From f80c3fd3b4387dc89d378b3903d4cf9711660dc3 Mon Sep 17 00:00:00 2001 From: Yuanhan Liu Date: Tue, 28 Jun 2016 11:58:30 +0800 Subject: [PATCH] vhost: fix not null terminated string Fix an issue raised by Coverity. >>> CID 127475: Memory - illegal accesses (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 108 bytes on >>> destination array "un->sun_path" of size 108 bytes might leave >>> the destination string unterminated. 441 strncpy(un->sun_path, path, sizeof(un->sun_path)); 442 443 return fd; 444 } Coverity issue: 127475 Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode") Reported-by: John McNamara Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost_user/vhost-net-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c b/lib/librte_vhost/vhost_user/vhost-net-user.c index 90cc127612..67303a43a8 100644 --- a/lib/librte_vhost/vhost_user/vhost-net-user.c +++ b/lib/librte_vhost/vhost_user/vhost-net-user.c @@ -439,6 +439,7 @@ create_unix_socket(const char *path, struct sockaddr_un *un, bool is_server) memset(un, 0, sizeof(*un)); un->sun_family = AF_UNIX; strncpy(un->sun_path, path, sizeof(un->sun_path)); + un->sun_path[sizeof(un->sun_path) - 1] = '\0'; return fd; } -- 2.20.1