From f819a1629b1ccc9ed74e17374e26507a490058ac Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Tue, 15 Feb 2022 11:07:58 +0000 Subject: [PATCH] crypto/ipsec_mb: remove useless check The qp is never NULL when it reaches the qp_setup_cleanup error handling code. This is due to checks earlier in the function that return an error if qp is NULL. Coverity issue: 375013 Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer dereference") Cc: stable@dpdk.org Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 1cf37e9836..7e8396b4a3 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -284,8 +284,6 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp == NULL) - return ret; #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM if (qp->mb_mgr) free_mb_mgr(qp->mb_mgr); -- 2.39.5