From fca922e8f602c5acc0c483296c769fd2a9efa48c Mon Sep 17 00:00:00 2001 From: Lance Richardson Date: Fri, 19 Jul 2019 11:49:04 +0530 Subject: [PATCH] net/bnxt: disable vector mode Tx with VLAN offload The vector mode transmit path does not currently support VLAN tag insertion, so we need to disable vector transmit when transmit VLAN insertion offload is enabled. Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index b336a234cc..ccec9684a8 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -734,13 +734,11 @@ bnxt_transmit_function(__rte_unused struct rte_eth_dev *eth_dev) { #ifdef RTE_ARCH_X86 /* - * Vector mode receive can be enabled only if scatter tx is not - * in use and tx offloads other than VLAN insertion are not - * in use. + * Vector mode transmit can be enabled only if not using scatter rx + * or tx offloads. */ if (!eth_dev->data->scattered_rx && - !(eth_dev->data->dev_conf.txmode.offloads & - ~DEV_TX_OFFLOAD_VLAN_INSERT)) { + !eth_dev->data->dev_conf.txmode.offloads) { PMD_DRV_LOG(INFO, "Using vector mode transmit for port %d\n", eth_dev->data->port_id); return bnxt_xmit_pkts_vec; -- 2.20.1