From fee720e9292529c08f6a80ed05bd47d559812916 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Wed, 8 Nov 2017 14:36:32 +0000 Subject: [PATCH] net/nfp: fix null pointer check First, the received pointer was not checked before. Then the pointer from malloc was not the one used in the existing check. Coverity issue: 195027 Fixes: ad60bca34899 ("net/nfp: read PF port MAC addr using NSP") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_nspu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_nspu.c b/drivers/net/nfp/nfp_nspu.c index 39d14e6acd..0b415fc4ab 100644 --- a/drivers/net/nfp/nfp_nspu.c +++ b/drivers/net/nfp/nfp_nspu.c @@ -618,10 +618,14 @@ nfp_nsp_eth_read_table(nspu_desc_t *desc, union eth_table_entry **table) { int ret; + if (!table) + return -EINVAL; + RTE_LOG(INFO, PMD, "Reading hw ethernet table...\n"); + /* port 0 allocates the eth table and read it using NSPU */ *table = malloc(NSP_ETH_TABLE_SIZE); - if (!table) + if (!*table) return -ENOMEM; ret = nspu_command(desc, NSP_CMD_READ_ETH_TABLE, 1, 0, *table, -- 2.20.1