From 24427bb914a6375f29635897d23a3192d85b2127 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Fri, 9 Sep 2016 11:42:08 +0200 Subject: [PATCH] app/testpmd: fix crash when mempool allocation fails Avoid access to mempool pointer if it is NULL. Coverity issue: 127553 Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code") Signed-off-by: Olivier Matz Acked-by: Pablo de Lara --- app/test-pmd/testpmd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 30749a4e8c..754de47782 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -443,10 +443,13 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf, mb_size, (unsigned) mb_mempool_cache, sizeof(struct rte_pktmbuf_pool_private), socket_id, 0); + if (rte_mp == NULL) + goto err; if (rte_mempool_populate_anon(rte_mp) == 0) { rte_mempool_free(rte_mp); rte_mp = NULL; + goto err; } rte_pktmbuf_pool_init(rte_mp, NULL); rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL); @@ -457,6 +460,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf, } } +err: if (rte_mp == NULL) { rte_exit(EXIT_FAILURE, "Creation of mbuf pool for socket %u failed: %s\n", -- 2.20.1