From 3bb262e2631d930812fda59f25c4eb0402f3b698 Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Fri, 24 Jun 2016 17:36:21 +0100 Subject: [PATCH] pdump: fix string overflow replaced strncpy with snprintf for safely copying the strings. Coverity issue: 127350 Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan Acked-by: John McNamara --- lib/librte_pdump/rte_pdump.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index e3b03a657e..ee566cb2f4 100644 --- a/lib/librte_pdump/rte_pdump.c +++ b/lib/librte_pdump/rte_pdump.c @@ -810,13 +810,15 @@ pdump_prepare_client_request(char *device, uint16_t queue, req.flags = flags; req.op = operation; if ((operation & ENABLE) != 0) { - strncpy(req.data.en_v1.device, device, strlen(device)); + snprintf(req.data.en_v1.device, sizeof(req.data.en_v1.device), + "%s", device); req.data.en_v1.queue = queue; req.data.en_v1.ring = ring; req.data.en_v1.mp = mp; req.data.en_v1.filter = filter; } else { - strncpy(req.data.dis_v1.device, device, strlen(device)); + snprintf(req.data.dis_v1.device, sizeof(req.data.dis_v1.device), + "%s", device); req.data.dis_v1.queue = queue; req.data.dis_v1.ring = NULL; req.data.dis_v1.mp = NULL; -- 2.20.1