From c9c7758dde16d9801349178d1c514a157b0738e2 Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Thu, 10 Nov 2016 16:29:40 +0000 Subject: [PATCH] pdump: fix log messages The ethdev Rx/Tx remove callback apis doesn't set rte_errno during failures, instead they just return negative error number, so using that number in logs instead of rte_errno upon Rx and Tx callback removal failures. Fixes: 278f9454 ("pdump: add new library for packet capture") Signed-off-by: Reshma Pattan Acked-by: John McNamara Acked-by: Pablo de Lara --- lib/librte_pdump/rte_pdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index 504a1ce5ed..596868374d 100644 --- a/lib/librte_pdump/rte_pdump.c +++ b/lib/librte_pdump/rte_pdump.c @@ -269,7 +269,7 @@ pdump_regitser_rx_callbacks(uint16_t end_q, uint8_t port, uint16_t queue, if (ret < 0) { RTE_LOG(ERR, PDUMP, "failed to remove rx callback, errno=%d\n", - rte_errno); + -ret); return ret; } cbs->cb = NULL; @@ -324,7 +324,7 @@ pdump_regitser_tx_callbacks(uint16_t end_q, uint8_t port, uint16_t queue, if (ret < 0) { RTE_LOG(ERR, PDUMP, "failed to remove tx callback, errno=%d\n", - rte_errno); + -ret); return ret; } cbs->cb = NULL; -- 2.20.1