From f229eb41eeecfc121600379046c7f11680739f1a Mon Sep 17 00:00:00 2001 From: Jianfeng Tan Date: Tue, 17 Jan 2017 07:10:21 +0000 Subject: [PATCH] net/virtio: fix rewriting LSC flag The LSC flag is decided according to if VIRTIO_NET_F_STATUS feature is negotiated. Copy the PCI info after the judgement will rewrite the correct result. Fixes: 198ab33677c9 ("net/virtio: move device initialization in a function") CC: stable@dpdk.org Signed-off-by: Jianfeng Tan Tested-by: Lei Yao Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 0a76cce21e..76d5fa97e5 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1208,18 +1208,17 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features) if (virtio_negotiate_features(hw, req_features) < 0) return -1; + if (eth_dev->device) { + pci_dev = RTE_DEV_TO_PCI(eth_dev->device); + rte_eth_copy_pci_info(eth_dev, pci_dev); + } + /* If host does not support status then disable LSC */ if (!vtpci_with_feature(hw, VIRTIO_NET_F_STATUS)) eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC; else eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC; - if (eth_dev->device) { - pci_dev = RTE_DEV_TO_PCI(eth_dev->device); - rte_eth_copy_pci_info(eth_dev, pci_dev); - eth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE; - } - rx_func_get(eth_dev); /* Setting up rx_header size for the device */ -- 2.20.1