drivers/net/bnxt/bnxt_flow.c

   1 /* SPDX-License-Identifier: BSD-3-Clause
   2  * Copyright(c) 2014-2018 Broadcom
   3  * All rights reserved.
   4  */
   5
   6 #include <sys/queue.h>
   7
   8 #include <rte_log.h>
   9 #include <rte_malloc.h>
  10 #include <rte_flow.h>
  11 #include <rte_flow_driver.h>
  12 #include <rte_tailq.h>
  13
  14 #include "bnxt.h"
  15 #include "bnxt_filter.h"
  16 #include "bnxt_hwrm.h"
  17 #include "bnxt_ring.h"
  18 #include "bnxt_rxq.h"
  19 #include "bnxt_vnic.h"
  20 #include "hsi_struct_def_dpdk.h"
  21
  22 static int
  23 bnxt_flow_args_validate(const struct rte_flow_attr *attr,
  24                         const struct rte_flow_item pattern[],
  25                         const struct rte_flow_action actions[],
  26                         struct rte_flow_error *error)
  27 {
  28         if (!pattern) {
  29                 rte_flow_error_set(error,
  30                                    EINVAL,
  31                                    RTE_FLOW_ERROR_TYPE_ITEM_NUM,
  32                                    NULL,
  33                                    "NULL pattern.");
  34                 return -rte_errno;
  35         }
  36
  37         if (!actions) {
  38                 rte_flow_error_set(error,
  39                                    EINVAL,
  40                                    RTE_FLOW_ERROR_TYPE_ACTION_NUM,
  41                                    NULL,
  42                                    "NULL action.");
  43                 return -rte_errno;
  44         }
  45
  46         if (!attr) {
  47                 rte_flow_error_set(error,
  48                                    EINVAL,
  49                                    RTE_FLOW_ERROR_TYPE_ATTR,
  50                                    NULL,
  51                                    "NULL attribute.");
  52                 return -rte_errno;
  53         }
  54
  55         return 0;
  56 }
  57
  58 static const struct rte_flow_item *
  59 bnxt_flow_non_void_item(const struct rte_flow_item *cur)
  60 {
  61         while (1) {
  62                 if (cur->type != RTE_FLOW_ITEM_TYPE_VOID)
  63                         return cur;
  64                 cur++;
  65         }
  66 }
  67
  68 static const struct rte_flow_action *
  69 bnxt_flow_non_void_action(const struct rte_flow_action *cur)
  70 {
  71         while (1) {
  72                 if (cur->type != RTE_FLOW_ACTION_TYPE_VOID)
  73                         return cur;
  74                 cur++;
  75         }
  76 }
  77
  78 static int
  79 bnxt_filter_type_check(const struct rte_flow_item pattern[],
  80                        struct rte_flow_error *error __rte_unused)
  81 {
  82         const struct rte_flow_item *item =
  83                 bnxt_flow_non_void_item(pattern);
  84         int use_ntuple = 1;
  85         bool has_vlan = 0;
  86
  87         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
  88                 switch (item->type) {
  89                 case RTE_FLOW_ITEM_TYPE_ANY:
  90                 case RTE_FLOW_ITEM_TYPE_ETH:
  91                         use_ntuple = 0;
  92                         break;
  93                 case RTE_FLOW_ITEM_TYPE_VLAN:
  94                         use_ntuple = 0;
  95                         has_vlan = 1;
  96                         break;
  97                 case RTE_FLOW_ITEM_TYPE_IPV4:
  98                 case RTE_FLOW_ITEM_TYPE_IPV6:
  99                 case RTE_FLOW_ITEM_TYPE_TCP:
 100                 case RTE_FLOW_ITEM_TYPE_UDP:
 101                         /* FALLTHROUGH */
 102                         /* need ntuple match, reset exact match */
 103                         use_ntuple |= 1;
 104                         break;
 105                 default:
 106                         PMD_DRV_LOG(DEBUG, "Unknown Flow type\n");
 107                         use_ntuple |= 0;
 108                 }
 109                 item++;
 110         }
 111
 112         if (has_vlan && use_ntuple) {
 113                 PMD_DRV_LOG(ERR,
 114                             "VLAN flow cannot use NTUPLE filter\n");
 115                 rte_flow_error_set(error, EINVAL,
 116                                    RTE_FLOW_ERROR_TYPE_ITEM,
 117                                    item,
 118                                    "Cannot use VLAN with NTUPLE");
 119                 return -rte_errno;
 120         }
 121
 122         return use_ntuple;
 123 }
 124
 125 static int
 126 bnxt_validate_and_parse_flow_type(struct bnxt *bp,
 127                                   const struct rte_flow_attr *attr,
 128                                   const struct rte_flow_item pattern[],
 129                                   struct rte_flow_error *error,
 130                                   struct bnxt_filter_info *filter)
 131 {
 132         const struct rte_flow_item *item = bnxt_flow_non_void_item(pattern);
 133         const struct rte_flow_item_vlan *vlan_spec, *vlan_mask;
 134         const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_mask;
 135         const struct rte_flow_item_ipv6 *ipv6_spec, *ipv6_mask;
 136         const struct rte_flow_item_tcp *tcp_spec, *tcp_mask;
 137         const struct rte_flow_item_udp *udp_spec, *udp_mask;
 138         const struct rte_flow_item_eth *eth_spec, *eth_mask;
 139         const struct rte_ether_addr *dst, *src;
 140         const struct rte_flow_item_nvgre *nvgre_spec;
 141         const struct rte_flow_item_nvgre *nvgre_mask;
 142         const struct rte_flow_item_gre *gre_spec;
 143         const struct rte_flow_item_gre *gre_mask;
 144         const struct rte_flow_item_vxlan *vxlan_spec;
 145         const struct rte_flow_item_vxlan *vxlan_mask;
 146         uint8_t vni_mask[] = {0xFF, 0xFF, 0xFF};
 147         uint8_t tni_mask[] = {0xFF, 0xFF, 0xFF};
 148         const struct rte_flow_item_vf *vf_spec;
 149         uint32_t tenant_id_be = 0, valid_flags = 0;
 150         bool vni_masked = 0;
 151         bool tni_masked = 0;
 152         uint32_t en_ethertype;
 153         uint8_t inner = 0;
 154         uint32_t vf = 0;
 155         uint32_t en = 0;
 156         int use_ntuple;
 157         int dflt_vnic;
 158
 159         use_ntuple = bnxt_filter_type_check(pattern, error);
 160         if (use_ntuple < 0)
 161                 return use_ntuple;
 162         PMD_DRV_LOG(DEBUG, "Use NTUPLE %d\n", use_ntuple);
 163
 164         filter->filter_type = use_ntuple ?
 165                 HWRM_CFA_NTUPLE_FILTER : HWRM_CFA_L2_FILTER;
 166         en_ethertype = use_ntuple ?
 167                 NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE :
 168                 EM_FLOW_ALLOC_INPUT_EN_ETHERTYPE;
 169
 170         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
 171                 if (item->last) {
 172                         /* last or range is NOT supported as match criteria */
 173                         rte_flow_error_set(error, EINVAL,
 174                                            RTE_FLOW_ERROR_TYPE_ITEM,
 175                                            item,
 176                                            "No support for range");
 177                         return -rte_errno;
 178                 }
 179
 180                 if (!item->spec || !item->mask) {
 181                         rte_flow_error_set(error, EINVAL,
 182                                            RTE_FLOW_ERROR_TYPE_ITEM,
 183                                            item,
 184                                            "spec/mask is NULL");
 185                         return -rte_errno;
 186                 }
 187
 188                 switch (item->type) {
 189                 case RTE_FLOW_ITEM_TYPE_ANY:
 190                         inner =
 191                         ((const struct rte_flow_item_any *)item->spec)->num > 3;
 192                         if (inner)
 193                                 PMD_DRV_LOG(DEBUG, "Parse inner header\n");
 194                         break;
 195                 case RTE_FLOW_ITEM_TYPE_ETH:
 196                         if (!item->spec || !item->mask)
 197                                 break;
 198
 199                         eth_spec = item->spec;
 200                         eth_mask = item->mask;
 201
 202                         /* Source MAC address mask cannot be partially set.
 203                          * Should be All 0's or all 1's.
 204                          * Destination MAC address mask must not be partially
 205                          * set. Should be all 1's or all 0's.
 206                          */
 207                         if ((!rte_is_zero_ether_addr(&eth_mask->src) &&
 208                              !rte_is_broadcast_ether_addr(&eth_mask->src)) ||
 209                             (!rte_is_zero_ether_addr(&eth_mask->dst) &&
 210                              !rte_is_broadcast_ether_addr(&eth_mask->dst))) {
 211                                 rte_flow_error_set(error,
 212                                                    EINVAL,
 213                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 214                                                    item,
 215                                                    "MAC_addr mask not valid");
 216                                 return -rte_errno;
 217                         }
 218
 219                         /* Mask is not allowed. Only exact matches are */
 220                         if (eth_mask->type &&
 221                             eth_mask->type != RTE_BE16(0xffff)) {
 222                                 rte_flow_error_set(error, EINVAL,
 223                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 224                                                    item,
 225                                                    "ethertype mask not valid");
 226                                 return -rte_errno;
 227                         }
 228
 229                         if (rte_is_broadcast_ether_addr(&eth_mask->dst)) {
 230                                 dst = &eth_spec->dst;
 231                                 if (!rte_is_valid_assigned_ether_addr(dst)) {
 232                                         rte_flow_error_set(error,
 233                                                            EINVAL,
 234                                                            RTE_FLOW_ERROR_TYPE_ITEM,
 235                                                            item,
 236                                                            "DMAC is invalid");
 237                                         PMD_DRV_LOG(ERR,
 238                                                     "DMAC is invalid!\n");
 239                                         return -rte_errno;
 240                                 }
 241                                 rte_memcpy(filter->dst_macaddr,
 242                                            &eth_spec->dst, RTE_ETHER_ADDR_LEN);
 243                                 en |= use_ntuple ?
 244                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :
 245                                         EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;
 246                                 valid_flags |= inner ?
 247                                         BNXT_FLOW_L2_INNER_DST_VALID_FLAG :
 248                                         BNXT_FLOW_L2_DST_VALID_FLAG;
 249                                 filter->priority = attr->priority;
 250                                 PMD_DRV_LOG(DEBUG,
 251                                             "Creating a priority flow\n");
 252                         }
 253                         if (rte_is_broadcast_ether_addr(&eth_mask->src)) {
 254                                 src = &eth_spec->src;
 255                                 if (!rte_is_valid_assigned_ether_addr(src)) {
 256                                         rte_flow_error_set(error,
 257                                                            EINVAL,
 258                                                            RTE_FLOW_ERROR_TYPE_ITEM,
 259                                                            item,
 260                                                            "SMAC is invalid");
 261                                         PMD_DRV_LOG(ERR,
 262                                                     "SMAC is invalid!\n");
 263                                         return -rte_errno;
 264                                 }
 265                                 rte_memcpy(filter->src_macaddr,
 266                                            &eth_spec->src, RTE_ETHER_ADDR_LEN);
 267                                 en |= use_ntuple ?
 268                                         NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
 269                                         EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;
 270                                 valid_flags |= inner ?
 271                                         BNXT_FLOW_L2_INNER_SRC_VALID_FLAG :
 272                                         BNXT_FLOW_L2_SRC_VALID_FLAG;
 273                         } /*
 274                            * else {
 275                            *  PMD_DRV_LOG(ERR, "Handle this condition\n");
 276                            * }
 277                            */
 278                         if (eth_mask->type) {
 279                                 filter->ethertype =
 280                                         rte_be_to_cpu_16(eth_spec->type);
 281                                 en |= en_ethertype;
 282                         }
 283                         if (inner)
 284                                 valid_flags |= BNXT_FLOW_PARSE_INNER_FLAG;
 285
 286                         break;
 287                 case RTE_FLOW_ITEM_TYPE_VLAN:
 288                         vlan_spec = item->spec;
 289                         vlan_mask = item->mask;
 290                         if (en & en_ethertype) {
 291                                 rte_flow_error_set(error, EINVAL,
 292                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 293                                                    item,
 294                                                    "VLAN TPID matching is not"
 295                                                    " supported");
 296                                 return -rte_errno;
 297                         }
 298                         if (vlan_mask->tci &&
 299                             vlan_mask->tci == RTE_BE16(0x0fff)) {
 300                                 /* Only the VLAN ID can be matched. */
 301                                 filter->l2_ovlan =
 302                                         rte_be_to_cpu_16(vlan_spec->tci &
 303                                                          RTE_BE16(0x0fff));
 304                                 en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
 305                         } else {
 306                                 rte_flow_error_set(error,
 307                                                    EINVAL,
 308                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 309                                                    item,
 310                                                    "VLAN mask is invalid");
 311                                 return -rte_errno;
 312                         }
 313                         if (vlan_mask->inner_type &&
 314                             vlan_mask->inner_type != RTE_BE16(0xffff)) {
 315                                 rte_flow_error_set(error, EINVAL,
 316                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 317                                                    item,
 318                                                    "inner ethertype mask not"
 319                                                    " valid");
 320                                 return -rte_errno;
 321                         }
 322                         if (vlan_mask->inner_type) {
 323                                 filter->ethertype =
 324                                         rte_be_to_cpu_16(vlan_spec->inner_type);
 325                                 en |= en_ethertype;
 326                         }
 327
 328                         break;
 329                 case RTE_FLOW_ITEM_TYPE_IPV4:
 330                         /* If mask is not involved, we could use EM filters. */
 331                         ipv4_spec = item->spec;
 332                         ipv4_mask = item->mask;
 333
 334                         if (!item->spec || !item->mask)
 335                                 break;
 336
 337                         /* Only IP DST and SRC fields are maskable. */
 338                         if (ipv4_mask->hdr.version_ihl ||
 339                             ipv4_mask->hdr.type_of_service ||
 340                             ipv4_mask->hdr.total_length ||
 341                             ipv4_mask->hdr.packet_id ||
 342                             ipv4_mask->hdr.fragment_offset ||
 343                             ipv4_mask->hdr.time_to_live ||
 344                             ipv4_mask->hdr.next_proto_id ||
 345                             ipv4_mask->hdr.hdr_checksum) {
 346                                 rte_flow_error_set(error,
 347                                                    EINVAL,
 348                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 349                                                    item,
 350                                                    "Invalid IPv4 mask.");
 351                                 return -rte_errno;
 352                         }
 353
 354                         filter->dst_ipaddr[0] = ipv4_spec->hdr.dst_addr;
 355                         filter->src_ipaddr[0] = ipv4_spec->hdr.src_addr;
 356
 357                         if (use_ntuple)
 358                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
 359                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
 360                         else
 361                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
 362                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
 363
 364                         if (ipv4_mask->hdr.src_addr) {
 365                                 filter->src_ipaddr_mask[0] =
 366                                         ipv4_mask->hdr.src_addr;
 367                                 en |= !use_ntuple ? 0 :
 368                                      NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
 369                         }
 370
 371                         if (ipv4_mask->hdr.dst_addr) {
 372                                 filter->dst_ipaddr_mask[0] =
 373                                         ipv4_mask->hdr.dst_addr;
 374                                 en |= !use_ntuple ? 0 :
 375                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
 376                         }
 377
 378                         filter->ip_addr_type = use_ntuple ?
 379                          HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_IP_ADDR_TYPE_IPV4 :
 380                          HWRM_CFA_EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
 381
 382                         if (ipv4_spec->hdr.next_proto_id) {
 383                                 filter->ip_protocol =
 384                                         ipv4_spec->hdr.next_proto_id;
 385                                 if (use_ntuple)
 386                                         en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
 387                                 else
 388                                         en |= EM_FLOW_ALLOC_INPUT_EN_IP_PROTO;
 389                         }
 390                         break;
 391                 case RTE_FLOW_ITEM_TYPE_IPV6:
 392                         ipv6_spec = item->spec;
 393                         ipv6_mask = item->mask;
 394
 395                         if (!item->spec || !item->mask)
 396                                 break;
 397
 398                         /* Only IP DST and SRC fields are maskable. */
 399                         if (ipv6_mask->hdr.vtc_flow ||
 400                             ipv6_mask->hdr.payload_len ||
 401                             ipv6_mask->hdr.proto ||
 402                             ipv6_mask->hdr.hop_limits) {
 403                                 rte_flow_error_set(error,
 404                                                    EINVAL,
 405                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 406                                                    item,
 407                                                    "Invalid IPv6 mask.");
 408                                 return -rte_errno;
 409                         }
 410
 411                         if (use_ntuple)
 412                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
 413                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
 414                         else
 415                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
 416                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
 417
 418                         rte_memcpy(filter->src_ipaddr,
 419                                    ipv6_spec->hdr.src_addr, 16);
 420                         rte_memcpy(filter->dst_ipaddr,
 421                                    ipv6_spec->hdr.dst_addr, 16);
 422
 423                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr,
 424                                                    16)) {
 425                                 rte_memcpy(filter->src_ipaddr_mask,
 426                                            ipv6_mask->hdr.src_addr, 16);
 427                                 en |= !use_ntuple ? 0 :
 428                                     NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
 429                         }
 430
 431                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr,
 432                                                    16)) {
 433                                 rte_memcpy(filter->dst_ipaddr_mask,
 434                                            ipv6_mask->hdr.dst_addr, 16);
 435                                 en |= !use_ntuple ? 0 :
 436                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
 437                         }
 438
 439                         filter->ip_addr_type = use_ntuple ?
 440                                 NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6 :
 441                                 EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
 442                         break;
 443                 case RTE_FLOW_ITEM_TYPE_TCP:
 444                         tcp_spec = item->spec;
 445                         tcp_mask = item->mask;
 446
 447                         if (!item->spec || !item->mask)
 448                                 break;
 449
 450                         /* Check TCP mask. Only DST & SRC ports are maskable */
 451                         if (tcp_mask->hdr.sent_seq ||
 452                             tcp_mask->hdr.recv_ack ||
 453                             tcp_mask->hdr.data_off ||
 454                             tcp_mask->hdr.tcp_flags ||
 455                             tcp_mask->hdr.rx_win ||
 456                             tcp_mask->hdr.cksum ||
 457                             tcp_mask->hdr.tcp_urp) {
 458                                 rte_flow_error_set(error,
 459                                                    EINVAL,
 460                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 461                                                    item,
 462                                                    "Invalid TCP mask");
 463                                 return -rte_errno;
 464                         }
 465
 466                         filter->src_port = tcp_spec->hdr.src_port;
 467                         filter->dst_port = tcp_spec->hdr.dst_port;
 468
 469                         if (use_ntuple)
 470                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
 471                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
 472                         else
 473                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
 474                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
 475
 476                         if (tcp_mask->hdr.dst_port) {
 477                                 filter->dst_port_mask = tcp_mask->hdr.dst_port;
 478                                 en |= !use_ntuple ? 0 :
 479                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
 480                         }
 481
 482                         if (tcp_mask->hdr.src_port) {
 483                                 filter->src_port_mask = tcp_mask->hdr.src_port;
 484                                 en |= !use_ntuple ? 0 :
 485                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
 486                         }
 487                         break;
 488                 case RTE_FLOW_ITEM_TYPE_UDP:
 489                         udp_spec = item->spec;
 490                         udp_mask = item->mask;
 491
 492                         if (!item->spec || !item->mask)
 493                                 break;
 494
 495                         if (udp_mask->hdr.dgram_len ||
 496                             udp_mask->hdr.dgram_cksum) {
 497                                 rte_flow_error_set(error,
 498                                                    EINVAL,
 499                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 500                                                    item,
 501                                                    "Invalid UDP mask");
 502                                 return -rte_errno;
 503                         }
 504
 505                         filter->src_port = udp_spec->hdr.src_port;
 506                         filter->dst_port = udp_spec->hdr.dst_port;
 507
 508                         if (use_ntuple)
 509                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
 510                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
 511                         else
 512                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
 513                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
 514
 515                         if (udp_mask->hdr.dst_port) {
 516                                 filter->dst_port_mask = udp_mask->hdr.dst_port;
 517                                 en |= !use_ntuple ? 0 :
 518                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
 519                         }
 520
 521                         if (udp_mask->hdr.src_port) {
 522                                 filter->src_port_mask = udp_mask->hdr.src_port;
 523                                 en |= !use_ntuple ? 0 :
 524                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
 525                         }
 526                         break;
 527                 case RTE_FLOW_ITEM_TYPE_VXLAN:
 528                         vxlan_spec = item->spec;
 529                         vxlan_mask = item->mask;
 530                         /* Check if VXLAN item is used to describe protocol.
 531                          * If yes, both spec and mask should be NULL.
 532                          * If no, both spec and mask shouldn't be NULL.
 533                          */
 534                         if ((!vxlan_spec && vxlan_mask) ||
 535                             (vxlan_spec && !vxlan_mask)) {
 536                                 rte_flow_error_set(error,
 537                                                    EINVAL,
 538                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 539                                                    item,
 540                                                    "Invalid VXLAN item");
 541                                 return -rte_errno;
 542                         }
 543
 544                         if (!vxlan_spec && !vxlan_mask) {
 545                                 filter->tunnel_type =
 546                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
 547                                 break;
 548                         }
 549
 550                         if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
 551                             vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
 552                             vxlan_spec->flags != 0x8) {
 553                                 rte_flow_error_set(error,
 554                                                    EINVAL,
 555                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 556                                                    item,
 557                                                    "Invalid VXLAN item");
 558                                 return -rte_errno;
 559                         }
 560
 561                         /* Check if VNI is masked. */
 562                         if (vxlan_spec && vxlan_mask) {
 563                                 vni_masked =
 564                                         !!memcmp(vxlan_mask->vni, vni_mask,
 565                                                  RTE_DIM(vni_mask));
 566                                 if (vni_masked) {
 567                                         rte_flow_error_set
 568                                                 (error,
 569                                                  EINVAL,
 570                                                  RTE_FLOW_ERROR_TYPE_ITEM,
 571                                                  item,
 572                                                  "Invalid VNI mask");
 573                                         return -rte_errno;
 574                                 }
 575
 576                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
 577                                            vxlan_spec->vni, 3);
 578                                 filter->vni =
 579                                         rte_be_to_cpu_32(tenant_id_be);
 580                                 filter->tunnel_type =
 581                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
 582                         }
 583                         break;
 584                 case RTE_FLOW_ITEM_TYPE_NVGRE:
 585                         nvgre_spec = item->spec;
 586                         nvgre_mask = item->mask;
 587                         /* Check if NVGRE item is used to describe protocol.
 588                          * If yes, both spec and mask should be NULL.
 589                          * If no, both spec and mask shouldn't be NULL.
 590                          */
 591                         if ((!nvgre_spec && nvgre_mask) ||
 592                             (nvgre_spec && !nvgre_mask)) {
 593                                 rte_flow_error_set(error,
 594                                                    EINVAL,
 595                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 596                                                    item,
 597                                                    "Invalid NVGRE item");
 598                                 return -rte_errno;
 599                         }
 600
 601                         if (!nvgre_spec && !nvgre_mask) {
 602                                 filter->tunnel_type =
 603                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
 604                                 break;
 605                         }
 606
 607                         if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 ||
 608                             nvgre_spec->protocol != 0x6558) {
 609                                 rte_flow_error_set(error,
 610                                                    EINVAL,
 611                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 612                                                    item,
 613                                                    "Invalid NVGRE item");
 614                                 return -rte_errno;
 615                         }
 616
 617                         if (nvgre_spec && nvgre_mask) {
 618                                 tni_masked =
 619                                         !!memcmp(nvgre_mask->tni, tni_mask,
 620                                                  RTE_DIM(tni_mask));
 621                                 if (tni_masked) {
 622                                         rte_flow_error_set
 623                                                 (error,
 624                                                  EINVAL,
 625                                                  RTE_FLOW_ERROR_TYPE_ITEM,
 626                                                  item,
 627                                                  "Invalid TNI mask");
 628                                         return -rte_errno;
 629                                 }
 630                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
 631                                            nvgre_spec->tni, 3);
 632                                 filter->vni =
 633                                         rte_be_to_cpu_32(tenant_id_be);
 634                                 filter->tunnel_type =
 635                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
 636                         }
 637                         break;
 638
 639                 case RTE_FLOW_ITEM_TYPE_GRE:
 640                         gre_spec = (const struct rte_flow_item_gre *)item->spec;
 641                         gre_mask = (const struct rte_flow_item_gre *)item->mask;
 642
 643                         /*
 644                          *Check if GRE item is used to describe protocol.
 645                          * If yes, both spec and mask should be NULL.
 646                          * If no, both spec and mask shouldn't be NULL.
 647                          */
 648                         if (!!gre_spec ^ !!gre_mask) {
 649                                 rte_flow_error_set(error, EINVAL,
 650                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 651                                                    item,
 652                                                    "Invalid GRE item");
 653                                 return -rte_errno;
 654                         }
 655
 656                         if (!gre_spec && !gre_mask) {
 657                                 filter->tunnel_type =
 658                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE;
 659                                 break;
 660                         }
 661                         break;
 662
 663                 case RTE_FLOW_ITEM_TYPE_VF:
 664                         vf_spec = item->spec;
 665                         vf = vf_spec->id;
 666                         if (!BNXT_PF(bp)) {
 667                                 rte_flow_error_set(error,
 668                                                    EINVAL,
 669                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 670                                                    item,
 671                                                    "Configuring on a VF!");
 672                                 return -rte_errno;
 673                         }
 674
 675                         if (vf >= bp->pdev->max_vfs) {
 676                                 rte_flow_error_set(error,
 677                                                    EINVAL,
 678                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 679                                                    item,
 680                                                    "Incorrect VF id!");
 681                                 return -rte_errno;
 682                         }
 683
 684                         if (!attr->transfer) {
 685                                 rte_flow_error_set(error,
 686                                                    ENOTSUP,
 687                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 688                                                    item,
 689                                                    "Matching VF traffic without"
 690                                                    " affecting it (transfer attribute)"
 691                                                    " is unsupported");
 692                                 return -rte_errno;
 693                         }
 694
 695                         filter->mirror_vnic_id =
 696                         dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
 697                         if (dflt_vnic < 0) {
 698                                 /* This simply indicates there's no driver
 699                                  * loaded. This is not an error.
 700                                  */
 701                                 rte_flow_error_set
 702                                         (error,
 703                                          EINVAL,
 704                                          RTE_FLOW_ERROR_TYPE_ITEM,
 705                                          item,
 706                                          "Unable to get default VNIC for VF");
 707                                 return -rte_errno;
 708                         }
 709
 710                         filter->mirror_vnic_id = dflt_vnic;
 711                         en |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
 712                         break;
 713                 default:
 714                         break;
 715                 }
 716                 item++;
 717         }
 718         filter->enables = en;
 719         filter->valid_flags = valid_flags;
 720
 721         return 0;
 722 }
 723
 724 /* Parse attributes */
 725 static int
 726 bnxt_flow_parse_attr(const struct rte_flow_attr *attr,
 727                      struct rte_flow_error *error)
 728 {
 729         /* Must be input direction */
 730         if (!attr->ingress) {
 731                 rte_flow_error_set(error,
 732                                    EINVAL,
 733                                    RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
 734                                    attr,
 735                                    "Only support ingress.");
 736                 return -rte_errno;
 737         }
 738
 739         /* Not supported */
 740         if (attr->egress) {
 741                 rte_flow_error_set(error,
 742                                    EINVAL,
 743                                    RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
 744                                    attr,
 745                                    "No support for egress.");
 746                 return -rte_errno;
 747         }
 748
 749         return 0;
 750 }
 751
 752 static struct bnxt_filter_info *
 753 bnxt_find_matching_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
 754 {
 755         struct bnxt_filter_info *mf, *f0;
 756         struct bnxt_vnic_info *vnic0;
 757         struct rte_flow *flow;
 758         int i;
 759
 760         vnic0 = &bp->vnic_info[0];
 761         f0 = STAILQ_FIRST(&vnic0->filter);
 762
 763         /* This flow has same DST MAC as the port/l2 filter. */
 764         if (memcmp(f0->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN) == 0)
 765                 return f0;
 766
 767         for (i = bp->max_vnics - 1; i >= 0; i--) {
 768                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
 769
 770                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
 771                         continue;
 772
 773                 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
 774                         mf = flow->filter;
 775
 776                         if (mf->matching_l2_fltr_ptr)
 777                                 continue;
 778
 779                         if (mf->ethertype == nf->ethertype &&
 780                             mf->l2_ovlan == nf->l2_ovlan &&
 781                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
 782                             mf->l2_ivlan == nf->l2_ivlan &&
 783                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
 784                             !memcmp(mf->src_macaddr, nf->src_macaddr,
 785                                     RTE_ETHER_ADDR_LEN) &&
 786                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
 787                                     RTE_ETHER_ADDR_LEN))
 788                                 return mf;
 789                 }
 790         }
 791         return NULL;
 792 }
 793
 794 static struct bnxt_filter_info *
 795 bnxt_create_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
 796                       struct bnxt_vnic_info *vnic)
 797 {
 798         struct bnxt_filter_info *filter1;
 799         int rc;
 800
 801         /* Alloc new L2 filter.
 802          * This flow needs MAC filter which does not match any existing
 803          * L2 filters.
 804          */
 805         filter1 = bnxt_get_unused_filter(bp);
 806         if (filter1 == NULL)
 807                 return NULL;
 808
 809         filter1->flags = HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_XDP_DISABLE;
 810         filter1->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX;
 811         if (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
 812             nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG) {
 813                 filter1->flags |=
 814                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
 815                 PMD_DRV_LOG(DEBUG, "Create Outer filter\n");
 816         }
 817
 818         if (nf->filter_type == HWRM_CFA_L2_FILTER &&
 819             (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
 820              nf->valid_flags & BNXT_FLOW_L2_INNER_SRC_VALID_FLAG)) {
 821                 PMD_DRV_LOG(DEBUG, "Create L2 filter for SRC MAC\n");
 822                 filter1->flags |=
 823                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_SOURCE_VALID;
 824                 memcpy(filter1->l2_addr, nf->src_macaddr, RTE_ETHER_ADDR_LEN);
 825         } else {
 826                 PMD_DRV_LOG(DEBUG, "Create L2 filter for DST MAC\n");
 827                 memcpy(filter1->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN);
 828         }
 829
 830         if (nf->priority &&
 831             (nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG ||
 832              nf->valid_flags & BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
 833                 /* Tell the FW where to place the filter in the table. */
 834                 if (nf->priority > 65535) {
 835                         filter1->pri_hint =
 836                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_PRI_HINT_BELOW_FILTER;
 837                         /* This will place the filter in TCAM */
 838                         filter1->l2_filter_id_hint = (uint64_t)-1;
 839                 }
 840         }
 841
 842         if (nf->valid_flags & (BNXT_FLOW_L2_DST_VALID_FLAG |
 843                                BNXT_FLOW_L2_SRC_VALID_FLAG |
 844                                BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
 845                                BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
 846                 filter1->enables =
 847                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |
 848                         L2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK;
 849                 memset(filter1->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
 850         }
 851
 852         if (nf->valid_flags & BNXT_FLOW_L2_DROP_FLAG) {
 853                 filter1->flags |=
 854                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_DROP;
 855                 if (nf->ethertype == RTE_ETHER_TYPE_IPV4) {
 856                         /* Num VLANs for drop filter will/should be 0.
 857                          * If the req is memset to 0, then the count will
 858                          * be automatically set to 0.
 859                          */
 860                         if (nf->valid_flags & BNXT_FLOW_PARSE_INNER_FLAG) {
 861                                 filter1->enables |=
 862                                         L2_FILTER_ALLOC_INPUT_EN_T_NUM_VLANS;
 863                         } else {
 864                                 filter1->enables |=
 865                                         L2_FILTER_ALLOC_INPUT_EN_NUM_VLANS;
 866                                 filter1->flags |=
 867                                 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
 868                         }
 869                 }
 870         }
 871
 872         rc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id,
 873                                      filter1);
 874         if (rc) {
 875                 bnxt_free_filter(bp, filter1);
 876                 return NULL;
 877         }
 878         filter1->l2_ref_cnt++;
 879         return filter1;
 880 }
 881
 882 struct bnxt_filter_info *
 883 bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
 884                    struct bnxt_vnic_info *vnic)
 885 {
 886         struct bnxt_filter_info *l2_filter = NULL;
 887
 888         l2_filter = bnxt_find_matching_l2_filter(bp, nf);
 889         if (l2_filter) {
 890                 l2_filter->l2_ref_cnt++;
 891                 nf->matching_l2_fltr_ptr = l2_filter;
 892         } else {
 893                 l2_filter = bnxt_create_l2_filter(bp, nf, vnic);
 894                 nf->matching_l2_fltr_ptr = NULL;
 895         }
 896
 897         return l2_filter;
 898 }
 899
 900 static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic)
 901 {
 902         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
 903         uint64_t rx_offloads = dev_conf->rxmode.offloads;
 904         int rc;
 905
 906         rc = bnxt_vnic_grp_alloc(bp, vnic);
 907         if (rc)
 908                 goto ret;
 909
 910         rc = bnxt_hwrm_vnic_alloc(bp, vnic);
 911         if (rc) {
 912                 PMD_DRV_LOG(ERR, "HWRM vnic alloc failure rc: %x\n", rc);
 913                 goto ret;
 914         }
 915         bp->nr_vnics++;
 916
 917         /* RSS context is required only when there is more than one RSS ring */
 918         if (vnic->rx_queue_cnt > 1) {
 919                 rc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, 0 /* ctx_idx 0 */);
 920                 if (rc) {
 921                         PMD_DRV_LOG(ERR,
 922                                     "HWRM vnic ctx alloc failure: %x\n", rc);
 923                         goto ret;
 924                 }
 925         } else {
 926                 PMD_DRV_LOG(DEBUG, "No RSS context required\n");
 927         }
 928
 929         if (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
 930                 vnic->vlan_strip = true;
 931         else
 932                 vnic->vlan_strip = false;
 933
 934         rc = bnxt_hwrm_vnic_cfg(bp, vnic);
 935         if (rc)
 936                 goto ret;
 937
 938         bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
 939
 940 ret:
 941         return rc;
 942 }
 943
 944 static int match_vnic_rss_cfg(struct bnxt *bp,
 945                               struct bnxt_vnic_info *vnic,
 946                               const struct rte_flow_action_rss *rss)
 947 {
 948         unsigned int match = 0, i;
 949
 950         if (vnic->rx_queue_cnt != rss->queue_num)
 951                 return -EINVAL;
 952
 953         for (i = 0; i < rss->queue_num; i++) {
 954                 if (!bp->rx_queues[rss->queue[i]]->vnic->rx_queue_cnt &&
 955                     !bp->rx_queues[rss->queue[i]]->rx_started)
 956                         return -EINVAL;
 957         }
 958
 959         for (i = 0; i < vnic->rx_queue_cnt; i++) {
 960                 int j;
 961
 962                 for (j = 0; j < vnic->rx_queue_cnt; j++) {
 963                         if (bp->grp_info[rss->queue[i]].fw_grp_id ==
 964                             vnic->fw_grp_ids[j])
 965                                 match++;
 966                 }
 967         }
 968
 969         if (match != vnic->rx_queue_cnt) {
 970                 PMD_DRV_LOG(ERR,
 971                             "VNIC queue count %d vs queues matched %d\n",
 972                             match, vnic->rx_queue_cnt);
 973                 return -EINVAL;
 974         }
 975
 976         return 0;
 977 }
 978
 979 static void
 980 bnxt_update_filter_flags_en(struct bnxt_filter_info *filter,
 981                             struct bnxt_filter_info *filter1,
 982                             int use_ntuple)
 983 {
 984         if (!use_ntuple &&
 985             !(filter->valid_flags &
 986               ~(BNXT_FLOW_L2_DST_VALID_FLAG |
 987                 BNXT_FLOW_L2_SRC_VALID_FLAG |
 988                 BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
 989                 BNXT_FLOW_L2_INNER_DST_VALID_FLAG |
 990                 BNXT_FLOW_L2_DROP_FLAG |
 991                 BNXT_FLOW_PARSE_INNER_FLAG))) {
 992                 filter->flags = filter1->flags;
 993                 filter->enables = filter1->enables;
 994                 filter->filter_type = HWRM_CFA_L2_FILTER;
 995                 memcpy(filter->l2_addr, filter1->l2_addr, RTE_ETHER_ADDR_LEN);
 996                 memset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
 997                 filter->pri_hint = filter1->pri_hint;
 998                 filter->l2_filter_id_hint = filter1->l2_filter_id_hint;
 999         }
1000         filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1001         filter->l2_ref_cnt = filter1->l2_ref_cnt;
1002         PMD_DRV_LOG(DEBUG,
1003                 "l2_filter: %p fw_l2_filter_id %" PRIx64 " l2_ref_cnt %u\n",
1004                 filter1, filter->fw_l2_filter_id, filter->l2_ref_cnt);
1005 }
1006
1007 static int
1008 bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
1009                              const struct rte_flow_item pattern[],
1010                              const struct rte_flow_action actions[],
1011                              const struct rte_flow_attr *attr,
1012                              struct rte_flow_error *error,
1013                              struct bnxt_filter_info *filter)
1014 {
1015         const struct rte_flow_action *act =
1016                 bnxt_flow_non_void_action(actions);
1017         struct bnxt *bp = dev->data->dev_private;
1018         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
1019         struct bnxt_vnic_info *vnic = NULL, *vnic0 = NULL;
1020         const struct rte_flow_action_queue *act_q;
1021         const struct rte_flow_action_vf *act_vf;
1022         struct bnxt_filter_info *filter1 = NULL;
1023         const struct rte_flow_action_rss *rss;
1024         struct bnxt_rx_queue *rxq = NULL;
1025         int dflt_vnic, vnic_id;
1026         unsigned int rss_idx;
1027         uint32_t vf = 0, i;
1028         int rc, use_ntuple;
1029
1030         rc =
1031         bnxt_validate_and_parse_flow_type(bp, attr, pattern, error, filter);
1032         if (rc != 0)
1033                 goto ret;
1034
1035         rc = bnxt_flow_parse_attr(attr, error);
1036         if (rc != 0)
1037                 goto ret;
1038
1039         /* Since we support ingress attribute only - right now. */
1040         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1041                 filter->flags = HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_PATH_RX;
1042
1043         use_ntuple = bnxt_filter_type_check(pattern, error);
1044         switch (act->type) {
1045         case RTE_FLOW_ACTION_TYPE_QUEUE:
1046                 /* Allow this flow. Redirect to a VNIC. */
1047                 act_q = (const struct rte_flow_action_queue *)act->conf;
1048                 if (!act_q->index || act_q->index >= bp->rx_nr_rings) {
1049                         rte_flow_error_set(error,
1050                                            EINVAL,
1051                                            RTE_FLOW_ERROR_TYPE_ACTION,
1052                                            act,
1053                                            "Invalid queue ID.");
1054                         rc = -rte_errno;
1055                         goto ret;
1056                 }
1057                 PMD_DRV_LOG(DEBUG, "Queue index %d\n", act_q->index);
1058
1059                 vnic_id = attr->group;
1060                 if (!vnic_id) {
1061                         PMD_DRV_LOG(DEBUG, "Group id is 0\n");
1062                         vnic_id = act_q->index;
1063                 }
1064
1065                 vnic = &bp->vnic_info[vnic_id];
1066                 if (vnic == NULL) {
1067                         rte_flow_error_set(error,
1068                                            EINVAL,
1069                                            RTE_FLOW_ERROR_TYPE_ACTION,
1070                                            act,
1071                                            "No matching VNIC found.");
1072                         rc = -rte_errno;
1073                         goto ret;
1074                 }
1075                 if (vnic->rx_queue_cnt) {
1076                         if (vnic->start_grp_id != act_q->index) {
1077                                 PMD_DRV_LOG(ERR,
1078                                             "VNIC already in use\n");
1079                                 rte_flow_error_set(error,
1080                                                    EINVAL,
1081                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1082                                                    act,
1083                                                    "VNIC already in use");
1084                                 rc = -rte_errno;
1085                                 goto ret;
1086                         }
1087                         goto use_vnic;
1088                 }
1089
1090                 rxq = bp->rx_queues[act_q->index];
1091
1092                 if (!(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS) && rxq &&
1093                     vnic->fw_vnic_id != INVALID_HW_RING_ID)
1094                         goto use_vnic;
1095
1096                 if (!rxq) {
1097                         PMD_DRV_LOG(ERR,
1098                                     "Queue invalid or used with other VNIC\n");
1099                         rte_flow_error_set(error,
1100                                            EINVAL,
1101                                            RTE_FLOW_ERROR_TYPE_ACTION,
1102                                            act,
1103                                            "Queue invalid queue or in use");
1104                         rc = -rte_errno;
1105                         goto ret;
1106                 }
1107
1108                 rxq->vnic = vnic;
1109                 rxq->rx_started = 1;
1110                 vnic->rx_queue_cnt++;
1111                 vnic->start_grp_id = act_q->index;
1112                 vnic->end_grp_id = act_q->index;
1113                 vnic->func_default = 0; //This is not a default VNIC.
1114
1115                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1116
1117                 rc = bnxt_vnic_prep(bp, vnic);
1118                 if (rc)  {
1119                         rte_flow_error_set(error,
1120                                            EINVAL,
1121                                            RTE_FLOW_ERROR_TYPE_ACTION,
1122                                            act,
1123                                            "VNIC prep fail");
1124                         rc = -rte_errno;
1125                         goto ret;
1126                 }
1127
1128                 PMD_DRV_LOG(DEBUG,
1129                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1130                             act_q->index, vnic, vnic->fw_grp_ids);
1131
1132 use_vnic:
1133                 vnic->ff_pool_idx = vnic_id;
1134                 PMD_DRV_LOG(DEBUG,
1135                             "Setting vnic ff_idx %d\n", vnic->ff_pool_idx);
1136                 filter->dst_id = vnic->fw_vnic_id;
1137                 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1138                 if (filter1 == NULL) {
1139                         rte_flow_error_set(error,
1140                                            ENOSPC,
1141                                            RTE_FLOW_ERROR_TYPE_ACTION,
1142                                            act,
1143                                            "Filter not available");
1144                         rc = -rte_errno;
1145                         goto ret;
1146                 }
1147
1148                 PMD_DRV_LOG(DEBUG, "new fltr: %p l2fltr: %p l2_ref_cnt: %d\n",
1149                             filter, filter1, filter1->l2_ref_cnt);
1150                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1151                 break;
1152         case RTE_FLOW_ACTION_TYPE_DROP:
1153                 vnic0 = &bp->vnic_info[0];
1154                 filter->dst_id = vnic0->fw_vnic_id;
1155                 filter->valid_flags |= BNXT_FLOW_L2_DROP_FLAG;
1156                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1157                 if (filter1 == NULL) {
1158                         rte_flow_error_set(error,
1159                                            ENOSPC,
1160                                            RTE_FLOW_ERROR_TYPE_ACTION,
1161                                            act,
1162                                            "Filter not available");
1163                         rc = -rte_errno;
1164                         goto ret;
1165                 }
1166
1167                 if (filter->filter_type == HWRM_CFA_EM_FILTER)
1168                         filter->flags =
1169                                 HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_DROP;
1170                 else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1171                         filter->flags =
1172                                 HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
1173
1174                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1175                 break;
1176         case RTE_FLOW_ACTION_TYPE_COUNT:
1177                 vnic0 = &bp->vnic_info[0];
1178                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1179                 if (filter1 == NULL) {
1180                         rte_flow_error_set(error,
1181                                            ENOSPC,
1182                                            RTE_FLOW_ERROR_TYPE_ACTION,
1183                                            act,
1184                                            "New filter not available");
1185                         rc = -rte_errno;
1186                         goto ret;
1187                 }
1188
1189                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1190                 filter->flags = HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_METER;
1191                 break;
1192         case RTE_FLOW_ACTION_TYPE_VF:
1193                 act_vf = (const struct rte_flow_action_vf *)act->conf;
1194                 vf = act_vf->id;
1195
1196                 if (filter->tunnel_type ==
1197                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN ||
1198                     filter->tunnel_type ==
1199                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE) {
1200                         /* If issued on a VF, ensure id is 0 and is trusted */
1201                         if (BNXT_VF(bp)) {
1202                                 if (!BNXT_VF_IS_TRUSTED(bp) || vf) {
1203                                         rte_flow_error_set(error, EINVAL,
1204                                                 RTE_FLOW_ERROR_TYPE_ACTION,
1205                                                 act,
1206                                                 "Incorrect VF");
1207                                         rc = -rte_errno;
1208                                         goto ret;
1209                                 }
1210                         }
1211
1212                         filter->enables |= filter->tunnel_type;
1213                         filter->filter_type = HWRM_CFA_TUNNEL_REDIRECT_FILTER;
1214                         goto done;
1215                 }
1216
1217                 if (vf >= bp->pdev->max_vfs) {
1218                         rte_flow_error_set(error,
1219                                            EINVAL,
1220                                            RTE_FLOW_ERROR_TYPE_ACTION,
1221                                            act,
1222                                            "Incorrect VF id!");
1223                         rc = -rte_errno;
1224                         goto ret;
1225                 }
1226
1227                 filter->mirror_vnic_id =
1228                 dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
1229                 if (dflt_vnic < 0) {
1230                         /* This simply indicates there's no driver loaded.
1231                          * This is not an error.
1232                          */
1233                         rte_flow_error_set(error,
1234                                            EINVAL,
1235                                            RTE_FLOW_ERROR_TYPE_ACTION,
1236                                            act,
1237                                            "Unable to get default VNIC for VF");
1238                         rc = -rte_errno;
1239                         goto ret;
1240                 }
1241
1242                 filter->mirror_vnic_id = dflt_vnic;
1243                 filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
1244
1245                 vnic0 = &bp->vnic_info[0];
1246                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1247                 if (filter1 == NULL) {
1248                         rte_flow_error_set(error,
1249                                            ENOSPC,
1250                                            RTE_FLOW_ERROR_TYPE_ACTION,
1251                                            act,
1252                                            "New filter not available");
1253                         rc = -rte_errno;
1254                         goto ret;
1255                 }
1256
1257                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1258                 break;
1259         case RTE_FLOW_ACTION_TYPE_RSS:
1260                 rss = (const struct rte_flow_action_rss *)act->conf;
1261
1262                 vnic_id = attr->group;
1263                 if (!vnic_id) {
1264                         PMD_DRV_LOG(ERR, "Group id cannot be 0\n");
1265                         rte_flow_error_set(error,
1266                                            EINVAL,
1267                                            RTE_FLOW_ERROR_TYPE_ATTR,
1268                                            NULL,
1269                                            "Group id cannot be 0");
1270                         rc = -rte_errno;
1271                         goto ret;
1272                 }
1273
1274                 vnic = &bp->vnic_info[vnic_id];
1275                 if (vnic == NULL) {
1276                         rte_flow_error_set(error,
1277                                            EINVAL,
1278                                            RTE_FLOW_ERROR_TYPE_ACTION,
1279                                            act,
1280                                            "No matching VNIC for RSS group.");
1281                         rc = -rte_errno;
1282                         goto ret;
1283                 }
1284                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1285
1286                 /* Check if requested RSS config matches RSS config of VNIC
1287                  * only if it is not a fresh VNIC configuration.
1288                  * Otherwise the existing VNIC configuration can be used.
1289                  */
1290                 if (vnic->rx_queue_cnt) {
1291                         rc = match_vnic_rss_cfg(bp, vnic, rss);
1292                         if (rc) {
1293                                 PMD_DRV_LOG(ERR,
1294                                             "VNIC and RSS config mismatch\n");
1295                                 rte_flow_error_set(error,
1296                                                    EINVAL,
1297                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1298                                                    act,
1299                                                    "VNIC and RSS cfg mismatch");
1300                                 rc = -rte_errno;
1301                                 goto ret;
1302                         }
1303                         goto vnic_found;
1304                 }
1305
1306                 for (i = 0; i < rss->queue_num; i++) {
1307                         PMD_DRV_LOG(DEBUG, "RSS action Queue %d\n",
1308                                     rss->queue[i]);
1309
1310                         if (!rss->queue[i] ||
1311                             rss->queue[i] >= bp->rx_nr_rings ||
1312                             !bp->rx_queues[rss->queue[i]]) {
1313                                 rte_flow_error_set(error,
1314                                                    EINVAL,
1315                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1316                                                    act,
1317                                                    "Invalid queue ID for RSS");
1318                                 rc = -rte_errno;
1319                                 goto ret;
1320                         }
1321                         rxq = bp->rx_queues[rss->queue[i]];
1322
1323                         if (bp->vnic_info[0].fw_grp_ids[rss->queue[i]] !=
1324                             INVALID_HW_RING_ID) {
1325                                 PMD_DRV_LOG(ERR,
1326                                             "queue active with other VNIC\n");
1327                                 rte_flow_error_set(error,
1328                                                    EINVAL,
1329                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1330                                                    act,
1331                                                    "Invalid queue ID for RSS");
1332                                 rc = -rte_errno;
1333                                 goto ret;
1334                         }
1335
1336                         rxq->vnic = vnic;
1337                         rxq->rx_started = 1;
1338                         vnic->rx_queue_cnt++;
1339                 }
1340
1341                 vnic->start_grp_id = rss->queue[0];
1342                 vnic->end_grp_id = rss->queue[rss->queue_num - 1];
1343                 vnic->func_default = 0; //This is not a default VNIC.
1344
1345                 rc = bnxt_vnic_prep(bp, vnic);
1346                 if (rc) {
1347                         rte_flow_error_set(error,
1348                                            EINVAL,
1349                                            RTE_FLOW_ERROR_TYPE_ACTION,
1350                                            act,
1351                                            "VNIC prep fail");
1352                         rc = -rte_errno;
1353                         goto ret;
1354                 }
1355
1356                 PMD_DRV_LOG(DEBUG,
1357                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1358                             vnic_id, vnic, vnic->fw_grp_ids);
1359
1360                 vnic->ff_pool_idx = vnic_id;
1361                 PMD_DRV_LOG(DEBUG,
1362                             "Setting vnic ff_pool_idx %d\n", vnic->ff_pool_idx);
1363
1364                 /* This can be done only after vnic_grp_alloc is done. */
1365                 for (i = 0; i < vnic->rx_queue_cnt; i++) {
1366                         vnic->fw_grp_ids[i] =
1367                                 bp->grp_info[rss->queue[i]].fw_grp_id;
1368                         /* Make sure vnic0 does not use these rings. */
1369                         bp->vnic_info[0].fw_grp_ids[rss->queue[i]] =
1370                                 INVALID_HW_RING_ID;
1371                 }
1372
1373                 for (rss_idx = 0; rss_idx < HW_HASH_INDEX_SIZE; ) {
1374                         for (i = 0; i < vnic->rx_queue_cnt; i++)
1375                                 vnic->rss_table[rss_idx++] =
1376                                         vnic->fw_grp_ids[i];
1377                 }
1378
1379                 /* Configure RSS only if the queue count is > 1 */
1380                 if (vnic->rx_queue_cnt > 1) {
1381                         vnic->hash_type =
1382                                 bnxt_rte_to_hwrm_hash_types(rss->types);
1383
1384                         if (!rss->key_len) {
1385                                 /* If hash key has not been specified,
1386                                  * use random hash key.
1387                                  */
1388                                 prandom_bytes(vnic->rss_hash_key,
1389                                               HW_HASH_KEY_SIZE);
1390                         } else {
1391                                 if (rss->key_len > HW_HASH_KEY_SIZE)
1392                                         memcpy(vnic->rss_hash_key,
1393                                                rss->key,
1394                                                HW_HASH_KEY_SIZE);
1395                                 else
1396                                         memcpy(vnic->rss_hash_key,
1397                                                rss->key,
1398                                                rss->key_len);
1399                         }
1400                         bnxt_hwrm_vnic_rss_cfg(bp, vnic);
1401                 } else {
1402                         PMD_DRV_LOG(DEBUG, "No RSS config required\n");
1403                 }
1404
1405 vnic_found:
1406                 filter->dst_id = vnic->fw_vnic_id;
1407                 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1408                 if (filter1 == NULL) {
1409                         rte_flow_error_set(error,
1410                                            ENOSPC,
1411                                            RTE_FLOW_ERROR_TYPE_ACTION,
1412                                            act,
1413                                            "New filter not available");
1414                         rc = -rte_errno;
1415                         goto ret;
1416                 }
1417
1418                 PMD_DRV_LOG(DEBUG, "L2 filter created\n");
1419                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1420                 break;
1421         default:
1422                 rte_flow_error_set(error,
1423                                    EINVAL,
1424                                    RTE_FLOW_ERROR_TYPE_ACTION,
1425                                    act,
1426                                    "Invalid action.");
1427                 rc = -rte_errno;
1428                 goto ret;
1429         }
1430
1431         if (filter1 && !filter->matching_l2_fltr_ptr) {
1432                 bnxt_free_filter(bp, filter1);
1433                 filter1->fw_l2_filter_id = -1;
1434         }
1435
1436 done:
1437         act = bnxt_flow_non_void_action(++act);
1438         if (act->type != RTE_FLOW_ACTION_TYPE_END) {
1439                 rte_flow_error_set(error,
1440                                    EINVAL,
1441                                    RTE_FLOW_ERROR_TYPE_ACTION,
1442                                    act,
1443                                    "Invalid action.");
1444                 rc = -rte_errno;
1445                 goto ret;
1446         }
1447
1448         return rc;
1449 ret:
1450
1451         //TODO: Cleanup according to ACTION TYPE.
1452         if (rte_errno)  {
1453                 if (vnic && STAILQ_EMPTY(&vnic->filter))
1454                         vnic->rx_queue_cnt = 0;
1455
1456                 if (rxq && !vnic->rx_queue_cnt)
1457                         rxq->vnic = &bp->vnic_info[0];
1458         }
1459         return rc;
1460 }
1461
1462 static
1463 struct bnxt_vnic_info *find_matching_vnic(struct bnxt *bp,
1464                                           struct bnxt_filter_info *filter)
1465 {
1466         struct bnxt_vnic_info *vnic = NULL;
1467         unsigned int i;
1468
1469         for (i = 0; i < bp->max_vnics; i++) {
1470                 vnic = &bp->vnic_info[i];
1471                 if (vnic->fw_vnic_id != INVALID_VNIC_ID &&
1472                     filter->dst_id == vnic->fw_vnic_id) {
1473                         PMD_DRV_LOG(DEBUG, "Found matching VNIC Id %d\n",
1474                                     vnic->ff_pool_idx);
1475                         return vnic;
1476                 }
1477         }
1478         return NULL;
1479 }
1480
1481 static int
1482 bnxt_flow_validate(struct rte_eth_dev *dev,
1483                    const struct rte_flow_attr *attr,
1484                    const struct rte_flow_item pattern[],
1485                    const struct rte_flow_action actions[],
1486                    struct rte_flow_error *error)
1487 {
1488         struct bnxt *bp = dev->data->dev_private;
1489         struct bnxt_vnic_info *vnic = NULL;
1490         struct bnxt_filter_info *filter;
1491         int ret = 0;
1492
1493         bnxt_acquire_flow_lock(bp);
1494         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1495         if (ret != 0) {
1496                 bnxt_release_flow_lock(bp);
1497                 return ret;
1498         }
1499
1500         filter = bnxt_get_unused_filter(bp);
1501         if (filter == NULL) {
1502                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1503                 bnxt_release_flow_lock(bp);
1504                 return -ENOMEM;
1505         }
1506
1507         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1508                                            error, filter);
1509         if (ret)
1510                 goto exit;
1511
1512         vnic = find_matching_vnic(bp, filter);
1513         if (vnic) {
1514                 if (STAILQ_EMPTY(&vnic->filter)) {
1515                         rte_free(vnic->fw_grp_ids);
1516                         bnxt_hwrm_vnic_ctx_free(bp, vnic);
1517                         bnxt_hwrm_vnic_free(bp, vnic);
1518                         vnic->rx_queue_cnt = 0;
1519                         PMD_DRV_LOG(DEBUG, "Free VNIC\n");
1520                 }
1521         }
1522
1523         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1524                 bnxt_hwrm_clear_em_filter(bp, filter);
1525         else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1526                 bnxt_hwrm_clear_ntuple_filter(bp, filter);
1527         else
1528                 bnxt_hwrm_clear_l2_filter(bp, filter);
1529
1530 exit:
1531         /* No need to hold on to this filter if we are just validating flow */
1532         filter->fw_l2_filter_id = UINT64_MAX;
1533         bnxt_free_filter(bp, filter);
1534         bnxt_release_flow_lock(bp);
1535
1536         return ret;
1537 }
1538
1539 static void
1540 bnxt_update_filter(struct bnxt *bp, struct bnxt_filter_info *old_filter,
1541                    struct bnxt_filter_info *new_filter)
1542 {
1543         /* Clear the new L2 filter that was created in the previous step in
1544          * bnxt_validate_and_parse_flow. For L2 filters, we will use the new
1545          * filter which points to the new destination queue and so we clear
1546          * the previous L2 filter. For ntuple filters, we are going to reuse
1547          * the old L2 filter and create new NTUPLE filter with this new
1548          * destination queue subsequently during bnxt_flow_create.
1549          */
1550         if (new_filter->filter_type == HWRM_CFA_L2_FILTER) {
1551                 bnxt_hwrm_clear_l2_filter(bp, old_filter);
1552                 bnxt_hwrm_set_l2_filter(bp, new_filter->dst_id, new_filter);
1553         } else {
1554                 if (new_filter->filter_type == HWRM_CFA_EM_FILTER)
1555                         bnxt_hwrm_clear_em_filter(bp, old_filter);
1556                 if (new_filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1557                         bnxt_hwrm_clear_ntuple_filter(bp, old_filter);
1558         }
1559 }
1560
1561 static int
1562 bnxt_match_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
1563 {
1564         struct bnxt_filter_info *mf;
1565         struct rte_flow *flow;
1566         int i;
1567
1568         for (i = bp->max_vnics - 1; i >= 0; i--) {
1569                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
1570
1571                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
1572                         continue;
1573
1574                 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
1575                         mf = flow->filter;
1576
1577                         if (mf->filter_type == nf->filter_type &&
1578                             mf->flags == nf->flags &&
1579                             mf->src_port == nf->src_port &&
1580                             mf->src_port_mask == nf->src_port_mask &&
1581                             mf->dst_port == nf->dst_port &&
1582                             mf->dst_port_mask == nf->dst_port_mask &&
1583                             mf->ip_protocol == nf->ip_protocol &&
1584                             mf->ip_addr_type == nf->ip_addr_type &&
1585                             mf->ethertype == nf->ethertype &&
1586                             mf->vni == nf->vni &&
1587                             mf->tunnel_type == nf->tunnel_type &&
1588                             mf->l2_ovlan == nf->l2_ovlan &&
1589                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
1590                             mf->l2_ivlan == nf->l2_ivlan &&
1591                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
1592                             !memcmp(mf->l2_addr, nf->l2_addr,
1593                                     RTE_ETHER_ADDR_LEN) &&
1594                             !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
1595                                     RTE_ETHER_ADDR_LEN) &&
1596                             !memcmp(mf->src_macaddr, nf->src_macaddr,
1597                                     RTE_ETHER_ADDR_LEN) &&
1598                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
1599                                     RTE_ETHER_ADDR_LEN) &&
1600                             !memcmp(mf->src_ipaddr, nf->src_ipaddr,
1601                                     sizeof(nf->src_ipaddr)) &&
1602                             !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
1603                                     sizeof(nf->src_ipaddr_mask)) &&
1604                             !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
1605                                     sizeof(nf->dst_ipaddr)) &&
1606                             !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
1607                                     sizeof(nf->dst_ipaddr_mask))) {
1608                                 if (mf->dst_id == nf->dst_id)
1609                                         return -EEXIST;
1610                                 /* Free the old filter, update flow
1611                                  * with new filter
1612                                  */
1613                                 bnxt_update_filter(bp, mf, nf);
1614                                 STAILQ_REMOVE(&vnic->filter, mf,
1615                                               bnxt_filter_info, next);
1616                                 STAILQ_INSERT_TAIL(&vnic->filter, nf, next);
1617                                 bnxt_free_filter(bp, mf);
1618                                 flow->filter = nf;
1619                                 return -EXDEV;
1620                         }
1621                 }
1622         }
1623         return 0;
1624 }
1625
1626 static struct rte_flow *
1627 bnxt_flow_create(struct rte_eth_dev *dev,
1628                  const struct rte_flow_attr *attr,
1629                  const struct rte_flow_item pattern[],
1630                  const struct rte_flow_action actions[],
1631                  struct rte_flow_error *error)
1632 {
1633         struct bnxt *bp = dev->data->dev_private;
1634         struct bnxt_vnic_info *vnic = NULL;
1635         struct bnxt_filter_info *filter;
1636         bool update_flow = false;
1637         struct rte_flow *flow;
1638         int ret = 0;
1639         uint32_t tun_type;
1640
1641         if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
1642                 rte_flow_error_set(error, EINVAL,
1643                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1644                                    "Failed to create flow, Not a Trusted VF!");
1645                 return NULL;
1646         }
1647
1648         if (!dev->data->dev_started) {
1649                 rte_flow_error_set(error,
1650                                    EINVAL,
1651                                    RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
1652                                    NULL,
1653                                    "Device must be started");
1654                 return NULL;
1655         }
1656
1657         flow = rte_zmalloc("bnxt_flow", sizeof(struct rte_flow), 0);
1658         if (!flow) {
1659                 rte_flow_error_set(error, ENOMEM,
1660                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1661                                    "Failed to allocate memory");
1662                 return flow;
1663         }
1664
1665         bnxt_acquire_flow_lock(bp);
1666         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1667         if (ret != 0) {
1668                 PMD_DRV_LOG(ERR, "Not a validate flow.\n");
1669                 goto free_flow;
1670         }
1671
1672         filter = bnxt_get_unused_filter(bp);
1673         if (filter == NULL) {
1674                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1675                 goto free_flow;
1676         }
1677
1678         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1679                                            error, filter);
1680         if (ret != 0)
1681                 goto free_filter;
1682
1683         ret = bnxt_match_filter(bp, filter);
1684         if (ret == -EEXIST) {
1685                 PMD_DRV_LOG(DEBUG, "Flow already exists.\n");
1686                 /* Clear the filter that was created as part of
1687                  * validate_and_parse_flow() above
1688                  */
1689                 bnxt_hwrm_clear_l2_filter(bp, filter);
1690                 goto free_filter;
1691         } else if (ret == -EXDEV) {
1692                 PMD_DRV_LOG(DEBUG, "Flow with same pattern exists\n");
1693                 PMD_DRV_LOG(DEBUG, "Updating with different destination\n");
1694                 update_flow = true;
1695         }
1696
1697         /* If tunnel redirection to a VF/PF is specified then only tunnel_type
1698          * is set and enable is set to the tunnel type. Issue hwrm cmd directly
1699          * in such a case.
1700          */
1701         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1702             filter->enables == filter->tunnel_type) {
1703                 ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1704                 if (ret) {
1705                         rte_flow_error_set(error, -ret,
1706                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1707                                            "Unable to query tunnel to VF");
1708                         goto free_filter;
1709                 }
1710                 if (tun_type == (1U << filter->tunnel_type)) {
1711                         ret =
1712                         bnxt_hwrm_tunnel_redirect_free(bp,
1713                                                        filter->tunnel_type);
1714                         if (ret) {
1715                                 PMD_DRV_LOG(ERR,
1716                                             "Unable to free existing tunnel\n");
1717                                 rte_flow_error_set(error, -ret,
1718                                                    RTE_FLOW_ERROR_TYPE_HANDLE,
1719                                                    NULL,
1720                                                    "Unable to free preexisting "
1721                                                    "tunnel on VF");
1722                                 goto free_filter;
1723                         }
1724                 }
1725                 ret = bnxt_hwrm_tunnel_redirect(bp, filter->tunnel_type);
1726                 if (ret) {
1727                         rte_flow_error_set(error, -ret,
1728                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1729                                            "Unable to redirect tunnel to VF");
1730                         goto free_filter;
1731                 }
1732                 vnic = &bp->vnic_info[0];
1733                 goto done;
1734         }
1735
1736         if (filter->filter_type == HWRM_CFA_EM_FILTER) {
1737                 filter->enables |=
1738                         HWRM_CFA_EM_FLOW_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1739                 ret = bnxt_hwrm_set_em_filter(bp, filter->dst_id, filter);
1740         }
1741
1742         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER) {
1743                 filter->enables |=
1744                         HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1745                 ret = bnxt_hwrm_set_ntuple_filter(bp, filter->dst_id, filter);
1746         }
1747
1748         vnic = find_matching_vnic(bp, filter);
1749 done:
1750         if (!ret || update_flow) {
1751                 flow->filter = filter;
1752                 flow->vnic = vnic;
1753                 if (update_flow) {
1754                         ret = -EXDEV;
1755                         goto free_flow;
1756                 }
1757
1758                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
1759                 PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
1760                 STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
1761                 bnxt_release_flow_lock(bp);
1762                 return flow;
1763         }
1764
1765 free_filter:
1766         bnxt_free_filter(bp, filter);
1767 free_flow:
1768         if (ret == -EEXIST)
1769                 rte_flow_error_set(error, ret,
1770                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1771                                    "Matching Flow exists.");
1772         else if (ret == -EXDEV)
1773                 rte_flow_error_set(error, 0,
1774                                    RTE_FLOW_ERROR_TYPE_NONE, NULL,
1775                                    "Flow with pattern exists, updating destination queue");
1776         else
1777                 rte_flow_error_set(error, -ret,
1778                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1779                                    "Failed to create flow.");
1780         rte_free(flow);
1781         flow = NULL;
1782         bnxt_release_flow_lock(bp);
1783         return flow;
1784 }
1785
1786 static int bnxt_handle_tunnel_redirect_destroy(struct bnxt *bp,
1787                                                struct bnxt_filter_info *filter,
1788                                                struct rte_flow_error *error)
1789 {
1790         uint16_t tun_dst_fid;
1791         uint32_t tun_type;
1792         int ret = 0;
1793
1794         ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1795         if (ret) {
1796                 rte_flow_error_set(error, -ret,
1797                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1798                                    "Unable to query tunnel to VF");
1799                 return ret;
1800         }
1801         if (tun_type == (1U << filter->tunnel_type)) {
1802                 ret = bnxt_hwrm_tunnel_redirect_info(bp, filter->tunnel_type,
1803                                                      &tun_dst_fid);
1804                 if (ret) {
1805                         rte_flow_error_set(error, -ret,
1806                                            RTE_FLOW_ERROR_TYPE_HANDLE,
1807                                            NULL,
1808                                            "tunnel_redirect info cmd fail");
1809                         return ret;
1810                 }
1811                 PMD_DRV_LOG(INFO, "Pre-existing tunnel fid = %x vf->fid = %x\n",
1812                             tun_dst_fid + bp->first_vf_id, bp->fw_fid);
1813
1814                 /* Tunnel doesn't belong to this VF, so don't send HWRM
1815                  * cmd, just delete the flow from driver
1816                  */
1817                 if (bp->fw_fid != (tun_dst_fid + bp->first_vf_id))
1818                         PMD_DRV_LOG(ERR,
1819                                     "Tunnel does not belong to this VF, skip hwrm_tunnel_redirect_free\n");
1820                 else
1821                         ret = bnxt_hwrm_tunnel_redirect_free(bp,
1822                                                         filter->tunnel_type);
1823         }
1824         return ret;
1825 }
1826
1827 static int
1828 bnxt_flow_destroy(struct rte_eth_dev *dev,
1829                   struct rte_flow *flow,
1830                   struct rte_flow_error *error)
1831 {
1832         struct bnxt *bp = dev->data->dev_private;
1833         struct bnxt_filter_info *filter;
1834         struct bnxt_vnic_info *vnic;
1835         int ret = 0;
1836
1837         bnxt_acquire_flow_lock(bp);
1838         if (!flow) {
1839                 rte_flow_error_set(error, EINVAL,
1840                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1841                                    "Invalid flow: failed to destroy flow.");
1842                 bnxt_release_flow_lock(bp);
1843                 return -EINVAL;
1844         }
1845
1846         filter = flow->filter;
1847         vnic = flow->vnic;
1848
1849         if (!filter) {
1850                 rte_flow_error_set(error, EINVAL,
1851                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1852                                    "Invalid flow: failed to destroy flow.");
1853                 bnxt_release_flow_lock(bp);
1854                 return -EINVAL;
1855         }
1856
1857         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1858             filter->enables == filter->tunnel_type) {
1859                 ret = bnxt_handle_tunnel_redirect_destroy(bp,
1860                                                           filter,
1861                                                           error);
1862                 if (!ret) {
1863                         goto done;
1864                 } else {
1865                         bnxt_release_flow_lock(bp);
1866                         return ret;
1867                 }
1868         }
1869
1870         ret = bnxt_match_filter(bp, filter);
1871         if (ret == 0)
1872                 PMD_DRV_LOG(ERR, "Could not find matching flow\n");
1873
1874         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1875                 ret = bnxt_hwrm_clear_em_filter(bp, filter);
1876         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1877                 ret = bnxt_hwrm_clear_ntuple_filter(bp, filter);
1878         ret = bnxt_hwrm_clear_l2_filter(bp, filter);
1879
1880 done:
1881         if (!ret) {
1882                 /* If it is a L2 drop filter, when the filter is created,
1883                  * the FW updates the BC/MC records.
1884                  * Once this filter is removed, issue the set_rx_mask command
1885                  * to reset the BC/MC records in the HW to the settings
1886                  * before the drop counter is created.
1887                  */
1888                 if (filter->valid_flags & BNXT_FLOW_L2_DROP_FLAG)
1889                         bnxt_set_rx_mask_no_vlan(bp, &bp->vnic_info[0]);
1890
1891                 STAILQ_REMOVE(&vnic->filter, filter, bnxt_filter_info, next);
1892                 bnxt_free_filter(bp, filter);
1893                 STAILQ_REMOVE(&vnic->flow_list, flow, rte_flow, next);
1894                 rte_free(flow);
1895
1896                 /* If this was the last flow associated with this vnic,
1897                  * switch the queue back to RSS pool.
1898                  */
1899                 if (vnic && !vnic->func_default &&
1900                     STAILQ_EMPTY(&vnic->flow_list)) {
1901                         rte_free(vnic->fw_grp_ids);
1902                         if (vnic->rx_queue_cnt > 1)
1903                                 bnxt_hwrm_vnic_ctx_free(bp, vnic);
1904
1905                         bnxt_hwrm_vnic_free(bp, vnic);
1906                         vnic->rx_queue_cnt = 0;
1907                 }
1908         } else {
1909                 rte_flow_error_set(error, -ret,
1910                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1911                                    "Failed to destroy flow.");
1912         }
1913
1914         bnxt_release_flow_lock(bp);
1915         return ret;
1916 }
1917
1918 static int
1919 bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
1920 {
1921         struct bnxt *bp = dev->data->dev_private;
1922         struct bnxt_filter_info *filter = NULL;
1923         struct bnxt_vnic_info *vnic;
1924         struct rte_flow *flow;
1925         unsigned int i;
1926         int ret = 0;
1927
1928         bnxt_acquire_flow_lock(bp);
1929         for (i = 0; i < bp->max_vnics; i++) {
1930                 vnic = &bp->vnic_info[i];
1931                 if (vnic && vnic->fw_vnic_id == INVALID_VNIC_ID)
1932                         continue;
1933
1934                 while (!STAILQ_EMPTY(&vnic->flow_list)) {
1935                         flow = STAILQ_FIRST(&vnic->flow_list);
1936                         filter = flow->filter;
1937
1938                         if (filter->filter_type ==
1939                             HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1940                             filter->enables == filter->tunnel_type) {
1941                                 ret =
1942                                 bnxt_handle_tunnel_redirect_destroy(bp,
1943                                                                     filter,
1944                                                                     error);
1945                                 if (!ret) {
1946                                         goto done;
1947                                 } else {
1948                                         bnxt_release_flow_lock(bp);
1949                                         return ret;
1950                                 }
1951                         }
1952
1953                         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1954                                 ret = bnxt_hwrm_clear_em_filter(bp, filter);
1955                         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1956                                 ret = bnxt_hwrm_clear_ntuple_filter(bp, filter);
1957                         else if (i)
1958                                 ret = bnxt_hwrm_clear_l2_filter(bp, filter);
1959
1960                         if (ret) {
1961                                 rte_flow_error_set
1962                                         (error,
1963                                          -ret,
1964                                          RTE_FLOW_ERROR_TYPE_HANDLE,
1965                                          NULL,
1966                                          "Failed to flush flow in HW.");
1967                                 bnxt_release_flow_lock(bp);
1968                                 return -rte_errno;
1969                         }
1970 done:
1971                         STAILQ_REMOVE(&vnic->flow_list, flow,
1972                                       rte_flow, next);
1973
1974                         STAILQ_REMOVE(&vnic->filter,
1975                                       filter,
1976                                       bnxt_filter_info,
1977                                       next);
1978                         bnxt_free_filter(bp, filter);
1979
1980                         rte_free(flow);
1981
1982                         /* If this was the last flow associated with this vnic,
1983                          * switch the queue back to RSS pool.
1984                          */
1985                         if (STAILQ_EMPTY(&vnic->flow_list)) {
1986                                 rte_free(vnic->fw_grp_ids);
1987                                 if (vnic->rx_queue_cnt > 1)
1988                                         bnxt_hwrm_vnic_ctx_free(bp, vnic);
1989                                 bnxt_hwrm_vnic_free(bp, vnic);
1990                                 vnic->rx_queue_cnt = 0;
1991                         }
1992                 }
1993         }
1994
1995         bnxt_release_flow_lock(bp);
1996         return ret;
1997 }
1998
1999 const struct rte_flow_ops bnxt_flow_ops = {
2000         .validate = bnxt_flow_validate,
2001         .create = bnxt_flow_create,
2002         .destroy = bnxt_flow_destroy,
2003         .flush = bnxt_flow_flush,
2004 };