net/sfc: support counters in tunnel offload jump rules
[dpdk.git] / drivers / net / sfc / sfc_mae.c
1 /* SPDX-License-Identifier: BSD-3-Clause
2  *
3  * Copyright(c) 2019-2021 Xilinx, Inc.
4  * Copyright(c) 2019 Solarflare Communications Inc.
5  *
6  * This software was jointly developed between OKTET Labs (under contract
7  * for Solarflare) and Solarflare Communications, Inc.
8  */
9
10 #include <stdbool.h>
11
12 #include <rte_bitops.h>
13 #include <rte_common.h>
14 #include <rte_vxlan.h>
15
16 #include "efx.h"
17
18 #include "sfc.h"
19 #include "sfc_flow_tunnel.h"
20 #include "sfc_mae_counter.h"
21 #include "sfc_log.h"
22 #include "sfc_switch.h"
23 #include "sfc_service.h"
24
25 static int
26 sfc_mae_assign_entity_mport(struct sfc_adapter *sa,
27                             efx_mport_sel_t *mportp)
28 {
29         const efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);
30
31         return efx_mae_mport_by_pcie_function(encp->enc_pf, encp->enc_vf,
32                                               mportp);
33 }
34
35 static int
36 sfc_mae_counter_registry_init(struct sfc_mae_counter_registry *registry,
37                               uint32_t nb_counters_max)
38 {
39         return sfc_mae_counters_init(&registry->counters, nb_counters_max);
40 }
41
42 static void
43 sfc_mae_counter_registry_fini(struct sfc_mae_counter_registry *registry)
44 {
45         sfc_mae_counters_fini(&registry->counters);
46 }
47
48 static int
49 sfc_mae_internal_rule_find_empty_slot(struct sfc_adapter *sa,
50                                       struct sfc_mae_rule **rule)
51 {
52         struct sfc_mae *mae = &sa->mae;
53         struct sfc_mae_internal_rules *internal_rules = &mae->internal_rules;
54         unsigned int entry;
55         int rc;
56
57         for (entry = 0; entry < SFC_MAE_NB_RULES_MAX; entry++) {
58                 if (internal_rules->rules[entry].spec == NULL)
59                         break;
60         }
61
62         if (entry == SFC_MAE_NB_RULES_MAX) {
63                 rc = ENOSPC;
64                 sfc_err(sa, "failed too many rules (%u rules used)", entry);
65                 goto fail_too_many_rules;
66         }
67
68         *rule = &internal_rules->rules[entry];
69
70         return 0;
71
72 fail_too_many_rules:
73         return rc;
74 }
75
76 int
77 sfc_mae_rule_add_mport_match_deliver(struct sfc_adapter *sa,
78                                      const efx_mport_sel_t *mport_match,
79                                      const efx_mport_sel_t *mport_deliver,
80                                      int prio, struct sfc_mae_rule **rulep)
81 {
82         struct sfc_mae *mae = &sa->mae;
83         struct sfc_mae_rule *rule;
84         int rc;
85
86         sfc_log_init(sa, "entry");
87
88         if (prio > 0 && (unsigned int)prio >= mae->nb_action_rule_prios_max) {
89                 rc = EINVAL;
90                 sfc_err(sa, "failed: invalid priority %d (max %u)", prio,
91                         mae->nb_action_rule_prios_max);
92                 goto fail_invalid_prio;
93         }
94         if (prio < 0)
95                 prio = mae->nb_action_rule_prios_max - 1;
96
97         rc = sfc_mae_internal_rule_find_empty_slot(sa, &rule);
98         if (rc != 0)
99                 goto fail_find_empty_slot;
100
101         sfc_log_init(sa, "init MAE match spec");
102         rc = efx_mae_match_spec_init(sa->nic, EFX_MAE_RULE_ACTION,
103                                      (uint32_t)prio, &rule->spec);
104         if (rc != 0) {
105                 sfc_err(sa, "failed to init MAE match spec");
106                 goto fail_match_init;
107         }
108
109         rc = efx_mae_match_spec_mport_set(rule->spec, mport_match, NULL);
110         if (rc != 0) {
111                 sfc_err(sa, "failed to get MAE match mport selector");
112                 goto fail_mport_set;
113         }
114
115         rc = efx_mae_action_set_spec_init(sa->nic, &rule->actions);
116         if (rc != 0) {
117                 sfc_err(sa, "failed to init MAE action set");
118                 goto fail_action_init;
119         }
120
121         rc = efx_mae_action_set_populate_deliver(rule->actions,
122                                                  mport_deliver);
123         if (rc != 0) {
124                 sfc_err(sa, "failed to populate deliver action");
125                 goto fail_populate_deliver;
126         }
127
128         rc = efx_mae_action_set_alloc(sa->nic, rule->actions,
129                                       &rule->action_set);
130         if (rc != 0) {
131                 sfc_err(sa, "failed to allocate action set");
132                 goto fail_action_set_alloc;
133         }
134
135         rc = efx_mae_action_rule_insert(sa->nic, rule->spec, NULL,
136                                         &rule->action_set,
137                                         &rule->rule_id);
138         if (rc != 0) {
139                 sfc_err(sa, "failed to insert action rule");
140                 goto fail_rule_insert;
141         }
142
143         *rulep = rule;
144
145         sfc_log_init(sa, "done");
146
147         return 0;
148
149 fail_rule_insert:
150         efx_mae_action_set_free(sa->nic, &rule->action_set);
151
152 fail_action_set_alloc:
153 fail_populate_deliver:
154         efx_mae_action_set_spec_fini(sa->nic, rule->actions);
155
156 fail_action_init:
157 fail_mport_set:
158         efx_mae_match_spec_fini(sa->nic, rule->spec);
159
160 fail_match_init:
161 fail_find_empty_slot:
162 fail_invalid_prio:
163         sfc_log_init(sa, "failed: %s", rte_strerror(rc));
164         return rc;
165 }
166
167 void
168 sfc_mae_rule_del(struct sfc_adapter *sa, struct sfc_mae_rule *rule)
169 {
170         if (rule == NULL || rule->spec == NULL)
171                 return;
172
173         efx_mae_action_rule_remove(sa->nic, &rule->rule_id);
174         efx_mae_action_set_free(sa->nic, &rule->action_set);
175         efx_mae_action_set_spec_fini(sa->nic, rule->actions);
176         efx_mae_match_spec_fini(sa->nic, rule->spec);
177
178         rule->spec = NULL;
179 }
180
181 int
182 sfc_mae_attach(struct sfc_adapter *sa)
183 {
184         struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
185         struct sfc_mae_switch_port_request switch_port_request = {0};
186         const efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);
187         efx_mport_sel_t entity_mport;
188         struct sfc_mae *mae = &sa->mae;
189         struct sfc_mae_bounce_eh *bounce_eh = &mae->bounce_eh;
190         efx_mae_limits_t limits;
191         int rc;
192
193         sfc_log_init(sa, "entry");
194
195         if (!encp->enc_mae_supported) {
196                 mae->status = SFC_MAE_STATUS_UNSUPPORTED;
197                 return 0;
198         }
199
200         sfc_log_init(sa, "init MAE");
201         rc = efx_mae_init(sa->nic);
202         if (rc != 0)
203                 goto fail_mae_init;
204
205         sfc_log_init(sa, "get MAE limits");
206         rc = efx_mae_get_limits(sa->nic, &limits);
207         if (rc != 0)
208                 goto fail_mae_get_limits;
209
210         sfc_log_init(sa, "init MAE counter registry");
211         rc = sfc_mae_counter_registry_init(&mae->counter_registry,
212                                            limits.eml_max_n_counters);
213         if (rc != 0) {
214                 sfc_err(sa, "failed to init MAE counters registry for %u entries: %s",
215                         limits.eml_max_n_counters, rte_strerror(rc));
216                 goto fail_counter_registry_init;
217         }
218
219         sfc_log_init(sa, "assign entity MPORT");
220         rc = sfc_mae_assign_entity_mport(sa, &entity_mport);
221         if (rc != 0)
222                 goto fail_mae_assign_entity_mport;
223
224         sfc_log_init(sa, "assign RTE switch domain");
225         rc = sfc_mae_assign_switch_domain(sa, &mae->switch_domain_id);
226         if (rc != 0)
227                 goto fail_mae_assign_switch_domain;
228
229         sfc_log_init(sa, "assign RTE switch port");
230         switch_port_request.type = SFC_MAE_SWITCH_PORT_INDEPENDENT;
231         switch_port_request.entity_mportp = &entity_mport;
232         /* RTE ethdev MPORT matches that of the entity for independent ports. */
233         switch_port_request.ethdev_mportp = &entity_mport;
234         switch_port_request.ethdev_port_id = sas->port_id;
235         rc = sfc_mae_assign_switch_port(mae->switch_domain_id,
236                                         &switch_port_request,
237                                         &mae->switch_port_id);
238         if (rc != 0)
239                 goto fail_mae_assign_switch_port;
240
241         sfc_log_init(sa, "allocate encap. header bounce buffer");
242         bounce_eh->buf_size = limits.eml_encap_header_size_limit;
243         bounce_eh->buf = rte_malloc("sfc_mae_bounce_eh",
244                                     bounce_eh->buf_size, 0);
245         if (bounce_eh->buf == NULL)
246                 goto fail_mae_alloc_bounce_eh;
247
248         mae->status = SFC_MAE_STATUS_SUPPORTED;
249         mae->nb_outer_rule_prios_max = limits.eml_max_n_outer_prios;
250         mae->nb_action_rule_prios_max = limits.eml_max_n_action_prios;
251         mae->encap_types_supported = limits.eml_encap_types_supported;
252         TAILQ_INIT(&mae->outer_rules);
253         TAILQ_INIT(&mae->encap_headers);
254         TAILQ_INIT(&mae->action_sets);
255
256         sfc_log_init(sa, "done");
257
258         return 0;
259
260 fail_mae_alloc_bounce_eh:
261 fail_mae_assign_switch_port:
262 fail_mae_assign_switch_domain:
263 fail_mae_assign_entity_mport:
264         sfc_mae_counter_registry_fini(&mae->counter_registry);
265
266 fail_counter_registry_init:
267 fail_mae_get_limits:
268         efx_mae_fini(sa->nic);
269
270 fail_mae_init:
271         sfc_log_init(sa, "failed %d", rc);
272
273         return rc;
274 }
275
276 void
277 sfc_mae_detach(struct sfc_adapter *sa)
278 {
279         struct sfc_mae *mae = &sa->mae;
280         enum sfc_mae_status status_prev = mae->status;
281
282         sfc_log_init(sa, "entry");
283
284         mae->nb_action_rule_prios_max = 0;
285         mae->status = SFC_MAE_STATUS_UNKNOWN;
286
287         if (status_prev != SFC_MAE_STATUS_SUPPORTED)
288                 return;
289
290         rte_free(mae->bounce_eh.buf);
291         sfc_mae_counter_registry_fini(&mae->counter_registry);
292
293         efx_mae_fini(sa->nic);
294
295         sfc_log_init(sa, "done");
296 }
297
298 static struct sfc_mae_outer_rule *
299 sfc_mae_outer_rule_attach(struct sfc_adapter *sa,
300                           const efx_mae_match_spec_t *match_spec,
301                           efx_tunnel_protocol_t encap_type)
302 {
303         struct sfc_mae_outer_rule *rule;
304         struct sfc_mae *mae = &sa->mae;
305
306         SFC_ASSERT(sfc_adapter_is_locked(sa));
307
308         TAILQ_FOREACH(rule, &mae->outer_rules, entries) {
309                 if (efx_mae_match_specs_equal(rule->match_spec, match_spec) &&
310                     rule->encap_type == encap_type) {
311                         sfc_dbg(sa, "attaching to outer_rule=%p", rule);
312                         ++(rule->refcnt);
313                         return rule;
314                 }
315         }
316
317         return NULL;
318 }
319
320 static int
321 sfc_mae_outer_rule_add(struct sfc_adapter *sa,
322                        efx_mae_match_spec_t *match_spec,
323                        efx_tunnel_protocol_t encap_type,
324                        struct sfc_mae_outer_rule **rulep)
325 {
326         struct sfc_mae_outer_rule *rule;
327         struct sfc_mae *mae = &sa->mae;
328
329         SFC_ASSERT(sfc_adapter_is_locked(sa));
330
331         rule = rte_zmalloc("sfc_mae_outer_rule", sizeof(*rule), 0);
332         if (rule == NULL)
333                 return ENOMEM;
334
335         rule->refcnt = 1;
336         rule->match_spec = match_spec;
337         rule->encap_type = encap_type;
338
339         rule->fw_rsrc.rule_id.id = EFX_MAE_RSRC_ID_INVALID;
340
341         TAILQ_INSERT_TAIL(&mae->outer_rules, rule, entries);
342
343         *rulep = rule;
344
345         sfc_dbg(sa, "added outer_rule=%p", rule);
346
347         return 0;
348 }
349
350 static void
351 sfc_mae_outer_rule_del(struct sfc_adapter *sa,
352                        struct sfc_mae_outer_rule *rule)
353 {
354         struct sfc_mae *mae = &sa->mae;
355
356         SFC_ASSERT(sfc_adapter_is_locked(sa));
357         SFC_ASSERT(rule->refcnt != 0);
358
359         --(rule->refcnt);
360
361         if (rule->refcnt != 0)
362                 return;
363
364         if (rule->fw_rsrc.rule_id.id != EFX_MAE_RSRC_ID_INVALID ||
365             rule->fw_rsrc.refcnt != 0) {
366                 sfc_err(sa, "deleting outer_rule=%p abandons its FW resource: OR_ID=0x%08x, refcnt=%u",
367                         rule, rule->fw_rsrc.rule_id.id, rule->fw_rsrc.refcnt);
368         }
369
370         efx_mae_match_spec_fini(sa->nic, rule->match_spec);
371
372         TAILQ_REMOVE(&mae->outer_rules, rule, entries);
373         rte_free(rule);
374
375         sfc_dbg(sa, "deleted outer_rule=%p", rule);
376 }
377
378 static int
379 sfc_mae_outer_rule_enable(struct sfc_adapter *sa,
380                           struct sfc_mae_outer_rule *rule,
381                           efx_mae_match_spec_t *match_spec_action)
382 {
383         struct sfc_mae_fw_rsrc *fw_rsrc = &rule->fw_rsrc;
384         int rc;
385
386         SFC_ASSERT(sfc_adapter_is_locked(sa));
387
388         if (fw_rsrc->refcnt == 0) {
389                 SFC_ASSERT(fw_rsrc->rule_id.id == EFX_MAE_RSRC_ID_INVALID);
390                 SFC_ASSERT(rule->match_spec != NULL);
391
392                 rc = efx_mae_outer_rule_insert(sa->nic, rule->match_spec,
393                                                rule->encap_type,
394                                                &fw_rsrc->rule_id);
395                 if (rc != 0) {
396                         sfc_err(sa, "failed to enable outer_rule=%p: %s",
397                                 rule, strerror(rc));
398                         return rc;
399                 }
400         }
401
402         if (match_spec_action == NULL)
403                 goto skip_action_rule;
404
405         rc = efx_mae_match_spec_outer_rule_id_set(match_spec_action,
406                                                   &fw_rsrc->rule_id);
407         if (rc != 0) {
408                 if (fw_rsrc->refcnt == 0) {
409                         (void)efx_mae_outer_rule_remove(sa->nic,
410                                                         &fw_rsrc->rule_id);
411                         fw_rsrc->rule_id.id = EFX_MAE_RSRC_ID_INVALID;
412                 }
413
414                 sfc_err(sa, "can't match on outer rule ID: %s", strerror(rc));
415
416                 return rc;
417         }
418
419 skip_action_rule:
420         if (fw_rsrc->refcnt == 0) {
421                 sfc_dbg(sa, "enabled outer_rule=%p: OR_ID=0x%08x",
422                         rule, fw_rsrc->rule_id.id);
423         }
424
425         ++(fw_rsrc->refcnt);
426
427         return 0;
428 }
429
430 static void
431 sfc_mae_outer_rule_disable(struct sfc_adapter *sa,
432                            struct sfc_mae_outer_rule *rule)
433 {
434         struct sfc_mae_fw_rsrc *fw_rsrc = &rule->fw_rsrc;
435         int rc;
436
437         SFC_ASSERT(sfc_adapter_is_locked(sa));
438
439         if (fw_rsrc->rule_id.id == EFX_MAE_RSRC_ID_INVALID ||
440             fw_rsrc->refcnt == 0) {
441                 sfc_err(sa, "failed to disable outer_rule=%p: already disabled; OR_ID=0x%08x, refcnt=%u",
442                         rule, fw_rsrc->rule_id.id, fw_rsrc->refcnt);
443                 return;
444         }
445
446         if (fw_rsrc->refcnt == 1) {
447                 rc = efx_mae_outer_rule_remove(sa->nic, &fw_rsrc->rule_id);
448                 if (rc == 0) {
449                         sfc_dbg(sa, "disabled outer_rule=%p with OR_ID=0x%08x",
450                                 rule, fw_rsrc->rule_id.id);
451                 } else {
452                         sfc_err(sa, "failed to disable outer_rule=%p with OR_ID=0x%08x: %s",
453                                 rule, fw_rsrc->rule_id.id, strerror(rc));
454                 }
455                 fw_rsrc->rule_id.id = EFX_MAE_RSRC_ID_INVALID;
456         }
457
458         --(fw_rsrc->refcnt);
459 }
460
461 static struct sfc_mae_encap_header *
462 sfc_mae_encap_header_attach(struct sfc_adapter *sa,
463                             const struct sfc_mae_bounce_eh *bounce_eh)
464 {
465         struct sfc_mae_encap_header *encap_header;
466         struct sfc_mae *mae = &sa->mae;
467
468         SFC_ASSERT(sfc_adapter_is_locked(sa));
469
470         TAILQ_FOREACH(encap_header, &mae->encap_headers, entries) {
471                 if (encap_header->size == bounce_eh->size &&
472                     memcmp(encap_header->buf, bounce_eh->buf,
473                            bounce_eh->size) == 0) {
474                         sfc_dbg(sa, "attaching to encap_header=%p",
475                                 encap_header);
476                         ++(encap_header->refcnt);
477                         return encap_header;
478                 }
479         }
480
481         return NULL;
482 }
483
484 static int
485 sfc_mae_encap_header_add(struct sfc_adapter *sa,
486                          const struct sfc_mae_bounce_eh *bounce_eh,
487                          struct sfc_mae_encap_header **encap_headerp)
488 {
489         struct sfc_mae_encap_header *encap_header;
490         struct sfc_mae *mae = &sa->mae;
491
492         SFC_ASSERT(sfc_adapter_is_locked(sa));
493
494         encap_header = rte_zmalloc("sfc_mae_encap_header",
495                                    sizeof(*encap_header), 0);
496         if (encap_header == NULL)
497                 return ENOMEM;
498
499         encap_header->size = bounce_eh->size;
500
501         encap_header->buf = rte_malloc("sfc_mae_encap_header_buf",
502                                        encap_header->size, 0);
503         if (encap_header->buf == NULL) {
504                 rte_free(encap_header);
505                 return ENOMEM;
506         }
507
508         rte_memcpy(encap_header->buf, bounce_eh->buf, bounce_eh->size);
509
510         encap_header->refcnt = 1;
511         encap_header->type = bounce_eh->type;
512         encap_header->fw_rsrc.eh_id.id = EFX_MAE_RSRC_ID_INVALID;
513
514         TAILQ_INSERT_TAIL(&mae->encap_headers, encap_header, entries);
515
516         *encap_headerp = encap_header;
517
518         sfc_dbg(sa, "added encap_header=%p", encap_header);
519
520         return 0;
521 }
522
523 static void
524 sfc_mae_encap_header_del(struct sfc_adapter *sa,
525                        struct sfc_mae_encap_header *encap_header)
526 {
527         struct sfc_mae *mae = &sa->mae;
528
529         if (encap_header == NULL)
530                 return;
531
532         SFC_ASSERT(sfc_adapter_is_locked(sa));
533         SFC_ASSERT(encap_header->refcnt != 0);
534
535         --(encap_header->refcnt);
536
537         if (encap_header->refcnt != 0)
538                 return;
539
540         if (encap_header->fw_rsrc.eh_id.id != EFX_MAE_RSRC_ID_INVALID ||
541             encap_header->fw_rsrc.refcnt != 0) {
542                 sfc_err(sa, "deleting encap_header=%p abandons its FW resource: EH_ID=0x%08x, refcnt=%u",
543                         encap_header, encap_header->fw_rsrc.eh_id.id,
544                         encap_header->fw_rsrc.refcnt);
545         }
546
547         TAILQ_REMOVE(&mae->encap_headers, encap_header, entries);
548         rte_free(encap_header->buf);
549         rte_free(encap_header);
550
551         sfc_dbg(sa, "deleted encap_header=%p", encap_header);
552 }
553
554 static int
555 sfc_mae_encap_header_enable(struct sfc_adapter *sa,
556                             struct sfc_mae_encap_header *encap_header,
557                             efx_mae_actions_t *action_set_spec)
558 {
559         struct sfc_mae_fw_rsrc *fw_rsrc;
560         int rc;
561
562         if (encap_header == NULL)
563                 return 0;
564
565         SFC_ASSERT(sfc_adapter_is_locked(sa));
566
567         fw_rsrc = &encap_header->fw_rsrc;
568
569         if (fw_rsrc->refcnt == 0) {
570                 SFC_ASSERT(fw_rsrc->eh_id.id == EFX_MAE_RSRC_ID_INVALID);
571                 SFC_ASSERT(encap_header->buf != NULL);
572                 SFC_ASSERT(encap_header->size != 0);
573
574                 rc = efx_mae_encap_header_alloc(sa->nic, encap_header->type,
575                                                 encap_header->buf,
576                                                 encap_header->size,
577                                                 &fw_rsrc->eh_id);
578                 if (rc != 0) {
579                         sfc_err(sa, "failed to enable encap_header=%p: %s",
580                                 encap_header, strerror(rc));
581                         return rc;
582                 }
583         }
584
585         rc = efx_mae_action_set_fill_in_eh_id(action_set_spec,
586                                               &fw_rsrc->eh_id);
587         if (rc != 0) {
588                 if (fw_rsrc->refcnt == 0) {
589                         (void)efx_mae_encap_header_free(sa->nic,
590                                                         &fw_rsrc->eh_id);
591                         fw_rsrc->eh_id.id = EFX_MAE_RSRC_ID_INVALID;
592                 }
593
594                 sfc_err(sa, "can't fill in encap. header ID: %s", strerror(rc));
595
596                 return rc;
597         }
598
599         if (fw_rsrc->refcnt == 0) {
600                 sfc_dbg(sa, "enabled encap_header=%p: EH_ID=0x%08x",
601                         encap_header, fw_rsrc->eh_id.id);
602         }
603
604         ++(fw_rsrc->refcnt);
605
606         return 0;
607 }
608
609 static void
610 sfc_mae_encap_header_disable(struct sfc_adapter *sa,
611                              struct sfc_mae_encap_header *encap_header)
612 {
613         struct sfc_mae_fw_rsrc *fw_rsrc;
614         int rc;
615
616         if (encap_header == NULL)
617                 return;
618
619         SFC_ASSERT(sfc_adapter_is_locked(sa));
620
621         fw_rsrc = &encap_header->fw_rsrc;
622
623         if (fw_rsrc->eh_id.id == EFX_MAE_RSRC_ID_INVALID ||
624             fw_rsrc->refcnt == 0) {
625                 sfc_err(sa, "failed to disable encap_header=%p: already disabled; EH_ID=0x%08x, refcnt=%u",
626                         encap_header, fw_rsrc->eh_id.id, fw_rsrc->refcnt);
627                 return;
628         }
629
630         if (fw_rsrc->refcnt == 1) {
631                 rc = efx_mae_encap_header_free(sa->nic, &fw_rsrc->eh_id);
632                 if (rc == 0) {
633                         sfc_dbg(sa, "disabled encap_header=%p with EH_ID=0x%08x",
634                                 encap_header, fw_rsrc->eh_id.id);
635                 } else {
636                         sfc_err(sa, "failed to disable encap_header=%p with EH_ID=0x%08x: %s",
637                                 encap_header, fw_rsrc->eh_id.id, strerror(rc));
638                 }
639                 fw_rsrc->eh_id.id = EFX_MAE_RSRC_ID_INVALID;
640         }
641
642         --(fw_rsrc->refcnt);
643 }
644
645 static int
646 sfc_mae_counters_enable(struct sfc_adapter *sa,
647                         struct sfc_mae_counter_id *counters,
648                         unsigned int n_counters,
649                         efx_mae_actions_t *action_set_spec)
650 {
651         int rc;
652
653         sfc_log_init(sa, "entry");
654
655         if (n_counters == 0) {
656                 sfc_log_init(sa, "no counters - skip");
657                 return 0;
658         }
659
660         SFC_ASSERT(sfc_adapter_is_locked(sa));
661         SFC_ASSERT(n_counters == 1);
662
663         rc = sfc_mae_counter_enable(sa, &counters[0]);
664         if (rc != 0) {
665                 sfc_err(sa, "failed to enable MAE counter %u: %s",
666                         counters[0].mae_id.id, rte_strerror(rc));
667                 goto fail_counter_add;
668         }
669
670         rc = efx_mae_action_set_fill_in_counter_id(action_set_spec,
671                                                    &counters[0].mae_id);
672         if (rc != 0) {
673                 sfc_err(sa, "failed to fill in MAE counter %u in action set: %s",
674                         counters[0].mae_id.id, rte_strerror(rc));
675                 goto fail_fill_in_id;
676         }
677
678         return 0;
679
680 fail_fill_in_id:
681         (void)sfc_mae_counter_disable(sa, &counters[0]);
682
683 fail_counter_add:
684         sfc_log_init(sa, "failed: %s", rte_strerror(rc));
685         return rc;
686 }
687
688 static int
689 sfc_mae_counters_disable(struct sfc_adapter *sa,
690                          struct sfc_mae_counter_id *counters,
691                          unsigned int n_counters)
692 {
693         if (n_counters == 0)
694                 return 0;
695
696         SFC_ASSERT(sfc_adapter_is_locked(sa));
697         SFC_ASSERT(n_counters == 1);
698
699         if (counters[0].mae_id.id == EFX_MAE_RSRC_ID_INVALID) {
700                 sfc_err(sa, "failed to disable: already disabled");
701                 return EALREADY;
702         }
703
704         return sfc_mae_counter_disable(sa, &counters[0]);
705 }
706
707 static struct sfc_mae_action_set *
708 sfc_mae_action_set_attach(struct sfc_adapter *sa,
709                           const struct sfc_mae_encap_header *encap_header,
710                           unsigned int n_count,
711                           const efx_mae_actions_t *spec)
712 {
713         struct sfc_mae_action_set *action_set;
714         struct sfc_mae *mae = &sa->mae;
715
716         SFC_ASSERT(sfc_adapter_is_locked(sa));
717
718         TAILQ_FOREACH(action_set, &mae->action_sets, entries) {
719                 /*
720                  * Shared counters are not supported, hence action sets with
721                  * COUNT are not attachable.
722                  */
723                 if (action_set->encap_header == encap_header &&
724                     n_count == 0 &&
725                     efx_mae_action_set_specs_equal(action_set->spec, spec)) {
726                         sfc_dbg(sa, "attaching to action_set=%p", action_set);
727                         ++(action_set->refcnt);
728                         return action_set;
729                 }
730         }
731
732         return NULL;
733 }
734
735 static int
736 sfc_mae_action_set_add(struct sfc_adapter *sa,
737                        const struct rte_flow_action actions[],
738                        efx_mae_actions_t *spec,
739                        struct sfc_mae_encap_header *encap_header,
740                        uint64_t *ft_group_hit_counter,
741                        struct sfc_flow_tunnel *ft,
742                        unsigned int n_counters,
743                        struct sfc_mae_action_set **action_setp)
744 {
745         struct sfc_mae_action_set *action_set;
746         struct sfc_mae *mae = &sa->mae;
747         unsigned int i;
748
749         SFC_ASSERT(sfc_adapter_is_locked(sa));
750
751         action_set = rte_zmalloc("sfc_mae_action_set", sizeof(*action_set), 0);
752         if (action_set == NULL) {
753                 sfc_err(sa, "failed to alloc action set");
754                 return ENOMEM;
755         }
756
757         if (n_counters > 0) {
758                 const struct rte_flow_action *action;
759
760                 action_set->counters = rte_malloc("sfc_mae_counter_ids",
761                         sizeof(action_set->counters[0]) * n_counters, 0);
762                 if (action_set->counters == NULL) {
763                         rte_free(action_set);
764                         sfc_err(sa, "failed to alloc counters");
765                         return ENOMEM;
766                 }
767
768                 for (i = 0; i < n_counters; ++i) {
769                         action_set->counters[i].rte_id_valid = B_FALSE;
770                         action_set->counters[i].mae_id.id =
771                                 EFX_MAE_RSRC_ID_INVALID;
772
773                         action_set->counters[i].ft_group_hit_counter =
774                                 ft_group_hit_counter;
775                         action_set->counters[i].ft = ft;
776                 }
777
778                 for (action = actions, i = 0;
779                      action->type != RTE_FLOW_ACTION_TYPE_END && i < n_counters;
780                      ++action) {
781                         const struct rte_flow_action_count *conf;
782
783                         if (action->type != RTE_FLOW_ACTION_TYPE_COUNT)
784                                 continue;
785
786                         conf = action->conf;
787
788                         action_set->counters[i].rte_id_valid = B_TRUE;
789                         action_set->counters[i].rte_id = conf->id;
790                         i++;
791                 }
792                 action_set->n_counters = n_counters;
793         }
794
795         action_set->refcnt = 1;
796         action_set->spec = spec;
797         action_set->encap_header = encap_header;
798
799         action_set->fw_rsrc.aset_id.id = EFX_MAE_RSRC_ID_INVALID;
800
801         TAILQ_INSERT_TAIL(&mae->action_sets, action_set, entries);
802
803         *action_setp = action_set;
804
805         sfc_dbg(sa, "added action_set=%p", action_set);
806
807         return 0;
808 }
809
810 static void
811 sfc_mae_action_set_del(struct sfc_adapter *sa,
812                        struct sfc_mae_action_set *action_set)
813 {
814         struct sfc_mae *mae = &sa->mae;
815
816         SFC_ASSERT(sfc_adapter_is_locked(sa));
817         SFC_ASSERT(action_set->refcnt != 0);
818
819         --(action_set->refcnt);
820
821         if (action_set->refcnt != 0)
822                 return;
823
824         if (action_set->fw_rsrc.aset_id.id != EFX_MAE_RSRC_ID_INVALID ||
825             action_set->fw_rsrc.refcnt != 0) {
826                 sfc_err(sa, "deleting action_set=%p abandons its FW resource: AS_ID=0x%08x, refcnt=%u",
827                         action_set, action_set->fw_rsrc.aset_id.id,
828                         action_set->fw_rsrc.refcnt);
829         }
830
831         efx_mae_action_set_spec_fini(sa->nic, action_set->spec);
832         sfc_mae_encap_header_del(sa, action_set->encap_header);
833         if (action_set->n_counters > 0) {
834                 SFC_ASSERT(action_set->n_counters == 1);
835                 SFC_ASSERT(action_set->counters[0].mae_id.id ==
836                            EFX_MAE_RSRC_ID_INVALID);
837                 rte_free(action_set->counters);
838         }
839         TAILQ_REMOVE(&mae->action_sets, action_set, entries);
840         rte_free(action_set);
841
842         sfc_dbg(sa, "deleted action_set=%p", action_set);
843 }
844
845 static int
846 sfc_mae_action_set_enable(struct sfc_adapter *sa,
847                           struct sfc_mae_action_set *action_set)
848 {
849         struct sfc_mae_encap_header *encap_header = action_set->encap_header;
850         struct sfc_mae_counter_id *counters = action_set->counters;
851         struct sfc_mae_fw_rsrc *fw_rsrc = &action_set->fw_rsrc;
852         int rc;
853
854         SFC_ASSERT(sfc_adapter_is_locked(sa));
855
856         if (fw_rsrc->refcnt == 0) {
857                 SFC_ASSERT(fw_rsrc->aset_id.id == EFX_MAE_RSRC_ID_INVALID);
858                 SFC_ASSERT(action_set->spec != NULL);
859
860                 rc = sfc_mae_encap_header_enable(sa, encap_header,
861                                                  action_set->spec);
862                 if (rc != 0)
863                         return rc;
864
865                 rc = sfc_mae_counters_enable(sa, counters,
866                                              action_set->n_counters,
867                                              action_set->spec);
868                 if (rc != 0) {
869                         sfc_err(sa, "failed to enable %u MAE counters: %s",
870                                 action_set->n_counters, rte_strerror(rc));
871
872                         sfc_mae_encap_header_disable(sa, encap_header);
873                         return rc;
874                 }
875
876                 rc = efx_mae_action_set_alloc(sa->nic, action_set->spec,
877                                               &fw_rsrc->aset_id);
878                 if (rc != 0) {
879                         sfc_err(sa, "failed to enable action_set=%p: %s",
880                                 action_set, strerror(rc));
881
882                         (void)sfc_mae_counters_disable(sa, counters,
883                                                        action_set->n_counters);
884                         sfc_mae_encap_header_disable(sa, encap_header);
885                         return rc;
886                 }
887
888                 sfc_dbg(sa, "enabled action_set=%p: AS_ID=0x%08x",
889                         action_set, fw_rsrc->aset_id.id);
890         }
891
892         ++(fw_rsrc->refcnt);
893
894         return 0;
895 }
896
897 static void
898 sfc_mae_action_set_disable(struct sfc_adapter *sa,
899                            struct sfc_mae_action_set *action_set)
900 {
901         struct sfc_mae_fw_rsrc *fw_rsrc = &action_set->fw_rsrc;
902         int rc;
903
904         SFC_ASSERT(sfc_adapter_is_locked(sa));
905
906         if (fw_rsrc->aset_id.id == EFX_MAE_RSRC_ID_INVALID ||
907             fw_rsrc->refcnt == 0) {
908                 sfc_err(sa, "failed to disable action_set=%p: already disabled; AS_ID=0x%08x, refcnt=%u",
909                         action_set, fw_rsrc->aset_id.id, fw_rsrc->refcnt);
910                 return;
911         }
912
913         if (fw_rsrc->refcnt == 1) {
914                 rc = efx_mae_action_set_free(sa->nic, &fw_rsrc->aset_id);
915                 if (rc == 0) {
916                         sfc_dbg(sa, "disabled action_set=%p with AS_ID=0x%08x",
917                                 action_set, fw_rsrc->aset_id.id);
918                 } else {
919                         sfc_err(sa, "failed to disable action_set=%p with AS_ID=0x%08x: %s",
920                                 action_set, fw_rsrc->aset_id.id, strerror(rc));
921                 }
922                 fw_rsrc->aset_id.id = EFX_MAE_RSRC_ID_INVALID;
923
924                 rc = sfc_mae_counters_disable(sa, action_set->counters,
925                                               action_set->n_counters);
926                 if (rc != 0) {
927                         sfc_err(sa, "failed to disable %u MAE counters: %s",
928                                 action_set->n_counters, rte_strerror(rc));
929                 }
930
931                 sfc_mae_encap_header_disable(sa, action_set->encap_header);
932         }
933
934         --(fw_rsrc->refcnt);
935 }
936
937 void
938 sfc_mae_flow_cleanup(struct sfc_adapter *sa,
939                      struct rte_flow *flow)
940 {
941         struct sfc_flow_spec *spec;
942         struct sfc_flow_spec_mae *spec_mae;
943
944         if (flow == NULL)
945                 return;
946
947         spec = &flow->spec;
948
949         if (spec == NULL)
950                 return;
951
952         spec_mae = &spec->mae;
953
954         if (spec_mae->ft != NULL) {
955                 if (spec_mae->ft_rule_type == SFC_FT_RULE_JUMP)
956                         spec_mae->ft->jump_rule_is_set = B_FALSE;
957
958                 SFC_ASSERT(spec_mae->ft->refcnt != 0);
959                 --(spec_mae->ft->refcnt);
960         }
961
962         SFC_ASSERT(spec_mae->rule_id.id == EFX_MAE_RSRC_ID_INVALID);
963
964         if (spec_mae->outer_rule != NULL)
965                 sfc_mae_outer_rule_del(sa, spec_mae->outer_rule);
966
967         if (spec_mae->action_set != NULL)
968                 sfc_mae_action_set_del(sa, spec_mae->action_set);
969
970         if (spec_mae->match_spec != NULL)
971                 efx_mae_match_spec_fini(sa->nic, spec_mae->match_spec);
972 }
973
974 static int
975 sfc_mae_set_ethertypes(struct sfc_mae_parse_ctx *ctx)
976 {
977         struct sfc_mae_pattern_data *pdata = &ctx->pattern_data;
978         const efx_mae_field_id_t *fremap = ctx->field_ids_remap;
979         const efx_mae_field_id_t field_ids[] = {
980                 EFX_MAE_FIELD_VLAN0_PROTO_BE,
981                 EFX_MAE_FIELD_VLAN1_PROTO_BE,
982         };
983         const struct sfc_mae_ethertype *et;
984         unsigned int i;
985         int rc;
986
987         /*
988          * In accordance with RTE flow API convention, the innermost L2
989          * item's "type" ("inner_type") is a L3 EtherType. If there is
990          * no L3 item, it's 0x0000/0x0000.
991          */
992         et = &pdata->ethertypes[pdata->nb_vlan_tags];
993         rc = efx_mae_match_spec_field_set(ctx->match_spec,
994                                           fremap[EFX_MAE_FIELD_ETHER_TYPE_BE],
995                                           sizeof(et->value),
996                                           (const uint8_t *)&et->value,
997                                           sizeof(et->mask),
998                                           (const uint8_t *)&et->mask);
999         if (rc != 0)
1000                 return rc;
1001
1002         /*
1003          * sfc_mae_rule_parse_item_vlan() has already made sure
1004          * that pdata->nb_vlan_tags does not exceed this figure.
1005          */
1006         RTE_BUILD_BUG_ON(SFC_MAE_MATCH_VLAN_MAX_NTAGS != 2);
1007
1008         for (i = 0; i < pdata->nb_vlan_tags; ++i) {
1009                 et = &pdata->ethertypes[i];
1010
1011                 rc = efx_mae_match_spec_field_set(ctx->match_spec,
1012                                                   fremap[field_ids[i]],
1013                                                   sizeof(et->value),
1014                                                   (const uint8_t *)&et->value,
1015                                                   sizeof(et->mask),
1016                                                   (const uint8_t *)&et->mask);
1017                 if (rc != 0)
1018                         return rc;
1019         }
1020
1021         return 0;
1022 }
1023
1024 static int
1025 sfc_mae_rule_process_pattern_data(struct sfc_mae_parse_ctx *ctx,
1026                                   struct rte_flow_error *error)
1027 {
1028         const efx_mae_field_id_t *fremap = ctx->field_ids_remap;
1029         struct sfc_mae_pattern_data *pdata = &ctx->pattern_data;
1030         struct sfc_mae_ethertype *ethertypes = pdata->ethertypes;
1031         const rte_be16_t supported_tpids[] = {
1032                 /* VLAN standard TPID (always the first element) */
1033                 RTE_BE16(RTE_ETHER_TYPE_VLAN),
1034
1035                 /* Double-tagging TPIDs */
1036                 RTE_BE16(RTE_ETHER_TYPE_QINQ),
1037                 RTE_BE16(RTE_ETHER_TYPE_QINQ1),
1038                 RTE_BE16(RTE_ETHER_TYPE_QINQ2),
1039                 RTE_BE16(RTE_ETHER_TYPE_QINQ3),
1040         };
1041         bool enforce_tag_presence[SFC_MAE_MATCH_VLAN_MAX_NTAGS] = {0};
1042         unsigned int nb_supported_tpids = RTE_DIM(supported_tpids);
1043         unsigned int ethertype_idx;
1044         const uint8_t *valuep;
1045         const uint8_t *maskp;
1046         int rc;
1047
1048         if (pdata->innermost_ethertype_restriction.mask != 0 &&
1049             pdata->nb_vlan_tags < SFC_MAE_MATCH_VLAN_MAX_NTAGS) {
1050                 /*
1051                  * If a single item VLAN is followed by a L3 item, value
1052                  * of "type" in item ETH can't be a double-tagging TPID.
1053                  */
1054                 nb_supported_tpids = 1;
1055         }
1056
1057         /*
1058          * sfc_mae_rule_parse_item_vlan() has already made sure
1059          * that pdata->nb_vlan_tags does not exceed this figure.
1060          */
1061         RTE_BUILD_BUG_ON(SFC_MAE_MATCH_VLAN_MAX_NTAGS != 2);
1062
1063         for (ethertype_idx = 0;
1064              ethertype_idx < pdata->nb_vlan_tags; ++ethertype_idx) {
1065                 rte_be16_t tpid_v = ethertypes[ethertype_idx].value;
1066                 rte_be16_t tpid_m = ethertypes[ethertype_idx].mask;
1067                 unsigned int tpid_idx;
1068
1069                 /*
1070                  * This loop can have only two iterations. On the second one,
1071                  * drop outer tag presence enforcement bit because the inner
1072                  * tag presence automatically assumes that for the outer tag.
1073                  */
1074                 enforce_tag_presence[0] = B_FALSE;
1075
1076                 if (tpid_m == RTE_BE16(0)) {
1077                         if (pdata->tci_masks[ethertype_idx] == RTE_BE16(0))
1078                                 enforce_tag_presence[ethertype_idx] = B_TRUE;
1079
1080                         /* No match on this field, and no value check. */
1081                         nb_supported_tpids = 1;
1082                         continue;
1083                 }
1084
1085                 /* Exact match is supported only. */
1086                 if (tpid_m != RTE_BE16(0xffff)) {
1087                         sfc_err(ctx->sa, "TPID mask must be 0x0 or 0xffff; got 0x%04x",
1088                                 rte_be_to_cpu_16(tpid_m));
1089                         rc = EINVAL;
1090                         goto fail;
1091                 }
1092
1093                 for (tpid_idx = pdata->nb_vlan_tags - ethertype_idx - 1;
1094                      tpid_idx < nb_supported_tpids; ++tpid_idx) {
1095                         if (tpid_v == supported_tpids[tpid_idx])
1096                                 break;
1097                 }
1098
1099                 if (tpid_idx == nb_supported_tpids) {
1100                         sfc_err(ctx->sa, "TPID 0x%04x is unsupported",
1101                                 rte_be_to_cpu_16(tpid_v));
1102                         rc = EINVAL;
1103                         goto fail;
1104                 }
1105
1106                 nb_supported_tpids = 1;
1107         }
1108
1109         if (pdata->innermost_ethertype_restriction.mask == RTE_BE16(0xffff)) {
1110                 struct sfc_mae_ethertype *et = &ethertypes[ethertype_idx];
1111                 rte_be16_t enforced_et;
1112
1113                 enforced_et = pdata->innermost_ethertype_restriction.value;
1114
1115                 if (et->mask == 0) {
1116                         et->mask = RTE_BE16(0xffff);
1117                         et->value = enforced_et;
1118                 } else if (et->mask != RTE_BE16(0xffff) ||
1119                            et->value != enforced_et) {
1120                         sfc_err(ctx->sa, "L3 EtherType must be 0x0/0x0 or 0x%04x/0xffff; got 0x%04x/0x%04x",
1121                                 rte_be_to_cpu_16(enforced_et),
1122                                 rte_be_to_cpu_16(et->value),
1123                                 rte_be_to_cpu_16(et->mask));
1124                         rc = EINVAL;
1125                         goto fail;
1126                 }
1127         }
1128
1129         /*
1130          * Now, when the number of VLAN tags is known, set fields
1131          * ETHER_TYPE, VLAN0_PROTO and VLAN1_PROTO so that the first
1132          * one is either a valid L3 EtherType (or 0x0000/0x0000),
1133          * and the last two are valid TPIDs (or 0x0000/0x0000).
1134          */
1135         rc = sfc_mae_set_ethertypes(ctx);
1136         if (rc != 0)
1137                 goto fail;
1138
1139         if (pdata->l3_next_proto_restriction_mask == 0xff) {
1140                 if (pdata->l3_next_proto_mask == 0) {
1141                         pdata->l3_next_proto_mask = 0xff;
1142                         pdata->l3_next_proto_value =
1143                                 pdata->l3_next_proto_restriction_value;
1144                 } else if (pdata->l3_next_proto_mask != 0xff ||
1145                            pdata->l3_next_proto_value !=
1146                            pdata->l3_next_proto_restriction_value) {
1147                         sfc_err(ctx->sa, "L3 next protocol must be 0x0/0x0 or 0x%02x/0xff; got 0x%02x/0x%02x",
1148                                 pdata->l3_next_proto_restriction_value,
1149                                 pdata->l3_next_proto_value,
1150                                 pdata->l3_next_proto_mask);
1151                         rc = EINVAL;
1152                         goto fail;
1153                 }
1154         }
1155
1156         if (enforce_tag_presence[0] || pdata->has_ovlan_mask) {
1157                 rc = efx_mae_match_spec_bit_set(ctx->match_spec,
1158                                                 fremap[EFX_MAE_FIELD_HAS_OVLAN],
1159                                                 enforce_tag_presence[0] ||
1160                                                 pdata->has_ovlan_value);
1161                 if (rc != 0)
1162                         goto fail;
1163         }
1164
1165         if (enforce_tag_presence[1] || pdata->has_ivlan_mask) {
1166                 rc = efx_mae_match_spec_bit_set(ctx->match_spec,
1167                                                 fremap[EFX_MAE_FIELD_HAS_IVLAN],
1168                                                 enforce_tag_presence[1] ||
1169                                                 pdata->has_ivlan_value);
1170                 if (rc != 0)
1171                         goto fail;
1172         }
1173
1174         valuep = (const uint8_t *)&pdata->l3_next_proto_value;
1175         maskp = (const uint8_t *)&pdata->l3_next_proto_mask;
1176         rc = efx_mae_match_spec_field_set(ctx->match_spec,
1177                                           fremap[EFX_MAE_FIELD_IP_PROTO],
1178                                           sizeof(pdata->l3_next_proto_value),
1179                                           valuep,
1180                                           sizeof(pdata->l3_next_proto_mask),
1181                                           maskp);
1182         if (rc != 0)
1183                 goto fail;
1184
1185         return 0;
1186
1187 fail:
1188         return rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ITEM, NULL,
1189                                   "Failed to process pattern data");
1190 }
1191
1192 static int
1193 sfc_mae_rule_parse_item_mark(const struct rte_flow_item *item,
1194                              struct sfc_flow_parse_ctx *ctx,
1195                              struct rte_flow_error *error)
1196 {
1197         const struct rte_flow_item_mark *spec = item->spec;
1198         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1199
1200         if (spec == NULL) {
1201                 return rte_flow_error_set(error, EINVAL,
1202                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1203                                 "NULL spec in item MARK");
1204         }
1205
1206         /*
1207          * This item is used in tunnel offload support only.
1208          * It must go before any network header items. This
1209          * way, sfc_mae_rule_preparse_item_mark() must have
1210          * already parsed it. Only one item MARK is allowed.
1211          */
1212         if (ctx_mae->ft_rule_type != SFC_FT_RULE_GROUP ||
1213             spec->id != (uint32_t)SFC_FT_ID_TO_MARK(ctx_mae->ft->id)) {
1214                 return rte_flow_error_set(error, EINVAL,
1215                                           RTE_FLOW_ERROR_TYPE_ITEM,
1216                                           item, "invalid item MARK");
1217         }
1218
1219         return 0;
1220 }
1221
1222 static int
1223 sfc_mae_rule_parse_item_port_id(const struct rte_flow_item *item,
1224                                 struct sfc_flow_parse_ctx *ctx,
1225                                 struct rte_flow_error *error)
1226 {
1227         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1228         const struct rte_flow_item_port_id supp_mask = {
1229                 .id = 0xffffffff,
1230         };
1231         const void *def_mask = &rte_flow_item_port_id_mask;
1232         const struct rte_flow_item_port_id *spec = NULL;
1233         const struct rte_flow_item_port_id *mask = NULL;
1234         efx_mport_sel_t mport_sel;
1235         int rc;
1236
1237         if (ctx_mae->match_mport_set) {
1238                 return rte_flow_error_set(error, ENOTSUP,
1239                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1240                                 "Can't handle multiple traffic source items");
1241         }
1242
1243         rc = sfc_flow_parse_init(item,
1244                                  (const void **)&spec, (const void **)&mask,
1245                                  (const void *)&supp_mask, def_mask,
1246                                  sizeof(struct rte_flow_item_port_id), error);
1247         if (rc != 0)
1248                 return rc;
1249
1250         if (mask->id != supp_mask.id) {
1251                 return rte_flow_error_set(error, EINVAL,
1252                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1253                                 "Bad mask in the PORT_ID pattern item");
1254         }
1255
1256         /* If "spec" is not set, could be any port ID */
1257         if (spec == NULL)
1258                 return 0;
1259
1260         if (spec->id > UINT16_MAX) {
1261                 return rte_flow_error_set(error, EOVERFLOW,
1262                                           RTE_FLOW_ERROR_TYPE_ITEM, item,
1263                                           "The port ID is too large");
1264         }
1265
1266         rc = sfc_mae_switch_port_by_ethdev(ctx_mae->sa->mae.switch_domain_id,
1267                                            spec->id, &mport_sel);
1268         if (rc != 0) {
1269                 return rte_flow_error_set(error, rc,
1270                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1271                                 "Can't find RTE ethdev by the port ID");
1272         }
1273
1274         rc = efx_mae_match_spec_mport_set(ctx_mae->match_spec,
1275                                           &mport_sel, NULL);
1276         if (rc != 0) {
1277                 return rte_flow_error_set(error, rc,
1278                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1279                                 "Failed to set MPORT for the port ID");
1280         }
1281
1282         ctx_mae->match_mport_set = B_TRUE;
1283
1284         return 0;
1285 }
1286
1287 static int
1288 sfc_mae_rule_parse_item_phy_port(const struct rte_flow_item *item,
1289                                  struct sfc_flow_parse_ctx *ctx,
1290                                  struct rte_flow_error *error)
1291 {
1292         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1293         const struct rte_flow_item_phy_port supp_mask = {
1294                 .index = 0xffffffff,
1295         };
1296         const void *def_mask = &rte_flow_item_phy_port_mask;
1297         const struct rte_flow_item_phy_port *spec = NULL;
1298         const struct rte_flow_item_phy_port *mask = NULL;
1299         efx_mport_sel_t mport_v;
1300         int rc;
1301
1302         if (ctx_mae->match_mport_set) {
1303                 return rte_flow_error_set(error, ENOTSUP,
1304                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1305                                 "Can't handle multiple traffic source items");
1306         }
1307
1308         rc = sfc_flow_parse_init(item,
1309                                  (const void **)&spec, (const void **)&mask,
1310                                  (const void *)&supp_mask, def_mask,
1311                                  sizeof(struct rte_flow_item_phy_port), error);
1312         if (rc != 0)
1313                 return rc;
1314
1315         if (mask->index != supp_mask.index) {
1316                 return rte_flow_error_set(error, EINVAL,
1317                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1318                                 "Bad mask in the PHY_PORT pattern item");
1319         }
1320
1321         /* If "spec" is not set, could be any physical port */
1322         if (spec == NULL)
1323                 return 0;
1324
1325         rc = efx_mae_mport_by_phy_port(spec->index, &mport_v);
1326         if (rc != 0) {
1327                 return rte_flow_error_set(error, rc,
1328                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1329                                 "Failed to convert the PHY_PORT index");
1330         }
1331
1332         rc = efx_mae_match_spec_mport_set(ctx_mae->match_spec, &mport_v, NULL);
1333         if (rc != 0) {
1334                 return rte_flow_error_set(error, rc,
1335                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1336                                 "Failed to set MPORT for the PHY_PORT");
1337         }
1338
1339         ctx_mae->match_mport_set = B_TRUE;
1340
1341         return 0;
1342 }
1343
1344 static int
1345 sfc_mae_rule_parse_item_pf(const struct rte_flow_item *item,
1346                            struct sfc_flow_parse_ctx *ctx,
1347                            struct rte_flow_error *error)
1348 {
1349         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1350         const efx_nic_cfg_t *encp = efx_nic_cfg_get(ctx_mae->sa->nic);
1351         efx_mport_sel_t mport_v;
1352         int rc;
1353
1354         if (ctx_mae->match_mport_set) {
1355                 return rte_flow_error_set(error, ENOTSUP,
1356                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1357                                 "Can't handle multiple traffic source items");
1358         }
1359
1360         rc = efx_mae_mport_by_pcie_function(encp->enc_pf, EFX_PCI_VF_INVALID,
1361                                             &mport_v);
1362         if (rc != 0) {
1363                 return rte_flow_error_set(error, rc,
1364                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1365                                 "Failed to convert the PF ID");
1366         }
1367
1368         rc = efx_mae_match_spec_mport_set(ctx_mae->match_spec, &mport_v, NULL);
1369         if (rc != 0) {
1370                 return rte_flow_error_set(error, rc,
1371                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1372                                 "Failed to set MPORT for the PF");
1373         }
1374
1375         ctx_mae->match_mport_set = B_TRUE;
1376
1377         return 0;
1378 }
1379
1380 static int
1381 sfc_mae_rule_parse_item_vf(const struct rte_flow_item *item,
1382                            struct sfc_flow_parse_ctx *ctx,
1383                            struct rte_flow_error *error)
1384 {
1385         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1386         const efx_nic_cfg_t *encp = efx_nic_cfg_get(ctx_mae->sa->nic);
1387         const struct rte_flow_item_vf supp_mask = {
1388                 .id = 0xffffffff,
1389         };
1390         const void *def_mask = &rte_flow_item_vf_mask;
1391         const struct rte_flow_item_vf *spec = NULL;
1392         const struct rte_flow_item_vf *mask = NULL;
1393         efx_mport_sel_t mport_v;
1394         int rc;
1395
1396         if (ctx_mae->match_mport_set) {
1397                 return rte_flow_error_set(error, ENOTSUP,
1398                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1399                                 "Can't handle multiple traffic source items");
1400         }
1401
1402         rc = sfc_flow_parse_init(item,
1403                                  (const void **)&spec, (const void **)&mask,
1404                                  (const void *)&supp_mask, def_mask,
1405                                  sizeof(struct rte_flow_item_vf), error);
1406         if (rc != 0)
1407                 return rc;
1408
1409         if (mask->id != supp_mask.id) {
1410                 return rte_flow_error_set(error, EINVAL,
1411                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1412                                 "Bad mask in the VF pattern item");
1413         }
1414
1415         /*
1416          * If "spec" is not set, the item requests any VF related to the
1417          * PF of the current DPDK port (but not the PF itself).
1418          * Reject this match criterion as unsupported.
1419          */
1420         if (spec == NULL) {
1421                 return rte_flow_error_set(error, EINVAL,
1422                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1423                                 "Bad spec in the VF pattern item");
1424         }
1425
1426         rc = efx_mae_mport_by_pcie_function(encp->enc_pf, spec->id, &mport_v);
1427         if (rc != 0) {
1428                 return rte_flow_error_set(error, rc,
1429                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1430                                 "Failed to convert the PF + VF IDs");
1431         }
1432
1433         rc = efx_mae_match_spec_mport_set(ctx_mae->match_spec, &mport_v, NULL);
1434         if (rc != 0) {
1435                 return rte_flow_error_set(error, rc,
1436                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1437                                 "Failed to set MPORT for the PF + VF");
1438         }
1439
1440         ctx_mae->match_mport_set = B_TRUE;
1441
1442         return 0;
1443 }
1444
1445 /*
1446  * Having this field ID in a field locator means that this
1447  * locator cannot be used to actually set the field at the
1448  * time when the corresponding item gets encountered. Such
1449  * fields get stashed in the parsing context instead. This
1450  * is required to resolve dependencies between the stashed
1451  * fields. See sfc_mae_rule_process_pattern_data().
1452  */
1453 #define SFC_MAE_FIELD_HANDLING_DEFERRED EFX_MAE_FIELD_NIDS
1454
1455 struct sfc_mae_field_locator {
1456         efx_mae_field_id_t              field_id;
1457         size_t                          size;
1458         /* Field offset in the corresponding rte_flow_item_ struct */
1459         size_t                          ofst;
1460 };
1461
1462 static void
1463 sfc_mae_item_build_supp_mask(const struct sfc_mae_field_locator *field_locators,
1464                              unsigned int nb_field_locators, void *mask_ptr,
1465                              size_t mask_size)
1466 {
1467         unsigned int i;
1468
1469         memset(mask_ptr, 0, mask_size);
1470
1471         for (i = 0; i < nb_field_locators; ++i) {
1472                 const struct sfc_mae_field_locator *fl = &field_locators[i];
1473
1474                 SFC_ASSERT(fl->ofst + fl->size <= mask_size);
1475                 memset(RTE_PTR_ADD(mask_ptr, fl->ofst), 0xff, fl->size);
1476         }
1477 }
1478
1479 static int
1480 sfc_mae_parse_item(const struct sfc_mae_field_locator *field_locators,
1481                    unsigned int nb_field_locators, const uint8_t *spec,
1482                    const uint8_t *mask, struct sfc_mae_parse_ctx *ctx,
1483                    struct rte_flow_error *error)
1484 {
1485         const efx_mae_field_id_t *fremap = ctx->field_ids_remap;
1486         unsigned int i;
1487         int rc = 0;
1488
1489         for (i = 0; i < nb_field_locators; ++i) {
1490                 const struct sfc_mae_field_locator *fl = &field_locators[i];
1491
1492                 if (fl->field_id == SFC_MAE_FIELD_HANDLING_DEFERRED)
1493                         continue;
1494
1495                 rc = efx_mae_match_spec_field_set(ctx->match_spec,
1496                                                   fremap[fl->field_id],
1497                                                   fl->size, spec + fl->ofst,
1498                                                   fl->size, mask + fl->ofst);
1499                 if (rc != 0)
1500                         break;
1501         }
1502
1503         if (rc != 0) {
1504                 rc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ITEM,
1505                                 NULL, "Failed to process item fields");
1506         }
1507
1508         return rc;
1509 }
1510
1511 static const struct sfc_mae_field_locator flocs_eth[] = {
1512         {
1513                 /*
1514                  * This locator is used only for building supported fields mask.
1515                  * The field is handled by sfc_mae_rule_process_pattern_data().
1516                  */
1517                 SFC_MAE_FIELD_HANDLING_DEFERRED,
1518                 RTE_SIZEOF_FIELD(struct rte_flow_item_eth, type),
1519                 offsetof(struct rte_flow_item_eth, type),
1520         },
1521         {
1522                 EFX_MAE_FIELD_ETH_DADDR_BE,
1523                 RTE_SIZEOF_FIELD(struct rte_flow_item_eth, dst),
1524                 offsetof(struct rte_flow_item_eth, dst),
1525         },
1526         {
1527                 EFX_MAE_FIELD_ETH_SADDR_BE,
1528                 RTE_SIZEOF_FIELD(struct rte_flow_item_eth, src),
1529                 offsetof(struct rte_flow_item_eth, src),
1530         },
1531 };
1532
1533 static int
1534 sfc_mae_rule_parse_item_eth(const struct rte_flow_item *item,
1535                             struct sfc_flow_parse_ctx *ctx,
1536                             struct rte_flow_error *error)
1537 {
1538         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1539         struct rte_flow_item_eth override_mask;
1540         struct rte_flow_item_eth supp_mask;
1541         const uint8_t *spec = NULL;
1542         const uint8_t *mask = NULL;
1543         int rc;
1544
1545         sfc_mae_item_build_supp_mask(flocs_eth, RTE_DIM(flocs_eth),
1546                                      &supp_mask, sizeof(supp_mask));
1547         supp_mask.has_vlan = 1;
1548
1549         rc = sfc_flow_parse_init(item,
1550                                  (const void **)&spec, (const void **)&mask,
1551                                  (const void *)&supp_mask,
1552                                  &rte_flow_item_eth_mask,
1553                                  sizeof(struct rte_flow_item_eth), error);
1554         if (rc != 0)
1555                 return rc;
1556
1557         if (ctx_mae->ft_rule_type == SFC_FT_RULE_JUMP && mask != NULL) {
1558                 /*
1559                  * The HW/FW hasn't got support for match on MAC addresses in
1560                  * outer rules yet (this will change). Match on VLAN presence
1561                  * isn't supported either. Ignore these match criteria.
1562                  */
1563                 memcpy(&override_mask, mask, sizeof(override_mask));
1564                 memset(&override_mask.hdr.dst_addr, 0,
1565                        sizeof(override_mask.hdr.dst_addr));
1566                 memset(&override_mask.hdr.src_addr, 0,
1567                        sizeof(override_mask.hdr.src_addr));
1568                 override_mask.has_vlan = 0;
1569
1570                 mask = (const uint8_t *)&override_mask;
1571         }
1572
1573         if (spec != NULL) {
1574                 struct sfc_mae_pattern_data *pdata = &ctx_mae->pattern_data;
1575                 struct sfc_mae_ethertype *ethertypes = pdata->ethertypes;
1576                 const struct rte_flow_item_eth *item_spec;
1577                 const struct rte_flow_item_eth *item_mask;
1578
1579                 item_spec = (const struct rte_flow_item_eth *)spec;
1580                 item_mask = (const struct rte_flow_item_eth *)mask;
1581
1582                 /*
1583                  * Remember various match criteria in the parsing context.
1584                  * sfc_mae_rule_process_pattern_data() will consider them
1585                  * altogether when the rest of the items have been parsed.
1586                  */
1587                 ethertypes[0].value = item_spec->type;
1588                 ethertypes[0].mask = item_mask->type;
1589                 if (item_mask->has_vlan) {
1590                         pdata->has_ovlan_mask = B_TRUE;
1591                         if (item_spec->has_vlan)
1592                                 pdata->has_ovlan_value = B_TRUE;
1593                 }
1594         } else {
1595                 /*
1596                  * The specification is empty. The overall pattern
1597                  * validity will be enforced at the end of parsing.
1598                  * See sfc_mae_rule_process_pattern_data().
1599                  */
1600                 return 0;
1601         }
1602
1603         return sfc_mae_parse_item(flocs_eth, RTE_DIM(flocs_eth), spec, mask,
1604                                   ctx_mae, error);
1605 }
1606
1607 static const struct sfc_mae_field_locator flocs_vlan[] = {
1608         /* Outermost tag */
1609         {
1610                 EFX_MAE_FIELD_VLAN0_TCI_BE,
1611                 RTE_SIZEOF_FIELD(struct rte_flow_item_vlan, tci),
1612                 offsetof(struct rte_flow_item_vlan, tci),
1613         },
1614         {
1615                 /*
1616                  * This locator is used only for building supported fields mask.
1617                  * The field is handled by sfc_mae_rule_process_pattern_data().
1618                  */
1619                 SFC_MAE_FIELD_HANDLING_DEFERRED,
1620                 RTE_SIZEOF_FIELD(struct rte_flow_item_vlan, inner_type),
1621                 offsetof(struct rte_flow_item_vlan, inner_type),
1622         },
1623
1624         /* Innermost tag */
1625         {
1626                 EFX_MAE_FIELD_VLAN1_TCI_BE,
1627                 RTE_SIZEOF_FIELD(struct rte_flow_item_vlan, tci),
1628                 offsetof(struct rte_flow_item_vlan, tci),
1629         },
1630         {
1631                 /*
1632                  * This locator is used only for building supported fields mask.
1633                  * The field is handled by sfc_mae_rule_process_pattern_data().
1634                  */
1635                 SFC_MAE_FIELD_HANDLING_DEFERRED,
1636                 RTE_SIZEOF_FIELD(struct rte_flow_item_vlan, inner_type),
1637                 offsetof(struct rte_flow_item_vlan, inner_type),
1638         },
1639 };
1640
1641 static int
1642 sfc_mae_rule_parse_item_vlan(const struct rte_flow_item *item,
1643                              struct sfc_flow_parse_ctx *ctx,
1644                              struct rte_flow_error *error)
1645 {
1646         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1647         struct sfc_mae_pattern_data *pdata = &ctx_mae->pattern_data;
1648         boolean_t *has_vlan_mp_by_nb_tags[SFC_MAE_MATCH_VLAN_MAX_NTAGS] = {
1649                 &pdata->has_ovlan_mask,
1650                 &pdata->has_ivlan_mask,
1651         };
1652         boolean_t *has_vlan_vp_by_nb_tags[SFC_MAE_MATCH_VLAN_MAX_NTAGS] = {
1653                 &pdata->has_ovlan_value,
1654                 &pdata->has_ivlan_value,
1655         };
1656         boolean_t *cur_tag_presence_bit_mp;
1657         boolean_t *cur_tag_presence_bit_vp;
1658         const struct sfc_mae_field_locator *flocs;
1659         struct rte_flow_item_vlan supp_mask;
1660         const uint8_t *spec = NULL;
1661         const uint8_t *mask = NULL;
1662         unsigned int nb_flocs;
1663         int rc;
1664
1665         RTE_BUILD_BUG_ON(SFC_MAE_MATCH_VLAN_MAX_NTAGS != 2);
1666
1667         if (pdata->nb_vlan_tags == SFC_MAE_MATCH_VLAN_MAX_NTAGS) {
1668                 return rte_flow_error_set(error, ENOTSUP,
1669                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1670                                 "Can't match that many VLAN tags");
1671         }
1672
1673         cur_tag_presence_bit_mp = has_vlan_mp_by_nb_tags[pdata->nb_vlan_tags];
1674         cur_tag_presence_bit_vp = has_vlan_vp_by_nb_tags[pdata->nb_vlan_tags];
1675
1676         if (*cur_tag_presence_bit_mp == B_TRUE &&
1677             *cur_tag_presence_bit_vp == B_FALSE) {
1678                 return rte_flow_error_set(error, EINVAL,
1679                                 RTE_FLOW_ERROR_TYPE_ITEM, item,
1680                                 "The previous item enforces no (more) VLAN, "
1681                                 "so the current item (VLAN) must not exist");
1682         }
1683
1684         nb_flocs = RTE_DIM(flocs_vlan) / SFC_MAE_MATCH_VLAN_MAX_NTAGS;
1685         flocs = flocs_vlan + pdata->nb_vlan_tags * nb_flocs;
1686
1687         sfc_mae_item_build_supp_mask(flocs, nb_flocs,
1688                                      &supp_mask, sizeof(supp_mask));
1689         /*
1690          * This only means that the field is supported by the driver and libefx.
1691          * Support on NIC level will be checked when all items have been parsed.
1692          */
1693         supp_mask.has_more_vlan = 1;
1694
1695         rc = sfc_flow_parse_init(item,
1696                                  (const void **)&spec, (const void **)&mask,
1697                                  (const void *)&supp_mask,
1698                                  &rte_flow_item_vlan_mask,
1699                                  sizeof(struct rte_flow_item_vlan), error);
1700         if (rc != 0)
1701                 return rc;
1702
1703         if (spec != NULL) {
1704                 struct sfc_mae_ethertype *et = pdata->ethertypes;
1705                 const struct rte_flow_item_vlan *item_spec;
1706                 const struct rte_flow_item_vlan *item_mask;
1707
1708                 item_spec = (const struct rte_flow_item_vlan *)spec;
1709                 item_mask = (const struct rte_flow_item_vlan *)mask;
1710
1711                 /*
1712                  * Remember various match criteria in the parsing context.
1713                  * sfc_mae_rule_process_pattern_data() will consider them
1714                  * altogether when the rest of the items have been parsed.
1715                  */
1716                 et[pdata->nb_vlan_tags + 1].value = item_spec->inner_type;
1717                 et[pdata->nb_vlan_tags + 1].mask = item_mask->inner_type;
1718                 pdata->tci_masks[pdata->nb_vlan_tags] = item_mask->tci;
1719                 if (item_mask->has_more_vlan) {
1720                         if (pdata->nb_vlan_tags ==
1721                             SFC_MAE_MATCH_VLAN_MAX_NTAGS) {
1722                                 return rte_flow_error_set(error, ENOTSUP,
1723                                         RTE_FLOW_ERROR_TYPE_ITEM, item,
1724                                         "Can't use 'has_more_vlan' in "
1725                                         "the second item VLAN");
1726                         }
1727                         pdata->has_ivlan_mask = B_TRUE;
1728                         if (item_spec->has_more_vlan)
1729                                 pdata->has_ivlan_value = B_TRUE;
1730                 }
1731
1732                 /* Convert TCI to MAE representation right now. */
1733                 rc = sfc_mae_parse_item(flocs, nb_flocs, spec, mask,
1734                                         ctx_mae, error);
1735                 if (rc != 0)
1736                         return rc;
1737         }
1738
1739         ++(pdata->nb_vlan_tags);
1740
1741         return 0;
1742 }
1743
1744 static const struct sfc_mae_field_locator flocs_ipv4[] = {
1745         {
1746                 EFX_MAE_FIELD_SRC_IP4_BE,
1747                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv4, hdr.src_addr),
1748                 offsetof(struct rte_flow_item_ipv4, hdr.src_addr),
1749         },
1750         {
1751                 EFX_MAE_FIELD_DST_IP4_BE,
1752                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv4, hdr.dst_addr),
1753                 offsetof(struct rte_flow_item_ipv4, hdr.dst_addr),
1754         },
1755         {
1756                 /*
1757                  * This locator is used only for building supported fields mask.
1758                  * The field is handled by sfc_mae_rule_process_pattern_data().
1759                  */
1760                 SFC_MAE_FIELD_HANDLING_DEFERRED,
1761                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv4, hdr.next_proto_id),
1762                 offsetof(struct rte_flow_item_ipv4, hdr.next_proto_id),
1763         },
1764         {
1765                 EFX_MAE_FIELD_IP_TOS,
1766                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv4,
1767                                  hdr.type_of_service),
1768                 offsetof(struct rte_flow_item_ipv4, hdr.type_of_service),
1769         },
1770         {
1771                 EFX_MAE_FIELD_IP_TTL,
1772                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv4, hdr.time_to_live),
1773                 offsetof(struct rte_flow_item_ipv4, hdr.time_to_live),
1774         },
1775 };
1776
1777 static int
1778 sfc_mae_rule_parse_item_ipv4(const struct rte_flow_item *item,
1779                              struct sfc_flow_parse_ctx *ctx,
1780                              struct rte_flow_error *error)
1781 {
1782         rte_be16_t ethertype_ipv4_be = RTE_BE16(RTE_ETHER_TYPE_IPV4);
1783         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1784         struct sfc_mae_pattern_data *pdata = &ctx_mae->pattern_data;
1785         struct rte_flow_item_ipv4 supp_mask;
1786         const uint8_t *spec = NULL;
1787         const uint8_t *mask = NULL;
1788         int rc;
1789
1790         sfc_mae_item_build_supp_mask(flocs_ipv4, RTE_DIM(flocs_ipv4),
1791                                      &supp_mask, sizeof(supp_mask));
1792
1793         rc = sfc_flow_parse_init(item,
1794                                  (const void **)&spec, (const void **)&mask,
1795                                  (const void *)&supp_mask,
1796                                  &rte_flow_item_ipv4_mask,
1797                                  sizeof(struct rte_flow_item_ipv4), error);
1798         if (rc != 0)
1799                 return rc;
1800
1801         pdata->innermost_ethertype_restriction.value = ethertype_ipv4_be;
1802         pdata->innermost_ethertype_restriction.mask = RTE_BE16(0xffff);
1803
1804         if (spec != NULL) {
1805                 const struct rte_flow_item_ipv4 *item_spec;
1806                 const struct rte_flow_item_ipv4 *item_mask;
1807
1808                 item_spec = (const struct rte_flow_item_ipv4 *)spec;
1809                 item_mask = (const struct rte_flow_item_ipv4 *)mask;
1810
1811                 pdata->l3_next_proto_value = item_spec->hdr.next_proto_id;
1812                 pdata->l3_next_proto_mask = item_mask->hdr.next_proto_id;
1813         } else {
1814                 return 0;
1815         }
1816
1817         return sfc_mae_parse_item(flocs_ipv4, RTE_DIM(flocs_ipv4), spec, mask,
1818                                   ctx_mae, error);
1819 }
1820
1821 static const struct sfc_mae_field_locator flocs_ipv6[] = {
1822         {
1823                 EFX_MAE_FIELD_SRC_IP6_BE,
1824                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv6, hdr.src_addr),
1825                 offsetof(struct rte_flow_item_ipv6, hdr.src_addr),
1826         },
1827         {
1828                 EFX_MAE_FIELD_DST_IP6_BE,
1829                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv6, hdr.dst_addr),
1830                 offsetof(struct rte_flow_item_ipv6, hdr.dst_addr),
1831         },
1832         {
1833                 /*
1834                  * This locator is used only for building supported fields mask.
1835                  * The field is handled by sfc_mae_rule_process_pattern_data().
1836                  */
1837                 SFC_MAE_FIELD_HANDLING_DEFERRED,
1838                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv6, hdr.proto),
1839                 offsetof(struct rte_flow_item_ipv6, hdr.proto),
1840         },
1841         {
1842                 EFX_MAE_FIELD_IP_TTL,
1843                 RTE_SIZEOF_FIELD(struct rte_flow_item_ipv6, hdr.hop_limits),
1844                 offsetof(struct rte_flow_item_ipv6, hdr.hop_limits),
1845         },
1846 };
1847
1848 static int
1849 sfc_mae_rule_parse_item_ipv6(const struct rte_flow_item *item,
1850                              struct sfc_flow_parse_ctx *ctx,
1851                              struct rte_flow_error *error)
1852 {
1853         rte_be16_t ethertype_ipv6_be = RTE_BE16(RTE_ETHER_TYPE_IPV6);
1854         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1855         const efx_mae_field_id_t *fremap = ctx_mae->field_ids_remap;
1856         struct sfc_mae_pattern_data *pdata = &ctx_mae->pattern_data;
1857         struct rte_flow_item_ipv6 supp_mask;
1858         const uint8_t *spec = NULL;
1859         const uint8_t *mask = NULL;
1860         rte_be32_t vtc_flow_be;
1861         uint32_t vtc_flow;
1862         uint8_t tc_value;
1863         uint8_t tc_mask;
1864         int rc;
1865
1866         sfc_mae_item_build_supp_mask(flocs_ipv6, RTE_DIM(flocs_ipv6),
1867                                      &supp_mask, sizeof(supp_mask));
1868
1869         vtc_flow_be = RTE_BE32(RTE_IPV6_HDR_TC_MASK);
1870         memcpy(&supp_mask, &vtc_flow_be, sizeof(vtc_flow_be));
1871
1872         rc = sfc_flow_parse_init(item,
1873                                  (const void **)&spec, (const void **)&mask,
1874                                  (const void *)&supp_mask,
1875                                  &rte_flow_item_ipv6_mask,
1876                                  sizeof(struct rte_flow_item_ipv6), error);
1877         if (rc != 0)
1878                 return rc;
1879
1880         pdata->innermost_ethertype_restriction.value = ethertype_ipv6_be;
1881         pdata->innermost_ethertype_restriction.mask = RTE_BE16(0xffff);
1882
1883         if (spec != NULL) {
1884                 const struct rte_flow_item_ipv6 *item_spec;
1885                 const struct rte_flow_item_ipv6 *item_mask;
1886
1887                 item_spec = (const struct rte_flow_item_ipv6 *)spec;
1888                 item_mask = (const struct rte_flow_item_ipv6 *)mask;
1889
1890                 pdata->l3_next_proto_value = item_spec->hdr.proto;
1891                 pdata->l3_next_proto_mask = item_mask->hdr.proto;
1892         } else {
1893                 return 0;
1894         }
1895
1896         rc = sfc_mae_parse_item(flocs_ipv6, RTE_DIM(flocs_ipv6), spec, mask,
1897                                 ctx_mae, error);
1898         if (rc != 0)
1899                 return rc;
1900
1901         memcpy(&vtc_flow_be, spec, sizeof(vtc_flow_be));
1902         vtc_flow = rte_be_to_cpu_32(vtc_flow_be);
1903         tc_value = (vtc_flow & RTE_IPV6_HDR_TC_MASK) >> RTE_IPV6_HDR_TC_SHIFT;
1904
1905         memcpy(&vtc_flow_be, mask, sizeof(vtc_flow_be));
1906         vtc_flow = rte_be_to_cpu_32(vtc_flow_be);
1907         tc_mask = (vtc_flow & RTE_IPV6_HDR_TC_MASK) >> RTE_IPV6_HDR_TC_SHIFT;
1908
1909         rc = efx_mae_match_spec_field_set(ctx_mae->match_spec,
1910                                           fremap[EFX_MAE_FIELD_IP_TOS],
1911                                           sizeof(tc_value), &tc_value,
1912                                           sizeof(tc_mask), &tc_mask);
1913         if (rc != 0) {
1914                 return rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ITEM,
1915                                 NULL, "Failed to process item fields");
1916         }
1917
1918         return 0;
1919 }
1920
1921 static const struct sfc_mae_field_locator flocs_tcp[] = {
1922         {
1923                 EFX_MAE_FIELD_L4_SPORT_BE,
1924                 RTE_SIZEOF_FIELD(struct rte_flow_item_tcp, hdr.src_port),
1925                 offsetof(struct rte_flow_item_tcp, hdr.src_port),
1926         },
1927         {
1928                 EFX_MAE_FIELD_L4_DPORT_BE,
1929                 RTE_SIZEOF_FIELD(struct rte_flow_item_tcp, hdr.dst_port),
1930                 offsetof(struct rte_flow_item_tcp, hdr.dst_port),
1931         },
1932         {
1933                 EFX_MAE_FIELD_TCP_FLAGS_BE,
1934                 /*
1935                  * The values have been picked intentionally since the
1936                  * target MAE field is oversize (16 bit). This mapping
1937                  * relies on the fact that the MAE field is big-endian.
1938                  */
1939                 RTE_SIZEOF_FIELD(struct rte_flow_item_tcp, hdr.data_off) +
1940                 RTE_SIZEOF_FIELD(struct rte_flow_item_tcp, hdr.tcp_flags),
1941                 offsetof(struct rte_flow_item_tcp, hdr.data_off),
1942         },
1943 };
1944
1945 static int
1946 sfc_mae_rule_parse_item_tcp(const struct rte_flow_item *item,
1947                             struct sfc_flow_parse_ctx *ctx,
1948                             struct rte_flow_error *error)
1949 {
1950         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
1951         struct sfc_mae_pattern_data *pdata = &ctx_mae->pattern_data;
1952         struct rte_flow_item_tcp supp_mask;
1953         const uint8_t *spec = NULL;
1954         const uint8_t *mask = NULL;
1955         int rc;
1956
1957         /*
1958          * When encountered among outermost items, item TCP is invalid.
1959          * Check which match specification is being constructed now.
1960          */
1961         if (ctx_mae->match_spec != ctx_mae->match_spec_action) {
1962                 return rte_flow_error_set(error, EINVAL,
1963                                           RTE_FLOW_ERROR_TYPE_ITEM, item,
1964                                           "TCP in outer frame is invalid");
1965         }
1966
1967         sfc_mae_item_build_supp_mask(flocs_tcp, RTE_DIM(flocs_tcp),
1968                                      &supp_mask, sizeof(supp_mask));
1969
1970         rc = sfc_flow_parse_init(item,
1971                                  (const void **)&spec, (const void **)&mask,
1972                                  (const void *)&supp_mask,
1973                                  &rte_flow_item_tcp_mask,
1974                                  sizeof(struct rte_flow_item_tcp), error);
1975         if (rc != 0)
1976                 return rc;
1977
1978         pdata->l3_next_proto_restriction_value = IPPROTO_TCP;
1979         pdata->l3_next_proto_restriction_mask = 0xff;
1980
1981         if (spec == NULL)
1982                 return 0;
1983
1984         return sfc_mae_parse_item(flocs_tcp, RTE_DIM(flocs_tcp), spec, mask,
1985                                   ctx_mae, error);
1986 }
1987
1988 static const struct sfc_mae_field_locator flocs_udp[] = {
1989         {
1990                 EFX_MAE_FIELD_L4_SPORT_BE,
1991                 RTE_SIZEOF_FIELD(struct rte_flow_item_udp, hdr.src_port),
1992                 offsetof(struct rte_flow_item_udp, hdr.src_port),
1993         },
1994         {
1995                 EFX_MAE_FIELD_L4_DPORT_BE,
1996                 RTE_SIZEOF_FIELD(struct rte_flow_item_udp, hdr.dst_port),
1997                 offsetof(struct rte_flow_item_udp, hdr.dst_port),
1998         },
1999 };
2000
2001 static int
2002 sfc_mae_rule_parse_item_udp(const struct rte_flow_item *item,
2003                             struct sfc_flow_parse_ctx *ctx,
2004                             struct rte_flow_error *error)
2005 {
2006         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
2007         struct sfc_mae_pattern_data *pdata = &ctx_mae->pattern_data;
2008         struct rte_flow_item_udp supp_mask;
2009         const uint8_t *spec = NULL;
2010         const uint8_t *mask = NULL;
2011         int rc;
2012
2013         sfc_mae_item_build_supp_mask(flocs_udp, RTE_DIM(flocs_udp),
2014                                      &supp_mask, sizeof(supp_mask));
2015
2016         rc = sfc_flow_parse_init(item,
2017                                  (const void **)&spec, (const void **)&mask,
2018                                  (const void *)&supp_mask,
2019                                  &rte_flow_item_udp_mask,
2020                                  sizeof(struct rte_flow_item_udp), error);
2021         if (rc != 0)
2022                 return rc;
2023
2024         pdata->l3_next_proto_restriction_value = IPPROTO_UDP;
2025         pdata->l3_next_proto_restriction_mask = 0xff;
2026
2027         if (spec == NULL)
2028                 return 0;
2029
2030         return sfc_mae_parse_item(flocs_udp, RTE_DIM(flocs_udp), spec, mask,
2031                                   ctx_mae, error);
2032 }
2033
2034 static const struct sfc_mae_field_locator flocs_tunnel[] = {
2035         {
2036                 /*
2037                  * The size and offset values are relevant
2038                  * for Geneve and NVGRE, too.
2039                  */
2040                 .size = RTE_SIZEOF_FIELD(struct rte_flow_item_vxlan, vni),
2041                 .ofst = offsetof(struct rte_flow_item_vxlan, vni),
2042         },
2043 };
2044
2045 /*
2046  * An auxiliary registry which allows using non-encap. field IDs
2047  * directly when building a match specification of type ACTION.
2048  *
2049  * See sfc_mae_rule_parse_pattern() and sfc_mae_rule_parse_item_tunnel().
2050  */
2051 static const efx_mae_field_id_t field_ids_no_remap[] = {
2052 #define FIELD_ID_NO_REMAP(_field) \
2053         [EFX_MAE_FIELD_##_field] = EFX_MAE_FIELD_##_field
2054
2055         FIELD_ID_NO_REMAP(ETHER_TYPE_BE),
2056         FIELD_ID_NO_REMAP(ETH_SADDR_BE),
2057         FIELD_ID_NO_REMAP(ETH_DADDR_BE),
2058         FIELD_ID_NO_REMAP(VLAN0_TCI_BE),
2059         FIELD_ID_NO_REMAP(VLAN0_PROTO_BE),
2060         FIELD_ID_NO_REMAP(VLAN1_TCI_BE),
2061         FIELD_ID_NO_REMAP(VLAN1_PROTO_BE),
2062         FIELD_ID_NO_REMAP(SRC_IP4_BE),
2063         FIELD_ID_NO_REMAP(DST_IP4_BE),
2064         FIELD_ID_NO_REMAP(IP_PROTO),
2065         FIELD_ID_NO_REMAP(IP_TOS),
2066         FIELD_ID_NO_REMAP(IP_TTL),
2067         FIELD_ID_NO_REMAP(SRC_IP6_BE),
2068         FIELD_ID_NO_REMAP(DST_IP6_BE),
2069         FIELD_ID_NO_REMAP(L4_SPORT_BE),
2070         FIELD_ID_NO_REMAP(L4_DPORT_BE),
2071         FIELD_ID_NO_REMAP(TCP_FLAGS_BE),
2072         FIELD_ID_NO_REMAP(HAS_OVLAN),
2073         FIELD_ID_NO_REMAP(HAS_IVLAN),
2074
2075 #undef FIELD_ID_NO_REMAP
2076 };
2077
2078 /*
2079  * An auxiliary registry which allows using "ENC" field IDs
2080  * when building a match specification of type OUTER.
2081  *
2082  * See sfc_mae_rule_encap_parse_init().
2083  */
2084 static const efx_mae_field_id_t field_ids_remap_to_encap[] = {
2085 #define FIELD_ID_REMAP_TO_ENCAP(_field) \
2086         [EFX_MAE_FIELD_##_field] = EFX_MAE_FIELD_ENC_##_field
2087
2088         FIELD_ID_REMAP_TO_ENCAP(ETHER_TYPE_BE),
2089         FIELD_ID_REMAP_TO_ENCAP(ETH_SADDR_BE),
2090         FIELD_ID_REMAP_TO_ENCAP(ETH_DADDR_BE),
2091         FIELD_ID_REMAP_TO_ENCAP(VLAN0_TCI_BE),
2092         FIELD_ID_REMAP_TO_ENCAP(VLAN0_PROTO_BE),
2093         FIELD_ID_REMAP_TO_ENCAP(VLAN1_TCI_BE),
2094         FIELD_ID_REMAP_TO_ENCAP(VLAN1_PROTO_BE),
2095         FIELD_ID_REMAP_TO_ENCAP(SRC_IP4_BE),
2096         FIELD_ID_REMAP_TO_ENCAP(DST_IP4_BE),
2097         FIELD_ID_REMAP_TO_ENCAP(IP_PROTO),
2098         FIELD_ID_REMAP_TO_ENCAP(IP_TOS),
2099         FIELD_ID_REMAP_TO_ENCAP(IP_TTL),
2100         FIELD_ID_REMAP_TO_ENCAP(SRC_IP6_BE),
2101         FIELD_ID_REMAP_TO_ENCAP(DST_IP6_BE),
2102         FIELD_ID_REMAP_TO_ENCAP(L4_SPORT_BE),
2103         FIELD_ID_REMAP_TO_ENCAP(L4_DPORT_BE),
2104         FIELD_ID_REMAP_TO_ENCAP(HAS_OVLAN),
2105         FIELD_ID_REMAP_TO_ENCAP(HAS_IVLAN),
2106
2107 #undef FIELD_ID_REMAP_TO_ENCAP
2108 };
2109
2110 static int
2111 sfc_mae_rule_parse_item_tunnel(const struct rte_flow_item *item,
2112                                struct sfc_flow_parse_ctx *ctx,
2113                                struct rte_flow_error *error)
2114 {
2115         struct sfc_mae_parse_ctx *ctx_mae = ctx->mae;
2116         uint8_t vnet_id_v[sizeof(uint32_t)] = {0};
2117         uint8_t vnet_id_m[sizeof(uint32_t)] = {0};
2118         const struct rte_flow_item_vxlan *vxp;
2119         uint8_t supp_mask[sizeof(uint64_t)];
2120         const uint8_t *spec = NULL;
2121         const uint8_t *mask = NULL;
2122         int rc;
2123
2124         /*
2125          * We're about to start processing inner frame items.
2126          * Process pattern data that has been deferred so far
2127          * and reset pattern data storage.
2128          */
2129         rc = sfc_mae_rule_process_pattern_data(ctx_mae, error);
2130         if (rc != 0)
2131                 return rc;
2132
2133         memset(&ctx_mae->pattern_data, 0, sizeof(ctx_mae->pattern_data));
2134
2135         sfc_mae_item_build_supp_mask(flocs_tunnel, RTE_DIM(flocs_tunnel),
2136                                      &supp_mask, sizeof(supp_mask));
2137
2138         /*
2139          * This tunnel item was preliminarily detected by
2140          * sfc_mae_rule_encap_parse_init(). Default mask
2141          * was also picked by that helper. Use it here.
2142          */
2143         rc = sfc_flow_parse_init(item,
2144                                  (const void **)&spec, (const void **)&mask,
2145                                  (const void *)&supp_mask,
2146                                  ctx_mae->tunnel_def_mask,
2147                                  ctx_mae->tunnel_def_mask_size,  error);
2148         if (rc != 0)
2149                 return rc;
2150
2151         /*
2152          * This item and later ones comprise a
2153          * match specification of type ACTION.
2154          */
2155         ctx_mae->match_spec = ctx_mae->match_spec_action;
2156
2157         /* This item and later ones use non-encap. EFX MAE field IDs. */
2158         ctx_mae->field_ids_remap = field_ids_no_remap;
2159
2160         if (spec == NULL)
2161                 return 0;
2162
2163         /*
2164          * Field EFX_MAE_FIELD_ENC_VNET_ID_BE is a 32-bit one.
2165          * Copy 24-bit VNI, which is BE, at offset 1 in it.
2166          * The extra byte is 0 both in the mask and in the value.
2167          */
2168         vxp = (const struct rte_flow_item_vxlan *)spec;
2169         memcpy(vnet_id_v + 1, &vxp->vni, sizeof(vxp->vni));
2170
2171         vxp = (const struct rte_flow_item_vxlan *)mask;
2172         memcpy(vnet_id_m + 1, &vxp->vni, sizeof(vxp->vni));
2173
2174         rc = efx_mae_match_spec_field_set(ctx_mae->match_spec,
2175                                           EFX_MAE_FIELD_ENC_VNET_ID_BE,
2176                                           sizeof(vnet_id_v), vnet_id_v,
2177                                           sizeof(vnet_id_m), vnet_id_m);
2178         if (rc != 0) {
2179                 rc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ITEM,
2180                                         item, "Failed to set VXLAN VNI");
2181         }
2182
2183         return rc;
2184 }
2185
2186 static const struct sfc_flow_item sfc_flow_items[] = {
2187         {
2188                 .type = RTE_FLOW_ITEM_TYPE_MARK,
2189                 .name = "MARK",
2190                 .prev_layer = SFC_FLOW_ITEM_ANY_LAYER,
2191                 .layer = SFC_FLOW_ITEM_ANY_LAYER,
2192                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2193                 .parse = sfc_mae_rule_parse_item_mark,
2194         },
2195         {
2196                 .type = RTE_FLOW_ITEM_TYPE_PORT_ID,
2197                 .name = "PORT_ID",
2198                 /*
2199                  * In terms of RTE flow, this item is a META one,
2200                  * and its position in the pattern is don't care.
2201                  */
2202                 .prev_layer = SFC_FLOW_ITEM_ANY_LAYER,
2203                 .layer = SFC_FLOW_ITEM_ANY_LAYER,
2204                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2205                 .parse = sfc_mae_rule_parse_item_port_id,
2206         },
2207         {
2208                 .type = RTE_FLOW_ITEM_TYPE_PHY_PORT,
2209                 .name = "PHY_PORT",
2210                 /*
2211                  * In terms of RTE flow, this item is a META one,
2212                  * and its position in the pattern is don't care.
2213                  */
2214                 .prev_layer = SFC_FLOW_ITEM_ANY_LAYER,
2215                 .layer = SFC_FLOW_ITEM_ANY_LAYER,
2216                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2217                 .parse = sfc_mae_rule_parse_item_phy_port,
2218         },
2219         {
2220                 .type = RTE_FLOW_ITEM_TYPE_PF,
2221                 .name = "PF",
2222                 /*
2223                  * In terms of RTE flow, this item is a META one,
2224                  * and its position in the pattern is don't care.
2225                  */
2226                 .prev_layer = SFC_FLOW_ITEM_ANY_LAYER,
2227                 .layer = SFC_FLOW_ITEM_ANY_LAYER,
2228                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2229                 .parse = sfc_mae_rule_parse_item_pf,
2230         },
2231         {
2232                 .type = RTE_FLOW_ITEM_TYPE_VF,
2233                 .name = "VF",
2234                 /*
2235                  * In terms of RTE flow, this item is a META one,
2236                  * and its position in the pattern is don't care.
2237                  */
2238                 .prev_layer = SFC_FLOW_ITEM_ANY_LAYER,
2239                 .layer = SFC_FLOW_ITEM_ANY_LAYER,
2240                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2241                 .parse = sfc_mae_rule_parse_item_vf,
2242         },
2243         {
2244                 .type = RTE_FLOW_ITEM_TYPE_ETH,
2245                 .name = "ETH",
2246                 .prev_layer = SFC_FLOW_ITEM_START_LAYER,
2247                 .layer = SFC_FLOW_ITEM_L2,
2248                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2249                 .parse = sfc_mae_rule_parse_item_eth,
2250         },
2251         {
2252                 .type = RTE_FLOW_ITEM_TYPE_VLAN,
2253                 .name = "VLAN",
2254                 .prev_layer = SFC_FLOW_ITEM_L2,
2255                 .layer = SFC_FLOW_ITEM_L2,
2256                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2257                 .parse = sfc_mae_rule_parse_item_vlan,
2258         },
2259         {
2260                 .type = RTE_FLOW_ITEM_TYPE_IPV4,
2261                 .name = "IPV4",
2262                 .prev_layer = SFC_FLOW_ITEM_L2,
2263                 .layer = SFC_FLOW_ITEM_L3,
2264                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2265                 .parse = sfc_mae_rule_parse_item_ipv4,
2266         },
2267         {
2268                 .type = RTE_FLOW_ITEM_TYPE_IPV6,
2269                 .name = "IPV6",
2270                 .prev_layer = SFC_FLOW_ITEM_L2,
2271                 .layer = SFC_FLOW_ITEM_L3,
2272                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2273                 .parse = sfc_mae_rule_parse_item_ipv6,
2274         },
2275         {
2276                 .type = RTE_FLOW_ITEM_TYPE_TCP,
2277                 .name = "TCP",
2278                 .prev_layer = SFC_FLOW_ITEM_L3,
2279                 .layer = SFC_FLOW_ITEM_L4,
2280                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2281                 .parse = sfc_mae_rule_parse_item_tcp,
2282         },
2283         {
2284                 .type = RTE_FLOW_ITEM_TYPE_UDP,
2285                 .name = "UDP",
2286                 .prev_layer = SFC_FLOW_ITEM_L3,
2287                 .layer = SFC_FLOW_ITEM_L4,
2288                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2289                 .parse = sfc_mae_rule_parse_item_udp,
2290         },
2291         {
2292                 .type = RTE_FLOW_ITEM_TYPE_VXLAN,
2293                 .name = "VXLAN",
2294                 .prev_layer = SFC_FLOW_ITEM_L4,
2295                 .layer = SFC_FLOW_ITEM_START_LAYER,
2296                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2297                 .parse = sfc_mae_rule_parse_item_tunnel,
2298         },
2299         {
2300                 .type = RTE_FLOW_ITEM_TYPE_GENEVE,
2301                 .name = "GENEVE",
2302                 .prev_layer = SFC_FLOW_ITEM_L4,
2303                 .layer = SFC_FLOW_ITEM_START_LAYER,
2304                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2305                 .parse = sfc_mae_rule_parse_item_tunnel,
2306         },
2307         {
2308                 .type = RTE_FLOW_ITEM_TYPE_NVGRE,
2309                 .name = "NVGRE",
2310                 .prev_layer = SFC_FLOW_ITEM_L3,
2311                 .layer = SFC_FLOW_ITEM_START_LAYER,
2312                 .ctx_type = SFC_FLOW_PARSE_CTX_MAE,
2313                 .parse = sfc_mae_rule_parse_item_tunnel,
2314         },
2315 };
2316
2317 static int
2318 sfc_mae_rule_process_outer(struct sfc_adapter *sa,
2319                            struct sfc_mae_parse_ctx *ctx,
2320                            struct sfc_mae_outer_rule **rulep,
2321                            struct rte_flow_error *error)
2322 {
2323         efx_mae_rule_id_t invalid_rule_id = { .id = EFX_MAE_RSRC_ID_INVALID };
2324         int rc;
2325
2326         if (ctx->encap_type == EFX_TUNNEL_PROTOCOL_NONE) {
2327                 *rulep = NULL;
2328                 goto no_or_id;
2329         }
2330
2331         SFC_ASSERT(ctx->match_spec_outer != NULL);
2332
2333         if (!efx_mae_match_spec_is_valid(sa->nic, ctx->match_spec_outer)) {
2334                 return rte_flow_error_set(error, ENOTSUP,
2335                                           RTE_FLOW_ERROR_TYPE_ITEM, NULL,
2336                                           "Inconsistent pattern (outer)");
2337         }
2338
2339         *rulep = sfc_mae_outer_rule_attach(sa, ctx->match_spec_outer,
2340                                            ctx->encap_type);
2341         if (*rulep != NULL) {
2342                 efx_mae_match_spec_fini(sa->nic, ctx->match_spec_outer);
2343         } else {
2344                 rc = sfc_mae_outer_rule_add(sa, ctx->match_spec_outer,
2345                                             ctx->encap_type, rulep);
2346                 if (rc != 0) {
2347                         return rte_flow_error_set(error, rc,
2348                                         RTE_FLOW_ERROR_TYPE_ITEM, NULL,
2349                                         "Failed to process the pattern");
2350                 }
2351         }
2352
2353         /* The spec has now been tracked by the outer rule entry. */
2354         ctx->match_spec_outer = NULL;
2355
2356 no_or_id:
2357         switch (ctx->ft_rule_type) {
2358         case SFC_FT_RULE_NONE:
2359                 break;
2360         case SFC_FT_RULE_JUMP:
2361                 /* No action rule */
2362                 return 0;
2363         case SFC_FT_RULE_GROUP:
2364                 /*
2365                  * Match on recirculation ID rather than
2366                  * on the outer rule allocation handle.
2367                  */
2368                 rc = efx_mae_match_spec_recirc_id_set(ctx->match_spec_action,
2369                                         SFC_FT_ID_TO_TUNNEL_MARK(ctx->ft->id));
2370                 if (rc != 0) {
2371                         return rte_flow_error_set(error, rc,
2372                                         RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
2373                                         "tunnel offload: GROUP: AR: failed to request match on RECIRC_ID");
2374                 }
2375                 return 0;
2376         default:
2377                 SFC_ASSERT(B_FALSE);
2378         }
2379
2380         /*
2381          * In MAE, lookup sequence comprises outer parse, outer rule lookup,
2382          * inner parse (when some outer rule is hit) and action rule lookup.
2383          * If the currently processed flow does not come with an outer rule,
2384          * its action rule must be available only for packets which miss in
2385          * outer rule table. Set OR_ID match field to 0xffffffff/0xffffffff
2386          * in the action rule specification; this ensures correct behaviour.
2387          *
2388          * If, on the other hand, this flow does have an outer rule, its ID
2389          * may be unknown at the moment (not yet allocated), but OR_ID mask
2390          * has to be set to 0xffffffff anyway for correct class comparisons.
2391          * When the outer rule has been allocated, this match field will be
2392          * overridden by sfc_mae_outer_rule_enable() to use the right value.
2393          */
2394         rc = efx_mae_match_spec_outer_rule_id_set(ctx->match_spec_action,
2395                                                   &invalid_rule_id);
2396         if (rc != 0) {
2397                 if (*rulep != NULL)
2398                         sfc_mae_outer_rule_del(sa, *rulep);
2399
2400                 *rulep = NULL;
2401
2402                 return rte_flow_error_set(error, rc,
2403                                           RTE_FLOW_ERROR_TYPE_ITEM, NULL,
2404                                           "Failed to process the pattern");
2405         }
2406
2407         return 0;
2408 }
2409
2410 static int
2411 sfc_mae_rule_preparse_item_mark(const struct rte_flow_item_mark *spec,
2412                                 struct sfc_mae_parse_ctx *ctx)
2413 {
2414         struct sfc_flow_tunnel *ft;
2415         uint32_t user_mark;
2416
2417         if (spec == NULL) {
2418                 sfc_err(ctx->sa, "tunnel offload: GROUP: NULL spec in item MARK");
2419                 return EINVAL;
2420         }
2421
2422         ft = sfc_flow_tunnel_pick(ctx->sa, spec->id);
2423         if (ft == NULL) {
2424                 sfc_err(ctx->sa, "tunnel offload: GROUP: invalid tunnel");
2425                 return EINVAL;
2426         }
2427
2428         if (ft->refcnt == 0) {
2429                 sfc_err(ctx->sa, "tunnel offload: GROUP: tunnel=%u does not exist",
2430                         ft->id);
2431                 return ENOENT;
2432         }
2433
2434         user_mark = SFC_FT_GET_USER_MARK(spec->id);
2435         if (user_mark != 0) {
2436                 sfc_err(ctx->sa, "tunnel offload: GROUP: invalid item MARK");
2437                 return EINVAL;
2438         }
2439
2440         sfc_dbg(ctx->sa, "tunnel offload: GROUP: detected");
2441
2442         ctx->ft_rule_type = SFC_FT_RULE_GROUP;
2443         ctx->ft = ft;
2444
2445         return 0;
2446 }
2447
2448 static int
2449 sfc_mae_rule_encap_parse_init(struct sfc_adapter *sa,
2450                               const struct rte_flow_item pattern[],
2451                               struct sfc_mae_parse_ctx *ctx,
2452                               struct rte_flow_error *error)
2453 {
2454         struct sfc_mae *mae = &sa->mae;
2455         uint8_t recirc_id = 0;
2456         int rc;
2457
2458         if (pattern == NULL) {
2459                 rte_flow_error_set(error, EINVAL,
2460                                    RTE_FLOW_ERROR_TYPE_ITEM_NUM, NULL,
2461                                    "NULL pattern");
2462                 return -rte_errno;
2463         }
2464
2465         for (;;) {
2466                 switch (pattern->type) {
2467                 case RTE_FLOW_ITEM_TYPE_MARK:
2468                         rc = sfc_mae_rule_preparse_item_mark(pattern->spec,
2469                                                              ctx);
2470                         if (rc != 0) {
2471                                 return rte_flow_error_set(error, rc,
2472                                                   RTE_FLOW_ERROR_TYPE_ITEM,
2473                                                   pattern, "tunnel offload: GROUP: invalid item MARK");
2474                         }
2475                         ++pattern;
2476                         continue;
2477                 case RTE_FLOW_ITEM_TYPE_VXLAN:
2478                         ctx->encap_type = EFX_TUNNEL_PROTOCOL_VXLAN;
2479                         ctx->tunnel_def_mask = &rte_flow_item_vxlan_mask;
2480                         ctx->tunnel_def_mask_size =
2481                                 sizeof(rte_flow_item_vxlan_mask);
2482                         break;
2483                 case RTE_FLOW_ITEM_TYPE_GENEVE:
2484                         ctx->encap_type = EFX_TUNNEL_PROTOCOL_GENEVE;
2485                         ctx->tunnel_def_mask = &rte_flow_item_geneve_mask;
2486                         ctx->tunnel_def_mask_size =
2487                                 sizeof(rte_flow_item_geneve_mask);
2488                         break;
2489                 case RTE_FLOW_ITEM_TYPE_NVGRE:
2490                         ctx->encap_type = EFX_TUNNEL_PROTOCOL_NVGRE;
2491                         ctx->tunnel_def_mask = &rte_flow_item_nvgre_mask;
2492                         ctx->tunnel_def_mask_size =
2493                                 sizeof(rte_flow_item_nvgre_mask);
2494                         break;
2495                 case RTE_FLOW_ITEM_TYPE_END:
2496                         break;
2497                 default:
2498                         ++pattern;
2499                         continue;
2500                 };
2501
2502                 break;
2503         }
2504
2505         switch (ctx->ft_rule_type) {
2506         case SFC_FT_RULE_NONE:
2507                 if (pattern->type == RTE_FLOW_ITEM_TYPE_END)
2508                         return 0;
2509                 break;
2510         case SFC_FT_RULE_JUMP:
2511                 if (pattern->type != RTE_FLOW_ITEM_TYPE_END) {
2512                         return rte_flow_error_set(error, ENOTSUP,
2513                                                   RTE_FLOW_ERROR_TYPE_ITEM,
2514                                                   pattern, "tunnel offload: JUMP: invalid item");
2515                 }
2516                 ctx->encap_type = ctx->ft->encap_type;
2517                 break;
2518         case SFC_FT_RULE_GROUP:
2519                 if (pattern->type == RTE_FLOW_ITEM_TYPE_END) {
2520                         return rte_flow_error_set(error, EINVAL,
2521                                                   RTE_FLOW_ERROR_TYPE_ITEM,
2522                                                   NULL, "tunnel offload: GROUP: missing tunnel item");
2523                 } else if (ctx->encap_type != ctx->ft->encap_type) {
2524                         return rte_flow_error_set(error, EINVAL,
2525                                                   RTE_FLOW_ERROR_TYPE_ITEM,
2526                                                   pattern, "tunnel offload: GROUP: tunnel type mismatch");
2527                 }
2528                 break;
2529         default:
2530                 SFC_ASSERT(B_FALSE);
2531                 break;
2532         }
2533
2534         if ((mae->encap_types_supported & (1U << ctx->encap_type)) == 0) {
2535                 return rte_flow_error_set(error, ENOTSUP,
2536                                           RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
2537                                           "OR: unsupported tunnel type");
2538         }
2539
2540         switch (ctx->ft_rule_type) {
2541         case SFC_FT_RULE_JUMP:
2542                 recirc_id = SFC_FT_ID_TO_TUNNEL_MARK(ctx->ft->id);
2543                 /* FALLTHROUGH */
2544         case SFC_FT_RULE_NONE:
2545                 if (ctx->priority >= mae->nb_outer_rule_prios_max) {
2546                         return rte_flow_error_set(error, ENOTSUP,
2547                                         RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,
2548                                         NULL, "OR: unsupported priority level");
2549                 }
2550
2551                 rc = efx_mae_match_spec_init(sa->nic,
2552                                              EFX_MAE_RULE_OUTER, ctx->priority,
2553                                              &ctx->match_spec_outer);
2554                 if (rc != 0) {
2555                         return rte_flow_error_set(error, rc,
2556                                 RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
2557                                 "OR: failed to initialise the match specification");
2558                 }
2559
2560                 /*
2561                  * Outermost items comprise a match
2562                  * specification of type OUTER.
2563                  */
2564                 ctx->match_spec = ctx->match_spec_outer;
2565
2566                 /* Outermost items use "ENC" EFX MAE field IDs. */
2567                 ctx->field_ids_remap = field_ids_remap_to_encap;
2568
2569                 rc = efx_mae_outer_rule_recirc_id_set(ctx->match_spec,
2570                                                       recirc_id);
2571                 if (rc != 0) {
2572                         return rte_flow_error_set(error, rc,
2573                                         RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
2574                                         "OR: failed to initialise RECIRC_ID");
2575                 }
2576                 break;
2577         case SFC_FT_RULE_GROUP:
2578                 /* Outermost items -> "ENC" match fields in the action rule. */
2579                 ctx->field_ids_remap = field_ids_remap_to_encap;
2580                 ctx->match_spec = ctx->match_spec_action;
2581
2582                 /* No own outer rule; match on JUMP OR's RECIRC_ID is used. */
2583                 ctx->encap_type = EFX_TUNNEL_PROTOCOL_NONE;
2584                 break;
2585         default:
2586                 SFC_ASSERT(B_FALSE);
2587                 break;
2588         }
2589
2590         return 0;
2591 }
2592
2593 static void
2594 sfc_mae_rule_encap_parse_fini(struct sfc_adapter *sa,
2595                               struct sfc_mae_parse_ctx *ctx)
2596 {
2597         if (ctx->encap_type == EFX_TUNNEL_PROTOCOL_NONE)
2598                 return;
2599
2600         if (ctx->match_spec_outer != NULL)
2601                 efx_mae_match_spec_fini(sa->nic, ctx->match_spec_outer);
2602 }
2603
2604 int
2605 sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,
2606                            const struct rte_flow_item pattern[],
2607                            struct sfc_flow_spec_mae *spec,
2608                            struct rte_flow_error *error)
2609 {
2610         struct sfc_mae_parse_ctx ctx_mae;
2611         unsigned int priority_shift = 0;
2612         struct sfc_flow_parse_ctx ctx;
2613         int rc;
2614
2615         memset(&ctx_mae, 0, sizeof(ctx_mae));
2616         ctx_mae.ft_rule_type = spec->ft_rule_type;
2617         ctx_mae.priority = spec->priority;
2618         ctx_mae.ft = spec->ft;
2619         ctx_mae.sa = sa;
2620
2621         switch (ctx_mae.ft_rule_type) {
2622         case SFC_FT_RULE_JUMP:
2623                 /*
2624                  * By design, this flow should be represented solely by the
2625                  * outer rule. But the HW/FW hasn't got support for setting
2626                  * Rx mark from RECIRC_ID on outer rule lookup yet. Neither
2627                  * does it support outer rule counters. As a workaround, an
2628                  * action rule of lower priority is used to do the job.
2629                  */
2630                 priority_shift = 1;
2631
2632                 /* FALLTHROUGH */
2633         case SFC_FT_RULE_GROUP:
2634                 if (ctx_mae.priority != 0) {
2635                         /*
2636                          * Because of the above workaround, deny the
2637                          * use of priorities to JUMP and GROUP rules.
2638                          */
2639                         rc = rte_flow_error_set(error, ENOTSUP,
2640                                 RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY, NULL,
2641                                 "tunnel offload: priorities are not supported");
2642                         goto fail_priority_check;
2643                 }
2644
2645                 /* FALLTHROUGH */
2646         case SFC_FT_RULE_NONE:
2647                 rc = efx_mae_match_spec_init(sa->nic, EFX_MAE_RULE_ACTION,
2648                                              spec->priority + priority_shift,
2649                                              &ctx_mae.match_spec_action);
2650                 if (rc != 0) {
2651                         rc = rte_flow_error_set(error, rc,
2652                                 RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
2653                                 "AR: failed to initialise the match specification");
2654                         goto fail_init_match_spec_action;
2655                 }
2656                 break;
2657         default:
2658                 SFC_ASSERT(B_FALSE);
2659                 break;
2660         }
2661
2662         /*
2663          * As a preliminary setting, assume that there is no encapsulation
2664          * in the pattern. That is, pattern items are about to comprise a
2665          * match specification of type ACTION and use non-encap. field IDs.
2666          *
2667          * sfc_mae_rule_encap_parse_init() below may override this.
2668          */
2669         ctx_mae.encap_type = EFX_TUNNEL_PROTOCOL_NONE;
2670         ctx_mae.match_spec = ctx_mae.match_spec_action;
2671         ctx_mae.field_ids_remap = field_ids_no_remap;
2672
2673         ctx.type = SFC_FLOW_PARSE_CTX_MAE;
2674         ctx.mae = &ctx_mae;
2675
2676         rc = sfc_mae_rule_encap_parse_init(sa, pattern, &ctx_mae, error);
2677         if (rc != 0)
2678                 goto fail_encap_parse_init;
2679
2680         /*
2681          * sfc_mae_rule_encap_parse_init() may have detected tunnel offload
2682          * GROUP rule. Remember its properties for later use.
2683          */
2684         spec->ft_rule_type = ctx_mae.ft_rule_type;
2685         spec->ft = ctx_mae.ft;
2686
2687         rc = sfc_flow_parse_pattern(sa, sfc_flow_items, RTE_DIM(sfc_flow_items),
2688                                     pattern, &ctx, error);
2689         if (rc != 0)
2690                 goto fail_parse_pattern;
2691
2692         rc = sfc_mae_rule_process_pattern_data(&ctx_mae, error);
2693         if (rc != 0)
2694                 goto fail_process_pattern_data;
2695
2696         rc = sfc_mae_rule_process_outer(sa, &ctx_mae, &spec->outer_rule, error);
2697         if (rc != 0)
2698                 goto fail_process_outer;
2699
2700         if (ctx_mae.match_spec_action != NULL &&
2701             !efx_mae_match_spec_is_valid(sa->nic, ctx_mae.match_spec_action)) {
2702                 rc = rte_flow_error_set(error, ENOTSUP,
2703                                         RTE_FLOW_ERROR_TYPE_ITEM, NULL,
2704                                         "Inconsistent pattern");
2705                 goto fail_validate_match_spec_action;
2706         }
2707
2708         spec->match_spec = ctx_mae.match_spec_action;
2709
2710         return 0;
2711
2712 fail_validate_match_spec_action:
2713 fail_process_outer:
2714 fail_process_pattern_data:
2715 fail_parse_pattern:
2716         sfc_mae_rule_encap_parse_fini(sa, &ctx_mae);
2717
2718 fail_encap_parse_init:
2719         if (ctx_mae.match_spec_action != NULL)
2720                 efx_mae_match_spec_fini(sa->nic, ctx_mae.match_spec_action);
2721
2722 fail_init_match_spec_action:
2723 fail_priority_check:
2724         return rc;
2725 }
2726
2727 /*
2728  * An action supported by MAE may correspond to a bundle of RTE flow actions,
2729  * in example, VLAN_PUSH = OF_PUSH_VLAN + OF_VLAN_SET_VID + OF_VLAN_SET_PCP.
2730  * That is, related RTE flow actions need to be tracked as parts of a whole
2731  * so that they can be combined into a single action and submitted to MAE
2732  * representation of a given rule's action set.
2733  *
2734  * Each RTE flow action provided by an application gets classified as
2735  * one belonging to some bundle type. If an action is not supposed to
2736  * belong to any bundle, or if this action is END, it is described as
2737  * one belonging to a dummy bundle of type EMPTY.
2738  *
2739  * A currently tracked bundle will be submitted if a repeating
2740  * action or an action of different bundle type follows.
2741  */
2742
2743 enum sfc_mae_actions_bundle_type {
2744         SFC_MAE_ACTIONS_BUNDLE_EMPTY = 0,
2745         SFC_MAE_ACTIONS_BUNDLE_VLAN_PUSH,
2746 };
2747
2748 struct sfc_mae_actions_bundle {
2749         enum sfc_mae_actions_bundle_type        type;
2750
2751         /* Indicates actions already tracked by the current bundle */
2752         uint64_t                                actions_mask;
2753
2754         /* Parameters used by SFC_MAE_ACTIONS_BUNDLE_VLAN_PUSH */
2755         rte_be16_t                              vlan_push_tpid;
2756         rte_be16_t                              vlan_push_tci;
2757 };
2758
2759 /*
2760  * Combine configuration of RTE flow actions tracked by the bundle into a
2761  * single action and submit the result to MAE action set specification.
2762  * Do nothing in the case of dummy action bundle.
2763  */
2764 static int
2765 sfc_mae_actions_bundle_submit(const struct sfc_mae_actions_bundle *bundle,
2766                               efx_mae_actions_t *spec)
2767 {
2768         int rc = 0;
2769
2770         switch (bundle->type) {
2771         case SFC_MAE_ACTIONS_BUNDLE_EMPTY:
2772                 break;
2773         case SFC_MAE_ACTIONS_BUNDLE_VLAN_PUSH:
2774                 rc = efx_mae_action_set_populate_vlan_push(
2775                         spec, bundle->vlan_push_tpid, bundle->vlan_push_tci);
2776                 break;
2777         default:
2778                 SFC_ASSERT(B_FALSE);
2779                 break;
2780         }
2781
2782         return rc;
2783 }
2784
2785 /*
2786  * Given the type of the next RTE flow action in the line, decide
2787  * whether a new bundle is about to start, and, if this is the case,
2788  * submit and reset the current bundle.
2789  */
2790 static int
2791 sfc_mae_actions_bundle_sync(const struct rte_flow_action *action,
2792                             struct sfc_mae_actions_bundle *bundle,
2793                             efx_mae_actions_t *spec,
2794                             struct rte_flow_error *error)
2795 {
2796         enum sfc_mae_actions_bundle_type bundle_type_new;
2797         int rc;
2798
2799         switch (action->type) {
2800         case RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN:
2801         case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID:
2802         case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP:
2803                 bundle_type_new = SFC_MAE_ACTIONS_BUNDLE_VLAN_PUSH;
2804                 break;
2805         default:
2806                 /*
2807                  * Self-sufficient actions, including END, are handled in this
2808                  * case. No checks for unsupported actions are needed here
2809                  * because parsing doesn't occur at this point.
2810                  */
2811                 bundle_type_new = SFC_MAE_ACTIONS_BUNDLE_EMPTY;
2812                 break;
2813         }
2814
2815         if (bundle_type_new != bundle->type ||
2816             (bundle->actions_mask & (1ULL << action->type)) != 0) {
2817                 rc = sfc_mae_actions_bundle_submit(bundle, spec);
2818                 if (rc != 0)
2819                         goto fail_submit;
2820
2821                 memset(bundle, 0, sizeof(*bundle));
2822         }
2823
2824         bundle->type = bundle_type_new;
2825
2826         return 0;
2827
2828 fail_submit:
2829         return rte_flow_error_set(error, rc,
2830                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
2831                         "Failed to request the (group of) action(s)");
2832 }
2833
2834 static void
2835 sfc_mae_rule_parse_action_of_push_vlan(
2836                             const struct rte_flow_action_of_push_vlan *conf,
2837                             struct sfc_mae_actions_bundle *bundle)
2838 {
2839         bundle->vlan_push_tpid = conf->ethertype;
2840 }
2841
2842 static void
2843 sfc_mae_rule_parse_action_of_set_vlan_vid(
2844                             const struct rte_flow_action_of_set_vlan_vid *conf,
2845                             struct sfc_mae_actions_bundle *bundle)
2846 {
2847         bundle->vlan_push_tci |= (conf->vlan_vid &
2848                                   rte_cpu_to_be_16(RTE_LEN2MASK(12, uint16_t)));
2849 }
2850
2851 static void
2852 sfc_mae_rule_parse_action_of_set_vlan_pcp(
2853                             const struct rte_flow_action_of_set_vlan_pcp *conf,
2854                             struct sfc_mae_actions_bundle *bundle)
2855 {
2856         uint16_t vlan_tci_pcp = (uint16_t)(conf->vlan_pcp &
2857                                            RTE_LEN2MASK(3, uint8_t)) << 13;
2858
2859         bundle->vlan_push_tci |= rte_cpu_to_be_16(vlan_tci_pcp);
2860 }
2861
2862 struct sfc_mae_parsed_item {
2863         const struct rte_flow_item      *item;
2864         size_t                          proto_header_ofst;
2865         size_t                          proto_header_size;
2866 };
2867
2868 /*
2869  * For each 16-bit word of the given header, override
2870  * bits enforced by the corresponding 16-bit mask.
2871  */
2872 static void
2873 sfc_mae_header_force_item_masks(uint8_t *header_buf,
2874                                 const struct sfc_mae_parsed_item *parsed_items,
2875                                 unsigned int nb_parsed_items)
2876 {
2877         unsigned int item_idx;
2878
2879         for (item_idx = 0; item_idx < nb_parsed_items; ++item_idx) {
2880                 const struct sfc_mae_parsed_item *parsed_item;
2881                 const struct rte_flow_item *item;
2882                 size_t proto_header_size;
2883                 size_t ofst;
2884
2885                 parsed_item = &parsed_items[item_idx];
2886                 proto_header_size = parsed_item->proto_header_size;
2887                 item = parsed_item->item;
2888
2889                 for (ofst = 0; ofst < proto_header_size;
2890                      ofst += sizeof(rte_be16_t)) {
2891                         rte_be16_t *wp = RTE_PTR_ADD(header_buf, ofst);
2892                         const rte_be16_t *w_maskp;
2893                         const rte_be16_t *w_specp;
2894
2895                         w_maskp = RTE_PTR_ADD(item->mask, ofst);
2896                         w_specp = RTE_PTR_ADD(item->spec, ofst);
2897
2898                         *wp &= ~(*w_maskp);
2899                         *wp |= (*w_specp & *w_maskp);
2900                 }
2901
2902                 header_buf += proto_header_size;
2903         }
2904 }
2905
2906 #define SFC_IPV4_TTL_DEF        0x40
2907 #define SFC_IPV6_VTC_FLOW_DEF   0x60000000
2908 #define SFC_IPV6_HOP_LIMITS_DEF 0xff
2909 #define SFC_VXLAN_FLAGS_DEF     0x08000000
2910
2911 static int
2912 sfc_mae_rule_parse_action_vxlan_encap(
2913                             struct sfc_mae *mae,
2914                             const struct rte_flow_action_vxlan_encap *conf,
2915                             efx_mae_actions_t *spec,
2916                             struct rte_flow_error *error)
2917 {
2918         struct sfc_mae_bounce_eh *bounce_eh = &mae->bounce_eh;
2919         struct rte_flow_item *pattern = conf->definition;
2920         uint8_t *buf = bounce_eh->buf;
2921
2922         /* This array will keep track of non-VOID pattern items. */
2923         struct sfc_mae_parsed_item parsed_items[1 /* Ethernet */ +
2924                                                 2 /* VLAN tags */ +
2925                                                 1 /* IPv4 or IPv6 */ +
2926                                                 1 /* UDP */ +
2927                                                 1 /* VXLAN */];
2928         unsigned int nb_parsed_items = 0;
2929
2930         size_t eth_ethertype_ofst = offsetof(struct rte_ether_hdr, ether_type);
2931         uint8_t dummy_buf[RTE_MAX(sizeof(struct rte_ipv4_hdr),
2932                                   sizeof(struct rte_ipv6_hdr))];
2933         struct rte_ipv4_hdr *ipv4 = (void *)dummy_buf;
2934         struct rte_ipv6_hdr *ipv6 = (void *)dummy_buf;
2935         struct rte_vxlan_hdr *vxlan = NULL;
2936         struct rte_udp_hdr *udp = NULL;
2937         unsigned int nb_vlan_tags = 0;
2938         size_t next_proto_ofst = 0;
2939         size_t ethertype_ofst = 0;
2940         uint64_t exp_items;
2941         int rc;
2942
2943         if (pattern == NULL) {
2944                 return rte_flow_error_set(error, EINVAL,
2945                                 RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
2946                                 "The encap. header definition is NULL");
2947         }
2948
2949         bounce_eh->type = EFX_TUNNEL_PROTOCOL_VXLAN;
2950         bounce_eh->size = 0;
2951
2952         /*
2953          * Process pattern items and remember non-VOID ones.
2954          * Defer applying masks until after the complete header
2955          * has been built from the pattern items.
2956          */
2957         exp_items = RTE_BIT64(RTE_FLOW_ITEM_TYPE_ETH);
2958
2959         for (; pattern->type != RTE_FLOW_ITEM_TYPE_END; ++pattern) {
2960                 struct sfc_mae_parsed_item *parsed_item;
2961                 const uint64_t exp_items_extra_vlan[] = {
2962                         RTE_BIT64(RTE_FLOW_ITEM_TYPE_VLAN), 0
2963                 };
2964                 size_t proto_header_size;
2965                 rte_be16_t *ethertypep;
2966                 uint8_t *next_protop;
2967                 uint8_t *buf_cur;
2968
2969                 if (pattern->spec == NULL) {
2970                         return rte_flow_error_set(error, EINVAL,
2971                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
2972                                         "NULL item spec in the encap. header");
2973                 }
2974
2975                 if (pattern->mask == NULL) {
2976                         return rte_flow_error_set(error, EINVAL,
2977                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
2978                                         "NULL item mask in the encap. header");
2979                 }
2980
2981                 if (pattern->last != NULL) {
2982                         /* This is not a match pattern, so disallow range. */
2983                         return rte_flow_error_set(error, EINVAL,
2984                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
2985                                         "Range item in the encap. header");
2986                 }
2987
2988                 if (pattern->type == RTE_FLOW_ITEM_TYPE_VOID) {
2989                         /* Handle VOID separately, for clarity. */
2990                         continue;
2991                 }
2992
2993                 if ((exp_items & RTE_BIT64(pattern->type)) == 0) {
2994                         return rte_flow_error_set(error, ENOTSUP,
2995                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
2996                                         "Unexpected item in the encap. header");
2997                 }
2998
2999                 parsed_item = &parsed_items[nb_parsed_items];
3000                 buf_cur = buf + bounce_eh->size;
3001
3002                 switch (pattern->type) {
3003                 case RTE_FLOW_ITEM_TYPE_ETH:
3004                         SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ITEM_TYPE_ETH,
3005                                                exp_items);
3006                         RTE_BUILD_BUG_ON(offsetof(struct rte_flow_item_eth,
3007                                                   hdr) != 0);
3008
3009                         proto_header_size = sizeof(struct rte_ether_hdr);
3010
3011                         ethertype_ofst = eth_ethertype_ofst;
3012
3013                         exp_items = RTE_BIT64(RTE_FLOW_ITEM_TYPE_VLAN) |
3014                                     RTE_BIT64(RTE_FLOW_ITEM_TYPE_IPV4) |
3015                                     RTE_BIT64(RTE_FLOW_ITEM_TYPE_IPV6);
3016                         break;
3017                 case RTE_FLOW_ITEM_TYPE_VLAN:
3018                         SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ITEM_TYPE_VLAN,
3019                                                exp_items);
3020                         RTE_BUILD_BUG_ON(offsetof(struct rte_flow_item_vlan,
3021                                                   hdr) != 0);
3022
3023                         proto_header_size = sizeof(struct rte_vlan_hdr);
3024
3025                         ethertypep = RTE_PTR_ADD(buf, eth_ethertype_ofst);
3026                         *ethertypep = RTE_BE16(RTE_ETHER_TYPE_QINQ);
3027
3028                         ethertypep = RTE_PTR_ADD(buf, ethertype_ofst);
3029                         *ethertypep = RTE_BE16(RTE_ETHER_TYPE_VLAN);
3030
3031                         ethertype_ofst =
3032                             bounce_eh->size +
3033                             offsetof(struct rte_vlan_hdr, eth_proto);
3034
3035                         exp_items = RTE_BIT64(RTE_FLOW_ITEM_TYPE_IPV4) |
3036                                     RTE_BIT64(RTE_FLOW_ITEM_TYPE_IPV6);
3037                         exp_items |= exp_items_extra_vlan[nb_vlan_tags];
3038
3039                         ++nb_vlan_tags;
3040                         break;
3041                 case RTE_FLOW_ITEM_TYPE_IPV4:
3042                         SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ITEM_TYPE_IPV4,
3043                                                exp_items);
3044                         RTE_BUILD_BUG_ON(offsetof(struct rte_flow_item_ipv4,
3045                                                   hdr) != 0);
3046
3047                         proto_header_size = sizeof(struct rte_ipv4_hdr);
3048
3049                         ethertypep = RTE_PTR_ADD(buf, ethertype_ofst);
3050                         *ethertypep = RTE_BE16(RTE_ETHER_TYPE_IPV4);
3051
3052                         next_proto_ofst =
3053                             bounce_eh->size +
3054                             offsetof(struct rte_ipv4_hdr, next_proto_id);
3055
3056                         ipv4 = (struct rte_ipv4_hdr *)buf_cur;
3057
3058                         exp_items = RTE_BIT64(RTE_FLOW_ITEM_TYPE_UDP);
3059                         break;
3060                 case RTE_FLOW_ITEM_TYPE_IPV6:
3061                         SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ITEM_TYPE_IPV6,
3062                                                exp_items);
3063                         RTE_BUILD_BUG_ON(offsetof(struct rte_flow_item_ipv6,
3064                                                   hdr) != 0);
3065
3066                         proto_header_size = sizeof(struct rte_ipv6_hdr);
3067
3068                         ethertypep = RTE_PTR_ADD(buf, ethertype_ofst);
3069                         *ethertypep = RTE_BE16(RTE_ETHER_TYPE_IPV6);
3070
3071                         next_proto_ofst = bounce_eh->size +
3072                                           offsetof(struct rte_ipv6_hdr, proto);
3073
3074                         ipv6 = (struct rte_ipv6_hdr *)buf_cur;
3075
3076                         exp_items = RTE_BIT64(RTE_FLOW_ITEM_TYPE_UDP);
3077                         break;
3078                 case RTE_FLOW_ITEM_TYPE_UDP:
3079                         SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ITEM_TYPE_UDP,
3080                                                exp_items);
3081                         RTE_BUILD_BUG_ON(offsetof(struct rte_flow_item_udp,
3082                                                   hdr) != 0);
3083
3084                         proto_header_size = sizeof(struct rte_udp_hdr);
3085
3086                         next_protop = RTE_PTR_ADD(buf, next_proto_ofst);
3087                         *next_protop = IPPROTO_UDP;
3088
3089                         udp = (struct rte_udp_hdr *)buf_cur;
3090
3091                         exp_items = RTE_BIT64(RTE_FLOW_ITEM_TYPE_VXLAN);
3092                         break;
3093                 case RTE_FLOW_ITEM_TYPE_VXLAN:
3094                         SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ITEM_TYPE_VXLAN,
3095                                                exp_items);
3096                         RTE_BUILD_BUG_ON(offsetof(struct rte_flow_item_vxlan,
3097                                                   hdr) != 0);
3098
3099                         proto_header_size = sizeof(struct rte_vxlan_hdr);
3100
3101                         vxlan = (struct rte_vxlan_hdr *)buf_cur;
3102
3103                         udp->dst_port = RTE_BE16(RTE_VXLAN_DEFAULT_PORT);
3104                         udp->dgram_len = RTE_BE16(sizeof(*udp) +
3105                                                   sizeof(*vxlan));
3106                         udp->dgram_cksum = 0;
3107
3108                         exp_items = 0;
3109                         break;
3110                 default:
3111                         return rte_flow_error_set(error, ENOTSUP,
3112                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
3113                                         "Unknown item in the encap. header");
3114                 }
3115
3116                 if (bounce_eh->size + proto_header_size > bounce_eh->buf_size) {
3117                         return rte_flow_error_set(error, E2BIG,
3118                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
3119                                         "The encap. header is too big");
3120                 }
3121
3122                 if ((proto_header_size & 1) != 0) {
3123                         return rte_flow_error_set(error, EINVAL,
3124                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
3125                                         "Odd layer size in the encap. header");
3126                 }
3127
3128                 rte_memcpy(buf_cur, pattern->spec, proto_header_size);
3129                 bounce_eh->size += proto_header_size;
3130
3131                 parsed_item->item = pattern;
3132                 parsed_item->proto_header_size = proto_header_size;
3133                 ++nb_parsed_items;
3134         }
3135
3136         if (exp_items != 0) {
3137                 /* Parsing item VXLAN would have reset exp_items to 0. */
3138                 return rte_flow_error_set(error, ENOTSUP,
3139                                         RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,
3140                                         "No item VXLAN in the encap. header");
3141         }
3142
3143         /* One of the pointers (ipv4, ipv6) refers to a dummy area. */
3144         ipv4->version_ihl = RTE_IPV4_VHL_DEF;
3145         ipv4->time_to_live = SFC_IPV4_TTL_DEF;
3146         ipv4->total_length = RTE_BE16(sizeof(*ipv4) + sizeof(*udp) +
3147                                       sizeof(*vxlan));
3148         /* The HW cannot compute this checksum. */
3149         ipv4->hdr_checksum = 0;
3150         ipv4->hdr_checksum = rte_ipv4_cksum(ipv4);
3151
3152         ipv6->vtc_flow = RTE_BE32(SFC_IPV6_VTC_FLOW_DEF);
3153         ipv6->hop_limits = SFC_IPV6_HOP_LIMITS_DEF;
3154         ipv6->payload_len = udp->dgram_len;
3155
3156         vxlan->vx_flags = RTE_BE32(SFC_VXLAN_FLAGS_DEF);
3157
3158         /* Take care of the masks. */
3159         sfc_mae_header_force_item_masks(buf, parsed_items, nb_parsed_items);
3160
3161         rc = efx_mae_action_set_populate_encap(spec);
3162         if (rc != 0) {
3163                 rc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ACTION,
3164                                 NULL, "failed to request action ENCAP");
3165         }
3166
3167         return rc;
3168 }
3169
3170 static int
3171 sfc_mae_rule_parse_action_mark(struct sfc_adapter *sa,
3172                                const struct rte_flow_action_mark *conf,
3173                                const struct sfc_flow_spec_mae *spec_mae,
3174                                efx_mae_actions_t *spec)
3175 {
3176         int rc;
3177
3178         if (spec_mae->ft_rule_type == SFC_FT_RULE_JUMP) {
3179                 /* Workaround. See sfc_flow_parse_rte_to_mae() */
3180         } else if (conf->id > SFC_FT_USER_MARK_MASK) {
3181                 sfc_err(sa, "the mark value is too large");
3182                 return EINVAL;
3183         }
3184
3185         rc = efx_mae_action_set_populate_mark(spec, conf->id);
3186         if (rc != 0)
3187                 sfc_err(sa, "failed to request action MARK: %s", strerror(rc));
3188
3189         return rc;
3190 }
3191
3192 static int
3193 sfc_mae_rule_parse_action_count(struct sfc_adapter *sa,
3194                                 const struct rte_flow_action_count *conf
3195                                         __rte_unused,
3196                                 efx_mae_actions_t *spec)
3197 {
3198         int rc;
3199
3200         if ((sa->counter_rxq.state & SFC_COUNTER_RXQ_INITIALIZED) == 0) {
3201                 sfc_err(sa,
3202                         "counter queue is not configured for COUNT action");
3203                 rc = EINVAL;
3204                 goto fail_counter_queue_uninit;
3205         }
3206
3207         if (sfc_get_service_lcore(SOCKET_ID_ANY) == RTE_MAX_LCORE) {
3208                 rc = EINVAL;
3209                 goto fail_no_service_core;
3210         }
3211
3212         rc = efx_mae_action_set_populate_count(spec);
3213         if (rc != 0) {
3214                 sfc_err(sa,
3215                         "failed to populate counters in MAE action set: %s",
3216                         rte_strerror(rc));
3217                 goto fail_populate_count;
3218         }
3219
3220         return 0;
3221
3222 fail_populate_count:
3223 fail_no_service_core:
3224 fail_counter_queue_uninit:
3225
3226         return rc;
3227 }
3228
3229 static int
3230 sfc_mae_rule_parse_action_phy_port(struct sfc_adapter *sa,
3231                                    const struct rte_flow_action_phy_port *conf,
3232                                    efx_mae_actions_t *spec)
3233 {
3234         efx_mport_sel_t mport;
3235         uint32_t phy_port;
3236         int rc;
3237
3238         if (conf->original != 0)
3239                 phy_port = efx_nic_cfg_get(sa->nic)->enc_assigned_port;
3240         else
3241                 phy_port = conf->index;
3242
3243         rc = efx_mae_mport_by_phy_port(phy_port, &mport);
3244         if (rc != 0) {
3245                 sfc_err(sa, "failed to convert phys. port ID %u to m-port selector: %s",
3246                         phy_port, strerror(rc));
3247                 return rc;
3248         }
3249
3250         rc = efx_mae_action_set_populate_deliver(spec, &mport);
3251         if (rc != 0) {
3252                 sfc_err(sa, "failed to request action DELIVER with m-port selector 0x%08x: %s",
3253                         mport.sel, strerror(rc));
3254         }
3255
3256         return rc;
3257 }
3258
3259 static int
3260 sfc_mae_rule_parse_action_pf_vf(struct sfc_adapter *sa,
3261                                 const struct rte_flow_action_vf *vf_conf,
3262                                 efx_mae_actions_t *spec)
3263 {
3264         const efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);
3265         efx_mport_sel_t mport;
3266         uint32_t vf;
3267         int rc;
3268
3269         if (vf_conf == NULL)
3270                 vf = EFX_PCI_VF_INVALID;
3271         else if (vf_conf->original != 0)
3272                 vf = encp->enc_vf;
3273         else
3274                 vf = vf_conf->id;
3275
3276         rc = efx_mae_mport_by_pcie_function(encp->enc_pf, vf, &mport);
3277         if (rc != 0) {
3278                 sfc_err(sa, "failed to convert PF %u VF %d to m-port: %s",
3279                         encp->enc_pf, (vf != EFX_PCI_VF_INVALID) ? (int)vf : -1,
3280                         strerror(rc));
3281                 return rc;
3282         }
3283
3284         rc = efx_mae_action_set_populate_deliver(spec, &mport);
3285         if (rc != 0) {
3286                 sfc_err(sa, "failed to request action DELIVER with m-port selector 0x%08x: %s",
3287                         mport.sel, strerror(rc));
3288         }
3289
3290         return rc;
3291 }
3292
3293 static int
3294 sfc_mae_rule_parse_action_port_id(struct sfc_adapter *sa,
3295                                   const struct rte_flow_action_port_id *conf,
3296                                   efx_mae_actions_t *spec)
3297 {
3298         struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
3299         struct sfc_mae *mae = &sa->mae;
3300         efx_mport_sel_t mport;
3301         uint16_t port_id;
3302         int rc;
3303
3304         if (conf->id > UINT16_MAX)
3305                 return EOVERFLOW;
3306
3307         port_id = (conf->original != 0) ? sas->port_id : conf->id;
3308
3309         rc = sfc_mae_switch_port_by_ethdev(mae->switch_domain_id,
3310                                            port_id, &mport);
3311         if (rc != 0) {
3312                 sfc_err(sa, "failed to find MAE switch port SW entry for RTE ethdev port %u: %s",
3313                         port_id, strerror(rc));
3314                 return rc;
3315         }
3316
3317         rc = efx_mae_action_set_populate_deliver(spec, &mport);
3318         if (rc != 0) {
3319                 sfc_err(sa, "failed to request action DELIVER with m-port selector 0x%08x: %s",
3320                         mport.sel, strerror(rc));
3321         }
3322
3323         return rc;
3324 }
3325
3326 static const char * const action_names[] = {
3327         [RTE_FLOW_ACTION_TYPE_VXLAN_DECAP] = "VXLAN_DECAP",
3328         [RTE_FLOW_ACTION_TYPE_OF_POP_VLAN] = "OF_POP_VLAN",
3329         [RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN] = "OF_PUSH_VLAN",
3330         [RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID] = "OF_SET_VLAN_VID",
3331         [RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP] = "OF_SET_VLAN_PCP",
3332         [RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP] = "VXLAN_ENCAP",
3333         [RTE_FLOW_ACTION_TYPE_FLAG] = "FLAG",
3334         [RTE_FLOW_ACTION_TYPE_MARK] = "MARK",
3335         [RTE_FLOW_ACTION_TYPE_PHY_PORT] = "PHY_PORT",
3336         [RTE_FLOW_ACTION_TYPE_PF] = "PF",
3337         [RTE_FLOW_ACTION_TYPE_VF] = "VF",
3338         [RTE_FLOW_ACTION_TYPE_PORT_ID] = "PORT_ID",
3339         [RTE_FLOW_ACTION_TYPE_DROP] = "DROP",
3340         [RTE_FLOW_ACTION_TYPE_JUMP] = "JUMP",
3341 };
3342
3343 static int
3344 sfc_mae_rule_parse_action(struct sfc_adapter *sa,
3345                           const struct rte_flow_action *action,
3346                           const struct sfc_flow_spec_mae *spec_mae,
3347                           struct sfc_mae_actions_bundle *bundle,
3348                           efx_mae_actions_t *spec,
3349                           struct rte_flow_error *error)
3350 {
3351         const struct sfc_mae_outer_rule *outer_rule = spec_mae->outer_rule;
3352         const uint64_t rx_metadata = sa->negotiated_rx_metadata;
3353         bool custom_error = B_FALSE;
3354         int rc = 0;
3355
3356         switch (action->type) {
3357         case RTE_FLOW_ACTION_TYPE_VXLAN_DECAP:
3358                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_VXLAN_DECAP,
3359                                        bundle->actions_mask);
3360                 if (outer_rule == NULL ||
3361                     outer_rule->encap_type != EFX_TUNNEL_PROTOCOL_VXLAN)
3362                         rc = EINVAL;
3363                 else
3364                         rc = efx_mae_action_set_populate_decap(spec);
3365                 break;
3366         case RTE_FLOW_ACTION_TYPE_OF_POP_VLAN:
3367                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_OF_POP_VLAN,
3368                                        bundle->actions_mask);
3369                 rc = efx_mae_action_set_populate_vlan_pop(spec);
3370                 break;
3371         case RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN:
3372                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN,
3373                                        bundle->actions_mask);
3374                 sfc_mae_rule_parse_action_of_push_vlan(action->conf, bundle);
3375                 break;
3376         case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID:
3377                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID,
3378                                        bundle->actions_mask);
3379                 sfc_mae_rule_parse_action_of_set_vlan_vid(action->conf, bundle);
3380                 break;
3381         case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP:
3382                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP,
3383                                        bundle->actions_mask);
3384                 sfc_mae_rule_parse_action_of_set_vlan_pcp(action->conf, bundle);
3385                 break;
3386         case RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP:
3387                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP,
3388                                        bundle->actions_mask);
3389                 rc = sfc_mae_rule_parse_action_vxlan_encap(&sa->mae,
3390                                                            action->conf,
3391                                                            spec, error);
3392                 custom_error = B_TRUE;
3393                 break;
3394         case RTE_FLOW_ACTION_TYPE_COUNT:
3395                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_COUNT,
3396                                        bundle->actions_mask);
3397                 rc = sfc_mae_rule_parse_action_count(sa, action->conf, spec);
3398                 break;
3399         case RTE_FLOW_ACTION_TYPE_FLAG:
3400                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_FLAG,
3401                                        bundle->actions_mask);
3402                 if ((rx_metadata & RTE_ETH_RX_METADATA_USER_FLAG) != 0) {
3403                         rc = efx_mae_action_set_populate_flag(spec);
3404                 } else {
3405                         rc = rte_flow_error_set(error, ENOTSUP,
3406                                                 RTE_FLOW_ERROR_TYPE_ACTION,
3407                                                 action,
3408                                                 "flag delivery has not been negotiated");
3409                         custom_error = B_TRUE;
3410                 }
3411                 break;
3412         case RTE_FLOW_ACTION_TYPE_MARK:
3413                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_MARK,
3414                                        bundle->actions_mask);
3415                 if ((rx_metadata & RTE_ETH_RX_METADATA_USER_MARK) != 0 ||
3416                     spec_mae->ft_rule_type == SFC_FT_RULE_JUMP) {
3417                         rc = sfc_mae_rule_parse_action_mark(sa, action->conf,
3418                                                             spec_mae, spec);
3419                 } else {
3420                         rc = rte_flow_error_set(error, ENOTSUP,
3421                                                 RTE_FLOW_ERROR_TYPE_ACTION,
3422                                                 action,
3423                                                 "mark delivery has not been negotiated");
3424                         custom_error = B_TRUE;
3425                 }
3426                 break;
3427         case RTE_FLOW_ACTION_TYPE_PHY_PORT:
3428                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_PHY_PORT,
3429                                        bundle->actions_mask);
3430                 rc = sfc_mae_rule_parse_action_phy_port(sa, action->conf, spec);
3431                 break;
3432         case RTE_FLOW_ACTION_TYPE_PF:
3433                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_PF,
3434                                        bundle->actions_mask);
3435                 rc = sfc_mae_rule_parse_action_pf_vf(sa, NULL, spec);
3436                 break;
3437         case RTE_FLOW_ACTION_TYPE_VF:
3438                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_VF,
3439                                        bundle->actions_mask);
3440                 rc = sfc_mae_rule_parse_action_pf_vf(sa, action->conf, spec);
3441                 break;
3442         case RTE_FLOW_ACTION_TYPE_PORT_ID:
3443                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_PORT_ID,
3444                                        bundle->actions_mask);
3445                 rc = sfc_mae_rule_parse_action_port_id(sa, action->conf, spec);
3446                 break;
3447         case RTE_FLOW_ACTION_TYPE_DROP:
3448                 SFC_BUILD_SET_OVERFLOW(RTE_FLOW_ACTION_TYPE_DROP,
3449                                        bundle->actions_mask);
3450                 rc = efx_mae_action_set_populate_drop(spec);
3451                 break;
3452         case RTE_FLOW_ACTION_TYPE_JUMP:
3453                 if (spec_mae->ft_rule_type == SFC_FT_RULE_JUMP) {
3454                         /* Workaround. See sfc_flow_parse_rte_to_mae() */
3455                         break;
3456                 }
3457                 /* FALLTHROUGH */
3458         default:
3459                 return rte_flow_error_set(error, ENOTSUP,
3460                                 RTE_FLOW_ERROR_TYPE_ACTION, NULL,
3461                                 "Unsupported action");
3462         }
3463
3464         if (rc == 0) {
3465                 bundle->actions_mask |= (1ULL << action->type);
3466         } else if (!custom_error) {
3467                 if (action->type < RTE_DIM(action_names)) {
3468                         const char *action_name = action_names[action->type];
3469
3470                         if (action_name != NULL) {
3471                                 sfc_err(sa, "action %s was rejected: %s",
3472                                         action_name, strerror(rc));
3473                         }
3474                 }
3475                 rc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ACTION,
3476                                 NULL, "Failed to request the action");
3477         }
3478
3479         return rc;
3480 }
3481
3482 static void
3483 sfc_mae_bounce_eh_invalidate(struct sfc_mae_bounce_eh *bounce_eh)
3484 {
3485         bounce_eh->type = EFX_TUNNEL_PROTOCOL_NONE;
3486 }
3487
3488 static int
3489 sfc_mae_process_encap_header(struct sfc_adapter *sa,
3490                              const struct sfc_mae_bounce_eh *bounce_eh,
3491                              struct sfc_mae_encap_header **encap_headerp)
3492 {
3493         if (bounce_eh->type == EFX_TUNNEL_PROTOCOL_NONE) {
3494                 encap_headerp = NULL;
3495                 return 0;
3496         }
3497
3498         *encap_headerp = sfc_mae_encap_header_attach(sa, bounce_eh);
3499         if (*encap_headerp != NULL)
3500                 return 0;
3501
3502         return sfc_mae_encap_header_add(sa, bounce_eh, encap_headerp);
3503 }
3504
3505 int
3506 sfc_mae_rule_parse_actions(struct sfc_adapter *sa,
3507                            const struct rte_flow_action actions[],
3508                            struct sfc_flow_spec_mae *spec_mae,
3509                            struct rte_flow_error *error)
3510 {
3511         struct sfc_mae_encap_header *encap_header = NULL;
3512         struct sfc_mae_actions_bundle bundle = {0};
3513         struct sfc_flow_tunnel *counter_ft = NULL;
3514         uint64_t *ft_group_hit_counter = NULL;
3515         const struct rte_flow_action *action;
3516         struct sfc_mae *mae = &sa->mae;
3517         unsigned int n_count = 0;
3518         efx_mae_actions_t *spec;
3519         int rc;
3520
3521         rte_errno = 0;
3522
3523         if (actions == NULL) {
3524                 return rte_flow_error_set(error, EINVAL,
3525                                 RTE_FLOW_ERROR_TYPE_ACTION_NUM, NULL,
3526                                 "NULL actions");
3527         }
3528
3529         rc = efx_mae_action_set_spec_init(sa->nic, &spec);
3530         if (rc != 0)
3531                 goto fail_action_set_spec_init;
3532
3533         for (action = actions;
3534              action->type != RTE_FLOW_ACTION_TYPE_END; ++action) {
3535                 if (action->type == RTE_FLOW_ACTION_TYPE_COUNT)
3536                         ++n_count;
3537         }
3538
3539         if (spec_mae->ft_rule_type == SFC_FT_RULE_GROUP) {
3540                 /* JUMP rules don't decapsulate packets. GROUP rules do. */
3541                 rc = efx_mae_action_set_populate_decap(spec);
3542                 if (rc != 0)
3543                         goto fail_enforce_ft_decap;
3544
3545                 if (n_count == 0 && sfc_mae_counter_stream_enabled(sa)) {
3546                         /*
3547                          * The user opted not to use action COUNT in this rule,
3548                          * but the counter should be enabled implicitly because
3549                          * packets hitting this rule contribute to the tunnel's
3550                          * total number of hits. See sfc_mae_counter_get().
3551                          */
3552                         rc = efx_mae_action_set_populate_count(spec);
3553                         if (rc != 0)
3554                                 goto fail_enforce_ft_count;
3555
3556                         n_count = 1;
3557                 }
3558         }
3559
3560         /* Cleanup after previous encap. header bounce buffer usage. */
3561         sfc_mae_bounce_eh_invalidate(&mae->bounce_eh);
3562
3563         for (action = actions;
3564              action->type != RTE_FLOW_ACTION_TYPE_END; ++action) {
3565                 rc = sfc_mae_actions_bundle_sync(action, &bundle, spec, error);
3566                 if (rc != 0)
3567                         goto fail_rule_parse_action;
3568
3569                 rc = sfc_mae_rule_parse_action(sa, action, spec_mae,
3570                                                &bundle, spec, error);
3571                 if (rc != 0)
3572                         goto fail_rule_parse_action;
3573         }
3574
3575         rc = sfc_mae_actions_bundle_sync(action, &bundle, spec, error);
3576         if (rc != 0)
3577                 goto fail_rule_parse_action;
3578
3579         rc = sfc_mae_process_encap_header(sa, &mae->bounce_eh, &encap_header);
3580         if (rc != 0)
3581                 goto fail_process_encap_header;
3582
3583         if (n_count > 1) {
3584                 rc = ENOTSUP;
3585                 sfc_err(sa, "too many count actions requested: %u", n_count);
3586                 goto fail_nb_count;
3587         }
3588
3589         switch (spec_mae->ft_rule_type) {
3590         case SFC_FT_RULE_NONE:
3591                 break;
3592         case SFC_FT_RULE_JUMP:
3593                 /* Workaround. See sfc_flow_parse_rte_to_mae() */
3594                 rc = sfc_mae_rule_parse_action_pf_vf(sa, NULL, spec);
3595                 if (rc != 0)
3596                         goto fail_workaround_jump_delivery;
3597
3598                 counter_ft = spec_mae->ft;
3599                 break;
3600         case SFC_FT_RULE_GROUP:
3601                 /*
3602                  * Packets that go to the rule's AR have FT mark set (from the
3603                  * JUMP rule OR's RECIRC_ID). Remove this mark in matching
3604                  * packets. The user may have provided their own action
3605                  * MARK above, so don't check the return value here.
3606                  */
3607                 (void)efx_mae_action_set_populate_mark(spec, 0);
3608
3609                 ft_group_hit_counter = &spec_mae->ft->group_hit_counter;
3610                 break;
3611         default:
3612                 SFC_ASSERT(B_FALSE);
3613         }
3614
3615         spec_mae->action_set = sfc_mae_action_set_attach(sa, encap_header,
3616                                                          n_count, spec);
3617         if (spec_mae->action_set != NULL) {
3618                 sfc_mae_encap_header_del(sa, encap_header);
3619                 efx_mae_action_set_spec_fini(sa->nic, spec);
3620                 return 0;
3621         }
3622
3623         rc = sfc_mae_action_set_add(sa, actions, spec, encap_header,
3624                                     ft_group_hit_counter, counter_ft, n_count,
3625                                     &spec_mae->action_set);
3626         if (rc != 0)
3627                 goto fail_action_set_add;
3628
3629         return 0;
3630
3631 fail_action_set_add:
3632 fail_workaround_jump_delivery:
3633 fail_nb_count:
3634         sfc_mae_encap_header_del(sa, encap_header);
3635
3636 fail_process_encap_header:
3637 fail_rule_parse_action:
3638         efx_mae_action_set_spec_fini(sa->nic, spec);
3639
3640 fail_enforce_ft_count:
3641 fail_enforce_ft_decap:
3642 fail_action_set_spec_init:
3643         if (rc > 0 && rte_errno == 0) {
3644                 rc = rte_flow_error_set(error, rc,
3645                         RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
3646                         NULL, "Failed to process the action");
3647         }
3648         return rc;
3649 }
3650
3651 static bool
3652 sfc_mae_rules_class_cmp(struct sfc_adapter *sa,
3653                         const efx_mae_match_spec_t *left,
3654                         const efx_mae_match_spec_t *right)
3655 {
3656         bool have_same_class;
3657         int rc;
3658
3659         rc = efx_mae_match_specs_class_cmp(sa->nic, left, right,
3660                                            &have_same_class);
3661
3662         return (rc == 0) ? have_same_class : false;
3663 }
3664
3665 static int
3666 sfc_mae_outer_rule_class_verify(struct sfc_adapter *sa,
3667                                 struct sfc_mae_outer_rule *rule)
3668 {
3669         struct sfc_mae_fw_rsrc *fw_rsrc = &rule->fw_rsrc;
3670         struct sfc_mae_outer_rule *entry;
3671         struct sfc_mae *mae = &sa->mae;
3672
3673         if (fw_rsrc->rule_id.id != EFX_MAE_RSRC_ID_INVALID) {
3674                 /* An active rule is reused. It's class is wittingly valid. */
3675                 return 0;
3676         }
3677
3678         TAILQ_FOREACH_REVERSE(entry, &mae->outer_rules,
3679                               sfc_mae_outer_rules, entries) {
3680                 const efx_mae_match_spec_t *left = entry->match_spec;
3681                 const efx_mae_match_spec_t *right = rule->match_spec;
3682
3683                 if (entry == rule)
3684                         continue;
3685
3686                 if (sfc_mae_rules_class_cmp(sa, left, right))
3687                         return 0;
3688         }
3689
3690         sfc_info(sa, "for now, the HW doesn't support rule validation, and HW "
3691                  "support for outer frame pattern items is not guaranteed; "
3692                  "other than that, the items are valid from SW standpoint");
3693         return 0;
3694 }
3695
3696 static int
3697 sfc_mae_action_rule_class_verify(struct sfc_adapter *sa,
3698                                  struct sfc_flow_spec_mae *spec)
3699 {
3700         const struct rte_flow *entry;
3701
3702         if (spec->match_spec == NULL)
3703                 return 0;
3704
3705         TAILQ_FOREACH_REVERSE(entry, &sa->flow_list, sfc_flow_list, entries) {
3706                 const struct sfc_flow_spec *entry_spec = &entry->spec;
3707                 const struct sfc_flow_spec_mae *es_mae = &entry_spec->mae;
3708                 const efx_mae_match_spec_t *left = es_mae->match_spec;
3709                 const efx_mae_match_spec_t *right = spec->match_spec;
3710
3711                 switch (entry_spec->type) {
3712                 case SFC_FLOW_SPEC_FILTER:
3713                         /* Ignore VNIC-level flows */
3714                         break;
3715                 case SFC_FLOW_SPEC_MAE:
3716                         if (sfc_mae_rules_class_cmp(sa, left, right))
3717                                 return 0;
3718                         break;
3719                 default:
3720                         SFC_ASSERT(false);
3721                 }
3722         }
3723
3724         sfc_info(sa, "for now, the HW doesn't support rule validation, and HW "
3725                  "support for inner frame pattern items is not guaranteed; "
3726                  "other than that, the items are valid from SW standpoint");
3727         return 0;
3728 }
3729
3730 /**
3731  * Confirm that a given flow can be accepted by the FW.
3732  *
3733  * @param sa
3734  *   Software adapter context
3735  * @param flow
3736  *   Flow to be verified
3737  * @return
3738  *   Zero on success and non-zero in the case of error.
3739  *   A special value of EAGAIN indicates that the adapter is
3740  *   not in started state. This state is compulsory because
3741  *   it only makes sense to compare the rule class of the flow
3742  *   being validated with classes of the active rules.
3743  *   Such classes are wittingly supported by the FW.
3744  */
3745 int
3746 sfc_mae_flow_verify(struct sfc_adapter *sa,
3747                     struct rte_flow *flow)
3748 {
3749         struct sfc_flow_spec *spec = &flow->spec;
3750         struct sfc_flow_spec_mae *spec_mae = &spec->mae;
3751         struct sfc_mae_outer_rule *outer_rule = spec_mae->outer_rule;
3752         int rc;
3753
3754         SFC_ASSERT(sfc_adapter_is_locked(sa));
3755
3756         if (sa->state != SFC_ETHDEV_STARTED)
3757                 return EAGAIN;
3758
3759         if (outer_rule != NULL) {
3760                 rc = sfc_mae_outer_rule_class_verify(sa, outer_rule);
3761                 if (rc != 0)
3762                         return rc;
3763         }
3764
3765         return sfc_mae_action_rule_class_verify(sa, spec_mae);
3766 }
3767
3768 int
3769 sfc_mae_flow_insert(struct sfc_adapter *sa,
3770                     struct rte_flow *flow)
3771 {
3772         struct sfc_flow_spec *spec = &flow->spec;
3773         struct sfc_flow_spec_mae *spec_mae = &spec->mae;
3774         struct sfc_mae_outer_rule *outer_rule = spec_mae->outer_rule;
3775         struct sfc_mae_action_set *action_set = spec_mae->action_set;
3776         struct sfc_mae_fw_rsrc *fw_rsrc;
3777         int rc;
3778
3779         SFC_ASSERT(spec_mae->rule_id.id == EFX_MAE_RSRC_ID_INVALID);
3780
3781         if (outer_rule != NULL) {
3782                 rc = sfc_mae_outer_rule_enable(sa, outer_rule,
3783                                                spec_mae->match_spec);
3784                 if (rc != 0)
3785                         goto fail_outer_rule_enable;
3786         }
3787
3788         if (spec_mae->ft_rule_type == SFC_FT_RULE_JUMP) {
3789                 spec_mae->ft->reset_jump_hit_counter =
3790                         spec_mae->ft->group_hit_counter;
3791         }
3792
3793         if (action_set == NULL) {
3794                 sfc_dbg(sa, "enabled flow=%p (no AR)", flow);
3795                 return 0;
3796         }
3797
3798         rc = sfc_mae_action_set_enable(sa, action_set);
3799         if (rc != 0)
3800                 goto fail_action_set_enable;
3801
3802         if (action_set->n_counters > 0) {
3803                 rc = sfc_mae_counter_start(sa);
3804                 if (rc != 0) {
3805                         sfc_err(sa, "failed to start MAE counters support: %s",
3806                                 rte_strerror(rc));
3807                         goto fail_mae_counter_start;
3808                 }
3809         }
3810
3811         fw_rsrc = &action_set->fw_rsrc;
3812
3813         rc = efx_mae_action_rule_insert(sa->nic, spec_mae->match_spec,
3814                                         NULL, &fw_rsrc->aset_id,
3815                                         &spec_mae->rule_id);
3816         if (rc != 0)
3817                 goto fail_action_rule_insert;
3818
3819         sfc_dbg(sa, "enabled flow=%p: AR_ID=0x%08x",
3820                 flow, spec_mae->rule_id.id);
3821
3822         return 0;
3823
3824 fail_action_rule_insert:
3825 fail_mae_counter_start:
3826         sfc_mae_action_set_disable(sa, action_set);
3827
3828 fail_action_set_enable:
3829         if (outer_rule != NULL)
3830                 sfc_mae_outer_rule_disable(sa, outer_rule);
3831
3832 fail_outer_rule_enable:
3833         return rc;
3834 }
3835
3836 int
3837 sfc_mae_flow_remove(struct sfc_adapter *sa,
3838                     struct rte_flow *flow)
3839 {
3840         struct sfc_flow_spec *spec = &flow->spec;
3841         struct sfc_flow_spec_mae *spec_mae = &spec->mae;
3842         struct sfc_mae_action_set *action_set = spec_mae->action_set;
3843         struct sfc_mae_outer_rule *outer_rule = spec_mae->outer_rule;
3844         int rc;
3845
3846         if (action_set == NULL) {
3847                 sfc_dbg(sa, "disabled flow=%p (no AR)", flow);
3848                 goto skip_action_rule;
3849         }
3850
3851         SFC_ASSERT(spec_mae->rule_id.id != EFX_MAE_RSRC_ID_INVALID);
3852
3853         rc = efx_mae_action_rule_remove(sa->nic, &spec_mae->rule_id);
3854         if (rc != 0) {
3855                 sfc_err(sa, "failed to disable flow=%p with AR_ID=0x%08x: %s",
3856                         flow, spec_mae->rule_id.id, strerror(rc));
3857         }
3858         sfc_dbg(sa, "disabled flow=%p with AR_ID=0x%08x",
3859                 flow, spec_mae->rule_id.id);
3860         spec_mae->rule_id.id = EFX_MAE_RSRC_ID_INVALID;
3861
3862         sfc_mae_action_set_disable(sa, action_set);
3863
3864 skip_action_rule:
3865         if (outer_rule != NULL)
3866                 sfc_mae_outer_rule_disable(sa, outer_rule);
3867
3868         return 0;
3869 }
3870
3871 static int
3872 sfc_mae_query_counter(struct sfc_adapter *sa,
3873                       struct sfc_flow_spec_mae *spec,
3874                       const struct rte_flow_action *action,
3875                       struct rte_flow_query_count *data,
3876                       struct rte_flow_error *error)
3877 {
3878         struct sfc_mae_action_set *action_set = spec->action_set;
3879         const struct rte_flow_action_count *conf = action->conf;
3880         unsigned int i;
3881         int rc;
3882
3883         if (action_set == NULL || action_set->n_counters == 0) {
3884                 return rte_flow_error_set(error, EINVAL,
3885                         RTE_FLOW_ERROR_TYPE_ACTION, action,
3886                         "Queried flow rule does not have count actions");
3887         }
3888
3889         for (i = 0; i < action_set->n_counters; i++) {
3890                 /*
3891                  * Get the first available counter of the flow rule if
3892                  * counter ID is not specified, provided that this
3893                  * counter is not an automatic (implicit) one.
3894                  */
3895                 if (conf != NULL && action_set->counters[i].rte_id != conf->id)
3896                         continue;
3897
3898                 rc = sfc_mae_counter_get(&sa->mae.counter_registry.counters,
3899                                          &action_set->counters[i], data);
3900                 if (rc != 0) {
3901                         return rte_flow_error_set(error, EINVAL,
3902                                 RTE_FLOW_ERROR_TYPE_ACTION, action,
3903                                 "Queried flow rule counter action is invalid");
3904                 }
3905
3906                 return 0;
3907         }
3908
3909         return rte_flow_error_set(error, ENOENT,
3910                                   RTE_FLOW_ERROR_TYPE_ACTION, action,
3911                                   "no such flow rule action or such count ID");
3912 }
3913
3914 int
3915 sfc_mae_flow_query(struct rte_eth_dev *dev,
3916                    struct rte_flow *flow,
3917                    const struct rte_flow_action *action,
3918                    void *data,
3919                    struct rte_flow_error *error)
3920 {
3921         struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
3922         struct sfc_flow_spec *spec = &flow->spec;
3923         struct sfc_flow_spec_mae *spec_mae = &spec->mae;
3924
3925         switch (action->type) {
3926         case RTE_FLOW_ACTION_TYPE_COUNT:
3927                 return sfc_mae_query_counter(sa, spec_mae, action,
3928                                              data, error);
3929         default:
3930                 return rte_flow_error_set(error, ENOTSUP,
3931                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
3932                         "Query for action of this type is not supported");
3933         }
3934 }
3935
3936 int
3937 sfc_mae_switchdev_init(struct sfc_adapter *sa)
3938 {
3939         const efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);
3940         struct sfc_mae *mae = &sa->mae;
3941         efx_mport_sel_t pf;
3942         efx_mport_sel_t phy;
3943         int rc;
3944
3945         sfc_log_init(sa, "entry");
3946
3947         if (!sa->switchdev) {
3948                 sfc_log_init(sa, "switchdev is not enabled - skip");
3949                 return 0;
3950         }
3951
3952         if (mae->status != SFC_MAE_STATUS_SUPPORTED) {
3953                 rc = ENOTSUP;
3954                 sfc_err(sa, "failed to init switchdev - no MAE support");
3955                 goto fail_no_mae;
3956         }
3957
3958         rc = efx_mae_mport_by_pcie_function(encp->enc_pf, EFX_PCI_VF_INVALID,
3959                                             &pf);
3960         if (rc != 0) {
3961                 sfc_err(sa, "failed get PF mport");
3962                 goto fail_pf_get;
3963         }
3964
3965         rc = efx_mae_mport_by_phy_port(encp->enc_assigned_port, &phy);
3966         if (rc != 0) {
3967                 sfc_err(sa, "failed get PHY mport");
3968                 goto fail_phy_get;
3969         }
3970
3971         rc = sfc_mae_rule_add_mport_match_deliver(sa, &pf, &phy,
3972                         SFC_MAE_RULE_PRIO_LOWEST,
3973                         &mae->switchdev_rule_pf_to_ext);
3974         if (rc != 0) {
3975                 sfc_err(sa, "failed add MAE rule to forward from PF to PHY");
3976                 goto fail_pf_add;
3977         }
3978
3979         rc = sfc_mae_rule_add_mport_match_deliver(sa, &phy, &pf,
3980                         SFC_MAE_RULE_PRIO_LOWEST,
3981                         &mae->switchdev_rule_ext_to_pf);
3982         if (rc != 0) {
3983                 sfc_err(sa, "failed add MAE rule to forward from PHY to PF");
3984                 goto fail_phy_add;
3985         }
3986
3987         sfc_log_init(sa, "done");
3988
3989         return 0;
3990
3991 fail_phy_add:
3992         sfc_mae_rule_del(sa, mae->switchdev_rule_pf_to_ext);
3993
3994 fail_pf_add:
3995 fail_phy_get:
3996 fail_pf_get:
3997 fail_no_mae:
3998         sfc_log_init(sa, "failed: %s", rte_strerror(rc));
3999         return rc;
4000 }
4001
4002 void
4003 sfc_mae_switchdev_fini(struct sfc_adapter *sa)
4004 {
4005         struct sfc_mae *mae = &sa->mae;
4006
4007         if (!sa->switchdev)
4008                 return;
4009
4010         sfc_mae_rule_del(sa, mae->switchdev_rule_pf_to_ext);
4011         sfc_mae_rule_del(sa, mae->switchdev_rule_ext_to_pf);
4012 }