app/testpmd: support integrity flow item
[dpdk.git] / app / test-pmd / cmdline_flow.c
index 9940d4f..b508cda 100644 (file)
@@ -54,7 +54,7 @@ enum index {
        PORT_ID,
        GROUP_ID,
        PRIORITY_LEVEL,
-       SHARED_ACTION_ID,
+       INDIRECT_ACTION_ID,
 
        /* Top-level command. */
        SET,
@@ -68,7 +68,7 @@ enum index {
        /* Top-level command. */
        FLOW,
        /* Sub-level commands. */
-       SHARED_ACTION,
+       INDIRECT_ACTION,
        VALIDATE,
        CREATE,
        DESTROY,
@@ -108,21 +108,25 @@ enum index {
        TUNNEL_SET,
        TUNNEL_MATCH,
 
-       /* Shared action arguments */
-       SHARED_ACTION_CREATE,
-       SHARED_ACTION_UPDATE,
-       SHARED_ACTION_DESTROY,
-       SHARED_ACTION_QUERY,
+       /* Dump arguments */
+       DUMP_ALL,
+       DUMP_ONE,
 
-       /* Shared action create arguments */
-       SHARED_ACTION_CREATE_ID,
-       SHARED_ACTION_INGRESS,
-       SHARED_ACTION_EGRESS,
-       SHARED_ACTION_TRANSFER,
-       SHARED_ACTION_SPEC,
+       /* Indirect action arguments */
+       INDIRECT_ACTION_CREATE,
+       INDIRECT_ACTION_UPDATE,
+       INDIRECT_ACTION_DESTROY,
+       INDIRECT_ACTION_QUERY,
 
-       /* Shared action destroy arguments */
-       SHARED_ACTION_DESTROY_ID,
+       /* Indirect action create arguments */
+       INDIRECT_ACTION_CREATE_ID,
+       INDIRECT_ACTION_INGRESS,
+       INDIRECT_ACTION_EGRESS,
+       INDIRECT_ACTION_TRANSFER,
+       INDIRECT_ACTION_SPEC,
+
+       /* Indirect action destroy arguments */
+       INDIRECT_ACTION_DESTROY_ID,
 
        /* Validate/create pattern. */
        PATTERN,
@@ -289,6 +293,9 @@ enum index {
        ITEM_GENEVE_OPT_TYPE,
        ITEM_GENEVE_OPT_LENGTH,
        ITEM_GENEVE_OPT_DATA,
+       ITEM_INTEGRITY,
+       ITEM_INTEGRITY_LEVEL,
+       ITEM_INTEGRITY_VALUE,
 
        /* Validate/create actions. */
        ACTIONS,
@@ -412,8 +419,21 @@ enum index {
        ACTION_SAMPLE_RATIO,
        ACTION_SAMPLE_INDEX,
        ACTION_SAMPLE_INDEX_VALUE,
-       ACTION_SHARED,
-       SHARED_ACTION_ID2PTR,
+       ACTION_INDIRECT,
+       INDIRECT_ACTION_ID2PTR,
+       ACTION_MODIFY_FIELD,
+       ACTION_MODIFY_FIELD_OP,
+       ACTION_MODIFY_FIELD_OP_VALUE,
+       ACTION_MODIFY_FIELD_DST_TYPE,
+       ACTION_MODIFY_FIELD_DST_TYPE_VALUE,
+       ACTION_MODIFY_FIELD_DST_LEVEL,
+       ACTION_MODIFY_FIELD_DST_OFFSET,
+       ACTION_MODIFY_FIELD_SRC_TYPE,
+       ACTION_MODIFY_FIELD_SRC_TYPE_VALUE,
+       ACTION_MODIFY_FIELD_SRC_LEVEL,
+       ACTION_MODIFY_FIELD_SRC_OFFSET,
+       ACTION_MODIFY_FIELD_SRC_VALUE,
+       ACTION_MODIFY_FIELD_WIDTH,
 };
 
 /** Maximum size for pattern in struct rte_flow_item_raw. */
@@ -569,6 +589,26 @@ struct rte_flow_action_queue sample_queue[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_count sample_count[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_port_id sample_port_id[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_raw_encap sample_encap[RAW_SAMPLE_CONFS_MAX_NUM];
+struct action_vxlan_encap_data sample_vxlan_encap[RAW_SAMPLE_CONFS_MAX_NUM];
+struct action_nvgre_encap_data sample_nvgre_encap[RAW_SAMPLE_CONFS_MAX_NUM];
+struct action_rss_data sample_rss_data[RAW_SAMPLE_CONFS_MAX_NUM];
+struct rte_flow_action_vf sample_vf[RAW_SAMPLE_CONFS_MAX_NUM];
+
+static const char *const modify_field_ops[] = {
+       "set", "add", "sub", NULL
+};
+
+static const char *const modify_field_ids[] = {
+       "start", "mac_dst", "mac_src",
+       "vlan_type", "vlan_id", "mac_type",
+       "ipv4_dscp", "ipv4_ttl", "ipv4_src", "ipv4_dst",
+       "ipv6_dscp", "ipv6_hoplimit", "ipv6_src", "ipv6_dst",
+       "tcp_port_src", "tcp_port_dst",
+       "tcp_seq_num", "tcp_ack_num", "tcp_flags",
+       "udp_port_src", "udp_port_dst",
+       "vxlan_vni", "geneve_vni", "gtp_teid",
+       "tag", "mark", "meta", "pointer", "value", NULL
+};
 
 /** Maximum number of subsequent tokens and arguments on the stack. */
 #define CTX_STACK_SIZE 16
@@ -741,10 +781,10 @@ struct buffer {
                struct {
                        uint32_t *action_id;
                        uint32_t action_id_n;
-               } sa_destroy; /**< Shared action destroy arguments. */
+               } ia_destroy; /**< Indirect action destroy arguments. */
                struct {
                        uint32_t action_id;
-               } sa; /* Shared action query arguments */
+               } ia; /* Indirect action query arguments */
                struct {
                        struct rte_flow_attr attr;
                        struct tunnel_ops tunnel_ops;
@@ -760,6 +800,8 @@ struct buffer {
                } destroy; /**< Destroy arguments. */
                struct {
                        char file[128];
+                       bool mode;
+                       uint32_t rule;
                } dump; /**< Dump arguments. */
                struct {
                        uint32_t rule;
@@ -802,20 +844,26 @@ struct parse_action_priv {
                .size = s, \
        })
 
-static const enum index next_sa_create_attr[] = {
-       SHARED_ACTION_CREATE_ID,
-       SHARED_ACTION_INGRESS,
-       SHARED_ACTION_EGRESS,
-       SHARED_ACTION_TRANSFER,
-       SHARED_ACTION_SPEC,
+static const enum index next_ia_create_attr[] = {
+       INDIRECT_ACTION_CREATE_ID,
+       INDIRECT_ACTION_INGRESS,
+       INDIRECT_ACTION_EGRESS,
+       INDIRECT_ACTION_TRANSFER,
+       INDIRECT_ACTION_SPEC,
+       ZERO,
+};
+
+static const enum index next_dump_subcmd[] = {
+       DUMP_ALL,
+       DUMP_ONE,
        ZERO,
 };
 
-static const enum index next_sa_subcmd[] = {
-       SHARED_ACTION_CREATE,
-       SHARED_ACTION_UPDATE,
-       SHARED_ACTION_DESTROY,
-       SHARED_ACTION_QUERY,
+static const enum index next_ia_subcmd[] = {
+       INDIRECT_ACTION_CREATE,
+       INDIRECT_ACTION_UPDATE,
+       INDIRECT_ACTION_DESTROY,
+       INDIRECT_ACTION_QUERY,
        ZERO,
 };
 
@@ -855,8 +903,8 @@ static const enum index next_aged_attr[] = {
        ZERO,
 };
 
-static const enum index next_sa_destroy_attr[] = {
-       SHARED_ACTION_DESTROY_ID,
+static const enum index next_ia_destroy_attr[] = {
+       INDIRECT_ACTION_DESTROY_ID,
        END,
        ZERO,
 };
@@ -923,6 +971,7 @@ static const enum index next_item[] = {
        ITEM_PFCP,
        ITEM_ECPRI,
        ITEM_GENEVE_OPT,
+       ITEM_INTEGRITY,
        END_SET,
        ZERO,
 };
@@ -1274,6 +1323,19 @@ static const enum index item_geneve_opt[] = {
        ZERO,
 };
 
+static const enum index item_integrity[] = {
+       ITEM_INTEGRITY_LEVEL,
+       ITEM_INTEGRITY_VALUE,
+       ZERO,
+};
+
+static const enum index item_integrity_lv[] = {
+       ITEM_INTEGRITY_LEVEL,
+       ITEM_INTEGRITY_VALUE,
+       ITEM_NEXT,
+       ZERO,
+};
+
 static const enum index next_action[] = {
        ACTION_END,
        ACTION_VOID,
@@ -1335,7 +1397,8 @@ static const enum index next_action[] = {
        ACTION_SET_IPV6_DSCP,
        ACTION_AGE,
        ACTION_SAMPLE,
-       ACTION_SHARED,
+       ACTION_INDIRECT,
+       ACTION_MODIFY_FIELD,
        ZERO,
 };
 
@@ -1578,14 +1641,32 @@ static const enum index action_sample[] = {
 
 static const enum index next_action_sample[] = {
        ACTION_QUEUE,
+       ACTION_RSS,
        ACTION_MARK,
        ACTION_COUNT,
        ACTION_PORT_ID,
        ACTION_RAW_ENCAP,
+       ACTION_VXLAN_ENCAP,
+       ACTION_NVGRE_ENCAP,
        ACTION_NEXT,
        ZERO,
 };
 
+static const enum index action_modify_field_dst[] = {
+       ACTION_MODIFY_FIELD_DST_LEVEL,
+       ACTION_MODIFY_FIELD_DST_OFFSET,
+       ACTION_MODIFY_FIELD_SRC_TYPE,
+       ZERO,
+};
+
+static const enum index action_modify_field_src[] = {
+       ACTION_MODIFY_FIELD_SRC_LEVEL,
+       ACTION_MODIFY_FIELD_SRC_OFFSET,
+       ACTION_MODIFY_FIELD_SRC_VALUE,
+       ACTION_MODIFY_FIELD_WIDTH,
+       ZERO,
+};
+
 static int parse_set_raw_encap_decap(struct context *, const struct token *,
                                     const char *, unsigned int,
                                     void *, unsigned int);
@@ -1668,6 +1749,14 @@ static int
 parse_vc_action_sample_index(struct context *ctx, const struct token *token,
                                const char *str, unsigned int len, void *buf,
                                unsigned int size);
+static int
+parse_vc_modify_field_op(struct context *ctx, const struct token *token,
+                               const char *str, unsigned int len, void *buf,
+                               unsigned int size);
+static int
+parse_vc_modify_field_id(struct context *ctx, const struct token *token,
+                               const char *str, unsigned int len, void *buf,
+                               unsigned int size);
 static int parse_destroy(struct context *, const struct token *,
                         const char *, unsigned int,
                         void *, unsigned int);
@@ -1725,13 +1814,13 @@ static int parse_ipv6_addr(struct context *, const struct token *,
 static int parse_port(struct context *, const struct token *,
                      const char *, unsigned int,
                      void *, unsigned int);
-static int parse_sa(struct context *, const struct token *,
+static int parse_ia(struct context *, const struct token *,
                    const char *, unsigned int,
                    void *, unsigned int);
-static int parse_sa_destroy(struct context *ctx, const struct token *token,
+static int parse_ia_destroy(struct context *ctx, const struct token *token,
                            const char *str, unsigned int len,
                            void *buf, unsigned int size);
-static int parse_sa_id2ptr(struct context *ctx, const struct token *token,
+static int parse_ia_id2ptr(struct context *ctx, const struct token *token,
                           const char *str, unsigned int len, void *buf,
                           unsigned int size);
 static int comp_none(struct context *, const struct token *,
@@ -1752,6 +1841,10 @@ static int comp_set_raw_index(struct context *, const struct token *,
                              unsigned int, char *, unsigned int);
 static int comp_set_sample_index(struct context *, const struct token *,
                              unsigned int, char *, unsigned int);
+static int comp_set_modify_field_op(struct context *, const struct token *,
+                             unsigned int, char *, unsigned int);
+static int comp_set_modify_field_id(struct context *, const struct token *,
+                             unsigned int, char *, unsigned int);
 
 /** Token definitions. */
 static const struct token token_list[] = {
@@ -1874,10 +1967,10 @@ static const struct token token_list[] = {
                .call = parse_int,
                .comp = comp_none,
        },
-       [SHARED_ACTION_ID] = {
-               .name = "{shared_action_id}",
-               .type = "SHARED_ACTION_ID",
-               .help = "shared action id",
+       [INDIRECT_ACTION_ID] = {
+               .name = "{indirect_action_id}",
+               .type = "INDIRECT_ACTION_ID",
+               .help = "indirect action id",
                .call = parse_int,
                .comp = comp_none,
        },
@@ -1887,7 +1980,7 @@ static const struct token token_list[] = {
                .type = "{command} {port_id} [{arg} [...]]",
                .help = "manage ingress/egress flow rules",
                .next = NEXT(NEXT_ENTRY
-                            (SHARED_ACTION,
+                            (INDIRECT_ACTION,
                              VALIDATE,
                              CREATE,
                              DESTROY,
@@ -1901,42 +1994,42 @@ static const struct token token_list[] = {
                .call = parse_init,
        },
        /* Top-level command. */
-       [SHARED_ACTION] = {
-               .name = "shared_action",
+       [INDIRECT_ACTION] = {
+               .name = "indirect_action",
                .type = "{command} {port_id} [{arg} [...]]",
-               .help = "manage shared actions",
-               .next = NEXT(next_sa_subcmd, NEXT_ENTRY(PORT_ID)),
+               .help = "manage indirect actions",
+               .next = NEXT(next_ia_subcmd, NEXT_ENTRY(PORT_ID)),
                .args = ARGS(ARGS_ENTRY(struct buffer, port)),
-               .call = parse_sa,
+               .call = parse_ia,
        },
        /* Sub-level commands. */
-       [SHARED_ACTION_CREATE] = {
+       [INDIRECT_ACTION_CREATE] = {
                .name = "create",
-               .help = "create shared action",
-               .next = NEXT(next_sa_create_attr),
-               .call = parse_sa,
+               .help = "create indirect action",
+               .next = NEXT(next_ia_create_attr),
+               .call = parse_ia,
        },
-       [SHARED_ACTION_UPDATE] = {
+       [INDIRECT_ACTION_UPDATE] = {
                .name = "update",
-               .help = "update shared action",
-               .next = NEXT(NEXT_ENTRY(SHARED_ACTION_SPEC),
-                            NEXT_ENTRY(SHARED_ACTION_ID)),
+               .help = "update indirect action",
+               .next = NEXT(NEXT_ENTRY(INDIRECT_ACTION_SPEC),
+                            NEXT_ENTRY(INDIRECT_ACTION_ID)),
                .args = ARGS(ARGS_ENTRY(struct buffer, args.vc.attr.group)),
-               .call = parse_sa,
+               .call = parse_ia,
        },
-       [SHARED_ACTION_DESTROY] = {
+       [INDIRECT_ACTION_DESTROY] = {
                .name = "destroy",
-               .help = "destroy shared action",
-               .next = NEXT(NEXT_ENTRY(SHARED_ACTION_DESTROY_ID)),
+               .help = "destroy indirect action",
+               .next = NEXT(NEXT_ENTRY(INDIRECT_ACTION_DESTROY_ID)),
                .args = ARGS(ARGS_ENTRY(struct buffer, port)),
-               .call = parse_sa_destroy,
+               .call = parse_ia_destroy,
        },
-       [SHARED_ACTION_QUERY] = {
+       [INDIRECT_ACTION_QUERY] = {
                .name = "query",
-               .help = "query shared action",
-               .next = NEXT(NEXT_ENTRY(END), NEXT_ENTRY(SHARED_ACTION_ID)),
-               .args = ARGS(ARGS_ENTRY(struct buffer, args.sa.action_id)),
-               .call = parse_sa,
+               .help = "query indirect action",
+               .next = NEXT(NEXT_ENTRY(END), NEXT_ENTRY(INDIRECT_ACTION_ID)),
+               .args = ARGS(ARGS_ENTRY(struct buffer, args.ia.action_id)),
+               .call = parse_ia,
        },
        [VALIDATE] = {
                .name = "validate",
@@ -1968,10 +2061,9 @@ static const struct token token_list[] = {
        },
        [DUMP] = {
                .name = "dump",
-               .help = "dump all flow rules to file",
-               .next = NEXT(next_dump_attr, NEXT_ENTRY(PORT_ID)),
-               .args = ARGS(ARGS_ENTRY(struct buffer, args.dump.file),
-                            ARGS_ENTRY(struct buffer, port)),
+               .help = "dump single/all flow rules to file",
+               .next = NEXT(next_dump_subcmd, NEXT_ENTRY(PORT_ID)),
+               .args = ARGS(ARGS_ENTRY(struct buffer, port)),
                .call = parse_dump,
        },
        [QUERY] = {
@@ -2061,6 +2153,22 @@ static const struct token token_list[] = {
                .args = ARGS(ARGS_ENTRY_PTR(struct buffer, args.destroy.rule)),
                .call = parse_destroy,
        },
+       /* Dump arguments. */
+       [DUMP_ALL] = {
+               .name = "all",
+               .help = "dump all",
+               .next = NEXT(next_dump_attr),
+               .args = ARGS(ARGS_ENTRY(struct buffer, args.dump.file)),
+               .call = parse_dump,
+       },
+       [DUMP_ONE] = {
+               .name = "rule",
+               .help = "dump one rule",
+               .next = NEXT(next_dump_attr, NEXT_ENTRY(RULE_ID)),
+               .args = ARGS(ARGS_ENTRY(struct buffer, args.dump.file),
+                               ARGS_ENTRY(struct buffer, args.dump.rule)),
+               .call = parse_dump,
+       },
        /* Query arguments. */
        [QUERY_ACTION] = {
                .name = "{action}",
@@ -3309,6 +3417,28 @@ static const struct token token_list[] = {
                                (sizeof(struct rte_flow_item_geneve_opt),
                                ITEM_GENEVE_OPT_DATA_SIZE)),
        },
+       [ITEM_INTEGRITY] = {
+               .name = "integrity",
+               .help = "match packet integrity",
+               .priv = PRIV_ITEM(INTEGRITY,
+                                 sizeof(struct rte_flow_item_integrity)),
+               .next = NEXT(item_integrity),
+               .call = parse_vc,
+       },
+       [ITEM_INTEGRITY_LEVEL] = {
+               .name = "level",
+               .help = "integrity level",
+               .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED),
+                            item_param),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, level)),
+       },
+       [ITEM_INTEGRITY_VALUE] = {
+               .name = "value",
+               .help = "integrity value",
+               .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED),
+                            item_param),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, value)),
+       },
        /* Validate/create actions. */
        [ACTIONS] = {
                .name = "actions",
@@ -3482,7 +3612,10 @@ static const struct token token_list[] = {
                .name = "key",
                .help = "RSS hash key",
                .next = NEXT(action_rss, NEXT_ENTRY(HEX)),
-               .args = ARGS(ARGS_ENTRY_ARB(0, 0),
+               .args = ARGS(ARGS_ENTRY_ARB
+                            (offsetof(struct action_rss_data, conf) +
+                             offsetof(struct rte_flow_action_rss, key),
+                             sizeof(((struct rte_flow_action_rss *)0)->key)),
                             ARGS_ENTRY_ARB
                             (offsetof(struct action_rss_data, conf) +
                              offsetof(struct rte_flow_action_rss, key_len),
@@ -4116,6 +4249,103 @@ static const struct token token_list[] = {
                .call = parse_vc_action_raw_decap_index,
                .comp = comp_set_raw_index,
        },
+       [ACTION_MODIFY_FIELD] = {
+               .name = "modify_field",
+               .help = "modify destination field with data from source field",
+               .priv = PRIV_ACTION(MODIFY_FIELD,
+                       sizeof(struct rte_flow_action_modify_field)),
+               .next = NEXT(NEXT_ENTRY(ACTION_MODIFY_FIELD_OP)),
+               .call = parse_vc,
+       },
+       [ACTION_MODIFY_FIELD_OP] = {
+               .name = "op",
+               .help = "operation type",
+               .next = NEXT(NEXT_ENTRY(ACTION_MODIFY_FIELD_DST_TYPE),
+                       NEXT_ENTRY(ACTION_MODIFY_FIELD_OP_VALUE)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_OP_VALUE] = {
+               .name = "{operation}",
+               .help = "operation type value",
+               .call = parse_vc_modify_field_op,
+               .comp = comp_set_modify_field_op,
+       },
+       [ACTION_MODIFY_FIELD_DST_TYPE] = {
+               .name = "dst_type",
+               .help = "destination field type",
+               .next = NEXT(action_modify_field_dst,
+                       NEXT_ENTRY(ACTION_MODIFY_FIELD_DST_TYPE_VALUE)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_DST_TYPE_VALUE] = {
+               .name = "{dst_type}",
+               .help = "destination field type value",
+               .call = parse_vc_modify_field_id,
+               .comp = comp_set_modify_field_id,
+       },
+       [ACTION_MODIFY_FIELD_DST_LEVEL] = {
+               .name = "dst_level",
+               .help = "destination field level",
+               .next = NEXT(action_modify_field_dst, NEXT_ENTRY(UNSIGNED)),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,
+                                       dst.level)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_DST_OFFSET] = {
+               .name = "dst_offset",
+               .help = "destination field bit offset",
+               .next = NEXT(action_modify_field_dst, NEXT_ENTRY(UNSIGNED)),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,
+                                       dst.offset)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_SRC_TYPE] = {
+               .name = "src_type",
+               .help = "source field type",
+               .next = NEXT(action_modify_field_src,
+                       NEXT_ENTRY(ACTION_MODIFY_FIELD_SRC_TYPE_VALUE)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_SRC_TYPE_VALUE] = {
+               .name = "{src_type}",
+               .help = "source field type value",
+               .call = parse_vc_modify_field_id,
+               .comp = comp_set_modify_field_id,
+       },
+       [ACTION_MODIFY_FIELD_SRC_LEVEL] = {
+               .name = "src_level",
+               .help = "source field level",
+               .next = NEXT(action_modify_field_src, NEXT_ENTRY(UNSIGNED)),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,
+                                       src.level)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_SRC_OFFSET] = {
+               .name = "src_offset",
+               .help = "source field bit offset",
+               .next = NEXT(action_modify_field_src, NEXT_ENTRY(UNSIGNED)),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,
+                                       src.offset)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_SRC_VALUE] = {
+               .name = "src_value",
+               .help = "source immediate value",
+               .next = NEXT(NEXT_ENTRY(ACTION_MODIFY_FIELD_WIDTH),
+                       NEXT_ENTRY(UNSIGNED)),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,
+                                       src.value)),
+               .call = parse_vc_conf,
+       },
+       [ACTION_MODIFY_FIELD_WIDTH] = {
+               .name = "width",
+               .help = "number of bits to copy",
+               .next = NEXT(NEXT_ENTRY(ACTION_NEXT),
+                       NEXT_ENTRY(UNSIGNED)),
+               .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field,
+                                       width)),
+               .call = parse_vc_conf,
+       },
        /* Top level command. */
        [SET] = {
                .name = "set",
@@ -4307,61 +4537,61 @@ static const struct token token_list[] = {
                .call = parse_vc_action_sample_index,
                .comp = comp_set_sample_index,
        },
-       /* Shared action destroy arguments. */
-       [SHARED_ACTION_DESTROY_ID] = {
+       /* Indirect action destroy arguments. */
+       [INDIRECT_ACTION_DESTROY_ID] = {
                .name = "action_id",
-               .help = "specify a shared action id to destroy",
-               .next = NEXT(next_sa_destroy_attr,
-                            NEXT_ENTRY(SHARED_ACTION_ID)),
+               .help = "specify a indirect action id to destroy",
+               .next = NEXT(next_ia_destroy_attr,
+                            NEXT_ENTRY(INDIRECT_ACTION_ID)),
                .args = ARGS(ARGS_ENTRY_PTR(struct buffer,
-                                           args.sa_destroy.action_id)),
-               .call = parse_sa_destroy,
+                                           args.ia_destroy.action_id)),
+               .call = parse_ia_destroy,
        },
-       /* Shared action create arguments. */
-       [SHARED_ACTION_CREATE_ID] = {
+       /* Indirect action create arguments. */
+       [INDIRECT_ACTION_CREATE_ID] = {
                .name = "action_id",
-               .help = "specify a shared action id to create",
-               .next = NEXT(next_sa_create_attr,
-                            NEXT_ENTRY(SHARED_ACTION_ID)),
+               .help = "specify a indirect action id to create",
+               .next = NEXT(next_ia_create_attr,
+                            NEXT_ENTRY(INDIRECT_ACTION_ID)),
                .args = ARGS(ARGS_ENTRY(struct buffer, args.vc.attr.group)),
        },
-       [ACTION_SHARED] = {
-               .name = "shared",
-               .help = "apply shared action by id",
-               .priv = PRIV_ACTION(SHARED, 0),
-               .next = NEXT(NEXT_ENTRY(SHARED_ACTION_ID2PTR)),
+       [ACTION_INDIRECT] = {
+               .name = "indirect",
+               .help = "apply indirect action by id",
+               .priv = PRIV_ACTION(INDIRECT, 0),
+               .next = NEXT(NEXT_ENTRY(INDIRECT_ACTION_ID2PTR)),
                .args = ARGS(ARGS_ENTRY_ARB(0, sizeof(uint32_t))),
                .call = parse_vc,
        },
-       [SHARED_ACTION_ID2PTR] = {
+       [INDIRECT_ACTION_ID2PTR] = {
                .name = "{action_id}",
-               .type = "SHARED_ACTION_ID",
-               .help = "shared action id",
+               .type = "INDIRECT_ACTION_ID",
+               .help = "indirect action id",
                .next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
-               .call = parse_sa_id2ptr,
+               .call = parse_ia_id2ptr,
                .comp = comp_none,
        },
-       [SHARED_ACTION_INGRESS] = {
+       [INDIRECT_ACTION_INGRESS] = {
                .name = "ingress",
                .help = "affect rule to ingress",
-               .next = NEXT(next_sa_create_attr),
-               .call = parse_sa,
+               .next = NEXT(next_ia_create_attr),
+               .call = parse_ia,
        },
-       [SHARED_ACTION_EGRESS] = {
+       [INDIRECT_ACTION_EGRESS] = {
                .name = "egress",
                .help = "affect rule to egress",
-               .next = NEXT(next_sa_create_attr),
-               .call = parse_sa,
+               .next = NEXT(next_ia_create_attr),
+               .call = parse_ia,
        },
-       [SHARED_ACTION_TRANSFER] = {
+       [INDIRECT_ACTION_TRANSFER] = {
                .name = "transfer",
                .help = "affect rule to transfer",
-               .next = NEXT(next_sa_create_attr),
-               .call = parse_sa,
+               .next = NEXT(next_ia_create_attr),
+               .call = parse_ia,
        },
-       [SHARED_ACTION_SPEC] = {
+       [INDIRECT_ACTION_SPEC] = {
                .name = "action",
-               .help = "specify action to share",
+               .help = "specify action to create indirect handle",
                .next = NEXT(next_action),
        },
 };
@@ -4548,9 +4778,9 @@ parse_init(struct context *ctx, const struct token *token,
        return len;
 }
 
-/** Parse tokens for shared action commands. */
+/** Parse tokens for indirect action commands. */
 static int
-parse_sa(struct context *ctx, const struct token *token,
+parse_ia(struct context *ctx, const struct token *token,
         const char *str, unsigned int len,
         void *buf, unsigned int size)
 {
@@ -4563,7 +4793,7 @@ parse_sa(struct context *ctx, const struct token *token,
        if (!out)
                return len;
        if (!out->command) {
-               if (ctx->curr != SHARED_ACTION)
+               if (ctx->curr != INDIRECT_ACTION)
                        return -1;
                if (sizeof(*out) > size)
                        return -1;
@@ -4575,26 +4805,26 @@ parse_sa(struct context *ctx, const struct token *token,
                return len;
        }
        switch (ctx->curr) {
-       case SHARED_ACTION_CREATE:
-       case SHARED_ACTION_UPDATE:
+       case INDIRECT_ACTION_CREATE:
+       case INDIRECT_ACTION_UPDATE:
                out->args.vc.actions =
                        (void *)RTE_ALIGN_CEIL((uintptr_t)(out + 1),
                                               sizeof(double));
                out->args.vc.attr.group = UINT32_MAX;
                /* fallthrough */
-       case SHARED_ACTION_QUERY:
+       case INDIRECT_ACTION_QUERY:
                out->command = ctx->curr;
                ctx->objdata = 0;
                ctx->object = out;
                ctx->objmask = NULL;
                return len;
-       case SHARED_ACTION_EGRESS:
+       case INDIRECT_ACTION_EGRESS:
                out->args.vc.attr.egress = 1;
                return len;
-       case SHARED_ACTION_INGRESS:
+       case INDIRECT_ACTION_INGRESS:
                out->args.vc.attr.ingress = 1;
                return len;
-       case SHARED_ACTION_TRANSFER:
+       case INDIRECT_ACTION_TRANSFER:
                out->args.vc.attr.transfer = 1;
                return len;
        default:
@@ -4603,9 +4833,9 @@ parse_sa(struct context *ctx, const struct token *token,
 }
 
 
-/** Parse tokens for shared action destroy command. */
+/** Parse tokens for indirect action destroy command. */
 static int
-parse_sa_destroy(struct context *ctx, const struct token *token,
+parse_ia_destroy(struct context *ctx, const struct token *token,
                 const char *str, unsigned int len,
                 void *buf, unsigned int size)
 {
@@ -4618,8 +4848,8 @@ parse_sa_destroy(struct context *ctx, const struct token *token,
        /* Nothing else to do if there is no buffer. */
        if (!out)
                return len;
-       if (!out->command || out->command == SHARED_ACTION) {
-               if (ctx->curr != SHARED_ACTION_DESTROY)
+       if (!out->command || out->command == INDIRECT_ACTION) {
+               if (ctx->curr != INDIRECT_ACTION_DESTROY)
                        return -1;
                if (sizeof(*out) > size)
                        return -1;
@@ -4627,13 +4857,13 @@ parse_sa_destroy(struct context *ctx, const struct token *token,
                ctx->objdata = 0;
                ctx->object = out;
                ctx->objmask = NULL;
-               out->args.sa_destroy.action_id =
+               out->args.ia_destroy.action_id =
                        (void *)RTE_ALIGN_CEIL((uintptr_t)(out + 1),
                                               sizeof(double));
                return len;
        }
-       action_id = out->args.sa_destroy.action_id
-                   + out->args.sa_destroy.action_id_n++;
+       action_id = out->args.ia_destroy.action_id
+                   + out->args.ia_destroy.action_id_n++;
        if ((uint8_t *)action_id > (uint8_t *)out + size)
                return -1;
        ctx->objdata = 0;
@@ -5084,31 +5314,11 @@ end:
        return len;
 }
 
-/** Parse VXLAN encap action. */
+/** Setup VXLAN encap configuration. */
 static int
-parse_vc_action_vxlan_encap(struct context *ctx, const struct token *token,
-                           const char *str, unsigned int len,
-                           void *buf, unsigned int size)
+parse_setup_vxlan_encap_data(struct action_vxlan_encap_data *action_vxlan_encap_data)
 {
-       struct buffer *out = buf;
-       struct rte_flow_action *action;
-       struct action_vxlan_encap_data *action_vxlan_encap_data;
-       int ret;
-
-       ret = parse_vc(ctx, token, str, len, buf, size);
-       if (ret < 0)
-               return ret;
-       /* Nothing else to do if there is no buffer. */
-       if (!out)
-               return ret;
-       if (!out->args.vc.actions_n)
-               return -1;
-       action = &out->args.vc.actions[out->args.vc.actions_n - 1];
-       /* Point to selected object. */
-       ctx->object = out->args.vc.data;
-       ctx->objmask = NULL;
        /* Set up default configuration. */
-       action_vxlan_encap_data = ctx->object;
        *action_vxlan_encap_data = (struct action_vxlan_encap_data){
                .conf = (struct rte_flow_action_vxlan_encap){
                        .definition = action_vxlan_encap_data->items,
@@ -5212,19 +5422,18 @@ parse_vc_action_vxlan_encap(struct context *ctx, const struct token *token,
        }
        memcpy(action_vxlan_encap_data->item_vxlan.vni, vxlan_encap_conf.vni,
               RTE_DIM(vxlan_encap_conf.vni));
-       action->conf = &action_vxlan_encap_data->conf;
-       return ret;
+       return 0;
 }
 
-/** Parse NVGRE encap action. */
+/** Parse VXLAN encap action. */
 static int
-parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,
+parse_vc_action_vxlan_encap(struct context *ctx, const struct token *token,
                            const char *str, unsigned int len,
                            void *buf, unsigned int size)
 {
        struct buffer *out = buf;
        struct rte_flow_action *action;
-       struct action_nvgre_encap_data *action_nvgre_encap_data;
+       struct action_vxlan_encap_data *action_vxlan_encap_data;
        int ret;
 
        ret = parse_vc(ctx, token, str, len, buf, size);
@@ -5239,8 +5448,17 @@ parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,
        /* Point to selected object. */
        ctx->object = out->args.vc.data;
        ctx->objmask = NULL;
+       action_vxlan_encap_data = ctx->object;
+       parse_setup_vxlan_encap_data(action_vxlan_encap_data);
+       action->conf = &action_vxlan_encap_data->conf;
+       return ret;
+}
+
+/** Setup NVGRE encap configuration. */
+static int
+parse_setup_nvgre_encap_data(struct action_nvgre_encap_data *action_nvgre_encap_data)
+{
        /* Set up default configuration. */
-       action_nvgre_encap_data = ctx->object;
        *action_nvgre_encap_data = (struct action_nvgre_encap_data){
                .conf = (struct rte_flow_action_nvgre_encap){
                        .definition = action_nvgre_encap_data->items,
@@ -5279,6 +5497,8 @@ parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,
                       .src_addr = nvgre_encap_conf.ipv4_src,
                       .dst_addr = nvgre_encap_conf.ipv4_dst,
                },
+               .item_nvgre.c_k_s_rsvd0_ver = RTE_BE16(0x2000),
+               .item_nvgre.protocol = RTE_BE16(RTE_ETHER_TYPE_TEB),
                .item_nvgre.flow_id = 0,
        };
        memcpy(action_nvgre_encap_data->item_eth.dst.addr_bytes,
@@ -5303,6 +5523,34 @@ parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,
                        RTE_FLOW_ITEM_TYPE_VOID;
        memcpy(action_nvgre_encap_data->item_nvgre.tni, nvgre_encap_conf.tni,
               RTE_DIM(nvgre_encap_conf.tni));
+       return 0;
+}
+
+/** Parse NVGRE encap action. */
+static int
+parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,
+                           const char *str, unsigned int len,
+                           void *buf, unsigned int size)
+{
+       struct buffer *out = buf;
+       struct rte_flow_action *action;
+       struct action_nvgre_encap_data *action_nvgre_encap_data;
+       int ret;
+
+       ret = parse_vc(ctx, token, str, len, buf, size);
+       if (ret < 0)
+               return ret;
+       /* Nothing else to do if there is no buffer. */
+       if (!out)
+               return ret;
+       if (!out->args.vc.actions_n)
+               return -1;
+       action = &out->args.vc.actions[out->args.vc.actions_n - 1];
+       /* Point to selected object. */
+       ctx->object = out->args.vc.data;
+       ctx->objmask = NULL;
+       action_nvgre_encap_data = ctx->object;
+       parse_setup_nvgre_encap_data(action_nvgre_encap_data);
        action->conf = &action_nvgre_encap_data->conf;
        return ret;
 }
@@ -6039,6 +6287,62 @@ parse_vc_action_sample_index(struct context *ctx, const struct token *token,
        return len;
 }
 
+/** Parse operation for modify_field command. */
+static int
+parse_vc_modify_field_op(struct context *ctx, const struct token *token,
+                        const char *str, unsigned int len, void *buf,
+                        unsigned int size)
+{
+       struct rte_flow_action_modify_field *action_modify_field;
+       unsigned int i;
+
+       (void)token;
+       (void)buf;
+       (void)size;
+       if (ctx->curr != ACTION_MODIFY_FIELD_OP_VALUE)
+               return -1;
+       for (i = 0; modify_field_ops[i]; ++i)
+               if (!strcmp_partial(modify_field_ops[i], str, len))
+                       break;
+       if (!modify_field_ops[i])
+               return -1;
+       if (!ctx->object)
+               return len;
+       action_modify_field = ctx->object;
+       action_modify_field->operation = (enum rte_flow_modify_op)i;
+       return len;
+}
+
+/** Parse id for modify_field command. */
+static int
+parse_vc_modify_field_id(struct context *ctx, const struct token *token,
+                        const char *str, unsigned int len, void *buf,
+                        unsigned int size)
+{
+       struct rte_flow_action_modify_field *action_modify_field;
+       unsigned int i;
+
+       (void)token;
+       (void)buf;
+       (void)size;
+       if (ctx->curr != ACTION_MODIFY_FIELD_DST_TYPE_VALUE &&
+               ctx->curr != ACTION_MODIFY_FIELD_SRC_TYPE_VALUE)
+               return -1;
+       for (i = 0; modify_field_ids[i]; ++i)
+               if (!strcmp_partial(modify_field_ids[i], str, len))
+                       break;
+       if (!modify_field_ids[i])
+               return -1;
+       if (!ctx->object)
+               return len;
+       action_modify_field = ctx->object;
+       if (ctx->curr == ACTION_MODIFY_FIELD_DST_TYPE_VALUE)
+               action_modify_field->dst.field = (enum rte_flow_field_id)i;
+       else
+               action_modify_field->src.field = (enum rte_flow_field_id)i;
+       return len;
+}
+
 /** Parse tokens for destroy command. */
 static int
 parse_destroy(struct context *ctx, const struct token *token,
@@ -6126,8 +6430,20 @@ parse_dump(struct context *ctx, const struct token *token,
                ctx->objdata = 0;
                ctx->object = out;
                ctx->objmask = NULL;
+               return len;
+       }
+       switch (ctx->curr) {
+       case DUMP_ALL:
+       case DUMP_ONE:
+               out->args.dump.mode = (ctx->curr == DUMP_ALL) ? true : false;
+               out->command = ctx->curr;
+               ctx->objdata = 0;
+               ctx->object = out;
+               ctx->objmask = NULL;
+               return len;
+       default:
+               return -1;
        }
-       return len;
 }
 
 /** Parse tokens for query command. */
@@ -6825,7 +7141,7 @@ parse_port(struct context *ctx, const struct token *token,
 }
 
 static int
-parse_sa_id2ptr(struct context *ctx, const struct token *token,
+parse_ia_id2ptr(struct context *ctx, const struct token *token,
                const char *str, unsigned int len,
                void *buf, unsigned int size)
 {
@@ -6842,9 +7158,9 @@ parse_sa_id2ptr(struct context *ctx, const struct token *token,
        ctx->object = action;
        if (ret != (int)len)
                return ret;
-       /* set shared action */
+       /* set indirect action */
        if (action) {
-               action->conf = port_shared_action_get_by_id(ctx->port, id);
+               action->conf = port_action_handle_get_by_id(ctx->port, id);
                ret = (action->conf) ? ret : -1;
        }
        return ret;
@@ -7111,6 +7427,42 @@ comp_set_sample_index(struct context *ctx, const struct token *token,
        return nb;
 }
 
+/** Complete operation for modify_field command. */
+static int
+comp_set_modify_field_op(struct context *ctx, const struct token *token,
+                  unsigned int ent, char *buf, unsigned int size)
+{
+       uint16_t idx = 0;
+
+       RTE_SET_USED(ctx);
+       RTE_SET_USED(token);
+       for (idx = 0; modify_field_ops[idx]; ++idx)
+               ;
+       if (!buf)
+               return idx + 1;
+       if (ent < idx)
+               return strlcpy(buf, modify_field_ops[ent], size);
+       return -1;
+}
+
+/** Complete field id for modify_field command. */
+static int
+comp_set_modify_field_id(struct context *ctx, const struct token *token,
+                  unsigned int ent, char *buf, unsigned int size)
+{
+       uint16_t idx = 0;
+
+       RTE_SET_USED(ctx);
+       RTE_SET_USED(token);
+       for (idx = 0; modify_field_ids[idx]; ++idx)
+               ;
+       if (!buf)
+               return idx + 1;
+       if (ent < idx)
+               return strlcpy(buf, modify_field_ids[ent], size);
+       return -1;
+}
+
 /** Internal context. */
 static struct context cmd_flow_context;
 
@@ -7346,27 +7698,27 @@ static void
 cmd_flow_parsed(const struct buffer *in)
 {
        switch (in->command) {
-       case SHARED_ACTION_CREATE:
-               port_shared_action_create(
+       case INDIRECT_ACTION_CREATE:
+               port_action_handle_create(
                                in->port, in->args.vc.attr.group,
-                               &((const struct rte_flow_shared_action_conf) {
+                               &((const struct rte_flow_indir_action_conf) {
                                        .ingress = in->args.vc.attr.ingress,
                                        .egress = in->args.vc.attr.egress,
                                        .transfer = in->args.vc.attr.transfer,
                                }),
                                in->args.vc.actions);
                break;
-       case SHARED_ACTION_DESTROY:
-               port_shared_action_destroy(in->port,
-                                          in->args.sa_destroy.action_id_n,
-                                          in->args.sa_destroy.action_id);
+       case INDIRECT_ACTION_DESTROY:
+               port_action_handle_destroy(in->port,
+                                          in->args.ia_destroy.action_id_n,
+                                          in->args.ia_destroy.action_id);
                break;
-       case SHARED_ACTION_UPDATE:
-               port_shared_action_update(in->port, in->args.vc.attr.group,
+       case INDIRECT_ACTION_UPDATE:
+               port_action_handle_update(in->port, in->args.vc.attr.group,
                                          in->args.vc.actions);
                break;
-       case SHARED_ACTION_QUERY:
-               port_shared_action_query(in->port, in->args.sa.action_id);
+       case INDIRECT_ACTION_QUERY:
+               port_action_handle_query(in->port, in->args.ia.action_id);
                break;
        case VALIDATE:
                port_flow_validate(in->port, &in->args.vc.attr,
@@ -7385,8 +7737,10 @@ cmd_flow_parsed(const struct buffer *in)
        case FLUSH:
                port_flow_flush(in->port);
                break;
-       case DUMP:
-               port_flow_dump(in->port, in->args.dump.file);
+       case DUMP_ONE:
+       case DUMP_ALL:
+               port_flow_dump(in->port, in->args.dump.mode,
+                               in->args.dump.rule, in->args.dump.file);
                break;
        case QUERY:
                port_flow_query(in->port, in->args.query.rule,
@@ -7600,6 +7954,7 @@ cmd_set_raw_parsed_sample(const struct buffer *in)
        uint32_t i = 0;
        struct rte_flow_action *action = NULL;
        struct rte_flow_action *data = NULL;
+       const struct rte_flow_action_rss *rss = NULL;
        size_t size = 0;
        uint16_t idx = in->port; /* We borrow port field as index */
        uint32_t max_size = sizeof(struct rte_flow_action) *
@@ -7631,6 +7986,29 @@ cmd_set_raw_parsed_sample(const struct buffer *in)
                                (const void *)action->conf, size);
                        action->conf = &sample_queue[idx];
                        break;
+               case RTE_FLOW_ACTION_TYPE_RSS:
+                       size = sizeof(struct rte_flow_action_rss);
+                       rss = action->conf;
+                       rte_memcpy(&sample_rss_data[idx].conf,
+                                  (const void *)rss, size);
+                       if (rss->key_len && rss->key) {
+                               sample_rss_data[idx].conf.key =
+                                               sample_rss_data[idx].key;
+                               rte_memcpy((void *)((uintptr_t)
+                                          sample_rss_data[idx].conf.key),
+                                          (const void *)rss->key,
+                                          sizeof(uint8_t) * rss->key_len);
+                       }
+                       if (rss->queue_num && rss->queue) {
+                               sample_rss_data[idx].conf.queue =
+                                               sample_rss_data[idx].queue;
+                               rte_memcpy((void *)((uintptr_t)
+                                          sample_rss_data[idx].conf.queue),
+                                          (const void *)rss->queue,
+                                          sizeof(uint16_t) * rss->queue_num);
+                       }
+                       action->conf = &sample_rss_data[idx].conf;
+                       break;
                case RTE_FLOW_ACTION_TYPE_RAW_ENCAP:
                        size = sizeof(struct rte_flow_action_raw_encap);
                        rte_memcpy(&sample_encap[idx],
@@ -7643,6 +8021,24 @@ cmd_set_raw_parsed_sample(const struct buffer *in)
                                (const void *)action->conf, size);
                        action->conf = &sample_port_id[idx];
                        break;
+               case RTE_FLOW_ACTION_TYPE_PF:
+                       break;
+               case RTE_FLOW_ACTION_TYPE_VF:
+                       size = sizeof(struct rte_flow_action_vf);
+                       rte_memcpy(&sample_vf[idx],
+                                       (const void *)action->conf, size);
+                       action->conf = &sample_vf[idx];
+                       break;
+               case RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP:
+                       size = sizeof(struct rte_flow_action_vxlan_encap);
+                       parse_setup_vxlan_encap_data(&sample_vxlan_encap[idx]);
+                       action->conf = &sample_vxlan_encap[idx].conf;
+                       break;
+               case RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP:
+                       size = sizeof(struct rte_flow_action_nvgre_encap);
+                       parse_setup_nvgre_encap_data(&sample_nvgre_encap[idx]);
+                       action->conf = &sample_nvgre_encap[idx];
+                       break;
                default:
                        printf("Error - Not supported action\n");
                        return;