ethdev: introduce indirect flow action
[dpdk.git] / app / test-pmd / config.c
index 4d3953c..868ff34 100644 (file)
 #include <rte_cycles.h>
 #include <rte_flow.h>
 #include <rte_errno.h>
-#ifdef RTE_LIBRTE_IXGBE_PMD
+#ifdef RTE_NET_IXGBE
 #include <rte_pmd_ixgbe.h>
 #endif
-#ifdef RTE_LIBRTE_I40E_PMD
+#ifdef RTE_NET_I40E
 #include <rte_pmd_i40e.h>
 #endif
-#ifdef RTE_LIBRTE_BNXT_PMD
+#ifdef RTE_NET_BNXT
 #include <rte_pmd_bnxt.h>
 #endif
 #include <rte_gro.h>
@@ -87,7 +87,7 @@ const struct rss_type_info rss_type_table[] = {
        { "all", ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP | ETH_RSS_TCP |
                ETH_RSS_UDP | ETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD |
                ETH_RSS_L2TPV3 | ETH_RSS_ESP | ETH_RSS_AH | ETH_RSS_PFCP |
-               ETH_RSS_GTPU},
+               ETH_RSS_GTPU | ETH_RSS_ECPRI | ETH_RSS_MPLS},
        { "none", 0 },
        { "eth", ETH_RSS_ETH },
        { "l2-src-only", ETH_RSS_L2_SRC_ONLY },
@@ -136,6 +136,8 @@ const struct rss_type_info rss_type_table[] = {
        { "pfcp", ETH_RSS_PFCP },
        { "pppoe", ETH_RSS_PPPOE },
        { "gtpu", ETH_RSS_GTPU },
+       { "ecpri", ETH_RSS_ECPRI },
+       { "mpls", ETH_RSS_MPLS },
        { NULL, 0 },
 };
 
@@ -182,8 +184,6 @@ nic_stats_display(portid_t port_id)
                                                                diff_ns;
        uint64_t mpps_rx, mpps_tx, mbps_rx, mbps_tx;
        struct rte_eth_stats stats;
-       struct rte_port *port = &ports[port_id];
-       uint8_t i;
 
        static const char *nic_stats_border = "########################";
 
@@ -195,46 +195,12 @@ nic_stats_display(portid_t port_id)
        printf("\n  %s NIC statistics for port %-2d %s\n",
               nic_stats_border, port_id, nic_stats_border);
 
-       if ((!port->rx_queue_stats_mapping_enabled) && (!port->tx_queue_stats_mapping_enabled)) {
-               printf("  RX-packets: %-10"PRIu64" RX-missed: %-10"PRIu64" RX-bytes:  "
-                      "%-"PRIu64"\n",
-                      stats.ipackets, stats.imissed, stats.ibytes);
-               printf("  RX-errors: %-"PRIu64"\n", stats.ierrors);
-               printf("  RX-nombuf:  %-10"PRIu64"\n",
-                      stats.rx_nombuf);
-               printf("  TX-packets: %-10"PRIu64" TX-errors: %-10"PRIu64" TX-bytes:  "
-                      "%-"PRIu64"\n",
-                      stats.opackets, stats.oerrors, stats.obytes);
-       }
-       else {
-               printf("  RX-packets:              %10"PRIu64"    RX-errors: %10"PRIu64
-                      "    RX-bytes: %10"PRIu64"\n",
-                      stats.ipackets, stats.ierrors, stats.ibytes);
-               printf("  RX-errors:  %10"PRIu64"\n", stats.ierrors);
-               printf("  RX-nombuf:               %10"PRIu64"\n",
-                      stats.rx_nombuf);
-               printf("  TX-packets:              %10"PRIu64"    TX-errors: %10"PRIu64
-                      "    TX-bytes: %10"PRIu64"\n",
-                      stats.opackets, stats.oerrors, stats.obytes);
-       }
-
-       if (port->rx_queue_stats_mapping_enabled) {
-               printf("\n");
-               for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {
-                       printf("  Stats reg %2d RX-packets: %10"PRIu64
-                              "    RX-errors: %10"PRIu64
-                              "    RX-bytes: %10"PRIu64"\n",
-                              i, stats.q_ipackets[i], stats.q_errors[i], stats.q_ibytes[i]);
-               }
-       }
-       if (port->tx_queue_stats_mapping_enabled) {
-               printf("\n");
-               for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {
-                       printf("  Stats reg %2d TX-packets: %10"PRIu64
-                              "                             TX-bytes: %10"PRIu64"\n",
-                              i, stats.q_opackets[i], stats.q_obytes[i]);
-               }
-       }
+       printf("  RX-packets: %-10"PRIu64" RX-missed: %-10"PRIu64" RX-bytes:  "
+              "%-"PRIu64"\n", stats.ipackets, stats.imissed, stats.ibytes);
+       printf("  RX-errors: %-"PRIu64"\n", stats.ierrors);
+       printf("  RX-nombuf:  %-10"PRIu64"\n", stats.rx_nombuf);
+       printf("  TX-packets: %-10"PRIu64" TX-errors: %-10"PRIu64" TX-bytes:  "
+              "%-"PRIu64"\n", stats.opackets, stats.oerrors, stats.obytes);
 
        diff_ns = 0;
        if (clock_gettime(CLOCK_TYPE_ID, &cur_time) == 0) {
@@ -397,54 +363,6 @@ nic_xstats_clear(portid_t port_id)
        }
 }
 
-void
-nic_stats_mapping_display(portid_t port_id)
-{
-       struct rte_port *port = &ports[port_id];
-       uint16_t i;
-
-       static const char *nic_stats_mapping_border = "########################";
-
-       if (port_id_is_invalid(port_id, ENABLED_WARN)) {
-               print_valid_ports();
-               return;
-       }
-
-       if ((!port->rx_queue_stats_mapping_enabled) && (!port->tx_queue_stats_mapping_enabled)) {
-               printf("Port id %d - either does not support queue statistic mapping or"
-                      " no queue statistic mapping set\n", port_id);
-               return;
-       }
-
-       printf("\n  %s NIC statistics mapping for port %-2d %s\n",
-              nic_stats_mapping_border, port_id, nic_stats_mapping_border);
-
-       if (port->rx_queue_stats_mapping_enabled) {
-               for (i = 0; i < nb_rx_queue_stats_mappings; i++) {
-                       if (rx_queue_stats_mappings[i].port_id == port_id) {
-                               printf("  RX-queue %2d mapped to Stats Reg %2d\n",
-                                      rx_queue_stats_mappings[i].queue_id,
-                                      rx_queue_stats_mappings[i].stats_counter_id);
-                       }
-               }
-               printf("\n");
-       }
-
-
-       if (port->tx_queue_stats_mapping_enabled) {
-               for (i = 0; i < nb_tx_queue_stats_mappings; i++) {
-                       if (tx_queue_stats_mappings[i].port_id == port_id) {
-                               printf("  TX-queue %2d mapped to Stats Reg %2d\n",
-                                      tx_queue_stats_mappings[i].queue_id,
-                                      tx_queue_stats_mappings[i].stats_counter_id);
-                       }
-               }
-       }
-
-       printf("  %s####################################%s\n",
-              nic_stats_mapping_border, nic_stats_mapping_border);
-}
-
 void
 rx_queue_infos_display(portid_t port_id, uint16_t queue_id)
 {
@@ -592,8 +510,6 @@ device_infos_display(const char *identifier)
 
        if (rte_devargs_parsef(&da, "%s", identifier)) {
                printf("cannot parse identifier\n");
-               if (da.args)
-                       free(da.args);
                return;
        }
 
@@ -641,6 +557,7 @@ skip_parse:
                        }
                }
        };
+       rte_devargs_reset(&da);
 }
 
 void
@@ -967,295 +884,6 @@ port_module_eeprom_display(portid_t port_id)
        printf("Finish -- Port: %d MODULE EEPROM length: %d bytes\n", port_id, einfo.length);
 }
 
-void
-port_offload_cap_display(portid_t port_id)
-{
-       struct rte_eth_dev_info dev_info;
-       static const char *info_border = "************";
-       int ret;
-
-       if (port_id_is_invalid(port_id, ENABLED_WARN))
-               return;
-
-       ret = eth_dev_info_get_print_err(port_id, &dev_info);
-       if (ret != 0)
-               return;
-
-       printf("\n%s Port %d supported offload features: %s\n",
-               info_border, port_id, info_border);
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_VLAN_STRIP) {
-               printf("VLAN stripped:                 ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_VLAN_STRIP)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_QINQ_STRIP) {
-               printf("Double VLANs stripped:         ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_QINQ_STRIP)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_IPV4_CKSUM) {
-               printf("RX IPv4 checksum:              ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_IPV4_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_UDP_CKSUM) {
-               printf("RX UDP checksum:               ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_UDP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM) {
-               printf("RX TCP checksum:               ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_TCP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCTP_CKSUM) {
-               printf("RX SCTP checksum:              ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_SCTP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM) {
-               printf("RX Outer IPv4 checksum:        ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_UDP_CKSUM) {
-               printf("RX Outer UDP checksum:         ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_OUTER_UDP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_LRO) {
-               printf("Large receive offload:         ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_TCP_LRO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TIMESTAMP) {
-               printf("HW timestamp:                  ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_TIMESTAMP)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_KEEP_CRC) {
-               printf("Rx Keep CRC:                   ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_KEEP_CRC)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SECURITY) {
-               printf("RX offload security:           ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   DEV_RX_OFFLOAD_SECURITY)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) {
-               printf("RX offload buffer split:       ");
-               if (ports[port_id].dev_conf.rxmode.offloads &
-                   RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_VLAN_INSERT) {
-               printf("VLAN insert:                   ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_VLAN_INSERT)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_QINQ_INSERT) {
-               printf("Double VLANs insert:           ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_QINQ_INSERT)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IPV4_CKSUM) {
-               printf("TX IPv4 checksum:              ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_IPV4_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_CKSUM) {
-               printf("TX UDP checksum:               ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_UDP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_CKSUM) {
-               printf("TX TCP checksum:               ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_TCP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_SCTP_CKSUM) {
-               printf("TX SCTP checksum:              ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_SCTP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) {
-               printf("TX Outer IPv4 checksum:        ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) {
-               printf("TX TCP segmentation:           ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_TCP_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_TSO) {
-               printf("TX UDP segmentation:           ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_UDP_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_VXLAN_TNL_TSO) {
-               printf("TSO for VXLAN tunnel packet:   ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_VXLAN_TNL_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_GRE_TNL_TSO) {
-               printf("TSO for GRE tunnel packet:     ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_GRE_TNL_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IPIP_TNL_TSO) {
-               printf("TSO for IPIP tunnel packet:    ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_IPIP_TNL_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_GENEVE_TNL_TSO) {
-               printf("TSO for GENEVE tunnel packet:  ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_GENEVE_TNL_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IP_TNL_TSO) {
-               printf("IP tunnel TSO:  ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_IP_TNL_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_TNL_TSO) {
-               printf("UDP tunnel TSO:  ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_UDP_TNL_TSO)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) {
-               printf("TX Outer UDP checksum:         ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-       if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_SEND_ON_TIMESTAMP) {
-               printf("Tx scheduling on timestamp:    ");
-               if (ports[port_id].dev_conf.txmode.offloads &
-                   DEV_TX_OFFLOAD_SEND_ON_TIMESTAMP)
-                       printf("on\n");
-               else
-                       printf("off\n");
-       }
-
-}
-
 int
 port_id_is_invalid(portid_t port_id, enum print_warning warning)
 {
@@ -1517,7 +1145,7 @@ port_mtu_set(portid_t port_id, uint16_t mtu)
                 * device supports jumbo frame.
                 */
                eth_overhead = dev_info.max_rx_pktlen - dev_info.max_mtu;
-               if (mtu > RTE_ETHER_MAX_LEN - eth_overhead) {
+               if (mtu > RTE_ETHER_MTU) {
                        rte_port->dev_conf.rxmode.offloads |=
                                                DEV_RX_OFFLOAD_JUMBO_FRAME;
                        rte_port->dev_conf.rxmode.max_rx_pkt_len =
@@ -1763,38 +1391,38 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
        }
 }
 
-static struct port_shared_action *
+static struct port_indirect_action *
 action_get_by_id(portid_t port_id, uint32_t id)
 {
        struct rte_port *port;
-       struct port_shared_action **ppsa;
-       struct port_shared_action *psa = NULL;
+       struct port_indirect_action **ppia;
+       struct port_indirect_action *pia = NULL;
 
        if (port_id_is_invalid(port_id, ENABLED_WARN) ||
            port_id == (portid_t)RTE_PORT_ALL)
                return NULL;
        port = &ports[port_id];
-       ppsa = &port->actions_list;
-       while (*ppsa) {
-               if ((*ppsa)->id == id) {
-                       psa = *ppsa;
+       ppia = &port->actions_list;
+       while (*ppia) {
+               if ((*ppia)->id == id) {
+                       pia = *ppia;
                        break;
                }
-               ppsa = &(*ppsa)->next;
+               ppia = &(*ppia)->next;
        }
-       if (!psa)
-               printf("Failed to find shared action #%u on port %u\n",
+       if (!pia)
+               printf("Failed to find indirect action #%u on port %u\n",
                       id, port_id);
-       return psa;
+       return pia;
 }
 
 static int
 action_alloc(portid_t port_id, uint32_t id,
-            struct port_shared_action **action)
+            struct port_indirect_action **action)
 {
        struct rte_port *port;
-       struct port_shared_action **ppsa;
-       struct port_shared_action *psa = NULL;
+       struct port_indirect_action **ppia;
+       struct port_indirect_action *pia = NULL;
 
        *action = NULL;
        if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -1805,7 +1433,7 @@ action_alloc(portid_t port_id, uint32_t id,
                /* taking first available ID */
                if (port->actions_list) {
                        if (port->actions_list->id == UINT32_MAX - 1) {
-                               printf("Highest shared action ID is already"
+                               printf("Highest indirect action ID is already"
                                " assigned, delete it first\n");
                                return -ENOMEM;
                        }
@@ -1814,63 +1442,70 @@ action_alloc(portid_t port_id, uint32_t id,
                        id = 0;
                }
        }
-       psa = calloc(1, sizeof(*psa));
-       if (!psa) {
-               printf("Allocation of port %u shared action failed\n",
+       pia = calloc(1, sizeof(*pia));
+       if (!pia) {
+               printf("Allocation of port %u indirect action failed\n",
                       port_id);
                return -ENOMEM;
        }
-       ppsa = &port->actions_list;
-       while (*ppsa && (*ppsa)->id > id)
-               ppsa = &(*ppsa)->next;
-       if (*ppsa && (*ppsa)->id == id) {
-               printf("Shared action #%u is already assigned,"
+       ppia = &port->actions_list;
+       while (*ppia && (*ppia)->id > id)
+               ppia = &(*ppia)->next;
+       if (*ppia && (*ppia)->id == id) {
+               printf("Indirect action #%u is already assigned,"
                        " delete it first\n", id);
-               free(psa);
+               free(pia);
                return -EINVAL;
        }
-       psa->next = *ppsa;
-       psa->id = id;
-       *ppsa = psa;
-       *action = psa;
+       pia->next = *ppia;
+       pia->id = id;
+       *ppia = pia;
+       *action = pia;
        return 0;
 }
 
-/** Create shared action */
+/** Create indirect action */
 int
-port_shared_action_create(portid_t port_id, uint32_t id,
-                         const struct rte_flow_shared_action_conf *conf,
+port_action_handle_create(portid_t port_id, uint32_t id,
+                         const struct rte_flow_indir_action_conf *conf,
                          const struct rte_flow_action *action)
 {
-       struct port_shared_action *psa;
+       struct port_indirect_action *pia;
        int ret;
        struct rte_flow_error error;
 
-       ret = action_alloc(port_id, id, &psa);
+       ret = action_alloc(port_id, id, &pia);
        if (ret)
                return ret;
+       if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
+               struct rte_flow_action_age *age =
+                       (struct rte_flow_action_age *)(uintptr_t)(action->conf);
+
+               pia->age_type = ACTION_AGE_CONTEXT_TYPE_INDIRECT_ACTION;
+               age->context = &pia->age_type;
+       }
        /* Poisoning to make sure PMDs update it in case of error. */
        memset(&error, 0x22, sizeof(error));
-       psa->action = rte_flow_shared_action_create(port_id, conf, action,
+       pia->handle = rte_flow_action_handle_create(port_id, conf, action,
                                                    &error);
-       if (!psa->action) {
-               uint32_t destroy_id = psa->id;
-               port_shared_action_destroy(port_id, 1, &destroy_id);
+       if (!pia->handle) {
+               uint32_t destroy_id = pia->id;
+               port_action_handle_destroy(port_id, 1, &destroy_id);
                return port_flow_complain(&error);
        }
-       psa->type = action->type;
-       printf("Shared action #%u created\n", psa->id);
+       pia->type = action->type;
+       printf("Indirect action #%u created\n", pia->id);
        return 0;
 }
 
-/** Destroy shared action */
+/** Destroy indirect action */
 int
-port_shared_action_destroy(portid_t port_id,
+port_action_handle_destroy(portid_t port_id,
                           uint32_t n,
                           const uint32_t *actions)
 {
        struct rte_port *port;
-       struct port_shared_action **tmp;
+       struct port_indirect_action **tmp;
        uint32_t c = 0;
        int ret = 0;
 
@@ -1884,9 +1519,9 @@ port_shared_action_destroy(portid_t port_id,
 
                for (i = 0; i != n; ++i) {
                        struct rte_flow_error error;
-                       struct port_shared_action *psa = *tmp;
+                       struct port_indirect_action *pia = *tmp;
 
-                       if (actions[i] != psa->id)
+                       if (actions[i] != pia->id)
                                continue;
                        /*
                         * Poisoning to make sure PMDs update it in case
@@ -1894,14 +1529,14 @@ port_shared_action_destroy(portid_t port_id,
                         */
                        memset(&error, 0x33, sizeof(error));
 
-                       if (psa->action && rte_flow_shared_action_destroy(
-                                       port_id, psa->action, &error)) {
+                       if (pia->handle && rte_flow_action_handle_destroy(
+                                       port_id, pia->handle, &error)) {
                                ret = port_flow_complain(&error);
                                continue;
                        }
-                       *tmp = psa->next;
-                       free(psa);
-                       printf("Shared action #%u destroyed\n", psa->id);
+                       *tmp = pia->next;
+                       printf("Indirect action #%u destroyed\n", pia->id);
+                       free(pia);
                        break;
                }
                if (i == n)
@@ -1912,72 +1547,88 @@ port_shared_action_destroy(portid_t port_id,
 }
 
 
-/** Get shared action by port + id */
-struct rte_flow_shared_action *
-port_shared_action_get_by_id(portid_t port_id, uint32_t id)
+/** Get indirect action by port + id */
+struct rte_flow_action_handle *
+port_action_handle_get_by_id(portid_t port_id, uint32_t id)
 {
 
-       struct port_shared_action *psa = action_get_by_id(port_id, id);
+       struct port_indirect_action *pia = action_get_by_id(port_id, id);
 
-       return (psa) ? psa->action : NULL;
+       return (pia) ? pia->handle : NULL;
 }
 
-/** Update shared action */
+/** Update indirect action */
 int
-port_shared_action_update(portid_t port_id, uint32_t id,
+port_action_handle_update(portid_t port_id, uint32_t id,
                          const struct rte_flow_action *action)
 {
        struct rte_flow_error error;
-       struct rte_flow_shared_action *shared_action;
+       struct rte_flow_action_handle *action_handle;
 
-       shared_action = port_shared_action_get_by_id(port_id, id);
-       if (!shared_action)
+       action_handle = port_action_handle_get_by_id(port_id, id);
+       if (!action_handle)
                return -EINVAL;
-       if (rte_flow_shared_action_update(port_id, shared_action, action,
+       if (rte_flow_action_handle_update(port_id, action_handle, action,
                                          &error)) {
                return port_flow_complain(&error);
        }
-       printf("Shared action #%u updated\n", id);
+       printf("Indirect action #%u updated\n", id);
        return 0;
 }
 
 int
-port_shared_action_query(portid_t port_id, uint32_t id)
+port_action_handle_query(portid_t port_id, uint32_t id)
 {
        struct rte_flow_error error;
-       struct port_shared_action *psa;
+       struct port_indirect_action *pia;
        uint64_t default_data;
        void *data = NULL;
        int ret = 0;
 
-       psa = action_get_by_id(port_id, id);
-       if (!psa)
+       pia = action_get_by_id(port_id, id);
+       if (!pia)
                return -EINVAL;
-       switch (psa->type) {
+       switch (pia->type) {
        case RTE_FLOW_ACTION_TYPE_RSS:
+       case RTE_FLOW_ACTION_TYPE_AGE:
                data = &default_data;
                break;
        default:
-               printf("Shared action %u (type: %d) on port %u doesn't support"
-                      " query\n", id, psa->type, port_id);
+               printf("Indirect action %u (type: %d) on port %u doesn't"
+                      " support query\n", id, pia->type, port_id);
                return -1;
        }
-       if (rte_flow_shared_action_query(port_id, psa->action, data, &error))
+       if (rte_flow_action_handle_query(port_id, pia->handle, data, &error))
                ret = port_flow_complain(&error);
-       switch (psa->type) {
+       switch (pia->type) {
        case RTE_FLOW_ACTION_TYPE_RSS:
                if (!ret)
                        printf("Shared RSS action:\n\trefs:%u\n",
                               *((uint32_t *)data));
                data = NULL;
                break;
+       case RTE_FLOW_ACTION_TYPE_AGE:
+               if (!ret) {
+                       struct rte_flow_query_age *resp = data;
+
+                       printf("AGE:\n"
+                              " aged: %u\n"
+                              " sec_since_last_hit_valid: %u\n"
+                              " sec_since_last_hit: %" PRIu32 "\n",
+                              resp->aged,
+                              resp->sec_since_last_hit_valid,
+                              resp->sec_since_last_hit);
+               }
+               data = NULL;
+               break;
        default:
-               printf("Shared action %u (type: %d) on port %u doesn't support"
-                      " query\n", id, psa->type, port_id);
+               printf("Indirect action %u (type: %d) on port %u doesn't"
+                      " support query\n", id, pia->type, port_id);
                ret = -1;
        }
        return ret;
 }
+
 static struct port_flow_tunnel *
 port_flow_tunnel_offload_cmd_prep(portid_t port_id,
                                  const struct rte_flow_item *pattern,
@@ -2113,24 +1764,20 @@ port_flow_validate(portid_t port_id,
        return 0;
 }
 
-/** Update age action context by port_flow pointer. */
-void
-update_age_action_context(const struct rte_flow_action *actions,
-                       struct port_flow *pf)
+/** Return age action structure if exists, otherwise NULL. */
+static struct rte_flow_action_age *
+age_action_get(const struct rte_flow_action *actions)
 {
-       struct rte_flow_action_age *age = NULL;
-
        for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
                switch (actions->type) {
                case RTE_FLOW_ACTION_TYPE_AGE:
-                       age = (struct rte_flow_action_age *)
+                       return (struct rte_flow_action_age *)
                                (uintptr_t)actions->conf;
-                       age->context = pf;
-                       return;
                default:
                        break;
                }
        }
+       return NULL;
 }
 
 /** Create flow rule. */
@@ -2147,6 +1794,7 @@ port_flow_create(portid_t port_id,
        uint32_t id = 0;
        struct rte_flow_error error;
        struct port_flow_tunnel *pft = NULL;
+       struct rte_flow_action_age *age = age_action_get(actions);
 
        port = &ports[port_id];
        if (port->flow_list) {
@@ -2170,7 +1818,10 @@ port_flow_create(portid_t port_id,
        pf = port_flow_new(attr, pattern, actions, &error);
        if (!pf)
                return port_flow_complain(&error);
-       update_age_action_context(actions, pf);
+       if (age) {
+               pf->age_type = ACTION_AGE_CONTEXT_TYPE_FLOW;
+               age->context = &pf->age_type;
+       }
        /* Poisoning to make sure PMDs update it in case of error. */
        memset(&error, 0x22, sizeof(error));
        flow = rte_flow_create(port_id, attr, pattern, actions, &error);
@@ -2264,13 +1915,41 @@ port_flow_flush(portid_t port_id)
        return ret;
 }
 
-/** Dump all flow rules. */
+/** Dump flow rules. */
 int
-port_flow_dump(portid_t port_id, const char *file_name)
+port_flow_dump(portid_t port_id, bool dump_all, uint32_t rule_id,
+               const char *file_name)
 {
        int ret = 0;
        FILE *file = stdout;
        struct rte_flow_error error;
+       struct rte_port *port;
+       struct port_flow *pflow;
+       struct rte_flow *tmpFlow = NULL;
+       bool found = false;
+
+       if (port_id_is_invalid(port_id, ENABLED_WARN) ||
+               port_id == (portid_t)RTE_PORT_ALL)
+               return -EINVAL;
+
+       if (!dump_all) {
+               port = &ports[port_id];
+               pflow = port->flow_list;
+               while (pflow) {
+                       if (rule_id != pflow->id) {
+                               pflow = pflow->next;
+                       } else {
+                               tmpFlow = pflow->flow;
+                               if (tmpFlow)
+                                       found = true;
+                               break;
+                       }
+               }
+               if (found == false) {
+                       printf("Failed to dump to flow %d\n", rule_id);
+                       return -EINVAL;
+               }
+       }
 
        if (file_name && strlen(file_name)) {
                file = fopen(file_name, "w");
@@ -2280,7 +1959,11 @@ port_flow_dump(portid_t port_id, const char *file_name)
                        return -errno;
                }
        }
-       ret = rte_flow_dev_dump(port_id, file, &error);
+
+       if (!dump_all)
+               ret = rte_flow_dev_dump(port_id, tmpFlow, file, &error);
+       else
+               ret = rte_flow_dev_dump(port_id, NULL, file, &error);
        if (ret) {
                port_flow_complain(&error);
                printf("Failed to dump flow: %s\n", strerror(-ret));
@@ -2379,7 +2062,11 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
        void **contexts;
        int nb_context, total = 0, idx;
        struct rte_flow_error error;
-       struct port_flow *pf;
+       enum age_action_context_type *type;
+       union {
+               struct port_flow *pf;
+               struct port_indirect_action *pia;
+       } ctx;
 
        if (port_id_is_invalid(port_id, ENABLED_WARN) ||
            port_id == (portid_t)RTE_PORT_ALL)
@@ -2397,7 +2084,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
                printf("Cannot allocate contexts for aged flow\n");
                return;
        }
-       printf("ID\tGroup\tPrio\tAttr\n");
+       printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
        nb_context = rte_flow_get_aged_flows(port_id, contexts, total, &error);
        if (nb_context != total) {
                printf("Port:%d get aged flows count(%d) != total(%d)\n",
@@ -2405,37 +2092,41 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
                free(contexts);
                return;
        }
+       total = 0;
        for (idx = 0; idx < nb_context; idx++) {
-               pf = (struct port_flow *)contexts[idx];
-               if (!pf) {
+               if (!contexts[idx]) {
                        printf("Error: get Null context in port %u\n", port_id);
                        continue;
                }
-               printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
-                      pf->id,
-                      pf->rule.attr->group,
-                      pf->rule.attr->priority,
-                      pf->rule.attr->ingress ? 'i' : '-',
-                      pf->rule.attr->egress ? 'e' : '-',
-                      pf->rule.attr->transfer ? 't' : '-');
-       }
-       if (destroy) {
-               int ret;
-               uint32_t flow_id;
-
-               total = 0;
-               printf("\n");
-               for (idx = 0; idx < nb_context; idx++) {
-                       pf = (struct port_flow *)contexts[idx];
-                       if (!pf)
-                               continue;
-                       flow_id = pf->id;
-                       ret = port_flow_destroy(port_id, 1, &flow_id);
-                       if (!ret)
+               type = (enum age_action_context_type *)contexts[idx];
+               switch (*type) {
+               case ACTION_AGE_CONTEXT_TYPE_FLOW:
+                       ctx.pf = container_of(type, struct port_flow, age_type);
+                       printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
+                                                                "\t%c%c%c\t\n",
+                              "Flow",
+                              ctx.pf->id,
+                              ctx.pf->rule.attr->group,
+                              ctx.pf->rule.attr->priority,
+                              ctx.pf->rule.attr->ingress ? 'i' : '-',
+                              ctx.pf->rule.attr->egress ? 'e' : '-',
+                              ctx.pf->rule.attr->transfer ? 't' : '-');
+                       if (destroy && !port_flow_destroy(port_id, 1,
+                                                         &ctx.pf->id))
                                total++;
+                       break;
+               case ACTION_AGE_CONTEXT_TYPE_INDIRECT_ACTION:
+                       ctx.pia = container_of(type,
+                                       struct port_indirect_action, age_type);
+                       printf("%-20s\t%" PRIu32 "\n", "Indirect action",
+                              ctx.pia->id);
+                       break;
+               default:
+                       printf("Error: invalid context type %u\n", port_id);
+                       break;
                }
-               printf("%d flows be destroyed\n", total);
        }
+       printf("\n%d flows destroyed\n", total);
        free(contexts);
 }
 
@@ -2557,7 +2248,7 @@ tx_queue_id_is_invalid(queueid_t txq_id)
 {
        if (txq_id < nb_txq)
                return 0;
-       printf("Invalid TX queue %d (must be < nb_rxq=%d)\n", txq_id, nb_txq);
+       printf("Invalid TX queue %d (must be < nb_txq=%d)\n", txq_id, nb_txq);
        return 1;
 }
 
@@ -3015,7 +2706,7 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)
 
 void
 port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,
-                        uint hash_key_len)
+                        uint8_t hash_key_len)
 {
        struct rte_eth_rss_conf rss_conf;
        int diag;
@@ -3456,9 +3147,9 @@ set_fwd_lcores_list(unsigned int *lcorelist, unsigned int nb_lc)
                        printf("lcore %u not enabled\n", lcore_cpuid);
                        return -1;
                }
-               if (lcore_cpuid == rte_get_master_lcore()) {
+               if (lcore_cpuid == rte_get_main_lcore()) {
                        printf("lcore %u cannot be masked on for running "
-                              "packet forwarding, which is the master lcore "
+                              "packet forwarding, which is the main lcore "
                               "and reserved for command line parsing only\n",
                               lcore_cpuid);
                        return -1;
@@ -3504,6 +3195,10 @@ set_fwd_lcores_mask(uint64_t lcoremask)
 void
 set_fwd_lcores_number(uint16_t nb_lc)
 {
+       if (test_done == 0) {
+               printf("Please stop forwarding first\n");
+               return;
+       }
        if (nb_lc > nb_cfg_lcores) {
                printf("nb fwd cores %u > %u (max. number of configured "
                       "lcores) - ignored\n",
@@ -3765,7 +3460,7 @@ show_fec_capability(unsigned int num, struct rte_eth_fec_capa *speed_fec_capa)
                printf("%s : ",
                        rte_eth_link_speed_to_str(speed_fec_capa[i].speed));
 
-               for (j = RTE_ETH_FEC_AUTO; j < RTE_DIM(fec_mode_name); j++) {
+               for (j = 0; j < RTE_DIM(fec_mode_name); j++) {
                        if (RTE_ETH_FEC_MODE_TO_CAPA(j) &
                                                speed_fec_capa[i].capa)
                                printf("%s ", fec_mode_name[j].name);
@@ -3774,6 +3469,94 @@ show_fec_capability(unsigned int num, struct rte_eth_fec_capa *speed_fec_capa)
        }
 }
 
+void
+show_rx_pkt_offsets(void)
+{
+       uint32_t i, n;
+
+       n = rx_pkt_nb_offs;
+       printf("Number of offsets: %u\n", n);
+       if (n) {
+               printf("Segment offsets: ");
+               for (i = 0; i != n - 1; i++)
+                       printf("%hu,", rx_pkt_seg_offsets[i]);
+               printf("%hu\n", rx_pkt_seg_lengths[i]);
+       }
+}
+
+void
+set_rx_pkt_offsets(unsigned int *seg_offsets, unsigned int nb_offs)
+{
+       unsigned int i;
+
+       if (nb_offs >= MAX_SEGS_BUFFER_SPLIT) {
+               printf("nb segments per RX packets=%u >= "
+                      "MAX_SEGS_BUFFER_SPLIT - ignored\n", nb_offs);
+               return;
+       }
+
+       /*
+        * No extra check here, the segment length will be checked by PMD
+        * in the extended queue setup.
+        */
+       for (i = 0; i < nb_offs; i++) {
+               if (seg_offsets[i] >= UINT16_MAX) {
+                       printf("offset[%u]=%u > UINT16_MAX - give up\n",
+                              i, seg_offsets[i]);
+                       return;
+               }
+       }
+
+       for (i = 0; i < nb_offs; i++)
+               rx_pkt_seg_offsets[i] = (uint16_t) seg_offsets[i];
+
+       rx_pkt_nb_offs = (uint8_t) nb_offs;
+}
+
+void
+show_rx_pkt_segments(void)
+{
+       uint32_t i, n;
+
+       n = rx_pkt_nb_segs;
+       printf("Number of segments: %u\n", n);
+       if (n) {
+               printf("Segment sizes: ");
+               for (i = 0; i != n - 1; i++)
+                       printf("%hu,", rx_pkt_seg_lengths[i]);
+               printf("%hu\n", rx_pkt_seg_lengths[i]);
+       }
+}
+
+void
+set_rx_pkt_segments(unsigned int *seg_lengths, unsigned int nb_segs)
+{
+       unsigned int i;
+
+       if (nb_segs >= MAX_SEGS_BUFFER_SPLIT) {
+               printf("nb segments per RX packets=%u >= "
+                      "MAX_SEGS_BUFFER_SPLIT - ignored\n", nb_segs);
+               return;
+       }
+
+       /*
+        * No extra check here, the segment length will be checked by PMD
+        * in the extended queue setup.
+        */
+       for (i = 0; i < nb_segs; i++) {
+               if (seg_lengths[i] >= UINT16_MAX) {
+                       printf("length[%u]=%u > UINT16_MAX - give up\n",
+                              i, seg_lengths[i]);
+                       return;
+               }
+       }
+
+       for (i = 0; i < nb_segs; i++)
+               rx_pkt_seg_lengths[i] = (uint16_t) seg_lengths[i];
+
+       rx_pkt_nb_segs = (uint8_t) nb_segs;
+}
+
 void
 show_tx_pkt_segments(void)
 {
@@ -3819,10 +3602,10 @@ nb_segs_is_invalid(unsigned int nb_segs)
 }
 
 void
-set_tx_pkt_segments(unsigned *seg_lengths, unsigned nb_segs)
+set_tx_pkt_segments(unsigned int *seg_lengths, unsigned int nb_segs)
 {
        uint16_t tx_pkt_len;
-       unsigned i;
+       unsigned int i;
 
        if (nb_segs_is_invalid(nb_segs))
                return;
@@ -3867,44 +3650,6 @@ show_tx_pkt_times(void)
 void
 set_tx_pkt_times(unsigned int *tx_times)
 {
-       uint16_t port_id;
-       int offload_found = 0;
-       int offset;
-       int flag;
-
-       static const struct rte_mbuf_dynfield desc_offs = {
-               .name = RTE_MBUF_DYNFIELD_TIMESTAMP_NAME,
-               .size = sizeof(uint64_t),
-               .align = __alignof__(uint64_t),
-       };
-       static const struct rte_mbuf_dynflag desc_flag = {
-               .name = RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME,
-       };
-
-       RTE_ETH_FOREACH_DEV(port_id) {
-               struct rte_eth_dev_info dev_info = { 0 };
-               int ret;
-
-               ret = rte_eth_dev_info_get(port_id, &dev_info);
-               if (ret == 0 && dev_info.tx_offload_capa &
-                               DEV_TX_OFFLOAD_SEND_ON_TIMESTAMP) {
-                       offload_found = 1;
-                       break;
-               }
-       }
-       if (!offload_found) {
-               printf("No device supporting Tx timestamp scheduling found, "
-                      "dynamic flag and field not registered\n");
-               return;
-       }
-       offset = rte_mbuf_dynfield_register(&desc_offs);
-       if (offset < 0 && rte_errno != EEXIST)
-               printf("Dynamic timestamp field registration error: %d",
-                      rte_errno);
-       flag = rte_mbuf_dynflag_register(&desc_flag);
-       if (flag < 0 && rte_errno != EEXIST)
-               printf("Dynamic timestamp flag registration error: %d",
-                      rte_errno);
        tx_pkt_times_inter = tx_times[0];
        tx_pkt_times_intra = tx_times[1];
 }
@@ -4458,8 +4203,7 @@ tx_vlan_pvid_set(portid_t port_id, uint16_t vlan_id, int on)
 void
 set_qmap(portid_t port_id, uint8_t is_rx, uint16_t queue_id, uint8_t map_value)
 {
-       uint16_t i;
-       uint8_t existing_mapping_found = 0;
+       int ret;
 
        if (port_id_is_invalid(port_id, ENABLED_WARN))
                return;
@@ -4469,40 +4213,23 @@ set_qmap(portid_t port_id, uint8_t is_rx, uint16_t queue_id, uint8_t map_value)
 
        if (map_value >= RTE_ETHDEV_QUEUE_STAT_CNTRS) {
                printf("map_value not in required range 0..%d\n",
-                               RTE_ETHDEV_QUEUE_STAT_CNTRS - 1);
+                      RTE_ETHDEV_QUEUE_STAT_CNTRS - 1);
                return;
        }
 
-       if (!is_rx) { /*then tx*/
-               for (i = 0; i < nb_tx_queue_stats_mappings; i++) {
-                       if ((tx_queue_stats_mappings[i].port_id == port_id) &&
-                           (tx_queue_stats_mappings[i].queue_id == queue_id)) {
-                               tx_queue_stats_mappings[i].stats_counter_id = map_value;
-                               existing_mapping_found = 1;
-                               break;
-                       }
-               }
-               if (!existing_mapping_found) { /* A new additional mapping... */
-                       tx_queue_stats_mappings[nb_tx_queue_stats_mappings].port_id = port_id;
-                       tx_queue_stats_mappings[nb_tx_queue_stats_mappings].queue_id = queue_id;
-                       tx_queue_stats_mappings[nb_tx_queue_stats_mappings].stats_counter_id = map_value;
-                       nb_tx_queue_stats_mappings++;
-               }
-       }
-       else { /*rx*/
-               for (i = 0; i < nb_rx_queue_stats_mappings; i++) {
-                       if ((rx_queue_stats_mappings[i].port_id == port_id) &&
-                           (rx_queue_stats_mappings[i].queue_id == queue_id)) {
-                               rx_queue_stats_mappings[i].stats_counter_id = map_value;
-                               existing_mapping_found = 1;
-                               break;
-                       }
+       if (!is_rx) { /* tx */
+               ret = rte_eth_dev_set_tx_queue_stats_mapping(port_id, queue_id,
+                                                            map_value);
+               if (ret) {
+                       printf("failed to set tx queue stats mapping.\n");
+                       return;
                }
-               if (!existing_mapping_found) { /* A new additional mapping... */
-                       rx_queue_stats_mappings[nb_rx_queue_stats_mappings].port_id = port_id;
-                       rx_queue_stats_mappings[nb_rx_queue_stats_mappings].queue_id = queue_id;
-                       rx_queue_stats_mappings[nb_rx_queue_stats_mappings].stats_counter_id = map_value;
-                       nb_rx_queue_stats_mappings++;
+       } else { /* rx */
+               ret = rte_eth_dev_set_rx_queue_stats_mapping(port_id, queue_id,
+                                                            map_value);
+               if (ret) {
+                       printf("failed to set rx queue stats mapping.\n");
+                       return;
                }
        }
 }
@@ -4623,6 +4350,8 @@ flowtype_to_str(uint16_t flow_type)
        return NULL;
 }
 
+#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE)
+
 static inline void
 print_fdir_flex_mask(struct rte_eth_fdir_flex_conf *flex_conf, uint32_t num)
 {
@@ -4662,25 +4391,16 @@ static int
 get_fdir_info(portid_t port_id, struct rte_eth_fdir_info *fdir_info,
                    struct rte_eth_fdir_stats *fdir_stat)
 {
-       int ret;
-
-       ret = rte_eth_dev_filter_supported(port_id, RTE_ETH_FILTER_FDIR);
-       if (!ret) {
-               rte_eth_dev_filter_ctrl(port_id, RTE_ETH_FILTER_FDIR,
-                              RTE_ETH_FILTER_INFO, fdir_info);
-               rte_eth_dev_filter_ctrl(port_id, RTE_ETH_FILTER_FDIR,
-                              RTE_ETH_FILTER_STATS, fdir_stat);
-               return 0;
-       }
+       int ret = -ENOTSUP;
 
-#ifdef RTE_LIBRTE_I40E_PMD
+#ifdef RTE_NET_I40E
        if (ret == -ENOTSUP) {
                ret = rte_pmd_i40e_get_fdir_info(port_id, fdir_info);
                if (!ret)
                        ret = rte_pmd_i40e_get_fdir_stats(port_id, fdir_stat);
        }
 #endif
-#ifdef RTE_LIBRTE_IXGBE_PMD
+#ifdef RTE_NET_IXGBE
        if (ret == -ENOTSUP) {
                ret = rte_pmd_ixgbe_get_fdir_info(port_id, fdir_info);
                if (!ret)
@@ -4769,6 +4489,8 @@ fdir_get_infos(portid_t port_id)
               fdir_stats_border, fdir_stats_border);
 }
 
+#endif /* RTE_NET_I40E || RTE_NET_IXGBE */
+
 void
 fdir_set_flex_mask(portid_t port_id, struct rte_eth_fdir_flex_mask *cfg)
 {
@@ -4833,7 +4555,7 @@ fdir_set_flex_payload(portid_t port_id, struct rte_eth_flex_payload_cfg *cfg)
 void
 set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on)
 {
-#ifdef RTE_LIBRTE_IXGBE_PMD
+#ifdef RTE_NET_IXGBE
        int diag;
 
        if (is_rx)
@@ -4888,12 +4610,12 @@ set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, uint64_t q_msk)
        RTE_SET_USED(rate);
        RTE_SET_USED(q_msk);
 
-#ifdef RTE_LIBRTE_IXGBE_PMD
+#ifdef RTE_NET_IXGBE
        if (diag == -ENOTSUP)
                diag = rte_pmd_ixgbe_set_vf_rate_limit(port_id, vf, rate,
                                                       q_msk);
 #endif
-#ifdef RTE_LIBRTE_BNXT_PMD
+#ifdef RTE_NET_BNXT
        if (diag == -ENOTSUP)
                diag = rte_pmd_bnxt_set_vf_rate_limit(port_id, vf, rate, q_msk);
 #endif
@@ -5189,7 +4911,7 @@ close_file(uint8_t *buf)
 void
 port_queue_region_info_display(portid_t port_id, void *buf)
 {
-#ifdef RTE_LIBRTE_I40E_PMD
+#ifdef RTE_NET_I40E
        uint16_t i, j;
        struct rte_pmd_i40e_queue_regions *info =
                (struct rte_pmd_i40e_queue_regions *)buf;
@@ -5240,7 +4962,8 @@ show_macs(portid_t port_id)
 
        dev = &rte_eth_devices[port_id];
 
-       rte_eth_dev_info_get(port_id, &dev_info);
+       if (eth_dev_info_get_print_err(port_id, &dev_info))
+               return;
 
        for (i = 0; i < dev_info.max_mac_addrs; i++) {
                addr = &dev->data->mac_addrs[i];