app/testpmd: fix copy of raw flow item
[dpdk.git] / app / test-pmd / config.c
index d98c082..bcaf429 100644 (file)
@@ -407,6 +407,7 @@ port_infos_display(portid_t port_id)
        static const char *info_border = "*********************";
        portid_t pid;
        uint16_t mtu;
+       char name[RTE_ETH_NAME_MAX_LEN];
 
        if (port_id_is_invalid(port_id, ENABLED_WARN)) {
                printf("Valid port range is [0");
@@ -423,6 +424,8 @@ port_infos_display(portid_t port_id)
               info_border, port_id, info_border);
        rte_eth_macaddr_get(port_id, &mac_addr);
        print_ethaddr("MAC address: ", &mac_addr);
+       rte_eth_dev_get_name_by_port(port_id, name);
+       printf("\nDevice name: %s", name);
        printf("\nDriver name: %s", dev_info.driver_name);
        printf("\nConnect to socket: %u", port->socket_id);
 
@@ -517,6 +520,18 @@ port_infos_display(portid_t port_id)
        printf("Min possible number of TXDs per queue: %hu\n",
                dev_info.tx_desc_lim.nb_min);
        printf("TXDs number alignment: %hu\n", dev_info.tx_desc_lim.nb_align);
+
+       /* Show switch info only if valid switch domain and port id is set */
+       if (dev_info.switch_info.domain_id !=
+               RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID) {
+               if (dev_info.switch_info.name)
+                       printf("Switch name: %s\n", dev_info.switch_info.name);
+
+               printf("Switch domain Id: %u\n",
+                       dev_info.switch_info.domain_id);
+               printf("Switch Port Id: %u\n",
+                       dev_info.switch_info.port_id);
+       }
 }
 
 void
@@ -993,8 +1008,9 @@ static const struct {
        MK_FLOW_ITEM(ANY, sizeof(struct rte_flow_item_any)),
        MK_FLOW_ITEM(PF, 0),
        MK_FLOW_ITEM(VF, sizeof(struct rte_flow_item_vf)),
-       MK_FLOW_ITEM(PORT, sizeof(struct rte_flow_item_port)),
-       MK_FLOW_ITEM(RAW, sizeof(struct rte_flow_item_raw)), /* +pattern[] */
+       MK_FLOW_ITEM(PHY_PORT, sizeof(struct rte_flow_item_phy_port)),
+       MK_FLOW_ITEM(PORT_ID, sizeof(struct rte_flow_item_port_id)),
+       MK_FLOW_ITEM(RAW, sizeof(struct rte_flow_item_raw)),
        MK_FLOW_ITEM(ETH, sizeof(struct rte_flow_item_eth)),
        MK_FLOW_ITEM(VLAN, sizeof(struct rte_flow_item_vlan)),
        MK_FLOW_ITEM(IPV4, sizeof(struct rte_flow_item_ipv4)),
@@ -1013,6 +1029,17 @@ static const struct {
        MK_FLOW_ITEM(GTPC, sizeof(struct rte_flow_item_gtp)),
        MK_FLOW_ITEM(GTPU, sizeof(struct rte_flow_item_gtp)),
        MK_FLOW_ITEM(GENEVE, sizeof(struct rte_flow_item_geneve)),
+       MK_FLOW_ITEM(VXLAN_GPE, sizeof(struct rte_flow_item_vxlan_gpe)),
+       MK_FLOW_ITEM(ARP_ETH_IPV4, sizeof(struct rte_flow_item_arp_eth_ipv4)),
+       MK_FLOW_ITEM(IPV6_EXT, sizeof(struct rte_flow_item_ipv6_ext)),
+       MK_FLOW_ITEM(ICMP6, sizeof(struct rte_flow_item_icmp6)),
+       MK_FLOW_ITEM(ICMP6_ND_NS, sizeof(struct rte_flow_item_icmp6_nd_ns)),
+       MK_FLOW_ITEM(ICMP6_ND_NA, sizeof(struct rte_flow_item_icmp6_nd_na)),
+       MK_FLOW_ITEM(ICMP6_ND_OPT, sizeof(struct rte_flow_item_icmp6_nd_opt)),
+       MK_FLOW_ITEM(ICMP6_ND_OPT_SLA_ETH,
+                    sizeof(struct rte_flow_item_icmp6_nd_opt_sla_eth)),
+       MK_FLOW_ITEM(ICMP6_ND_OPT_TLA_ETH,
+                    sizeof(struct rte_flow_item_icmp6_nd_opt_tla_eth)),
 };
 
 /** Pattern item specification types. */
@@ -1043,14 +1070,21 @@ flow_item_spec_copy(void *buf, const struct rte_flow_item *item,
                union {
                        struct rte_flow_item_raw *raw;
                } dst;
+               size_t off;
 
        case RTE_FLOW_ITEM_TYPE_RAW:
                src.raw = item_spec;
                dst.raw = buf;
-               size = offsetof(struct rte_flow_item_raw, pattern) +
-                       src.raw->length * sizeof(*src.raw->pattern);
-               if (dst.raw)
-                       memcpy(dst.raw, src.raw, size);
+               off = RTE_ALIGN_CEIL(sizeof(struct rte_flow_item_raw),
+                                    sizeof(*src.raw->pattern));
+               size = off + ((const struct rte_flow_item_raw *)item->spec)->
+                       length * sizeof(*src.raw->pattern);
+               if (dst.raw) {
+                       memcpy(dst.raw, src.raw, sizeof(*src.raw));
+                       dst.raw->pattern = memcpy((uint8_t *)dst.raw + off,
+                                                 src.raw->pattern,
+                                                 size - off);
+               }
                break;
        default:
                size = flow_item[item->type].size;
@@ -1081,12 +1115,32 @@ static const struct {
        MK_FLOW_ACTION(FLAG, 0),
        MK_FLOW_ACTION(QUEUE, sizeof(struct rte_flow_action_queue)),
        MK_FLOW_ACTION(DROP, 0),
-       MK_FLOW_ACTION(COUNT, 0),
-       MK_FLOW_ACTION(DUP, sizeof(struct rte_flow_action_dup)),
-       MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* +queue[] */
+       MK_FLOW_ACTION(COUNT, sizeof(struct rte_flow_action_count)),
+       MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)),
        MK_FLOW_ACTION(PF, 0),
        MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)),
+       MK_FLOW_ACTION(PHY_PORT, sizeof(struct rte_flow_action_phy_port)),
+       MK_FLOW_ACTION(PORT_ID, sizeof(struct rte_flow_action_port_id)),
        MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)),
+       MK_FLOW_ACTION(OF_SET_MPLS_TTL,
+                      sizeof(struct rte_flow_action_of_set_mpls_ttl)),
+       MK_FLOW_ACTION(OF_DEC_MPLS_TTL, 0),
+       MK_FLOW_ACTION(OF_SET_NW_TTL,
+                      sizeof(struct rte_flow_action_of_set_nw_ttl)),
+       MK_FLOW_ACTION(OF_DEC_NW_TTL, 0),
+       MK_FLOW_ACTION(OF_COPY_TTL_OUT, 0),
+       MK_FLOW_ACTION(OF_COPY_TTL_IN, 0),
+       MK_FLOW_ACTION(OF_POP_VLAN, 0),
+       MK_FLOW_ACTION(OF_PUSH_VLAN,
+                      sizeof(struct rte_flow_action_of_push_vlan)),
+       MK_FLOW_ACTION(OF_SET_VLAN_VID,
+                      sizeof(struct rte_flow_action_of_set_vlan_vid)),
+       MK_FLOW_ACTION(OF_SET_VLAN_PCP,
+                      sizeof(struct rte_flow_action_of_set_vlan_pcp)),
+       MK_FLOW_ACTION(OF_POP_MPLS,
+                      sizeof(struct rte_flow_action_of_pop_mpls)),
+       MK_FLOW_ACTION(OF_PUSH_MPLS,
+                      sizeof(struct rte_flow_action_of_push_mpls)),
 };
 
 /** Compute storage space needed by action configuration and copy it. */
@@ -1112,37 +1166,29 @@ flow_action_conf_copy(void *buf, const struct rte_flow_action *action)
                off = 0;
                if (dst.rss)
                        *dst.rss = (struct rte_flow_action_rss){
-                               .num = src.rss->num,
+                               .func = src.rss->func,
+                               .level = src.rss->level,
+                               .types = src.rss->types,
+                               .key_len = src.rss->key_len,
+                               .queue_num = src.rss->queue_num,
                        };
-               off += offsetof(struct rte_flow_action_rss, queue);
-               if (src.rss->num) {
-                       size = sizeof(*src.rss->queue) * src.rss->num;
+               off += sizeof(*src.rss);
+               if (src.rss->key_len) {
+                       off = RTE_ALIGN_CEIL(off, sizeof(double));
+                       size = sizeof(*src.rss->key) * src.rss->key_len;
                        if (dst.rss)
-                               memcpy(dst.rss->queue, src.rss->queue, size);
+                               dst.rss->key = memcpy
+                                       ((void *)((uintptr_t)dst.rss + off),
+                                        src.rss->key, size);
                        off += size;
                }
-               off = RTE_ALIGN_CEIL(off, sizeof(double));
-               if (dst.rss) {
-                       dst.rss->rss_conf = (void *)((uintptr_t)dst.rss + off);
-                       *(struct rte_eth_rss_conf *)(uintptr_t)
-                               dst.rss->rss_conf = (struct rte_eth_rss_conf){
-                               .rss_key_len = src.rss->rss_conf->rss_key_len,
-                               .rss_hf = src.rss->rss_conf->rss_hf,
-                       };
-               }
-               off += sizeof(*src.rss->rss_conf);
-               if (src.rss->rss_conf->rss_key_len) {
+               if (src.rss->queue_num) {
                        off = RTE_ALIGN_CEIL(off, sizeof(double));
-                       size = sizeof(*src.rss->rss_conf->rss_key) *
-                               src.rss->rss_conf->rss_key_len;
-                       if (dst.rss) {
-                               ((struct rte_eth_rss_conf *)(uintptr_t)
-                                dst.rss->rss_conf)->rss_key =
-                                       (void *)((uintptr_t)dst.rss + off);
-                               memcpy(dst.rss->rss_conf->rss_key,
-                                      src.rss->rss_conf->rss_key,
-                                      size);
-                       }
+                       size = sizeof(*src.rss->queue) * src.rss->queue_num;
+                       if (dst.rss)
+                               dst.rss->queue = memcpy
+                                       ((void *)((uintptr_t)dst.rss + off),
+                                        src.rss->queue, size);
                        off += size;
                }
                size = off;
@@ -1259,10 +1305,15 @@ port_flow_complain(struct rte_flow_error *error)
                [RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY] = "priority field",
                [RTE_FLOW_ERROR_TYPE_ATTR_INGRESS] = "ingress field",
                [RTE_FLOW_ERROR_TYPE_ATTR_EGRESS] = "egress field",
+               [RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER] = "transfer field",
                [RTE_FLOW_ERROR_TYPE_ATTR] = "attributes structure",
                [RTE_FLOW_ERROR_TYPE_ITEM_NUM] = "pattern length",
+               [RTE_FLOW_ERROR_TYPE_ITEM_SPEC] = "item specification",
+               [RTE_FLOW_ERROR_TYPE_ITEM_LAST] = "item specification range",
+               [RTE_FLOW_ERROR_TYPE_ITEM_MASK] = "item specification mask",
                [RTE_FLOW_ERROR_TYPE_ITEM] = "specific pattern item",
                [RTE_FLOW_ERROR_TYPE_ACTION_NUM] = "number of actions",
+               [RTE_FLOW_ERROR_TYPE_ACTION_CONF] = "action configuration",
                [RTE_FLOW_ERROR_TYPE_ACTION] = "specific action",
        };
        const char *errstr;
@@ -1417,7 +1468,7 @@ port_flow_flush(portid_t port_id)
 /** Query a flow rule. */
 int
 port_flow_query(portid_t port_id, uint32_t rule,
-               enum rte_flow_action_type action)
+               const struct rte_flow_action *action)
 {
        struct rte_flow_error error;
        struct rte_port *port;
@@ -1438,16 +1489,17 @@ port_flow_query(portid_t port_id, uint32_t rule,
                printf("Flow rule #%u not found\n", rule);
                return -ENOENT;
        }
-       if ((unsigned int)action >= RTE_DIM(flow_action) ||
-           !flow_action[action].name)
+       if ((unsigned int)action->type >= RTE_DIM(flow_action) ||
+           !flow_action[action->type].name)
                name = "unknown";
        else
-               name = flow_action[action].name;
-       switch (action) {
+               name = flow_action[action->type].name;
+       switch (action->type) {
        case RTE_FLOW_ACTION_TYPE_COUNT:
                break;
        default:
-               printf("Cannot query action type %d (%s)\n", action, name);
+               printf("Cannot query action type %d (%s)\n",
+                       action->type, name);
                return -ENOTSUP;
        }
        /* Poisoning to make sure PMDs update it in case of error. */
@@ -1455,7 +1507,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
        memset(&query, 0, sizeof(query));
        if (rte_flow_query(port_id, pf->flow, action, &query, &error))
                return port_flow_complain(&error);
-       switch (action) {
+       switch (action->type) {
        case RTE_FLOW_ACTION_TYPE_COUNT:
                printf("%s:\n"
                       " hits_set: %u\n"
@@ -1470,7 +1522,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
                break;
        default:
                printf("Cannot display result for action type %d (%s)\n",
-                      action, name);
+                      action->type, name);
                break;
        }
        return 0;
@@ -1520,12 +1572,13 @@ port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n])
                const struct rte_flow_item *item = pf->pattern;
                const struct rte_flow_action *action = pf->actions;
 
-               printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c\t",
+               printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t",
                       pf->id,
                       pf->attr.group,
                       pf->attr.priority,
                       pf->attr.ingress ? 'i' : '-',
-                      pf->attr.egress ? 'e' : '-');
+                      pf->attr.egress ? 'e' : '-',
+                      pf->attr.transfer ? 't' : '-');
                while (item->type != RTE_FLOW_ITEM_TYPE_END) {
                        if (item->type != RTE_FLOW_ITEM_TYPE_VOID)
                                printf("%s ", flow_item[item->type].name);
@@ -1755,6 +1808,7 @@ void
 rxtx_config_display(void)
 {
        portid_t pid;
+       queueid_t qid;
 
        printf("  %s packet forwarding%s packets/burst=%d\n",
               cur_fwd_eng->fwd_mode_name,
@@ -1769,31 +1823,46 @@ rxtx_config_display(void)
               nb_fwd_lcores, nb_fwd_ports);
 
        RTE_ETH_FOREACH_DEV(pid) {
-               struct rte_eth_rxconf *rx_conf = &ports[pid].rx_conf;
-               struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf;
-
-               printf("  port %d:\n", (unsigned int)pid);
-               printf("  RX queues=%d - RX desc=%d - RX free threshold=%d\n",
-                               nb_rxq, nb_rxd, rx_conf->rx_free_thresh);
-               printf("  RX threshold registers: pthresh=%d hthresh=%d "
-                      " wthresh=%d\n",
-                               rx_conf->rx_thresh.pthresh,
-                               rx_conf->rx_thresh.hthresh,
-                               rx_conf->rx_thresh.wthresh);
-               printf("  Rx offloads=0x%"PRIx64" RXQ offloads=0x%"PRIx64"\n",
+               struct rte_eth_rxconf *rx_conf = &ports[pid].rx_conf[0];
+               struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf[0];
+               uint16_t *nb_rx_desc = &ports[pid].nb_rx_desc[0];
+               uint16_t *nb_tx_desc = &ports[pid].nb_tx_desc[0];
+
+               /* per port config */
+               printf("  port %d: RX queue number: %d Tx queue number: %d\n",
+                               (unsigned int)pid, nb_rxq, nb_txq);
+
+               printf("    Rx offloads=0x%"PRIx64" Tx offloads=0x%"PRIx64"\n",
                                ports[pid].dev_conf.rxmode.offloads,
-                               rx_conf->offloads);
-               printf("  TX queues=%d - TX desc=%d - TX free threshold=%d\n",
-                               nb_txq, nb_txd, tx_conf->tx_free_thresh);
-               printf("  TX threshold registers: pthresh=%d hthresh=%d "
-                      " wthresh=%d\n",
-                               tx_conf->tx_thresh.pthresh,
-                               tx_conf->tx_thresh.hthresh,
-                               tx_conf->tx_thresh.wthresh);
-               printf("  TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);
-               printf("  Tx offloads=0x%"PRIx64" TXQ offloads=0x%"PRIx64"\n",
-                               ports[pid].dev_conf.txmode.offloads,
-                               tx_conf->offloads);
+                               ports[pid].dev_conf.txmode.offloads);
+
+               /* per rx queue config only for first queue to be less verbose */
+               for (qid = 0; qid < 1; qid++) {
+                       printf("    RX queue: %d\n", qid);
+                       printf("      RX desc=%d - RX free threshold=%d\n",
+                               nb_rx_desc[qid], rx_conf[qid].rx_free_thresh);
+                       printf("      RX threshold registers: pthresh=%d hthresh=%d "
+                               " wthresh=%d\n",
+                               rx_conf[qid].rx_thresh.pthresh,
+                               rx_conf[qid].rx_thresh.hthresh,
+                               rx_conf[qid].rx_thresh.wthresh);
+                       printf("      RX Offloads=0x%"PRIx64"\n",
+                               rx_conf[qid].offloads);
+               }
+
+               /* per tx queue config only for first queue to be less verbose */
+               for (qid = 0; qid < 1; qid++) {
+                       printf("    TX queue: %d\n", qid);
+                       printf("      TX desc=%d - TX free threshold=%d\n",
+                               nb_tx_desc[qid], tx_conf[qid].tx_free_thresh);
+                       printf("      TX threshold registers: pthresh=%d hthresh=%d "
+                               " wthresh=%d\n",
+                               tx_conf[qid].tx_thresh.pthresh,
+                               tx_conf[qid].tx_thresh.hthresh,
+                               tx_conf[qid].tx_thresh.wthresh);
+                       printf("      TX offloads=0x%"PRIx64" - TX RS bit threshold=%d\n",
+                               tx_conf[qid].offloads, tx_conf->tx_rs_thresh);
+               }
        }
 }
 
@@ -3110,6 +3179,7 @@ flowtype_to_str(uint16_t flow_type)
                {"vxlan", RTE_ETH_FLOW_VXLAN},
                {"geneve", RTE_ETH_FLOW_GENEVE},
                {"nvgre", RTE_ETH_FLOW_NVGRE},
+               {"vxlan-gpe", RTE_ETH_FLOW_VXLAN_GPE},
        };
 
        for (i = 0; i < RTE_DIM(flowtype_str_table); i++) {