app/testpmd: add forwarding engine for shared Rx queue
[dpdk.git] / app / test-pmd / testpmd.c
index 9061cbf..6d5bbc8 100644 (file)
@@ -188,6 +188,7 @@ struct fwd_engine * fwd_engines[] = {
 #ifdef RTE_LIBRTE_IEEE1588
        &ieee1588_fwd_engine,
 #endif
+       &shared_rxq_engine,
        NULL,
 };
 
@@ -208,12 +209,22 @@ uint32_t param_total_num_mbufs = 0;  /**< number of mbufs in all pools - if
                                       * specified on command-line. */
 uint16_t stats_period; /**< Period to show statistics (disabled by default) */
 
+/** Extended statistics to show. */
+struct rte_eth_xstat_name *xstats_display;
+
+unsigned int xstats_display_num; /**< Size of extended statistics to show */
+
 /*
  * In container, it cannot terminate the process which running with 'stats-period'
  * option. Set flag to exit stats period loop after received SIGINT/SIGTERM.
  */
 uint8_t f_quit;
 
+/*
+ * Max Rx frame size, set by '--max-pkt-len' parameter.
+ */
+uint32_t max_rx_pkt_len;
+
 /*
  * Configuration of packet segments used to scatter received packets
  * if some of split features is configured.
@@ -446,13 +457,7 @@ lcoreid_t latencystats_lcore_id = -1;
 /*
  * Ethernet device configuration.
  */
-struct rte_eth_rxmode rx_mode = {
-       /* Default maximum frame length.
-        * Zero is converted to "RTE_ETHER_MTU + PMD Ethernet overhead"
-        * in init_config().
-        */
-       .max_rx_pkt_len = 0,
-};
+struct rte_eth_rxmode rx_mode;
 
 struct rte_eth_txmode tx_mode = {
        .offloads = DEV_TX_OFFLOAD_MBUF_FAST_FREE,
@@ -498,6 +503,11 @@ uint8_t record_core_cycles;
  */
 uint8_t record_burst_stats;
 
+/*
+ * Number of ports per shared Rx queue group, 0 disable.
+ */
+uint32_t rxq_share;
+
 unsigned int num_sockets = 0;
 unsigned int socket_ids[RTE_MAX_NUMA_NODES];
 
@@ -521,6 +531,116 @@ enum rte_eth_rx_mq_mode rx_mq_mode = ETH_MQ_RX_VMDQ_DCB_RSS;
  */
 uint32_t eth_link_speed;
 
+/*
+ * ID of the current process in multi-process, used to
+ * configure the queues to be polled.
+ */
+int proc_id;
+
+/*
+ * Number of processes in multi-process, used to
+ * configure the queues to be polled.
+ */
+unsigned int num_procs = 1;
+
+static void
+eth_rx_metadata_negotiate_mp(uint16_t port_id)
+{
+       uint64_t rx_meta_features = 0;
+       int ret;
+
+       if (!is_proc_primary())
+               return;
+
+       rx_meta_features |= RTE_ETH_RX_METADATA_USER_FLAG;
+       rx_meta_features |= RTE_ETH_RX_METADATA_USER_MARK;
+       rx_meta_features |= RTE_ETH_RX_METADATA_TUNNEL_ID;
+
+       ret = rte_eth_rx_metadata_negotiate(port_id, &rx_meta_features);
+       if (ret == 0) {
+               if (!(rx_meta_features & RTE_ETH_RX_METADATA_USER_FLAG)) {
+                       TESTPMD_LOG(DEBUG, "Flow action FLAG will not affect Rx mbufs on port %u\n",
+                                   port_id);
+               }
+
+               if (!(rx_meta_features & RTE_ETH_RX_METADATA_USER_MARK)) {
+                       TESTPMD_LOG(DEBUG, "Flow action MARK will not affect Rx mbufs on port %u\n",
+                                   port_id);
+               }
+
+               if (!(rx_meta_features & RTE_ETH_RX_METADATA_TUNNEL_ID)) {
+                       TESTPMD_LOG(DEBUG, "Flow tunnel offload support might be limited or unavailable on port %u\n",
+                                   port_id);
+               }
+       } else if (ret != -ENOTSUP) {
+               rte_exit(EXIT_FAILURE, "Error when negotiating Rx meta features on port %u: %s\n",
+                        port_id, rte_strerror(-ret));
+       }
+}
+
+static void
+flow_pick_transfer_proxy_mp(uint16_t port_id)
+{
+       struct rte_port *port = &ports[port_id];
+       int ret;
+
+       port->flow_transfer_proxy = port_id;
+
+       if (!is_proc_primary())
+               return;
+
+       ret = rte_flow_pick_transfer_proxy(port_id, &port->flow_transfer_proxy,
+                                          NULL);
+       if (ret != 0) {
+               fprintf(stderr, "Error picking flow transfer proxy for port %u: %s - ignore\n",
+                       port_id, rte_strerror(-ret));
+       }
+}
+
+static int
+eth_dev_configure_mp(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
+                     const struct rte_eth_conf *dev_conf)
+{
+       if (is_proc_primary())
+               return rte_eth_dev_configure(port_id, nb_rx_q, nb_tx_q,
+                                       dev_conf);
+       return 0;
+}
+
+static int
+eth_dev_start_mp(uint16_t port_id)
+{
+       if (is_proc_primary())
+               return rte_eth_dev_start(port_id);
+
+       return 0;
+}
+
+static int
+eth_dev_stop_mp(uint16_t port_id)
+{
+       if (is_proc_primary())
+               return rte_eth_dev_stop(port_id);
+
+       return 0;
+}
+
+static void
+mempool_free_mp(struct rte_mempool *mp)
+{
+       if (is_proc_primary())
+               rte_mempool_free(mp);
+}
+
+static int
+eth_dev_set_mtu_mp(uint16_t port_id, uint16_t mtu)
+{
+       if (is_proc_primary())
+               return rte_eth_dev_set_mtu(port_id, mtu);
+
+       return 0;
+}
+
 /* Forward function declarations */
 static void setup_attached_port(portid_t pi);
 static void check_all_ports_link_status(uint32_t port_mask);
@@ -530,6 +650,7 @@ static int eth_event_callback(portid_t port_id,
 static void dev_event_callback(const char *device_name,
                                enum rte_dev_event_type type,
                                void *param);
+static void fill_xstats_display_info(void);
 
 /*
  * Check if all the ports are started.
@@ -543,6 +664,7 @@ uint16_t gso_max_segment_size = RTE_ETHER_MAX_LEN - RTE_ETHER_CRC_LEN;
 /* Holds the registered mbuf dynamic flags names. */
 char dynf_names[64][RTE_MBUF_DYN_NAMESIZE];
 
+
 /*
  * Helper function to check if socket is already discovered.
  * If yes, return positive value. If not, return zero.
@@ -996,6 +1118,14 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
        mb_size = sizeof(struct rte_mbuf) + mbuf_seg_size;
 #endif
        mbuf_poolname_build(socket_id, pool_name, sizeof(pool_name), size_idx);
+       if (!is_proc_primary()) {
+               rte_mp = rte_mempool_lookup(pool_name);
+               if (rte_mp == NULL)
+                       rte_exit(EXIT_FAILURE,
+                               "Get mbuf pool for socket %u failed: %s\n",
+                               socket_id, rte_strerror(rte_errno));
+               return rte_mp;
+       }
 
        TESTPMD_LOG(INFO,
                "create a new mbuf pool <%s>: n=%u, size=%u, socket=%u\n",
@@ -1417,14 +1547,30 @@ check_nb_hairpinq(queueid_t hairpinq)
        return 0;
 }
 
+static int
+get_eth_overhead(struct rte_eth_dev_info *dev_info)
+{
+       uint32_t eth_overhead;
+
+       if (dev_info->max_mtu != UINT16_MAX &&
+           dev_info->max_rx_pktlen > dev_info->max_mtu)
+               eth_overhead = dev_info->max_rx_pktlen - dev_info->max_mtu;
+       else
+               eth_overhead = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
+
+       return eth_overhead;
+}
+
 static void
 init_config_port_offloads(portid_t pid, uint32_t socket_id)
 {
        struct rte_port *port = &ports[pid];
-       uint16_t data_size;
        int ret;
        int i;
 
+       eth_rx_metadata_negotiate_mp(pid);
+       flow_pick_transfer_proxy_mp(pid);
+
        port->dev_conf.txmode = tx_mode;
        port->dev_conf.rxmode = rx_mode;
 
@@ -1432,12 +1578,6 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
        if (ret != 0)
                rte_exit(EXIT_FAILURE, "rte_eth_dev_info_get() failed\n");
 
-       ret = update_jumbo_frame_offload(pid);
-       if (ret != 0)
-               fprintf(stderr,
-                       "Updating jumbo frame offload failed for port %u\n",
-                       pid);
-
        if (!(port->dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE))
                port->dev_conf.txmode.offloads &=
                        ~DEV_TX_OFFLOAD_MBUF_FAST_FREE;
@@ -1452,6 +1592,10 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
        if (eth_link_speed)
                port->dev_conf.link_speeds = eth_link_speed;
 
+       if (max_rx_pkt_len)
+               port->dev_conf.rxmode.mtu = max_rx_pkt_len -
+                       get_eth_overhead(&port->dev_info);
+
        /* set flag to initialize port/queue */
        port->need_reconfig = 1;
        port->need_reconfig_queues = 1;
@@ -1464,14 +1608,20 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
         */
        if (port->dev_info.rx_desc_lim.nb_mtu_seg_max != UINT16_MAX &&
            port->dev_info.rx_desc_lim.nb_mtu_seg_max != 0) {
-               data_size = rx_mode.max_rx_pkt_len /
-                       port->dev_info.rx_desc_lim.nb_mtu_seg_max;
-
-               if ((data_size + RTE_PKTMBUF_HEADROOM) > mbuf_data_size[0]) {
-                       mbuf_data_size[0] = data_size + RTE_PKTMBUF_HEADROOM;
-                       TESTPMD_LOG(WARNING,
-                                   "Configured mbuf size of the first segment %hu\n",
-                                   mbuf_data_size[0]);
+               uint32_t eth_overhead = get_eth_overhead(&port->dev_info);
+               uint16_t mtu;
+
+               if (rte_eth_dev_get_mtu(pid, &mtu) == 0) {
+                       uint16_t data_size = (mtu + eth_overhead) /
+                               port->dev_info.rx_desc_lim.nb_mtu_seg_max;
+                       uint16_t buffer_size = data_size + RTE_PKTMBUF_HEADROOM;
+
+                       if (buffer_size > mbuf_data_size[0]) {
+                               mbuf_data_size[0] = buffer_size;
+                               TESTPMD_LOG(WARNING,
+                                       "Configured mbuf size of the first segment %hu\n",
+                                       mbuf_data_size[0]);
+                       }
                }
        }
 }
@@ -1995,6 +2145,11 @@ flush_fwd_rx_queues(void)
        uint64_t prev_tsc = 0, diff_tsc, cur_tsc, timer_tsc = 0;
        uint64_t timer_period;
 
+       if (num_procs > 1) {
+               printf("multi-process not support for flushing fwd Rx queues, skip the below lines and return.\n");
+               return;
+       }
+
        /* convert to number of cycles */
        timer_period = rte_get_timer_hz(); /* 1 second timeout */
 
@@ -2103,16 +2258,10 @@ run_one_txonly_burst_on_core(void *fwd_arg)
 static void
 launch_packet_forwarding(lcore_function_t *pkt_fwd_on_lcore)
 {
-       port_fwd_begin_t port_fwd_begin;
        unsigned int i;
        unsigned int lc_id;
        int diag;
 
-       port_fwd_begin = cur_fwd_config.fwd_eng->port_fwd_begin;
-       if (port_fwd_begin != NULL) {
-               for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
-                       (*port_fwd_begin)(fwd_ports_ids[i]);
-       }
        for (i = 0; i < cur_fwd_config.nb_fwd_lcores; i++) {
                lc_id = fwd_lcores_cpuids[i];
                if ((interactive == 0) || (lc_id != rte_lcore_id())) {
@@ -2158,23 +2307,46 @@ start_packet_forwarding(int with_tx_first)
                fprintf(stderr, "Packet forwarding already started\n");
                return;
        }
-       test_done = 0;
 
        fwd_config_setup();
 
+       pkt_fwd_config_display(&cur_fwd_config);
+       if (!pkt_fwd_shared_rxq_check())
+               return;
+
+       port_fwd_begin = cur_fwd_config.fwd_eng->port_fwd_begin;
+       if (port_fwd_begin != NULL) {
+               for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
+                       if (port_fwd_begin(fwd_ports_ids[i])) {
+                               fprintf(stderr,
+                                       "Packet forwarding is not ready\n");
+                               return;
+                       }
+               }
+       }
+
+       if (with_tx_first) {
+               port_fwd_begin = tx_only_engine.port_fwd_begin;
+               if (port_fwd_begin != NULL) {
+                       for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
+                               if (port_fwd_begin(fwd_ports_ids[i])) {
+                                       fprintf(stderr,
+                                               "Packet forwarding is not ready\n");
+                                       return;
+                               }
+                       }
+               }
+       }
+
+       test_done = 0;
+
        if(!no_flush_rx)
                flush_fwd_rx_queues();
 
-       pkt_fwd_config_display(&cur_fwd_config);
        rxtx_config_display();
 
        fwd_stats_reset();
        if (with_tx_first) {
-               port_fwd_begin = tx_only_engine.port_fwd_begin;
-               if (port_fwd_begin != NULL) {
-                       for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
-                               (*port_fwd_begin)(fwd_ports_ids[i]);
-               }
                while (with_tx_first--) {
                        launch_packet_forwarding(
                                        run_one_txonly_burst_on_core);
@@ -2431,6 +2603,108 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
        return ret;
 }
 
+static int
+alloc_xstats_display_info(portid_t pi)
+{
+       uint64_t **ids_supp = &ports[pi].xstats_info.ids_supp;
+       uint64_t **prev_values = &ports[pi].xstats_info.prev_values;
+       uint64_t **curr_values = &ports[pi].xstats_info.curr_values;
+
+       if (xstats_display_num == 0)
+               return 0;
+
+       *ids_supp = calloc(xstats_display_num, sizeof(**ids_supp));
+       if (*ids_supp == NULL)
+               goto fail_ids_supp;
+
+       *prev_values = calloc(xstats_display_num,
+                             sizeof(**prev_values));
+       if (*prev_values == NULL)
+               goto fail_prev_values;
+
+       *curr_values = calloc(xstats_display_num,
+                             sizeof(**curr_values));
+       if (*curr_values == NULL)
+               goto fail_curr_values;
+
+       ports[pi].xstats_info.allocated = true;
+
+       return 0;
+
+fail_curr_values:
+       free(*prev_values);
+fail_prev_values:
+       free(*ids_supp);
+fail_ids_supp:
+       return -ENOMEM;
+}
+
+static void
+free_xstats_display_info(portid_t pi)
+{
+       if (!ports[pi].xstats_info.allocated)
+               return;
+       free(ports[pi].xstats_info.ids_supp);
+       free(ports[pi].xstats_info.prev_values);
+       free(ports[pi].xstats_info.curr_values);
+       ports[pi].xstats_info.allocated = false;
+}
+
+/** Fill helper structures for specified port to show extended statistics. */
+static void
+fill_xstats_display_info_for_port(portid_t pi)
+{
+       unsigned int stat, stat_supp;
+       const char *xstat_name;
+       struct rte_port *port;
+       uint64_t *ids_supp;
+       int rc;
+
+       if (xstats_display_num == 0)
+               return;
+
+       if (pi == (portid_t)RTE_PORT_ALL) {
+               fill_xstats_display_info();
+               return;
+       }
+
+       port = &ports[pi];
+       if (port->port_status != RTE_PORT_STARTED)
+               return;
+
+       if (!port->xstats_info.allocated && alloc_xstats_display_info(pi) != 0)
+               rte_exit(EXIT_FAILURE,
+                        "Failed to allocate xstats display memory\n");
+
+       ids_supp = port->xstats_info.ids_supp;
+       for (stat = stat_supp = 0; stat < xstats_display_num; stat++) {
+               xstat_name = xstats_display[stat].name;
+               rc = rte_eth_xstats_get_id_by_name(pi, xstat_name,
+                                                  ids_supp + stat_supp);
+               if (rc != 0) {
+                       fprintf(stderr, "No xstat '%s' on port %u - skip it %u\n",
+                               xstat_name, pi, stat);
+                       continue;
+               }
+               stat_supp++;
+       }
+
+       port->xstats_info.ids_supp_sz = stat_supp;
+}
+
+/** Fill helper structures for all ports to show extended statistics. */
+static void
+fill_xstats_display_info(void)
+{
+       portid_t pi;
+
+       if (xstats_display_num == 0)
+               return;
+
+       RTE_ETH_FOREACH_DEV(pi)
+               fill_xstats_display_info_for_port(pi);
+}
+
 int
 start_port(portid_t pid)
 {
@@ -2462,6 +2736,9 @@ start_port(portid_t pid)
                }
 
                if (port->need_reconfig > 0) {
+                       struct rte_eth_conf dev_conf;
+                       int k;
+
                        port->need_reconfig = 0;
 
                        if (flow_isolate_all) {
@@ -2483,8 +2760,9 @@ start_port(portid_t pid)
                                        pi);
                                return -1;
                        }
+
                        /* configure port */
-                       diag = rte_eth_dev_configure(pi, nb_rxq + nb_hairpinq,
+                       diag = eth_dev_configure_mp(pi, nb_rxq + nb_hairpinq,
                                                     nb_txq + nb_hairpinq,
                                                     &(port->dev_conf));
                        if (diag != 0) {
@@ -2499,8 +2777,38 @@ start_port(portid_t pid)
                                port->need_reconfig = 1;
                                return -1;
                        }
+                       /* get device configuration*/
+                       if (0 !=
+                               eth_dev_conf_get_print_err(pi, &dev_conf)) {
+                               fprintf(stderr,
+                                       "port %d can not get device configuration\n",
+                                       pi);
+                               return -1;
+                       }
+                       /* Apply Rx offloads configuration */
+                       if (dev_conf.rxmode.offloads !=
+                           port->dev_conf.rxmode.offloads) {
+                               port->dev_conf.rxmode.offloads |=
+                                       dev_conf.rxmode.offloads;
+                               for (k = 0;
+                                    k < port->dev_info.max_rx_queues;
+                                    k++)
+                                       port->rx_conf[k].offloads |=
+                                               dev_conf.rxmode.offloads;
+                       }
+                       /* Apply Tx offloads configuration */
+                       if (dev_conf.txmode.offloads !=
+                           port->dev_conf.txmode.offloads) {
+                               port->dev_conf.txmode.offloads |=
+                                       dev_conf.txmode.offloads;
+                               for (k = 0;
+                                    k < port->dev_info.max_tx_queues;
+                                    k++)
+                                       port->tx_conf[k].offloads |=
+                                               dev_conf.txmode.offloads;
+                       }
                }
-               if (port->need_reconfig_queues > 0) {
+               if (port->need_reconfig_queues > 0 && is_proc_primary()) {
                        port->need_reconfig_queues = 0;
                        /* setup tx queues */
                        for (qi = 0; qi < nb_txq; qi++) {
@@ -2603,7 +2911,7 @@ start_port(portid_t pid)
                cnt_pi++;
 
                /* start port */
-               diag = rte_eth_dev_start(pi);
+               diag = eth_dev_start_mp(pi);
                if (diag < 0) {
                        fprintf(stderr, "Fail to start port %d: %s\n",
                                pi, rte_strerror(-diag));
@@ -2623,13 +2931,8 @@ start_port(portid_t pid)
                                pi);
 
                if (eth_macaddr_get_print_err(pi, &port->eth_addr) == 0)
-                       printf("Port %d: %02X:%02X:%02X:%02X:%02X:%02X\n", pi,
-                               port->eth_addr.addr_bytes[0],
-                               port->eth_addr.addr_bytes[1],
-                               port->eth_addr.addr_bytes[2],
-                               port->eth_addr.addr_bytes[3],
-                               port->eth_addr.addr_bytes[4],
-                               port->eth_addr.addr_bytes[5]);
+                       printf("Port %d: " RTE_ETHER_ADDR_PRT_FMT "\n", pi,
+                                       RTE_ETHER_ADDR_BYTES(&port->eth_addr));
 
                /* at least one port started, need checking link status */
                need_check_link_status = 1;
@@ -2686,6 +2989,8 @@ start_port(portid_t pid)
                }
        }
 
+       fill_xstats_display_info_for_port(pid);
+
        printf("Done\n");
        return 0;
 }
@@ -2746,7 +3051,7 @@ stop_port(portid_t pid)
                if (port->flow_list)
                        port_flow_flush(pi);
 
-               if (rte_eth_dev_stop(pi) != 0)
+               if (eth_dev_stop_mp(pi) != 0)
                        RTE_LOG(ERR, EAL, "rte_eth_dev_stop failed for port %u\n",
                                pi);
 
@@ -2820,8 +3125,13 @@ close_port(portid_t pid)
                        continue;
                }
 
-               port_flow_flush(pi);
-               rte_eth_dev_close(pi);
+               if (is_proc_primary()) {
+                       port_flow_flush(pi);
+                       port_flex_item_flush(pi);
+                       rte_eth_dev_close(pi);
+               }
+
+               free_xstats_display_info(pi);
        }
 
        remove_invalid_ports();
@@ -3106,8 +3416,9 @@ pmd_test_exit(void)
        }
        for (i = 0 ; i < RTE_DIM(mempools) ; i++) {
                if (mempools[i])
-                       rte_mempool_free(mempools[i]);
+                       mempool_free_mp(mempools[i]);
        }
+       free(xstats_display);
 
        printf("\nBye...\n");
 }
@@ -3327,14 +3638,23 @@ dev_event_callback(const char *device_name, enum rte_dev_event_type type,
 }
 
 static void
-rxtx_port_config(struct rte_port *port)
+rxtx_port_config(portid_t pid)
 {
        uint16_t qid;
        uint64_t offloads;
+       struct rte_port *port = &ports[pid];
 
        for (qid = 0; qid < nb_rxq; qid++) {
                offloads = port->rx_conf[qid].offloads;
                port->rx_conf[qid] = port->dev_info.default_rxconf;
+
+               if (rxq_share > 0 &&
+                   (port->dev_info.dev_capa & RTE_ETH_DEV_CAPA_RXQ_SHARE)) {
+                       /* Non-zero share group to enable RxQ share. */
+                       port->rx_conf[qid].share_group = pid / rxq_share + 1;
+                       port->rx_conf[qid].share_qid = qid; /* Equal mapping. */
+               }
+
                if (offloads != 0)
                        port->rx_conf[qid].offloads = offloads;
 
@@ -3384,77 +3704,39 @@ rxtx_port_config(struct rte_port *port)
 }
 
 /*
- * Helper function to arrange max_rx_pktlen value and JUMBO_FRAME offload,
- * MTU is also aligned if JUMBO_FRAME offload is not set.
+ * Helper function to set MTU from frame size
  *
  * port->dev_info should be set before calling this function.
  *
  * return 0 on success, negative on error
  */
 int
-update_jumbo_frame_offload(portid_t portid)
+update_mtu_from_frame_size(portid_t portid, uint32_t max_rx_pktlen)
 {
        struct rte_port *port = &ports[portid];
        uint32_t eth_overhead;
-       uint64_t rx_offloads;
-       int ret;
-       bool on;
+       uint16_t mtu, new_mtu;
 
-       /* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */
-       if (port->dev_info.max_mtu != UINT16_MAX &&
-           port->dev_info.max_rx_pktlen > port->dev_info.max_mtu)
-               eth_overhead = port->dev_info.max_rx_pktlen -
-                               port->dev_info.max_mtu;
-       else
-               eth_overhead = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
-
-       rx_offloads = port->dev_conf.rxmode.offloads;
+       eth_overhead = get_eth_overhead(&port->dev_info);
 
-       /* Default config value is 0 to use PMD specific overhead */
-       if (port->dev_conf.rxmode.max_rx_pkt_len == 0)
-               port->dev_conf.rxmode.max_rx_pkt_len = RTE_ETHER_MTU + eth_overhead;
-
-       if (port->dev_conf.rxmode.max_rx_pkt_len <= RTE_ETHER_MTU + eth_overhead) {
-               rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
-               on = false;
-       } else {
-               if ((port->dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME) == 0) {
-                       fprintf(stderr,
-                               "Frame size (%u) is not supported by port %u\n",
-                               port->dev_conf.rxmode.max_rx_pkt_len,
-                               portid);
-                       return -1;
-               }
-               rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
-               on = true;
+       if (rte_eth_dev_get_mtu(portid, &mtu) != 0) {
+               printf("Failed to get MTU for port %u\n", portid);
+               return -1;
        }
 
-       if (rx_offloads != port->dev_conf.rxmode.offloads) {
-               uint16_t qid;
+       new_mtu = max_rx_pktlen - eth_overhead;
 
-               port->dev_conf.rxmode.offloads = rx_offloads;
+       if (mtu == new_mtu)
+               return 0;
 
-               /* Apply JUMBO_FRAME offload configuration to Rx queue(s) */
-               for (qid = 0; qid < port->dev_info.nb_rx_queues; qid++) {
-                       if (on)
-                               port->rx_conf[qid].offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
-                       else
-                               port->rx_conf[qid].offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
-               }
+       if (eth_dev_set_mtu_mp(portid, new_mtu) != 0) {
+               fprintf(stderr,
+                       "Failed to set MTU to %u for port %u\n",
+                       new_mtu, portid);
+               return -1;
        }
 
-       /* If JUMBO_FRAME is set MTU conversion done by ethdev layer,
-        * if unset do it here
-        */
-       if ((rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) == 0) {
-               ret = rte_eth_dev_set_mtu(portid,
-                               port->dev_conf.rxmode.max_rx_pkt_len - eth_overhead);
-               if (ret)
-                       fprintf(stderr,
-                               "Failed to set MTU to %u for port %u\n",
-                               port->dev_conf.rxmode.max_rx_pkt_len - eth_overhead,
-                               portid);
-       }
+       port->dev_conf.rxmode.mtu = new_mtu;
 
        return 0;
 }
@@ -3464,7 +3746,7 @@ init_port_config(void)
 {
        portid_t pid;
        struct rte_port *port;
-       int ret;
+       int ret, i;
 
        RTE_ETH_FOREACH_DEV(pid) {
                port = &ports[pid];
@@ -3484,15 +3766,24 @@ init_port_config(void)
                }
 
                if (port->dcb_flag == 0) {
-                       if( port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0)
+                       if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) {
                                port->dev_conf.rxmode.mq_mode =
                                        (enum rte_eth_rx_mq_mode)
                                                (rx_mq_mode & ETH_MQ_RX_RSS);
-                       else
+                       } else {
                                port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
+                               port->dev_conf.rxmode.offloads &=
+                                               ~DEV_RX_OFFLOAD_RSS_HASH;
+
+                               for (i = 0;
+                                    i < port->dev_info.nb_rx_queues;
+                                    i++)
+                                       port->rx_conf[i].offloads &=
+                                               ~DEV_RX_OFFLOAD_RSS_HASH;
+                       }
                }
 
-               rxtx_port_config(port);
+               rxtx_port_config(pid);
 
                ret = eth_macaddr_get_print_err(pid, &port->eth_addr);
                if (ret != 0)
@@ -3643,12 +3934,14 @@ init_port_dcb_config(portid_t pid,
        int retval;
        uint16_t i;
 
+       if (num_procs > 1) {
+               printf("The multi-process feature doesn't support dcb.\n");
+               return -ENOTSUP;
+       }
        rte_port = &ports[pid];
 
-       memset(&port_conf, 0, sizeof(struct rte_eth_conf));
-
-       port_conf.rxmode = rte_port->dev_conf.rxmode;
-       port_conf.txmode = rte_port->dev_conf.txmode;
+       /* retain the original device configuration. */
+       memcpy(&port_conf, &rte_port->dev_conf, sizeof(struct rte_eth_conf));
 
        /*set configuration of DCB in vt mode and DCB in non-vt mode*/
        retval = get_eth_dcb_conf(pid, &port_conf, dcb_mode, num_tcs, pfc_en);
@@ -3702,7 +3995,7 @@ init_port_dcb_config(portid_t pid,
 
        memcpy(&rte_port->dev_conf, &port_conf, sizeof(struct rte_eth_conf));
 
-       rxtx_port_config(rte_port);
+       rxtx_port_config(pid);
        /* VLAN filter */
        rte_port->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
        for (i = 0; i < RTE_DIM(vlan_tags); i++)
@@ -3734,6 +4027,8 @@ init_port(void)
                                "rte_zmalloc(%d struct rte_port) failed\n",
                                RTE_MAX_ETHPORTS);
        }
+       for (i = 0; i < RTE_MAX_ETHPORTS; i++)
+               ports[i].xstats_info.allocated = false;
        for (i = 0; i < RTE_MAX_ETHPORTS; i++)
                LIST_INIT(&ports[i].flow_tunnel_list);
        /* Initialize ports NUMA structures */
@@ -3812,10 +4107,6 @@ main(int argc, char** argv)
                rte_exit(EXIT_FAILURE, "Cannot init EAL: %s\n",
                         rte_strerror(rte_errno));
 
-       if (rte_eal_process_type() == RTE_PROC_SECONDARY)
-               rte_exit(EXIT_FAILURE,
-                        "Secondary process type not supported.\n");
-
        ret = register_eth_event_callback();
        if (ret != 0)
                rte_exit(EXIT_FAILURE, "Cannot register for ethdev events");
@@ -3951,7 +4242,6 @@ main(int argc, char** argv)
                rte_stats_bitrate_reg(bitrate_data);
        }
 #endif
-
 #ifdef RTE_LIB_CMDLINE
        if (strlen(cmdline_filename) != 0)
                cmdline_read_from_file(cmdline_filename);