cryptodev: allocate driver structure statically
[dpdk.git] / drivers / crypto / dpaa2_sec / dpaa2_sec_dpseci.c
index b8ac0f1..672cacf 100644 (file)
@@ -2,7 +2,7 @@
  *   BSD LICENSE
  *
  *   Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.
- *   Copyright (c) 2016 NXP. All rights reserved.
+ *   Copyright 2016 NXP.
  *
  *   Redistribution and use in source and binary forms, with or without
  *   modification, are permitted provided that the following conditions
@@ -634,7 +634,7 @@ dpaa2_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops,
                }
                loop = 0;
                while (loop < frames_to_send) {
-                       loop += qbman_swp_send_multiple(swp, &eqdesc,
+                       loop += qbman_swp_enqueue_multiple(swp, &eqdesc,
                                                        &fd_arr[loop],
                                                        frames_to_send - loop);
                }
@@ -669,7 +669,7 @@ sec_fd_to_mbuf(const struct qbman_fd *fd)
 
        if (unlikely(DPAA2_GET_FD_IVP(fd))) {
                /* TODO complete it. */
-               RTE_LOG(ERR, PMD, "error: Non inline buffer - WHAT to DO?");
+               RTE_LOG(ERR, PMD, "error: Non inline buffer - WHAT to DO?\n");
                return NULL;
        }
        op = (struct rte_crypto_op *)DPAA2_IOVA_TO_VADDR(
@@ -731,8 +731,8 @@ dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops,
        /*Issue a volatile dequeue command. */
        while (1) {
                if (qbman_swp_pull(swp, &pulldesc)) {
-                       RTE_LOG(WARNING, PMD, "SEC VDQ command is not issued."
-                               "QBMAN is busy\n");
+                       RTE_LOG(WARNING, PMD,
+                               "SEC VDQ command is not issued : QBMAN busy\n");
                        /* Portal was busy, try again */
                        continue;
                }
@@ -747,13 +747,13 @@ dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops,
                 * Also seems like the SWP is shared between the Ethernet Driver
                 * and the SEC driver.
                 */
-               while (!qbman_check_command_complete(swp, dq_storage))
+               while (!qbman_check_command_complete(dq_storage))
                        ;
 
                /* Loop until the dq_storage is updated with
                 * new token by QBMAN
                 */
-               while (!qbman_result_has_new_result(swp, dq_storage))
+               while (!qbman_check_new_result(dq_storage))
                        ;
                /* Check whether Last Pull command is Expired and
                 * setting Condition for Loop termination
@@ -816,7 +816,8 @@ dpaa2_sec_queue_pair_release(struct rte_cryptodev *dev, uint16_t queue_pair_id)
 static int
 dpaa2_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,
                __rte_unused const struct rte_cryptodev_qp_conf *qp_conf,
-               __rte_unused int socket_id)
+               __rte_unused int socket_id,
+               __rte_unused struct rte_mempool *session_pool)
 {
        struct dpaa2_sec_dev_private *priv = dev->data->dev_private;
        struct dpaa2_sec_qp *qp;
@@ -907,13 +908,6 @@ dpaa2_sec_session_get_size(struct rte_cryptodev *dev __rte_unused)
        return sizeof(dpaa2_sec_session);
 }
 
-static void
-dpaa2_sec_session_initialize(struct rte_mempool *mp __rte_unused,
-                            void *sess __rte_unused)
-{
-       PMD_INIT_FUNC_TRACE();
-}
-
 static int
 dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
                      struct rte_crypto_sym_xform *xform,
@@ -932,7 +926,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
                        sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -943,7 +937,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
        session->cipher_key.data = rte_zmalloc(NULL, xform->cipher.key.length,
                        RTE_CACHE_LINE_SIZE);
        if (session->cipher_key.data == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for cipher key");
+               RTE_LOG(ERR, PMD, "No Memory for cipher key\n");
                rte_free(priv);
                return -1;
        }
@@ -986,7 +980,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_CIPHER_SNOW3G_UEA2:
        case RTE_CRYPTO_CIPHER_ZUC_EEA3:
        case RTE_CRYPTO_CIPHER_NULL:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u\n",
                        xform->cipher.algo);
                goto error_out;
        default:
@@ -1048,7 +1042,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
                        sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -1058,7 +1052,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
        session->auth_key.data = rte_zmalloc(NULL, xform->auth.key.length,
                        RTE_CACHE_LINE_SIZE);
        if (session->auth_key.data == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for auth key");
+               RTE_LOG(ERR, PMD, "No Memory for auth key\n");
                rte_free(priv);
                return -1;
        }
@@ -1118,7 +1112,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_AUTH_AES_CMAC:
        case RTE_CRYPTO_AUTH_AES_CBC_MAC:
        case RTE_CRYPTO_AUTH_ZUC_EIA3:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u\n",
                        xform->auth.algo);
                goto error_out;
        default:
@@ -1180,7 +1174,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
                        sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -1190,7 +1184,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
        session->aead_key.data = rte_zmalloc(NULL, aead_xform->key.length,
                                               RTE_CACHE_LINE_SIZE);
        if (session->aead_key.data == NULL && aead_xform->key.length > 0) {
-               RTE_LOG(ERR, PMD, "No Memory for aead key");
+               RTE_LOG(ERR, PMD, "No Memory for aead key\n");
                rte_free(priv);
                return -1;
        }
@@ -1199,7 +1193,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
 
        session->digest_length = aead_xform->digest_length;
        session->aead_key.length = aead_xform->key.length;
-       ctxt->auth_only_len = aead_xform->add_auth_data_length;
+       ctxt->auth_only_len = aead_xform->aad_length;
 
        aeaddata.key = (uint64_t)session->aead_key.data;
        aeaddata.keylen = session->aead_key.length;
@@ -1213,7 +1207,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
                session->cipher_alg = RTE_CRYPTO_AEAD_AES_GCM;
                break;
        case RTE_CRYPTO_AEAD_AES_CCM:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported AEAD alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported AEAD alg %u\n",
                        aead_xform->algo);
                goto error_out;
        default:
@@ -1231,7 +1225,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
                               &priv->flc_desc[0].desc[1], 1);
 
        if (err < 0) {
-               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths");
+               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths\n");
                goto error_out;
        }
        if (priv->flc_desc[0].desc[1] & 1) {
@@ -1314,7 +1308,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
                        sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -1324,7 +1318,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        session->cipher_key.data = rte_zmalloc(NULL, cipher_xform->key.length,
                                               RTE_CACHE_LINE_SIZE);
        if (session->cipher_key.data == NULL && cipher_xform->key.length > 0) {
-               RTE_LOG(ERR, PMD, "No Memory for cipher key");
+               RTE_LOG(ERR, PMD, "No Memory for cipher key\n");
                rte_free(priv);
                return -1;
        }
@@ -1332,7 +1326,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        session->auth_key.data = rte_zmalloc(NULL, auth_xform->key.length,
                                             RTE_CACHE_LINE_SIZE);
        if (session->auth_key.data == NULL && auth_xform->key.length > 0) {
-               RTE_LOG(ERR, PMD, "No Memory for auth key");
+               RTE_LOG(ERR, PMD, "No Memory for auth key\n");
                rte_free(session->cipher_key.data);
                rte_free(priv);
                return -1;
@@ -1395,7 +1389,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_AUTH_AES_CMAC:
        case RTE_CRYPTO_AUTH_AES_CBC_MAC:
        case RTE_CRYPTO_AUTH_ZUC_EIA3:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u\n",
                        auth_xform->algo);
                goto error_out;
        default:
@@ -1429,7 +1423,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_CIPHER_3DES_ECB:
        case RTE_CRYPTO_CIPHER_AES_ECB:
        case RTE_CRYPTO_CIPHER_KASUMI_F8:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u\n",
                        cipher_xform->algo);
                goto error_out;
        default:
@@ -1448,7 +1442,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
                               &priv->flc_desc[0].desc[2], 2);
 
        if (err < 0) {
-               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths");
+               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths\n");
                goto error_out;
        }
        if (priv->flc_desc[0].desc[2] & 1) {
@@ -1475,7 +1469,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
                                              session->digest_length,
                                              session->dir);
        } else {
-               RTE_LOG(ERR, PMD, "Hash before cipher not supported");
+               RTE_LOG(ERR, PMD, "Hash before cipher not supported\n");
                goto error_out;
        }
 
@@ -1509,7 +1503,7 @@ dpaa2_sec_set_session_parameters(struct rte_cryptodev *dev,
        PMD_INIT_FUNC_TRACE();
 
        if (unlikely(sess == NULL)) {
-               RTE_LOG(ERR, PMD, "invalid session struct");
+               RTE_LOG(ERR, PMD, "invalid session struct\n");
                return -1;
        }
 
@@ -1545,8 +1539,8 @@ dpaa2_sec_set_session_parameters(struct rte_cryptodev *dev,
                dpaa2_sec_aead_init(dev, xform, session);
 
        } else {
-               RTE_LOG(ERR, PMD, "Invalid crypto type");
-               return -1;
+               RTE_LOG(ERR, PMD, "Invalid crypto type\n");
+               return -EINVAL;
        }
 
        return 0;
@@ -1559,20 +1553,22 @@ dpaa2_sec_session_configure(struct rte_cryptodev *dev,
                struct rte_mempool *mempool)
 {
        void *sess_private_data;
+       int ret;
 
        if (rte_mempool_get(mempool, &sess_private_data)) {
                CDEV_LOG_ERR(
                        "Couldn't get object from session mempool");
-               return -1;
+               return -ENOMEM;
        }
 
-       if (dpaa2_sec_set_session_parameters(dev, xform, sess_private_data) != 0) {
+       ret = dpaa2_sec_set_session_parameters(dev, xform, sess_private_data);
+       if (ret != 0) {
                PMD_DRV_LOG(ERR, "DPAA2 PMD: failed to configure "
                                "session parameters");
 
                /* Return session to mempool */
                rte_mempool_put(mempool, sess_private_data);
-               return -1;
+               return ret;
        }
 
        set_session_private_data(sess, dev->driver_id,
@@ -1711,7 +1707,7 @@ dpaa2_sec_dev_close(struct rte_cryptodev *dev)
 
        /*Free the allocated memory for ethernet private data and dpseci*/
        priv->hw = NULL;
-       free(dpseci);
+       rte_free(dpseci);
 
        return 0;
 }
@@ -1820,7 +1816,6 @@ static struct rte_cryptodev_ops crypto_ops = {
        .queue_pair_stop      = dpaa2_sec_queue_pair_stop,
        .queue_pair_count     = dpaa2_sec_queue_pair_count,
        .session_get_size     = dpaa2_sec_session_get_size,
-       .session_initialize   = dpaa2_sec_session_initialize,
        .session_configure    = dpaa2_sec_session_configure,
        .session_clear        = dpaa2_sec_session_clear,
 };
@@ -1917,11 +1912,9 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)
                        NULL, NULL, NULL, NULL,
                        SOCKET_ID_ANY, 0);
        if (!internals->fle_pool) {
-               RTE_LOG(ERR, PMD, "%s create failed", str);
+               RTE_LOG(ERR, PMD, "%s create failed\n", str);
                goto init_error;
-       } else
-               RTE_LOG(INFO, PMD, "%s created: %p\n", str,
-                               internals->fle_pool);
+       }
 
        PMD_INIT_LOG(DEBUG, "driver %s: created\n", cryptodev->data->name);
        return 0;
@@ -2007,7 +2000,7 @@ cryptodev_dpaa2_sec_remove(struct rte_dpaa2_device *dpaa2_dev)
 }
 
 static struct rte_dpaa2_driver rte_dpaa2_sec_driver = {
-       .drv_type = DPAA2_MC_DPSECI_DEVID,
+       .drv_type = DPAA2_CRYPTO,
        .driver = {
                .name = "DPAA2 SEC PMD"
        },
@@ -2015,5 +2008,8 @@ static struct rte_dpaa2_driver rte_dpaa2_sec_driver = {
        .remove = cryptodev_dpaa2_sec_remove,
 };
 
+static struct cryptodev_driver dpaa2_sec_crypto_drv;
+
 RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD, rte_dpaa2_sec_driver);
-RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver, cryptodev_driver_id);
+RTE_PMD_REGISTER_CRYPTO_DRIVER(dpaa2_sec_crypto_drv, rte_dpaa2_sec_driver,
+               cryptodev_driver_id);