drivers: add newline in dpaa2 logs
[dpdk.git] / drivers / crypto / dpaa2_sec / dpaa2_sec_dpseci.c
index a708122..d6c3088 100644 (file)
@@ -2,7 +2,7 @@
  *   BSD LICENSE
  *
  *   Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.
- *   Copyright (c) 2016 NXP. All rights reserved.
+ *   Copyright 2016 NXP.
  *
  *   Redistribution and use in source and binary forms, with or without
  *   modification, are permitted provided that the following conditions
@@ -76,6 +76,8 @@
 
 enum rta_sec_era rta_sec_era = RTA_SEC_ERA_8;
 
+static uint8_t cryptodev_driver_id;
+
 static inline int
 build_authenc_gcm_fd(dpaa2_sec_session *sess,
                     struct rte_crypto_op *op,
@@ -617,7 +619,9 @@ dpaa2_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops,
                        /*Clear the unused FD fields before sending*/
                        memset(&fd_arr[loop], 0, sizeof(struct qbman_fd));
                        sess = (dpaa2_sec_session *)
-                               (*ops)->sym->session->_private;
+                                       get_session_private_data(
+                                       (*ops)->sym->session,
+                                       cryptodev_driver_id);
                        mb_pool = (*ops)->sym->m_src->pool;
                        bpid = mempool_to_bpid(mb_pool);
                        ret = build_sec_fd(sess, *ops, &fd_arr[loop], bpid);
@@ -665,7 +669,7 @@ sec_fd_to_mbuf(const struct qbman_fd *fd)
 
        if (unlikely(DPAA2_GET_FD_IVP(fd))) {
                /* TODO complete it. */
-               RTE_LOG(ERR, PMD, "error: Non inline buffer - WHAT to DO?");
+               RTE_LOG(ERR, PMD, "error: Non inline buffer - WHAT to DO?\n");
                return NULL;
        }
        op = (struct rte_crypto_op *)DPAA2_IOVA_TO_VADDR(
@@ -727,8 +731,8 @@ dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops,
        /*Issue a volatile dequeue command. */
        while (1) {
                if (qbman_swp_pull(swp, &pulldesc)) {
-                       RTE_LOG(WARNING, PMD, "SEC VDQ command is not issued."
-                               "QBMAN is busy\n");
+                       RTE_LOG(WARNING, PMD,
+                               "SEC VDQ command is not issued : QBMAN busy\n");
                        /* Portal was busy, try again */
                        continue;
                }
@@ -812,7 +816,8 @@ dpaa2_sec_queue_pair_release(struct rte_cryptodev *dev, uint16_t queue_pair_id)
 static int
 dpaa2_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,
                __rte_unused const struct rte_cryptodev_qp_conf *qp_conf,
-               __rte_unused int socket_id)
+               __rte_unused int socket_id,
+               __rte_unused struct rte_mempool *session_pool)
 {
        struct dpaa2_sec_dev_private *priv = dev->data->dev_private;
        struct dpaa2_sec_qp *qp;
@@ -903,13 +908,6 @@ dpaa2_sec_session_get_size(struct rte_cryptodev *dev __rte_unused)
        return sizeof(dpaa2_sec_session);
 }
 
-static void
-dpaa2_sec_session_initialize(struct rte_mempool *mp __rte_unused,
-                            void *sess __rte_unused)
-{
-       PMD_INIT_FUNC_TRACE();
-}
-
 static int
 dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
                      struct rte_crypto_sym_xform *xform,
@@ -928,7 +926,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
                        sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -939,7 +937,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
        session->cipher_key.data = rte_zmalloc(NULL, xform->cipher.key.length,
                        RTE_CACHE_LINE_SIZE);
        if (session->cipher_key.data == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for cipher key");
+               RTE_LOG(ERR, PMD, "No Memory for cipher key\n");
                rte_free(priv);
                return -1;
        }
@@ -982,7 +980,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_CIPHER_SNOW3G_UEA2:
        case RTE_CRYPTO_CIPHER_ZUC_EEA3:
        case RTE_CRYPTO_CIPHER_NULL:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u\n",
                        xform->cipher.algo);
                goto error_out;
        default:
@@ -1044,7 +1042,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
                        sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -1054,7 +1052,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
        session->auth_key.data = rte_zmalloc(NULL, xform->auth.key.length,
                        RTE_CACHE_LINE_SIZE);
        if (session->auth_key.data == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for auth key");
+               RTE_LOG(ERR, PMD, "No Memory for auth key\n");
                rte_free(priv);
                return -1;
        }
@@ -1114,7 +1112,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_AUTH_AES_CMAC:
        case RTE_CRYPTO_AUTH_AES_CBC_MAC:
        case RTE_CRYPTO_AUTH_ZUC_EIA3:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u\n",
                        xform->auth.algo);
                goto error_out;
        default:
@@ -1176,7 +1174,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
                        sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -1186,7 +1184,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
        session->aead_key.data = rte_zmalloc(NULL, aead_xform->key.length,
                                               RTE_CACHE_LINE_SIZE);
        if (session->aead_key.data == NULL && aead_xform->key.length > 0) {
-               RTE_LOG(ERR, PMD, "No Memory for aead key");
+               RTE_LOG(ERR, PMD, "No Memory for aead key\n");
                rte_free(priv);
                return -1;
        }
@@ -1209,7 +1207,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
                session->cipher_alg = RTE_CRYPTO_AEAD_AES_GCM;
                break;
        case RTE_CRYPTO_AEAD_AES_CCM:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported AEAD alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported AEAD alg %u\n",
                        aead_xform->algo);
                goto error_out;
        default:
@@ -1227,7 +1225,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev,
                               &priv->flc_desc[0].desc[1], 1);
 
        if (err < 0) {
-               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths");
+               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths\n");
                goto error_out;
        }
        if (priv->flc_desc[0].desc[1] & 1) {
@@ -1310,7 +1308,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
                        sizeof(struct ctxt_priv) + sizeof(struct sec_flc_desc),
                        RTE_CACHE_LINE_SIZE);
        if (priv == NULL) {
-               RTE_LOG(ERR, PMD, "No Memory for priv CTXT");
+               RTE_LOG(ERR, PMD, "No Memory for priv CTXT\n");
                return -1;
        }
 
@@ -1320,7 +1318,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        session->cipher_key.data = rte_zmalloc(NULL, cipher_xform->key.length,
                                               RTE_CACHE_LINE_SIZE);
        if (session->cipher_key.data == NULL && cipher_xform->key.length > 0) {
-               RTE_LOG(ERR, PMD, "No Memory for cipher key");
+               RTE_LOG(ERR, PMD, "No Memory for cipher key\n");
                rte_free(priv);
                return -1;
        }
@@ -1328,7 +1326,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        session->auth_key.data = rte_zmalloc(NULL, auth_xform->key.length,
                                             RTE_CACHE_LINE_SIZE);
        if (session->auth_key.data == NULL && auth_xform->key.length > 0) {
-               RTE_LOG(ERR, PMD, "No Memory for auth key");
+               RTE_LOG(ERR, PMD, "No Memory for auth key\n");
                rte_free(session->cipher_key.data);
                rte_free(priv);
                return -1;
@@ -1391,7 +1389,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_AUTH_AES_CMAC:
        case RTE_CRYPTO_AUTH_AES_CBC_MAC:
        case RTE_CRYPTO_AUTH_ZUC_EIA3:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported auth alg %u\n",
                        auth_xform->algo);
                goto error_out;
        default:
@@ -1425,7 +1423,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
        case RTE_CRYPTO_CIPHER_3DES_ECB:
        case RTE_CRYPTO_CIPHER_AES_ECB:
        case RTE_CRYPTO_CIPHER_KASUMI_F8:
-               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u",
+               RTE_LOG(ERR, PMD, "Crypto: Unsupported Cipher alg %u\n",
                        cipher_xform->algo);
                goto error_out;
        default:
@@ -1444,7 +1442,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
                               &priv->flc_desc[0].desc[2], 2);
 
        if (err < 0) {
-               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths");
+               PMD_DRV_LOG(ERR, "Crypto: Incorrect key lengths\n");
                goto error_out;
        }
        if (priv->flc_desc[0].desc[2] & 1) {
@@ -1471,7 +1469,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev,
                                              session->digest_length,
                                              session->dir);
        } else {
-               RTE_LOG(ERR, PMD, "Hash before cipher not supported");
+               RTE_LOG(ERR, PMD, "Hash before cipher not supported\n");
                goto error_out;
        }
 
@@ -1496,8 +1494,8 @@ error_out:
        return -1;
 }
 
-static void *
-dpaa2_sec_session_configure(struct rte_cryptodev *dev,
+static int
+dpaa2_sec_set_session_parameters(struct rte_cryptodev *dev,
                            struct rte_crypto_sym_xform *xform, void *sess)
 {
        dpaa2_sec_session *session = sess;
@@ -1505,8 +1503,8 @@ dpaa2_sec_session_configure(struct rte_cryptodev *dev,
        PMD_INIT_FUNC_TRACE();
 
        if (unlikely(sess == NULL)) {
-               RTE_LOG(ERR, PMD, "invalid session struct");
-               return NULL;
+               RTE_LOG(ERR, PMD, "invalid session struct\n");
+               return -1;
        }
 
        /* Default IV length = 0 */
@@ -1541,25 +1539,60 @@ dpaa2_sec_session_configure(struct rte_cryptodev *dev,
                dpaa2_sec_aead_init(dev, xform, session);
 
        } else {
-               RTE_LOG(ERR, PMD, "Invalid crypto type");
-               return NULL;
+               RTE_LOG(ERR, PMD, "Invalid crypto type\n");
+               return -1;
+       }
+
+       return 0;
+}
+
+static int
+dpaa2_sec_session_configure(struct rte_cryptodev *dev,
+               struct rte_crypto_sym_xform *xform,
+               struct rte_cryptodev_sym_session *sess,
+               struct rte_mempool *mempool)
+{
+       void *sess_private_data;
+
+       if (rte_mempool_get(mempool, &sess_private_data)) {
+               CDEV_LOG_ERR(
+                       "Couldn't get object from session mempool");
+               return -1;
        }
 
-       return session;
+       if (dpaa2_sec_set_session_parameters(dev, xform, sess_private_data) != 0) {
+               PMD_DRV_LOG(ERR, "DPAA2 PMD: failed to configure "
+                               "session parameters");
+
+               /* Return session to mempool */
+               rte_mempool_put(mempool, sess_private_data);
+               return -1;
+       }
+
+       set_session_private_data(sess, dev->driver_id,
+               sess_private_data);
+
+       return 0;
 }
 
 /** Clear the memory of session so it doesn't leave key material behind */
 static void
-dpaa2_sec_session_clear(struct rte_cryptodev *dev __rte_unused, void *sess)
+dpaa2_sec_session_clear(struct rte_cryptodev *dev,
+               struct rte_cryptodev_sym_session *sess)
 {
        PMD_INIT_FUNC_TRACE();
-       dpaa2_sec_session *s = (dpaa2_sec_session *)sess;
+       uint8_t index = dev->driver_id;
+       void *sess_priv = get_session_private_data(sess, index);
+       dpaa2_sec_session *s = (dpaa2_sec_session *)sess_priv;
 
-       if (s) {
+       if (sess_priv) {
                rte_free(s->ctxt);
                rte_free(s->cipher_key.data);
                rte_free(s->auth_key.data);
                memset(sess, 0, sizeof(dpaa2_sec_session));
+               struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv);
+               set_session_private_data(sess, index, NULL);
+               rte_mempool_put(sess_mp, sess_priv);
        }
 }
 
@@ -1689,7 +1722,7 @@ dpaa2_sec_dev_infos_get(struct rte_cryptodev *dev,
                info->feature_flags = dev->feature_flags;
                info->capabilities = dpaa2_sec_capabilities;
                info->sym.max_nb_sessions = internals->max_nb_sessions;
-               info->dev_type = RTE_CRYPTODEV_DPAA2_SEC_PMD;
+               info->driver_id = cryptodev_driver_id;
        }
 }
 
@@ -1781,7 +1814,6 @@ static struct rte_cryptodev_ops crypto_ops = {
        .queue_pair_stop      = dpaa2_sec_queue_pair_stop,
        .queue_pair_count     = dpaa2_sec_queue_pair_count,
        .session_get_size     = dpaa2_sec_session_get_size,
-       .session_initialize   = dpaa2_sec_session_initialize,
        .session_configure    = dpaa2_sec_session_configure,
        .session_clear        = dpaa2_sec_session_clear,
 };
@@ -1819,7 +1851,7 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)
        }
        hw_id = dpaa2_dev->object_id;
 
-       cryptodev->dev_type = RTE_CRYPTODEV_DPAA2_SEC_PMD;
+       cryptodev->driver_id = cryptodev_driver_id;
        cryptodev->dev_ops = &crypto_ops;
 
        cryptodev->enqueue_burst = dpaa2_sec_enqueue_burst;
@@ -1878,7 +1910,7 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)
                        NULL, NULL, NULL, NULL,
                        SOCKET_ID_ANY, 0);
        if (!internals->fle_pool) {
-               RTE_LOG(ERR, PMD, "%s create failed", str);
+               RTE_LOG(ERR, PMD, "%s create failed\n", str);
                goto init_error;
        } else
                RTE_LOG(INFO, PMD, "%s created: %p\n", str,
@@ -1977,3 +2009,4 @@ static struct rte_dpaa2_driver rte_dpaa2_sec_driver = {
 };
 
 RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD, rte_dpaa2_sec_driver);
+RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver, cryptodev_driver_id);