crypto/openssl: do not append digest
[dpdk.git] / drivers / crypto / openssl / rte_openssl_pmd.c
index 13a5129..280148e 100644 (file)
@@ -1,7 +1,7 @@
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2016 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2016-2017 Intel Corporation. All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
  *   modification, are permitted provided that the following conditions
 #include <rte_hexdump.h>
 #include <rte_cryptodev.h>
 #include <rte_cryptodev_pmd.h>
+#include <rte_cryptodev_vdev.h>
 #include <rte_vdev.h>
 #include <rte_malloc.h>
 #include <rte_cpuflags.h>
 
+#include <openssl/hmac.h>
 #include <openssl/evp.h>
 
 #include "rte_openssl_pmd_private.h"
 
 #define DES_BLOCK_SIZE 8
 
+static uint8_t cryptodev_driver_id;
+
+#if (OPENSSL_VERSION_NUMBER < 0x10100000L)
+static HMAC_CTX *HMAC_CTX_new(void)
+{
+       HMAC_CTX *ctx = OPENSSL_malloc(sizeof(*ctx));
+
+       if (ctx != NULL)
+               HMAC_CTX_init(ctx);
+       return ctx;
+}
+
+static void HMAC_CTX_free(HMAC_CTX *ctx)
+{
+       if (ctx != NULL) {
+               HMAC_CTX_cleanup(ctx);
+               OPENSSL_free(ctx);
+       }
+}
+#endif
+
 static int cryptodev_openssl_remove(struct rte_vdev_device *vdev);
 
 /*----------------------------------------------------------------------------*/
@@ -88,6 +111,8 @@ openssl_get_chain_order(const struct rte_crypto_sym_xform *xform)
                        else if (xform->next->type == RTE_CRYPTO_SYM_XFORM_AUTH)
                                res =  OPENSSL_CHAIN_CIPHER_AUTH;
                }
+               if (xform->type == RTE_CRYPTO_SYM_XFORM_AEAD)
+                       res = OPENSSL_CHAIN_COMBINED;
        }
 
        return res;
@@ -183,21 +208,6 @@ get_cipher_algo(enum rte_crypto_cipher_algorithm sess_algo, size_t keylen,
                                res = -EINVAL;
                        }
                        break;
-               case RTE_CRYPTO_CIPHER_AES_GCM:
-                       switch (keylen) {
-                       case 16:
-                               *algo = EVP_aes_128_gcm();
-                               break;
-                       case 24:
-                               *algo = EVP_aes_192_gcm();
-                               break;
-                       case 32:
-                               *algo = EVP_aes_256_gcm();
-                               break;
-                       default:
-                               res = -EINVAL;
-                       }
-                       break;
                default:
                        res = -EINVAL;
                        break;
@@ -253,6 +263,41 @@ get_auth_algo(enum rte_crypto_auth_algorithm sessalgo,
        return res;
 }
 
+/** Get adequate openssl function for input cipher algorithm */
+static uint8_t
+get_aead_algo(enum rte_crypto_aead_algorithm sess_algo, size_t keylen,
+               const EVP_CIPHER **algo)
+{
+       int res = 0;
+
+       if (algo != NULL) {
+               switch (sess_algo) {
+               case RTE_CRYPTO_AEAD_AES_GCM:
+                       switch (keylen) {
+                       case 16:
+                               *algo = EVP_aes_128_gcm();
+                               break;
+                       case 24:
+                               *algo = EVP_aes_192_gcm();
+                               break;
+                       case 32:
+                               *algo = EVP_aes_256_gcm();
+                               break;
+                       default:
+                               res = -EINVAL;
+                       }
+                       break;
+               default:
+                       res = -EINVAL;
+                       break;
+               }
+       } else {
+               res = -EINVAL;
+       }
+
+       return res;
+}
+
 /** Set session cipher parameters */
 static int
 openssl_set_session_cipher_parameters(struct openssl_session *sess,
@@ -263,12 +308,15 @@ openssl_set_session_cipher_parameters(struct openssl_session *sess,
        /* Select cipher key */
        sess->cipher.key.length = xform->cipher.key.length;
 
+       /* Set IV parameters */
+       sess->iv.offset = xform->cipher.iv.offset;
+       sess->iv.length = xform->cipher.iv.length;
+
        /* Select cipher algo */
        switch (xform->cipher.algo) {
        case RTE_CRYPTO_CIPHER_3DES_CBC:
        case RTE_CRYPTO_CIPHER_AES_CBC:
        case RTE_CRYPTO_CIPHER_AES_CTR:
-       case RTE_CRYPTO_CIPHER_AES_GCM:
                sess->cipher.mode = OPENSSL_CIPHER_LIB;
                sess->cipher.algo = xform->cipher.algo;
                sess->cipher.ctx = EVP_CIPHER_CTX_new();
@@ -279,6 +327,22 @@ openssl_set_session_cipher_parameters(struct openssl_session *sess,
 
                get_cipher_key(xform->cipher.key.data, sess->cipher.key.length,
                        sess->cipher.key.data);
+               if (sess->cipher.direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT) {
+                       if (EVP_EncryptInit_ex(sess->cipher.ctx,
+                                       sess->cipher.evp_algo,
+                                       NULL, xform->cipher.key.data,
+                                       NULL) != 1) {
+                               return -EINVAL;
+                       }
+               } else if (sess->cipher.direction ==
+                               RTE_CRYPTO_CIPHER_OP_DECRYPT) {
+                       if (EVP_DecryptInit_ex(sess->cipher.ctx,
+                                       sess->cipher.evp_algo,
+                                       NULL, xform->cipher.key.data,
+                                       NULL) != 1) {
+                               return -EINVAL;
+                       }
+               }
 
                break;
 
@@ -305,10 +369,27 @@ openssl_set_session_cipher_parameters(struct openssl_session *sess,
 
                get_cipher_key(xform->cipher.key.data, sess->cipher.key.length,
                        sess->cipher.key.data);
+               if (sess->cipher.direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT) {
+                       if (EVP_EncryptInit_ex(sess->cipher.ctx,
+                                       sess->cipher.evp_algo,
+                                       NULL, xform->cipher.key.data,
+                                       NULL) != 1) {
+                               return -EINVAL;
+                       }
+               } else if (sess->cipher.direction ==
+                               RTE_CRYPTO_CIPHER_OP_DECRYPT) {
+                       if (EVP_DecryptInit_ex(sess->cipher.ctx,
+                                       sess->cipher.evp_algo,
+                                       NULL, xform->cipher.key.data,
+                                       NULL) != 1) {
+                               return -EINVAL;
+                       }
+               }
+
                break;
        default:
                sess->cipher.algo = RTE_CRYPTO_CIPHER_NULL;
-               return -EINVAL;
+               return -ENOTSUP;
        }
 
        return 0;
@@ -326,11 +407,33 @@ openssl_set_session_auth_parameters(struct openssl_session *sess,
        /* Select auth algo */
        switch (xform->auth.algo) {
        case RTE_CRYPTO_AUTH_AES_GMAC:
-       case RTE_CRYPTO_AUTH_AES_GCM:
-               /* Check additional condition for AES_GMAC/GCM */
-               if (sess->cipher.algo != RTE_CRYPTO_CIPHER_AES_GCM)
-                       return -EINVAL;
                sess->chain_order = OPENSSL_CHAIN_COMBINED;
+
+               /* Set IV parameters */
+               sess->iv.offset = xform->auth.iv.offset;
+               sess->iv.length = xform->auth.iv.length;
+
+               /*
+                * OpenSSL requires GMAC to be a GCM operation
+                * with no cipher data length
+                */
+               sess->cipher.mode = OPENSSL_CIPHER_LIB;
+               if (sess->auth.operation == RTE_CRYPTO_AUTH_OP_GENERATE)
+                       sess->cipher.direction = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
+               else
+                       sess->cipher.direction = RTE_CRYPTO_CIPHER_OP_DECRYPT;
+
+               sess->cipher.key.length = xform->auth.key.length;
+               sess->cipher.ctx = EVP_CIPHER_CTX_new();
+
+               if (get_aead_algo(RTE_CRYPTO_AEAD_AES_GCM,
+                               sess->cipher.key.length,
+                               &sess->cipher.evp_algo) != 0)
+                       return -EINVAL;
+
+               get_cipher_key(xform->auth.key.data, xform->auth.key.length,
+                       sess->cipher.key.data);
+
                break;
 
        case RTE_CRYPTO_AUTH_MD5:
@@ -353,18 +456,68 @@ openssl_set_session_auth_parameters(struct openssl_session *sess,
        case RTE_CRYPTO_AUTH_SHA384_HMAC:
        case RTE_CRYPTO_AUTH_SHA512_HMAC:
                sess->auth.mode = OPENSSL_AUTH_AS_HMAC;
-               sess->auth.hmac.ctx = EVP_MD_CTX_create();
+               sess->auth.hmac.ctx = HMAC_CTX_new();
                if (get_auth_algo(xform->auth.algo,
                                &sess->auth.hmac.evp_algo) != 0)
                        return -EINVAL;
-               sess->auth.hmac.pkey = EVP_PKEY_new_mac_key(EVP_PKEY_HMAC, NULL,
-                               xform->auth.key.data, xform->auth.key.length);
+
+               if (HMAC_Init_ex(sess->auth.hmac.ctx,
+                               xform->auth.key.data,
+                               xform->auth.key.length,
+                               sess->auth.hmac.evp_algo, NULL) != 1)
+                       return -EINVAL;
                break;
 
        default:
-               return -EINVAL;
+               return -ENOTSUP;
        }
 
+       sess->auth.digest_length = xform->auth.digest_length;
+
+       return 0;
+}
+
+/* Set session AEAD parameters */
+static int
+openssl_set_session_aead_parameters(struct openssl_session *sess,
+               const struct rte_crypto_sym_xform *xform)
+{
+       /* Select cipher direction */
+       sess->cipher.direction = xform->cipher.op;
+       /* Select cipher key */
+       sess->cipher.key.length = xform->aead.key.length;
+
+       /* Set IV parameters */
+       sess->iv.offset = xform->aead.iv.offset;
+       sess->iv.length = xform->aead.iv.length;
+
+       /* Select auth generate/verify */
+       sess->auth.operation = xform->auth.op;
+       sess->auth.algo = xform->auth.algo;
+
+       /* Select auth algo */
+       switch (xform->aead.algo) {
+       case RTE_CRYPTO_AEAD_AES_GCM:
+               sess->cipher.mode = OPENSSL_CIPHER_LIB;
+               sess->aead_algo = xform->aead.algo;
+               sess->cipher.ctx = EVP_CIPHER_CTX_new();
+
+               if (get_aead_algo(sess->aead_algo, sess->cipher.key.length,
+                               &sess->cipher.evp_algo) != 0)
+                       return -EINVAL;
+
+               get_cipher_key(xform->cipher.key.data, sess->cipher.key.length,
+                       sess->cipher.key.data);
+
+               sess->chain_order = OPENSSL_CHAIN_COMBINED;
+               break;
+       default:
+               return -ENOTSUP;
+       }
+
+       sess->auth.aad_length = xform->aead.aad_length;
+       sess->auth.digest_length = xform->aead.digest_length;
+
        return 0;
 }
 
@@ -375,6 +528,8 @@ openssl_set_session_parameters(struct openssl_session *sess,
 {
        const struct rte_crypto_sym_xform *cipher_xform = NULL;
        const struct rte_crypto_sym_xform *auth_xform = NULL;
+       const struct rte_crypto_sym_xform *aead_xform = NULL;
+       int ret;
 
        sess->chain_order = openssl_get_chain_order(xform);
        switch (sess->chain_order) {
@@ -392,25 +547,42 @@ openssl_set_session_parameters(struct openssl_session *sess,
                auth_xform = xform;
                cipher_xform = xform->next;
                break;
+       case OPENSSL_CHAIN_COMBINED:
+               aead_xform = xform;
+               break;
        default:
                return -EINVAL;
        }
 
+       /* Default IV length = 0 */
+       sess->iv.length = 0;
+
        /* cipher_xform must be check before auth_xform */
        if (cipher_xform) {
-               if (openssl_set_session_cipher_parameters(
-                               sess, cipher_xform)) {
+               ret = openssl_set_session_cipher_parameters(
+                               sess, cipher_xform);
+               if (ret != 0) {
                        OPENSSL_LOG_ERR(
                                "Invalid/unsupported cipher parameters");
-                       return -EINVAL;
+                       return ret;
                }
        }
 
        if (auth_xform) {
-               if (openssl_set_session_auth_parameters(sess, auth_xform)) {
+               ret = openssl_set_session_auth_parameters(sess, auth_xform);
+               if (ret != 0) {
                        OPENSSL_LOG_ERR(
                                "Invalid/unsupported auth parameters");
-                       return -EINVAL;
+                       return ret;
+               }
+       }
+
+       if (aead_xform) {
+               ret = openssl_set_session_aead_parameters(sess, aead_xform);
+               if (ret != 0) {
+                       OPENSSL_LOG_ERR(
+                               "Invalid/unsupported AEAD parameters");
+                       return ret;
                }
        }
 
@@ -432,7 +604,7 @@ openssl_reset_session(struct openssl_session *sess)
                break;
        case OPENSSL_AUTH_AS_HMAC:
                EVP_PKEY_free(sess->auth.hmac.pkey);
-               EVP_MD_CTX_destroy(sess->auth.hmac.ctx);
+               HMAC_CTX_free(sess->auth.hmac.ctx);
                break;
        default:
                break;
@@ -445,29 +617,35 @@ get_session(struct openssl_qp *qp, struct rte_crypto_op *op)
 {
        struct openssl_session *sess = NULL;
 
-       if (op->sym->sess_type == RTE_CRYPTO_SYM_OP_WITH_SESSION) {
+       if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) {
                /* get existing session */
-               if (likely(op->sym->session != NULL &&
-                               op->sym->session->dev_type ==
-                               RTE_CRYPTODEV_OPENSSL_PMD))
+               if (likely(op->sym->session != NULL))
                        sess = (struct openssl_session *)
-                               op->sym->session->_private;
-       } else  {
+                                       get_session_private_data(
+                                       op->sym->session,
+                                       cryptodev_driver_id);
+       } else {
                /* provide internal session */
                void *_sess = NULL;
+               void *_sess_private_data = NULL;
 
-               if (!rte_mempool_get(qp->sess_mp, (void **)&_sess)) {
-                       sess = (struct openssl_session *)
-                               ((struct rte_cryptodev_sym_session *)_sess)
-                               ->_private;
-
-                       if (unlikely(openssl_set_session_parameters(
-                                       sess, op->sym->xform) != 0)) {
-                               rte_mempool_put(qp->sess_mp, _sess);
-                               sess = NULL;
-                       } else
-                               op->sym->session = _sess;
+               if (rte_mempool_get(qp->sess_mp, (void **)&_sess))
+                       return NULL;
+
+               if (rte_mempool_get(qp->sess_mp, (void **)&_sess_private_data))
+                       return NULL;
+
+               sess = (struct openssl_session *)_sess_private_data;
+
+               if (unlikely(openssl_set_session_parameters(sess,
+                               op->sym->xform) != 0)) {
+                       rte_mempool_put(qp->sess_mp, _sess);
+                       rte_mempool_put(qp->sess_mp, _sess_private_data);
+                       sess = NULL;
                }
+               op->sym->session = (struct rte_cryptodev_sym_session *)_sess;
+               set_session_private_data(op->sym->session, cryptodev_driver_id,
+                       _sess_private_data);
        }
 
        if (sess == NULL)
@@ -572,12 +750,11 @@ process_openssl_decryption_update(struct rte_mbuf *mbuf_src, int offset,
 /** Process standard openssl cipher encryption */
 static int
 process_openssl_cipher_encrypt(struct rte_mbuf *mbuf_src, uint8_t *dst,
-               int offset, uint8_t *iv, uint8_t *key, int srclen,
-               EVP_CIPHER_CTX *ctx, const EVP_CIPHER *algo)
+               int offset, uint8_t *iv, int srclen, EVP_CIPHER_CTX *ctx)
 {
        int totlen;
 
-       if (EVP_EncryptInit_ex(ctx, algo, NULL, key, iv) <= 0)
+       if (EVP_EncryptInit_ex(ctx, NULL, NULL, NULL, iv) <= 0)
                goto process_cipher_encrypt_err;
 
        EVP_CIPHER_CTX_set_padding(ctx, 0);
@@ -622,12 +799,11 @@ process_cipher_encrypt_err:
 /** Process standard openssl cipher decryption */
 static int
 process_openssl_cipher_decrypt(struct rte_mbuf *mbuf_src, uint8_t *dst,
-               int offset, uint8_t *iv, uint8_t *key, int srclen,
-               EVP_CIPHER_CTX *ctx, const EVP_CIPHER *algo)
+               int offset, uint8_t *iv, int srclen, EVP_CIPHER_CTX *ctx)
 {
        int totlen;
 
-       if (EVP_DecryptInit_ex(ctx, algo, NULL, key, iv) <= 0)
+       if (EVP_DecryptInit_ex(ctx, NULL, NULL, NULL, iv) <= 0)
                goto process_cipher_decrypt_err;
 
        EVP_CIPHER_CTX_set_padding(ctx, 0);
@@ -850,10 +1026,9 @@ process_auth_err:
 /** Process standard openssl auth algorithms with hmac */
 static int
 process_openssl_auth_hmac(struct rte_mbuf *mbuf_src, uint8_t *dst, int offset,
-               __rte_unused uint8_t *iv, EVP_PKEY *pkey,
-               int srclen, EVP_MD_CTX *ctx, const EVP_MD *algo)
+               int srclen, HMAC_CTX *ctx)
 {
-       size_t dstlen;
+       unsigned int dstlen;
        struct rte_mbuf *m;
        int l, n = srclen;
        uint8_t *src;
@@ -865,19 +1040,16 @@ process_openssl_auth_hmac(struct rte_mbuf *mbuf_src, uint8_t *dst, int offset,
        if (m == 0)
                goto process_auth_err;
 
-       if (EVP_DigestSignInit(ctx, NULL, algo, NULL, pkey) <= 0)
-               goto process_auth_err;
-
        src = rte_pktmbuf_mtod_offset(m, uint8_t *, offset);
 
        l = rte_pktmbuf_data_len(m) - offset;
        if (srclen <= l) {
-               if (EVP_DigestSignUpdate(ctx, (char *)src, srclen) <= 0)
+               if (HMAC_Update(ctx, (unsigned char *)src, srclen) != 1)
                        goto process_auth_err;
                goto process_auth_final;
        }
 
-       if (EVP_DigestSignUpdate(ctx, (char *)src, l) <= 0)
+       if (HMAC_Update(ctx, (unsigned char *)src, l) != 1)
                goto process_auth_err;
 
        n -= l;
@@ -885,13 +1057,16 @@ process_openssl_auth_hmac(struct rte_mbuf *mbuf_src, uint8_t *dst, int offset,
        for (m = m->next; (m != NULL) && (n > 0); m = m->next) {
                src = rte_pktmbuf_mtod(m, uint8_t *);
                l = rte_pktmbuf_data_len(m) < n ? rte_pktmbuf_data_len(m) : n;
-               if (EVP_DigestSignUpdate(ctx, (char *)src, l) <= 0)
+               if (HMAC_Update(ctx, (unsigned char *)src, l) != 1)
                        goto process_auth_err;
                n -= l;
        }
 
 process_auth_final:
-       if (EVP_DigestSignFinal(ctx, dst, &dstlen) <= 0)
+       if (HMAC_Final(ctx, dst, &dstlen) != 1)
+               goto process_auth_err;
+
+       if (unlikely(HMAC_Init_ex(ctx, NULL, 0, NULL, NULL) != 1))
                goto process_auth_err;
 
        return 0;
@@ -912,6 +1087,7 @@ process_openssl_combined_op
        /* cipher */
        uint8_t *dst = NULL, *iv, *tag, *aad;
        int srclen, ivlen, aadlen, status = -1;
+       uint32_t offset;
 
        /*
         * Segmented destination buffer is not supported for
@@ -922,34 +1098,41 @@ process_openssl_combined_op
                return;
        }
 
-       iv = op->sym->cipher.iv.data;
-       ivlen = op->sym->cipher.iv.length;
-       aad = op->sym->auth.aad.data;
-       aadlen = op->sym->auth.aad.length;
-
-       tag = op->sym->auth.digest.data;
-       if (tag == NULL)
-               tag = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
-                               op->sym->cipher.data.offset +
-                               op->sym->cipher.data.length);
-
-       if (sess->auth.algo == RTE_CRYPTO_AUTH_AES_GMAC)
+       iv = rte_crypto_op_ctod_offset(op, uint8_t *,
+                       sess->iv.offset);
+       ivlen = sess->iv.length;
+       if (sess->auth.algo == RTE_CRYPTO_AUTH_AES_GMAC) {
                srclen = 0;
-       else {
-               srclen = op->sym->cipher.data.length;
+               offset = op->sym->auth.data.offset;
+               aadlen = op->sym->auth.data.length;
+               aad = rte_pktmbuf_mtod_offset(mbuf_src, uint8_t *,
+                               op->sym->auth.data.offset);
+               tag = op->sym->auth.digest.data;
+               if (tag == NULL)
+                       tag = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
+                               offset + aadlen);
+       } else {
+               srclen = op->sym->aead.data.length;
                dst = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
-                               op->sym->cipher.data.offset);
+                               op->sym->aead.data.offset);
+               offset = op->sym->aead.data.offset;
+               aad = op->sym->aead.aad.data;
+               aadlen = sess->auth.aad_length;
+               tag = op->sym->aead.digest.data;
+               if (tag == NULL)
+                       tag = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
+                               offset + srclen);
        }
 
        if (sess->cipher.direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT)
                status = process_openssl_auth_encryption_gcm(
-                               mbuf_src, op->sym->cipher.data.offset, srclen,
+                               mbuf_src, offset, srclen,
                                aad, aadlen, iv, ivlen, sess->cipher.key.data,
                                dst, tag, sess->cipher.ctx,
                                sess->cipher.evp_algo);
        else
                status = process_openssl_auth_decryption_gcm(
-                               mbuf_src, op->sym->cipher.data.offset, srclen,
+                               mbuf_src, offset, srclen,
                                aad, aadlen, iv, ivlen, sess->cipher.key.data,
                                dst, tag, sess->cipher.ctx,
                                sess->cipher.evp_algo);
@@ -986,21 +1169,18 @@ process_openssl_cipher_op
        dst = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
                        op->sym->cipher.data.offset);
 
-       iv = op->sym->cipher.iv.data;
+       iv = rte_crypto_op_ctod_offset(op, uint8_t *,
+                       sess->iv.offset);
 
        if (sess->cipher.mode == OPENSSL_CIPHER_LIB)
                if (sess->cipher.direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT)
                        status = process_openssl_cipher_encrypt(mbuf_src, dst,
                                        op->sym->cipher.data.offset, iv,
-                                       sess->cipher.key.data, srclen,
-                                       sess->cipher.ctx,
-                                       sess->cipher.evp_algo);
+                                       srclen, sess->cipher.ctx);
                else
                        status = process_openssl_cipher_decrypt(mbuf_src, dst,
                                        op->sym->cipher.data.offset, iv,
-                                       sess->cipher.key.data, srclen,
-                                       sess->cipher.ctx,
-                                       sess->cipher.evp_algo);
+                                       srclen, sess->cipher.ctx);
        else
                status = process_openssl_cipher_des3ctr(mbuf_src, dst,
                                op->sym->cipher.data.offset, iv,
@@ -1027,7 +1207,8 @@ process_openssl_docsis_bpi_op(struct rte_crypto_op *op,
        dst = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
                        op->sym->cipher.data.offset);
 
-       iv = op->sym->cipher.iv.data;
+       iv = rte_crypto_op_ctod_offset(op, uint8_t *,
+                       sess->iv.offset);
 
        block_size = DES_BLOCK_SIZE;
 
@@ -1043,8 +1224,7 @@ process_openssl_docsis_bpi_op(struct rte_crypto_op *op,
                        /* Encrypt with the block aligned stream with CBC mode */
                        status = process_openssl_cipher_encrypt(mbuf_src, dst,
                                        op->sym->cipher.data.offset, iv,
-                                       sess->cipher.key.data, srclen,
-                                       sess->cipher.ctx, sess->cipher.evp_algo);
+                                       srclen, sess->cipher.ctx);
                        if (last_block_len) {
                                /* Point at last block */
                                dst += srclen;
@@ -1085,7 +1265,8 @@ process_openssl_docsis_bpi_op(struct rte_crypto_op *op,
                                                dst, iv,
                                                last_block_len, sess->cipher.bpi_ctx);
                                /* Prepare parameters for CBC mode op */
-                               iv = op->sym->cipher.iv.data;
+                               iv = rte_crypto_op_ctod_offset(op, uint8_t *,
+                                               sess->iv.offset);
                                dst += last_block_len - srclen;
                                srclen -= last_block_len;
                        }
@@ -1093,9 +1274,7 @@ process_openssl_docsis_bpi_op(struct rte_crypto_op *op,
                        /* Decrypt with CBC mode */
                        status |= process_openssl_cipher_decrypt(mbuf_src, dst,
                                        op->sym->cipher.data.offset, iv,
-                                       sess->cipher.key.data, srclen,
-                                       sess->cipher.ctx,
-                                       sess->cipher.evp_algo);
+                                       srclen, sess->cipher.ctx);
                }
        }
 
@@ -1105,9 +1284,9 @@ process_openssl_docsis_bpi_op(struct rte_crypto_op *op,
 
 /** Process auth operation */
 static void
-process_openssl_auth_op
-               (struct rte_crypto_op *op, struct openssl_session *sess,
-               struct rte_mbuf *mbuf_src, struct rte_mbuf *mbuf_dst)
+process_openssl_auth_op(struct openssl_qp *qp, struct rte_crypto_op *op,
+               struct openssl_session *sess, struct rte_mbuf *mbuf_src,
+               struct rte_mbuf *mbuf_dst)
 {
        uint8_t *dst;
        int srclen, status;
@@ -1115,8 +1294,7 @@ process_openssl_auth_op
        srclen = op->sym->auth.data.length;
 
        if (sess->auth.operation == RTE_CRYPTO_AUTH_OP_VERIFY)
-               dst = (uint8_t *)rte_pktmbuf_append(mbuf_src,
-                               op->sym->auth.digest.length);
+               dst = qp->temp_digest;
        else {
                dst = op->sym->auth.digest.data;
                if (dst == NULL)
@@ -1133,9 +1311,8 @@ process_openssl_auth_op
                break;
        case OPENSSL_AUTH_AS_HMAC:
                status = process_openssl_auth_hmac(mbuf_src, dst,
-                               op->sym->auth.data.offset, NULL,
-                               sess->auth.hmac.pkey, srclen,
-                               sess->auth.hmac.ctx, sess->auth.hmac.evp_algo);
+                               op->sym->auth.data.offset, srclen,
+                               sess->auth.hmac.ctx);
                break;
        default:
                status = -1;
@@ -1144,11 +1321,9 @@ process_openssl_auth_op
 
        if (sess->auth.operation == RTE_CRYPTO_AUTH_OP_VERIFY) {
                if (memcmp(dst, op->sym->auth.digest.data,
-                               op->sym->auth.digest.length) != 0) {
+                               sess->auth.digest_length) != 0) {
                        op->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
                }
-               /* Trim area used for digest from mbuf. */
-               rte_pktmbuf_trim(mbuf_src, op->sym->auth.digest.length);
        }
 
        if (status != 0)
@@ -1157,7 +1332,7 @@ process_openssl_auth_op
 
 /** Process crypto operation for mbuf */
 static int
-process_op(const struct openssl_qp *qp, struct rte_crypto_op *op,
+process_op(struct openssl_qp *qp, struct rte_crypto_op *op,
                struct openssl_session *sess)
 {
        struct rte_mbuf *msrc, *mdst;
@@ -1173,14 +1348,14 @@ process_op(const struct openssl_qp *qp, struct rte_crypto_op *op,
                process_openssl_cipher_op(op, sess, msrc, mdst);
                break;
        case OPENSSL_CHAIN_ONLY_AUTH:
-               process_openssl_auth_op(op, sess, msrc, mdst);
+               process_openssl_auth_op(qp, op, sess, msrc, mdst);
                break;
        case OPENSSL_CHAIN_CIPHER_AUTH:
                process_openssl_cipher_op(op, sess, msrc, mdst);
-               process_openssl_auth_op(op, sess, mdst, mdst);
+               process_openssl_auth_op(qp, op, sess, mdst, mdst);
                break;
        case OPENSSL_CHAIN_AUTH_CIPHER:
-               process_openssl_auth_op(op, sess, msrc, mdst);
+               process_openssl_auth_op(qp, op, sess, msrc, mdst);
                process_openssl_cipher_op(op, sess, msrc, mdst);
                break;
        case OPENSSL_CHAIN_COMBINED:
@@ -1195,9 +1370,12 @@ process_op(const struct openssl_qp *qp, struct rte_crypto_op *op,
        }
 
        /* Free session if a session-less crypto op */
-       if (op->sym->sess_type == RTE_CRYPTO_SYM_OP_SESSIONLESS) {
+       if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
                openssl_reset_session(sess);
                memset(sess, 0, sizeof(struct openssl_session));
+               memset(op->sym->session, 0,
+                               rte_cryptodev_get_header_session_size());
+               rte_mempool_put(qp->sess_mp, sess);
                rte_mempool_put(qp->sess_mp, op->sym->session);
                op->sym->session = NULL;
        }
@@ -1275,7 +1453,7 @@ cryptodev_openssl_create(const char *name,
                snprintf(init_params->name, sizeof(init_params->name),
                                "%s", name);
 
-       dev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,
+       dev = rte_cryptodev_vdev_pmd_init(init_params->name,
                        sizeof(struct openssl_private),
                        init_params->socket_id,
                        vdev);
@@ -1284,7 +1462,7 @@ cryptodev_openssl_create(const char *name,
                goto init_error;
        }
 
-       dev->dev_type = RTE_CRYPTODEV_OPENSSL_PMD;
+       dev->driver_id = cryptodev_driver_id;
        dev->dev_ops = rte_openssl_pmd_ops;
 
        /* register rx/tx burst functions for data path */
@@ -1330,7 +1508,7 @@ cryptodev_openssl_probe(struct rte_vdev_device *vdev)
                return -EINVAL;
        input_args = rte_vdev_device_args(vdev);
 
-       rte_cryptodev_parse_vdev_init_params(&init_params, input_args);
+       rte_cryptodev_vdev_parse_init_params(&init_params, input_args);
 
        RTE_LOG(INFO, PMD, "Initialising %s on NUMA node %d\n", name,
                        init_params.socket_id);
@@ -1367,9 +1545,13 @@ static struct rte_vdev_driver cryptodev_openssl_pmd_drv = {
        .remove = cryptodev_openssl_remove
 };
 
+static struct cryptodev_driver openssl_crypto_drv;
+
 RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_OPENSSL_PMD,
        cryptodev_openssl_pmd_drv);
 RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_OPENSSL_PMD,
        "max_nb_queue_pairs=<int> "
        "max_nb_sessions=<int> "
        "socket_id=<int>");
+RTE_PMD_REGISTER_CRYPTO_DRIVER(openssl_crypto_drv, cryptodev_openssl_pmd_drv,
+               cryptodev_driver_id);