crypto/openssl: fix typo
[dpdk.git] / drivers / crypto / openssl / rte_openssl_pmd.c
index faa48a7..4b6dd12 100644 (file)
@@ -45,6 +45,8 @@
 
 #define DES_BLOCK_SIZE 8
 
+static uint8_t cryptodev_driver_id;
+
 static int cryptodev_openssl_remove(struct rte_vdev_device *vdev);
 
 /*----------------------------------------------------------------------------*/
@@ -89,6 +91,8 @@ openssl_get_chain_order(const struct rte_crypto_sym_xform *xform)
                        else if (xform->next->type == RTE_CRYPTO_SYM_XFORM_AUTH)
                                res =  OPENSSL_CHAIN_CIPHER_AUTH;
                }
+               if (xform->type == RTE_CRYPTO_SYM_XFORM_AEAD)
+                       res = OPENSSL_CHAIN_COMBINED;
        }
 
        return res;
@@ -184,21 +188,6 @@ get_cipher_algo(enum rte_crypto_cipher_algorithm sess_algo, size_t keylen,
                                res = -EINVAL;
                        }
                        break;
-               case RTE_CRYPTO_CIPHER_AES_GCM:
-                       switch (keylen) {
-                       case 16:
-                               *algo = EVP_aes_128_gcm();
-                               break;
-                       case 24:
-                               *algo = EVP_aes_192_gcm();
-                               break;
-                       case 32:
-                               *algo = EVP_aes_256_gcm();
-                               break;
-                       default:
-                               res = -EINVAL;
-                       }
-                       break;
                default:
                        res = -EINVAL;
                        break;
@@ -254,6 +243,41 @@ get_auth_algo(enum rte_crypto_auth_algorithm sessalgo,
        return res;
 }
 
+/** Get adequate openssl function for input cipher algorithm */
+static uint8_t
+get_aead_algo(enum rte_crypto_aead_algorithm sess_algo, size_t keylen,
+               const EVP_CIPHER **algo)
+{
+       int res = 0;
+
+       if (algo != NULL) {
+               switch (sess_algo) {
+               case RTE_CRYPTO_AEAD_AES_GCM:
+                       switch (keylen) {
+                       case 16:
+                               *algo = EVP_aes_128_gcm();
+                               break;
+                       case 24:
+                               *algo = EVP_aes_192_gcm();
+                               break;
+                       case 32:
+                               *algo = EVP_aes_256_gcm();
+                               break;
+                       default:
+                               res = -EINVAL;
+                       }
+                       break;
+               default:
+                       res = -EINVAL;
+                       break;
+               }
+       } else {
+               res = -EINVAL;
+       }
+
+       return res;
+}
+
 /** Set session cipher parameters */
 static int
 openssl_set_session_cipher_parameters(struct openssl_session *sess,
@@ -273,7 +297,6 @@ openssl_set_session_cipher_parameters(struct openssl_session *sess,
        case RTE_CRYPTO_CIPHER_3DES_CBC:
        case RTE_CRYPTO_CIPHER_AES_CBC:
        case RTE_CRYPTO_CIPHER_AES_CTR:
-       case RTE_CRYPTO_CIPHER_AES_GCM:
                sess->cipher.mode = OPENSSL_CIPHER_LIB;
                sess->cipher.algo = xform->cipher.algo;
                sess->cipher.ctx = EVP_CIPHER_CTX_new();
@@ -330,12 +353,6 @@ openssl_set_session_auth_parameters(struct openssl_session *sess,
 
        /* Select auth algo */
        switch (xform->auth.algo) {
-       case RTE_CRYPTO_AUTH_AES_GCM:
-               /* Check additional condition for AES_GCM */
-               if (sess->cipher.algo != RTE_CRYPTO_CIPHER_AES_GCM)
-                       return -EINVAL;
-               sess->chain_order = OPENSSL_CHAIN_COMBINED;
-               break;
        case RTE_CRYPTO_AUTH_AES_GMAC:
                sess->chain_order = OPENSSL_CHAIN_COMBINED;
 
@@ -356,7 +373,7 @@ openssl_set_session_auth_parameters(struct openssl_session *sess,
                sess->cipher.key.length = xform->auth.key.length;
                sess->cipher.ctx = EVP_CIPHER_CTX_new();
 
-               if (get_cipher_algo(RTE_CRYPTO_CIPHER_AES_GCM,
+               if (get_aead_algo(RTE_CRYPTO_AEAD_AES_GCM,
                                sess->cipher.key.length,
                                &sess->cipher.evp_algo) != 0)
                        return -EINVAL;
@@ -398,12 +415,55 @@ openssl_set_session_auth_parameters(struct openssl_session *sess,
                return -EINVAL;
        }
 
-       sess->auth.aad_length = xform->auth.add_auth_data_length;
        sess->auth.digest_length = xform->auth.digest_length;
 
        return 0;
 }
 
+/* Set session AEAD parameters */
+static int
+openssl_set_session_aead_parameters(struct openssl_session *sess,
+               const struct rte_crypto_sym_xform *xform)
+{
+       /* Select cipher direction */
+       sess->cipher.direction = xform->cipher.op;
+       /* Select cipher key */
+       sess->cipher.key.length = xform->aead.key.length;
+
+       /* Set IV parameters */
+       sess->iv.offset = xform->aead.iv.offset;
+       sess->iv.length = xform->aead.iv.length;
+
+       /* Select auth generate/verify */
+       sess->auth.operation = xform->auth.op;
+       sess->auth.algo = xform->auth.algo;
+
+       /* Select auth algo */
+       switch (xform->aead.algo) {
+       case RTE_CRYPTO_AEAD_AES_GCM:
+               sess->cipher.mode = OPENSSL_CIPHER_LIB;
+               sess->aead_algo = xform->aead.algo;
+               sess->cipher.ctx = EVP_CIPHER_CTX_new();
+
+               if (get_aead_algo(sess->aead_algo, sess->cipher.key.length,
+                               &sess->cipher.evp_algo) != 0)
+                       return -EINVAL;
+
+               get_cipher_key(xform->cipher.key.data, sess->cipher.key.length,
+                       sess->cipher.key.data);
+
+               sess->chain_order = OPENSSL_CHAIN_COMBINED;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       sess->auth.aad_length = xform->aead.aad_length;
+       sess->auth.digest_length = xform->aead.digest_length;
+
+       return 0;
+}
+
 /** Parse crypto xform chain and set private session parameters */
 int
 openssl_set_session_parameters(struct openssl_session *sess,
@@ -411,6 +471,7 @@ openssl_set_session_parameters(struct openssl_session *sess,
 {
        const struct rte_crypto_sym_xform *cipher_xform = NULL;
        const struct rte_crypto_sym_xform *auth_xform = NULL;
+       const struct rte_crypto_sym_xform *aead_xform = NULL;
 
        sess->chain_order = openssl_get_chain_order(xform);
        switch (sess->chain_order) {
@@ -428,6 +489,9 @@ openssl_set_session_parameters(struct openssl_session *sess,
                auth_xform = xform;
                cipher_xform = xform->next;
                break;
+       case OPENSSL_CHAIN_COMBINED:
+               aead_xform = xform;
+               break;
        default:
                return -EINVAL;
        }
@@ -453,6 +517,14 @@ openssl_set_session_parameters(struct openssl_session *sess,
                }
        }
 
+       if (aead_xform) {
+               if (openssl_set_session_aead_parameters(sess, aead_xform)) {
+                       OPENSSL_LOG_ERR(
+                               "Invalid/unsupported AEAD parameters");
+                       return -EINVAL;
+               }
+       }
+
        return 0;
 }
 
@@ -486,27 +558,33 @@ get_session(struct openssl_qp *qp, struct rte_crypto_op *op)
 
        if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) {
                /* get existing session */
-               if (likely(op->sym->session != NULL &&
-                               op->sym->session->dev_type ==
-                               RTE_CRYPTODEV_OPENSSL_PMD))
+               if (likely(op->sym->session != NULL))
                        sess = (struct openssl_session *)
-                               op->sym->session->_private;
-       } else  {
+                                       get_session_private_data(
+                                       op->sym->session,
+                                       cryptodev_driver_id);
+       } else {
                /* provide internal session */
                void *_sess = NULL;
+               void *_sess_private_data = NULL;
 
-               if (!rte_mempool_get(qp->sess_mp, (void **)&_sess)) {
-                       sess = (struct openssl_session *)
-                               ((struct rte_cryptodev_sym_session *)_sess)
-                               ->_private;
-
-                       if (unlikely(openssl_set_session_parameters(
-                                       sess, op->sym->xform) != 0)) {
-                               rte_mempool_put(qp->sess_mp, _sess);
-                               sess = NULL;
-                       } else
-                               op->sym->session = _sess;
+               if (rte_mempool_get(qp->sess_mp, (void **)&_sess))
+                       return NULL;
+
+               if (rte_mempool_get(qp->sess_mp, (void **)&_sess_private_data))
+                       return NULL;
+
+               sess = (struct openssl_session *)_sess_private_data;
+
+               if (unlikely(openssl_set_session_parameters(sess,
+                               op->sym->xform) != 0)) {
+                       rte_mempool_put(qp->sess_mp, _sess);
+                       rte_mempool_put(qp->sess_mp, _sess_private_data);
+                       sess = NULL;
                }
+               op->sym->session = (struct rte_cryptodev_sym_session *)_sess;
+               set_session_private_data(op->sym->session, cryptodev_driver_id,
+                       _sess_private_data);
        }
 
        if (sess == NULL)
@@ -965,26 +1043,27 @@ process_openssl_combined_op
        iv = rte_crypto_op_ctod_offset(op, uint8_t *,
                        sess->iv.offset);
        ivlen = sess->iv.length;
-       tag = op->sym->auth.digest.data;
-       if (tag == NULL)
-               tag = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
-                               op->sym->cipher.data.offset +
-                               op->sym->cipher.data.length);
-
        if (sess->auth.algo == RTE_CRYPTO_AUTH_AES_GMAC) {
                srclen = 0;
                offset = op->sym->auth.data.offset;
                aadlen = op->sym->auth.data.length;
                aad = rte_pktmbuf_mtod_offset(mbuf_src, uint8_t *,
                                op->sym->auth.data.offset);
-
+               tag = op->sym->auth.digest.data;
+               if (tag == NULL)
+                       tag = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
+                               offset + aadlen);
        } else {
-               srclen = op->sym->cipher.data.length;
+               srclen = op->sym->aead.data.length;
                dst = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
-                               op->sym->cipher.data.offset);
-               offset = op->sym->cipher.data.offset;
-               aad = op->sym->auth.aad.data;
+                               op->sym->aead.data.offset);
+               offset = op->sym->aead.data.offset;
+               aad = op->sym->aead.aad.data;
                aadlen = sess->auth.aad_length;
+               tag = op->sym->aead.digest.data;
+               if (tag == NULL)
+                       tag = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
+                               offset + srclen);
        }
 
        if (sess->cipher.direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT)
@@ -1247,6 +1326,9 @@ process_op(const struct openssl_qp *qp, struct rte_crypto_op *op,
        if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
                openssl_reset_session(sess);
                memset(sess, 0, sizeof(struct openssl_session));
+               memset(op->sym->session, 0,
+                               rte_cryptodev_get_header_session_size());
+               rte_mempool_put(qp->sess_mp, sess);
                rte_mempool_put(qp->sess_mp, op->sym->session);
                op->sym->session = NULL;
        }
@@ -1333,7 +1415,7 @@ cryptodev_openssl_create(const char *name,
                goto init_error;
        }
 
-       dev->dev_type = RTE_CRYPTODEV_OPENSSL_PMD;
+       dev->driver_id = cryptodev_driver_id;
        dev->dev_ops = rte_openssl_pmd_ops;
 
        /* register rx/tx burst functions for data path */
@@ -1422,3 +1504,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_OPENSSL_PMD,
        "max_nb_queue_pairs=<int> "
        "max_nb_sessions=<int> "
        "socket_id=<int>");
+RTE_PMD_REGISTER_CRYPTO_DRIVER(cryptodev_openssl_pmd_drv, cryptodev_driver_id);