cryptodev: break dependency on virtual device bus
[dpdk.git] / drivers / crypto / scheduler / scheduler_pmd.c
index b385851..40ab304 100644 (file)
@@ -33,7 +33,6 @@
 #include <rte_hexdump.h>
 #include <rte_cryptodev.h>
 #include <rte_cryptodev_pmd.h>
-#include <rte_cryptodev_vdev.h>
 #include <rte_vdev.h>
 #include <rte_malloc.h>
 #include <rte_cpuflags.h>
 uint8_t cryptodev_driver_id;
 
 struct scheduler_init_params {
-       struct rte_crypto_vdev_init_params def_p;
+       struct rte_cryptodev_pmd_init_params def_p;
        uint32_t nb_slaves;
        enum rte_cryptodev_scheduler_mode mode;
        uint32_t enable_ordering;
+       uint64_t wcmask;
        char slave_names[RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES]
                        [RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN];
 };
@@ -60,6 +60,8 @@ struct scheduler_init_params {
 #define RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG       ("max_nb_queue_pairs")
 #define RTE_CRYPTODEV_VDEV_MAX_NB_SESS_ARG     ("max_nb_sessions")
 #define RTE_CRYPTODEV_VDEV_SOCKET_ID           ("socket_id")
+#define RTE_CRYPTODEV_VDEV_COREMASK            ("coremask")
+#define RTE_CRYPTODEV_VDEV_CORELIST            ("corelist")
 
 const char *scheduler_valid_params[] = {
        RTE_CRYPTODEV_VDEV_NAME,
@@ -68,7 +70,9 @@ const char *scheduler_valid_params[] = {
        RTE_CRYPTODEV_VDEV_ORDERING,
        RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG,
        RTE_CRYPTODEV_VDEV_MAX_NB_SESS_ARG,
-       RTE_CRYPTODEV_VDEV_SOCKET_ID
+       RTE_CRYPTODEV_VDEV_SOCKET_ID,
+       RTE_CRYPTODEV_VDEV_COREMASK,
+       RTE_CRYPTODEV_VDEV_CORELIST
 };
 
 struct scheduler_parse_map {
@@ -82,7 +86,9 @@ const struct scheduler_parse_map scheduler_mode_map[] = {
        {RTE_STR(SCHEDULER_MODE_NAME_PKT_SIZE_DISTR),
                        CDEV_SCHED_MODE_PKT_SIZE_DISTR},
        {RTE_STR(SCHEDULER_MODE_NAME_FAIL_OVER),
-                       CDEV_SCHED_MODE_FAILOVER}
+                       CDEV_SCHED_MODE_FAILOVER},
+       {RTE_STR(SCHEDULER_MODE_NAME_MULTI_CORE),
+                       CDEV_SCHED_MODE_MULTICORE}
 };
 
 const struct scheduler_parse_map scheduler_ordering_map[] = {
@@ -100,21 +106,18 @@ cryptodev_scheduler_create(const char *name,
        uint32_t i;
        int ret;
 
-       if (init_params->def_p.name[0] == '\0')
-               snprintf(init_params->def_p.name,
-                               sizeof(init_params->def_p.name),
-                               "%s", name);
-
-       dev = rte_cryptodev_vdev_pmd_init(init_params->def_p.name,
-                       sizeof(struct scheduler_ctx),
-                       init_params->def_p.socket_id,
-                       vdev);
+       dev = rte_cryptodev_pmd_create(name, &vdev->device,
+                       &init_params->def_p);
        if (dev == NULL) {
                CS_LOG_ERR("driver %s: failed to create cryptodev vdev",
                        name);
                return -EFAULT;
        }
 
+       if (init_params->wcmask != 0)
+               RTE_LOG(INFO, PMD, "  workers core mask = %"PRIx64"\n",
+                       init_params->wcmask);
+
        dev->driver_id = cryptodev_driver_id;
        dev->dev_ops = rte_crypto_scheduler_pmd_ops;
 
@@ -122,6 +125,21 @@ cryptodev_scheduler_create(const char *name,
        sched_ctx->max_nb_queue_pairs =
                        init_params->def_p.max_nb_queue_pairs;
 
+       if (init_params->mode == CDEV_SCHED_MODE_MULTICORE) {
+               uint16_t i;
+
+               sched_ctx->nb_wc = 0;
+
+               for (i = 0; i < RTE_CRYPTODEV_SCHEDULER_MAX_NB_WORKER_CORES; i++) {
+                       if (init_params->wcmask & (1ULL << i)) {
+                               sched_ctx->wc_pool[sched_ctx->nb_wc++] = i;
+                               RTE_LOG(INFO, PMD,
+                                       "  Worker core[%u]=%u added\n",
+                                       sched_ctx->nb_wc-1, i);
+                       }
+               }
+       }
+
        if (init_params->mode > CDEV_SCHED_MODE_USERDEFINED &&
                        init_params->mode < CDEV_SCHED_MODE_COUNT) {
                ret = rte_cryptodev_scheduler_mode_set(dev->data->dev_id,
@@ -218,10 +236,7 @@ cryptodev_scheduler_remove(struct rte_vdev_device *vdev)
                                        sched_ctx->slaves[i].dev_id);
        }
 
-       RTE_LOG(INFO, PMD, "Closing Crypto Scheduler device %s on numa "
-               "socket %u\n", name, rte_socket_id());
-
-       return 0;
+       return rte_cryptodev_pmd_destroy(dev);
 }
 
 /** Parse integer from integer argument */
@@ -240,12 +255,49 @@ parse_integer_arg(const char *key __rte_unused,
        return 0;
 }
 
+/** Parse integer from hexadecimal integer argument */
+static int
+parse_coremask_arg(const char *key __rte_unused,
+               const char *value, void *extra_args)
+{
+       struct scheduler_init_params *params = extra_args;
+
+       params->wcmask = strtoull(value, NULL, 16);
+
+       return 0;
+}
+
+/** Parse integer from list of integers argument */
+static int
+parse_corelist_arg(const char *key __rte_unused,
+               const char *value, void *extra_args)
+{
+       struct scheduler_init_params *params = extra_args;
+
+       params->wcmask = 0ULL;
+
+       const char *token = value;
+
+       while (isdigit(token[0])) {
+               char *rval;
+               unsigned int core = strtoul(token, &rval, 10);
+
+               params->wcmask |= 1ULL << core;
+               token = (const char *)rval;
+               if (token[0] == '\0')
+                       break;
+               token++;
+       }
+
+       return 0;
+}
+
 /** Parse name */
 static int
 parse_name_arg(const char *key __rte_unused,
                const char *value, void *extra_args)
 {
-       struct rte_crypto_vdev_init_params *params = extra_args;
+       struct rte_cryptodev_pmd_init_params *params = extra_args;
 
        if (strlen(value) >= RTE_CRYPTODEV_NAME_MAX_LEN - 1) {
                CS_LOG_ERR("Invalid name %s, should be less than "
@@ -266,7 +318,7 @@ parse_slave_arg(const char *key __rte_unused,
 {
        struct scheduler_init_params *param = extra_args;
 
-       if (param->nb_slaves >= RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES - 1) {
+       if (param->nb_slaves >= RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES) {
                CS_LOG_ERR("Too many slaves.\n");
                return -ENOMEM;
        }
@@ -359,6 +411,18 @@ scheduler_parse_init_params(struct scheduler_init_params *params,
                if (ret < 0)
                        goto free_kvlist;
 
+               ret = rte_kvargs_process(kvlist, RTE_CRYPTODEV_VDEV_COREMASK,
+                               &parse_coremask_arg,
+                               params);
+               if (ret < 0)
+                       goto free_kvlist;
+
+               ret = rte_kvargs_process(kvlist, RTE_CRYPTODEV_VDEV_CORELIST,
+                               &parse_corelist_arg,
+                               params);
+               if (ret < 0)
+                       goto free_kvlist;
+
                ret = rte_kvargs_process(kvlist, RTE_CRYPTODEV_VDEV_NAME,
                                &parse_name_arg,
                                &params->def_p);
@@ -391,10 +455,11 @@ cryptodev_scheduler_probe(struct rte_vdev_device *vdev)
 {
        struct scheduler_init_params init_params = {
                .def_p = {
-                       RTE_CRYPTODEV_VDEV_DEFAULT_MAX_NB_QUEUE_PAIRS,
-                       RTE_CRYPTODEV_VDEV_DEFAULT_MAX_NB_SESSIONS,
+                       "",
+                       sizeof(struct scheduler_ctx),
                        rte_socket_id(),
-                       ""
+                       RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS,
+                       RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_SESSIONS
                },
                .nb_slaves = 0,
                .mode = CDEV_SCHED_MODE_NOT_SET,
@@ -410,16 +475,6 @@ cryptodev_scheduler_probe(struct rte_vdev_device *vdev)
        scheduler_parse_init_params(&init_params,
                                    rte_vdev_device_args(vdev));
 
-       RTE_LOG(INFO, PMD, "Initialising %s on NUMA node %d\n",
-                       name,
-                       init_params.def_p.socket_id);
-       RTE_LOG(INFO, PMD, "  Max number of queue pairs = %d\n",
-                       init_params.def_p.max_nb_queue_pairs);
-       RTE_LOG(INFO, PMD, "  Max number of sessions = %d\n",
-                       init_params.def_p.max_nb_sessions);
-       if (init_params.def_p.name[0] != '\0')
-               RTE_LOG(INFO, PMD, "  User defined name = %s\n",
-                       init_params.def_p.name);
 
        return cryptodev_scheduler_create(name,
                                        vdev,
@@ -431,6 +486,8 @@ static struct rte_vdev_driver cryptodev_scheduler_pmd_drv = {
        .remove = cryptodev_scheduler_remove
 };
 
+static struct cryptodev_driver scheduler_crypto_drv;
+
 RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_SCHEDULER_PMD,
        cryptodev_scheduler_pmd_drv);
 RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_SCHEDULER_PMD,
@@ -438,5 +495,6 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_SCHEDULER_PMD,
        "max_nb_sessions=<int> "
        "socket_id=<int> "
        "slave=<name>");
-RTE_PMD_REGISTER_CRYPTO_DRIVER(cryptodev_scheduler_pmd_drv,
+RTE_PMD_REGISTER_CRYPTO_DRIVER(scheduler_crypto_drv,
+               cryptodev_scheduler_pmd_drv,
                cryptodev_driver_id);