cryptodev: fix session init return value
[dpdk.git] / drivers / crypto / scheduler / scheduler_pmd_ops.c
index 287b2fb..d379534 100644 (file)
 #include <rte_dev.h>
 #include <rte_cryptodev.h>
 #include <rte_cryptodev_pmd.h>
+#include <rte_cryptodev_vdev.h>
 #include <rte_reorder.h>
 
 #include "scheduler_pmd_private.h"
 
+/** attaching the slaves predefined by scheduler's EAL options */
+static int
+scheduler_attach_init_slave(struct rte_cryptodev *dev)
+{
+       struct scheduler_ctx *sched_ctx = dev->data->dev_private;
+       uint8_t scheduler_id = dev->data->dev_id;
+       int i;
+
+       for (i = sched_ctx->nb_init_slaves - 1; i >= 0; i--) {
+               const char *dev_name = sched_ctx->init_slave_names[i];
+               struct rte_cryptodev *slave_dev =
+                               rte_cryptodev_pmd_get_named_dev(dev_name);
+               int status;
+
+               if (!slave_dev) {
+                       CS_LOG_ERR("Failed to locate slave dev %s",
+                                       dev_name);
+                       return -EINVAL;
+               }
+
+               status = rte_cryptodev_scheduler_slave_attach(
+                               scheduler_id, slave_dev->data->dev_id);
+
+               if (status < 0) {
+                       CS_LOG_ERR("Failed to attach slave cryptodev %u",
+                                       slave_dev->data->dev_id);
+                       return status;
+               }
+
+               CS_LOG_INFO("Scheduler %s attached slave %s\n",
+                               dev->data->name,
+                               sched_ctx->init_slave_names[i]);
+
+               rte_free(sched_ctx->init_slave_names[i]);
+
+               sched_ctx->nb_init_slaves -= 1;
+       }
+
+       return 0;
+}
 /** Configure device */
 static int
-scheduler_pmd_config(struct rte_cryptodev *dev)
+scheduler_pmd_config(struct rte_cryptodev *dev,
+               struct rte_cryptodev_config *config)
 {
        struct scheduler_ctx *sched_ctx = dev->data->dev_private;
        uint32_t i;
-       int ret = 0;
+       int ret;
+
+       /* although scheduler_attach_init_slave presents multiple times,
+        * there will be only 1 meaningful execution.
+        */
+       ret = scheduler_attach_init_slave(dev);
+       if (ret < 0)
+               return ret;
 
        for (i = 0; i < sched_ctx->nb_slaves; i++) {
                uint8_t slave_dev_id = sched_ctx->slaves[i].dev_id;
-               struct rte_cryptodev *slave_dev =
-                               rte_cryptodev_pmd_get_dev(slave_dev_id);
 
-               ret = (*slave_dev->dev_ops->dev_configure)(slave_dev);
+               ret = rte_cryptodev_configure(slave_dev_id, config);
                if (ret < 0)
                        break;
        }
@@ -117,6 +164,13 @@ scheduler_pmd_start(struct rte_cryptodev *dev)
        if (dev->data->dev_started)
                return 0;
 
+       /* although scheduler_attach_init_slave presents multiple times,
+        * there will be only 1 meaningful execution.
+        */
+       ret = scheduler_attach_init_slave(dev);
+       if (ret < 0)
+               return ret;
+
        for (i = 0; i < dev->data->nb_queue_pairs; i++) {
                ret = update_order_ring(dev, i);
                if (ret < 0) {
@@ -299,6 +353,11 @@ scheduler_pmd_info_get(struct rte_cryptodev *dev,
        if (!dev_info)
                return;
 
+       /* although scheduler_attach_init_slave presents multiple times,
+        * there will be only 1 meaningful execution.
+        */
+       scheduler_attach_init_slave(dev);
+
        for (i = 0; i < sched_ctx->nb_slaves; i++) {
                uint8_t slave_dev_id = sched_ctx->slaves[i].dev_id;
                struct rte_cryptodev_info slave_info;
@@ -310,7 +369,7 @@ scheduler_pmd_info_get(struct rte_cryptodev *dev,
                                max_nb_sessions;
        }
 
-       dev_info->dev_type = dev->dev_type;
+       dev_info->driver_id = dev->driver_id;
        dev_info->feature_flags = dev->feature_flags;
        dev_info->capabilities = sched_ctx->capabilities;
        dev_info->max_nb_queue_pairs = sched_ctx->max_nb_queue_pairs;
@@ -340,11 +399,14 @@ scheduler_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)
 /** Setup a queue pair */
 static int
 scheduler_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
-       __rte_unused const struct rte_cryptodev_qp_conf *qp_conf, int socket_id)
+       const struct rte_cryptodev_qp_conf *qp_conf, int socket_id,
+       struct rte_mempool *session_pool)
 {
        struct scheduler_ctx *sched_ctx = dev->data->dev_private;
        struct scheduler_qp_ctx *qp_ctx;
        char name[RTE_CRYPTODEV_NAME_MAX_LEN];
+       uint32_t i;
+       int ret;
 
        if (snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN,
                        "CRYTO_SCHE PMD %u QP %u",
@@ -357,14 +419,41 @@ scheduler_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
        if (dev->data->queue_pairs[qp_id] != NULL)
                scheduler_pmd_qp_release(dev, qp_id);
 
+       for (i = 0; i < sched_ctx->nb_slaves; i++) {
+               uint8_t slave_id = sched_ctx->slaves[i].dev_id;
+
+               /*
+                * All slaves will share the same session mempool
+                * for session-less operations, so the objects
+                * must be big enough for all the drivers used.
+                */
+               ret = rte_cryptodev_queue_pair_setup(slave_id, qp_id,
+                               qp_conf, socket_id, session_pool);
+               if (ret < 0)
+                       return ret;
+       }
+
        /* Allocate the queue pair data structure. */
        qp_ctx = rte_zmalloc_socket(name, sizeof(*qp_ctx), RTE_CACHE_LINE_SIZE,
                        socket_id);
        if (qp_ctx == NULL)
                return -ENOMEM;
 
+       /* The actual available object number = nb_descriptors - 1 */
+       qp_ctx->max_nb_objs = qp_conf->nb_descriptors - 1;
+
        dev->data->queue_pairs[qp_id] = qp_ctx;
 
+       /* although scheduler_attach_init_slave presents multiple times,
+        * there will be only 1 meaningful execution.
+        */
+       ret = scheduler_attach_init_slave(dev);
+       if (ret < 0) {
+               CS_LOG_ERR("Failed to attach slave");
+               scheduler_pmd_qp_release(dev, qp_id);
+               return ret;
+       }
+
        if (*sched_ctx->ops.config_queue_pair) {
                if ((*sched_ctx->ops.config_queue_pair)(dev, qp_id) < 0) {
                        CS_LOG_ERR("Unable to configure queue pair");
@@ -401,40 +490,41 @@ scheduler_pmd_qp_count(struct rte_cryptodev *dev)
 static uint32_t
 scheduler_pmd_session_get_size(struct rte_cryptodev *dev __rte_unused)
 {
-       return sizeof(struct scheduler_session);
+       struct scheduler_ctx *sched_ctx = dev->data->dev_private;
+       uint8_t i = 0;
+       uint32_t max_priv_sess_size = 0;
+
+       /* Check what is the maximum private session size for all slaves */
+       for (i = 0; i < sched_ctx->nb_slaves; i++) {
+               uint8_t slave_dev_id = sched_ctx->slaves[i].dev_id;
+               struct rte_cryptodev *dev = &rte_cryptodevs[slave_dev_id];
+               uint32_t priv_sess_size = (*dev->dev_ops->session_get_size)(dev);
+
+               if (max_priv_sess_size < priv_sess_size)
+                       max_priv_sess_size = priv_sess_size;
+       }
+
+       return max_priv_sess_size;
 }
 
 static int
-config_slave_sess(struct scheduler_ctx *sched_ctx,
-               struct rte_crypto_sym_xform *xform,
-               struct scheduler_session *sess,
-               uint32_t create)
+scheduler_pmd_session_configure(struct rte_cryptodev *dev,
+       struct rte_crypto_sym_xform *xform,
+       struct rte_cryptodev_sym_session *sess,
+       struct rte_mempool *mempool)
 {
+       struct scheduler_ctx *sched_ctx = dev->data->dev_private;
        uint32_t i;
+       int ret;
 
        for (i = 0; i < sched_ctx->nb_slaves; i++) {
                struct scheduler_slave *slave = &sched_ctx->slaves[i];
-               struct rte_cryptodev *dev =
-                               rte_cryptodev_pmd_get_dev(slave->dev_id);
-
-               if (sess->sessions[i]) {
-                       if (create)
-                               continue;
-                       /* !create */
-                       (*dev->dev_ops->session_clear)(dev,
-                                       (void *)sess->sessions[i]);
-                       sess->sessions[i] = NULL;
-               } else {
-                       if (!create)
-                               continue;
-                       /* create */
-                       sess->sessions[i] =
-                                       rte_cryptodev_sym_session_create(
-                                                       slave->dev_id, xform);
-                       if (!sess->sessions[i]) {
-                               config_slave_sess(sched_ctx, NULL, sess, 0);
-                               return -1;
-                       }
+
+               ret = rte_cryptodev_sym_session_init(slave->dev_id, sess,
+                                       xform, mempool);
+               if (ret < 0) {
+                       CS_LOG_ERR("unabled to config sym session");
+                       return ret;
                }
        }
 
@@ -444,27 +534,17 @@ config_slave_sess(struct scheduler_ctx *sched_ctx,
 /** Clear the memory of session so it doesn't leave key material behind */
 static void
 scheduler_pmd_session_clear(struct rte_cryptodev *dev,
-       void *sess)
+               struct rte_cryptodev_sym_session *sess)
 {
        struct scheduler_ctx *sched_ctx = dev->data->dev_private;
+       uint32_t i;
 
-       config_slave_sess(sched_ctx, NULL, sess, 0);
-
-       memset(sess, 0, sizeof(struct scheduler_session));
-}
-
-static void *
-scheduler_pmd_session_configure(struct rte_cryptodev *dev,
-       struct rte_crypto_sym_xform *xform, void *sess)
-{
-       struct scheduler_ctx *sched_ctx = dev->data->dev_private;
+       /* Clear private data of slaves */
+       for (i = 0; i < sched_ctx->nb_slaves; i++) {
+               struct scheduler_slave *slave = &sched_ctx->slaves[i];
 
-       if (config_slave_sess(sched_ctx, xform, sess, 1) < 0) {
-               CS_LOG_ERR("unabled to config sym session");
-               return NULL;
+               rte_cryptodev_sym_session_clear(slave->dev_id, sess);
        }
-
-       return sess;
 }
 
 struct rte_cryptodev_ops scheduler_pmd_ops = {