ethdev: fix max Rx packet length
[dpdk.git] / drivers / net / axgbe / axgbe_ethdev.c
index 0c25739..76cd892 100644 (file)
@@ -8,14 +8,15 @@
 #include "axgbe_common.h"
 #include "axgbe_phy.h"
 #include "axgbe_regs.h"
+#include "rte_time.h"
 
 static int eth_axgbe_dev_init(struct rte_eth_dev *eth_dev);
-static int eth_axgbe_dev_uninit(struct rte_eth_dev *eth_dev);
 static int  axgbe_dev_configure(struct rte_eth_dev *dev);
 static int  axgbe_dev_start(struct rte_eth_dev *dev);
-static void axgbe_dev_stop(struct rte_eth_dev *dev);
+static int  axgbe_dev_stop(struct rte_eth_dev *dev);
 static void axgbe_dev_interrupt_handler(void *param);
-static void axgbe_dev_close(struct rte_eth_dev *dev);
+static int axgbe_dev_close(struct rte_eth_dev *dev);
+static int axgbe_dev_reset(struct rte_eth_dev *dev);
 static int axgbe_dev_promiscuous_enable(struct rte_eth_dev *dev);
 static int axgbe_dev_promiscuous_disable(struct rte_eth_dev *dev);
 static int axgbe_dev_allmulticast_enable(struct rte_eth_dev *dev);
@@ -56,8 +57,8 @@ axgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev,
                           unsigned int n);
 static int
 axgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,
-                                struct rte_eth_xstat_name *xstats_names,
                                 const uint64_t *ids,
+                                struct rte_eth_xstat_name *xstats_names,
                                 unsigned int size);
 static int axgbe_dev_xstats_reset(struct rte_eth_dev *dev);
 static int axgbe_dev_rss_reta_update(struct rte_eth_dev *dev,
@@ -85,6 +86,36 @@ static void axgbe_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
 const uint32_t *axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 
+static int
+axgbe_timesync_enable(struct rte_eth_dev *dev);
+static int
+axgbe_timesync_disable(struct rte_eth_dev *dev);
+static int
+axgbe_timesync_read_rx_timestamp(struct rte_eth_dev *dev,
+                       struct timespec *timestamp, uint32_t flags);
+static int
+axgbe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
+                       struct timespec *timestamp);
+static int
+axgbe_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta);
+static int
+axgbe_timesync_read_time(struct rte_eth_dev *dev,
+                       struct timespec *timestamp);
+static int
+axgbe_timesync_write_time(struct rte_eth_dev *dev,
+                       const struct timespec *timestamp);
+static void
+axgbe_set_tstamp_time(struct axgbe_port *pdata, unsigned int sec,
+                       unsigned int nsec);
+static void
+axgbe_update_tstamp_addend(struct axgbe_port *pdata,
+                       unsigned int addend);
+static int
+       axgbe_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on);
+static int axgbe_vlan_tpid_set(struct rte_eth_dev *dev,
+                               enum rte_vlan_type vlan_type, uint16_t tpid);
+static int axgbe_vlan_offload_set(struct rte_eth_dev *dev, int mask);
+
 struct axgbe_xstats {
        char name[RTE_ETH_XSTATS_NAME_SIZE];
        int offset;
@@ -190,6 +221,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = {
        .dev_start            = axgbe_dev_start,
        .dev_stop             = axgbe_dev_stop,
        .dev_close            = axgbe_dev_close,
+       .dev_reset            = axgbe_dev_reset,
        .promiscuous_enable   = axgbe_dev_promiscuous_enable,
        .promiscuous_disable  = axgbe_dev_promiscuous_disable,
        .allmulticast_enable  = axgbe_dev_allmulticast_enable,
@@ -224,9 +256,18 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = {
        .rxq_info_get                 = axgbe_rxq_info_get,
        .txq_info_get                 = axgbe_txq_info_get,
        .dev_supported_ptypes_get     = axgbe_dev_supported_ptypes_get,
-       .rx_descriptor_status         = axgbe_dev_rx_descriptor_status,
-       .tx_descriptor_status         = axgbe_dev_tx_descriptor_status,
        .mtu_set                = axgb_mtu_set,
+       .vlan_filter_set      = axgbe_vlan_filter_set,
+       .vlan_tpid_set        = axgbe_vlan_tpid_set,
+       .vlan_offload_set     = axgbe_vlan_offload_set,
+       .timesync_enable              = axgbe_timesync_enable,
+       .timesync_disable             = axgbe_timesync_disable,
+       .timesync_read_rx_timestamp   = axgbe_timesync_read_rx_timestamp,
+       .timesync_read_tx_timestamp   = axgbe_timesync_read_tx_timestamp,
+       .timesync_adjust_time         = axgbe_timesync_adjust_time,
+       .timesync_read_time           = axgbe_timesync_read_time,
+       .timesync_write_time          = axgbe_timesync_write_time,
+       .fw_version_get                 = axgbe_dev_fw_version_get,
 };
 
 static int axgbe_phy_reset(struct axgbe_port *pdata)
@@ -309,7 +350,7 @@ axgbe_dev_start(struct rte_eth_dev *dev)
        struct axgbe_port *pdata = dev->data->dev_private;
        int ret;
        struct rte_eth_dev_data *dev_data = dev->data;
-       uint16_t max_pkt_len = dev_data->dev_conf.rxmode.max_rx_pkt_len;
+       uint16_t max_pkt_len;
 
        dev->dev_ops = &axgbe_eth_dev_ops;
 
@@ -342,6 +383,8 @@ axgbe_dev_start(struct rte_eth_dev *dev)
 
        rte_bit_relaxed_clear32(AXGBE_STOPPED, &pdata->dev_state);
        rte_bit_relaxed_clear32(AXGBE_DOWN, &pdata->dev_state);
+
+       max_pkt_len = dev_data->mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
        if ((dev_data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_SCATTER) ||
                                max_pkt_len > pdata->rx_buf_size)
                dev_data->scattered_rx = 1;
@@ -356,7 +399,7 @@ axgbe_dev_start(struct rte_eth_dev *dev)
 }
 
 /* Stop device: disable rx and tx functions to allow for reconfiguring. */
-static void
+static int
 axgbe_dev_stop(struct rte_eth_dev *dev)
 {
        struct axgbe_port *pdata = dev->data->dev_private;
@@ -366,7 +409,7 @@ axgbe_dev_stop(struct rte_eth_dev *dev)
        rte_intr_disable(&pdata->pci_dev->intr_handle);
 
        if (rte_bit_relaxed_get32(AXGBE_STOPPED, &pdata->dev_state))
-               return;
+               return 0;
 
        rte_bit_relaxed_set32(AXGBE_STOPPED, &pdata->dev_state);
        axgbe_dev_disable_tx(dev);
@@ -376,13 +419,8 @@ axgbe_dev_stop(struct rte_eth_dev *dev)
        pdata->hw_if.exit(pdata);
        memset(&dev->data->dev_link, 0, sizeof(struct rte_eth_link));
        rte_bit_relaxed_set32(AXGBE_DOWN, &pdata->dev_state);
-}
 
-/* Clear all resources like TX/RX queues. */
-static void
-axgbe_dev_close(struct rte_eth_dev *dev)
-{
-       axgbe_dev_clear_queues(dev);
+       return 0;
 }
 
 static int
@@ -593,6 +631,20 @@ axgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
        return 0;
 }
 
+static int
+axgbe_dev_reset(struct rte_eth_dev *dev)
+{
+       int ret = 0;
+
+       ret = axgbe_dev_close(dev);
+       if (ret)
+               return ret;
+
+       ret = eth_axgbe_dev_init(dev);
+
+       return ret;
+}
+
 static void
 axgbe_dev_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)
 {
@@ -1026,8 +1078,8 @@ axgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
 
 static int
 axgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,
-                                struct rte_eth_xstat_name *xstats_names,
                                 const uint64_t *ids,
+                                struct rte_eth_xstat_name *xstats_names,
                                 unsigned int size)
 {
        struct rte_eth_xstat_name xstats_names_copy[AXGBE_XSTATS_COUNT];
@@ -1079,22 +1131,33 @@ axgbe_dev_stats_get(struct rte_eth_dev *dev,
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
                rxq = dev->data->rx_queues[i];
-               stats->q_ipackets[i] = rxq->pkts;
-               stats->ipackets += rxq->pkts;
-               stats->q_ibytes[i] = rxq->bytes;
-               stats->ibytes += rxq->bytes;
-               stats->rx_nombuf += rxq->rx_mbuf_alloc_failed;
-               stats->q_errors[i] = rxq->errors + rxq->rx_mbuf_alloc_failed;
-               stats->ierrors += rxq->errors;
+               if (rxq) {
+                       stats->q_ipackets[i] = rxq->pkts;
+                       stats->ipackets += rxq->pkts;
+                       stats->q_ibytes[i] = rxq->bytes;
+                       stats->ibytes += rxq->bytes;
+                       stats->rx_nombuf += rxq->rx_mbuf_alloc_failed;
+                       stats->q_errors[i] = rxq->errors
+                               + rxq->rx_mbuf_alloc_failed;
+                       stats->ierrors += rxq->errors;
+               } else {
+                       PMD_DRV_LOG(DEBUG, "Rx queue not setup for port %d\n",
+                                       dev->data->port_id);
+               }
        }
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                txq = dev->data->tx_queues[i];
-               stats->q_opackets[i] = txq->pkts;
-               stats->opackets += txq->pkts;
-               stats->q_obytes[i] = txq->bytes;
-               stats->obytes += txq->bytes;
-               stats->oerrors += txq->errors;
+               if (txq) {
+                       stats->q_opackets[i] = txq->pkts;
+                       stats->opackets += txq->pkts;
+                       stats->q_obytes[i] = txq->bytes;
+                       stats->obytes += txq->bytes;
+                       stats->oerrors += txq->errors;
+               } else {
+                       PMD_DRV_LOG(DEBUG, "Tx queue not setup for port %d\n",
+                                       dev->data->port_id);
+               }
        }
 
        return 0;
@@ -1109,16 +1172,26 @@ axgbe_dev_stats_reset(struct rte_eth_dev *dev)
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
                rxq = dev->data->rx_queues[i];
-               rxq->pkts = 0;
-               rxq->bytes = 0;
-               rxq->errors = 0;
-               rxq->rx_mbuf_alloc_failed = 0;
+               if (rxq) {
+                       rxq->pkts = 0;
+                       rxq->bytes = 0;
+                       rxq->errors = 0;
+                       rxq->rx_mbuf_alloc_failed = 0;
+               } else {
+                       PMD_DRV_LOG(DEBUG, "Rx queue not setup for port %d\n",
+                                       dev->data->port_id);
+               }
        }
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                txq = dev->data->tx_queues[i];
-               txq->pkts = 0;
-               txq->bytes = 0;
-               txq->errors = 0;
+               if (txq) {
+                       txq->pkts = 0;
+                       txq->bytes = 0;
+                       txq->errors = 0;
+               } else {
+                       PMD_DRV_LOG(DEBUG, "Tx queue not setup for port %d\n",
+                                       dev->data->port_id);
+               }
        }
 
        return 0;
@@ -1138,6 +1211,9 @@ axgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->speed_capa =  ETH_LINK_SPEED_10G;
 
        dev_info->rx_offload_capa =
+               DEV_RX_OFFLOAD_VLAN_STRIP |
+               DEV_RX_OFFLOAD_VLAN_FILTER |
+               DEV_RX_OFFLOAD_VLAN_EXTEND |
                DEV_RX_OFFLOAD_IPV4_CKSUM |
                DEV_RX_OFFLOAD_UDP_CKSUM  |
                DEV_RX_OFFLOAD_TCP_CKSUM  |
@@ -1146,6 +1222,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
                DEV_RX_OFFLOAD_KEEP_CRC;
 
        dev_info->tx_offload_capa =
+               DEV_TX_OFFLOAD_VLAN_INSERT |
+               DEV_TX_OFFLOAD_QINQ_INSERT |
                DEV_TX_OFFLOAD_IPV4_CKSUM  |
                DEV_TX_OFFLOAD_UDP_CKSUM   |
                DEV_TX_OFFLOAD_TCP_CKSUM;
@@ -1397,6 +1475,7 @@ axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev)
                return ptypes;
        return NULL;
 }
+
 static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
        struct rte_eth_dev_info dev_info;
@@ -1413,7 +1492,7 @@ static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
                                dev->data->port_id);
                return -EBUSY;
        }
-       if (frame_size > RTE_ETHER_MAX_LEN) {
+       if (mtu > RTE_ETHER_MTU) {
                dev->data->dev_conf.rxmode.offloads |=
                        DEV_RX_OFFLOAD_JUMBO_FRAME;
                val = 1;
@@ -1423,17 +1502,469 @@ static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
                val = 0;
        }
        AXGMAC_IOWRITE_BITS(pdata, MAC_RCR, JE, val);
-       dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
        return 0;
 }
+
+static void
+axgbe_update_tstamp_time(struct axgbe_port *pdata,
+               unsigned int sec, unsigned int nsec, int addsub)
+{
+       unsigned int count = 100;
+       uint32_t sub_val = 0;
+       uint32_t sub_val_sec = 0xFFFFFFFF;
+       uint32_t sub_val_nsec = 0x3B9ACA00;
+
+       if (addsub) {
+               if (sec)
+                       sub_val = sub_val_sec - (sec - 1);
+               else
+                       sub_val = sec;
+
+               AXGMAC_IOWRITE(pdata, MAC_STSUR, sub_val);
+               sub_val = sub_val_nsec - nsec;
+               AXGMAC_IOWRITE(pdata, MAC_STNUR, sub_val);
+               AXGMAC_IOWRITE_BITS(pdata, MAC_STNUR, ADDSUB, 1);
+       } else {
+               AXGMAC_IOWRITE(pdata, MAC_STSUR, sec);
+               AXGMAC_IOWRITE_BITS(pdata, MAC_STNUR, ADDSUB, 0);
+               AXGMAC_IOWRITE(pdata, MAC_STNUR, nsec);
+       }
+       AXGMAC_IOWRITE_BITS(pdata, MAC_TSCR, TSUPDT, 1);
+       /* Wait for time update to complete */
+       while (--count && AXGMAC_IOREAD_BITS(pdata, MAC_TSCR, TSUPDT))
+               rte_delay_ms(1);
+}
+
+static inline uint64_t
+div_u64_rem(uint64_t dividend, uint32_t divisor, uint32_t *remainder)
+{
+       *remainder = dividend % divisor;
+       return dividend / divisor;
+}
+
+static inline uint64_t
+div_u64(uint64_t dividend, uint32_t divisor)
+{
+       uint32_t remainder;
+       return div_u64_rem(dividend, divisor, &remainder);
+}
+
+static int
+axgbe_adjfreq(struct axgbe_port *pdata, int64_t delta)
+{
+       uint64_t adjust;
+       uint32_t addend, diff;
+       unsigned int neg_adjust = 0;
+
+       if (delta < 0) {
+               neg_adjust = 1;
+               delta = -delta;
+       }
+       adjust = (uint64_t)pdata->tstamp_addend;
+       adjust *= delta;
+       diff = (uint32_t)div_u64(adjust, 1000000000UL);
+       addend = (neg_adjust) ? pdata->tstamp_addend - diff :
+                               pdata->tstamp_addend + diff;
+       pdata->tstamp_addend = addend;
+       axgbe_update_tstamp_addend(pdata, addend);
+       return 0;
+}
+
+static int
+axgbe_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta)
+{
+       struct axgbe_port *pdata = dev->data->dev_private;
+       struct timespec timestamp_delta;
+
+       axgbe_adjfreq(pdata, delta);
+       pdata->systime_tc.nsec += delta;
+
+       if (delta < 0) {
+               delta = -delta;
+               timestamp_delta = rte_ns_to_timespec(delta);
+               axgbe_update_tstamp_time(pdata, timestamp_delta.tv_sec,
+                               timestamp_delta.tv_nsec, 1);
+       } else {
+               timestamp_delta = rte_ns_to_timespec(delta);
+               axgbe_update_tstamp_time(pdata, timestamp_delta.tv_sec,
+                               timestamp_delta.tv_nsec, 0);
+       }
+       return 0;
+}
+
+static int
+axgbe_timesync_read_time(struct rte_eth_dev *dev,
+               struct timespec *timestamp)
+{
+       uint64_t nsec;
+       struct axgbe_port *pdata = dev->data->dev_private;
+
+       nsec = AXGMAC_IOREAD(pdata, MAC_STSR);
+       nsec *= NSEC_PER_SEC;
+       nsec += AXGMAC_IOREAD(pdata, MAC_STNR);
+       *timestamp = rte_ns_to_timespec(nsec);
+       return 0;
+}
+static int
+axgbe_timesync_write_time(struct rte_eth_dev *dev,
+                                   const struct timespec *timestamp)
+{
+       unsigned int count = 100;
+       struct axgbe_port *pdata = dev->data->dev_private;
+
+       AXGMAC_IOWRITE(pdata, MAC_STSUR, timestamp->tv_sec);
+       AXGMAC_IOWRITE(pdata, MAC_STNUR, timestamp->tv_nsec);
+       AXGMAC_IOWRITE_BITS(pdata, MAC_TSCR, TSUPDT, 1);
+       /* Wait for time update to complete */
+       while (--count && AXGMAC_IOREAD_BITS(pdata, MAC_TSCR, TSUPDT))
+               rte_delay_ms(1);
+       if (!count)
+               PMD_DRV_LOG(ERR, "Timed out update timestamp\n");
+       return 0;
+}
+
+static void
+axgbe_update_tstamp_addend(struct axgbe_port *pdata,
+               uint32_t addend)
+{
+       unsigned int count = 100;
+
+       AXGMAC_IOWRITE(pdata, MAC_TSAR, addend);
+       AXGMAC_IOWRITE_BITS(pdata, MAC_TSCR, TSADDREG, 1);
+
+       /* Wait for addend update to complete */
+       while (--count && AXGMAC_IOREAD_BITS(pdata, MAC_TSCR, TSADDREG))
+               rte_delay_ms(1);
+       if (!count)
+               PMD_DRV_LOG(ERR, "Timed out updating timestamp addend register\n");
+}
+
+static void
+axgbe_set_tstamp_time(struct axgbe_port *pdata, unsigned int sec,
+               unsigned int nsec)
+{
+       unsigned int count = 100;
+
+       /*System Time Sec Update*/
+       AXGMAC_IOWRITE(pdata, MAC_STSUR, sec);
+       /*System Time nanoSec Update*/
+       AXGMAC_IOWRITE(pdata, MAC_STNUR, nsec);
+       /*Initialize Timestamp*/
+       AXGMAC_IOWRITE_BITS(pdata, MAC_TSCR, TSINIT, 1);
+
+       /* Wait for time update to complete */
+       while (--count && AXGMAC_IOREAD_BITS(pdata, MAC_TSCR, TSINIT))
+               rte_delay_ms(1);
+       if (!count)
+               PMD_DRV_LOG(ERR, "Timed out initializing timestamp\n");
+}
+
+static int
+axgbe_timesync_enable(struct rte_eth_dev *dev)
+{
+       struct axgbe_port *pdata = dev->data->dev_private;
+       unsigned int mac_tscr = 0;
+       uint64_t dividend;
+       struct timespec timestamp;
+       uint64_t nsec;
+
+       /* Set one nano-second accuracy */
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSCTRLSSR, 1);
+
+       /* Set fine timestamp update */
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSCFUPDT, 1);
+
+       /* Overwrite earlier timestamps */
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TXTSSTSM, 1);
+
+       AXGMAC_IOWRITE(pdata, MAC_TSCR, mac_tscr);
+
+       /* Enabling processing of ptp over eth pkt */
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSIPENA, 1);
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSVER2ENA, 1);
+       /* Enable timestamp for all pkts*/
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSENALL, 1);
+
+       /* enabling timestamp */
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSENA, 1);
+       AXGMAC_IOWRITE(pdata, MAC_TSCR, mac_tscr);
+
+       /* Exit if timestamping is not enabled */
+       if (!AXGMAC_GET_BITS(mac_tscr, MAC_TSCR, TSENA)) {
+               PMD_DRV_LOG(ERR, "Exiting as timestamp is not enabled\n");
+               return 0;
+       }
+
+       /* Sub-second Increment Value*/
+       AXGMAC_IOWRITE_BITS(pdata, MAC_SSIR, SSINC, AXGBE_TSTAMP_SSINC);
+       /* Sub-nanosecond Increment Value */
+       AXGMAC_IOWRITE_BITS(pdata, MAC_SSIR, SNSINC, AXGBE_TSTAMP_SNSINC);
+
+       pdata->ptpclk_rate = AXGBE_V2_PTP_CLOCK_FREQ;
+       dividend = 50000000;
+       dividend <<= 32;
+       pdata->tstamp_addend = div_u64(dividend, pdata->ptpclk_rate);
+
+       axgbe_update_tstamp_addend(pdata, pdata->tstamp_addend);
+       axgbe_set_tstamp_time(pdata, 0, 0);
+
+       /* Initialize the timecounter */
+       memset(&pdata->systime_tc, 0, sizeof(struct rte_timecounter));
+
+       pdata->systime_tc.cc_mask = AXGBE_CYCLECOUNTER_MASK;
+       pdata->systime_tc.cc_shift = 0;
+       pdata->systime_tc.nsec_mask = 0;
+
+       PMD_DRV_LOG(DEBUG, "Initializing system time counter with realtime\n");
+
+       /* Updating the counter once with clock real time */
+       clock_gettime(CLOCK_REALTIME, &timestamp);
+       nsec = rte_timespec_to_ns(&timestamp);
+       nsec = rte_timecounter_update(&pdata->systime_tc, nsec);
+       axgbe_set_tstamp_time(pdata, timestamp.tv_sec, timestamp.tv_nsec);
+       return 0;
+}
+
+static int
+axgbe_timesync_disable(struct rte_eth_dev *dev)
+{
+       struct axgbe_port *pdata = dev->data->dev_private;
+       unsigned int mac_tscr = 0;
+
+       /*disable timestamp for all pkts*/
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSENALL, 0);
+       /*disable the addened register*/
+       AXGMAC_IOWRITE_BITS(pdata, MAC_TSCR, TSADDREG, 0);
+       /* disable timestamp update */
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSCFUPDT, 0);
+       /*disable time stamp*/
+       AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSENA, 0);
+       return 0;
+}
+
+static int
+axgbe_timesync_read_rx_timestamp(struct rte_eth_dev *dev,
+                               struct timespec *timestamp, uint32_t flags)
+{
+       uint64_t nsec = 0;
+       volatile union axgbe_rx_desc *desc;
+       uint16_t idx, pmt;
+       struct axgbe_rx_queue *rxq = *dev->data->rx_queues;
+
+       idx = AXGBE_GET_DESC_IDX(rxq, rxq->cur);
+       desc = &rxq->desc[idx];
+
+       while (AXGMAC_GET_BITS_LE(desc->write.desc3, RX_NORMAL_DESC3, OWN))
+               rte_delay_ms(1);
+       if (AXGMAC_GET_BITS_LE(desc->write.desc3, RX_NORMAL_DESC3, CTXT)) {
+               if (AXGMAC_GET_BITS_LE(desc->write.desc3, RX_CONTEXT_DESC3, TSA) &&
+                               !AXGMAC_GET_BITS_LE(desc->write.desc3,
+                                       RX_CONTEXT_DESC3, TSD)) {
+                       pmt = AXGMAC_GET_BITS_LE(desc->write.desc3,
+                                       RX_CONTEXT_DESC3, PMT);
+                       nsec = rte_le_to_cpu_32(desc->write.desc1);
+                       nsec *= NSEC_PER_SEC;
+                       nsec += rte_le_to_cpu_32(desc->write.desc0);
+                       if (nsec != 0xffffffffffffffffULL) {
+                               if (pmt == 0x01)
+                                       *timestamp = rte_ns_to_timespec(nsec);
+                               PMD_DRV_LOG(DEBUG,
+                                       "flags = 0x%x nsec = %"PRIu64"\n",
+                                       flags, nsec);
+                       }
+               }
+       }
+
+       return 0;
+}
+
+static int
+axgbe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
+                               struct timespec *timestamp)
+{
+       uint64_t nsec;
+       struct axgbe_port *pdata = dev->data->dev_private;
+       unsigned int tx_snr, tx_ssr;
+
+       rte_delay_us(5);
+       if (pdata->vdata->tx_tstamp_workaround) {
+               tx_snr = AXGMAC_IOREAD(pdata, MAC_TXSNR);
+               tx_ssr = AXGMAC_IOREAD(pdata, MAC_TXSSR);
+
+       } else {
+               tx_ssr = AXGMAC_IOREAD(pdata, MAC_TXSSR);
+               tx_snr = AXGMAC_IOREAD(pdata, MAC_TXSNR);
+       }
+       if (AXGMAC_GET_BITS(tx_snr, MAC_TXSNR, TXTSSTSMIS)) {
+               PMD_DRV_LOG(DEBUG, "Waiting for TXTSSTSMIS\n");
+               return 0;
+       }
+       nsec = tx_ssr;
+       nsec *= NSEC_PER_SEC;
+       nsec += tx_snr;
+       PMD_DRV_LOG(DEBUG, "nsec = %"PRIu64" tx_ssr = %d tx_snr = %d\n",
+                       nsec, tx_ssr, tx_snr);
+       *timestamp = rte_ns_to_timespec(nsec);
+       return 0;
+}
+
+static int
+axgbe_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on)
+{
+       struct axgbe_port *pdata = dev->data->dev_private;
+       unsigned long vid_bit, vid_idx;
+
+       vid_bit = VLAN_TABLE_BIT(vid);
+       vid_idx = VLAN_TABLE_IDX(vid);
+
+       if (on) {
+               PMD_DRV_LOG(DEBUG, "Set VLAN vid=%d for device = %s\n",
+                           vid, pdata->eth_dev->device->name);
+               pdata->active_vlans[vid_idx] |= vid_bit;
+       } else {
+               PMD_DRV_LOG(DEBUG, "Reset VLAN vid=%d for device = %s\n",
+                           vid, pdata->eth_dev->device->name);
+               pdata->active_vlans[vid_idx] &= ~vid_bit;
+       }
+       pdata->hw_if.update_vlan_hash_table(pdata);
+       return 0;
+}
+
+static int
+axgbe_vlan_tpid_set(struct rte_eth_dev *dev,
+                   enum rte_vlan_type vlan_type,
+                   uint16_t tpid)
+{
+       struct axgbe_port *pdata = dev->data->dev_private;
+       uint32_t reg = 0;
+       uint32_t qinq = 0;
+
+       qinq = AXGMAC_IOREAD_BITS(pdata, MAC_VLANTR, EDVLP);
+       PMD_DRV_LOG(DEBUG, "EDVLP: qinq = 0x%x\n", qinq);
+
+       switch (vlan_type) {
+       case ETH_VLAN_TYPE_INNER:
+               PMD_DRV_LOG(DEBUG, "ETH_VLAN_TYPE_INNER\n");
+               if (qinq) {
+                       if (tpid != 0x8100 && tpid != 0x88a8)
+                               PMD_DRV_LOG(ERR,
+                                           "tag supported 0x8100/0x88A8\n");
+                       PMD_DRV_LOG(DEBUG, "qinq with inner tag\n");
+
+                       /*Enable Inner VLAN Tag */
+                       AXGMAC_IOWRITE_BITS(pdata, MAC_VLANTR, ERIVLT, 1);
+                       reg = AXGMAC_IOREAD_BITS(pdata, MAC_VLANTR, ERIVLT);
+                       PMD_DRV_LOG(DEBUG, "bit ERIVLT = 0x%x\n", reg);
+
+               } else {
+                       PMD_DRV_LOG(ERR,
+                                   "Inner type not supported in single tag\n");
+               }
+               break;
+       case ETH_VLAN_TYPE_OUTER:
+               PMD_DRV_LOG(DEBUG, "ETH_VLAN_TYPE_OUTER\n");
+               if (qinq) {
+                       PMD_DRV_LOG(DEBUG, "double tagging is enabled\n");
+                       /*Enable outer VLAN tag*/
+                       AXGMAC_IOWRITE_BITS(pdata, MAC_VLANTR, ERIVLT, 0);
+                       reg = AXGMAC_IOREAD_BITS(pdata, MAC_VLANTR, ERIVLT);
+                       PMD_DRV_LOG(DEBUG, "bit ERIVLT = 0x%x\n", reg);
+
+                       AXGMAC_IOWRITE_BITS(pdata, MAC_VLANIR, CSVL, 1);
+                       reg = AXGMAC_IOREAD_BITS(pdata, MAC_VLANIR, CSVL);
+                       PMD_DRV_LOG(DEBUG, "bit CSVL = 0x%x\n", reg);
+               } else {
+                       if (tpid != 0x8100 && tpid != 0x88a8)
+                               PMD_DRV_LOG(ERR,
+                                           "tag supported 0x8100/0x88A8\n");
+               }
+               break;
+       case ETH_VLAN_TYPE_MAX:
+               PMD_DRV_LOG(ERR, "ETH_VLAN_TYPE_MAX\n");
+               break;
+       case ETH_VLAN_TYPE_UNKNOWN:
+               PMD_DRV_LOG(ERR, "ETH_VLAN_TYPE_UNKNOWN\n");
+               break;
+       }
+       return 0;
+}
+
+static void axgbe_vlan_extend_enable(struct axgbe_port *pdata)
+{
+       int qinq = 0;
+
+       AXGMAC_IOWRITE_BITS(pdata, MAC_VLANTR, EDVLP, 1);
+       qinq = AXGMAC_IOREAD_BITS(pdata, MAC_VLANTR, EDVLP);
+       PMD_DRV_LOG(DEBUG, "vlan double tag enabled EDVLP:qinq=0x%x\n", qinq);
+}
+
+static void axgbe_vlan_extend_disable(struct axgbe_port *pdata)
+{
+       int qinq = 0;
+
+       AXGMAC_IOWRITE_BITS(pdata, MAC_VLANTR, EDVLP, 0);
+       qinq = AXGMAC_IOREAD_BITS(pdata, MAC_VLANTR, EDVLP);
+       PMD_DRV_LOG(DEBUG, "vlan double tag disable EDVLP:qinq=0x%x\n", qinq);
+}
+
+static int
+axgbe_vlan_offload_set(struct rte_eth_dev *dev, int mask)
+{
+       struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
+       struct axgbe_port *pdata = dev->data->dev_private;
+
+       /* Indicate that VLAN Tx CTAGs come from context descriptors */
+       AXGMAC_IOWRITE_BITS(pdata, MAC_VLANIR, CSVL, 0);
+       AXGMAC_IOWRITE_BITS(pdata, MAC_VLANIR, VLTI, 1);
+
+       if (mask & ETH_VLAN_STRIP_MASK) {
+               if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) {
+                       PMD_DRV_LOG(DEBUG, "Strip ON for device = %s\n",
+                                   pdata->eth_dev->device->name);
+                       pdata->hw_if.enable_rx_vlan_stripping(pdata);
+               } else {
+                       PMD_DRV_LOG(DEBUG, "Strip OFF for device = %s\n",
+                                   pdata->eth_dev->device->name);
+                       pdata->hw_if.disable_rx_vlan_stripping(pdata);
+               }
+       }
+       if (mask & ETH_VLAN_FILTER_MASK) {
+               if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) {
+                       PMD_DRV_LOG(DEBUG, "Filter ON for device = %s\n",
+                                   pdata->eth_dev->device->name);
+                       pdata->hw_if.enable_rx_vlan_filtering(pdata);
+               } else {
+                       PMD_DRV_LOG(DEBUG, "Filter OFF for device = %s\n",
+                                   pdata->eth_dev->device->name);
+                       pdata->hw_if.disable_rx_vlan_filtering(pdata);
+               }
+       }
+       if (mask & ETH_VLAN_EXTEND_MASK) {
+               if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND) {
+                       PMD_DRV_LOG(DEBUG, "enabling vlan extended mode\n");
+                       axgbe_vlan_extend_enable(pdata);
+                       /* Set global registers with default ethertype*/
+                       axgbe_vlan_tpid_set(dev, ETH_VLAN_TYPE_OUTER,
+                                           RTE_ETHER_TYPE_VLAN);
+                       axgbe_vlan_tpid_set(dev, ETH_VLAN_TYPE_INNER,
+                                           RTE_ETHER_TYPE_VLAN);
+               } else {
+                       PMD_DRV_LOG(DEBUG, "disabling vlan extended mode\n");
+                       axgbe_vlan_extend_disable(pdata);
+               }
+       }
+       return 0;
+}
+
 static void axgbe_get_all_hw_features(struct axgbe_port *pdata)
 {
-       unsigned int mac_hfr0, mac_hfr1, mac_hfr2;
+       unsigned int mac_hfr0, mac_hfr1, mac_hfr2, mac_hfr3;
        struct axgbe_hw_features *hw_feat = &pdata->hw_feat;
 
        mac_hfr0 = AXGMAC_IOREAD(pdata, MAC_HWF0R);
        mac_hfr1 = AXGMAC_IOREAD(pdata, MAC_HWF1R);
        mac_hfr2 = AXGMAC_IOREAD(pdata, MAC_HWF2R);
+       mac_hfr3 = AXGMAC_IOREAD(pdata, MAC_HWF3R);
 
        memset(hw_feat, 0, sizeof(*hw_feat));
 
@@ -1484,6 +2015,12 @@ static void axgbe_get_all_hw_features(struct axgbe_port *pdata)
        hw_feat->aux_snap_num = AXGMAC_GET_BITS(mac_hfr2, MAC_HWF2R,
                                                AUXSNAPNUM);
 
+       /* Hardware feature register 3 */
+       hw_feat->tx_q_vlan_tag_ins  = AXGMAC_GET_BITS(mac_hfr3,
+                                                     MAC_HWF3R, CBTISEL);
+       hw_feat->no_of_vlan_extn    = AXGMAC_GET_BITS(mac_hfr3,
+                                                     MAC_HWF3R, NRVF);
+
        /* Translate the Hash Table size into actual number */
        switch (hw_feat->hash_table_size) {
        case 0:
@@ -1632,6 +2169,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
 
        eth_dev->dev_ops = &axgbe_eth_dev_ops;
 
+       eth_dev->rx_descriptor_status = axgbe_dev_rx_descriptor_status;
+       eth_dev->tx_descriptor_status = axgbe_dev_tx_descriptor_status;
+
        /*
         * For secondary processes, we don't initialise any further as primary
         * has already done this work.
@@ -1639,6 +2179,8 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)
                return 0;
 
+       eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+
        pdata = eth_dev->data->dev_private;
        /* initial state */
        rte_bit_relaxed_set32(AXGBE_DOWN, &pdata->dev_state);
@@ -1793,7 +2335,7 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
 }
 
 static int
-eth_axgbe_dev_uninit(struct rte_eth_dev *eth_dev)
+axgbe_dev_close(struct rte_eth_dev *eth_dev)
 {
        struct rte_pci_device *pci_dev;
 
@@ -1803,9 +2345,6 @@ eth_axgbe_dev_uninit(struct rte_eth_dev *eth_dev)
                return 0;
 
        pci_dev = RTE_DEV_TO_PCI(eth_dev->device);
-       eth_dev->dev_ops = NULL;
-       eth_dev->rx_pkt_burst = NULL;
-       eth_dev->tx_pkt_burst = NULL;
        axgbe_dev_clear_queues(eth_dev);
 
        /* disable uio intr before callback unregister */
@@ -1826,7 +2365,7 @@ static int eth_axgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 
 static int eth_axgbe_pci_remove(struct rte_pci_device *pci_dev)
 {
-       return rte_eth_dev_pci_generic_remove(pci_dev, eth_axgbe_dev_uninit);
+       return rte_eth_dev_pci_generic_remove(pci_dev, axgbe_dev_close);
 }
 
 static struct rte_pci_driver rte_axgbe_pmd = {
@@ -1839,5 +2378,5 @@ static struct rte_pci_driver rte_axgbe_pmd = {
 RTE_PMD_REGISTER_PCI(net_axgbe, rte_axgbe_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_axgbe, pci_id_axgbe_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_axgbe, "* igb_uio | uio_pci_generic | vfio-pci");
-RTE_LOG_REGISTER(axgbe_logtype_init, pmd.net.axgbe.init, NOTICE);
-RTE_LOG_REGISTER(axgbe_logtype_driver, pmd.net.axgbe.driver, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(axgbe_logtype_init, init, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(axgbe_logtype_driver, driver, NOTICE);