net: add macro for MAC address print
[dpdk.git] / drivers / net / bnx2x / bnx2x.c
index 0b4030e..9163b8b 100644 (file)
 
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <arpa/inet.h>
 #include <fcntl.h>
 #include <zlib.h>
+
+#include <rte_bitops.h>
 #include <rte_string_fns.h>
 
+#include "eal_firmware.h"
+
 #define BNX2X_PMD_VER_PREFIX "BNX2X PMD"
 #define BNX2X_PMD_VERSION_MAJOR 1
 #define BNX2X_PMD_VERSION_MINOR 1
@@ -129,32 +134,6 @@ static void bnx2x_ack_sb(struct bnx2x_softc *sc, uint8_t igu_sb_id,
                         uint8_t storm, uint16_t index, uint8_t op,
                         uint8_t update);
 
-int bnx2x_test_bit(int nr, volatile unsigned long *addr)
-{
-       int res;
-
-       mb();
-       res = ((*addr) & (1UL << nr)) != 0;
-       mb();
-       return res;
-}
-
-void bnx2x_set_bit(unsigned int nr, volatile unsigned long *addr)
-{
-       __sync_fetch_and_or(addr, (1UL << nr));
-}
-
-void bnx2x_clear_bit(int nr, volatile unsigned long *addr)
-{
-       __sync_fetch_and_and(addr, ~(1UL << nr));
-}
-
-int bnx2x_test_and_clear_bit(int nr, volatile unsigned long *addr)
-{
-       unsigned long mask = (1UL << nr);
-       return __sync_fetch_and_and(addr, ~mask) & mask;
-}
-
 int bnx2x_cmpxchg(volatile int *addr, int old, int new)
 {
        return __sync_val_compare_and_swap(addr, old, new);
@@ -1434,16 +1413,16 @@ static int
 bnx2x_del_all_macs(struct bnx2x_softc *sc, struct ecore_vlan_mac_obj *mac_obj,
                 int mac_type, uint8_t wait_for_comp)
 {
-       unsigned long ramrod_flags = 0, vlan_mac_flags = 0;
+       uint32_t ramrod_flags = 0, vlan_mac_flags = 0;
        int rc;
 
        /* wait for completion of requested */
        if (wait_for_comp) {
-               bnx2x_set_bit(RAMROD_COMP_WAIT, &ramrod_flags);
+               rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &ramrod_flags);
        }
 
        /* Set the mac type of addresses we want to clear */
-       bnx2x_set_bit(mac_type, &vlan_mac_flags);
+       rte_bit_relaxed_set32(mac_type, &vlan_mac_flags);
 
        rc = mac_obj->delete_all(sc, mac_obj, &vlan_mac_flags, &ramrod_flags);
        if (rc < 0)
@@ -1454,8 +1433,7 @@ bnx2x_del_all_macs(struct bnx2x_softc *sc, struct ecore_vlan_mac_obj *mac_obj,
 
 static int
 bnx2x_fill_accept_flags(struct bnx2x_softc *sc, uint32_t rx_mode,
-                       unsigned long *rx_accept_flags,
-                       unsigned long *tx_accept_flags)
+                       uint32_t *rx_accept_flags, uint32_t *tx_accept_flags)
 {
        /* Clear the flags first */
        *rx_accept_flags = 0;
@@ -1470,26 +1448,28 @@ bnx2x_fill_accept_flags(struct bnx2x_softc *sc, uint32_t rx_mode,
                break;
 
        case BNX2X_RX_MODE_NORMAL:
-               bnx2x_set_bit(ECORE_ACCEPT_UNICAST, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_MULTICAST, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_BROADCAST, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_UNICAST, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_MULTICAST, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_BROADCAST, rx_accept_flags);
 
                /* internal switching mode */
-               bnx2x_set_bit(ECORE_ACCEPT_UNICAST, tx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_MULTICAST, tx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_BROADCAST, tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_UNICAST, tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_MULTICAST, tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_BROADCAST, tx_accept_flags);
 
                break;
 
        case BNX2X_RX_MODE_ALLMULTI:
-               bnx2x_set_bit(ECORE_ACCEPT_UNICAST, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_ALL_MULTICAST, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_BROADCAST, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_UNICAST, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_ALL_MULTICAST,
+                                     rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_BROADCAST, rx_accept_flags);
 
                /* internal switching mode */
-               bnx2x_set_bit(ECORE_ACCEPT_UNICAST, tx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_ALL_MULTICAST, tx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_BROADCAST, tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_UNICAST, tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_ALL_MULTICAST,
+                                     tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_BROADCAST, tx_accept_flags);
 
                break;
 
@@ -1500,19 +1480,23 @@ bnx2x_fill_accept_flags(struct bnx2x_softc *sc, uint32_t rx_mode,
                 * should receive matched and unmatched (in resolution of port)
                 * unicast packets.
                 */
-               bnx2x_set_bit(ECORE_ACCEPT_UNMATCHED, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_UNICAST, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_ALL_MULTICAST, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_BROADCAST, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_UNMATCHED, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_UNICAST, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_ALL_MULTICAST,
+                                     rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_BROADCAST, rx_accept_flags);
 
                /* internal switching mode */
-               bnx2x_set_bit(ECORE_ACCEPT_ALL_MULTICAST, tx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_BROADCAST, tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_ALL_MULTICAST,
+                                     tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_BROADCAST, tx_accept_flags);
 
                if (IS_MF_SI(sc)) {
-                       bnx2x_set_bit(ECORE_ACCEPT_ALL_UNICAST, tx_accept_flags);
+                       rte_bit_relaxed_set32(ECORE_ACCEPT_ALL_UNICAST,
+                                       tx_accept_flags);
                } else {
-                       bnx2x_set_bit(ECORE_ACCEPT_UNICAST, tx_accept_flags);
+                       rte_bit_relaxed_set32(ECORE_ACCEPT_UNICAST,
+                                             tx_accept_flags);
                }
 
                break;
@@ -1524,8 +1508,8 @@ bnx2x_fill_accept_flags(struct bnx2x_softc *sc, uint32_t rx_mode,
 
        /* Set ACCEPT_ANY_VLAN as we do not enable filtering by VLAN */
        if (rx_mode != BNX2X_RX_MODE_NONE) {
-               bnx2x_set_bit(ECORE_ACCEPT_ANY_VLAN, rx_accept_flags);
-               bnx2x_set_bit(ECORE_ACCEPT_ANY_VLAN, tx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_ANY_VLAN, rx_accept_flags);
+               rte_bit_relaxed_set32(ECORE_ACCEPT_ANY_VLAN, tx_accept_flags);
        }
 
        return 0;
@@ -1554,7 +1538,7 @@ bnx2x_set_q_rx_mode(struct bnx2x_softc *sc, uint8_t cl_id,
        ramrod_param.rdata = BNX2X_SP(sc, rx_mode_rdata);
        ramrod_param.rdata_mapping =
            (rte_iova_t)BNX2X_SP_MAPPING(sc, rx_mode_rdata),
-           bnx2x_set_bit(ECORE_FILTER_RX_MODE_PENDING, &sc->sp_state);
+           rte_bit_relaxed_set32(ECORE_FILTER_RX_MODE_PENDING, &sc->sp_state);
 
        ramrod_param.ramrod_flags = ramrod_flags;
        ramrod_param.rx_mode_flags = rx_mode_flags;
@@ -1573,8 +1557,8 @@ bnx2x_set_q_rx_mode(struct bnx2x_softc *sc, uint8_t cl_id,
 
 int bnx2x_set_storm_rx_mode(struct bnx2x_softc *sc)
 {
-       unsigned long rx_mode_flags = 0, ramrod_flags = 0;
-       unsigned long rx_accept_flags = 0, tx_accept_flags = 0;
+       uint32_t rx_mode_flags = 0, ramrod_flags = 0;
+       uint32_t rx_accept_flags = 0, tx_accept_flags = 0;
        int rc;
 
        rc = bnx2x_fill_accept_flags(sc, sc->rx_mode, &rx_accept_flags,
@@ -1583,9 +1567,9 @@ int bnx2x_set_storm_rx_mode(struct bnx2x_softc *sc)
                return rc;
        }
 
-       bnx2x_set_bit(RAMROD_RX, &ramrod_flags);
-       bnx2x_set_bit(RAMROD_TX, &ramrod_flags);
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_RX, &ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_TX, &ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &ramrod_flags);
 
        return bnx2x_set_q_rx_mode(sc, sc->fp[0].cl_id, rx_mode_flags,
                                 rx_accept_flags, tx_accept_flags,
@@ -1710,7 +1694,8 @@ static int bnx2x_func_wait_started(struct bnx2x_softc *sc)
                            "Forcing STARTED-->TX_STOPPED-->STARTED");
 
                func_params.f_obj = &sc->func_obj;
-               bnx2x_set_bit(RAMROD_DRV_CLR_ONLY, &func_params.ramrod_flags);
+               rte_bit_relaxed_set32(RAMROD_DRV_CLR_ONLY,
+                                     &func_params.ramrod_flags);
 
                /* STARTED-->TX_STOPPED */
                func_params.cmd = ECORE_F_CMD_TX_STOP;
@@ -1734,7 +1719,7 @@ static int bnx2x_stop_queue(struct bnx2x_softc *sc, int index)
 
        q_params.q_obj = &sc->sp_objs[fp->index].q_obj;
        /* We want to wait for completion in this context */
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &q_params.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &q_params.ramrod_flags);
 
        /* Stop the primary connection: */
 
@@ -1763,26 +1748,25 @@ static int bnx2x_stop_queue(struct bnx2x_softc *sc, int index)
 }
 
 /* wait for the outstanding SP commands */
-static uint8_t bnx2x_wait_sp_comp(struct bnx2x_softc *sc, unsigned long mask)
+static uint8_t bnx2x_wait_sp_comp(struct bnx2x_softc *sc, uint32_t mask)
 {
-       unsigned long tmp;
+       uint32_t tmp;
        int tout = 5000;        /* wait for 5 secs tops */
 
        while (tout--) {
                mb();
-               if (!(atomic_load_acq_long(&sc->sp_state) & mask)) {
+               if (!(atomic_load_acq_int(&sc->sp_state) & mask))
                        return TRUE;
-               }
 
                DELAY(1000);
        }
 
        mb();
 
-       tmp = atomic_load_acq_long(&sc->sp_state);
+       tmp = atomic_load_acq_int(&sc->sp_state);
        if (tmp & mask) {
                PMD_DRV_LOG(INFO, sc, "Filtering completion timed out: "
-                           "sp_state 0x%lx, mask 0x%lx", tmp, mask);
+                           "sp_state 0x%x, mask 0x%x", tmp, mask);
                return FALSE;
        }
 
@@ -1795,7 +1779,7 @@ static int bnx2x_func_stop(struct bnx2x_softc *sc)
        int rc;
 
        /* prepare parameters for function state transitions */
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
        func_params.f_obj = &sc->func_obj;
        func_params.cmd = ECORE_F_CMD_STOP;
 
@@ -1809,7 +1793,8 @@ static int bnx2x_func_stop(struct bnx2x_softc *sc)
        if (rc) {
                PMD_DRV_LOG(NOTICE, sc, "FUNC_STOP ramrod failed. "
                            "Running a dry transaction");
-               bnx2x_set_bit(RAMROD_DRV_CLR_ONLY, &func_params.ramrod_flags);
+               rte_bit_relaxed_set32(RAMROD_DRV_CLR_ONLY,
+                                     &func_params.ramrod_flags);
                return ecore_func_state_change(sc, &func_params);
        }
 
@@ -1821,7 +1806,7 @@ static int bnx2x_reset_hw(struct bnx2x_softc *sc, uint32_t load_code)
        struct ecore_func_state_params func_params = { NULL };
 
        /* Prepare parameters for function state transitions */
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
 
        func_params.f_obj = &sc->func_obj;
        func_params.cmd = ECORE_F_CMD_HW_RESET;
@@ -1878,11 +1863,11 @@ bnx2x_chip_cleanup(struct bnx2x_softc *sc, uint32_t unload_mode, uint8_t keep_li
         * a race between the completion code and this code.
         */
 
-       if (bnx2x_test_bit(ECORE_FILTER_RX_MODE_PENDING, &sc->sp_state)) {
-               bnx2x_set_bit(ECORE_FILTER_RX_MODE_SCHED, &sc->sp_state);
-       } else {
+       if (rte_bit_relaxed_get32(ECORE_FILTER_RX_MODE_PENDING, &sc->sp_state))
+               rte_bit_relaxed_set32(ECORE_FILTER_RX_MODE_SCHED,
+                                     &sc->sp_state);
+       else
                bnx2x_set_storm_rx_mode(sc);
-       }
 
        /* Clean up multicast configuration */
        rparam.mcast_obj = &sc->mcast_obj;
@@ -1922,9 +1907,8 @@ bnx2x_chip_cleanup(struct bnx2x_softc *sc, uint32_t unload_mode, uint8_t keep_li
         * If SP settings didn't get completed so far - something
         * very wrong has happen.
         */
-       if (!bnx2x_wait_sp_comp(sc, ~0x0UL)) {
+       if (!bnx2x_wait_sp_comp(sc, ~0x0U))
                PMD_DRV_LOG(NOTICE, sc, "Common slow path ramrods got stuck!");
-       }
 
 unload_error:
 
@@ -1964,7 +1948,7 @@ static void bnx2x_disable_close_the_gate(struct bnx2x_softc *sc)
  */
 static void bnx2x_squeeze_objects(struct bnx2x_softc *sc)
 {
-       unsigned long ramrod_flags = 0, vlan_mac_flags = 0;
+       uint32_t ramrod_flags = 0, vlan_mac_flags = 0;
        struct ecore_mcast_ramrod_params rparam = { NULL };
        struct ecore_vlan_mac_obj *mac_obj = &sc->sp_objs->mac_obj;
        int rc;
@@ -1972,12 +1956,12 @@ static void bnx2x_squeeze_objects(struct bnx2x_softc *sc)
        /* Cleanup MACs' object first... */
 
        /* Wait for completion of requested */
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &ramrod_flags);
        /* Perform a dry cleanup */
-       bnx2x_set_bit(RAMROD_DRV_CLR_ONLY, &ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_DRV_CLR_ONLY, &ramrod_flags);
 
        /* Clean ETH primary MAC */
-       bnx2x_set_bit(ECORE_ETH_MAC, &vlan_mac_flags);
+       rte_bit_relaxed_set32(ECORE_ETH_MAC, &vlan_mac_flags);
        rc = mac_obj->delete_all(sc, &sc->sp_objs->mac_obj, &vlan_mac_flags,
                                 &ramrod_flags);
        if (rc != 0) {
@@ -1986,7 +1970,7 @@ static void bnx2x_squeeze_objects(struct bnx2x_softc *sc)
 
        /* Cleanup UC list */
        vlan_mac_flags = 0;
-       bnx2x_set_bit(ECORE_UC_LIST_MAC, &vlan_mac_flags);
+       rte_bit_relaxed_set32(ECORE_UC_LIST_MAC, &vlan_mac_flags);
        rc = mac_obj->delete_all(sc, mac_obj, &vlan_mac_flags, &ramrod_flags);
        if (rc != 0) {
                PMD_DRV_LOG(NOTICE, sc,
@@ -1996,7 +1980,7 @@ static void bnx2x_squeeze_objects(struct bnx2x_softc *sc)
        /* Now clean mcast object... */
 
        rparam.mcast_obj = &sc->mcast_obj;
-       bnx2x_set_bit(RAMROD_DRV_CLR_ONLY, &rparam.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_DRV_CLR_ONLY, &rparam.ramrod_flags);
 
        /* Add a DEL command... */
        rc = ecore_config_mcast(sc, &rparam, ECORE_MCAST_CMD_DEL);
@@ -2216,11 +2200,27 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf *m0)
                        tx_start_bd->vlan_or_ethertype =
                            rte_cpu_to_le_16(pkt_prod);
                else {
+                       /* when transmitting in a vf, start bd
+                        * must hold the ethertype for fw to enforce it
+                        */
                        struct rte_ether_hdr *eh =
                            rte_pktmbuf_mtod(m0, struct rte_ether_hdr *);
 
-                       tx_start_bd->vlan_or_ethertype =
-                           rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type));
+                       /* Still need to consider inband vlan for enforced */
+                       if (eh->ether_type ==
+                                       rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) {
+                               struct rte_vlan_hdr *vh =
+                                       (struct rte_vlan_hdr *)(eh + 1);
+                               tx_start_bd->bd_flags.as_bitfield |=
+                                       (X_ETH_INBAND_VLAN <<
+                                       ETH_TX_BD_FLAGS_VLAN_MODE_SHIFT);
+                               tx_start_bd->vlan_or_ethertype =
+                                       rte_cpu_to_le_16(ntohs(vh->vlan_tci));
+                       } else {
+                               tx_start_bd->vlan_or_ethertype =
+                                       (rte_cpu_to_le_16
+                                       (rte_be_to_cpu_16(eh->ether_type)));
+                       }
                }
        }
 
@@ -4294,13 +4294,13 @@ static void bnx2x_handle_mcast_eqe(struct bnx2x_softc *sc)
 static void
 bnx2x_handle_classification_eqe(struct bnx2x_softc *sc, union event_ring_elem *elem)
 {
-       unsigned long ramrod_flags = 0;
+       uint32_t ramrod_flags = 0;
        int rc = 0;
        uint32_t cid = elem->message.data.eth_event.echo & BNX2X_SWCID_MASK;
        struct ecore_vlan_mac_obj *vlan_mac_obj;
 
        /* always push next commands out, don't wait here */
-       bnx2x_set_bit(RAMROD_CONT, &ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_CONT, &ramrod_flags);
 
        switch (le32toh(elem->message.data.eth_event.echo) >> BNX2X_SWCID_SHIFT) {
        case ECORE_FILTER_MAC_PENDING:
@@ -4331,12 +4331,12 @@ bnx2x_handle_classification_eqe(struct bnx2x_softc *sc, union event_ring_elem *e
 
 static void bnx2x_handle_rx_mode_eqe(struct bnx2x_softc *sc)
 {
-       bnx2x_clear_bit(ECORE_FILTER_RX_MODE_PENDING, &sc->sp_state);
+       rte_bit_relaxed_clear32(ECORE_FILTER_RX_MODE_PENDING, &sc->sp_state);
 
        /* send rx_mode command again if was requested */
-       if (bnx2x_test_and_clear_bit(ECORE_FILTER_RX_MODE_SCHED, &sc->sp_state)) {
+       if (rte_bit_relaxed_test_and_clear32(ECORE_FILTER_RX_MODE_SCHED,
+                                               &sc->sp_state))
                bnx2x_set_storm_rx_mode(sc);
-       }
 }
 
 static void bnx2x_update_eq_prod(struct bnx2x_softc *sc, uint16_t prod)
@@ -4705,7 +4705,7 @@ static int bnx2x_init_hw(struct bnx2x_softc *sc, uint32_t load_code)
        PMD_INIT_FUNC_TRACE(sc);
 
        /* prepare the parameters for function state transitions */
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
 
        func_params.f_obj = &sc->func_obj;
        func_params.cmd = ECORE_F_CMD_HW_INIT;
@@ -4953,7 +4953,7 @@ static void bnx2x_init_eth_fp(struct bnx2x_softc *sc, int idx)
 {
        struct bnx2x_fastpath *fp = &sc->fp[idx];
        uint32_t cids[ECORE_MULTI_TX_COS] = { 0 };
-       unsigned long q_type = 0;
+       uint32_t q_type = 0;
        int cos;
 
        fp->sc = sc;
@@ -5000,8 +5000,8 @@ static void bnx2x_init_eth_fp(struct bnx2x_softc *sc, int idx)
        bnx2x_update_fp_sb_idx(fp);
 
        /* Configure Queue State object */
-       bnx2x_set_bit(ECORE_Q_TYPE_HAS_RX, &q_type);
-       bnx2x_set_bit(ECORE_Q_TYPE_HAS_TX, &q_type);
+       rte_bit_relaxed_set32(ECORE_Q_TYPE_HAS_RX, &q_type);
+       rte_bit_relaxed_set32(ECORE_Q_TYPE_HAS_TX, &q_type);
 
        ecore_init_queue_obj(sc,
                             &sc->sp_objs[idx].q_obj,
@@ -5815,7 +5815,7 @@ static int bnx2x_func_start(struct bnx2x_softc *sc)
            &func_params.params.start;
 
        /* Prepare parameters for function state transitions */
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
 
        func_params.f_obj = &sc->func_obj;
        func_params.cmd = ECORE_F_CMD_START;
@@ -6391,11 +6391,11 @@ bnx2x_pf_q_prep_init(struct bnx2x_softc *sc, struct bnx2x_fastpath *fp,
        uint8_t cos;
        int cxt_index, cxt_offset;
 
-       bnx2x_set_bit(ECORE_Q_FLG_HC, &init_params->rx.flags);
-       bnx2x_set_bit(ECORE_Q_FLG_HC, &init_params->tx.flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_HC, &init_params->rx.flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_HC, &init_params->tx.flags);
 
-       bnx2x_set_bit(ECORE_Q_FLG_HC_EN, &init_params->rx.flags);
-       bnx2x_set_bit(ECORE_Q_FLG_HC_EN, &init_params->tx.flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_HC_EN, &init_params->rx.flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_HC_EN, &init_params->tx.flags);
 
        /* HC rate */
        init_params->rx.hc_rate =
@@ -6426,10 +6426,10 @@ bnx2x_pf_q_prep_init(struct bnx2x_softc *sc, struct bnx2x_fastpath *fp,
 static unsigned long
 bnx2x_get_common_flags(struct bnx2x_softc *sc, uint8_t zero_stats)
 {
-       unsigned long flags = 0;
+       uint32_t flags = 0;
 
        /* PF driver will always initialize the Queue to an ACTIVE state */
-       bnx2x_set_bit(ECORE_Q_FLG_ACTIVE, &flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_ACTIVE, &flags);
 
        /*
         * tx only connections collect statistics (on the same index as the
@@ -6437,9 +6437,9 @@ bnx2x_get_common_flags(struct bnx2x_softc *sc, uint8_t zero_stats)
         * connection is initialized.
         */
 
-       bnx2x_set_bit(ECORE_Q_FLG_STATS, &flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_STATS, &flags);
        if (zero_stats) {
-               bnx2x_set_bit(ECORE_Q_FLG_ZERO_STATS, &flags);
+               rte_bit_relaxed_set32(ECORE_Q_FLG_ZERO_STATS, &flags);
        }
 
        /*
@@ -6447,28 +6447,28 @@ bnx2x_get_common_flags(struct bnx2x_softc *sc, uint8_t zero_stats)
         * CoS-ness doesn't survive the loopback
         */
        if (sc->flags & BNX2X_TX_SWITCHING) {
-               bnx2x_set_bit(ECORE_Q_FLG_TX_SWITCH, &flags);
+               rte_bit_relaxed_set32(ECORE_Q_FLG_TX_SWITCH, &flags);
        }
 
-       bnx2x_set_bit(ECORE_Q_FLG_PCSUM_ON_PKT, &flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_PCSUM_ON_PKT, &flags);
 
        return flags;
 }
 
 static unsigned long bnx2x_get_q_flags(struct bnx2x_softc *sc, uint8_t leading)
 {
-       unsigned long flags = 0;
+       uint32_t flags = 0;
 
        if (IS_MF_SD(sc)) {
-               bnx2x_set_bit(ECORE_Q_FLG_OV, &flags);
+               rte_bit_relaxed_set32(ECORE_Q_FLG_OV, &flags);
        }
 
        if (leading) {
-               bnx2x_set_bit(ECORE_Q_FLG_LEADING_RSS, &flags);
-               bnx2x_set_bit(ECORE_Q_FLG_MCAST, &flags);
+               rte_bit_relaxed_set32(ECORE_Q_FLG_LEADING_RSS, &flags);
+               rte_bit_relaxed_set32(ECORE_Q_FLG_MCAST, &flags);
        }
 
-       bnx2x_set_bit(ECORE_Q_FLG_VLAN, &flags);
+       rte_bit_relaxed_set32(ECORE_Q_FLG_VLAN, &flags);
 
        /* merge with common flags */
        return flags | bnx2x_get_common_flags(sc, TRUE);
@@ -6589,7 +6589,7 @@ bnx2x_setup_queue(struct bnx2x_softc *sc, struct bnx2x_fastpath *fp, uint8_t lea
        q_params.q_obj = &BNX2X_SP_OBJ(sc, fp).q_obj;
 
        /* we want to wait for completion in this context */
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &q_params.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &q_params.ramrod_flags);
 
        /* prepare the INIT parameters */
        bnx2x_pf_q_prep_init(sc, fp, &q_params.params.init);
@@ -6657,20 +6657,20 @@ bnx2x_config_rss_pf(struct bnx2x_softc *sc, struct ecore_rss_config_obj *rss_obj
 
        params.rss_obj = rss_obj;
 
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &params.ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &params.ramrod_flags);
 
-       bnx2x_set_bit(ECORE_RSS_MODE_REGULAR, &params.rss_flags);
+       rte_bit_relaxed_set32(ECORE_RSS_MODE_REGULAR, &params.rss_flags);
 
        /* RSS configuration */
-       bnx2x_set_bit(ECORE_RSS_IPV4, &params.rss_flags);
-       bnx2x_set_bit(ECORE_RSS_IPV4_TCP, &params.rss_flags);
-       bnx2x_set_bit(ECORE_RSS_IPV6, &params.rss_flags);
-       bnx2x_set_bit(ECORE_RSS_IPV6_TCP, &params.rss_flags);
+       rte_bit_relaxed_set32(ECORE_RSS_IPV4, &params.rss_flags);
+       rte_bit_relaxed_set32(ECORE_RSS_IPV4_TCP, &params.rss_flags);
+       rte_bit_relaxed_set32(ECORE_RSS_IPV6, &params.rss_flags);
+       rte_bit_relaxed_set32(ECORE_RSS_IPV6_TCP, &params.rss_flags);
        if (rss_obj->udp_rss_v4) {
-               bnx2x_set_bit(ECORE_RSS_IPV4_UDP, &params.rss_flags);
+               rte_bit_relaxed_set32(ECORE_RSS_IPV4_UDP, &params.rss_flags);
        }
        if (rss_obj->udp_rss_v6) {
-               bnx2x_set_bit(ECORE_RSS_IPV6_UDP, &params.rss_flags);
+               rte_bit_relaxed_set32(ECORE_RSS_IPV6_UDP, &params.rss_flags);
        }
 
        /* Hash bits */
@@ -6685,7 +6685,7 @@ bnx2x_config_rss_pf(struct bnx2x_softc *sc, struct ecore_rss_config_obj *rss_obj
                        params.rss_key[i] = (uint32_t) rte_rand();
                }
 
-               bnx2x_set_bit(ECORE_RSS_SET_SRCH, &params.rss_flags);
+               rte_bit_relaxed_set32(ECORE_RSS_SET_SRCH, &params.rss_flags);
        }
 
        if (IS_PF(sc))
@@ -6730,7 +6730,7 @@ static int bnx2x_init_rss_pf(struct bnx2x_softc *sc)
 static int
 bnx2x_set_mac_one(struct bnx2x_softc *sc, uint8_t * mac,
                struct ecore_vlan_mac_obj *obj, uint8_t set, int mac_type,
-               unsigned long *ramrod_flags)
+               uint32_t *ramrod_flags)
 {
        struct ecore_vlan_mac_ramrod_params ramrod_param;
        int rc;
@@ -6742,11 +6742,12 @@ bnx2x_set_mac_one(struct bnx2x_softc *sc, uint8_t * mac,
        ramrod_param.ramrod_flags = *ramrod_flags;
 
        /* fill a user request section if needed */
-       if (!bnx2x_test_bit(RAMROD_CONT, ramrod_flags)) {
+       if (!rte_bit_relaxed_get32(RAMROD_CONT, ramrod_flags)) {
                rte_memcpy(ramrod_param.user_req.u.mac.mac, mac,
                                 ETH_ALEN);
 
-               bnx2x_set_bit(mac_type, &ramrod_param.user_req.vlan_mac_flags);
+               rte_bit_relaxed_set32(mac_type,
+                                     &ramrod_param.user_req.vlan_mac_flags);
 
 /* Set the command: ADD or DEL */
                ramrod_param.user_req.cmd = (set) ? ECORE_VLAN_MAC_ADD :
@@ -6769,11 +6770,11 @@ bnx2x_set_mac_one(struct bnx2x_softc *sc, uint8_t * mac,
 
 static int bnx2x_set_eth_mac(struct bnx2x_softc *sc, uint8_t set)
 {
-       unsigned long ramrod_flags = 0;
+       uint32_t ramrod_flags = 0;
 
        PMD_DRV_LOG(DEBUG, sc, "Adding Ethernet MAC");
 
-       bnx2x_set_bit(RAMROD_COMP_WAIT, &ramrod_flags);
+       rte_bit_relaxed_set32(RAMROD_COMP_WAIT, &ramrod_flags);
 
        /* Eth MAC is set on RSS leading client (fp[0]) */
        return bnx2x_set_mac_one(sc, sc->link_params.mac_addr,
@@ -6905,24 +6906,26 @@ bnx2x_fill_report_data(struct bnx2x_softc *sc, struct bnx2x_link_report_data *da
 
        /* Link is down */
        if (!sc->link_vars.link_up || (sc->flags & BNX2X_MF_FUNC_DIS)) {
-               bnx2x_set_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+               rte_bit_relaxed_set32(BNX2X_LINK_REPORT_LINK_DOWN,
                            &data->link_report_flags);
        }
 
        /* Full DUPLEX */
        if (sc->link_vars.duplex == DUPLEX_FULL) {
-               bnx2x_set_bit(BNX2X_LINK_REPORT_FULL_DUPLEX,
+               rte_bit_relaxed_set32(BNX2X_LINK_REPORT_FULL_DUPLEX,
                            &data->link_report_flags);
        }
 
        /* Rx Flow Control is ON */
        if (sc->link_vars.flow_ctrl & ELINK_FLOW_CTRL_RX) {
-               bnx2x_set_bit(BNX2X_LINK_REPORT_RX_FC_ON, &data->link_report_flags);
+               rte_bit_relaxed_set32(BNX2X_LINK_REPORT_RX_FC_ON,
+                               &data->link_report_flags);
        }
 
        /* Tx Flow Control is ON */
        if (sc->link_vars.flow_ctrl & ELINK_FLOW_CTRL_TX) {
-               bnx2x_set_bit(BNX2X_LINK_REPORT_TX_FC_ON, &data->link_report_flags);
+               rte_bit_relaxed_set32(BNX2X_LINK_REPORT_TX_FC_ON,
+                               &data->link_report_flags);
        }
 }
 
@@ -6941,14 +6944,14 @@ static void bnx2x_link_report_locked(struct bnx2x_softc *sc)
 
        /* Don't report link down or exactly the same link status twice */
        if (!memcmp(&cur_data, &sc->last_reported_link, sizeof(cur_data)) ||
-           (bnx2x_test_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+           (rte_bit_relaxed_get32(BNX2X_LINK_REPORT_LINK_DOWN,
                          &sc->last_reported_link.link_report_flags) &&
-            bnx2x_test_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+            rte_bit_relaxed_get32(BNX2X_LINK_REPORT_LINK_DOWN,
                          &cur_data.link_report_flags))) {
                return;
        }
 
-       ELINK_DEBUG_P2(sc, "Change in link status : cur_data = %lx, last_reported_link = %lx",
+       ELINK_DEBUG_P2(sc, "Change in link status : cur_data = %x, last_reported_link = %x",
                       cur_data.link_report_flags,
                       sc->last_reported_link.link_report_flags);
 
@@ -6958,15 +6961,16 @@ static void bnx2x_link_report_locked(struct bnx2x_softc *sc)
        /* report new link params and remember the state for the next time */
        rte_memcpy(&sc->last_reported_link, &cur_data, sizeof(cur_data));
 
-       if (bnx2x_test_bit(BNX2X_LINK_REPORT_LINK_DOWN,
+       if (rte_bit_relaxed_get32(BNX2X_LINK_REPORT_LINK_DOWN,
                         &cur_data.link_report_flags)) {
                ELINK_DEBUG_P0(sc, "NIC Link is Down");
        } else {
                __rte_unused const char *duplex;
                __rte_unused const char *flow;
 
-               if (bnx2x_test_and_clear_bit(BNX2X_LINK_REPORT_FULL_DUPLEX,
-                                          &cur_data.link_report_flags)) {
+               if (rte_bit_relaxed_test_and_clear32
+                                       (BNX2X_LINK_REPORT_FULL_DUPLEX,
+                                        &cur_data.link_report_flags)) {
                        duplex = "full";
                                ELINK_DEBUG_P0(sc, "link set to full duplex");
                } else {
@@ -6980,20 +6984,25 @@ static void bnx2x_link_report_locked(struct bnx2x_softc *sc)
  * enabled.
  */
                if (cur_data.link_report_flags) {
-                       if (bnx2x_test_bit(BNX2X_LINK_REPORT_RX_FC_ON,
+                       if (rte_bit_relaxed_get32
+                                       (BNX2X_LINK_REPORT_RX_FC_ON,
                                         &cur_data.link_report_flags) &&
-                           bnx2x_test_bit(BNX2X_LINK_REPORT_TX_FC_ON,
+                           rte_bit_relaxed_get32(BNX2X_LINK_REPORT_TX_FC_ON,
                                         &cur_data.link_report_flags)) {
                                flow = "ON - receive & transmit";
-                       } else if (bnx2x_test_bit(BNX2X_LINK_REPORT_RX_FC_ON,
-                                               &cur_data.link_report_flags) &&
-                                  !bnx2x_test_bit(BNX2X_LINK_REPORT_TX_FC_ON,
+                       } else if (rte_bit_relaxed_get32
+                                               (BNX2X_LINK_REPORT_RX_FC_ON,
+                                                &cur_data.link_report_flags) &&
+                                  !rte_bit_relaxed_get32
+                                               (BNX2X_LINK_REPORT_TX_FC_ON,
                                                 &cur_data.link_report_flags)) {
                                flow = "ON - receive";
-                       } else if (!bnx2x_test_bit(BNX2X_LINK_REPORT_RX_FC_ON,
+                       } else if (!rte_bit_relaxed_get32
+                                               (BNX2X_LINK_REPORT_RX_FC_ON,
                                                 &cur_data.link_report_flags) &&
-                                  bnx2x_test_bit(BNX2X_LINK_REPORT_TX_FC_ON,
-                                               &cur_data.link_report_flags)) {
+                                  rte_bit_relaxed_get32
+                                               (BNX2X_LINK_REPORT_TX_FC_ON,
+                                                &cur_data.link_report_flags)) {
                                flow = "ON - transmit";
                        } else {
                                flow = "none";  /* possible? */
@@ -7413,7 +7422,7 @@ int bnx2x_nic_load(struct bnx2x_softc *sc)
        bnx2x_set_rx_mode(sc);
 
        /* wait for all pending SP commands to complete */
-       if (IS_PF(sc) && !bnx2x_wait_sp_comp(sc, ~0x0UL)) {
+       if (IS_PF(sc) && !bnx2x_wait_sp_comp(sc, ~0x0U)) {
                PMD_DRV_LOG(NOTICE, sc, "Timeout waiting for all SPs to complete!");
                bnx2x_periodic_stop(sc);
                bnx2x_nic_unload(sc, UNLOAD_CLOSE, FALSE);
@@ -8167,7 +8176,7 @@ static int bnx2x_get_shmem_info(struct bnx2x_softc *sc)
                sc->link_params.mac_addr[4] = (uint8_t) (mac_lo >> 8);
                sc->link_params.mac_addr[5] = (uint8_t) (mac_lo);
                snprintf(sc->mac_addr_str, sizeof(sc->mac_addr_str),
-                        "%02x:%02x:%02x:%02x:%02x:%02x",
+                        RTE_ETHER_ADDR_PRT_FMT,
                         sc->link_params.mac_addr[0],
                         sc->link_params.mac_addr[1],
                         sc->link_params.mac_addr[2],
@@ -9649,44 +9658,33 @@ static void bnx2x_init_rte(struct bnx2x_softc *sc)
 void bnx2x_load_firmware(struct bnx2x_softc *sc)
 {
        const char *fwname;
-       int f;
-       struct stat st;
+       void *buf;
+       size_t bufsz;
 
        fwname = sc->devinfo.device_id == CHIP_NUM_57711
                ? FW_NAME_57711 : FW_NAME_57810;
-       f = open(fwname, O_RDONLY);
-       if (f < 0) {
+       if (rte_firmware_read(fwname, &buf, &bufsz) != 0) {
                PMD_DRV_LOG(NOTICE, sc, "Can't open firmware file");
                return;
        }
 
-       if (fstat(f, &st) < 0) {
-               PMD_DRV_LOG(NOTICE, sc, "Can't stat firmware file");
-               close(f);
-               return;
-       }
-
-       sc->firmware = rte_zmalloc("bnx2x_fw", st.st_size, RTE_CACHE_LINE_SIZE);
+       sc->firmware = rte_zmalloc("bnx2x_fw", bufsz, RTE_CACHE_LINE_SIZE);
        if (!sc->firmware) {
                PMD_DRV_LOG(NOTICE, sc, "Can't allocate memory for firmware");
-               close(f);
-               return;
+               goto out;
        }
 
-       if (read(f, sc->firmware, st.st_size) != st.st_size) {
-               PMD_DRV_LOG(NOTICE, sc, "Can't read firmware data");
-               close(f);
-               return;
-       }
-       close(f);
-
-       sc->fw_len = st.st_size;
+       sc->fw_len = bufsz;
        if (sc->fw_len < FW_HEADER_LEN) {
                PMD_DRV_LOG(NOTICE, sc,
                            "Invalid fw size: %" PRIu64, sc->fw_len);
-               return;
+               goto out;
        }
+
+       memcpy(sc->firmware, buf, sc->fw_len);
        PMD_DRV_LOG(DEBUG, sc, "fw_len = %" PRIu64, sc->fw_len);
+out:
+       free(buf);
 }
 
 static void
@@ -11896,7 +11894,7 @@ void bnx2x_print_device_info(struct bnx2x_softc *sc)
        PMD_DRV_LOG(INFO, sc, "%12s : %u", "MTU", sc->mtu);
        PMD_DRV_LOG(INFO, sc,
                    "%12s : %s", "PHY Type", get_ext_phy_type(ext_phy_type));
-       PMD_DRV_LOG(INFO, sc, "%12s : %x:%x:%x:%x:%x:%x", "MAC Addr",
+       PMD_DRV_LOG(INFO, sc, "%12s : " RTE_ETHER_ADDR_PRT_FMT, "MAC Addr",
                        sc->link_params.mac_addr[0],
                        sc->link_params.mac_addr[1],
                        sc->link_params.mac_addr[2],