net: add rte prefix to ether structures

[dpdk.git] / drivers / net / bnx2x / bnx2x_ethdev.c

diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index 0057843..567dc55 100644 (file)
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -8,6 +8,7 @@
 #include "bnx2x.h"
 #include "bnx2x_rxtx.h"
 
+#include <rte_string_fns.h>
 #include <rte_dev.h>
 #include <rte_ethdev_pci.h>
 #include <rte_alarm.h>
@@ -107,14 +108,15 @@ bnx2x_link_update(struct rte_eth_dev *dev)
 }
 
 static void
-bnx2x_interrupt_action(struct rte_eth_dev *dev)
+bnx2x_interrupt_action(struct rte_eth_dev *dev, int intr_cxt)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
        uint32_t link_status;
 
-       bnx2x_intr_legacy(sc, 0);
+       bnx2x_intr_legacy(sc);
 
-       if (sc->periodic_flags & PERIODIC_GO)
+       if ((atomic_load_acq_long(&sc->periodic_flags) == PERIODIC_GO) &&
+           !intr_cxt)
                bnx2x_periodic_callout(sc);
        link_status = REG_RD(sc, sc->link_params.shmem_base +
                        offsetof(struct shmem_region,
@@ -131,9 +133,7 @@ bnx2x_interrupt_handler(void *param)
 
        PMD_DEBUG_PERIODIC_LOG(INFO, sc, "Interrupt handled");
 
-       atomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP);
-       bnx2x_interrupt_action(dev);
-       atomic_store_rel_long(&sc->periodic_flags, PERIODIC_GO);
+       bnx2x_interrupt_action(dev, 1);
        rte_intr_enable(&sc->pci_dev->intr_handle);
 }
 
@@ -144,7 +144,7 @@ static void bnx2x_periodic_start(void *param)
        int ret = 0;
 
        atomic_store_rel_long(&sc->periodic_flags, PERIODIC_GO);
-       bnx2x_interrupt_action(dev);
+       bnx2x_interrupt_action(dev, 0);
        if (IS_PF(sc)) {
                ret = rte_eal_alarm_set(BNX2X_SP_TIMER_PERIOD,
                                        bnx2x_periodic_start, (void *)dev);
@@ -164,6 +164,8 @@ void bnx2x_periodic_stop(void *param)
        atomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP);
 
        rte_eal_alarm_cancel(bnx2x_periodic_start, (void *)dev);
+
+       PMD_DRV_LOG(DEBUG, sc, "Periodic poll stopped");
 }
 
 /*
@@ -180,8 +182,10 @@ bnx2x_dev_configure(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE(sc);
 
-       if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)
+       if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
                sc->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len;
+               dev->data->mtu = sc->mtu;
+       }
 
        if (dev->data->nb_tx_queues > dev->data->nb_rx_queues) {
                PMD_DRV_LOG(ERR, sc, "The number of TX queues is greater than number of RX queues");
@@ -210,6 +214,7 @@ bnx2x_dev_configure(struct rte_eth_dev *dev)
                return -ENXIO;
        }
 
+       bnx2x_dev_rxtx_init_dummy(dev);
        return 0;
 }
 
@@ -222,8 +227,10 @@ bnx2x_dev_start(struct rte_eth_dev *dev)
        PMD_INIT_FUNC_TRACE(sc);
 
        /* start the periodic callout */
-       if (sc->periodic_flags & PERIODIC_STOP)
+       if (atomic_load_acq_long(&sc->periodic_flags) == PERIODIC_STOP) {
                bnx2x_periodic_start(dev);
+               PMD_DRV_LOG(DEBUG, sc, "Periodic poll re-started");
+       }
 
        ret = bnx2x_init(sc);
        if (ret) {
@@ -239,14 +246,9 @@ bnx2x_dev_start(struct rte_eth_dev *dev)
                        PMD_DRV_LOG(ERR, sc, "rte_intr_enable failed");
        }
 
-       ret = bnx2x_dev_rx_init(dev);
-       if (ret != 0) {
-               PMD_DRV_LOG(DEBUG, sc, "bnx2x_dev_rx_init returned error code");
-               return -3;
-       }
+       bnx2x_dev_rxtx_init(dev);
 
-       /* Print important adapter info for the user. */
-       bnx2x_print_adapter_info(sc);
+       bnx2x_print_device_info(sc);
 
        return ret;
 }
@@ -259,6 +261,8 @@ bnx2x_dev_stop(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE(sc);
 
+       bnx2x_dev_rxtx_init_dummy(dev);
+
        if (IS_PF(sc)) {
                rte_intr_disable(&sc->pci_dev->intr_handle);
                rte_intr_callback_unregister(&sc->pci_dev->intr_handle,
@@ -446,10 +450,9 @@ bnx2x_get_xstats_names(__rte_unused struct rte_eth_dev *dev,
 
        if (xstats_names != NULL)
                for (i = 0; i < stat_cnt; i++)
-                       snprintf(xstats_names[i].name,
-                               sizeof(xstats_names[i].name),
-                               "%s",
-                               bnx2x_xstats_strings[i].name);
+                       strlcpy(xstats_names[i].name,
+                               bnx2x_xstats_strings[i].name,
+                               sizeof(xstats_names[i].name));
 
        return stat_cnt;
 }
@@ -498,7 +501,7 @@ bnx2x_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 }
 
 static int
-bnx2x_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
+bnx2x_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,
                uint32_t index, uint32_t pool)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
@@ -574,6 +577,7 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
        struct rte_pci_device *pci_dev;
        struct rte_pci_addr pci_addr;
        struct bnx2x_softc *sc;
+       static bool adapter_info = true;
 
        /* Extract key data structures */
        sc = eth_dev->data->dev_private;
@@ -632,8 +636,15 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
                return ret;
        }
 
+       /* Print important adapter info for the user. */
+       if (adapter_info) {
+               bnx2x_print_adapter_info(sc);
+               adapter_info = false;
+       }
+
        /* schedule periodic poll for slowpath link events */
        if (IS_PF(sc)) {
+               PMD_DRV_LOG(DEBUG, sc, "Scheduling periodic poll for slowpath link events");
                ret = rte_eal_alarm_set(BNX2X_SP_TIMER_PERIOD,
                                        bnx2x_periodic_start, (void *)eth_dev);
                if (ret) {
@@ -643,16 +654,8 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
                }
        }
 
-       eth_dev->data->mac_addrs = (struct ether_addr *)sc->link_params.mac_addr;
-
-       PMD_DRV_LOG(INFO, sc, "pcie_bus=%d, pcie_device=%d",
-                       sc->pcie_bus, sc->pcie_device);
-       PMD_DRV_LOG(INFO, sc, "bar0.addr=%p, bar1.addr=%p",
-                       sc->bar[BAR0].base_addr, sc->bar[BAR1].base_addr);
-       PMD_DRV_LOG(INFO, sc, "port=%d, path=%d, vnic=%d, func=%d",
-                       PORT_ID(sc), PATH_ID(sc), VNIC_ID(sc), FUNC_ID(sc));
-       PMD_DRV_LOG(INFO, sc, "portID=%d vendorID=0x%x deviceID=0x%x",
-                       eth_dev->data->port_id, pci_dev->id.vendor_id, pci_dev->id.device_id);
+       eth_dev->data->mac_addrs =
+               (struct rte_ether_addr *)sc->link_params.mac_addr;
 
        if (IS_VF(sc)) {
                rte_spinlock_init(&sc->vf2pf_lock);