net/bnxt: fix Rx next consumer index in mbuf alloc fail
[dpdk.git] / drivers / net / bnxt / bnxt_rxr.c
index 9a5ac39..e2f09ad 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2014-2018 Broadcom
+ * Copyright(c) 2014-2021 Broadcom
  * All rights reserved.
  */
 
 #include <rte_byteorder.h>
 #include <rte_malloc.h>
 #include <rte_memory.h>
+#include <rte_alarm.h>
 
 #include "bnxt.h"
+#include "bnxt_reps.h"
 #include "bnxt_ring.h"
 #include "bnxt_rxr.h"
 #include "bnxt_rxq.h"
 #include "hsi_struct_def_dpdk.h"
-#ifdef RTE_LIBRTE_IEEE1588
 #include "bnxt_hwrm.h"
-#endif
 
 #include <bnxt_tf_common.h>
 #include <ulp_mark_mgr.h>
@@ -38,19 +38,22 @@ static inline struct rte_mbuf *__bnxt_alloc_rx_data(struct rte_mempool *mb)
 
 static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq,
                                     struct bnxt_rx_ring_info *rxr,
-                                    uint16_t prod)
+                                    uint16_t raw_prod)
 {
-       struct rx_prod_pkt_bd *rxbd = &rxr->rx_desc_ring[prod];
-       struct bnxt_sw_rx_bd *rx_buf = &rxr->rx_buf_ring[prod];
+       uint16_t prod = RING_IDX(rxr->rx_ring_struct, raw_prod);
+       struct rx_prod_pkt_bd *rxbd;
+       struct rte_mbuf **rx_buf;
        struct rte_mbuf *mbuf;
 
+       rxbd = &rxr->rx_desc_ring[prod];
+       rx_buf = &rxr->rx_buf_ring[prod];
        mbuf = __bnxt_alloc_rx_data(rxq->mb_pool);
        if (!mbuf) {
                rte_atomic64_inc(&rxq->rx_mbuf_alloc_fail);
                return -ENOMEM;
        }
 
-       rx_buf->mbuf = mbuf;
+       *rx_buf = mbuf;
        mbuf->data_off = RTE_PKTMBUF_HEADROOM;
 
        rxbd->address = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbuf));
@@ -60,12 +63,15 @@ static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq,
 
 static inline int bnxt_alloc_ag_data(struct bnxt_rx_queue *rxq,
                                     struct bnxt_rx_ring_info *rxr,
-                                    uint16_t prod)
+                                    uint16_t raw_prod)
 {
-       struct rx_prod_pkt_bd *rxbd = &rxr->ag_desc_ring[prod];
-       struct bnxt_sw_rx_bd *rx_buf = &rxr->ag_buf_ring[prod];
+       uint16_t prod = RING_IDX(rxr->ag_ring_struct, raw_prod);
+       struct rx_prod_pkt_bd *rxbd;
+       struct rte_mbuf **rx_buf;
        struct rte_mbuf *mbuf;
 
+       rxbd = &rxr->ag_desc_ring[prod];
+       rx_buf = &rxr->ag_buf_ring[prod];
        if (rxbd == NULL) {
                PMD_DRV_LOG(ERR, "Jumbo Frame. rxbd is NULL\n");
                return -EINVAL;
@@ -82,7 +88,7 @@ static inline int bnxt_alloc_ag_data(struct bnxt_rx_queue *rxq,
                return -ENOMEM;
        }
 
-       rx_buf->mbuf = mbuf;
+       *rx_buf = mbuf;
        mbuf->data_off = RTE_PKTMBUF_HEADROOM;
 
        rxbd->address = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbuf));
@@ -93,38 +99,132 @@ static inline int bnxt_alloc_ag_data(struct bnxt_rx_queue *rxq,
 static inline void bnxt_reuse_rx_mbuf(struct bnxt_rx_ring_info *rxr,
                               struct rte_mbuf *mbuf)
 {
-       uint16_t prod = RING_NEXT(rxr->rx_ring_struct, rxr->rx_prod);
-       struct bnxt_sw_rx_bd *prod_rx_buf;
+       uint16_t prod, raw_prod = RING_NEXT(rxr->rx_raw_prod);
+       struct rte_mbuf **prod_rx_buf;
        struct rx_prod_pkt_bd *prod_bd;
 
+       prod = RING_IDX(rxr->rx_ring_struct, raw_prod);
        prod_rx_buf = &rxr->rx_buf_ring[prod];
 
-       RTE_ASSERT(prod_rx_buf->mbuf == NULL);
+       RTE_ASSERT(*prod_rx_buf == NULL);
        RTE_ASSERT(mbuf != NULL);
 
-       prod_rx_buf->mbuf = mbuf;
+       *prod_rx_buf = mbuf;
 
        prod_bd = &rxr->rx_desc_ring[prod];
 
        prod_bd->address = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbuf));
 
-       rxr->rx_prod = prod;
+       rxr->rx_raw_prod = raw_prod;
 }
 
 static inline
 struct rte_mbuf *bnxt_consume_rx_buf(struct bnxt_rx_ring_info *rxr,
                                     uint16_t cons)
 {
-       struct bnxt_sw_rx_bd *cons_rx_buf;
+       struct rte_mbuf **cons_rx_buf;
        struct rte_mbuf *mbuf;
 
-       cons_rx_buf = &rxr->rx_buf_ring[cons];
-       RTE_ASSERT(cons_rx_buf->mbuf != NULL);
-       mbuf = cons_rx_buf->mbuf;
-       cons_rx_buf->mbuf = NULL;
+       cons_rx_buf = &rxr->rx_buf_ring[RING_IDX(rxr->rx_ring_struct, cons)];
+       RTE_ASSERT(*cons_rx_buf != NULL);
+       mbuf = *cons_rx_buf;
+       *cons_rx_buf = NULL;
+
        return mbuf;
 }
 
+static void bnxt_rx_ring_reset(void *arg)
+{
+       struct bnxt *bp = arg;
+       int i, rc = 0;
+       struct bnxt_rx_queue *rxq;
+
+
+       for (i = 0; i < (int)bp->rx_nr_rings; i++) {
+               struct bnxt_rx_ring_info *rxr;
+
+               rxq = bp->rx_queues[i];
+               if (!rxq || !rxq->in_reset)
+                       continue;
+
+               rxr = rxq->rx_ring;
+               /* Disable and flush TPA before resetting the RX ring */
+               if (rxr->tpa_info)
+                       bnxt_hwrm_vnic_tpa_cfg(bp, rxq->vnic, false);
+               rc = bnxt_hwrm_rx_ring_reset(bp, i);
+               if (rc) {
+                       PMD_DRV_LOG(ERR, "Rx ring%d reset failed\n", i);
+                       continue;
+               }
+
+               bnxt_rx_queue_release_mbufs(rxq);
+               rxr->rx_raw_prod = 0;
+               rxr->ag_raw_prod = 0;
+               rxr->rx_next_cons = 0;
+               bnxt_init_one_rx_ring(rxq);
+               bnxt_db_write(&rxr->rx_db, rxr->rx_raw_prod);
+               bnxt_db_write(&rxr->ag_db, rxr->ag_raw_prod);
+               if (rxr->tpa_info)
+                       bnxt_hwrm_vnic_tpa_cfg(bp, rxq->vnic, true);
+
+               rxq->in_reset = 0;
+       }
+}
+
+
+static void bnxt_sched_ring_reset(struct bnxt_rx_queue *rxq)
+{
+       rxq->in_reset = 1;
+       rte_eal_alarm_set(1, bnxt_rx_ring_reset, (void *)rxq->bp);
+}
+
+static void bnxt_tpa_get_metadata(struct bnxt *bp,
+                                 struct bnxt_tpa_info *tpa_info,
+                                 struct rx_tpa_start_cmpl *tpa_start,
+                                 struct rx_tpa_start_cmpl_hi *tpa_start1)
+{
+       tpa_info->cfa_code_valid = 0;
+       tpa_info->vlan_valid = 0;
+       tpa_info->hash_valid = 0;
+       tpa_info->l4_csum_valid = 0;
+
+       if (likely(tpa_start->flags_type &
+                  rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS_RSS_VALID))) {
+               tpa_info->hash_valid = 1;
+               tpa_info->rss_hash = rte_le_to_cpu_32(tpa_start->rss_hash);
+       }
+
+       if (bp->vnic_cap_flags & BNXT_VNIC_CAP_RX_CMPL_V2) {
+               struct rx_tpa_start_v2_cmpl *v2_tpa_start = (void *)tpa_start;
+               struct rx_tpa_start_v2_cmpl_hi *v2_tpa_start1 =
+                       (void *)tpa_start1;
+
+               if (v2_tpa_start->agg_id &
+                   RX_TPA_START_V2_CMPL_METADATA1_VALID) {
+                       tpa_info->vlan_valid = 1;
+                       tpa_info->vlan =
+                               rte_le_to_cpu_16(v2_tpa_start1->metadata0);
+               }
+
+               if (v2_tpa_start1->flags2 & RX_CMP_FLAGS2_L4_CSUM_ALL_OK_MASK)
+                       tpa_info->l4_csum_valid = 1;
+
+               return;
+       }
+
+       tpa_info->cfa_code_valid = 1;
+       tpa_info->cfa_code = rte_le_to_cpu_16(tpa_start1->cfa_code);
+       if (tpa_start1->flags2 &
+           rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS2_META_FORMAT_VLAN)) {
+               tpa_info->vlan_valid = 1;
+               tpa_info->vlan = rte_le_to_cpu_32(tpa_start1->metadata);
+       }
+
+       if (likely(tpa_start1->flags2 &
+                  rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS2_L4_CS_CALC)))
+               tpa_info->l4_csum_valid = 1;
+}
+
 static void bnxt_tpa_start(struct bnxt_rx_queue *rxq,
                           struct rx_tpa_start_cmpl *tpa_start,
                           struct rx_tpa_start_cmpl_hi *tpa_start1)
@@ -139,6 +239,12 @@ static void bnxt_tpa_start(struct bnxt_rx_queue *rxq,
 
        data_cons = tpa_start->opaque;
        tpa_info = &rxr->tpa_info[agg_id];
+       if (unlikely(data_cons != rxr->rx_next_cons)) {
+               PMD_DRV_LOG(ERR, "TPA cons %x, expected cons %x\n",
+                           data_cons, rxr->rx_next_cons);
+               bnxt_sched_ring_reset(rxq);
+               return;
+       }
 
        mbuf = bnxt_consume_rx_buf(rxr, data_cons);
 
@@ -148,32 +254,38 @@ static void bnxt_tpa_start(struct bnxt_rx_queue *rxq,
        tpa_info->mbuf = mbuf;
        tpa_info->len = rte_le_to_cpu_32(tpa_start->len);
 
+       mbuf->data_off = RTE_PKTMBUF_HEADROOM;
        mbuf->nb_segs = 1;
        mbuf->next = NULL;
        mbuf->pkt_len = rte_le_to_cpu_32(tpa_start->len);
        mbuf->data_len = mbuf->pkt_len;
        mbuf->port = rxq->port_id;
-       mbuf->ol_flags = PKT_RX_LRO;
-       if (likely(tpa_start->flags_type &
-                  rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS_RSS_VALID))) {
-               mbuf->hash.rss = rte_le_to_cpu_32(tpa_start->rss_hash);
-               mbuf->ol_flags |= PKT_RX_RSS_HASH;
-       } else {
-               mbuf->hash.fdir.id = rte_le_to_cpu_16(tpa_start1->cfa_code);
-               mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;
+       mbuf->ol_flags = RTE_MBUF_F_RX_LRO;
+
+       bnxt_tpa_get_metadata(rxq->bp, tpa_info, tpa_start, tpa_start1);
+
+       if (likely(tpa_info->hash_valid)) {
+               mbuf->hash.rss = tpa_info->rss_hash;
+               mbuf->ol_flags |= RTE_MBUF_F_RX_RSS_HASH;
+       } else if (tpa_info->cfa_code_valid) {
+               mbuf->hash.fdir.id = tpa_info->cfa_code;
+               mbuf->ol_flags |= RTE_MBUF_F_RX_FDIR | RTE_MBUF_F_RX_FDIR_ID;
        }
-       if (tpa_start1->flags2 &
-           rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS2_META_FORMAT_VLAN)) {
-               mbuf->vlan_tci = rte_le_to_cpu_32(tpa_start1->metadata);
-               mbuf->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
+
+       if (tpa_info->vlan_valid && BNXT_RX_VLAN_STRIP_EN(rxq->bp)) {
+               mbuf->vlan_tci = tpa_info->vlan;
+               mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED;
        }
-       if (likely(tpa_start1->flags2 &
-                  rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS2_L4_CS_CALC)))
-               mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
+
+       if (likely(tpa_info->l4_csum_valid))
+               mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
 
        /* recycle next mbuf */
-       data_cons = RING_NEXT(rxr->rx_ring_struct, data_cons);
+       data_cons = RING_NEXT(data_cons);
        bnxt_reuse_rx_mbuf(rxr, bnxt_consume_rx_buf(rxr, data_cons));
+
+       rxr->rx_next_cons = RING_IDX(rxr->rx_ring_struct,
+                                    RING_NEXT(data_cons));
 }
 
 static int bnxt_agg_bufs_valid(struct bnxt_cp_ring_info *cpr,
@@ -185,28 +297,28 @@ static int bnxt_agg_bufs_valid(struct bnxt_cp_ring_info *cpr,
        raw_cp_cons = ADV_RAW_CMP(raw_cp_cons, agg_bufs);
        last_cp_cons = RING_CMP(cpr->cp_ring_struct, raw_cp_cons);
        agg_cmpl = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[last_cp_cons];
-       cpr->valid = FLIP_VALID(raw_cp_cons,
-                               cpr->cp_ring_struct->ring_mask,
-                               cpr->valid);
-       return CMP_VALID(agg_cmpl, raw_cp_cons, cpr->cp_ring_struct);
+       return bnxt_cpr_cmp_valid(agg_cmpl, raw_cp_cons,
+                                 cpr->cp_ring_struct->ring_size);
 }
 
 /* TPA consume agg buffer out of order, allocate connected data only */
 static int bnxt_prod_ag_mbuf(struct bnxt_rx_queue *rxq)
 {
        struct bnxt_rx_ring_info *rxr = rxq->rx_ring;
-       uint16_t next = RING_NEXT(rxr->ag_ring_struct, rxr->ag_prod);
+       uint16_t raw_next = RING_NEXT(rxr->ag_raw_prod);
+       uint16_t bmap_next = RING_IDX(rxr->ag_ring_struct, raw_next);
 
        /* TODO batch allocation for better performance */
-       while (rte_bitmap_get(rxr->ag_bitmap, next)) {
-               if (unlikely(bnxt_alloc_ag_data(rxq, rxr, next))) {
-                       PMD_DRV_LOG(ERR,
-                               "agg mbuf alloc failed: prod=0x%x\n", next);
+       while (rte_bitmap_get(rxr->ag_bitmap, bmap_next)) {
+               if (unlikely(bnxt_alloc_ag_data(rxq, rxr, raw_next))) {
+                       PMD_DRV_LOG(ERR, "agg mbuf alloc failed: prod=0x%x\n",
+                                   raw_next);
                        break;
                }
-               rte_bitmap_clear(rxr->ag_bitmap, next);
-               rxr->ag_prod = next;
-               next = RING_NEXT(rxr->ag_ring_struct, next);
+               rte_bitmap_clear(rxr->ag_bitmap, bmap_next);
+               rxr->ag_raw_prod = raw_next;
+               raw_next = RING_NEXT(raw_next);
+               bmap_next = RING_IDX(rxr->ag_ring_struct, raw_next);
        }
 
        return 0;
@@ -222,13 +334,13 @@ static int bnxt_rx_pages(struct bnxt_rx_queue *rxq,
        uint16_t cp_cons, ag_cons;
        struct rx_pkt_cmpl *rxcmp;
        struct rte_mbuf *last = mbuf;
-       bool is_thor_tpa = tpa_info && BNXT_CHIP_THOR(rxq->bp);
+       bool is_p5_tpa = tpa_info && BNXT_CHIP_P5(rxq->bp);
 
        for (i = 0; i < agg_buf; i++) {
-               struct bnxt_sw_rx_bd *ag_buf;
+               struct rte_mbuf **ag_buf;
                struct rte_mbuf *ag_mbuf;
 
-               if (is_thor_tpa) {
+               if (is_p5_tpa) {
                        rxcmp = (void *)&tpa_info->agg_arr[i];
                } else {
                        *tmp_raw_cons = NEXT_RAW_CMP(*tmp_raw_cons);
@@ -244,7 +356,7 @@ static int bnxt_rx_pages(struct bnxt_rx_queue *rxq,
                ag_cons = rxcmp->opaque;
                RTE_ASSERT(ag_cons <= rxr->ag_ring_struct->ring_mask);
                ag_buf = &rxr->ag_buf_ring[ag_cons];
-               ag_mbuf = ag_buf->mbuf;
+               ag_mbuf = *ag_buf;
                RTE_ASSERT(ag_mbuf != NULL);
 
                ag_mbuf->data_len = rte_le_to_cpu_16(rxcmp->len);
@@ -255,7 +367,7 @@ static int bnxt_rx_pages(struct bnxt_rx_queue *rxq,
                last->next = ag_mbuf;
                last = ag_mbuf;
 
-               ag_buf->mbuf = NULL;
+               *ag_buf = NULL;
 
                /*
                 * As aggregation buffer consumed out of order in TPA module,
@@ -264,10 +376,39 @@ static int bnxt_rx_pages(struct bnxt_rx_queue *rxq,
                 */
                rte_bitmap_set(rxr->ag_bitmap, ag_cons);
        }
+       last->next = NULL;
        bnxt_prod_ag_mbuf(rxq);
        return 0;
 }
 
+static int bnxt_discard_rx(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
+                          uint32_t *raw_cons, void *cmp)
+{
+       struct rx_pkt_cmpl *rxcmp = cmp;
+       uint32_t tmp_raw_cons = *raw_cons;
+       uint8_t cmp_type, agg_bufs = 0;
+
+       cmp_type = CMP_TYPE(rxcmp);
+
+       if (cmp_type == CMPL_BASE_TYPE_RX_L2) {
+               agg_bufs = BNXT_RX_L2_AGG_BUFS(rxcmp);
+       } else if (cmp_type == RX_TPA_END_CMPL_TYPE_RX_TPA_END) {
+               struct rx_tpa_end_cmpl *tpa_end = cmp;
+
+               if (BNXT_CHIP_P5(bp))
+                       return 0;
+
+               agg_bufs = BNXT_TPA_END_AGG_BUFS(tpa_end);
+       }
+
+       if (agg_bufs) {
+               if (!bnxt_agg_bufs_valid(cpr, agg_bufs, tmp_raw_cons))
+                       return -EBUSY;
+       }
+       *raw_cons = tmp_raw_cons;
+       return 0;
+}
+
 static inline struct rte_mbuf *bnxt_tpa_end(
                struct bnxt_rx_queue *rxq,
                uint32_t *raw_cp_cons,
@@ -282,7 +423,14 @@ static inline struct rte_mbuf *bnxt_tpa_end(
        uint8_t payload_offset;
        struct bnxt_tpa_info *tpa_info;
 
-       if (BNXT_CHIP_THOR(rxq->bp)) {
+       if (unlikely(rxq->in_reset)) {
+               PMD_DRV_LOG(ERR, "rxq->in_reset: raw_cp_cons:%d\n",
+                           *raw_cp_cons);
+               bnxt_discard_rx(rxq->bp, cpr, raw_cp_cons, tpa_end);
+               return NULL;
+       }
+
+       if (BNXT_CHIP_P5(rxq->bp)) {
                struct rx_tpa_v2_end_cmpl *th_tpa_end;
                struct rx_tpa_v2_end_cmpl_hi *th_tpa_end1;
 
@@ -303,7 +451,6 @@ static inline struct rte_mbuf *bnxt_tpa_end(
        mbuf = tpa_info->mbuf;
        RTE_ASSERT(mbuf != NULL);
 
-       rte_prefetch0(mbuf);
        if (agg_bufs) {
                bnxt_rx_pages(rxq, mbuf, raw_cp_cons, agg_bufs, tpa_info);
        }
@@ -320,71 +467,237 @@ static inline struct rte_mbuf *bnxt_tpa_end(
        return mbuf;
 }
 
+uint32_t bnxt_ptype_table[BNXT_PTYPE_TBL_DIM] __rte_cache_aligned;
+
+static void __rte_cold
+bnxt_init_ptype_table(void)
+{
+       uint32_t *pt = bnxt_ptype_table;
+       static bool initialized;
+       int ip6, tun, type;
+       uint32_t l3;
+       int i;
+
+       if (initialized)
+               return;
+
+       for (i = 0; i < BNXT_PTYPE_TBL_DIM; i++) {
+               if (i & BNXT_PTYPE_TBL_VLAN_MSK)
+                       pt[i] = RTE_PTYPE_L2_ETHER_VLAN;
+               else
+                       pt[i] = RTE_PTYPE_L2_ETHER;
+
+               ip6 = !!(i & BNXT_PTYPE_TBL_IP_VER_MSK);
+               tun = !!(i & BNXT_PTYPE_TBL_TUN_MSK);
+               type = (i & BNXT_PTYPE_TBL_TYPE_MSK) >> BNXT_PTYPE_TBL_TYPE_SFT;
+
+               if (!tun && !ip6)
+                       l3 = RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
+               else if (!tun && ip6)
+                       l3 = RTE_PTYPE_L3_IPV6_EXT_UNKNOWN;
+               else if (tun && !ip6)
+                       l3 = RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN;
+               else
+                       l3 = RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN;
+
+               switch (type) {
+               case BNXT_PTYPE_TBL_TYPE_ICMP:
+                       if (tun)
+                               pt[i] |= l3 | RTE_PTYPE_INNER_L4_ICMP;
+                       else
+                               pt[i] |= l3 | RTE_PTYPE_L4_ICMP;
+                       break;
+               case BNXT_PTYPE_TBL_TYPE_TCP:
+                       if (tun)
+                               pt[i] |= l3 | RTE_PTYPE_INNER_L4_TCP;
+                       else
+                               pt[i] |= l3 | RTE_PTYPE_L4_TCP;
+                       break;
+               case BNXT_PTYPE_TBL_TYPE_UDP:
+                       if (tun)
+                               pt[i] |= l3 | RTE_PTYPE_INNER_L4_UDP;
+                       else
+                               pt[i] |= l3 | RTE_PTYPE_L4_UDP;
+                       break;
+               case BNXT_PTYPE_TBL_TYPE_IP:
+                       pt[i] |= l3;
+                       break;
+               }
+       }
+       initialized = true;
+}
+
 static uint32_t
 bnxt_parse_pkt_type(struct rx_pkt_cmpl *rxcmp, struct rx_pkt_cmpl_hi *rxcmp1)
 {
-       uint32_t l3, pkt_type = 0;
-       uint32_t t_ipcs = 0, ip6 = 0, vlan = 0;
-       uint32_t flags_type;
-
-       vlan = !!(rxcmp1->flags2 &
-               rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN));
-       pkt_type |= vlan ? RTE_PTYPE_L2_ETHER_VLAN : RTE_PTYPE_L2_ETHER;
-
-       t_ipcs = !!(rxcmp1->flags2 &
-               rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC));
-       ip6 = !!(rxcmp1->flags2 &
-                rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_IP_TYPE));
-
-       flags_type = rxcmp->flags_type &
-               rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS_ITYPE_MASK);
-
-       if (!t_ipcs && !ip6)
-               l3 = RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
-       else if (!t_ipcs && ip6)
-               l3 = RTE_PTYPE_L3_IPV6_EXT_UNKNOWN;
-       else if (t_ipcs && !ip6)
-               l3 = RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN;
-       else
-               l3 = RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN;
+       uint32_t flags_type, flags2;
+       uint8_t index;
 
-       switch (flags_type) {
-       case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_ICMP):
-               if (!t_ipcs)
-                       pkt_type |= l3 | RTE_PTYPE_L4_ICMP;
-               else
-                       pkt_type |= l3 | RTE_PTYPE_INNER_L4_ICMP;
-               break;
+       flags_type = rte_le_to_cpu_16(rxcmp->flags_type);
+       flags2 = rte_le_to_cpu_32(rxcmp1->flags2);
 
-       case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_TCP):
-               if (!t_ipcs)
-                       pkt_type |= l3 | RTE_PTYPE_L4_TCP;
-               else
-                       pkt_type |= l3 | RTE_PTYPE_INNER_L4_TCP;
-               break;
+       /* Validate ptype table indexing at build time. */
+       bnxt_check_ptype_constants();
 
-       case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_UDP):
-               if (!t_ipcs)
-                       pkt_type |= l3 | RTE_PTYPE_L4_UDP;
-               else
-                       pkt_type |= l3 | RTE_PTYPE_INNER_L4_UDP;
-               break;
+       /*
+        * Index format:
+        *     bit 0: Set if IP tunnel encapsulated packet.
+        *     bit 1: Set if IPv6 packet, clear if IPv4.
+        *     bit 2: Set if VLAN tag present.
+        *     bits 3-6: Four-bit hardware packet type field.
+        */
+       index = BNXT_CMPL_ITYPE_TO_IDX(flags_type) |
+               BNXT_CMPL_VLAN_TUN_TO_IDX(flags2) |
+               BNXT_CMPL_IP_VER_TO_IDX(flags2);
 
-       case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_IP):
-               pkt_type |= l3;
-               break;
+       return bnxt_ptype_table[index];
+}
+
+static void __rte_cold
+bnxt_init_ol_flags_tables(struct bnxt_rx_queue *rxq)
+{
+       struct bnxt_rx_ring_info *rxr = rxq->rx_ring;
+       struct rte_eth_conf *dev_conf;
+       bool outer_cksum_enabled;
+       uint64_t offloads;
+       uint32_t *pt;
+       int i;
+
+       dev_conf = &rxq->bp->eth_dev->data->dev_conf;
+       offloads = dev_conf->rxmode.offloads;
+
+       outer_cksum_enabled = !!(offloads & (RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+                                            RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM));
+
+       /* Initialize ol_flags table. */
+       pt = rxr->ol_flags_table;
+       for (i = 0; i < BNXT_OL_FLAGS_TBL_DIM; i++) {
+               pt[i] = 0;
+
+               if (BNXT_RX_VLAN_STRIP_EN(rxq->bp)) {
+                       if (i & RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN)
+                               pt[i] |= RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED;
+               }
+
+               if (i & (RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC << 3)) {
+                       /* Tunnel case. */
+                       if (outer_cksum_enabled) {
+                               if (i & RX_PKT_CMPL_FLAGS2_IP_CS_CALC)
+                                       pt[i] |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
+
+                               if (i & RX_PKT_CMPL_FLAGS2_L4_CS_CALC)
+                                       pt[i] |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
+
+                               if (i & RX_PKT_CMPL_FLAGS2_T_L4_CS_CALC)
+                                       pt[i] |= RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD;
+                       } else {
+                               if (i & RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC)
+                                       pt[i] |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
+
+                               if (i & RX_PKT_CMPL_FLAGS2_T_L4_CS_CALC)
+                                       pt[i] |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
+                       }
+               } else {
+                       /* Non-tunnel case. */
+                       if (i & RX_PKT_CMPL_FLAGS2_IP_CS_CALC)
+                               pt[i] |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
+
+                       if (i & RX_PKT_CMPL_FLAGS2_L4_CS_CALC)
+                               pt[i] |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
+               }
        }
 
-       return pkt_type;
+       /* Initialize checksum error table. */
+       pt = rxr->ol_flags_err_table;
+       for (i = 0; i < BNXT_OL_FLAGS_ERR_TBL_DIM; i++) {
+               pt[i] = 0;
+
+               if (i & (RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC << 2)) {
+                       /* Tunnel case. */
+                       if (outer_cksum_enabled) {
+                               if (i & (RX_PKT_CMPL_ERRORS_IP_CS_ERROR >> 4))
+                                       pt[i] |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
+
+                               if (i & (RX_PKT_CMPL_ERRORS_T_IP_CS_ERROR >> 4))
+                                       pt[i] |= RTE_MBUF_F_RX_OUTER_IP_CKSUM_BAD;
+
+                               if (i & (RX_PKT_CMPL_ERRORS_L4_CS_ERROR >> 4))
+                                       pt[i] |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
+
+                               if (i & (RX_PKT_CMPL_ERRORS_T_L4_CS_ERROR >> 4))
+                                       pt[i] |= RTE_MBUF_F_RX_OUTER_L4_CKSUM_BAD;
+                       } else {
+                               if (i & (RX_PKT_CMPL_ERRORS_T_IP_CS_ERROR >> 4))
+                                       pt[i] |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
+
+                               if (i & (RX_PKT_CMPL_ERRORS_T_L4_CS_ERROR >> 4))
+                                       pt[i] |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
+                       }
+               } else {
+                       /* Non-tunnel case. */
+                       if (i & (RX_PKT_CMPL_ERRORS_IP_CS_ERROR >> 4))
+                               pt[i] |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
+
+                       if (i & (RX_PKT_CMPL_ERRORS_L4_CS_ERROR >> 4))
+                               pt[i] |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
+               }
+       }
+}
+
+static void
+bnxt_set_ol_flags(struct bnxt_rx_ring_info *rxr, struct rx_pkt_cmpl *rxcmp,
+                 struct rx_pkt_cmpl_hi *rxcmp1, struct rte_mbuf *mbuf)
+{
+       uint16_t flags_type, errors, flags;
+       uint64_t ol_flags;
+
+       flags_type = rte_le_to_cpu_16(rxcmp->flags_type);
+
+       flags = rte_le_to_cpu_32(rxcmp1->flags2) &
+                               (RX_PKT_CMPL_FLAGS2_IP_CS_CALC |
+                                RX_PKT_CMPL_FLAGS2_L4_CS_CALC |
+                                RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC |
+                                RX_PKT_CMPL_FLAGS2_T_L4_CS_CALC |
+                                RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN);
+
+       flags |= (flags & RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC) << 3;
+       errors = rte_le_to_cpu_16(rxcmp1->errors_v2) &
+                               (RX_PKT_CMPL_ERRORS_IP_CS_ERROR |
+                                RX_PKT_CMPL_ERRORS_L4_CS_ERROR |
+                                RX_PKT_CMPL_ERRORS_T_IP_CS_ERROR |
+                                RX_PKT_CMPL_ERRORS_T_L4_CS_ERROR);
+       errors = (errors >> 4) & flags;
+
+       ol_flags = rxr->ol_flags_table[flags & ~errors];
+
+       if (unlikely(errors)) {
+               errors |= (flags & RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC) << 2;
+               ol_flags |= rxr->ol_flags_err_table[errors];
+       }
+
+       if (flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID) {
+               mbuf->hash.rss = rte_le_to_cpu_32(rxcmp->rss_hash);
+               ol_flags |= RTE_MBUF_F_RX_RSS_HASH;
+       }
+
+#ifdef RTE_LIBRTE_IEEE1588
+       if (unlikely((flags_type & RX_PKT_CMPL_FLAGS_MASK) ==
+                    RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP))
+               ol_flags |= RTE_MBUF_F_RX_IEEE1588_PTP | RTE_MBUF_F_RX_IEEE1588_TMST;
+#endif
+
+       mbuf->ol_flags = ol_flags;
 }
 
 #ifdef RTE_LIBRTE_IEEE1588
 static void
-bnxt_get_rx_ts_thor(struct bnxt *bp, uint32_t rx_ts_cmpl)
+bnxt_get_rx_ts_p5(struct bnxt *bp, uint32_t rx_ts_cmpl)
 {
-       uint64_t systime_cycles = 0;
+       struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
+       uint64_t last_hwrm_time;
+       uint64_t pkt_time = 0;
 
-       if (!BNXT_CHIP_THOR(bp))
+       if (!BNXT_CHIP_P5(bp) || !ptp)
                return;
 
        /* On Thor, Rx timestamps are provided directly in the
@@ -395,16 +708,19 @@ bnxt_get_rx_ts_thor(struct bnxt *bp, uint32_t rx_ts_cmpl)
         * from the HWRM response with the lower 32 bits in the
         * Rx completion to produce the 48 bit timestamp for the Rx packet
         */
-       bnxt_hwrm_port_ts_query(bp, BNXT_PTP_FLAGS_CURRENT_TIME,
-                               &systime_cycles);
-       bp->ptp_cfg->rx_timestamp = (systime_cycles & 0xFFFF00000000);
-       bp->ptp_cfg->rx_timestamp |= rx_ts_cmpl;
+       last_hwrm_time = ptp->current_time;
+       pkt_time = (last_hwrm_time & BNXT_PTP_CURRENT_TIME_MASK) | rx_ts_cmpl;
+       if (rx_ts_cmpl < (uint32_t)last_hwrm_time) {
+               /* timer has rolled over */
+               pkt_time += (1ULL << 32);
+       }
+       ptp->rx_timestamp = pkt_time;
 }
 #endif
 
-static void
+static uint32_t
 bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1,
-                         struct rte_mbuf *mbuf)
+                         struct rte_mbuf *mbuf, uint32_t *vfr_flag)
 {
        uint32_t cfa_code;
        uint32_t meta_fmt;
@@ -415,7 +731,6 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1,
        uint32_t gfid_support = 0;
        int rc;
 
-
        if (BNXT_GFID_ENABLED(bp))
                gfid_support = 1;
 
@@ -483,19 +798,24 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1,
        }
 
        rc = ulp_mark_db_mark_get(bp->ulp_ctx, gfid,
-                                 cfa_code, &mark_id);
+                                 cfa_code, vfr_flag, &mark_id);
        if (!rc) {
+               /* VF to VFR Rx path. So, skip mark_id injection in mbuf */
+               if (vfr_flag && *vfr_flag)
+                       return mark_id;
                /* Got the mark, write it to the mbuf and return */
                mbuf->hash.fdir.hi = mark_id;
-               mbuf->udata64 = (cfa_code & 0xffffffffull) << 32;
+               *bnxt_cfa_code_dynfield(mbuf) = cfa_code & 0xffffffffull;
                mbuf->hash.fdir.id = rxcmp1->cfa_code;
-               mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;
-               return;
+               mbuf->ol_flags |= RTE_MBUF_F_RX_FDIR | RTE_MBUF_F_RX_FDIR_ID;
+               return mark_id;
        }
 
 skip_mark:
        mbuf->hash.fdir.hi = 0;
        mbuf->hash.fdir.id = 0;
+
+       return 0;
 }
 
 void bnxt_set_mark_in_mbuf(struct bnxt *bp,
@@ -503,9 +823,6 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
                           struct rte_mbuf *mbuf)
 {
        uint32_t cfa_code = 0;
-       uint8_t meta_fmt = 0;
-       uint16_t flags2 = 0;
-       uint32_t meta =  0;
 
        cfa_code = rte_le_to_cpu_16(rxcmp1->cfa_code);
        if (!cfa_code)
@@ -514,45 +831,25 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
        if (cfa_code && !bp->mark_table[cfa_code].valid)
                return;
 
-       flags2 = rte_le_to_cpu_16(rxcmp1->flags2);
-       meta = rte_le_to_cpu_32(rxcmp1->metadata);
-       if (meta) {
-               meta >>= BNXT_RX_META_CFA_CODE_SHIFT;
-
-               /* The flags field holds extra bits of info from [6:4]
-                * which indicate if the flow is in TCAM or EM or EEM
-                */
-               meta_fmt = (flags2 & BNXT_CFA_META_FMT_MASK) >>
-                          BNXT_CFA_META_FMT_SHFT;
-
-               /* meta_fmt == 4 => 'b100 => 'b10x => EM.
-                * meta_fmt == 5 => 'b101 => 'b10x => EM + VLAN
-                * meta_fmt == 6 => 'b110 => 'b11x => EEM
-                * meta_fmt == 7 => 'b111 => 'b11x => EEM + VLAN.
-                */
-               meta_fmt >>= BNXT_CFA_META_FMT_EM_EEM_SHFT;
-       }
-
        mbuf->hash.fdir.hi = bp->mark_table[cfa_code].mark_id;
-       mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;
+       mbuf->ol_flags |= RTE_MBUF_F_RX_FDIR | RTE_MBUF_F_RX_FDIR_ID;
 }
 
 static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
-                           struct bnxt_rx_queue *rxq, uint32_t *raw_cons)
+                      struct bnxt_rx_queue *rxq, uint32_t *raw_cons)
 {
        struct bnxt_cp_ring_info *cpr = rxq->cp_ring;
        struct bnxt_rx_ring_info *rxr = rxq->rx_ring;
        struct rx_pkt_cmpl *rxcmp;
        struct rx_pkt_cmpl_hi *rxcmp1;
        uint32_t tmp_raw_cons = *raw_cons;
-       uint16_t cons, prod, cp_cons =
+       uint16_t cons, raw_prod, cp_cons =
            RING_CMP(cpr->cp_ring_struct, tmp_raw_cons);
        struct rte_mbuf *mbuf;
        int rc = 0;
        uint8_t agg_buf = 0;
        uint16_t cmp_type;
-       uint32_t flags2_f = 0;
-       uint16_t flags_type;
+       uint32_t vfr_flag = 0, mark_id = 0;
        struct bnxt *bp = rxq->bp;
 
        rxcmp = (struct rx_pkt_cmpl *)
@@ -576,14 +873,12 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
        cp_cons = RING_CMP(cpr->cp_ring_struct, tmp_raw_cons);
        rxcmp1 = (struct rx_pkt_cmpl_hi *)&cpr->cp_desc_ring[cp_cons];
 
-       if (!CMP_VALID(rxcmp1, tmp_raw_cons, cpr->cp_ring_struct))
+       if (!bnxt_cpr_cmp_valid(rxcmp1, tmp_raw_cons,
+                               cpr->cp_ring_struct->ring_size))
                return -EBUSY;
 
-       cpr->valid = FLIP_VALID(cp_cons,
-                               cpr->cp_ring_struct->ring_mask,
-                               cpr->valid);
-
-       if (cmp_type == RX_TPA_START_CMPL_TYPE_RX_TPA_START) {
+       if (cmp_type == RX_TPA_START_CMPL_TYPE_RX_TPA_START ||
+           cmp_type == RX_TPA_START_V2_CMPL_TYPE_RX_TPA_START_V2) {
                bnxt_tpa_start(rxq, (struct rx_tpa_start_cmpl *)rxcmp,
                               (struct rx_tpa_start_cmpl_hi *)rxcmp1);
                rc = -EINVAL; /* Continue w/o new mbuf */
@@ -596,106 +891,69 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
                        return -EBUSY;
                *rx_pkt = mbuf;
                goto next_rx;
-       } else if (cmp_type != 0x11) {
+       } else if ((cmp_type != CMPL_BASE_TYPE_RX_L2) &&
+                  (cmp_type != CMPL_BASE_TYPE_RX_L2_V2)) {
                rc = -EINVAL;
                goto next_rx;
        }
 
-       agg_buf = (rxcmp->agg_bufs_v1 & RX_PKT_CMPL_AGG_BUFS_MASK)
-                       >> RX_PKT_CMPL_AGG_BUFS_SFT;
+       agg_buf = BNXT_RX_L2_AGG_BUFS(rxcmp);
        if (agg_buf && !bnxt_agg_bufs_valid(cpr, agg_buf, tmp_raw_cons))
                return -EBUSY;
 
-       prod = rxr->rx_prod;
+       raw_prod = rxr->rx_raw_prod;
 
        cons = rxcmp->opaque;
+       if (unlikely(cons != rxr->rx_next_cons)) {
+               bnxt_discard_rx(bp, cpr, &tmp_raw_cons, rxcmp);
+               PMD_DRV_LOG(ERR, "RX cons %x != expected cons %x\n",
+                           cons, rxr->rx_next_cons);
+               bnxt_sched_ring_reset(rxq);
+               rc = -EBUSY;
+               goto next_rx;
+       }
        mbuf = bnxt_consume_rx_buf(rxr, cons);
        if (mbuf == NULL)
                return -EBUSY;
 
-       rte_prefetch0(mbuf);
-
        mbuf->data_off = RTE_PKTMBUF_HEADROOM;
        mbuf->nb_segs = 1;
        mbuf->next = NULL;
        mbuf->pkt_len = rxcmp->len;
        mbuf->data_len = mbuf->pkt_len;
        mbuf->port = rxq->port_id;
-       mbuf->ol_flags = 0;
 
-       flags_type = rte_le_to_cpu_16(rxcmp->flags_type);
-       if (flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID) {
-               mbuf->hash.rss = rxcmp->rss_hash;
-               mbuf->ol_flags |= PKT_RX_RSS_HASH;
+#ifdef RTE_LIBRTE_IEEE1588
+       if (unlikely((rte_le_to_cpu_16(rxcmp->flags_type) &
+                     RX_PKT_CMPL_FLAGS_MASK) ==
+                    RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP))
+               bnxt_get_rx_ts_p5(rxq->bp, rxcmp1->reorder);
+#endif
+
+       if (cmp_type == CMPL_BASE_TYPE_RX_L2_V2) {
+               bnxt_parse_csum_v2(mbuf, rxcmp1);
+               bnxt_parse_pkt_type_v2(mbuf, rxcmp, rxcmp1);
+               bnxt_rx_vlan_v2(mbuf, rxcmp, rxcmp1);
+               /* TODO Add support for cfa_code parsing */
+               goto reuse_rx_mbuf;
        }
 
+       bnxt_set_ol_flags(rxr, rxcmp, rxcmp1, mbuf);
+
+       mbuf->packet_type = bnxt_parse_pkt_type(rxcmp, rxcmp1);
+
+       bnxt_set_vlan(rxcmp1, mbuf);
+
        if (BNXT_TRUFLOW_EN(bp))
-               bnxt_ulp_set_mark_in_mbuf(rxq->bp, rxcmp1, mbuf);
+               mark_id = bnxt_ulp_set_mark_in_mbuf(rxq->bp, rxcmp1, mbuf,
+                                                   &vfr_flag);
        else
                bnxt_set_mark_in_mbuf(rxq->bp, rxcmp1, mbuf);
 
-#ifdef RTE_LIBRTE_IEEE1588
-       if (unlikely((flags_type & RX_PKT_CMPL_FLAGS_MASK) ==
-                    RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP)) {
-               mbuf->ol_flags |= PKT_RX_IEEE1588_PTP | PKT_RX_IEEE1588_TMST;
-               bnxt_get_rx_ts_thor(rxq->bp, rxcmp1->reorder);
-       }
-#endif
+reuse_rx_mbuf:
        if (agg_buf)
                bnxt_rx_pages(rxq, mbuf, &tmp_raw_cons, agg_buf, NULL);
 
-       if (rxcmp1->flags2 & RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN) {
-               mbuf->vlan_tci = rxcmp1->metadata &
-                       (RX_PKT_CMPL_METADATA_VID_MASK |
-                       RX_PKT_CMPL_METADATA_DE |
-                       RX_PKT_CMPL_METADATA_PRI_MASK);
-               mbuf->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
-       }
-
-       flags2_f = flags2_0xf(rxcmp1);
-       /* IP Checksum */
-       if (likely(IS_IP_NONTUNNEL_PKT(flags2_f))) {
-               if (unlikely(RX_CMP_IP_CS_ERROR(rxcmp1)))
-                       mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
-               else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
-                       mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
-               else
-                       mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
-       } else if (IS_IP_TUNNEL_PKT(flags2_f)) {
-               if (unlikely(RX_CMP_IP_OUTER_CS_ERROR(rxcmp1) ||
-                            RX_CMP_IP_CS_ERROR(rxcmp1)))
-                       mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
-               else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
-                       mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
-               else
-                       mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
-       }
-
-       /* L4 Checksum */
-       if (likely(IS_L4_NONTUNNEL_PKT(flags2_f))) {
-               if (unlikely(RX_CMP_L4_INNER_CS_ERR2(rxcmp1)))
-                       mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD;
-               else
-                       mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
-       } else if (IS_L4_TUNNEL_PKT(flags2_f)) {
-               if (unlikely(RX_CMP_L4_INNER_CS_ERR2(rxcmp1)))
-                       mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD;
-               else
-                       mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
-               if (unlikely(RX_CMP_L4_OUTER_CS_ERR2(rxcmp1))) {
-                       mbuf->ol_flags |= PKT_RX_OUTER_L4_CKSUM_BAD;
-               } else if (unlikely(IS_L4_TUNNEL_PKT_ONLY_INNER_L4_CS
-                                   (flags2_f))) {
-                       mbuf->ol_flags |= PKT_RX_OUTER_L4_CKSUM_UNKNOWN;
-               } else {
-                       mbuf->ol_flags |= PKT_RX_OUTER_L4_CKSUM_GOOD;
-               }
-       } else if (unlikely(RX_CMP_L4_CS_UNKNOWN(rxcmp1))) {
-               mbuf->ol_flags |= PKT_RX_L4_CKSUM_UNKNOWN;
-       }
-
-       mbuf->packet_type = bnxt_parse_pkt_type(rxcmp, rxcmp1);
-
 #ifdef BNXT_DEBUG
        if (rxcmp1->errors_v2 & RX_CMP_L2_ERRORS) {
                /* Re-install the mbuf back to the rx ring */
@@ -720,18 +978,33 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
         * calls in favour of a tight loop with the same function being called
         * in it.
         */
-       prod = RING_NEXT(rxr->rx_ring_struct, prod);
-       if (bnxt_alloc_rx_data(rxq, rxr, prod)) {
-               PMD_DRV_LOG(ERR, "mbuf alloc failed with prod=0x%x\n", prod);
+       raw_prod = RING_NEXT(raw_prod);
+       if (bnxt_alloc_rx_data(rxq, rxr, raw_prod)) {
+               PMD_DRV_LOG(ERR, "mbuf alloc failed with prod=0x%x\n",
+                           raw_prod);
                rc = -ENOMEM;
                goto rx;
        }
-       rxr->rx_prod = prod;
+       rxr->rx_raw_prod = raw_prod;
+rx:
+       rxr->rx_next_cons = RING_IDX(rxr->rx_ring_struct, RING_NEXT(cons));
+
+       if (BNXT_TRUFLOW_EN(bp) && (BNXT_VF_IS_TRUSTED(bp) || BNXT_PF(bp)) &&
+           vfr_flag) {
+               bnxt_vfr_recv(mark_id, rxq->queue_id, mbuf);
+               /* Now return an error so that nb_rx_pkts is not
+                * incremented.
+                * This packet was meant to be given to the representor.
+                * So no need to account the packet and give it to
+                * parent Rx burst function.
+                */
+               rc = -ENODEV;
+               goto next_rx;
+       }
        /*
         * All MBUFs are allocated with the same size under DPDK,
         * no optimization for rx_copy_thresh
         */
-rx:
        *rx_pkt = mbuf;
 
 next_rx:
@@ -747,12 +1020,14 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
        struct bnxt_rx_queue *rxq = rx_queue;
        struct bnxt_cp_ring_info *cpr = rxq->cp_ring;
        struct bnxt_rx_ring_info *rxr = rxq->rx_ring;
+       uint16_t rx_raw_prod = rxr->rx_raw_prod;
+       uint16_t ag_raw_prod = rxr->ag_raw_prod;
        uint32_t raw_cons = cpr->cp_raw_cons;
+       bool alloc_failed = false;
        uint32_t cons;
        int nb_rx_pkts = 0;
+       int nb_rep_rx_pkts = 0;
        struct rx_pkt_cmpl *rxcmp;
-       uint16_t prod = rxr->rx_prod;
-       uint16_t ag_prod = rxr->ag_prod;
        int rc = 0;
        bool evt = false;
 
@@ -760,29 +1035,50 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
                return 0;
 
        /* If Rx Q was stopped return */
-       if (unlikely(!rxq->rx_started ||
-                    !rte_spinlock_trylock(&rxq->lock)))
+       if (unlikely(!rxq->rx_started))
                return 0;
 
+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
+       /*
+        * Replenish buffers if needed when a transition has been made from
+        * vector- to non-vector- receive processing.
+        */
+       while (unlikely(rxq->rxrearm_nb)) {
+               if (!bnxt_alloc_rx_data(rxq, rxr, rxq->rxrearm_start)) {
+                       rxr->rx_raw_prod = rxq->rxrearm_start;
+                       bnxt_db_write(&rxr->rx_db, rxr->rx_raw_prod);
+                       rxq->rxrearm_start++;
+                       rxq->rxrearm_nb--;
+               } else {
+                       /* Retry allocation on next call. */
+                       break;
+               }
+       }
+#endif
+
        /* Handle RX burst request */
        while (1) {
                cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
-               rte_prefetch0(&cpr->cp_desc_ring[cons]);
                rxcmp = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[cons];
 
-               if (!CMP_VALID(rxcmp, raw_cons, cpr->cp_ring_struct))
+               if (!bnxt_cpr_cmp_valid(rxcmp, raw_cons,
+                                       cpr->cp_ring_struct->ring_size))
                        break;
-               cpr->valid = FLIP_VALID(cons,
-                                       cpr->cp_ring_struct->ring_mask,
-                                       cpr->valid);
-
-               /* TODO: Avoid magic numbers... */
-               if ((CMP_TYPE(rxcmp) & 0x30) == 0x10) {
+               if (CMP_TYPE(rxcmp) == CMPL_BASE_TYPE_HWRM_DONE) {
+                       PMD_DRV_LOG(ERR, "Rx flush done\n");
+               } else if ((CMP_TYPE(rxcmp) >= CMPL_BASE_TYPE_RX_TPA_START_V2) &&
+                    (CMP_TYPE(rxcmp) <= RX_TPA_V2_ABUF_CMPL_TYPE_RX_TPA_AGG)) {
                        rc = bnxt_rx_pkt(&rx_pkts[nb_rx_pkts], rxq, &raw_cons);
-                       if (likely(!rc) || rc == -ENOMEM)
+                       if (!rc)
                                nb_rx_pkts++;
-                       if (rc == -EBUSY)       /* partial completion */
+                       else if (rc == -EBUSY)  /* partial completion */
                                break;
+                       else if (rc == -ENODEV) /* completion for representor */
+                               nb_rep_rx_pkts++;
+                       else if (rc == -ENOMEM) {
+                               nb_rx_pkts++;
+                               alloc_failed = true;
+                       }
                } else if (!BNXT_NUM_ASYNC_CPR(rxq->bp)) {
                        evt =
                        bnxt_event_hwrm_resp_handler(rxq->bp,
@@ -793,15 +1089,12 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
                }
 
                raw_cons = NEXT_RAW_CMP(raw_cons);
-               if (nb_rx_pkts == nb_pkts || evt)
+               if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)
                        break;
-               /* Post some Rx buf early in case of larger burst processing */
-               if (nb_rx_pkts == BNXT_RX_POST_THRESH)
-                       bnxt_db_write(&rxr->rx_db, rxr->rx_prod);
        }
 
        cpr->cp_raw_cons = raw_cons;
-       if (!nb_rx_pkts && !evt) {
+       if (!nb_rx_pkts && !nb_rep_rx_pkts && !evt) {
                /*
                 * For PMD, there is no need to keep on pushing to REARM
                 * the doorbell if there are no new completions
@@ -809,32 +1102,37 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
                goto done;
        }
 
-       if (prod != rxr->rx_prod)
-               bnxt_db_write(&rxr->rx_db, rxr->rx_prod);
+       /* Ring the completion queue doorbell. */
+       bnxt_db_cq(cpr);
 
-       /* Ring the AGG ring DB */
-       if (ag_prod != rxr->ag_prod)
-               bnxt_db_write(&rxr->ag_db, rxr->ag_prod);
+       /* Ring the receive descriptor doorbell. */
+       if (rx_raw_prod != rxr->rx_raw_prod)
+               bnxt_db_write(&rxr->rx_db, rxr->rx_raw_prod);
 
-       bnxt_db_cq(cpr);
+       /* Ring the AGG ring DB */
+       if (ag_raw_prod != rxr->ag_raw_prod)
+               bnxt_db_write(&rxr->ag_db, rxr->ag_raw_prod);
 
        /* Attempt to alloc Rx buf in case of a previous allocation failure. */
-       if (rc == -ENOMEM) {
-               int i = RING_NEXT(rxr->rx_ring_struct, prod);
-               int cnt = nb_rx_pkts;
+       if (alloc_failed) {
+               int cnt;
+
+               rx_raw_prod = RING_NEXT(rx_raw_prod);
+               for (cnt = 0; cnt < nb_rx_pkts + nb_rep_rx_pkts; cnt++) {
+                       struct rte_mbuf **rx_buf;
+                       uint16_t ndx;
 
-               for (; cnt;
-                       i = RING_NEXT(rxr->rx_ring_struct, i), cnt--) {
-                       struct bnxt_sw_rx_bd *rx_buf = &rxr->rx_buf_ring[i];
+                       ndx = RING_IDX(rxr->rx_ring_struct, rx_raw_prod + cnt);
+                       rx_buf = &rxr->rx_buf_ring[ndx];
 
                        /* Buffer already allocated for this index. */
-                       if (rx_buf->mbuf != NULL)
+                       if (*rx_buf != NULL && *rx_buf != &rxq->fake_mbuf)
                                continue;
 
                        /* This slot is empty. Alloc buffer for Rx */
-                       if (!bnxt_alloc_rx_data(rxq, rxr, i)) {
-                               rxr->rx_prod = i;
-                               bnxt_db_write(&rxr->rx_db, rxr->rx_prod);
+                       if (!bnxt_alloc_rx_data(rxq, rxr, rx_raw_prod + cnt)) {
+                               rxr->rx_raw_prod = rx_raw_prod + cnt;
+                               bnxt_db_write(&rxr->rx_db, rxr->rx_raw_prod);
                        } else {
                                PMD_DRV_LOG(ERR, "Alloc  mbuf failed\n");
                                break;
@@ -843,8 +1141,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
        }
 
 done:
-       rte_spinlock_unlock(&rxq->lock);
-
        return nb_rx_pkts;
 }
 
@@ -889,6 +1185,9 @@ void bnxt_free_rx_rings(struct bnxt *bp)
                rte_free(rxq->cp_ring->cp_ring_struct);
                rte_free(rxq->cp_ring);
 
+               rte_memzone_free(rxq->mz);
+               rxq->mz = NULL;
+
                rte_free(rxq);
                bp->rx_queues[i] = NULL;
        }
@@ -902,47 +1201,75 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)
 
        rxq->rx_buf_size = BNXT_MAX_PKT_LEN + sizeof(struct rte_mbuf);
 
-       rxr = rte_zmalloc_socket("bnxt_rx_ring",
-                                sizeof(struct bnxt_rx_ring_info),
-                                RTE_CACHE_LINE_SIZE, socket_id);
-       if (rxr == NULL)
-               return -ENOMEM;
-       rxq->rx_ring = rxr;
+       if (rxq->rx_ring != NULL) {
+               rxr = rxq->rx_ring;
+       } else {
 
-       ring = rte_zmalloc_socket("bnxt_rx_ring_struct",
-                                  sizeof(struct bnxt_ring),
-                                  RTE_CACHE_LINE_SIZE, socket_id);
-       if (ring == NULL)
-               return -ENOMEM;
-       rxr->rx_ring_struct = ring;
-       ring->ring_size = rte_align32pow2(rxq->nb_rx_desc);
-       ring->ring_mask = ring->ring_size - 1;
-       ring->bd = (void *)rxr->rx_desc_ring;
-       ring->bd_dma = rxr->rx_desc_mapping;
-       ring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_rx_bd);
-       ring->vmem = (void **)&rxr->rx_buf_ring;
-
-       cpr = rte_zmalloc_socket("bnxt_rx_ring",
-                                sizeof(struct bnxt_cp_ring_info),
-                                RTE_CACHE_LINE_SIZE, socket_id);
-       if (cpr == NULL)
-               return -ENOMEM;
-       rxq->cp_ring = cpr;
+               rxr = rte_zmalloc_socket("bnxt_rx_ring",
+                                        sizeof(struct bnxt_rx_ring_info),
+                                        RTE_CACHE_LINE_SIZE, socket_id);
+               if (rxr == NULL)
+                       return -ENOMEM;
+               rxq->rx_ring = rxr;
+       }
 
-       ring = rte_zmalloc_socket("bnxt_rx_ring_struct",
-                                  sizeof(struct bnxt_ring),
-                                  RTE_CACHE_LINE_SIZE, socket_id);
-       if (ring == NULL)
-               return -ENOMEM;
-       cpr->cp_ring_struct = ring;
-       ring->ring_size = rte_align32pow2(rxr->rx_ring_struct->ring_size *
-                                         (2 + AGG_RING_SIZE_FACTOR));
-       ring->ring_mask = ring->ring_size - 1;
-       ring->bd = (void *)cpr->cp_desc_ring;
-       ring->bd_dma = cpr->cp_desc_mapping;
-       ring->vmem_size = 0;
-       ring->vmem = NULL;
+       if (rxr->rx_ring_struct == NULL) {
+               ring = rte_zmalloc_socket("bnxt_rx_ring_struct",
+                                          sizeof(struct bnxt_ring),
+                                          RTE_CACHE_LINE_SIZE, socket_id);
+               if (ring == NULL)
+                       return -ENOMEM;
+               rxr->rx_ring_struct = ring;
+               ring->ring_size = rte_align32pow2(rxq->nb_rx_desc);
+               ring->ring_mask = ring->ring_size - 1;
+               ring->bd = (void *)rxr->rx_desc_ring;
+               ring->bd_dma = rxr->rx_desc_mapping;
+
+               /* Allocate extra rx ring entries for vector rx. */
+               ring->vmem_size = sizeof(struct rte_mbuf *) *
+                                 (ring->ring_size + BNXT_RX_EXTRA_MBUF_ENTRIES);
+
+               ring->vmem = (void **)&rxr->rx_buf_ring;
+               ring->fw_ring_id = INVALID_HW_RING_ID;
+       }
 
+       if (rxq->cp_ring != NULL) {
+               cpr = rxq->cp_ring;
+       } else {
+               cpr = rte_zmalloc_socket("bnxt_rx_ring",
+                                        sizeof(struct bnxt_cp_ring_info),
+                                        RTE_CACHE_LINE_SIZE, socket_id);
+               if (cpr == NULL)
+                       return -ENOMEM;
+               rxq->cp_ring = cpr;
+       }
+
+       if (cpr->cp_ring_struct == NULL) {
+               ring = rte_zmalloc_socket("bnxt_rx_ring_struct",
+                                          sizeof(struct bnxt_ring),
+                                          RTE_CACHE_LINE_SIZE, socket_id);
+               if (ring == NULL)
+                       return -ENOMEM;
+               cpr->cp_ring_struct = ring;
+
+               /* Allocate two completion slots per entry in desc ring. */
+               ring->ring_size = rxr->rx_ring_struct->ring_size * 2;
+               if (bnxt_need_agg_ring(rxq->bp->eth_dev))
+                       ring->ring_size *= AGG_RING_SIZE_FACTOR;
+
+               ring->ring_size = rte_align32pow2(ring->ring_size);
+               ring->ring_mask = ring->ring_size - 1;
+               ring->bd = (void *)cpr->cp_desc_ring;
+               ring->bd_dma = cpr->cp_desc_mapping;
+               ring->vmem_size = 0;
+               ring->vmem = NULL;
+               ring->fw_ring_id = INVALID_HW_RING_ID;
+       }
+
+       if (!bnxt_need_agg_ring(rxq->bp->eth_dev))
+               return 0;
+
+       rxr = rxq->rx_ring;
        /* Allocate Aggregator rings */
        ring = rte_zmalloc_socket("bnxt_rx_ring_struct",
                                   sizeof(struct bnxt_ring),
@@ -955,8 +1282,9 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)
        ring->ring_mask = ring->ring_size - 1;
        ring->bd = (void *)rxr->ag_desc_ring;
        ring->bd_dma = rxr->ag_desc_mapping;
-       ring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_rx_bd);
+       ring->vmem_size = ring->ring_size * sizeof(struct rte_mbuf *);
        ring->vmem = (void **)&rxr->ag_buf_ring;
+       ring->fw_ring_id = INVALID_HW_RING_ID;
 
        return 0;
 }
@@ -980,49 +1308,67 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
 {
        struct bnxt_rx_ring_info *rxr;
        struct bnxt_ring *ring;
-       uint32_t prod, type;
+       uint32_t raw_prod, type;
        unsigned int i;
        uint16_t size;
 
+       /* Initialize packet type table. */
+       bnxt_init_ptype_table();
+
        size = rte_pktmbuf_data_room_size(rxq->mb_pool) - RTE_PKTMBUF_HEADROOM;
        size = RTE_MIN(BNXT_MAX_PKT_LEN, size);
 
-       type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT | RX_PROD_PKT_BD_FLAGS_EOP_PAD;
+       type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT;
 
        rxr = rxq->rx_ring;
        ring = rxr->rx_ring_struct;
        bnxt_init_rxbds(ring, type, size);
 
-       prod = rxr->rx_prod;
+       /* Initialize offload flags parsing table. */
+       bnxt_init_ol_flags_tables(rxq);
+
+       raw_prod = rxr->rx_raw_prod;
        for (i = 0; i < ring->ring_size; i++) {
-               if (unlikely(!rxr->rx_buf_ring[i].mbuf)) {
-                       if (bnxt_alloc_rx_data(rxq, rxr, prod) != 0) {
+               if (unlikely(!rxr->rx_buf_ring[i])) {
+                       if (bnxt_alloc_rx_data(rxq, rxr, raw_prod) != 0) {
                                PMD_DRV_LOG(WARNING,
                                            "init'ed rx ring %d with %d/%d mbufs only\n",
                                            rxq->queue_id, i, ring->ring_size);
                                break;
                        }
                }
-               rxr->rx_prod = prod;
-               prod = RING_NEXT(rxr->rx_ring_struct, prod);
+               rxr->rx_raw_prod = raw_prod;
+               raw_prod = RING_NEXT(raw_prod);
+       }
+
+       /* Initialize dummy mbuf pointers for vector mode rx. */
+       for (i = ring->ring_size;
+            i < ring->ring_size + BNXT_RX_EXTRA_MBUF_ENTRIES; i++) {
+               rxr->rx_buf_ring[i] = &rxq->fake_mbuf;
        }
 
+       /* Explicitly reset this driver internal tracker on a ring init */
+       rxr->rx_next_cons = 0;
+
+       if (!bnxt_need_agg_ring(rxq->bp->eth_dev))
+               return 0;
+
        ring = rxr->ag_ring_struct;
        type = RX_PROD_AGG_BD_TYPE_RX_PROD_AGG;
        bnxt_init_rxbds(ring, type, size);
-       prod = rxr->ag_prod;
+       raw_prod = rxr->ag_raw_prod;
 
        for (i = 0; i < ring->ring_size; i++) {
-               if (unlikely(!rxr->ag_buf_ring[i].mbuf)) {
-                       if (bnxt_alloc_ag_data(rxq, rxr, prod) != 0) {
+               if (unlikely(!rxr->ag_buf_ring[i])) {
+                       if (bnxt_alloc_ag_data(rxq, rxr, raw_prod) != 0) {
                                PMD_DRV_LOG(WARNING,
                                            "init'ed AG ring %d with %d/%d mbufs only\n",
                                            rxq->queue_id, i, ring->ring_size);
                                break;
                        }
                }
-               rxr->ag_prod = prod;
-               prod = RING_NEXT(rxr->ag_ring_struct, prod);
+               rxr->ag_raw_prod = raw_prod;
+               raw_prod = RING_NEXT(raw_prod);
        }
        PMD_DRV_LOG(DEBUG, "AGG Done!\n");
 
@@ -1044,3 +1390,35 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
 
        return 0;
 }
+
+/* Sweep the Rx completion queue till HWRM_DONE for ring flush is received.
+ * The mbufs will not be freed in this call.
+ * They will be freed during ring free as a part of mem cleanup.
+ */
+int bnxt_flush_rx_cmp(struct bnxt_cp_ring_info *cpr)
+{
+       struct bnxt_ring *cp_ring_struct = cpr->cp_ring_struct;
+       uint32_t ring_mask = cp_ring_struct->ring_mask;
+       uint32_t raw_cons = cpr->cp_raw_cons;
+       struct rx_pkt_cmpl *rxcmp;
+       uint32_t nb_rx = 0;
+       uint32_t cons;
+
+       do {
+               cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
+               rxcmp = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[cons];
+
+               if (CMP_TYPE(rxcmp) == CMPL_BASE_TYPE_HWRM_DONE)
+                       return 1;
+
+               raw_cons = NEXT_RAW_CMP(raw_cons);
+               nb_rx++;
+       } while (nb_rx < ring_mask);
+
+       cpr->cp_raw_cons = raw_cons;
+
+       /* Ring the completion queue doorbell. */
+       bnxt_db_cq(cpr);
+
+       return 0;
+}