net/bnxt: support extended port counters
[dpdk.git] / drivers / net / bnxt / bnxt_stats.c
index 2606e93..c16bf99 100644 (file)
@@ -1,34 +1,6 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) Broadcom Limited.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Broadcom Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2014-2018 Broadcom
+ * All rights reserved.
  */
 
 #include <inttypes.h>
@@ -54,8 +26,8 @@ static const struct bnxt_xstats_name_off bnxt_rx_stats_strings[] = {
                                rx_256b_511b_frames)},
        {"rx_512b_1023b_frames", offsetof(struct rx_port_stats,
                                rx_512b_1023b_frames)},
-       {"rx_1024b_1518_frames", offsetof(struct rx_port_stats,
-                               rx_1024b_1518_frames)},
+       {"rx_1024b_1518b_frames", offsetof(struct rx_port_stats,
+                               rx_1024b_1518b_frames)},
        {"rx_good_vlan_frames", offsetof(struct rx_port_stats,
                                rx_good_vlan_frames)},
        {"rx_1519b_2047b_frames", offsetof(struct rx_port_stats,
@@ -121,12 +93,12 @@ static const struct bnxt_xstats_name_off bnxt_tx_stats_strings[] = {
                                tx_256b_511b_frames)},
        {"tx_512b_1023b_frames", offsetof(struct tx_port_stats,
                                tx_512b_1023b_frames)},
-       {"tx_1024b_1518_frames", offsetof(struct tx_port_stats,
-                               tx_1024b_1518_frames)},
+       {"tx_1024b_1518b_frames", offsetof(struct tx_port_stats,
+                               tx_1024b_1518b_frames)},
        {"tx_good_vlan_frames", offsetof(struct tx_port_stats,
                                tx_good_vlan_frames)},
-       {"tx_1519b_2047_frames", offsetof(struct tx_port_stats,
-                               tx_1519b_2047_frames)},
+       {"tx_1519b_2047b_frames", offsetof(struct tx_port_stats,
+                               tx_1519b_2047b_frames)},
        {"tx_2048b_4095b_frames", offsetof(struct tx_port_stats,
                                tx_2048b_4095b_frames)},
        {"tx_4096b_9216b_frames", offsetof(struct tx_port_stats,
@@ -172,8 +144,8 @@ static const struct bnxt_xstats_name_off bnxt_func_stats_strings[] = {
                                tx_mcast_pkts)},
        {"tx_bcast_pkts", offsetof(struct hwrm_func_qstats_output,
                                tx_bcast_pkts)},
-       {"tx_err_pkts", offsetof(struct hwrm_func_qstats_output,
-                               tx_err_pkts)},
+       {"tx_discard_pkts", offsetof(struct hwrm_func_qstats_output,
+                               tx_discard_pkts)},
        {"tx_drop_pkts", offsetof(struct hwrm_func_qstats_output,
                                tx_drop_pkts)},
        {"tx_ucast_bytes", offsetof(struct hwrm_func_qstats_output,
@@ -188,8 +160,8 @@ static const struct bnxt_xstats_name_off bnxt_func_stats_strings[] = {
                                rx_mcast_pkts)},
        {"rx_bcast_pkts", offsetof(struct hwrm_func_qstats_output,
                                rx_bcast_pkts)},
-       {"rx_err_pkts", offsetof(struct hwrm_func_qstats_output,
-                               rx_err_pkts)},
+       {"rx_discard_pkts", offsetof(struct hwrm_func_qstats_output,
+                               rx_discard_pkts)},
        {"rx_drop_pkts", offsetof(struct hwrm_func_qstats_output,
                                rx_drop_pkts)},
        {"rx_ucast_bytes", offsetof(struct hwrm_func_qstats_output,
@@ -208,6 +180,150 @@ static const struct bnxt_xstats_name_off bnxt_func_stats_strings[] = {
                                rx_agg_aborts)},
 };
 
+static const struct bnxt_xstats_name_off bnxt_rx_ext_stats_strings[] = {
+       {"link_down_events", offsetof(struct rx_port_stats_ext,
+                               link_down_events)},
+       {"continuous_pause_events", offsetof(struct rx_port_stats_ext,
+                               continuous_pause_events)},
+       {"resume_pause_events", offsetof(struct rx_port_stats_ext,
+                               resume_pause_events)},
+       {"continuous_roce_pause_events", offsetof(struct rx_port_stats_ext,
+                               continuous_roce_pause_events)},
+       {"resume_roce_pause_events", offsetof(struct rx_port_stats_ext,
+                               resume_roce_pause_events)},
+       {"rx_bytes_cos0", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos0)},
+       {"rx_bytes_cos1", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos1)},
+       {"rx_bytes_cos2", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos2)},
+       {"rx_bytes_cos3", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos3)},
+       {"rx_bytes_cos4", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos4)},
+       {"rx_bytes_cos5", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos5)},
+       {"rx_bytes_cos6", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos6)},
+       {"rx_bytes_cos7", offsetof(struct rx_port_stats_ext,
+                               rx_bytes_cos7)},
+       {"rx_packets_cos0", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos0)},
+       {"rx_packets_cos1", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos1)},
+       {"rx_packets_cos2", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos2)},
+       {"rx_packets_cos3", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos3)},
+       {"rx_packets_cos4", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos4)},
+       {"rx_packets_cos5", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos5)},
+       {"rx_packets_cos6", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos6)},
+       {"rx_packets_cos7", offsetof(struct rx_port_stats_ext,
+                               rx_packets_cos7)},
+       {"pfc_pri0_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri0_rx_duration_us)},
+       {"pfc_pri0_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri0_rx_transitions)},
+       {"pfc_pri1_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri1_rx_duration_us)},
+       {"pfc_pri1_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri1_rx_transitions)},
+       {"pfc_pri2_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri2_rx_duration_us)},
+       {"pfc_pri2_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri2_rx_transitions)},
+       {"pfc_pri3_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri3_rx_duration_us)},
+       {"pfc_pri3_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri3_rx_transitions)},
+       {"pfc_pri4_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri4_rx_duration_us)},
+       {"pfc_pri4_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri4_rx_transitions)},
+       {"pfc_pri5_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri5_rx_duration_us)},
+       {"pfc_pri5_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri5_rx_transitions)},
+       {"pfc_pri6_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri6_rx_duration_us)},
+       {"pfc_pri6_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri6_rx_transitions)},
+       {"pfc_pri7_rx_duration_us", offsetof(struct rx_port_stats_ext,
+                               pfc_pri7_rx_duration_us)},
+       {"pfc_pri7_rx_transitions", offsetof(struct rx_port_stats_ext,
+                               pfc_pri7_rx_transitions)},
+};
+
+static const struct bnxt_xstats_name_off bnxt_tx_ext_stats_strings[] = {
+       {"tx_bytes_cos0", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos0)},
+       {"tx_bytes_cos1", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos1)},
+       {"tx_bytes_cos2", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos2)},
+       {"tx_bytes_cos3", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos3)},
+       {"tx_bytes_cos4", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos4)},
+       {"tx_bytes_cos5", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos5)},
+       {"tx_bytes_cos6", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos6)},
+       {"tx_bytes_cos7", offsetof(struct tx_port_stats_ext,
+                               tx_bytes_cos7)},
+       {"tx_packets_cos0", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos0)},
+       {"tx_packets_cos1", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos1)},
+       {"tx_packets_cos2", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos2)},
+       {"tx_packets_cos3", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos3)},
+       {"tx_packets_cos4", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos4)},
+       {"tx_packets_cos5", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos5)},
+       {"tx_packets_cos6", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos6)},
+       {"tx_packets_cos7", offsetof(struct tx_port_stats_ext,
+                               tx_packets_cos7)},
+       {"pfc_pri0_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri0_tx_duration_us)},
+       {"pfc_pri0_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri0_tx_transitions)},
+       {"pfc_pri1_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri1_tx_duration_us)},
+       {"pfc_pri1_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri1_tx_transitions)},
+       {"pfc_pri2_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri2_tx_duration_us)},
+       {"pfc_pri2_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri2_tx_transitions)},
+       {"pfc_pri3_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri3_tx_duration_us)},
+       {"pfc_pri3_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri3_tx_transitions)},
+       {"pfc_pri4_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri4_tx_duration_us)},
+       {"pfc_pri4_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri4_tx_transitions)},
+       {"pfc_pri5_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri5_tx_duration_us)},
+       {"pfc_pri5_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri5_tx_transitions)},
+       {"pfc_pri6_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri6_tx_duration_us)},
+       {"pfc_pri6_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri6_tx_transitions)},
+       {"pfc_pri7_tx_duration_us", offsetof(struct tx_port_stats_ext,
+                               pfc_pri7_tx_duration_us)},
+       {"pfc_pri7_tx_transitions", offsetof(struct tx_port_stats_ext,
+                               pfc_pri7_tx_transitions)},
+};
+
 /*
  * Statistics functions
  */
@@ -236,6 +352,10 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
        struct bnxt *bp = eth_dev->data->dev_private;
 
        memset(bnxt_stats, 0, sizeof(*bnxt_stats));
+       if (!(bp->flags & BNXT_FLAG_INIT_DONE)) {
+               PMD_DRV_LOG(ERR, "Device Initialization not complete!\n");
+               return -1;
+       }
 
        for (i = 0; i < bp->rx_cp_nr_rings; i++) {
                struct bnxt_rx_queue *rxq = bp->rx_queues[i];
@@ -245,6 +365,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
                                     bnxt_stats, 1);
                if (unlikely(rc))
                        return rc;
+               bnxt_stats->rx_nombuf +=
+                               rte_atomic64_read(&rxq->rx_mbuf_alloc_fail);
        }
 
        for (i = 0; i < bp->tx_cp_nr_rings; i++) {
@@ -259,16 +381,25 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
        rc = bnxt_hwrm_func_qstats(bp, 0xffff, bnxt_stats);
        if (unlikely(rc))
                return rc;
-       bnxt_stats->rx_nombuf = rte_atomic64_read(&bp->rx_mbuf_alloc_fail);
        return rc;
 }
 
 void bnxt_stats_reset_op(struct rte_eth_dev *eth_dev)
 {
        struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;
+       unsigned int i;
+
+       if (!(bp->flags & BNXT_FLAG_INIT_DONE)) {
+               PMD_DRV_LOG(ERR, "Device Initialization not complete!\n");
+               return;
+       }
 
        bnxt_clear_all_hwrm_stat_ctxs(bp);
-       rte_atomic64_clear(&bp->rx_mbuf_alloc_fail);
+       for (i = 0; i < bp->rx_cp_nr_rings; i++) {
+               struct bnxt_rx_queue *rxq = bp->rx_queues[i];
+
+               rte_atomic64_clear(&rxq->rx_mbuf_alloc_fail);
+       }
 }
 
 int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
@@ -278,17 +409,22 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
 
        unsigned int count, i;
        uint64_t tx_drop_pkts;
-
-       if (!(bp->flags & BNXT_FLAG_PORT_STATS)) {
-               RTE_LOG(ERR, PMD, "xstats not supported for VF\n");
-               return 0;
-       }
+       unsigned int rx_port_stats_ext_cnt;
+       unsigned int tx_port_stats_ext_cnt;
+       unsigned int stat_size = sizeof(uint64_t);
+       unsigned int stat_count;
 
        bnxt_hwrm_port_qstats(bp);
        bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, &tx_drop_pkts);
+       bnxt_hwrm_ext_port_qstats(bp);
+       rx_port_stats_ext_cnt = bp->fw_rx_port_stats_ext_size / stat_size;
+       tx_port_stats_ext_cnt = bp->fw_tx_port_stats_ext_size / stat_size;
 
        count = RTE_DIM(bnxt_rx_stats_strings) +
-               RTE_DIM(bnxt_tx_stats_strings) + 1; /* For tx_drop_pkts */
+               RTE_DIM(bnxt_tx_stats_strings) + 1/* For tx_drop_pkts */ +
+               RTE_DIM(bnxt_rx_ext_stats_strings) +
+               RTE_DIM(bnxt_tx_ext_stats_strings);
+       stat_count = count;
 
        if (n < count)
                return count;
@@ -296,6 +432,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
        count = 0;
        for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) {
                uint64_t *rx_stats = (uint64_t *)bp->hw_rx_port_stats;
+               xstats[count].id = count;
                xstats[count].value = rte_le_to_cpu_64(
                                *(uint64_t *)((char *)rx_stats +
                                bnxt_rx_stats_strings[i].offset));
@@ -304,6 +441,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
 
        for (i = 0; i < RTE_DIM(bnxt_tx_stats_strings); i++) {
                uint64_t *tx_stats = (uint64_t *)bp->hw_tx_port_stats;
+               xstats[count].id = count;
                xstats[count].value = rte_le_to_cpu_64(
                                 *(uint64_t *)((char *)tx_stats +
                                bnxt_tx_stats_strings[i].offset));
@@ -311,10 +449,31 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
        }
 
        /* The Tx drop pkts aka the Anti spoof coounter */
+       xstats[count].id = count;
        xstats[count].value = rte_le_to_cpu_64(tx_drop_pkts);
        count++;
 
-       return count;
+       for (i = 0; i < tx_port_stats_ext_cnt; i++) {
+               uint64_t *tx_stats_ext = (uint64_t *)bp->hw_tx_port_stats_ext;
+
+               xstats[count].value = rte_le_to_cpu_64
+                                       (*(uint64_t *)((char *)tx_stats_ext +
+                                        bnxt_tx_ext_stats_strings[i].offset));
+
+               count++;
+       }
+
+       for (i = 0; i < rx_port_stats_ext_cnt; i++) {
+               uint64_t *rx_stats_ext = (uint64_t *)bp->hw_rx_port_stats_ext;
+
+               xstats[count].value = rte_le_to_cpu_64
+                                       (*(uint64_t *)((char *)rx_stats_ext +
+                                        bnxt_rx_ext_stats_strings[i].offset));
+
+               count++;
+       }
+
+       return stat_count;
 }
 
 int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
@@ -323,7 +482,9 @@ int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
 {
        /* Account for the Tx drop pkts aka the Anti spoof counter */
        const unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) +
-                               RTE_DIM(bnxt_tx_stats_strings) + 1;
+                               RTE_DIM(bnxt_tx_stats_strings) + 1 +
+                               RTE_DIM(bnxt_rx_ext_stats_strings) +
+                               RTE_DIM(bnxt_tx_ext_stats_strings);
        unsigned int i, count;
 
        if (xstats_names != NULL) {
@@ -350,6 +511,25 @@ int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
                                "%s",
                                bnxt_func_stats_strings[4].name);
                count++;
+
+               for (i = 0; i < RTE_DIM(bnxt_rx_ext_stats_strings); i++) {
+                       snprintf(xstats_names[count].name,
+                                sizeof(xstats_names[count].name),
+                                "%s",
+                                bnxt_rx_ext_stats_strings[i].name);
+
+                       count++;
+               }
+
+               for (i = 0; i < RTE_DIM(bnxt_tx_ext_stats_strings); i++) {
+                       snprintf(xstats_names[count].name,
+                                sizeof(xstats_names[count].name),
+                                "%s",
+                                bnxt_tx_ext_stats_strings[i].name);
+
+                       count++;
+               }
+
        }
        return stat_cnt;
 }
@@ -362,11 +542,11 @@ void bnxt_dev_xstats_reset_op(struct rte_eth_dev *eth_dev)
                bnxt_hwrm_port_clr_stats(bp);
 
        if (BNXT_VF(bp))
-               RTE_LOG(ERR, PMD, "Operation not supported on a VF device\n");
+               PMD_DRV_LOG(ERR, "Operation not supported on a VF device\n");
        if (!BNXT_SINGLE_PF(bp))
-               RTE_LOG(ERR, PMD, "Operation not supported on a MF device\n");
+               PMD_DRV_LOG(ERR, "Operation not supported on a MF device\n");
        if (!(bp->flags & BNXT_FLAG_PORT_STATS))
-               RTE_LOG(ERR, PMD, "Operation not supported\n");
+               PMD_DRV_LOG(ERR, "Operation not supported\n");
 }
 
 int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,
@@ -374,7 +554,9 @@ int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,
 {
        /* Account for the Tx drop pkts aka the Anti spoof counter */
        const unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) +
-                               RTE_DIM(bnxt_tx_stats_strings) + 1;
+                               RTE_DIM(bnxt_tx_stats_strings) + 1 +
+                               RTE_DIM(bnxt_rx_ext_stats_strings) +
+                               RTE_DIM(bnxt_tx_ext_stats_strings);
        struct rte_eth_xstat xstats[stat_cnt];
        uint64_t values_copy[stat_cnt];
        uint16_t i;
@@ -385,7 +567,7 @@ int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,
        bnxt_dev_xstats_get_by_id_op(dev, NULL, values_copy, stat_cnt);
        for (i = 0; i < limit; i++) {
                if (ids[i] >= stat_cnt) {
-                       RTE_LOG(ERR, PMD, "id value isn't valid");
+                       PMD_DRV_LOG(ERR, "id value isn't valid");
                        return -1;
                }
                values[i] = values_copy[ids[i]];
@@ -399,7 +581,9 @@ int bnxt_dev_xstats_get_names_by_id_op(struct rte_eth_dev *dev,
 {
        /* Account for the Tx drop pkts aka the Anti spoof counter */
        const unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) +
-                               RTE_DIM(bnxt_tx_stats_strings) + 1;
+                               RTE_DIM(bnxt_tx_stats_strings) + 1 +
+                               RTE_DIM(bnxt_rx_ext_stats_strings) +
+                               RTE_DIM(bnxt_tx_ext_stats_strings);
        struct rte_eth_xstat_name xstats_names_copy[stat_cnt];
        uint16_t i;
 
@@ -411,7 +595,7 @@ int bnxt_dev_xstats_get_names_by_id_op(struct rte_eth_dev *dev,
 
        for (i = 0; i < limit; i++) {
                if (ids[i] >= stat_cnt) {
-                       RTE_LOG(ERR, PMD, "id value isn't valid");
+                       PMD_DRV_LOG(ERR, "id value isn't valid");
                        return -1;
                }
                strcpy(xstats_names[i].name,