ethdev: add device flag to bypass auto-filled queue xstats
[dpdk.git] / drivers / net / dpaa / dpaa_ethdev.c
index 636ed55..f00279e 100644 (file)
@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  *
  *   Copyright 2016 Freescale Semiconductor, Inc. All rights reserved.
- *   Copyright 2017 NXP
+ *   Copyright 2017-2020 NXP
  *
  */
 /* System headers */
@@ -15,6 +15,7 @@
 #include <sys/types.h>
 #include <sys/syscall.h>
 
+#include <rte_string_fns.h>
 #include <rte_byteorder.h>
 #include <rte_common.h>
 #include <rte_interrupts.h>
 
 #include <dpaa_ethdev.h>
 #include <dpaa_rxtx.h>
+#include <dpaa_flow.h>
 #include <rte_pmd_dpaa.h>
 
 #include <fsl_usd.h>
 #include <fsl_qman.h>
 #include <fsl_bman.h>
 #include <fsl_fman.h>
+#include <process.h>
+#include <fmlib/fm_ext.h>
 
 /* Supported Rx offloads */
 static uint64_t dev_rx_offloads_sup =
-               DEV_RX_OFFLOAD_JUMBO_FRAME;
+               DEV_RX_OFFLOAD_JUMBO_FRAME |
+               DEV_RX_OFFLOAD_SCATTER;
 
 /* Rx offloads which cannot be disabled */
 static uint64_t dev_rx_offloads_nodis =
@@ -55,11 +60,12 @@ static uint64_t dev_rx_offloads_nodis =
                DEV_RX_OFFLOAD_UDP_CKSUM |
                DEV_RX_OFFLOAD_TCP_CKSUM |
                DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
-               DEV_RX_OFFLOAD_CRC_STRIP |
-               DEV_RX_OFFLOAD_SCATTER;
+               DEV_RX_OFFLOAD_RSS_HASH;
 
 /* Supported Tx offloads */
-static uint64_t dev_tx_offloads_sup;
+static uint64_t dev_tx_offloads_sup =
+               DEV_TX_OFFLOAD_MT_LOCKFREE |
+               DEV_TX_OFFLOAD_MBUF_FAST_FREE;
 
 /* Tx offloads which cannot be disabled */
 static uint64_t dev_tx_offloads_nodis =
@@ -68,12 +74,12 @@ static uint64_t dev_tx_offloads_nodis =
                DEV_TX_OFFLOAD_TCP_CKSUM |
                DEV_TX_OFFLOAD_SCTP_CKSUM |
                DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
-               DEV_TX_OFFLOAD_MULTI_SEGS |
-               DEV_TX_OFFLOAD_MT_LOCKFREE |
-               DEV_TX_OFFLOAD_MBUF_FAST_FREE;
+               DEV_TX_OFFLOAD_MULTI_SEGS;
 
 /* Keep track of whether QMAN and BMAN have been globally initialized */
 static int is_global_init;
+static int fmc_q = 1;  /* Indicates the use of static fmc for distribution */
+static int default_q;  /* use default queue - FMC is not executed*/
 /* At present we only allow up to 4 push mode queues as default - as each of
  * this queue need dedicated portal and we are short of portals.
  */
@@ -84,9 +90,12 @@ static int dpaa_push_mode_max_queue = DPAA_DEFAULT_PUSH_MODE_QUEUE;
 static int dpaa_push_queue_idx; /* Queue index which are in push mode*/
 
 
-/* Per FQ Taildrop in frame count */
+/* Per RX FQ Taildrop in frame count */
 static unsigned int td_threshold = CGR_RX_PERFQ_THRESH;
 
+/* Per TX FQ Taildrop in frame count, disabled by default */
+static unsigned int td_tx_threshold;
+
 struct rte_dpaa_xstats_name_off {
        char name[RTE_ETH_XSTATS_NAME_SIZE];
        uint32_t offset;
@@ -123,9 +132,14 @@ static const struct rte_dpaa_xstats_name_off dpaa_xstats_strings[] = {
 
 static struct rte_dpaa_driver rte_dpaa_pmd;
 
-static void
+static int
 dpaa_eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info);
 
+static int dpaa_eth_link_update(struct rte_eth_dev *dev,
+                               int wait_to_complete __rte_unused);
+
+static void dpaa_interrupt_handler(void *param);
+
 static inline void
 dpaa_poll_queue_default_config(struct qm_mcc_initfq *opts)
 {
@@ -144,16 +158,34 @@ dpaa_poll_queue_default_config(struct qm_mcc_initfq *opts)
 static int
 dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
-       uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN
+       uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN
                                + VLAN_TAG_SIZE;
+       uint32_t buffsz = dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM;
 
        PMD_INIT_FUNC_TRACE();
 
-       if (mtu < ETHER_MIN_MTU || frame_size > DPAA_MAX_RX_PKT_LEN)
+       if (mtu < RTE_ETHER_MIN_MTU || frame_size > DPAA_MAX_RX_PKT_LEN)
                return -EINVAL;
-       if (frame_size > ETHER_MAX_LEN)
-               dev->data->dev_conf.rxmode.offloads &=
+       /*
+        * Refuse mtu that requires the support of scattered packets
+        * when this feature has not been enabled before.
+        */
+       if (dev->data->min_rx_buf_size &&
+               !dev->data->scattered_rx && frame_size > buffsz) {
+               DPAA_PMD_ERR("SG not enabled, will not fit in one buffer");
+               return -EINVAL;
+       }
+
+       /* check <seg size> * <max_seg>  >= max_frame */
+       if (dev->data->min_rx_buf_size && dev->data->scattered_rx &&
+               (frame_size > buffsz * DPAA_SGT_MAX_ENTRIES)) {
+               DPAA_PMD_ERR("Too big to fit for Max SG list %d",
+                               buffsz * DPAA_SGT_MAX_ENTRIES);
+               return -EINVAL;
+       }
+
+       if (frame_size > RTE_ETHER_MAX_LEN)
+               dev->data->dev_conf.rxmode.offloads |=
                                                DEV_RX_OFFLOAD_JUMBO_FRAME;
        else
                dev->data->dev_conf.rxmode.offloads &=
@@ -161,7 +193,7 @@ dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 
        dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
 
-       fman_if_set_maxfrm(dpaa_intf->fif, frame_size);
+       fman_if_set_maxfrm(dev->process_private, frame_size);
 
        return 0;
 }
@@ -169,55 +201,153 @@ dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 static int
 dpaa_eth_dev_configure(struct rte_eth_dev *dev)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
        struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
        uint64_t rx_offloads = eth_conf->rxmode.offloads;
        uint64_t tx_offloads = eth_conf->txmode.offloads;
+       struct rte_device *rdev = dev->device;
+       struct rte_eth_link *link = &dev->data->dev_link;
+       struct rte_dpaa_device *dpaa_dev;
+       struct fman_if *fif = dev->process_private;
+       struct __fman_if *__fif;
+       struct rte_intr_handle *intr_handle;
+       int speed, duplex;
+       int ret;
 
        PMD_INIT_FUNC_TRACE();
 
-       /* Rx offloads validation */
-       if (~(dev_rx_offloads_sup | dev_rx_offloads_nodis) & rx_offloads) {
-               DPAA_PMD_ERR(
-               "Rx offloads non supported - requested 0x%" PRIx64
-               " supported 0x%" PRIx64,
-                       rx_offloads,
-                       dev_rx_offloads_sup | dev_rx_offloads_nodis);
-               return -ENOTSUP;
-       }
+       dpaa_dev = container_of(rdev, struct rte_dpaa_device, device);
+       intr_handle = &dpaa_dev->intr_handle;
+       __fif = container_of(fif, struct __fman_if, __if);
+
+       /* Rx offloads which are enabled by default */
        if (dev_rx_offloads_nodis & ~rx_offloads) {
-               DPAA_PMD_WARN(
-               "Rx offloads non configurable - requested 0x%" PRIx64
-               " ignored 0x%" PRIx64,
-                       rx_offloads, dev_rx_offloads_nodis);
+               DPAA_PMD_INFO(
+               "Some of rx offloads enabled by default - requested 0x%" PRIx64
+               " fixed are 0x%" PRIx64,
+               rx_offloads, dev_rx_offloads_nodis);
        }
 
-       /* Tx offloads validation */
-       if (~(dev_tx_offloads_sup | dev_tx_offloads_nodis) & tx_offloads) {
-               DPAA_PMD_ERR(
-               "Tx offloads non supported - requested 0x%" PRIx64
-               " supported 0x%" PRIx64,
-                       tx_offloads,
-                       dev_tx_offloads_sup | dev_tx_offloads_nodis);
-               return -ENOTSUP;
-       }
+       /* Tx offloads which are enabled by default */
        if (dev_tx_offloads_nodis & ~tx_offloads) {
-               DPAA_PMD_WARN(
-               "Tx offloads non configurable - requested 0x%" PRIx64
-               " ignored 0x%" PRIx64,
-                       tx_offloads, dev_tx_offloads_nodis);
+               DPAA_PMD_INFO(
+               "Some of tx offloads enabled by default - requested 0x%" PRIx64
+               " fixed are 0x%" PRIx64,
+               tx_offloads, dev_tx_offloads_nodis);
        }
 
        if (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
+               uint32_t max_len;
+
+               DPAA_PMD_DEBUG("enabling jumbo");
+
                if (dev->data->dev_conf.rxmode.max_rx_pkt_len <=
-                   DPAA_MAX_RX_PKT_LEN) {
-                       fman_if_set_maxfrm(dpaa_intf->fif,
-                               dev->data->dev_conf.rxmode.max_rx_pkt_len);
-                       return 0;
-               } else {
+                   DPAA_MAX_RX_PKT_LEN)
+                       max_len = dev->data->dev_conf.rxmode.max_rx_pkt_len;
+               else {
+                       DPAA_PMD_INFO("enabling jumbo override conf max len=%d "
+                               "supported is %d",
+                               dev->data->dev_conf.rxmode.max_rx_pkt_len,
+                               DPAA_MAX_RX_PKT_LEN);
+                       max_len = DPAA_MAX_RX_PKT_LEN;
+               }
+
+               fman_if_set_maxfrm(dev->process_private, max_len);
+               dev->data->mtu = max_len
+                       - RTE_ETHER_HDR_LEN - RTE_ETHER_CRC_LEN - VLAN_TAG_SIZE;
+       }
+
+       if (rx_offloads & DEV_RX_OFFLOAD_SCATTER) {
+               DPAA_PMD_DEBUG("enabling scatter mode");
+               fman_if_set_sg(dev->process_private, 1);
+               dev->data->scattered_rx = 1;
+       }
+
+       if (!(default_q || fmc_q)) {
+               if (dpaa_fm_config(dev,
+                       eth_conf->rx_adv_conf.rss_conf.rss_hf)) {
+                       dpaa_write_fm_config_to_file();
+                       DPAA_PMD_ERR("FM port configuration: Failed\n");
                        return -1;
                }
+               dpaa_write_fm_config_to_file();
        }
+
+       /* if the interrupts were configured on this devices*/
+       if (intr_handle && intr_handle->fd) {
+               if (dev->data->dev_conf.intr_conf.lsc != 0)
+                       rte_intr_callback_register(intr_handle,
+                                          dpaa_interrupt_handler,
+                                          (void *)dev);
+
+               ret = dpaa_intr_enable(__fif->node_name, intr_handle->fd);
+               if (ret) {
+                       if (dev->data->dev_conf.intr_conf.lsc != 0) {
+                               rte_intr_callback_unregister(intr_handle,
+                                       dpaa_interrupt_handler,
+                                       (void *)dev);
+                               if (ret == EINVAL)
+                                       printf("Failed to enable interrupt: Not Supported\n");
+                               else
+                                       printf("Failed to enable interrupt\n");
+                       }
+                       dev->data->dev_conf.intr_conf.lsc = 0;
+                       dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC;
+               }
+       }
+
+       /* Wait for link status to get updated */
+       if (!link->link_status)
+               sleep(1);
+
+       /* Configure link only if link is UP*/
+       if (link->link_status) {
+               if (eth_conf->link_speeds == ETH_LINK_SPEED_AUTONEG) {
+                       /* Start autoneg only if link is not in autoneg mode */
+                       if (!link->link_autoneg)
+                               dpaa_restart_link_autoneg(__fif->node_name);
+               } else if (eth_conf->link_speeds & ETH_LINK_SPEED_FIXED) {
+                       switch (eth_conf->link_speeds & ~ETH_LINK_SPEED_FIXED) {
+                       case ETH_LINK_SPEED_10M_HD:
+                               speed = ETH_SPEED_NUM_10M;
+                               duplex = ETH_LINK_HALF_DUPLEX;
+                               break;
+                       case ETH_LINK_SPEED_10M:
+                               speed = ETH_SPEED_NUM_10M;
+                               duplex = ETH_LINK_FULL_DUPLEX;
+                               break;
+                       case ETH_LINK_SPEED_100M_HD:
+                               speed = ETH_SPEED_NUM_100M;
+                               duplex = ETH_LINK_HALF_DUPLEX;
+                               break;
+                       case ETH_LINK_SPEED_100M:
+                               speed = ETH_SPEED_NUM_100M;
+                               duplex = ETH_LINK_FULL_DUPLEX;
+                               break;
+                       case ETH_LINK_SPEED_1G:
+                               speed = ETH_SPEED_NUM_1G;
+                               duplex = ETH_LINK_FULL_DUPLEX;
+                               break;
+                       case ETH_LINK_SPEED_2_5G:
+                               speed = ETH_SPEED_NUM_2_5G;
+                               duplex = ETH_LINK_FULL_DUPLEX;
+                               break;
+                       case ETH_LINK_SPEED_10G:
+                               speed = ETH_SPEED_NUM_10G;
+                               duplex = ETH_LINK_FULL_DUPLEX;
+                               break;
+                       default:
+                               speed = ETH_SPEED_NUM_NONE;
+                               duplex = ETH_LINK_FULL_DUPLEX;
+                               break;
+                       }
+                       /* Set link speed */
+                       dpaa_update_link_speed(__fif->node_name, speed, duplex);
+               } else {
+                       /* Manual autoneg - custom advertisement speed. */
+                       printf("Custom Advertisement speeds not supported\n");
+               }
+       }
+
        return 0;
 }
 
@@ -225,12 +355,15 @@ static const uint32_t *
 dpaa_supported_ptypes_get(struct rte_eth_dev *dev)
 {
        static const uint32_t ptypes[] = {
-               /*todo -= add more types */
                RTE_PTYPE_L2_ETHER,
-               RTE_PTYPE_L3_IPV4,
-               RTE_PTYPE_L3_IPV4_EXT,
-               RTE_PTYPE_L3_IPV6,
-               RTE_PTYPE_L3_IPV6_EXT,
+               RTE_PTYPE_L2_ETHER_VLAN,
+               RTE_PTYPE_L2_ETHER_ARP,
+               RTE_PTYPE_L3_IPV4_EXT_UNKNOWN,
+               RTE_PTYPE_L3_IPV6_EXT_UNKNOWN,
+               RTE_PTYPE_L4_ICMP,
+               RTE_PTYPE_L4_TCP,
+               RTE_PTYPE_L4_UDP,
+               RTE_PTYPE_L4_FRAG,
                RTE_PTYPE_L4_TCP,
                RTE_PTYPE_L4_UDP,
                RTE_PTYPE_L4_SCTP
@@ -243,34 +376,138 @@ dpaa_supported_ptypes_get(struct rte_eth_dev *dev)
        return NULL;
 }
 
+static void dpaa_interrupt_handler(void *param)
+{
+       struct rte_eth_dev *dev = param;
+       struct rte_device *rdev = dev->device;
+       struct rte_dpaa_device *dpaa_dev;
+       struct rte_intr_handle *intr_handle;
+       uint64_t buf;
+       int bytes_read;
+
+       dpaa_dev = container_of(rdev, struct rte_dpaa_device, device);
+       intr_handle = &dpaa_dev->intr_handle;
+
+       bytes_read = read(intr_handle->fd, &buf, sizeof(uint64_t));
+       if (bytes_read < 0)
+               DPAA_PMD_ERR("Error reading eventfd\n");
+       dpaa_eth_link_update(dev, 0);
+       rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);
+}
+
 static int dpaa_eth_dev_start(struct rte_eth_dev *dev)
 {
        struct dpaa_if *dpaa_intf = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE();
 
+       if (!(default_q || fmc_q))
+               dpaa_write_fm_config_to_file();
+
        /* Change tx callback to the real one */
-       dev->tx_pkt_burst = dpaa_eth_queue_tx;
-       fman_if_enable_rx(dpaa_intf->fif);
+       if (dpaa_intf->cgr_tx)
+               dev->tx_pkt_burst = dpaa_eth_queue_tx_slow;
+       else
+               dev->tx_pkt_burst = dpaa_eth_queue_tx;
+
+       fman_if_enable_rx(dev->process_private);
 
        return 0;
 }
 
-static void dpaa_eth_dev_stop(struct rte_eth_dev *dev)
+static int dpaa_eth_dev_stop(struct rte_eth_dev *dev)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct fman_if *fif = dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
+       dev->data->dev_started = 0;
 
-       fman_if_disable_rx(dpaa_intf->fif);
+       if (!fif->is_shared_mac)
+               fman_if_disable_rx(fif);
        dev->tx_pkt_burst = dpaa_eth_tx_drop_all;
+
+       return 0;
 }
 
-static void dpaa_eth_dev_close(struct rte_eth_dev *dev)
+static int dpaa_eth_dev_close(struct rte_eth_dev *dev)
 {
+       struct fman_if *fif = dev->process_private;
+       struct __fman_if *__fif;
+       struct rte_device *rdev = dev->device;
+       struct rte_dpaa_device *dpaa_dev;
+       struct rte_intr_handle *intr_handle;
+       struct rte_eth_link *link = &dev->data->dev_link;
+       struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       int loop;
+       int ret;
+
        PMD_INIT_FUNC_TRACE();
 
-       dpaa_eth_dev_stop(dev);
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
+       if (!dpaa_intf) {
+               DPAA_PMD_WARN("Already closed or not started");
+               return -1;
+       }
+
+       /* DPAA FM deconfig */
+       if (!(default_q || fmc_q)) {
+               if (dpaa_fm_deconfig(dpaa_intf, dev->process_private))
+                       DPAA_PMD_WARN("DPAA FM deconfig failed\n");
+       }
+
+       dpaa_dev = container_of(rdev, struct rte_dpaa_device, device);
+       intr_handle = &dpaa_dev->intr_handle;
+       __fif = container_of(fif, struct __fman_if, __if);
+
+       ret = dpaa_eth_dev_stop(dev);
+
+       /* Reset link to autoneg */
+       if (link->link_status && !link->link_autoneg)
+               dpaa_restart_link_autoneg(__fif->node_name);
+
+       if (intr_handle && intr_handle->fd &&
+           dev->data->dev_conf.intr_conf.lsc != 0) {
+               dpaa_intr_disable(__fif->node_name);
+               rte_intr_callback_unregister(intr_handle,
+                                            dpaa_interrupt_handler,
+                                            (void *)dev);
+       }
+
+       /* release configuration memory */
+       if (dpaa_intf->fc_conf)
+               rte_free(dpaa_intf->fc_conf);
+
+       /* Release RX congestion Groups */
+       if (dpaa_intf->cgr_rx) {
+               for (loop = 0; loop < dpaa_intf->nb_rx_queues; loop++)
+                       qman_delete_cgr(&dpaa_intf->cgr_rx[loop]);
+
+               qman_release_cgrid_range(dpaa_intf->cgr_rx[loop].cgrid,
+                                        dpaa_intf->nb_rx_queues);
+       }
+
+       rte_free(dpaa_intf->cgr_rx);
+       dpaa_intf->cgr_rx = NULL;
+       /* Release TX congestion Groups */
+       if (dpaa_intf->cgr_tx) {
+               for (loop = 0; loop < MAX_DPAA_CORES; loop++)
+                       qman_delete_cgr(&dpaa_intf->cgr_tx[loop]);
+
+               qman_release_cgrid_range(dpaa_intf->cgr_tx[loop].cgrid,
+                                        MAX_DPAA_CORES);
+               rte_free(dpaa_intf->cgr_tx);
+               dpaa_intf->cgr_tx = NULL;
+       }
+
+       rte_free(dpaa_intf->rx_queues);
+       dpaa_intf->rx_queues = NULL;
+
+       rte_free(dpaa_intf->tx_queues);
+       dpaa_intf->tx_queues = NULL;
+
+       return ret;
 }
 
 static int
@@ -306,28 +543,129 @@ dpaa_fw_version_get(struct rte_eth_dev *dev __rte_unused,
                return 0;
 }
 
-static void dpaa_eth_dev_info(struct rte_eth_dev *dev,
-                             struct rte_eth_dev_info *dev_info)
+static int dpaa_eth_dev_info(struct rte_eth_dev *dev,
+                            struct rte_eth_dev_info *dev_info)
 {
        struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct fman_if *fif = dev->process_private;
 
-       PMD_INIT_FUNC_TRACE();
+       DPAA_PMD_DEBUG(": %s", dpaa_intf->name);
 
        dev_info->max_rx_queues = dpaa_intf->nb_rx_queues;
        dev_info->max_tx_queues = dpaa_intf->nb_tx_queues;
-       dev_info->min_rx_bufsize = DPAA_MIN_RX_BUF_SIZE;
        dev_info->max_rx_pktlen = DPAA_MAX_RX_PKT_LEN;
        dev_info->max_mac_addrs = DPAA_MAX_MAC_FILTER;
        dev_info->max_hash_mac_addrs = 0;
        dev_info->max_vfs = 0;
        dev_info->max_vmdq_pools = ETH_16_POOLS;
        dev_info->flow_type_rss_offloads = DPAA_RSS_OFFLOAD_ALL;
-       dev_info->speed_capa = (ETH_LINK_SPEED_1G |
-                               ETH_LINK_SPEED_10G);
+
+       if (fif->mac_type == fman_mac_1g) {
+               dev_info->speed_capa = ETH_LINK_SPEED_10M_HD
+                                       | ETH_LINK_SPEED_10M
+                                       | ETH_LINK_SPEED_100M_HD
+                                       | ETH_LINK_SPEED_100M
+                                       | ETH_LINK_SPEED_1G;
+       } else if (fif->mac_type == fman_mac_2_5g) {
+               dev_info->speed_capa = ETH_LINK_SPEED_10M_HD
+                                       | ETH_LINK_SPEED_10M
+                                       | ETH_LINK_SPEED_100M_HD
+                                       | ETH_LINK_SPEED_100M
+                                       | ETH_LINK_SPEED_1G
+                                       | ETH_LINK_SPEED_2_5G;
+       } else if (fif->mac_type == fman_mac_10g) {
+               dev_info->speed_capa = ETH_LINK_SPEED_10M_HD
+                                       | ETH_LINK_SPEED_10M
+                                       | ETH_LINK_SPEED_100M_HD
+                                       | ETH_LINK_SPEED_100M
+                                       | ETH_LINK_SPEED_1G
+                                       | ETH_LINK_SPEED_2_5G
+                                       | ETH_LINK_SPEED_10G;
+       } else {
+               DPAA_PMD_ERR("invalid link_speed: %s, %d",
+                            dpaa_intf->name, fif->mac_type);
+               return -EINVAL;
+       }
+
        dev_info->rx_offload_capa = dev_rx_offloads_sup |
                                        dev_rx_offloads_nodis;
        dev_info->tx_offload_capa = dev_tx_offloads_sup |
                                        dev_tx_offloads_nodis;
+       dev_info->default_rxportconf.burst_size = DPAA_DEF_RX_BURST_SIZE;
+       dev_info->default_txportconf.burst_size = DPAA_DEF_TX_BURST_SIZE;
+       dev_info->default_rxportconf.nb_queues = 1;
+       dev_info->default_txportconf.nb_queues = 1;
+       dev_info->default_txportconf.ring_size = CGR_TX_CGR_THRESH;
+       dev_info->default_rxportconf.ring_size = CGR_RX_PERFQ_THRESH;
+
+       return 0;
+}
+
+static int
+dpaa_dev_rx_burst_mode_get(struct rte_eth_dev *dev,
+                       __rte_unused uint16_t queue_id,
+                       struct rte_eth_burst_mode *mode)
+{
+       struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
+       int ret = -EINVAL;
+       unsigned int i;
+       const struct burst_info {
+               uint64_t flags;
+               const char *output;
+       } rx_offload_map[] = {
+                       {DEV_RX_OFFLOAD_JUMBO_FRAME, " Jumbo frame,"},
+                       {DEV_RX_OFFLOAD_SCATTER, " Scattered,"},
+                       {DEV_RX_OFFLOAD_IPV4_CKSUM, " IPV4 csum,"},
+                       {DEV_RX_OFFLOAD_UDP_CKSUM, " UDP csum,"},
+                       {DEV_RX_OFFLOAD_TCP_CKSUM, " TCP csum,"},
+                       {DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM, " Outer IPV4 csum,"},
+                       {DEV_RX_OFFLOAD_RSS_HASH, " RSS,"}
+       };
+
+       /* Update Rx offload info */
+       for (i = 0; i < RTE_DIM(rx_offload_map); i++) {
+               if (eth_conf->rxmode.offloads & rx_offload_map[i].flags) {
+                       snprintf(mode->info, sizeof(mode->info), "%s",
+                               rx_offload_map[i].output);
+                       ret = 0;
+                       break;
+               }
+       }
+       return ret;
+}
+
+static int
+dpaa_dev_tx_burst_mode_get(struct rte_eth_dev *dev,
+                       __rte_unused uint16_t queue_id,
+                       struct rte_eth_burst_mode *mode)
+{
+       struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
+       int ret = -EINVAL;
+       unsigned int i;
+       const struct burst_info {
+               uint64_t flags;
+               const char *output;
+       } tx_offload_map[] = {
+                       {DEV_TX_OFFLOAD_MT_LOCKFREE, " MT lockfree,"},
+                       {DEV_TX_OFFLOAD_MBUF_FAST_FREE, " MBUF free disable,"},
+                       {DEV_TX_OFFLOAD_IPV4_CKSUM, " IPV4 csum,"},
+                       {DEV_TX_OFFLOAD_UDP_CKSUM, " UDP csum,"},
+                       {DEV_TX_OFFLOAD_TCP_CKSUM, " TCP csum,"},
+                       {DEV_TX_OFFLOAD_SCTP_CKSUM, " SCTP csum,"},
+                       {DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM, " Outer IPV4 csum,"},
+                       {DEV_TX_OFFLOAD_MULTI_SEGS, " Scattered,"}
+       };
+
+       /* Update Tx offload info */
+       for (i = 0; i < RTE_DIM(tx_offload_map); i++) {
+               if (eth_conf->txmode.offloads & tx_offload_map[i].flags) {
+                       snprintf(mode->info, sizeof(mode->info), "%s",
+                               tx_offload_map[i].output);
+                       ret = 0;
+                       break;
+               }
+       }
+       return ret;
 }
 
 static int dpaa_eth_link_update(struct rte_eth_dev *dev,
@@ -335,48 +673,65 @@ static int dpaa_eth_link_update(struct rte_eth_dev *dev,
 {
        struct dpaa_if *dpaa_intf = dev->data->dev_private;
        struct rte_eth_link *link = &dev->data->dev_link;
+       struct fman_if *fif = dev->process_private;
+       struct __fman_if *__fif = container_of(fif, struct __fman_if, __if);
+       int ret, ioctl_version;
 
        PMD_INIT_FUNC_TRACE();
 
-       if (dpaa_intf->fif->mac_type == fman_mac_1g)
-               link->link_speed = ETH_SPEED_NUM_1G;
-       else if (dpaa_intf->fif->mac_type == fman_mac_10g)
-               link->link_speed = ETH_SPEED_NUM_10G;
-       else
-               DPAA_PMD_ERR("invalid link_speed: %s, %d",
-                            dpaa_intf->name, dpaa_intf->fif->mac_type);
+       ioctl_version = dpaa_get_ioctl_version_number();
+
+
+       if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) {
+               ret = dpaa_get_link_status(__fif->node_name, link);
+               if (ret)
+                       return ret;
+       } else {
+               link->link_status = dpaa_intf->valid;
+       }
+
+       if (ioctl_version < 2) {
+               link->link_duplex = ETH_LINK_FULL_DUPLEX;
+               link->link_autoneg = ETH_LINK_AUTONEG;
+
+               if (fif->mac_type == fman_mac_1g)
+                       link->link_speed = ETH_SPEED_NUM_1G;
+               else if (fif->mac_type == fman_mac_2_5g)
+                       link->link_speed = ETH_SPEED_NUM_2_5G;
+               else if (fif->mac_type == fman_mac_10g)
+                       link->link_speed = ETH_SPEED_NUM_10G;
+               else
+                       DPAA_PMD_ERR("invalid link_speed: %s, %d",
+                                    dpaa_intf->name, fif->mac_type);
+       }
 
-       link->link_status = dpaa_intf->valid;
-       link->link_duplex = ETH_LINK_FULL_DUPLEX;
-       link->link_autoneg = ETH_LINK_AUTONEG;
+       DPAA_PMD_INFO("Port %d Link is %s\n", dev->data->port_id,
+                     link->link_status ? "Up" : "Down");
        return 0;
 }
 
 static int dpaa_eth_stats_get(struct rte_eth_dev *dev,
                               struct rte_eth_stats *stats)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
-
        PMD_INIT_FUNC_TRACE();
 
-       fman_if_stats_get(dpaa_intf->fif, stats);
+       fman_if_stats_get(dev->process_private, stats);
        return 0;
 }
 
-static void dpaa_eth_stats_reset(struct rte_eth_dev *dev)
+static int dpaa_eth_stats_reset(struct rte_eth_dev *dev)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
-
        PMD_INIT_FUNC_TRACE();
 
-       fman_if_stats_reset(dpaa_intf->fif);
+       fman_if_stats_reset(dev->process_private);
+
+       return 0;
 }
 
 static int
 dpaa_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
                    unsigned int n)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
        unsigned int i = 0, num = RTE_DIM(dpaa_xstats_strings);
        uint64_t values[sizeof(struct dpaa_if_stats) / 8];
 
@@ -386,7 +741,7 @@ dpaa_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
        if (xstats == NULL)
                return 0;
 
-       fman_if_stats_get_all(dpaa_intf->fif, values,
+       fman_if_stats_get_all(dev->process_private, values,
                              sizeof(struct dpaa_if_stats) / 8);
 
        for (i = 0; i < num; i++) {
@@ -408,10 +763,9 @@ dpaa_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
 
        if (xstats_names != NULL)
                for (i = 0; i < stat_cnt; i++)
-                       snprintf(xstats_names[i].name,
-                                sizeof(xstats_names[i].name),
-                                "%s",
-                                dpaa_xstats_strings[i].name);
+                       strlcpy(xstats_names[i].name,
+                               dpaa_xstats_strings[i].name,
+                               sizeof(xstats_names[i].name));
 
        return stat_cnt;
 }
@@ -424,15 +778,13 @@ dpaa_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
        uint64_t values_copy[sizeof(struct dpaa_if_stats) / 8];
 
        if (!ids) {
-               struct dpaa_if *dpaa_intf = dev->data->dev_private;
-
                if (n < stat_cnt)
                        return stat_cnt;
 
                if (!values)
                        return 0;
 
-               fman_if_stats_get_all(dpaa_intf->fif, values_copy,
+               fman_if_stats_get_all(dev->process_private, values_copy,
                                      sizeof(struct dpaa_if_stats) / 8);
 
                for (i = 0; i < stat_cnt; i++)
@@ -479,91 +831,205 @@ dpaa_xstats_get_names_by_id(
        return limit;
 }
 
-static void dpaa_eth_promiscuous_enable(struct rte_eth_dev *dev)
+static int dpaa_eth_promiscuous_enable(struct rte_eth_dev *dev)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
-
        PMD_INIT_FUNC_TRACE();
 
-       fman_if_promiscuous_enable(dpaa_intf->fif);
+       fman_if_promiscuous_enable(dev->process_private);
+
+       return 0;
 }
 
-static void dpaa_eth_promiscuous_disable(struct rte_eth_dev *dev)
+static int dpaa_eth_promiscuous_disable(struct rte_eth_dev *dev)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
-
        PMD_INIT_FUNC_TRACE();
 
-       fman_if_promiscuous_disable(dpaa_intf->fif);
+       fman_if_promiscuous_disable(dev->process_private);
+
+       return 0;
 }
 
-static void dpaa_eth_multicast_enable(struct rte_eth_dev *dev)
+static int dpaa_eth_multicast_enable(struct rte_eth_dev *dev)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       PMD_INIT_FUNC_TRACE();
+
+       fman_if_set_mcast_filter_table(dev->process_private);
+
+       return 0;
+}
 
+static int dpaa_eth_multicast_disable(struct rte_eth_dev *dev)
+{
        PMD_INIT_FUNC_TRACE();
 
-       fman_if_set_mcast_filter_table(dpaa_intf->fif);
+       fman_if_reset_mcast_filter_table(dev->process_private);
+
+       return 0;
 }
 
-static void dpaa_eth_multicast_disable(struct rte_eth_dev *dev)
+static void dpaa_fman_if_pool_setup(struct rte_eth_dev *dev)
 {
        struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct fman_if_ic_params icp;
+       uint32_t fd_offset;
+       uint32_t bp_size;
+
+       memset(&icp, 0, sizeof(icp));
+       /* set ICEOF for to the default value , which is 0*/
+       icp.iciof = DEFAULT_ICIOF;
+       icp.iceof = DEFAULT_RX_ICEOF;
+       icp.icsz = DEFAULT_ICSZ;
+       fman_if_set_ic_params(dev->process_private, &icp);
+
+       fd_offset = RTE_PKTMBUF_HEADROOM + DPAA_HW_BUF_RESERVE;
+       fman_if_set_fdoff(dev->process_private, fd_offset);
+
+       /* Buffer pool size should be equal to Dataroom Size*/
+       bp_size = rte_pktmbuf_data_room_size(dpaa_intf->bp_info->mp);
+
+       fman_if_set_bp(dev->process_private,
+                      dpaa_intf->bp_info->mp->size,
+                      dpaa_intf->bp_info->bpid, bp_size);
+}
 
-       PMD_INIT_FUNC_TRACE();
+static inline int dpaa_eth_rx_queue_bp_check(struct rte_eth_dev *dev,
+                                            int8_t vsp_id, uint32_t bpid)
+{
+       struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct fman_if *fif = dev->process_private;
+
+       if (fif->num_profiles) {
+               if (vsp_id < 0)
+                       vsp_id = fif->base_profile_id;
+       } else {
+               if (vsp_id < 0)
+                       vsp_id = 0;
+       }
+
+       if (dpaa_intf->vsp_bpid[vsp_id] &&
+               bpid != dpaa_intf->vsp_bpid[vsp_id]) {
+               DPAA_PMD_ERR("Various MPs are assigned to RXQs with same VSP");
+
+               return -1;
+       }
 
-       fman_if_reset_mcast_filter_table(dpaa_intf->fif);
+       return 0;
 }
 
 static
 int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                            uint16_t nb_desc,
                            unsigned int socket_id __rte_unused,
-                           const struct rte_eth_rxconf *rx_conf __rte_unused,
+                           const struct rte_eth_rxconf *rx_conf,
                            struct rte_mempool *mp)
 {
        struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct fman_if *fif = dev->process_private;
        struct qman_fq *rxq = &dpaa_intf->rx_queues[queue_idx];
        struct qm_mcc_initfq opts = {0};
        u32 flags = 0;
        int ret;
+       u32 buffsz = rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM;
 
        PMD_INIT_FUNC_TRACE();
 
-       DPAA_PMD_INFO("Rx queue setup for queue index: %d", queue_idx);
+       if (queue_idx >= dev->data->nb_rx_queues) {
+               rte_errno = EOVERFLOW;
+               DPAA_PMD_ERR("%p: queue index out of range (%u >= %u)",
+                     (void *)dev, queue_idx, dev->data->nb_rx_queues);
+               return -rte_errno;
+       }
 
-       if (!dpaa_intf->bp_info || dpaa_intf->bp_info->mp != mp) {
-               struct fman_if_ic_params icp;
-               uint32_t fd_offset;
-               uint32_t bp_size;
+       /* Rx deferred start is not supported */
+       if (rx_conf->rx_deferred_start) {
+               DPAA_PMD_ERR("%p:Rx deferred start not supported", (void *)dev);
+               return -EINVAL;
+       }
+       rxq->nb_desc = UINT16_MAX;
+       rxq->offloads = rx_conf->offloads;
+
+       DPAA_PMD_INFO("Rx queue setup for queue index: %d fq_id (0x%x)",
+                       queue_idx, rxq->fqid);
+
+       if (!fif->num_profiles) {
+               if (dpaa_intf->bp_info && dpaa_intf->bp_info->bp &&
+                       dpaa_intf->bp_info->mp != mp) {
+                       DPAA_PMD_WARN("Multiple pools on same interface not"
+                                     " supported");
+                       return -EINVAL;
+               }
+       } else {
+               if (dpaa_eth_rx_queue_bp_check(dev, rxq->vsp_id,
+                       DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid)) {
+                       return -EINVAL;
+               }
+       }
 
-               if (!mp->pool_data) {
-                       DPAA_PMD_ERR("Not an offloaded buffer pool!");
-                       return -1;
+       /* Max packet can fit in single buffer */
+       if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) {
+               ;
+       } else if (dev->data->dev_conf.rxmode.offloads &
+                       DEV_RX_OFFLOAD_SCATTER) {
+               if (dev->data->dev_conf.rxmode.max_rx_pkt_len >
+                       buffsz * DPAA_SGT_MAX_ENTRIES) {
+                       DPAA_PMD_ERR("max RxPkt size %d too big to fit "
+                               "MaxSGlist %d",
+                               dev->data->dev_conf.rxmode.max_rx_pkt_len,
+                               buffsz * DPAA_SGT_MAX_ENTRIES);
+                       rte_errno = EOVERFLOW;
+                       return -rte_errno;
+               }
+       } else {
+               DPAA_PMD_WARN("The requested maximum Rx packet size (%u) is"
+                    " larger than a single mbuf (%u) and scattered"
+                    " mode has not been requested",
+                    dev->data->dev_conf.rxmode.max_rx_pkt_len,
+                    buffsz - RTE_PKTMBUF_HEADROOM);
+       }
+
+       dpaa_intf->bp_info = DPAA_MEMPOOL_TO_POOL_INFO(mp);
+
+       /* For shared interface, it's done in kernel, skip.*/
+       if (!fif->is_shared_mac)
+               dpaa_fman_if_pool_setup(dev);
+
+       if (fif->num_profiles) {
+               int8_t vsp_id = rxq->vsp_id;
+
+               if (vsp_id >= 0) {
+                       ret = dpaa_port_vsp_update(dpaa_intf, fmc_q, vsp_id,
+                                       DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid,
+                                       fif);
+                       if (ret) {
+                               DPAA_PMD_ERR("dpaa_port_vsp_update failed");
+                               return ret;
+                       }
+               } else {
+                       DPAA_PMD_INFO("Base profile is associated to"
+                               " RXQ fqid:%d\r\n", rxq->fqid);
+                       if (fif->is_shared_mac) {
+                               DPAA_PMD_ERR("Fatal: Base profile is associated"
+                                            " to shared interface on DPDK.");
+                               return -EINVAL;
+                       }
+                       dpaa_intf->vsp_bpid[fif->base_profile_id] =
+                               DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid;
                }
-               dpaa_intf->bp_info = DPAA_MEMPOOL_TO_POOL_INFO(mp);
-
-               memset(&icp, 0, sizeof(icp));
-               /* set ICEOF for to the default value , which is 0*/
-               icp.iciof = DEFAULT_ICIOF;
-               icp.iceof = DEFAULT_RX_ICEOF;
-               icp.icsz = DEFAULT_ICSZ;
-               fman_if_set_ic_params(dpaa_intf->fif, &icp);
-
-               fd_offset = RTE_PKTMBUF_HEADROOM + DPAA_HW_BUF_RESERVE;
-               fman_if_set_fdoff(dpaa_intf->fif, fd_offset);
-
-               /* Buffer pool size should be equal to Dataroom Size*/
-               bp_size = rte_pktmbuf_data_room_size(mp);
-               fman_if_set_bp(dpaa_intf->fif, mp->size,
-                              dpaa_intf->bp_info->bpid, bp_size);
-               dpaa_intf->valid = 1;
-               DPAA_PMD_INFO("if =%s - fd_offset = %d offset = %d",
-                           dpaa_intf->name, fd_offset,
-                       fman_if_get_fdoff(dpaa_intf->fif));
+       } else {
+               dpaa_intf->vsp_bpid[0] =
+                       DPAA_MEMPOOL_TO_POOL_INFO(mp)->bpid;
        }
+
+       dpaa_intf->valid = 1;
+       DPAA_PMD_DEBUG("if:%s sg_on = %d, max_frm =%d", dpaa_intf->name,
+               fman_if_get_sg_enable(fif),
+               dev->data->dev_conf.rxmode.max_rx_pkt_len);
        /* checking if push mode only, no error check for now */
-       if (dpaa_push_mode_max_queue > dpaa_push_queue_idx) {
+       if (!rxq->is_static &&
+           dpaa_push_mode_max_queue > dpaa_push_queue_idx) {
+               struct qman_portal *qp;
+               int q_fd;
+
                dpaa_push_queue_idx++;
                opts.we_mask = QM_INITFQ_WE_FQCTRL | QM_INITFQ_WE_CONTEXTA;
                opts.fqd.fq_ctrl = QM_FQCTRL_AVOIDBLOCK |
@@ -594,19 +1060,59 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                        opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
                }
                ret = qman_init_fq(rxq, flags, &opts);
-               if (ret)
-                       DPAA_PMD_ERR("Channel/Queue association failed. fqid %d"
-                                    " ret: %d", rxq->fqid, ret);
-               rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb;
-               rxq->cb.dqrr_prepare = dpaa_rx_cb_prepare;
+               if (ret) {
+                       DPAA_PMD_ERR("Channel/Q association failed. fqid 0x%x "
+                               "ret:%d(%s)", rxq->fqid, ret, strerror(ret));
+                       return ret;
+               }
+               if (dpaa_svr_family == SVR_LS1043A_FAMILY) {
+                       rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb_no_prefetch;
+               } else {
+                       rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb;
+                       rxq->cb.dqrr_prepare = dpaa_rx_cb_prepare;
+               }
+
                rxq->is_static = true;
+
+               /* Allocate qman specific portals */
+               qp = fsl_qman_fq_portal_create(&q_fd);
+               if (!qp) {
+                       DPAA_PMD_ERR("Unable to alloc fq portal");
+                       return -1;
+               }
+               rxq->qp = qp;
+
+               /* Set up the device interrupt handler */
+               if (!dev->intr_handle) {
+                       struct rte_dpaa_device *dpaa_dev;
+                       struct rte_device *rdev = dev->device;
+
+                       dpaa_dev = container_of(rdev, struct rte_dpaa_device,
+                                               device);
+                       dev->intr_handle = &dpaa_dev->intr_handle;
+                       dev->intr_handle->intr_vec = rte_zmalloc(NULL,
+                                       dpaa_push_mode_max_queue, 0);
+                       if (!dev->intr_handle->intr_vec) {
+                               DPAA_PMD_ERR("intr_vec alloc failed");
+                               return -ENOMEM;
+                       }
+                       dev->intr_handle->nb_efd = dpaa_push_mode_max_queue;
+                       dev->intr_handle->max_intr = dpaa_push_mode_max_queue;
+               }
+
+               dev->intr_handle->type = RTE_INTR_HANDLE_EXT;
+               dev->intr_handle->intr_vec[queue_idx] = queue_idx + 1;
+               dev->intr_handle->efds[queue_idx] = q_fd;
+               rxq->q_fd = q_fd;
        }
+       rxq->bp_array = rte_dpaa_bpid_info;
        dev->data->rx_queues[queue_idx] = rxq;
 
        /* configure the CGR size as per the desc size */
        if (dpaa_intf->cgr_rx) {
                struct qm_mcc_initcgr cgr_opts = {0};
 
+               rxq->nb_desc = nb_desc;
                /* Enable tail drop with cgr on this queue */
                qm_cgr_cs_thres_set64(&cgr_opts.cgr.cs_thres, nb_desc, 0);
                ret = qman_modify_cgr(dpaa_intf->cgr_rx, 0, &cgr_opts);
@@ -616,11 +1122,12 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                                rxq->fqid, ret);
                }
        }
-
+       /* Enable main queue to receive error packets also by default */
+       fman_if_set_err_fqid(fif, rxq->fqid);
        return 0;
 }
 
-int __rte_experimental
+int
 dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
                int eth_rx_queue_id,
                u16 ch_id,
@@ -633,7 +1140,8 @@ dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
        struct qm_mcc_initfq opts = {0};
 
        if (dpaa_push_mode_max_queue)
-               DPAA_PMD_WARN("PUSH mode already enabled for first %d queues.\n"
+               DPAA_PMD_WARN("PUSH mode q and EVENTDEV are not compatible\n"
+                             "PUSH mode already enabled for first %d queues.\n"
                              "To disable set DPAA_PUSH_QUEUES_NUMBER to 0\n",
                              dpaa_push_mode_max_queue);
 
@@ -671,8 +1179,8 @@ dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
 
        ret = qman_init_fq(rxq, flags, &opts);
        if (ret) {
-               DPAA_PMD_ERR("Channel/Queue association failed. fqid %d ret:%d",
-                            rxq->fqid, ret);
+               DPAA_PMD_ERR("Ev-Channel/Q association failed. fqid 0x%x "
+                               "ret:%d(%s)", rxq->fqid, ret, strerror(ret));
                return ret;
        }
 
@@ -683,7 +1191,7 @@ dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
        return ret;
 }
 
-int __rte_experimental
+int
 dpaa_eth_eventq_detach(const struct rte_eth_dev *dev,
                int eth_rx_queue_id)
 {
@@ -723,14 +1231,32 @@ static
 int dpaa_eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                            uint16_t nb_desc __rte_unused,
                unsigned int socket_id __rte_unused,
-               const struct rte_eth_txconf *tx_conf __rte_unused)
+               const struct rte_eth_txconf *tx_conf)
 {
        struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct qman_fq *txq = &dpaa_intf->tx_queues[queue_idx];
 
        PMD_INIT_FUNC_TRACE();
 
-       DPAA_PMD_INFO("Tx queue setup for queue index: %d", queue_idx);
-       dev->data->tx_queues[queue_idx] = &dpaa_intf->tx_queues[queue_idx];
+       /* Tx deferred start is not supported */
+       if (tx_conf->tx_deferred_start) {
+               DPAA_PMD_ERR("%p:Tx deferred start not supported", (void *)dev);
+               return -EINVAL;
+       }
+       txq->nb_desc = UINT16_MAX;
+       txq->offloads = tx_conf->offloads;
+
+       if (queue_idx >= dev->data->nb_tx_queues) {
+               rte_errno = EOVERFLOW;
+               DPAA_PMD_ERR("%p: queue index out of range (%u >= %u)",
+                     (void *)dev, queue_idx, dev->data->nb_tx_queues);
+               return -rte_errno;
+       }
+
+       DPAA_PMD_INFO("Tx queue setup for queue index: %d fq_id (0x%x)",
+                       queue_idx, txq->fqid);
+       dev->data->tx_queues[queue_idx] = txq;
+
        return 0;
 }
 
@@ -749,25 +1275,41 @@ dpaa_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
        PMD_INIT_FUNC_TRACE();
 
        if (qman_query_fq_frm_cnt(rxq, &frm_cnt) == 0) {
-               RTE_LOG(DEBUG, PMD, "RX frame count for q(%d) is %u\n",
-                       rx_queue_id, frm_cnt);
+               DPAA_PMD_DEBUG("RX frame count for q(%d) is %u",
+                              rx_queue_id, frm_cnt);
        }
        return frm_cnt;
 }
 
 static int dpaa_link_down(struct rte_eth_dev *dev)
 {
+       struct fman_if *fif = dev->process_private;
+       struct __fman_if *__fif;
+
        PMD_INIT_FUNC_TRACE();
 
-       dpaa_eth_dev_stop(dev);
+       __fif = container_of(fif, struct __fman_if, __if);
+
+       if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
+               dpaa_update_link_status(__fif->node_name, ETH_LINK_DOWN);
+       else
+               return dpaa_eth_dev_stop(dev);
        return 0;
 }
 
 static int dpaa_link_up(struct rte_eth_dev *dev)
 {
+       struct fman_if *fif = dev->process_private;
+       struct __fman_if *__fif;
+
        PMD_INIT_FUNC_TRACE();
 
-       dpaa_eth_dev_start(dev);
+       __fif = container_of(fif, struct __fman_if, __if);
+
+       if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
+               dpaa_update_link_status(__fif->node_name, ETH_LINK_UP);
+       else
+               dpaa_eth_dev_start(dev);
        return 0;
 }
 
@@ -799,11 +1341,12 @@ dpaa_flow_ctrl_set(struct rte_eth_dev *dev,
                return 0;
        } else if (fc_conf->mode == RTE_FC_TX_PAUSE ||
                 fc_conf->mode == RTE_FC_FULL) {
-               fman_if_set_fc_threshold(dpaa_intf->fif, fc_conf->high_water,
+               fman_if_set_fc_threshold(dev->process_private,
+                                        fc_conf->high_water,
                                         fc_conf->low_water,
-                               dpaa_intf->bp_info->bpid);
+                                        dpaa_intf->bp_info->bpid);
                if (fc_conf->pause_time)
-                       fman_if_set_fc_quanta(dpaa_intf->fif,
+                       fman_if_set_fc_quanta(dev->process_private,
                                              fc_conf->pause_time);
        }
 
@@ -839,10 +1382,11 @@ dpaa_flow_ctrl_get(struct rte_eth_dev *dev,
                fc_conf->autoneg = net_fc->autoneg;
                return 0;
        }
-       ret = fman_if_get_fc_threshold(dpaa_intf->fif);
+       ret = fman_if_get_fc_threshold(dev->process_private);
        if (ret) {
                fc_conf->mode = RTE_FC_TX_PAUSE;
-               fc_conf->pause_time = fman_if_get_fc_quanta(dpaa_intf->fif);
+               fc_conf->pause_time =
+                       fman_if_get_fc_quanta(dev->process_private);
        } else {
                fc_conf->mode = RTE_FC_NONE;
        }
@@ -852,20 +1396,19 @@ dpaa_flow_ctrl_get(struct rte_eth_dev *dev,
 
 static int
 dpaa_dev_add_mac_addr(struct rte_eth_dev *dev,
-                            struct ether_addr *addr,
+                            struct rte_ether_addr *addr,
                             uint32_t index,
                             __rte_unused uint32_t pool)
 {
        int ret;
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE();
 
-       ret = fman_if_add_mac_addr(dpaa_intf->fif, addr->addr_bytes, index);
+       ret = fman_if_add_mac_addr(dev->process_private,
+                                  addr->addr_bytes, index);
 
        if (ret)
-               RTE_LOG(ERR, PMD, "error: Adding the MAC ADDR failed:"
-                       " err = %d", ret);
+               DPAA_PMD_ERR("Adding the MAC ADDR failed: err = %d", ret);
        return 0;
 }
 
@@ -873,29 +1416,132 @@ static void
 dpaa_dev_remove_mac_addr(struct rte_eth_dev *dev,
                          uint32_t index)
 {
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
-
        PMD_INIT_FUNC_TRACE();
 
-       fman_if_clear_mac_addr(dpaa_intf->fif, index);
+       fman_if_clear_mac_addr(dev->process_private, index);
 }
 
 static int
 dpaa_dev_set_mac_addr(struct rte_eth_dev *dev,
-                      struct ether_addr *addr)
+                      struct rte_ether_addr *addr)
 {
        int ret;
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE();
 
-       ret = fman_if_add_mac_addr(dpaa_intf->fif, addr->addr_bytes, 0);
+       ret = fman_if_add_mac_addr(dev->process_private, addr->addr_bytes, 0);
        if (ret)
-               RTE_LOG(ERR, PMD, "error: Setting the MAC ADDR failed %d", ret);
+               DPAA_PMD_ERR("Setting the MAC ADDR failed %d", ret);
 
        return ret;
 }
 
+static int
+dpaa_dev_rss_hash_update(struct rte_eth_dev *dev,
+                        struct rte_eth_rss_conf *rss_conf)
+{
+       struct rte_eth_dev_data *data = dev->data;
+       struct rte_eth_conf *eth_conf = &data->dev_conf;
+
+       PMD_INIT_FUNC_TRACE();
+
+       if (!(default_q || fmc_q)) {
+               if (dpaa_fm_config(dev, rss_conf->rss_hf)) {
+                       DPAA_PMD_ERR("FM port configuration: Failed\n");
+                       return -1;
+               }
+               eth_conf->rx_adv_conf.rss_conf.rss_hf = rss_conf->rss_hf;
+       } else {
+               DPAA_PMD_ERR("Function not supported\n");
+               return -ENOTSUP;
+       }
+       return 0;
+}
+
+static int
+dpaa_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
+                          struct rte_eth_rss_conf *rss_conf)
+{
+       struct rte_eth_dev_data *data = dev->data;
+       struct rte_eth_conf *eth_conf = &data->dev_conf;
+
+       /* dpaa does not support rss_key, so length should be 0*/
+       rss_conf->rss_key_len = 0;
+       rss_conf->rss_hf = eth_conf->rx_adv_conf.rss_conf.rss_hf;
+       return 0;
+}
+
+static int dpaa_dev_queue_intr_enable(struct rte_eth_dev *dev,
+                                     uint16_t queue_id)
+{
+       struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct qman_fq *rxq = &dpaa_intf->rx_queues[queue_id];
+
+       if (!rxq->is_static)
+               return -EINVAL;
+
+       return qman_fq_portal_irqsource_add(rxq->qp, QM_PIRQ_DQRI);
+}
+
+static int dpaa_dev_queue_intr_disable(struct rte_eth_dev *dev,
+                                      uint16_t queue_id)
+{
+       struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct qman_fq *rxq = &dpaa_intf->rx_queues[queue_id];
+       uint32_t temp;
+       ssize_t temp1;
+
+       if (!rxq->is_static)
+               return -EINVAL;
+
+       qman_fq_portal_irqsource_remove(rxq->qp, ~0);
+
+       temp1 = read(rxq->q_fd, &temp, sizeof(temp));
+       if (temp1 != sizeof(temp))
+               DPAA_PMD_ERR("irq read error");
+
+       qman_fq_portal_thread_irq(rxq->qp);
+
+       return 0;
+}
+
+static void
+dpaa_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+       struct rte_eth_rxq_info *qinfo)
+{
+       struct dpaa_if *dpaa_intf = dev->data->dev_private;
+       struct qman_fq *rxq;
+
+       rxq = dev->data->rx_queues[queue_id];
+
+       qinfo->mp = dpaa_intf->bp_info->mp;
+       qinfo->scattered_rx = dev->data->scattered_rx;
+       qinfo->nb_desc = rxq->nb_desc;
+       qinfo->conf.rx_free_thresh = 1;
+       qinfo->conf.rx_drop_en = 1;
+       qinfo->conf.rx_deferred_start = 0;
+       qinfo->conf.offloads = rxq->offloads;
+}
+
+static void
+dpaa_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+       struct rte_eth_txq_info *qinfo)
+{
+       struct qman_fq *txq;
+
+       txq = dev->data->tx_queues[queue_id];
+
+       qinfo->nb_desc = txq->nb_desc;
+       qinfo->conf.tx_thresh.pthresh = 0;
+       qinfo->conf.tx_thresh.hthresh = 0;
+       qinfo->conf.tx_thresh.wthresh = 0;
+
+       qinfo->conf.tx_free_thresh = 0;
+       qinfo->conf.tx_rs_thresh = 0;
+       qinfo->conf.offloads = txq->offloads;
+       qinfo->conf.tx_deferred_start = 0;
+}
+
 static struct eth_dev_ops dpaa_devops = {
        .dev_configure            = dpaa_eth_dev_configure,
        .dev_start                = dpaa_eth_dev_start,
@@ -908,7 +1554,10 @@ static struct eth_dev_ops dpaa_devops = {
        .tx_queue_setup           = dpaa_eth_tx_queue_setup,
        .rx_queue_release         = dpaa_eth_rx_queue_release,
        .tx_queue_release         = dpaa_eth_tx_queue_release,
-       .rx_queue_count           = dpaa_dev_rx_queue_count,
+       .rx_burst_mode_get        = dpaa_dev_rx_burst_mode_get,
+       .tx_burst_mode_get        = dpaa_dev_tx_burst_mode_get,
+       .rxq_info_get             = dpaa_rxq_info_get,
+       .txq_info_get             = dpaa_txq_info_get,
 
        .flow_ctrl_get            = dpaa_flow_ctrl_get,
        .flow_ctrl_set            = dpaa_flow_ctrl_set,
@@ -933,6 +1582,11 @@ static struct eth_dev_ops dpaa_devops = {
        .mac_addr_set             = dpaa_dev_set_mac_addr,
 
        .fw_version_get           = dpaa_fw_version_get,
+
+       .rx_queue_intr_enable     = dpaa_dev_queue_intr_enable,
+       .rx_queue_intr_disable    = dpaa_dev_queue_intr_disable,
+       .rss_hash_update          = dpaa_dev_rss_hash_update,
+       .rss_hash_conf_get        = dpaa_dev_rss_hash_conf_get,
 };
 
 static bool
@@ -951,11 +1605,10 @@ is_dpaa_supported(struct rte_eth_dev *dev)
        return is_device_supported(dev, &rte_dpaa_pmd);
 }
 
-int __rte_experimental
-rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on)
+int
+rte_pmd_dpaa_set_tx_loopback(uint16_t port, uint8_t on)
 {
        struct rte_eth_dev *dev;
-       struct dpaa_if *dpaa_intf;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
 
@@ -964,17 +1617,16 @@ rte_pmd_dpaa_set_tx_loopback(uint8_t port, uint8_t on)
        if (!is_dpaa_supported(dev))
                return -ENOTSUP;
 
-       dpaa_intf = dev->data->dev_private;
-
        if (on)
-               fman_if_loopback_enable(dpaa_intf->fif);
+               fman_if_loopback_enable(dev->process_private);
        else
-               fman_if_loopback_disable(dpaa_intf->fif);
+               fman_if_loopback_disable(dev->process_private);
 
        return 0;
 }
 
-static int dpaa_fc_set_default(struct dpaa_if *dpaa_intf)
+static int dpaa_fc_set_default(struct dpaa_if *dpaa_intf,
+                              struct fman_if *fman_intf)
 {
        struct rte_eth_fc_conf *fc_conf;
        int ret;
@@ -990,10 +1642,10 @@ static int dpaa_fc_set_default(struct dpaa_if *dpaa_intf)
                }
        }
        fc_conf = dpaa_intf->fc_conf;
-       ret = fman_if_get_fc_threshold(dpaa_intf->fif);
+       ret = fman_if_get_fc_threshold(fman_intf);
        if (ret) {
                fc_conf->mode = RTE_FC_TX_PAUSE;
-               fc_conf->pause_time = fman_if_get_fc_quanta(dpaa_intf->fif);
+               fc_conf->pause_time = fman_if_get_fc_quanta(fman_intf);
        } else {
                fc_conf->mode = RTE_FC_NONE;
        }
@@ -1007,7 +1659,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,
 {
        struct qm_mcc_initfq opts = {0};
        int ret;
-       u32 flags = 0;
+       u32 flags = QMAN_FQ_FLAG_NO_ENQUEUE;
        struct qm_mcc_initcgr cgr_opts = {
                .we_mask = QM_CGR_WE_CS_THRES |
                                QM_CGR_WE_CSTD_EN |
@@ -1018,19 +1670,19 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,
                }
        };
 
-       PMD_INIT_FUNC_TRACE();
-
-       ret = qman_reserve_fqid(fqid);
-       if (ret) {
-               DPAA_PMD_ERR("reserve rx fqid %d failed with ret: %d",
-                            fqid, ret);
-               return -EINVAL;
+       if (fmc_q || default_q) {
+               ret = qman_reserve_fqid(fqid);
+               if (ret) {
+                       DPAA_PMD_ERR("reserve rx fqid 0x%x failed, ret: %d",
+                                    fqid, ret);
+                       return -EINVAL;
+               }
        }
 
-       DPAA_PMD_DEBUG("creating rx fq %p, fqid %d", fq, fqid);
-       ret = qman_create_fq(fqid, QMAN_FQ_FLAG_NO_ENQUEUE, fq);
+       DPAA_PMD_DEBUG("creating rx fq %p, fqid 0x%x", fq, fqid);
+       ret = qman_create_fq(fqid, flags, fq);
        if (ret) {
-               DPAA_PMD_ERR("create rx fqid %d failed with ret: %d",
+               DPAA_PMD_ERR("create rx fqid 0x%x failed with ret: %d",
                        fqid, ret);
                return ret;
        }
@@ -1046,8 +1698,8 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,
                                      &cgr_opts);
                if (ret) {
                        DPAA_PMD_WARN(
-                               "rx taildrop init fail on rx fqid %d (ret=%d)",
-                               fqid, ret);
+                               "rx taildrop init fail on rx fqid 0x%x(ret=%d)",
+                               fq->fqid, ret);
                        goto without_cgr;
                }
                opts.we_mask |= QM_INITFQ_WE_CGID;
@@ -1055,21 +1707,29 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,
                opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
        }
 without_cgr:
-       ret = qman_init_fq(fq, flags, &opts);
+       ret = qman_init_fq(fq, 0, &opts);
        if (ret)
-               DPAA_PMD_ERR("init rx fqid %d failed with ret: %d", fqid, ret);
+               DPAA_PMD_ERR("init rx fqid 0x%x failed with ret:%d", fqid, ret);
        return ret;
 }
 
 /* Initialise a Tx FQ */
 static int dpaa_tx_queue_init(struct qman_fq *fq,
-                             struct fman_if *fman_intf)
+                             struct fman_if *fman_intf,
+                             struct qman_cgr *cgr_tx)
 {
        struct qm_mcc_initfq opts = {0};
+       struct qm_mcc_initcgr cgr_opts = {
+               .we_mask = QM_CGR_WE_CS_THRES |
+                               QM_CGR_WE_CSTD_EN |
+                               QM_CGR_WE_MODE,
+               .cgr = {
+                       .cstd_en = QM_CGR_EN,
+                       .mode = QMAN_CGR_MODE_FRAME
+               }
+       };
        int ret;
 
-       PMD_INIT_FUNC_TRACE();
-
        ret = qman_create_fq(0, QMAN_FQ_FLAG_DYNAMIC_FQID |
                             QMAN_FQ_FLAG_TO_DCPORTAL, fq);
        if (ret) {
@@ -1085,10 +1745,31 @@ static int dpaa_tx_queue_init(struct qman_fq *fq,
        /* no tx-confirmation */
        opts.fqd.context_a.hi = 0x80000000 | fman_dealloc_bufs_mask_hi;
        opts.fqd.context_a.lo = 0 | fman_dealloc_bufs_mask_lo;
-       DPAA_PMD_DEBUG("init tx fq %p, fqid %d", fq, fq->fqid);
+       DPAA_PMD_DEBUG("init tx fq %p, fqid 0x%x", fq, fq->fqid);
+
+       if (cgr_tx) {
+               /* Enable tail drop with cgr on this queue */
+               qm_cgr_cs_thres_set64(&cgr_opts.cgr.cs_thres,
+                                     td_tx_threshold, 0);
+               cgr_tx->cb = NULL;
+               ret = qman_create_cgr(cgr_tx, QMAN_CGR_FLAG_USE_INIT,
+                                     &cgr_opts);
+               if (ret) {
+                       DPAA_PMD_WARN(
+                               "rx taildrop init fail on rx fqid 0x%x(ret=%d)",
+                               fq->fqid, ret);
+                       goto without_cgr;
+               }
+               opts.we_mask |= QM_INITFQ_WE_CGID;
+               opts.fqd.cgid = cgr_tx->cgrid;
+               opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
+               DPAA_PMD_DEBUG("Tx FQ tail drop enabled, threshold = %d\n",
+                               td_tx_threshold);
+       }
+without_cgr:
        ret = qman_init_fq(fq, QMAN_INITFQ_FLAG_SCHED, &opts);
        if (ret)
-               DPAA_PMD_ERR("init tx fqid %d failed %d", fq->fqid, ret);
+               DPAA_PMD_ERR("init tx fqid 0x%x failed %d", fq->fqid, ret);
        return ret;
 }
 
@@ -1125,11 +1806,44 @@ static int dpaa_debug_queue_init(struct qman_fq *fq, uint32_t fqid)
 }
 #endif
 
+/* Initialise a network interface */
+static int
+dpaa_dev_init_secondary(struct rte_eth_dev *eth_dev)
+{
+       struct rte_dpaa_device *dpaa_device;
+       struct fm_eth_port_cfg *cfg;
+       struct dpaa_if *dpaa_intf;
+       struct fman_if *fman_intf;
+       int dev_id;
+
+       PMD_INIT_FUNC_TRACE();
+
+       dpaa_device = DEV_TO_DPAA_DEVICE(eth_dev->device);
+       dev_id = dpaa_device->id.dev_id;
+       cfg = dpaa_get_eth_port_cfg(dev_id);
+       fman_intf = cfg->fman_if;
+       eth_dev->process_private = fman_intf;
+
+       /* Plugging of UCODE burst API not supported in Secondary */
+       dpaa_intf = eth_dev->data->dev_private;
+       eth_dev->rx_pkt_burst = dpaa_eth_queue_rx;
+       if (dpaa_intf->cgr_tx)
+               eth_dev->tx_pkt_burst = dpaa_eth_queue_tx_slow;
+       else
+               eth_dev->tx_pkt_burst = dpaa_eth_queue_tx;
+#ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
+       qman_set_fq_lookup_table(
+               dpaa_intf->rx_queues->qman_fq_lookup_table);
+#endif
+
+       return 0;
+}
+
 /* Initialise a network interface */
 static int
 dpaa_dev_init(struct rte_eth_dev *eth_dev)
 {
-       int num_cores, num_rx_fqs, fqid;
+       int num_rx_fqs, fqid;
        int loop, ret = 0;
        int dev_id;
        struct rte_dpaa_device *dpaa_device;
@@ -1138,59 +1852,88 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)
        struct fman_if *fman_intf;
        struct fman_if_bpool *bp, *tmp_bp;
        uint32_t cgrid[DPAA_MAX_NUM_PCD_QUEUES];
+       uint32_t cgrid_tx[MAX_DPAA_CORES];
+       uint32_t dev_rx_fqids[DPAA_MAX_NUM_PCD_QUEUES];
+       int8_t dev_vspids[DPAA_MAX_NUM_PCD_QUEUES];
+       int8_t vsp_id = -1;
 
        PMD_INIT_FUNC_TRACE();
 
-       /* For secondary processes, the primary has done all the work */
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-               return 0;
-
        dpaa_device = DEV_TO_DPAA_DEVICE(eth_dev->device);
        dev_id = dpaa_device->id.dev_id;
        dpaa_intf = eth_dev->data->dev_private;
-       cfg = &dpaa_netcfg->port_cfg[dev_id];
+       cfg = dpaa_get_eth_port_cfg(dev_id);
        fman_intf = cfg->fman_if;
 
        dpaa_intf->name = dpaa_device->name;
 
        /* save fman_if & cfg in the interface struture */
-       dpaa_intf->fif = fman_intf;
+       eth_dev->process_private = fman_intf;
        dpaa_intf->ifid = dev_id;
        dpaa_intf->cfg = cfg;
 
+       memset((char *)dev_rx_fqids, 0,
+               sizeof(uint32_t) * DPAA_MAX_NUM_PCD_QUEUES);
+
+       memset(dev_vspids, -1, DPAA_MAX_NUM_PCD_QUEUES);
+
        /* Initialize Rx FQ's */
-       if (getenv("DPAA_NUM_RX_QUEUES"))
-               num_rx_fqs = atoi(getenv("DPAA_NUM_RX_QUEUES"));
-       else
+       if (default_q) {
                num_rx_fqs = DPAA_DEFAULT_NUM_PCD_QUEUES;
-
-       /* if push mode queues to be enabled. Currenly we are allowing only
-        * one queue per thread.
-        */
-       if (getenv("DPAA_PUSH_QUEUES_NUMBER")) {
-               dpaa_push_mode_max_queue =
-                               atoi(getenv("DPAA_PUSH_QUEUES_NUMBER"));
-               if (dpaa_push_mode_max_queue > DPAA_MAX_PUSH_MODE_QUEUE)
-                       dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE;
+       } else if (fmc_q) {
+               num_rx_fqs = dpaa_port_fmc_init(fman_intf, dev_rx_fqids,
+                                               dev_vspids,
+                                               DPAA_MAX_NUM_PCD_QUEUES);
+               if (num_rx_fqs < 0) {
+                       DPAA_PMD_ERR("%s FMC initializes failed!",
+                               dpaa_intf->name);
+                       goto free_rx;
+               }
+               if (!num_rx_fqs) {
+                       DPAA_PMD_WARN("%s is not configured by FMC.",
+                               dpaa_intf->name);
+               }
+       } else {
+               /* FMCLESS mode, load balance to multiple cores.*/
+               num_rx_fqs = rte_lcore_count();
        }
 
        /* Each device can not have more than DPAA_MAX_NUM_PCD_QUEUES RX
         * queues.
         */
-       if (num_rx_fqs <= 0 || num_rx_fqs > DPAA_MAX_NUM_PCD_QUEUES) {
+       if (num_rx_fqs < 0 || num_rx_fqs > DPAA_MAX_NUM_PCD_QUEUES) {
                DPAA_PMD_ERR("Invalid number of RX queues\n");
                return -EINVAL;
        }
 
-       dpaa_intf->rx_queues = rte_zmalloc(NULL,
-               sizeof(struct qman_fq) * num_rx_fqs, MAX_CACHELINE);
-       if (!dpaa_intf->rx_queues) {
-               DPAA_PMD_ERR("Failed to alloc mem for RX queues\n");
-               return -ENOMEM;
+       if (num_rx_fqs > 0) {
+               dpaa_intf->rx_queues = rte_zmalloc(NULL,
+                       sizeof(struct qman_fq) * num_rx_fqs, MAX_CACHELINE);
+               if (!dpaa_intf->rx_queues) {
+                       DPAA_PMD_ERR("Failed to alloc mem for RX queues\n");
+                       return -ENOMEM;
+               }
+       } else {
+               dpaa_intf->rx_queues = NULL;
+       }
+
+       memset(cgrid, 0, sizeof(cgrid));
+       memset(cgrid_tx, 0, sizeof(cgrid_tx));
+
+       /* if DPAA_TX_TAILDROP_THRESHOLD is set, use that value; if 0, it means
+        * Tx tail drop is disabled.
+        */
+       if (getenv("DPAA_TX_TAILDROP_THRESHOLD")) {
+               td_tx_threshold = atoi(getenv("DPAA_TX_TAILDROP_THRESHOLD"));
+               DPAA_PMD_DEBUG("Tail drop threshold env configured: %u",
+                              td_tx_threshold);
+               /* if a very large value is being configured */
+               if (td_tx_threshold > UINT16_MAX)
+                       td_tx_threshold = CGR_RX_PERFQ_THRESH;
        }
 
        /* If congestion control is enabled globally*/
-       if (td_threshold) {
+       if (num_rx_fqs > 0 && td_threshold) {
                dpaa_intf->cgr_rx = rte_zmalloc(NULL,
                        sizeof(struct qman_cgr) * num_rx_fqs, MAX_CACHELINE);
                if (!dpaa_intf->cgr_rx) {
@@ -1209,9 +1952,22 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)
                dpaa_intf->cgr_rx = NULL;
        }
 
+       if (!fmc_q && !default_q) {
+               ret = qman_alloc_fqid_range(dev_rx_fqids, num_rx_fqs,
+                                           num_rx_fqs, 0);
+               if (ret < 0) {
+                       DPAA_PMD_ERR("Failed to alloc rx fqid's\n");
+                       goto free_rx;
+               }
+       }
+
        for (loop = 0; loop < num_rx_fqs; loop++) {
-               fqid = DPAA_PCD_FQID_START + dpaa_intf->ifid *
-                       DPAA_PCD_FQID_MULTIPLIER + loop;
+               if (default_q)
+                       fqid = cfg->rx_def;
+               else
+                       fqid = dev_rx_fqids[loop];
+
+               vsp_id = dev_vspids[loop];
 
                if (dpaa_intf->cgr_rx)
                        dpaa_intf->cgr_rx[loop].cgrid = cgrid[loop];
@@ -1221,67 +1977,103 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)
                        fqid);
                if (ret)
                        goto free_rx;
+               dpaa_intf->rx_queues[loop].vsp_id = vsp_id;
                dpaa_intf->rx_queues[loop].dpaa_intf = dpaa_intf;
        }
        dpaa_intf->nb_rx_queues = num_rx_fqs;
 
        /* Initialise Tx FQs.free_rx Have as many Tx FQ's as number of cores */
-       num_cores = rte_lcore_count();
        dpaa_intf->tx_queues = rte_zmalloc(NULL, sizeof(struct qman_fq) *
-               num_cores, MAX_CACHELINE);
+               MAX_DPAA_CORES, MAX_CACHELINE);
        if (!dpaa_intf->tx_queues) {
                DPAA_PMD_ERR("Failed to alloc mem for TX queues\n");
                ret = -ENOMEM;
                goto free_rx;
        }
 
-       for (loop = 0; loop < num_cores; loop++) {
+       /* If congestion control is enabled globally*/
+       if (td_tx_threshold) {
+               dpaa_intf->cgr_tx = rte_zmalloc(NULL,
+                       sizeof(struct qman_cgr) * MAX_DPAA_CORES,
+                       MAX_CACHELINE);
+               if (!dpaa_intf->cgr_tx) {
+                       DPAA_PMD_ERR("Failed to alloc mem for cgr_tx\n");
+                       ret = -ENOMEM;
+                       goto free_rx;
+               }
+
+               ret = qman_alloc_cgrid_range(&cgrid_tx[0], MAX_DPAA_CORES,
+                                            1, 0);
+               if (ret != MAX_DPAA_CORES) {
+                       DPAA_PMD_WARN("insufficient CGRIDs available");
+                       ret = -EINVAL;
+                       goto free_rx;
+               }
+       } else {
+               dpaa_intf->cgr_tx = NULL;
+       }
+
+
+       for (loop = 0; loop < MAX_DPAA_CORES; loop++) {
+               if (dpaa_intf->cgr_tx)
+                       dpaa_intf->cgr_tx[loop].cgrid = cgrid_tx[loop];
+
                ret = dpaa_tx_queue_init(&dpaa_intf->tx_queues[loop],
-                                        fman_intf);
+                       fman_intf,
+                       dpaa_intf->cgr_tx ? &dpaa_intf->cgr_tx[loop] : NULL);
                if (ret)
                        goto free_tx;
                dpaa_intf->tx_queues[loop].dpaa_intf = dpaa_intf;
        }
-       dpaa_intf->nb_tx_queues = num_cores;
+       dpaa_intf->nb_tx_queues = MAX_DPAA_CORES;
 
 #ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
-       dpaa_debug_queue_init(&dpaa_intf->debug_queues[
-               DPAA_DEBUG_FQ_RX_ERROR], fman_intf->fqid_rx_err);
+       ret = dpaa_debug_queue_init(&dpaa_intf->debug_queues
+                       [DPAA_DEBUG_FQ_RX_ERROR], fman_intf->fqid_rx_err);
+       if (ret) {
+               DPAA_PMD_ERR("DPAA RX ERROR queue init failed!");
+               goto free_tx;
+       }
        dpaa_intf->debug_queues[DPAA_DEBUG_FQ_RX_ERROR].dpaa_intf = dpaa_intf;
-       dpaa_debug_queue_init(&dpaa_intf->debug_queues[
-               DPAA_DEBUG_FQ_TX_ERROR], fman_intf->fqid_tx_err);
+       ret = dpaa_debug_queue_init(&dpaa_intf->debug_queues
+                       [DPAA_DEBUG_FQ_TX_ERROR], fman_intf->fqid_tx_err);
+       if (ret) {
+               DPAA_PMD_ERR("DPAA TX ERROR queue init failed!");
+               goto free_tx;
+       }
        dpaa_intf->debug_queues[DPAA_DEBUG_FQ_TX_ERROR].dpaa_intf = dpaa_intf;
 #endif
 
        DPAA_PMD_DEBUG("All frame queues created");
 
        /* Get the initial configuration for flow control */
-       dpaa_fc_set_default(dpaa_intf);
+       dpaa_fc_set_default(dpaa_intf, fman_intf);
 
        /* reset bpool list, initialize bpool dynamically */
        list_for_each_entry_safe(bp, tmp_bp, &cfg->fman_if->bpool_list, node) {
                list_del(&bp->node);
-               free(bp);
+               rte_free(bp);
        }
 
        /* Populate ethdev structure */
        eth_dev->dev_ops = &dpaa_devops;
+       eth_dev->rx_queue_count = dpaa_dev_rx_queue_count;
        eth_dev->rx_pkt_burst = dpaa_eth_queue_rx;
        eth_dev->tx_pkt_burst = dpaa_eth_tx_drop_all;
 
        /* Allocate memory for storing MAC addresses */
        eth_dev->data->mac_addrs = rte_zmalloc("mac_addr",
-               ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER, 0);
+               RTE_ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER, 0);
        if (eth_dev->data->mac_addrs == NULL) {
                DPAA_PMD_ERR("Failed to allocate %d bytes needed to "
                                                "store MAC addresses",
-                               ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER);
+                               RTE_ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER);
                ret = -ENOMEM;
                goto free_tx;
        }
 
        /* copy the primary mac address */
-       ether_addr_copy(&fman_intf->mac_addr, &eth_dev->data->mac_addrs[0]);
+       rte_ether_addr_copy(&fman_intf->mac_addr, &eth_dev->data->mac_addrs[0]);
 
        RTE_LOG(INFO, PMD, "net: dpaa: %s: %02x:%02x:%02x:%02x:%02x:%02x\n",
                dpaa_device->name,
@@ -1292,15 +2084,23 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)
                fman_intf->mac_addr.addr_bytes[4],
                fman_intf->mac_addr.addr_bytes[5]);
 
-       /* Disable RX mode */
-       fman_if_discard_rx_errors(fman_intf);
-       fman_if_disable_rx(fman_intf);
-       /* Disable promiscuous mode */
-       fman_if_promiscuous_disable(fman_intf);
-       /* Disable multicast */
-       fman_if_reset_mcast_filter_table(fman_intf);
-       /* Reset interface statistics */
-       fman_if_stats_reset(fman_intf);
+       if (!fman_intf->is_shared_mac) {
+               /* Configure error packet handling */
+               fman_if_receive_rx_errors(fman_intf,
+                       FM_FD_RX_STATUS_ERR_MASK);
+               /* Disable RX mode */
+               fman_if_disable_rx(fman_intf);
+               /* Disable promiscuous mode */
+               fman_if_promiscuous_disable(fman_intf);
+               /* Disable multicast */
+               fman_if_reset_mcast_filter_table(fman_intf);
+               /* Reset interface statistics */
+               fman_if_stats_reset(fman_intf);
+               /* Disable SG by default */
+               fman_if_set_sg(fman_intf, 0);
+               fman_if_set_maxfrm(fman_intf,
+                                  RTE_ETHER_MAX_LEN + VLAN_TAG_SIZE);
+       }
 
        return 0;
 
@@ -1311,63 +2111,13 @@ free_tx:
 
 free_rx:
        rte_free(dpaa_intf->cgr_rx);
+       rte_free(dpaa_intf->cgr_tx);
        rte_free(dpaa_intf->rx_queues);
        dpaa_intf->rx_queues = NULL;
        dpaa_intf->nb_rx_queues = 0;
        return ret;
 }
 
-static int
-dpaa_dev_uninit(struct rte_eth_dev *dev)
-{
-       struct dpaa_if *dpaa_intf = dev->data->dev_private;
-       int loop;
-
-       PMD_INIT_FUNC_TRACE();
-
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-               return -EPERM;
-
-       if (!dpaa_intf) {
-               DPAA_PMD_WARN("Already closed or not started");
-               return -1;
-       }
-
-       dpaa_eth_dev_close(dev);
-
-       /* release configuration memory */
-       if (dpaa_intf->fc_conf)
-               rte_free(dpaa_intf->fc_conf);
-
-       /* Release RX congestion Groups */
-       if (dpaa_intf->cgr_rx) {
-               for (loop = 0; loop < dpaa_intf->nb_rx_queues; loop++)
-                       qman_delete_cgr(&dpaa_intf->cgr_rx[loop]);
-
-               qman_release_cgrid_range(dpaa_intf->cgr_rx[loop].cgrid,
-                                        dpaa_intf->nb_rx_queues);
-       }
-
-       rte_free(dpaa_intf->cgr_rx);
-       dpaa_intf->cgr_rx = NULL;
-
-       rte_free(dpaa_intf->rx_queues);
-       dpaa_intf->rx_queues = NULL;
-
-       rte_free(dpaa_intf->tx_queues);
-       dpaa_intf->tx_queues = NULL;
-
-       /* free memory for storing MAC addresses */
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
-       dev->dev_ops = NULL;
-       dev->rx_pkt_burst = NULL;
-       dev->tx_pkt_burst = NULL;
-
-       return 0;
-}
-
 static int
 rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
               struct rte_dpaa_device *dpaa_dev)
@@ -1378,6 +2128,16 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
 
        PMD_INIT_FUNC_TRACE();
 
+       if ((DPAA_MBUF_HW_ANNOTATION + DPAA_FD_PTA_SIZE) >
+               RTE_PKTMBUF_HEADROOM) {
+               DPAA_PMD_ERR(
+               "RTE_PKTMBUF_HEADROOM(%d) shall be > DPAA Annotation req(%d)",
+               RTE_PKTMBUF_HEADROOM,
+               DPAA_MBUF_HW_ANNOTATION + DPAA_FD_PTA_SIZE);
+
+               return -1;
+       }
+
        /* In case of secondary process, the device is already configured
         * and no further action is required, except portal initialization
         * and verifying secondary attachment to port name.
@@ -1386,28 +2146,50 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
                eth_dev = rte_eth_dev_attach_secondary(dpaa_dev->name);
                if (!eth_dev)
                        return -ENOMEM;
+               eth_dev->device = &dpaa_dev->device;
+               eth_dev->dev_ops = &dpaa_devops;
+
+               ret = dpaa_dev_init_secondary(eth_dev);
+               if (ret != 0) {
+                       RTE_LOG(ERR, PMD, "secondary dev init failed\n");
+                       return ret;
+               }
+
+               rte_eth_dev_probing_finish(eth_dev);
                return 0;
        }
 
-       if (!is_global_init) {
-               /* One time load of Qman/Bman drivers */
-               ret = qman_global_init();
-               if (ret) {
-                       DPAA_PMD_ERR("QMAN initialization failed: %d",
-                                    ret);
-                       return ret;
+       if (!is_global_init && (rte_eal_process_type() == RTE_PROC_PRIMARY)) {
+               if (access("/tmp/fmc.bin", F_OK) == -1) {
+                       DPAA_PMD_INFO("* FMC not configured.Enabling default mode");
+                       default_q = 1;
                }
-               ret = bman_global_init();
-               if (ret) {
-                       DPAA_PMD_ERR("BMAN initialization failed: %d",
-                                    ret);
-                       return ret;
+
+               if (!(default_q || fmc_q)) {
+                       if (dpaa_fm_init()) {
+                               DPAA_PMD_ERR("FM init failed\n");
+                               return -1;
+                       }
+               }
+
+               /* disabling the default push mode for LS1043 */
+               if (dpaa_svr_family == SVR_LS1043A_FAMILY)
+                       dpaa_push_mode_max_queue = 0;
+
+               /* if push mode queues to be enabled. Currenly we are allowing
+                * only one queue per thread.
+                */
+               if (getenv("DPAA_PUSH_QUEUES_NUMBER")) {
+                       dpaa_push_mode_max_queue =
+                                       atoi(getenv("DPAA_PUSH_QUEUES_NUMBER"));
+                       if (dpaa_push_mode_max_queue > DPAA_MAX_PUSH_MODE_QUEUE)
+                           dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE;
                }
 
                is_global_init = 1;
        }
 
-       if (unlikely(!RTE_PER_LCORE(dpaa_io))) {
+       if (unlikely(!DPAA_PER_LCORE_PORTAL)) {
                ret = rte_dpaa_portal_init((void *)1);
                if (ret) {
                        DPAA_PMD_ERR("Unable to initialize portal");
@@ -1416,11 +2198,11 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
        }
 
        eth_dev = rte_eth_dev_allocate(dpaa_dev->name);
-       if (eth_dev == NULL)
+       if (!eth_dev)
                return -ENOMEM;
 
-       eth_dev->data->dev_private = rte_zmalloc(
-                                       "ethdev private structure",
+       eth_dev->data->dev_private =
+                       rte_zmalloc("ethdev private structure",
                                        sizeof(struct dpaa_if),
                                        RTE_CACHE_LINE_SIZE);
        if (!eth_dev->data->dev_private) {
@@ -1430,16 +2212,21 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
        }
 
        eth_dev->device = &dpaa_dev->device;
-       eth_dev->device->driver = &dpaa_drv->driver;
        dpaa_dev->eth_dev = eth_dev;
 
+       qman_ern_register_cb(dpaa_free_mbuf);
+
+       if (dpaa_drv->drv_flags & RTE_DPAA_DRV_INTR_LSC)
+               eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
+
+       eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+
        /* Invoke PMD device initialization function */
        diag = dpaa_dev_init(eth_dev);
-       if (diag == 0)
+       if (diag == 0) {
+               rte_eth_dev_probing_finish(eth_dev);
                return 0;
-
-       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-               rte_free(eth_dev->data->dev_private);
+       }
 
        rte_eth_dev_release_port(eth_dev);
        return diag;
@@ -1449,24 +2236,60 @@ static int
 rte_dpaa_remove(struct rte_dpaa_device *dpaa_dev)
 {
        struct rte_eth_dev *eth_dev;
+       int ret;
 
        PMD_INIT_FUNC_TRACE();
 
        eth_dev = dpaa_dev->eth_dev;
-       dpaa_dev_uninit(eth_dev);
+       dpaa_eth_dev_close(eth_dev);
+       ret = rte_eth_dev_release_port(eth_dev);
+
+       return ret;
+}
 
-       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-               rte_free(eth_dev->data->dev_private);
+static void __attribute__((destructor(102))) dpaa_finish(void)
+{
+       /* For secondary, primary will do all the cleanup */
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return;
+
+       if (!(default_q || fmc_q)) {
+               unsigned int i;
+
+               for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+                       if (rte_eth_devices[i].dev_ops == &dpaa_devops) {
+                               struct rte_eth_dev *dev = &rte_eth_devices[i];
+                               struct dpaa_if *dpaa_intf =
+                                       dev->data->dev_private;
+                               struct fman_if *fif =
+                                       dev->process_private;
+                               if (dpaa_intf->port_handle)
+                                       if (dpaa_fm_deconfig(dpaa_intf, fif))
+                                               DPAA_PMD_WARN("DPAA FM "
+                                                       "deconfig failed\n");
+                               if (fif->num_profiles) {
+                                       if (dpaa_port_vsp_cleanup(dpaa_intf,
+                                                                 fif))
+                                               DPAA_PMD_WARN("DPAA FM vsp cleanup failed\n");
+                               }
+                       }
+               }
+               if (is_global_init)
+                       if (dpaa_fm_term())
+                               DPAA_PMD_WARN("DPAA FM term failed\n");
 
-       rte_eth_dev_release_port(eth_dev);
+               is_global_init = 0;
 
-       return 0;
+               DPAA_PMD_INFO("DPAA fman cleaned up");
+       }
 }
 
 static struct rte_dpaa_driver rte_dpaa_pmd = {
+       .drv_flags = RTE_DPAA_DRV_INTR_LSC,
        .drv_type = FSL_DPAA_ETH,
        .probe = rte_dpaa_probe,
        .remove = rte_dpaa_remove,
 };
 
 RTE_PMD_REGISTER_DPAA(net_dpaa, rte_dpaa_pmd);
+RTE_LOG_REGISTER(dpaa_logtype_pmd, pmd.net.dpaa, NOTICE);