ethdev: remove jumbo offload flag
[dpdk.git] / drivers / net / failsafe / failsafe_ops.c
index 96f7e45..29de399 100644 (file)
@@ -9,7 +9,7 @@
 
 #include <rte_debug.h>
 #include <rte_atomic.h>
-#include <rte_ethdev_driver.h>
+#include <ethdev_driver.h>
 #include <rte_malloc.h>
 #include <rte_flow.h>
 #include <rte_cycles.h>
@@ -147,7 +147,9 @@ fs_dev_start(struct rte_eth_dev *dev)
                if (ret) {
                        if (!fs_err(sdev, ret))
                                continue;
-                       rte_eth_dev_stop(PORT_ID(sdev));
+                       if (fs_err(sdev, rte_eth_dev_stop(PORT_ID(sdev))) < 0)
+                               ERROR("Failed to stop sub-device %u",
+                                     SUB_ID(sdev));
                        fs_unlock(dev, 0);
                        return ret;
                }
@@ -177,22 +179,32 @@ fs_set_queues_state_stop(struct rte_eth_dev *dev)
                                                RTE_ETH_QUEUE_STATE_STOPPED;
 }
 
-static void
+static int
 fs_dev_stop(struct rte_eth_dev *dev)
 {
        struct sub_device *sdev;
        uint8_t i;
+       int ret;
 
        fs_lock(dev, 0);
        PRIV(dev)->state = DEV_STARTED - 1;
        FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_STARTED) {
-               rte_eth_dev_stop(PORT_ID(sdev));
+               ret = rte_eth_dev_stop(PORT_ID(sdev));
+               if (fs_err(sdev, ret) < 0) {
+                       ERROR("Failed to stop device %u",
+                             PORT_ID(sdev));
+                       PRIV(dev)->state = DEV_STARTED + 1;
+                       fs_unlock(dev, 0);
+                       return ret;
+               }
                failsafe_rx_intr_uninstall_subdevice(sdev);
                sdev->state = DEV_STARTED - 1;
        }
        failsafe_rx_intr_uninstall(dev);
        fs_set_queues_state_stop(dev);
        fs_unlock(dev, 0);
+
+       return 0;
 }
 
 static int
@@ -239,28 +251,6 @@ fs_dev_set_link_down(struct rte_eth_dev *dev)
        return 0;
 }
 
-static void fs_dev_free_queues(struct rte_eth_dev *dev);
-static void
-fs_dev_close(struct rte_eth_dev *dev)
-{
-       struct sub_device *sdev;
-       uint8_t i;
-
-       fs_lock(dev, 0);
-       failsafe_hotplug_alarm_cancel(dev);
-       if (PRIV(dev)->state == DEV_STARTED)
-               dev->dev_ops->dev_stop(dev);
-       PRIV(dev)->state = DEV_ACTIVE - 1;
-       FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {
-               DEBUG("Closing sub_device %d", i);
-               failsafe_eth_dev_unregister_callbacks(sdev);
-               rte_eth_dev_close(PORT_ID(sdev));
-               sdev->state = DEV_ACTIVE - 1;
-       }
-       fs_dev_free_queues(dev);
-       fs_unlock(dev, 0);
-}
-
 static int
 fs_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 {
@@ -368,26 +358,21 @@ fs_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
 }
 
 static void
-fs_rx_queue_release(void *queue)
+fs_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid)
 {
-       struct rte_eth_dev *dev;
        struct sub_device *sdev;
        uint8_t i;
-       struct rxq *rxq;
+       struct rxq *rxq = dev->data->rx_queues[qid];
 
-       if (queue == NULL)
+       if (rxq == NULL)
                return;
-       rxq = queue;
-       dev = &rte_eth_devices[rxq->priv->data->port_id];
        fs_lock(dev, 0);
        if (rxq->event_fd >= 0)
                close(rxq->event_fd);
        FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {
                if (ETH(sdev)->data->rx_queues != NULL &&
-                   ETH(sdev)->data->rx_queues[rxq->qid] != NULL) {
-                       SUBOPS(sdev, rx_queue_release)
-                               (ETH(sdev)->data->rx_queues[rxq->qid]);
-               }
+                   ETH(sdev)->data->rx_queues[rxq->qid] != NULL)
+                       SUBOPS(sdev, rx_queue_release)(ETH(sdev), rxq->qid);
        }
        dev->data->rx_queues[rxq->qid] = NULL;
        rte_free(rxq);
@@ -430,7 +415,7 @@ fs_rx_queue_setup(struct rte_eth_dev *dev,
        }
        rxq = dev->data->rx_queues[rx_queue_id];
        if (rxq != NULL) {
-               fs_rx_queue_release(rxq);
+               fs_rx_queue_release(dev, rx_queue_id);
                dev->data->rx_queues[rx_queue_id] = NULL;
        }
        rxq = rte_zmalloc(NULL,
@@ -470,7 +455,7 @@ fs_rx_queue_setup(struct rte_eth_dev *dev,
        fs_unlock(dev, 0);
        return 0;
 free_rxq:
-       fs_rx_queue_release(rxq);
+       fs_rx_queue_release(dev, rx_queue_id);
        fs_unlock(dev, 0);
        return ret;
 }
@@ -552,24 +537,19 @@ unlock:
 }
 
 static void
-fs_tx_queue_release(void *queue)
+fs_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid)
 {
-       struct rte_eth_dev *dev;
        struct sub_device *sdev;
        uint8_t i;
-       struct txq *txq;
+       struct txq *txq = dev->data->tx_queues[qid];
 
-       if (queue == NULL)
+       if (txq == NULL)
                return;
-       txq = queue;
-       dev = &rte_eth_devices[txq->priv->data->port_id];
        fs_lock(dev, 0);
        FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {
                if (ETH(sdev)->data->tx_queues != NULL &&
-                   ETH(sdev)->data->tx_queues[txq->qid] != NULL) {
-                       SUBOPS(sdev, tx_queue_release)
-                               (ETH(sdev)->data->tx_queues[txq->qid]);
-               }
+                   ETH(sdev)->data->tx_queues[txq->qid] != NULL)
+                       SUBOPS(sdev, tx_queue_release)(ETH(sdev), txq->qid);
        }
        dev->data->tx_queues[txq->qid] = NULL;
        rte_free(txq);
@@ -601,7 +581,7 @@ fs_tx_queue_setup(struct rte_eth_dev *dev,
        }
        txq = dev->data->tx_queues[tx_queue_id];
        if (txq != NULL) {
-               fs_tx_queue_release(txq);
+               fs_tx_queue_release(dev, tx_queue_id);
                dev->data->tx_queues[tx_queue_id] = NULL;
        }
        txq = rte_zmalloc("ethdev TX queue",
@@ -633,7 +613,7 @@ fs_tx_queue_setup(struct rte_eth_dev *dev,
        fs_unlock(dev, 0);
        return 0;
 free_txq:
-       fs_tx_queue_release(txq);
+       fs_tx_queue_release(dev, tx_queue_id);
        fs_unlock(dev, 0);
        return ret;
 }
@@ -644,17 +624,71 @@ fs_dev_free_queues(struct rte_eth_dev *dev)
        uint16_t i;
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               fs_rx_queue_release(dev->data->rx_queues[i]);
+               fs_rx_queue_release(dev, i);
                dev->data->rx_queues[i] = NULL;
        }
        dev->data->nb_rx_queues = 0;
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               fs_tx_queue_release(dev->data->tx_queues[i]);
+               fs_tx_queue_release(dev, i);
                dev->data->tx_queues[i] = NULL;
        }
        dev->data->nb_tx_queues = 0;
 }
 
+int
+failsafe_eth_dev_close(struct rte_eth_dev *dev)
+{
+       struct sub_device *sdev;
+       uint8_t i;
+       int err, ret = 0;
+
+       fs_lock(dev, 0);
+       failsafe_hotplug_alarm_cancel(dev);
+       if (PRIV(dev)->state == DEV_STARTED) {
+               ret = dev->dev_ops->dev_stop(dev);
+               if (ret != 0) {
+                       fs_unlock(dev, 0);
+                       return ret;
+               }
+       }
+       PRIV(dev)->state = DEV_ACTIVE - 1;
+       FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {
+               DEBUG("Closing sub_device %d", i);
+               failsafe_eth_dev_unregister_callbacks(sdev);
+               err = rte_eth_dev_close(PORT_ID(sdev));
+               if (err) {
+                       ret = ret ? ret : err;
+                       ERROR("Error while closing sub-device %u",
+                                       PORT_ID(sdev));
+               }
+               sdev->state = DEV_ACTIVE - 1;
+       }
+       rte_eth_dev_callback_unregister(RTE_ETH_ALL, RTE_ETH_EVENT_NEW,
+                                       failsafe_eth_new_event_callback, dev);
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               fs_unlock(dev, 0);
+               return ret;
+       }
+       fs_dev_free_queues(dev);
+       err = failsafe_eal_uninit(dev);
+       if (err) {
+               ret = ret ? ret : err;
+               ERROR("Error while uninitializing sub-EAL");
+       }
+       failsafe_args_free(dev);
+       rte_free(PRIV(dev)->subs);
+       rte_free(PRIV(dev)->mcast_addrs);
+       /* mac_addrs must not be freed alone because part of dev_private */
+       dev->data->mac_addrs = NULL;
+       fs_unlock(dev, 0);
+       err = pthread_mutex_destroy(&PRIV(dev)->hotplug_mutex);
+       if (err) {
+               ret = ret ? ret : err;
+               ERROR("Error while destroying hotplug mutex");
+       }
+       return ret;
+}
+
 static int
 fs_promiscuous_enable(struct rte_eth_dev *dev)
 {
@@ -1051,6 +1085,8 @@ static void
 fs_dev_merge_info(struct rte_eth_dev_info *info,
                  const struct rte_eth_dev_info *sinfo)
 {
+       info->min_mtu = RTE_MAX(info->min_mtu, sinfo->min_mtu);
+       info->max_mtu = RTE_MIN(info->max_mtu, sinfo->max_mtu);
        info->max_rx_pktlen = RTE_MIN(info->max_rx_pktlen, sinfo->max_rx_pktlen);
        info->max_rx_queues = RTE_MIN(info->max_rx_queues, sinfo->max_rx_queues);
        info->max_tx_queues = RTE_MIN(info->max_tx_queues, sinfo->max_tx_queues);
@@ -1119,6 +1155,8 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
        int ret;
 
        /* Use maximum upper bounds by default */
+       infos->min_mtu = RTE_ETHER_MIN_MTU;
+       infos->max_mtu = UINT16_MAX;
        infos->max_rx_pktlen = UINT32_MAX;
        infos->max_rx_queues = RTE_MAX_QUEUES_PER_PORT;
        infos->max_tx_queues = RTE_MAX_QUEUES_PER_PORT;
@@ -1145,10 +1183,10 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
                DEV_RX_OFFLOAD_HEADER_SPLIT |
                DEV_RX_OFFLOAD_VLAN_FILTER |
                DEV_RX_OFFLOAD_VLAN_EXTEND |
-               DEV_RX_OFFLOAD_JUMBO_FRAME |
                DEV_RX_OFFLOAD_SCATTER |
                DEV_RX_OFFLOAD_TIMESTAMP |
-               DEV_RX_OFFLOAD_SECURITY;
+               DEV_RX_OFFLOAD_SECURITY |
+               DEV_RX_OFFLOAD_RSS_HASH;
 
        infos->rx_queue_offload_capa =
                DEV_RX_OFFLOAD_VLAN_STRIP |
@@ -1162,10 +1200,10 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
                DEV_RX_OFFLOAD_HEADER_SPLIT |
                DEV_RX_OFFLOAD_VLAN_FILTER |
                DEV_RX_OFFLOAD_VLAN_EXTEND |
-               DEV_RX_OFFLOAD_JUMBO_FRAME |
                DEV_RX_OFFLOAD_SCATTER |
                DEV_RX_OFFLOAD_TIMESTAMP |
-               DEV_RX_OFFLOAD_SECURITY;
+               DEV_RX_OFFLOAD_SECURITY |
+               DEV_RX_OFFLOAD_RSS_HASH;
 
        infos->tx_offload_capa =
                DEV_TX_OFFLOAD_MULTI_SEGS |
@@ -1464,17 +1502,11 @@ fs_rss_hash_update(struct rte_eth_dev *dev,
 }
 
 static int
-fs_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
-               enum rte_filter_type type,
-               enum rte_filter_op op,
-               void *arg)
+fs_flow_ops_get(struct rte_eth_dev *dev __rte_unused,
+               const struct rte_flow_ops **ops)
 {
-       if (type == RTE_ETH_FILTER_GENERIC &&
-           op == RTE_ETH_FILTER_GET) {
-               *(const void **)arg = &fs_flow_ops;
-               return 0;
-       }
-       return -ENOTSUP;
+       *ops = &fs_flow_ops;
+       return 0;
 }
 
 const struct eth_dev_ops failsafe_ops = {
@@ -1483,7 +1515,7 @@ const struct eth_dev_ops failsafe_ops = {
        .dev_stop = fs_dev_stop,
        .dev_set_link_down = fs_dev_set_link_down,
        .dev_set_link_up = fs_dev_set_link_up,
-       .dev_close = fs_dev_close,
+       .dev_close = failsafe_eth_dev_close,
        .promiscuous_enable = fs_promiscuous_enable,
        .promiscuous_disable = fs_promiscuous_disable,
        .allmulticast_enable = fs_allmulticast_enable,
@@ -1515,5 +1547,5 @@ const struct eth_dev_ops failsafe_ops = {
        .mac_addr_set = fs_mac_addr_set,
        .set_mc_addr_list = fs_set_mc_addr_list,
        .rss_hash_update = fs_rss_hash_update,
-       .filter_ctrl = fs_filter_ctrl,
+       .flow_ops_get = fs_flow_ops_get,
 };