net/hns3: disable PFC if not configured
[dpdk.git] / drivers / net / hns3 / hns3_dcb.c
index 30e59e8..b71e2e9 100644 (file)
@@ -415,7 +415,7 @@ hns3_dcb_pg_shapping_cfg(struct hns3_hw *hw, enum hns3_shap_bucket bucket,
        return hns3_cmd_send(hw, &desc, 1);
 }
 
-int
+static int
 hns3_pg_shaper_rate_cfg(struct hns3_hw *hw, uint8_t pg_id, uint32_t rate)
 {
        struct hns3_shaper_parameter shaper_parameter;
@@ -551,7 +551,7 @@ hns3_dcb_pri_shapping_cfg(struct hns3_hw *hw, enum hns3_shap_bucket bucket,
        return hns3_cmd_send(hw, &desc, 1);
 }
 
-int
+static int
 hns3_pri_shaper_rate_cfg(struct hns3_hw *hw, uint8_t tc_no, uint32_t rate)
 {
        struct hns3_shaper_parameter shaper_parameter;
@@ -727,6 +727,18 @@ hns3_queue_to_tc_mapping(struct hns3_hw *hw, uint16_t nb_rx_q, uint16_t nb_tx_q)
 {
        int ret;
 
+       if (nb_rx_q < hw->num_tc) {
+               hns3_err(hw, "number of Rx queues(%u) is less than number of TC(%u).",
+                        nb_rx_q, hw->num_tc);
+               return -EINVAL;
+       }
+
+       if (nb_tx_q < hw->num_tc) {
+               hns3_err(hw, "number of Tx queues(%u) is less than number of TC(%u).",
+                        nb_tx_q, hw->num_tc);
+               return -EINVAL;
+       }
+
        ret = hns3_set_rss_size(hw, nb_rx_q);
        if (ret)
                return ret;
@@ -1388,42 +1400,22 @@ hns3_dcb_undrop_tc_map(struct hns3_hw *hw, uint8_t pfc_en)
        return pfc_map;
 }
 
-static void
-hns3_dcb_cfg_validate(struct hns3_adapter *hns, uint8_t *tc, bool *changed)
+static uint8_t
+hns3_dcb_parse_num_tc(struct hns3_adapter *hns)
 {
        struct rte_eth_dcb_rx_conf *dcb_rx_conf;
        struct hns3_hw *hw = &hns->hw;
-       uint16_t nb_rx_q = hw->data->nb_rx_queues;
-       uint16_t nb_tx_q = hw->data->nb_tx_queues;
-       uint8_t max_tc = 0;
-       uint8_t pfc_en;
+       uint8_t max_tc_id = 0;
        int i;
 
        dcb_rx_conf = &hw->data->dev_conf.rx_adv_conf.dcb_rx_conf;
        for (i = 0; i < HNS3_MAX_USER_PRIO; i++) {
-               if (dcb_rx_conf->dcb_tc[i] != hw->dcb_info.prio_tc[i])
-                       *changed = true;
-
-               if (dcb_rx_conf->dcb_tc[i] > max_tc)
-                       max_tc = dcb_rx_conf->dcb_tc[i];
+               if (dcb_rx_conf->dcb_tc[i] > max_tc_id)
+                       max_tc_id = dcb_rx_conf->dcb_tc[i];
        }
-       *tc = max_tc + 1;
-       if (*tc != hw->dcb_info.num_tc)
-               *changed = true;
-
-       /*
-        * We ensure that dcb information can be reconfigured
-        * after the hns3_priority_flow_ctrl_set function called.
-        */
-       if (hw->requested_fc_mode != HNS3_FC_FULL)
-               *changed = true;
-       pfc_en = RTE_LEN2MASK((uint8_t)dcb_rx_conf->nb_tcs, uint8_t);
-       if (hw->dcb_info.pfc_en != pfc_en)
-               *changed = true;
 
-       /* tx/rx queue number is reconfigured. */
-       if (nb_rx_q != hw->used_rx_queues || nb_tx_q != hw->used_tx_queues)
-               *changed = true;
+       /* Number of TC is equal to max_tc_id plus 1. */
+       return max_tc_id + 1;
 }
 
 static int
@@ -1531,7 +1523,8 @@ hns3_dcb_hw_configure(struct hns3_adapter *hns)
        enum hns3_fc_status fc_status = hw->current_fc_status;
        enum hns3_fc_mode requested_fc_mode = hw->requested_fc_mode;
        uint8_t hw_pfc_map = hw->dcb_info.hw_pfc_map;
-       int ret, status;
+       uint8_t pfc_en = hw->dcb_info.pfc_en;
+       int ret;
 
        if (pf->tx_sch_mode != HNS3_FLAG_TC_BASE_SCH_MODE &&
            pf->tx_sch_mode != HNS3_FLAG_VNET_BASE_SCH_MODE)
@@ -1554,38 +1547,32 @@ hns3_dcb_hw_configure(struct hns3_adapter *hns)
                hw->dcb_info.hw_pfc_map =
                                hns3_dcb_undrop_tc_map(hw, hw->dcb_info.pfc_en);
 
-               ret = hns3_buffer_alloc(hw);
-               if (ret)
-                       return ret;
-
                hw->current_fc_status = HNS3_FC_STATUS_PFC;
                hw->requested_fc_mode = HNS3_FC_FULL;
-               ret = hns3_dcb_pause_setup_hw(hw);
-               if (ret) {
-                       hns3_err(hw, "setup pfc failed! ret = %d", ret);
-                       goto pfc_setup_fail;
-               }
        } else {
-               /*
-                * Although dcb_capability_en is lack of ETH_DCB_PFC_SUPPORT
-                * flag, the DCB information is configured, such as tc numbers.
-                * Therefore, refreshing the allocation of packet buffer is
-                * necessary.
-                */
-               ret = hns3_buffer_alloc(hw);
-               if (ret)
-                       return ret;
+               hw->current_fc_status = HNS3_FC_STATUS_NONE;
+               hw->requested_fc_mode = HNS3_FC_NONE;
+               hw->dcb_info.pfc_en = 0;
+               hw->dcb_info.hw_pfc_map = 0;
+       }
+
+       ret = hns3_buffer_alloc(hw);
+       if (ret)
+               goto cfg_fail;
+
+       ret = hns3_dcb_pause_setup_hw(hw);
+       if (ret) {
+               hns3_err(hw, "setup pfc failed! ret = %d", ret);
+               goto cfg_fail;
        }
 
        return 0;
 
-pfc_setup_fail:
+cfg_fail:
        hw->requested_fc_mode = requested_fc_mode;
        hw->current_fc_status = fc_status;
+       hw->dcb_info.pfc_en = pfc_en;
        hw->dcb_info.hw_pfc_map = hw_pfc_map;
-       status = hns3_buffer_alloc(hw);
-       if (status)
-               hns3_err(hw, "recover packet buffer fail! status = %d", status);
 
        return ret;
 }
@@ -1599,24 +1586,20 @@ int
 hns3_dcb_configure(struct hns3_adapter *hns)
 {
        struct hns3_hw *hw = &hns->hw;
-       bool map_changed = false;
-       uint8_t num_tc = 0;
+       uint8_t num_tc;
        int ret;
 
-       hns3_dcb_cfg_validate(hns, &num_tc, &map_changed);
-       if (map_changed ||
-           __atomic_load_n(&hw->reset.resetting,  __ATOMIC_RELAXED)) {
-               ret = hns3_dcb_info_update(hns, num_tc);
-               if (ret) {
-                       hns3_err(hw, "dcb info update failed: %d", ret);
-                       return ret;
-               }
+       num_tc = hns3_dcb_parse_num_tc(hns);
+       ret = hns3_dcb_info_update(hns, num_tc);
+       if (ret) {
+               hns3_err(hw, "dcb info update failed: %d", ret);
+               return ret;
+       }
 
-               ret = hns3_dcb_hw_configure(hns);
-               if (ret) {
-                       hns3_err(hw, "dcb sw configure failed: %d", ret);
-                       return ret;
-               }
+       ret = hns3_dcb_hw_configure(hns);
+       if (ret) {
+               hns3_err(hw, "dcb sw configure failed: %d", ret);
+               return ret;
        }
 
        return 0;
@@ -1701,14 +1684,18 @@ hns3_dcb_init(struct hns3_hw *hw)
        return 0;
 }
 
-static int
+int
 hns3_update_queue_map_configure(struct hns3_adapter *hns)
 {
        struct hns3_hw *hw = &hns->hw;
+       enum rte_eth_rx_mq_mode mq_mode = hw->data->dev_conf.rxmode.mq_mode;
        uint16_t nb_rx_q = hw->data->nb_rx_queues;
        uint16_t nb_tx_q = hw->data->nb_tx_queues;
        int ret;
 
+       if ((uint32_t)mq_mode & ETH_MQ_RX_DCB_FLAG)
+               return 0;
+
        ret = hns3_dcb_update_tc_queue_mapping(hw, nb_rx_q, nb_tx_q);
        if (ret) {
                hns3_err(hw, "failed to update tc queue mapping, ret = %d.",
@@ -1722,30 +1709,28 @@ hns3_update_queue_map_configure(struct hns3_adapter *hns)
        return ret;
 }
 
-int
-hns3_dcb_cfg_update(struct hns3_adapter *hns)
+static void
+hns3_get_fc_mode(struct hns3_hw *hw, enum rte_eth_fc_mode mode)
 {
-       struct hns3_hw *hw = &hns->hw;
-       enum rte_eth_rx_mq_mode mq_mode = hw->data->dev_conf.rxmode.mq_mode;
-       int ret;
-
-       if ((uint32_t)mq_mode & ETH_MQ_RX_DCB_FLAG) {
-               ret = hns3_dcb_configure(hns);
-               if (ret)
-                       hns3_err(hw, "Failed to config dcb: %d", ret);
-       } else {
-               /*
-                * Update queue map without PFC configuration,
-                * due to queues reconfigured by user.
-                */
-               ret = hns3_update_queue_map_configure(hns);
-               if (ret)
-                       hns3_err(hw,
-                                "Failed to update queue mapping configure: %d",
-                                ret);
+       switch (mode) {
+       case RTE_FC_NONE:
+               hw->requested_fc_mode = HNS3_FC_NONE;
+               break;
+       case RTE_FC_RX_PAUSE:
+               hw->requested_fc_mode = HNS3_FC_RX_PAUSE;
+               break;
+       case RTE_FC_TX_PAUSE:
+               hw->requested_fc_mode = HNS3_FC_TX_PAUSE;
+               break;
+       case RTE_FC_FULL:
+               hw->requested_fc_mode = HNS3_FC_FULL;
+               break;
+       default:
+               hw->requested_fc_mode = HNS3_FC_NONE;
+               hns3_warn(hw, "fc_mode(%u) exceeds member scope and is "
+                         "configured to RTE_FC_NONE", mode);
+               break;
        }
-
-       return ret;
 }
 
 /*
@@ -1760,20 +1745,28 @@ hns3_dcb_pfc_enable(struct rte_eth_dev *dev, struct rte_eth_pfc_conf *pfc_conf)
        struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct hns3_pf *pf = HNS3_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        enum hns3_fc_status fc_status = hw->current_fc_status;
+       enum hns3_fc_mode old_fc_mode = hw->requested_fc_mode;
        uint8_t hw_pfc_map = hw->dcb_info.hw_pfc_map;
        uint8_t pfc_en = hw->dcb_info.pfc_en;
        uint8_t priority = pfc_conf->priority;
        uint16_t pause_time = pf->pause_time;
-       int ret, status;
+       int ret;
 
-       pf->pause_time = pfc_conf->fc.pause_time;
-       hw->current_fc_status = HNS3_FC_STATUS_PFC;
        hw->dcb_info.pfc_en |= BIT(priority);
        hw->dcb_info.hw_pfc_map =
                        hns3_dcb_undrop_tc_map(hw, hw->dcb_info.pfc_en);
        ret = hns3_buffer_alloc(hw);
-       if (ret)
-               goto pfc_setup_fail;
+       if (ret) {
+               hns3_err(hw, "update packet buffer failed, ret = %d", ret);
+               goto buffer_alloc_fail;
+       }
+
+       pf->pause_time = pfc_conf->fc.pause_time;
+       hns3_get_fc_mode(hw, pfc_conf->fc.mode);
+       if (hw->requested_fc_mode == HNS3_FC_NONE)
+               hw->current_fc_status = HNS3_FC_STATUS_NONE;
+       else
+               hw->current_fc_status = HNS3_FC_STATUS_PFC;
 
        /*
         * The flow control mode of all UPs will be changed based on
@@ -1788,13 +1781,12 @@ hns3_dcb_pfc_enable(struct rte_eth_dev *dev, struct rte_eth_pfc_conf *pfc_conf)
        return 0;
 
 pfc_setup_fail:
+       hw->requested_fc_mode = old_fc_mode;
        hw->current_fc_status = fc_status;
        pf->pause_time = pause_time;
+buffer_alloc_fail:
        hw->dcb_info.pfc_en = pfc_en;
        hw->dcb_info.hw_pfc_map = hw_pfc_map;
-       status = hns3_buffer_alloc(hw);
-       if (status)
-               hns3_err(hw, "recover packet buffer fail: %d", status);
 
        return ret;
 }
@@ -1810,11 +1802,13 @@ hns3_fc_enable(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 {
        struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct hns3_pf *pf = HNS3_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+       enum hns3_fc_mode old_fc_mode = hw->requested_fc_mode;
        enum hns3_fc_status fc_status = hw->current_fc_status;
        uint16_t pause_time = pf->pause_time;
        int ret;
 
        pf->pause_time = fc_conf->pause_time;
+       hns3_get_fc_mode(hw, fc_conf->mode);
 
        /*
         * In fact, current_fc_status is HNS3_FC_STATUS_NONE when mode
@@ -1834,6 +1828,7 @@ hns3_fc_enable(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        return 0;
 
 setup_fc_fail:
+       hw->requested_fc_mode = old_fc_mode;
        hw->current_fc_status = fc_status;
        pf->pause_time = pause_time;