net/hns3: support queue start and stop
[dpdk.git] / drivers / net / hns3 / hns3_ethdev.c
index b9868de..30151b6 100644 (file)
@@ -35,7 +35,7 @@
 #define HNS3_DEFAULT_PORT_CONF_QUEUES_NUM      1
 
 #define HNS3_SERVICE_INTERVAL          1000000 /* us */
-#define HNS3_INVLID_PVID               0xFFFF
+#define HNS3_INVALID_PVID              0xFFFF
 
 #define HNS3_FILTER_TYPE_VF            0
 #define HNS3_FILTER_TYPE_PORT          1
@@ -56,6 +56,9 @@
 #define HNS3_FUN_RST_ING_B             0
 
 #define HNS3_VECTOR0_IMP_RESET_INT_B   1
+#define HNS3_VECTOR0_IMP_CMDQ_ERR_B    4U
+#define HNS3_VECTOR0_IMP_RD_POISON_B   5U
+#define HNS3_VECTOR0_ALL_MSIX_ERR_B    6U
 
 #define HNS3_RESET_WAIT_MS     100
 #define HNS3_RESET_WAIT_CNT    200
@@ -97,12 +100,14 @@ hns3_check_event_cause(struct hns3_adapter *hns, uint32_t *clearval)
        struct hns3_hw *hw = &hns->hw;
        uint32_t vector0_int_stats;
        uint32_t cmdq_src_val;
+       uint32_t hw_err_src_reg;
        uint32_t val;
        enum hns3_evt_cause ret;
 
        /* fetch the events from their corresponding regs */
        vector0_int_stats = hns3_read_dev(hw, HNS3_VECTOR0_OTHER_INT_STS_REG);
        cmdq_src_val = hns3_read_dev(hw, HNS3_VECTOR0_CMDQ_SRC_REG);
+       hw_err_src_reg = hns3_read_dev(hw, HNS3_RAS_PF_OTHER_INT_STS_REG);
 
        /*
         * Assumption: If by any chance reset and mailbox events are reported
@@ -145,8 +150,9 @@ hns3_check_event_cause(struct hns3_adapter *hns, uint32_t *clearval)
        }
 
        /* check for vector0 msix event source */
-       if (vector0_int_stats & HNS3_VECTOR0_REG_MSIX_MASK) {
-               val = vector0_int_stats;
+       if (vector0_int_stats & HNS3_VECTOR0_REG_MSIX_MASK ||
+           hw_err_src_reg & HNS3_RAS_REG_NFE_MASK) {
+               val = vector0_int_stats | hw_err_src_reg;
                ret = HNS3_VECTOR0_EVENT_ERR;
                goto out;
        }
@@ -159,9 +165,9 @@ hns3_check_event_cause(struct hns3_adapter *hns, uint32_t *clearval)
                goto out;
        }
 
-       if (clearval && (vector0_int_stats || cmdq_src_val))
-               hns3_warn(hw, "surprise irq ector0_int_stats:0x%x cmdq_src_val:0x%x",
-                         vector0_int_stats, cmdq_src_val);
+       if (clearval && (vector0_int_stats || cmdq_src_val || hw_err_src_reg))
+               hns3_warn(hw, "vector0_int_stats:0x%x cmdq_src_val:0x%x hw_err_src_reg:0x%x",
+                         vector0_int_stats, cmdq_src_val, hw_err_src_reg);
        val = vector0_int_stats;
        ret = HNS3_VECTOR0_EVENT_OTHER;
 out:
@@ -215,11 +221,14 @@ hns3_interrupt_handler(void *param)
 
        /* vector 0 interrupt is shared with reset and mailbox source events. */
        if (event_cause == HNS3_VECTOR0_EVENT_ERR) {
+               hns3_warn(hw, "Received err interrupt");
                hns3_handle_msix_error(hns, &hw->reset.request);
+               hns3_handle_ras_error(hns, &hw->reset.request);
                hns3_schedule_reset(hns);
-       } else if (event_cause == HNS3_VECTOR0_EVENT_RST)
+       } else if (event_cause == HNS3_VECTOR0_EVENT_RST) {
+               hns3_warn(hw, "Received reset interrupt");
                hns3_schedule_reset(hns);
-       else if (event_cause == HNS3_VECTOR0_EVENT_MBX)
+       else if (event_cause == HNS3_VECTOR0_EVENT_MBX)
                hns3_dev_handle_mbx_msg(hw);
        else
                hns3_err(hw, "Received unknown event");
@@ -337,8 +346,9 @@ hns3_vlan_filter_configure(struct hns3_adapter *hns, uint16_t vlan_id, int on)
        int ret = 0;
 
        /*
-        * When vlan filter is enabled, hardware regards vlan id 0 as the entry
-        * for normal packet, deleting vlan id 0 is not allowed.
+        * When vlan filter is enabled, hardware regards packets without vlan
+        * as packets with vlan 0. So, to receive packets without vlan, vlan id
+        * 0 is not allowed to be removed by rte_eth_dev_vlan_filter.
         */
        if (on == 0 && vlan_id == 0)
                return 0;
@@ -355,7 +365,7 @@ hns3_vlan_filter_configure(struct hns3_adapter *hns, uint16_t vlan_id, int on)
                writen_to_tbl = true;
        }
 
-       if (ret == 0 && vlan_id) {
+       if (ret == 0) {
                if (on)
                        hns3_add_dev_vlan_table(hns, vlan_id, writen_to_tbl);
                else
@@ -468,6 +478,11 @@ hns3_set_vlan_rx_offload_cfg(struct hns3_adapter *hns,
        hns3_set_bit(req->vport_vlan_cfg, HNS3_SHOW_TAG2_EN_B,
                     vcfg->vlan2_vlan_prionly ? 1 : 0);
 
+       /* firmwall will ignore this configuration for PCI_REVISION_ID_HIP08 */
+       hns3_set_bit(req->vport_vlan_cfg, HNS3_DISCARD_TAG1_EN_B,
+                    vcfg->strip_tag1_discard_en ? 1 : 0);
+       hns3_set_bit(req->vport_vlan_cfg, HNS3_DISCARD_TAG2_EN_B,
+                    vcfg->strip_tag2_discard_en ? 1 : 0);
        /*
         * In current version VF is not supported when PF is driven by DPDK
         * driver, just need to configure parameters for PF vport.
@@ -509,11 +524,14 @@ hns3_en_hw_strip_rxvtag(struct hns3_adapter *hns, bool enable)
        if (hw->port_base_vlan_cfg.state == HNS3_PORT_BASE_VLAN_DISABLE) {
                rxvlan_cfg.strip_tag1_en = false;
                rxvlan_cfg.strip_tag2_en = enable;
+               rxvlan_cfg.strip_tag2_discard_en = false;
        } else {
                rxvlan_cfg.strip_tag1_en = enable;
                rxvlan_cfg.strip_tag2_en = true;
+               rxvlan_cfg.strip_tag2_discard_en = true;
        }
 
+       rxvlan_cfg.strip_tag1_discard_en = false;
        rxvlan_cfg.vlan1_vlan_prionly = false;
        rxvlan_cfg.vlan2_vlan_prionly = false;
        rxvlan_cfg.rx_vlan_offload_en = enable;
@@ -669,6 +687,10 @@ hns3_set_vlan_tx_offload_cfg(struct hns3_adapter *hns,
                     vcfg->insert_tag2_en ? 1 : 0);
        hns3_set_bit(req->vport_vlan_cfg, HNS3_CFG_NIC_ROCE_SEL_B, 0);
 
+       /* firmwall will ignore this configuration for PCI_REVISION_ID_HIP08 */
+       hns3_set_bit(req->vport_vlan_cfg, HNS3_TAG_SHIFT_MODE_EN_B,
+                    vcfg->tag_shift_mode_en ? 1 : 0);
+
        /*
         * In current version VF is not supported when PF is driven by DPDK
         * driver, just need to configure parameters for PF vport.
@@ -698,7 +720,8 @@ hns3_vlan_txvlan_cfg(struct hns3_adapter *hns, uint16_t port_base_vlan_state,
                txvlan_cfg.insert_tag1_en = false;
                txvlan_cfg.default_tag1 = 0;
        } else {
-               txvlan_cfg.accept_tag1 = false;
+               txvlan_cfg.accept_tag1 =
+                       hw->vlan_mode == HNS3_HW_SHIFT_AND_DISCARD_MODE;
                txvlan_cfg.insert_tag1_en = true;
                txvlan_cfg.default_tag1 = pvid;
        }
@@ -708,6 +731,7 @@ hns3_vlan_txvlan_cfg(struct hns3_adapter *hns, uint16_t port_base_vlan_state,
        txvlan_cfg.accept_untag2 = true;
        txvlan_cfg.insert_tag2_en = false;
        txvlan_cfg.default_tag2 = 0;
+       txvlan_cfg.tag_shift_mode_en = true;
 
        ret = hns3_set_vlan_tx_offload_cfg(hns, &txvlan_cfg);
        if (ret) {
@@ -720,16 +744,6 @@ hns3_vlan_txvlan_cfg(struct hns3_adapter *hns, uint16_t port_base_vlan_state,
        return ret;
 }
 
-static void
-hns3_store_port_base_vlan_info(struct hns3_adapter *hns, uint16_t pvid, int on)
-{
-       struct hns3_hw *hw = &hns->hw;
-
-       hw->port_base_vlan_cfg.state = on ?
-           HNS3_PORT_BASE_VLAN_ENABLE : HNS3_PORT_BASE_VLAN_DISABLE;
-
-       hw->port_base_vlan_cfg.pvid = pvid;
-}
 
 static void
 hns3_rm_all_vlan_table(struct hns3_adapter *hns, bool is_del_list)
@@ -738,10 +752,10 @@ hns3_rm_all_vlan_table(struct hns3_adapter *hns, bool is_del_list)
        struct hns3_pf *pf = &hns->pf;
 
        LIST_FOREACH(vlan_entry, &pf->vlan_list, next) {
-               if (vlan_entry->hd_tbl_status)
+               if (vlan_entry->hd_tbl_status) {
                        hns3_set_port_vlan_filter(hns, vlan_entry->vlan_id, 0);
-
-               vlan_entry->hd_tbl_status = false;
+                       vlan_entry->hd_tbl_status = false;
+               }
        }
 
        if (is_del_list) {
@@ -761,10 +775,10 @@ hns3_add_all_vlan_table(struct hns3_adapter *hns)
        struct hns3_pf *pf = &hns->pf;
 
        LIST_FOREACH(vlan_entry, &pf->vlan_list, next) {
-               if (!vlan_entry->hd_tbl_status)
+               if (!vlan_entry->hd_tbl_status) {
                        hns3_set_port_vlan_filter(hns, vlan_entry->vlan_id, 1);
-
-               vlan_entry->hd_tbl_status = true;
+                       vlan_entry->hd_tbl_status = true;
+               }
        }
 }
 
@@ -775,7 +789,7 @@ hns3_remove_all_vlan_table(struct hns3_adapter *hns)
        int ret;
 
        hns3_rm_all_vlan_table(hns, true);
-       if (hw->port_base_vlan_cfg.pvid != HNS3_INVLID_PVID) {
+       if (hw->port_base_vlan_cfg.pvid != HNS3_INVALID_PVID) {
                ret = hns3_set_port_vlan_filter(hns,
                                                hw->port_base_vlan_cfg.pvid, 0);
                if (ret) {
@@ -788,40 +802,41 @@ hns3_remove_all_vlan_table(struct hns3_adapter *hns)
 
 static int
 hns3_update_vlan_filter_entries(struct hns3_adapter *hns,
-                               uint16_t port_base_vlan_state,
-                               uint16_t new_pvid, uint16_t old_pvid)
+                       uint16_t port_base_vlan_state, uint16_t new_pvid)
 {
        struct hns3_hw *hw = &hns->hw;
-       int ret = 0;
+       uint16_t old_pvid;
+       int ret;
 
        if (port_base_vlan_state == HNS3_PORT_BASE_VLAN_ENABLE) {
-               if (old_pvid != HNS3_INVLID_PVID && old_pvid != 0) {
+               old_pvid = hw->port_base_vlan_cfg.pvid;
+               if (old_pvid != HNS3_INVALID_PVID) {
                        ret = hns3_set_port_vlan_filter(hns, old_pvid, 0);
                        if (ret) {
-                               hns3_err(hw,
-                                        "Failed to clear clear old pvid filter, ret =%d",
-                                        ret);
+                               hns3_err(hw, "failed to remove old pvid %u, "
+                                               "ret = %d", old_pvid, ret);
                                return ret;
                        }
                }
 
                hns3_rm_all_vlan_table(hns, false);
-               return hns3_set_port_vlan_filter(hns, new_pvid, 1);
-       }
-
-       if (new_pvid != 0) {
+               ret = hns3_set_port_vlan_filter(hns, new_pvid, 1);
+               if (ret) {
+                       hns3_err(hw, "failed to add new pvid %u, ret = %d",
+                                       new_pvid, ret);
+                       return ret;
+               }
+       } else {
                ret = hns3_set_port_vlan_filter(hns, new_pvid, 0);
                if (ret) {
-                       hns3_err(hw, "Failed to set port vlan filter, ret =%d",
-                                ret);
+                       hns3_err(hw, "failed to remove pvid %u, ret = %d",
+                                       new_pvid, ret);
                        return ret;
                }
-       }
 
-       if (new_pvid == hw->port_base_vlan_cfg.pvid)
                hns3_add_all_vlan_table(hns);
-
-       return ret;
+       }
+       return 0;
 }
 
 static int
@@ -832,14 +847,17 @@ hns3_en_pvid_strip(struct hns3_adapter *hns, int on)
        bool rx_strip_en;
        int ret;
 
-       rx_strip_en = old_cfg->rx_vlan_offload_en ? true : false;
+       rx_strip_en = old_cfg->rx_vlan_offload_en;
        if (on) {
                rx_vlan_cfg.strip_tag1_en = rx_strip_en;
                rx_vlan_cfg.strip_tag2_en = true;
+               rx_vlan_cfg.strip_tag2_discard_en = true;
        } else {
                rx_vlan_cfg.strip_tag1_en = false;
                rx_vlan_cfg.strip_tag2_en = rx_strip_en;
+               rx_vlan_cfg.strip_tag2_discard_en = false;
        }
+       rx_vlan_cfg.strip_tag1_discard_en = false;
        rx_vlan_cfg.vlan1_vlan_prionly = false;
        rx_vlan_cfg.vlan2_vlan_prionly = false;
        rx_vlan_cfg.rx_vlan_offload_en = old_cfg->rx_vlan_offload_en;
@@ -857,11 +875,10 @@ hns3_vlan_pvid_configure(struct hns3_adapter *hns, uint16_t pvid, int on)
 {
        struct hns3_hw *hw = &hns->hw;
        uint16_t port_base_vlan_state;
-       uint16_t old_pvid;
        int ret;
 
        if (on == 0 && pvid != hw->port_base_vlan_cfg.pvid) {
-               if (hw->port_base_vlan_cfg.pvid != HNS3_INVLID_PVID)
+               if (hw->port_base_vlan_cfg.pvid != HNS3_INVALID_PVID)
                        hns3_warn(hw, "Invalid operation! As current pvid set "
                                  "is %u, disable pvid %u is invalid",
                                  hw->port_base_vlan_cfg.pvid, pvid);
@@ -884,19 +901,18 @@ hns3_vlan_pvid_configure(struct hns3_adapter *hns, uint16_t pvid, int on)
                return ret;
        }
 
-       if (pvid == HNS3_INVLID_PVID)
+       if (pvid == HNS3_INVALID_PVID)
                goto out;
-       old_pvid = hw->port_base_vlan_cfg.pvid;
-       ret = hns3_update_vlan_filter_entries(hns, port_base_vlan_state, pvid,
-                                             old_pvid);
+       ret = hns3_update_vlan_filter_entries(hns, port_base_vlan_state, pvid);
        if (ret) {
-               hns3_err(hw, "Failed to update vlan filter entries, ret =%d",
+               hns3_err(hw, "failed to update vlan filter entries, ret = %d",
                         ret);
                return ret;
        }
 
 out:
-       hns3_store_port_base_vlan_info(hns, pvid, on);
+       hw->port_base_vlan_cfg.state = port_base_vlan_state;
+       hw->port_base_vlan_cfg.pvid = on ? pvid : HNS3_INVALID_PVID;
        return ret;
 }
 
@@ -931,27 +947,30 @@ hns3_vlan_pvid_set(struct rte_eth_dev *dev, uint16_t pvid, int on)
        rte_spinlock_unlock(&hw->lock);
        if (ret)
                return ret;
-
-       if (pvid_en_state_change)
-               hns3_update_all_queues_pvid_state(hw);
+       /*
+        * Only in HNS3_SW_SHIFT_AND_MODE the PVID related operation in Tx/Rx
+        * need be processed by PMD driver.
+        */
+       if (pvid_en_state_change &&
+           hw->vlan_mode == HNS3_SW_SHIFT_AND_DISCARD_MODE)
+               hns3_update_all_queues_pvid_proc_en(hw);
 
        return 0;
 }
 
-static void
-init_port_base_vlan_info(struct hns3_hw *hw)
-{
-       hw->port_base_vlan_cfg.state = HNS3_PORT_BASE_VLAN_DISABLE;
-       hw->port_base_vlan_cfg.pvid = HNS3_INVLID_PVID;
-}
-
 static int
 hns3_default_vlan_config(struct hns3_adapter *hns)
 {
        struct hns3_hw *hw = &hns->hw;
        int ret;
 
-       ret = hns3_set_port_vlan_filter(hns, 0, 1);
+       /*
+        * When vlan filter is enabled, hardware regards packets without vlan
+        * as packets with vlan 0. Therefore, if vlan 0 is not in the vlan
+        * table, packets without vlan won't be received. So, add vlan 0 as
+        * the default vlan.
+        */
+       ret = hns3_vlan_filter_configure(hns, 0, 1);
        if (ret)
                hns3_err(hw, "default vlan 0 config failed, ret =%d", ret);
        return ret;
@@ -970,8 +989,10 @@ hns3_init_vlan_config(struct hns3_adapter *hns)
         * ensure that the hardware configuration remains unchanged before and
         * after reset.
         */
-       if (rte_atomic16_read(&hw->reset.resetting) == 0)
-               init_port_base_vlan_info(hw);
+       if (rte_atomic16_read(&hw->reset.resetting) == 0) {
+               hw->port_base_vlan_cfg.state = HNS3_PORT_BASE_VLAN_DISABLE;
+               hw->port_base_vlan_cfg.pvid = HNS3_INVALID_PVID;
+       }
 
        ret = hns3_vlan_filter_init(hns);
        if (ret) {
@@ -993,7 +1014,7 @@ hns3_init_vlan_config(struct hns3_adapter *hns)
         * and hns3_restore_vlan_conf later.
         */
        if (rte_atomic16_read(&hw->reset.resetting) == 0) {
-               ret = hns3_vlan_pvid_configure(hns, HNS3_INVLID_PVID, 0);
+               ret = hns3_vlan_pvid_configure(hns, HNS3_INVALID_PVID, 0);
                if (ret) {
                        hns3_err(hw, "pvid set fail in pf, ret =%d", ret);
                        return ret;
@@ -1401,7 +1422,7 @@ hns3_add_uc_addr_common(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)
        struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
        struct hns3_mac_vlan_tbl_entry_cmd req;
        struct hns3_pf *pf = &hns->pf;
-       struct hns3_cmd_desc desc;
+       struct hns3_cmd_desc desc[3];
        char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
        uint16_t egress_port = 0;
        uint8_t vf_id;
@@ -1435,7 +1456,7 @@ hns3_add_uc_addr_common(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)
         * it if the entry is inexistent. Repeated unicast entry
         * is not allowed in the mac vlan table.
         */
-       ret = hns3_lookup_mac_vlan_tbl(hw, &req, &desc, false);
+       ret = hns3_lookup_mac_vlan_tbl(hw, &req, desc, false);
        if (ret == -ENOENT) {
                if (!hns3_is_umv_space_full(hw)) {
                        ret = hns3_add_mac_vlan_tbl(hw, &req, NULL);
@@ -2208,7 +2229,7 @@ hns3_bind_ring_with_vector(struct hns3_hw *hw, uint8_t vector_id, bool mmap,
 static int
 hns3_init_ring_with_vector(struct hns3_hw *hw)
 {
-       uint8_t vec;
+       uint16_t vec;
        int ret;
        int i;
 
@@ -2219,27 +2240,23 @@ hns3_init_ring_with_vector(struct hns3_hw *hw)
         * vector. In the initialization clearing the all hardware mapping
         * relationship configurations between queues and interrupt vectors is
         * needed, so some error caused by the residual configurations, such as
-        * the unexpected Tx interrupt, can be avoid. Because of the hardware
-        * constraints in hns3 hardware engine, we have to implement clearing
-        * the mapping relationship configurations by binding all queues to the
-        * last interrupt vector and reserving the last interrupt vector. This
-        * method results in a decrease of the maximum queues when upper
-        * applications call the rte_eth_dev_configure API function to enable
-        * Rx interrupt.
+        * the unexpected Tx interrupt, can be avoid.
         */
        vec = hw->num_msi - 1; /* vector 0 for misc interrupt, not for queue */
-       /* vec - 1: the last interrupt is reserved */
-       hw->intr_tqps_num = vec > hw->tqps_num ? hw->tqps_num : vec - 1;
+       if (hw->intr.mapping_mode == HNS3_INTR_MAPPING_VEC_RSV_ONE)
+               vec = vec - 1; /* the last interrupt is reserved */
+       hw->intr_tqps_num = RTE_MIN(vec, hw->tqps_num);
        for (i = 0; i < hw->intr_tqps_num; i++) {
                /*
-                * Set gap limiter and rate limiter configuration of queue's
-                * interrupt.
+                * Set gap limiter/rate limiter/quanity limiter algorithm
+                * configuration for interrupt coalesce of queue's interrupt.
                 */
                hns3_set_queue_intr_gl(hw, i, HNS3_RING_GL_RX,
                                       HNS3_TQP_INTR_GL_DEFAULT);
                hns3_set_queue_intr_gl(hw, i, HNS3_RING_GL_TX,
                                       HNS3_TQP_INTR_GL_DEFAULT);
                hns3_set_queue_intr_rl(hw, i, HNS3_TQP_INTR_RL_DEFAULT);
+               hns3_set_queue_intr_ql(hw, i, HNS3_TQP_INTR_QL_DEFAULT);
 
                ret = hns3_bind_ring_with_vector(hw, vec, false,
                                                 HNS3_RING_TYPE_TX, i);
@@ -2276,20 +2293,25 @@ hns3_dev_configure(struct rte_eth_dev *dev)
        bool gro_en;
        int ret;
 
+       hw->cfg_max_queues = RTE_MAX(nb_rx_q, nb_tx_q);
+
        /*
-        * Hardware does not support individually enable/disable/reset the Tx or
-        * Rx queue in hns3 network engine. Driver must enable/disable/reset Tx
-        * and Rx queues at the same time. When the numbers of Tx queues
-        * allocated by upper applications are not equal to the numbers of Rx
-        * queues, driver needs to setup fake Tx or Rx queues to adjust numbers
-        * of Tx/Rx queues. otherwise, network engine can not work as usual. But
-        * these fake queues are imperceptible, and can not be used by upper
-        * applications.
+        * Some versions of hardware network engine does not support
+        * individually enable/disable/reset the Tx or Rx queue. These devices
+        * must enable/disable/reset Tx and Rx queues at the same time. When the
+        * numbers of Tx queues allocated by upper applications are not equal to
+        * the numbers of Rx queues, driver needs to setup fake Tx or Rx queues
+        * to adjust numbers of Tx/Rx queues. otherwise, network engine can not
+        * work as usual. But these fake queues are imperceptible, and can not
+        * be used by upper applications.
         */
-       ret = hns3_set_fake_rx_or_tx_queues(dev, nb_rx_q, nb_tx_q);
-       if (ret) {
-               hns3_err(hw, "Failed to set rx/tx fake queues: %d", ret);
-               return ret;
+       if (!hns3_dev_indep_txrx_supported(hw)) {
+               ret = hns3_set_fake_rx_or_tx_queues(dev, nb_rx_q, nb_tx_q);
+               if (ret) {
+                       hns3_err(hw, "fail to set Rx/Tx fake queues, ret = %d.",
+                                ret);
+                       return ret;
+               }
        }
 
        hw->adapter_state = HNS3_NIC_CONFIGURING;
@@ -2309,6 +2331,7 @@ hns3_dev_configure(struct rte_eth_dev *dev)
        if ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {
                conf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
                rss_conf = conf->rx_adv_conf.rss_conf;
+               hw->rss_dis_flag = false;
                if (rss_conf.rss_key == NULL) {
                        rss_conf.rss_key = rss_cfg->key;
                        rss_conf.rss_key_len = HNS3_RSS_KEY_SIZE;
@@ -2346,6 +2369,12 @@ hns3_dev_configure(struct rte_eth_dev *dev)
        if (ret)
                goto cfg_err;
 
+       hns->rx_simple_allowed = true;
+       hns->rx_vec_allowed = true;
+       hns->tx_simple_allowed = true;
+       hns->tx_vec_allowed = true;
+
+       hns3_init_rx_ptype_tble(dev);
        hw->adapter_state = HNS3_NIC_CONFIGURED;
 
        return 0;
@@ -2450,7 +2479,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
        info->max_rx_queues = queue_num;
        info->max_tx_queues = hw->tqps_num;
        info->max_rx_pktlen = HNS3_MAX_FRAME_LEN; /* CRC included */
-       info->min_rx_bufsize = hw->rx_buf_len;
+       info->min_rx_bufsize = HNS3_MIN_BD_BUF_SIZE;
        info->max_mac_addrs = HNS3_UC_MACADDR_NUM;
        info->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD;
        info->max_lro_pkt_size = HNS3_MAX_LRO_SIZE;
@@ -2467,7 +2496,6 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
                                 DEV_RX_OFFLOAD_JUMBO_FRAME |
                                 DEV_RX_OFFLOAD_RSS_HASH |
                                 DEV_RX_OFFLOAD_TCP_LRO);
-       info->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;
        info->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
                                 DEV_TX_OFFLOAD_IPV4_CKSUM |
                                 DEV_TX_OFFLOAD_TCP_CKSUM |
@@ -2478,9 +2506,13 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
                                 DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
                                 DEV_TX_OFFLOAD_GRE_TNL_TSO |
                                 DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
-                                info->tx_queue_offload_capa |
+                                DEV_TX_OFFLOAD_MBUF_FAST_FREE |
                                 hns3_txvlan_cap_get(hw));
 
+       if (hns3_dev_indep_txrx_supported(hw))
+               info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
+                                RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
+
        info->rx_desc_lim = (struct rte_eth_desc_lim) {
                .nb_max = HNS3_MAX_RING_DESC,
                .nb_min = HNS3_MIN_RING_DESC,
@@ -2492,7 +2524,22 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
                .nb_min = HNS3_MIN_RING_DESC,
                .nb_align = HNS3_ALIGN_RING_DESC,
                .nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT,
-               .nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT,
+               .nb_mtu_seg_max = hw->max_non_tso_bd_num,
+       };
+
+       info->default_rxconf = (struct rte_eth_rxconf) {
+               .rx_free_thresh = HNS3_DEFAULT_RX_FREE_THRESH,
+               /*
+                * If there are no available Rx buffer descriptors, incoming
+                * packets are always dropped by hardware based on hns3 network
+                * engine.
+                */
+               .rx_drop_en = 1,
+               .offloads = 0,
+       };
+       info->default_txconf = (struct rte_eth_txconf) {
+               .tx_rs_thresh = HNS3_DEFAULT_TX_RS_THRESH,
+               .offloads = 0,
        };
 
        info->vmdq_queue_num = 0;
@@ -2560,6 +2607,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,
        case ETH_SPEED_NUM_40G:
        case ETH_SPEED_NUM_50G:
        case ETH_SPEED_NUM_100G:
+       case ETH_SPEED_NUM_200G:
                new_link.link_speed = mac->link_speed;
                break;
        default:
@@ -2620,6 +2668,49 @@ hns3_query_function_status(struct hns3_hw *hw)
        return hns3_parse_func_status(hw, req);
 }
 
+static int
+hns3_get_pf_max_tqp_num(struct hns3_hw *hw)
+{
+       struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
+       struct hns3_pf *pf = &hns->pf;
+
+       if (pf->tqp_config_mode == HNS3_FLEX_MAX_TQP_NUM_MODE) {
+               /*
+                * The total_tqps_num obtained from firmware is maximum tqp
+                * numbers of this port, which should be used for PF and VFs.
+                * There is no need for pf to have so many tqp numbers in
+                * most cases. RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF,
+                * coming from config file, is assigned to maximum queue number
+                * for the PF of this port by user. So users can modify the
+                * maximum queue number of PF according to their own application
+                * scenarios, which is more flexible to use. In addition, many
+                * memories can be saved due to allocating queue statistics
+                * room according to the actual number of queues required. The
+                * maximum queue number of PF for network engine with
+                * revision_id greater than 0x30 is assigned by config file.
+                */
+               if (RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF <= 0) {
+                       hns3_err(hw, "RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF(%d) "
+                                "must be greater than 0.",
+                                RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF);
+                       return -EINVAL;
+               }
+
+               hw->tqps_num = RTE_MIN(RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF,
+                                      hw->total_tqps_num);
+       } else {
+               /*
+                * Due to the limitation on the number of PF interrupts
+                * available, the maximum queue number assigned to PF on
+                * the network engine with revision_id 0x21 is 64.
+                */
+               hw->tqps_num = RTE_MIN(hw->total_tqps_num,
+                                      HNS3_MAX_TQP_NUM_HIP08_PF);
+       }
+
+       return 0;
+}
+
 static int
 hns3_query_pf_resource(struct hns3_hw *hw)
 {
@@ -2637,9 +2728,13 @@ hns3_query_pf_resource(struct hns3_hw *hw)
        }
 
        req = (struct hns3_pf_res_cmd *)desc.data;
-       hw->total_tqps_num = rte_le_to_cpu_16(req->tqp_num);
+       hw->total_tqps_num = rte_le_to_cpu_16(req->tqp_num) +
+                            rte_le_to_cpu_16(req->ext_tqp_num);
+       ret = hns3_get_pf_max_tqp_num(hw);
+       if (ret)
+               return ret;
+
        pf->pkt_buf_size = rte_le_to_cpu_16(req->buf_size) << HNS3_BUF_UNIT_S;
-       hw->tqps_num = RTE_MIN(hw->total_tqps_num, HNS3_MAX_TQP_NUM_PER_FUNC);
        pf->func_num = rte_le_to_cpu_16(req->pf_own_fun_number);
 
        if (req->tx_buf_size)
@@ -2659,8 +2754,8 @@ hns3_query_pf_resource(struct hns3_hw *hw)
        pf->dv_buf_size = roundup(pf->dv_buf_size, HNS3_BUF_SIZE_UNIT);
 
        hw->num_msi =
-           hns3_get_field(rte_le_to_cpu_16(req->pf_intr_vector_number),
-                          HNS3_VEC_NUM_M, HNS3_VEC_NUM_S);
+               hns3_get_field(rte_le_to_cpu_16(req->nic_pf_intr_vector_number),
+                              HNS3_PF_VEC_NUM_M, HNS3_PF_VEC_NUM_S);
 
        return 0;
 }
@@ -2670,6 +2765,7 @@ hns3_parse_cfg(struct hns3_cfg *cfg, struct hns3_cmd_desc *desc)
 {
        struct hns3_cfg_param_cmd *req;
        uint64_t mac_addr_tmp_high;
+       uint8_t ext_rss_size_max;
        uint64_t mac_addr_tmp;
        uint32_t i;
 
@@ -2722,6 +2818,21 @@ hns3_parse_cfg(struct hns3_cfg *cfg, struct hns3_cmd_desc *desc)
                                        HNS3_CFG_UMV_TBL_SPACE_S);
        if (!cfg->umv_space)
                cfg->umv_space = HNS3_DEFAULT_UMV_SPACE_PER_PF;
+
+       ext_rss_size_max = hns3_get_field(rte_le_to_cpu_32(req->param[2]),
+                                              HNS3_CFG_EXT_RSS_SIZE_M,
+                                              HNS3_CFG_EXT_RSS_SIZE_S);
+
+       /*
+        * Field ext_rss_size_max obtained from firmware will be more flexible
+        * for future changes and expansions, which is an exponent of 2, instead
+        * of reading out directly. If this field is not zero, hns3 PF PMD
+        * driver uses it as rss_size_max under one TC. Device, whose revision
+        * id is greater than or equal to PCI_REVISION_ID_HIP09_A, obtains the
+        * maximum number of queues supported under a TC through this field.
+        */
+       if (ext_rss_size_max)
+               cfg->rss_size_max = 1U << ext_rss_size_max;
 }
 
 /* hns3_get_board_cfg: query the static parameter from NCL_config file in flash
@@ -2789,6 +2900,9 @@ hns3_parse_speed(int speed_cmd, uint32_t *speed)
        case HNS3_CFG_SPEED_100G:
                *speed = ETH_SPEED_NUM_100G;
                break;
+       case HNS3_CFG_SPEED_200G:
+               *speed = ETH_SPEED_NUM_200G;
+               break;
        default:
                return -EINVAL;
        }
@@ -2796,10 +2910,57 @@ hns3_parse_speed(int speed_cmd, uint32_t *speed)
        return 0;
 }
 
+static void
+hns3_set_default_dev_specifications(struct hns3_hw *hw)
+{
+       hw->max_non_tso_bd_num = HNS3_MAX_NON_TSO_BD_PER_PKT;
+       hw->rss_ind_tbl_size = HNS3_RSS_IND_TBL_SIZE;
+       hw->rss_key_size = HNS3_RSS_KEY_SIZE;
+       hw->max_tm_rate = HNS3_ETHER_MAX_RATE;
+}
+
+static void
+hns3_parse_dev_specifications(struct hns3_hw *hw, struct hns3_cmd_desc *desc)
+{
+       struct hns3_dev_specs_0_cmd *req0;
+
+       req0 = (struct hns3_dev_specs_0_cmd *)desc[0].data;
+
+       hw->max_non_tso_bd_num = req0->max_non_tso_bd_num;
+       hw->rss_ind_tbl_size = rte_le_to_cpu_16(req0->rss_ind_tbl_size);
+       hw->rss_key_size = rte_le_to_cpu_16(req0->rss_key_size);
+       hw->max_tm_rate = rte_le_to_cpu_32(req0->max_tm_rate);
+}
+
+static int
+hns3_query_dev_specifications(struct hns3_hw *hw)
+{
+       struct hns3_cmd_desc desc[HNS3_QUERY_DEV_SPECS_BD_NUM];
+       int ret;
+       int i;
+
+       for (i = 0; i < HNS3_QUERY_DEV_SPECS_BD_NUM - 1; i++) {
+               hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS,
+                                         true);
+               desc[i].flag |= rte_cpu_to_le_16(HNS3_CMD_FLAG_NEXT);
+       }
+       hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS, true);
+
+       ret = hns3_cmd_send(hw, desc, HNS3_QUERY_DEV_SPECS_BD_NUM);
+       if (ret)
+               return ret;
+
+       hns3_parse_dev_specifications(hw, desc);
+
+       return 0;
+}
+
 static int
 hns3_get_capability(struct hns3_hw *hw)
 {
+       struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
        struct rte_pci_device *pci_dev;
+       struct hns3_pf *pf = &hns->pf;
        struct rte_eth_dev *eth_dev;
        uint16_t device_id;
        uint8_t revision;
@@ -2811,18 +2972,48 @@ hns3_get_capability(struct hns3_hw *hw)
 
        if (device_id == HNS3_DEV_ID_25GE_RDMA ||
            device_id == HNS3_DEV_ID_50GE_RDMA ||
-           device_id == HNS3_DEV_ID_100G_RDMA_MACSEC)
+           device_id == HNS3_DEV_ID_100G_RDMA_MACSEC ||
+           device_id == HNS3_DEV_ID_200G_RDMA)
                hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_DCB_B, 1);
 
        /* Get PCI revision id */
        ret = rte_pci_read_config(pci_dev, &revision, HNS3_PCI_REVISION_ID_LEN,
                                  HNS3_PCI_REVISION_ID);
        if (ret != HNS3_PCI_REVISION_ID_LEN) {
-               PMD_INIT_LOG(ERR, "failed to read pci revision id: %d", ret);
+               PMD_INIT_LOG(ERR, "failed to read pci revision id, ret = %d",
+                            ret);
                return -EIO;
        }
        hw->revision = revision;
 
+       if (revision < PCI_REVISION_ID_HIP09_A) {
+               hns3_set_default_dev_specifications(hw);
+               hw->intr.mapping_mode = HNS3_INTR_MAPPING_VEC_RSV_ONE;
+               hw->intr.coalesce_mode = HNS3_INTR_COALESCE_NON_QL;
+               hw->intr.gl_unit = HNS3_INTR_COALESCE_GL_UINT_2US;
+               hw->tso_mode = HNS3_TSO_SW_CAL_PSEUDO_H_CSUM;
+               hw->vlan_mode = HNS3_SW_SHIFT_AND_DISCARD_MODE;
+               hw->min_tx_pkt_len = HNS3_HIP08_MIN_TX_PKT_LEN;
+               pf->tqp_config_mode = HNS3_FIXED_MAX_TQP_NUM_MODE;
+               return 0;
+       }
+
+       ret = hns3_query_dev_specifications(hw);
+       if (ret) {
+               PMD_INIT_LOG(ERR,
+                            "failed to query dev specifications, ret = %d",
+                            ret);
+               return ret;
+       }
+
+       hw->intr.mapping_mode = HNS3_INTR_MAPPING_VEC_ALL;
+       hw->intr.coalesce_mode = HNS3_INTR_COALESCE_QL;
+       hw->intr.gl_unit = HNS3_INTR_COALESCE_GL_UINT_1US;
+       hw->tso_mode = HNS3_TSO_HW_CAL_PSEUDO_H_CSUM;
+       hw->vlan_mode = HNS3_HW_SHIFT_AND_DISCARD_MODE;
+       hw->min_tx_pkt_len = HNS3_HIP09_MIN_TX_PKT_LEN;
+       pf->tqp_config_mode = HNS3_FLEX_MAX_TQP_NUM_MODE;
+
        return 0;
 }
 
@@ -2840,7 +3031,8 @@ hns3_get_board_configuration(struct hns3_hw *hw)
                return ret;
        }
 
-       if (cfg.media_type == HNS3_MEDIA_TYPE_COPPER) {
+       if (cfg.media_type == HNS3_MEDIA_TYPE_COPPER &&
+           !hns3_dev_copper_supported(hw)) {
                PMD_INIT_LOG(ERR, "media type is copper, not supported.");
                return -EOPNOTSUPP;
        }
@@ -2848,7 +3040,6 @@ hns3_get_board_configuration(struct hns3_hw *hw)
        hw->mac.media_type = cfg.media_type;
        hw->rss_size_max = cfg.rss_size_max;
        hw->rss_dis_flag = false;
-       hw->rx_buf_len = cfg.rx_buf_len;
        memcpy(hw->mac.mac_addr, cfg.mac_addr, RTE_ETHER_ADDR_LEN);
        hw->mac.phy_addr = cfg.phy_addr;
        hw->mac.default_addr_setted = false;
@@ -2917,7 +3108,7 @@ hns3_get_configuration(struct hns3_hw *hw)
 
        ret = hns3_get_board_configuration(hw);
        if (ret)
-               PMD_INIT_LOG(ERR, "Failed to get board configuration: %d", ret);
+               PMD_INIT_LOG(ERR, "failed to get board configuration: %d", ret);
 
        return ret;
 }
@@ -2950,29 +3141,18 @@ hns3_map_tqps_to_func(struct hns3_hw *hw, uint16_t func_id, uint16_t tqp_pid,
 static int
 hns3_map_tqp(struct hns3_hw *hw)
 {
-       uint16_t tqps_num = hw->total_tqps_num;
-       uint16_t func_id;
-       uint16_t tqp_id;
-       bool is_pf;
-       int num;
        int ret;
        int i;
 
        /*
-        * In current version VF is not supported when PF is driven by DPDK
-        * driver, so we allocate tqps to PF as much as possible.
+        * In current version, VF is not supported when PF is driven by DPDK
+        * driver, so we assign total tqps_num tqps allocated to this port
+        * to PF.
         */
-       tqp_id = 0;
-       num = DIV_ROUND_UP(hw->total_tqps_num, HNS3_MAX_TQP_NUM_PER_FUNC);
-       for (func_id = HNS3_PF_FUNC_ID; func_id < num; func_id++) {
-               is_pf = func_id == HNS3_PF_FUNC_ID ? true : false;
-               for (i = 0;
-                    i < HNS3_MAX_TQP_NUM_PER_FUNC && tqp_id < tqps_num; i++) {
-                       ret = hns3_map_tqps_to_func(hw, func_id, tqp_id++, i,
-                                                   is_pf);
-                       if (ret)
-                               return ret;
-               }
+       for (i = 0; i < hw->total_tqps_num; i++) {
+               ret = hns3_map_tqps_to_func(hw, HNS3_PF_FUNC_ID, i, i, true);
+               if (ret)
+                       return ret;
        }
 
        return 0;
@@ -3024,6 +3204,10 @@ hns3_cfg_mac_speed_dup_hw(struct hns3_hw *hw, uint32_t speed, uint8_t duplex)
                hns3_set_field(req->speed_dup, HNS3_CFG_SPEED_M,
                               HNS3_CFG_SPEED_S, HNS3_CFG_SPEED_100G);
                break;
+       case ETH_SPEED_NUM_200G:
+               hns3_set_field(req->speed_dup, HNS3_CFG_SPEED_M,
+                              HNS3_CFG_SPEED_S, HNS3_CFG_SPEED_200G);
+               break;
        default:
                PMD_INIT_LOG(ERR, "invalid speed (%u)", speed);
                return -EINVAL;
@@ -3194,7 +3378,7 @@ hns3_is_rx_buf_ok(struct hns3_hw *hw, struct hns3_pkt_buf_alloc *buf_alloc,
                                        + pf->dv_buf_size;
 
        shared_buf_tc = tc_num * aligned_mps + aligned_mps;
-       shared_std = roundup(max_t(uint32_t, shared_buf_min, shared_buf_tc),
+       shared_std = roundup(RTE_MAX(shared_buf_min, shared_buf_tc),
                             HNS3_BUF_SIZE_UNIT);
 
        rx_priv = hns3_get_rx_priv_buff_alloced(buf_alloc);
@@ -3224,8 +3408,7 @@ hns3_is_rx_buf_ok(struct hns3_hw *hw, struct hns3_pkt_buf_alloc *buf_alloc,
                if (tc_num)
                        hi_thrd = hi_thrd / tc_num;
 
-               hi_thrd = max_t(uint32_t, hi_thrd,
-                               HNS3_BUF_MUL_BY * aligned_mps);
+               hi_thrd = RTE_MAX(hi_thrd, HNS3_BUF_MUL_BY * aligned_mps);
                hi_thrd = rounddown(hi_thrd, HNS3_BUF_SIZE_UNIT);
                lo_thrd = hi_thrd - aligned_mps / HNS3_BUF_DIV_BY;
        } else {
@@ -4172,7 +4355,15 @@ hns3_cfg_mac_mode(struct hns3_hw *hw, bool enable)
        hns3_set_bit(loop_en, HNS3_MAC_LINE_LP_B, 0);
        hns3_set_bit(loop_en, HNS3_MAC_FCS_TX_B, val);
        hns3_set_bit(loop_en, HNS3_MAC_RX_FCS_B, val);
-       hns3_set_bit(loop_en, HNS3_MAC_RX_FCS_STRIP_B, val);
+
+       /*
+        * If DEV_RX_OFFLOAD_KEEP_CRC offload is set, MAC will not strip CRC
+        * when receiving frames. Otherwise, CRC will be stripped.
+        */
+       if (hw->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC)
+               hns3_set_bit(loop_en, HNS3_MAC_RX_FCS_STRIP_B, 0);
+       else
+               hns3_set_bit(loop_en, HNS3_MAC_RX_FCS_STRIP_B, val);
        hns3_set_bit(loop_en, HNS3_MAC_TX_OVERSIZE_TRUNCATE_B, val);
        hns3_set_bit(loop_en, HNS3_MAC_RX_OVERSIZE_TRUNCATE_B, val);
        hns3_set_bit(loop_en, HNS3_MAC_TX_UNDER_MIN_ERR_B, val);
@@ -4335,6 +4526,24 @@ hns3_clear_hw(struct hns3_hw *hw)
        return 0;
 }
 
+static void
+hns3_config_all_msix_error(struct hns3_hw *hw, bool enable)
+{
+       uint32_t val;
+
+       /*
+        * The new firmware support report more hardware error types by
+        * msix mode. These errors are defined as RAS errors in hardware
+        * and belong to a different type from the MSI-x errors processed
+        * by the network driver.
+        *
+        * Network driver should open the new error report on initialition
+        */
+       val = hns3_read_dev(hw, HNS3_VECTOR0_OTER_EN_REG);
+       hns3_set_bit(val, HNS3_VECTOR0_ALL_MSIX_ERR_B, enable ? 1 : 0);
+       hns3_write_dev(hw, HNS3_VECTOR0_OTER_EN_REG, val);
+}
+
 static int
 hns3_init_pf(struct rte_eth_dev *eth_dev)
 {
@@ -4377,6 +4586,8 @@ hns3_init_pf(struct rte_eth_dev *eth_dev)
                goto err_cmd_init;
        }
 
+       hns3_config_all_msix_error(hw, true);
+
        ret = rte_intr_callback_register(&pci_dev->intr_handle,
                                         hns3_interrupt_handler,
                                         eth_dev);
@@ -4396,17 +4607,21 @@ hns3_init_pf(struct rte_eth_dev *eth_dev)
                goto err_get_config;
        }
 
+       ret = hns3_tqp_stats_init(hw);
+       if (ret)
+               goto err_get_config;
+
        ret = hns3_init_hardware(hns);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to init hardware: %d", ret);
-               goto err_get_config;
+               goto err_init_hw;
        }
 
        /* Initialize flow director filter list & hash */
        ret = hns3_fdir_filter_init(hns);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to alloc hashmap for fdir: %d", ret);
-               goto err_hw_init;
+               goto err_fdir;
        }
 
        hns3_set_default_rss_args(hw);
@@ -4415,16 +4630,17 @@ hns3_init_pf(struct rte_eth_dev *eth_dev)
        if (ret) {
                PMD_INIT_LOG(ERR, "fail to enable hw error interrupts: %d",
                             ret);
-               goto err_fdir;
+               goto err_enable_intr;
        }
 
        return 0;
 
-err_fdir:
+err_enable_intr:
        hns3_fdir_filter_uninit(hns);
-err_hw_init:
+err_fdir:
        hns3_uninit_umv_space(hw);
-
+err_init_hw:
+       hns3_tqp_stats_uninit(hw);
 err_get_config:
        hns3_pf_disable_irq0(hw);
        rte_intr_disable(&pci_dev->intr_handle);
@@ -4456,10 +4672,12 @@ hns3_uninit_pf(struct rte_eth_dev *eth_dev)
        hns3_promisc_uninit(hw);
        hns3_fdir_filter_uninit(hns);
        hns3_uninit_umv_space(hw);
+       hns3_tqp_stats_uninit(hw);
        hns3_pf_disable_irq0(hw);
        rte_intr_disable(&pci_dev->intr_handle);
        hns3_intr_unregister(&pci_dev->intr_handle, hns3_interrupt_handler,
                             eth_dev);
+       hns3_config_all_msix_error(hw, false);
        hns3_cmd_uninit(hw);
        hns3_cmd_destroy_queue(hw);
        hw->io_base = NULL;
@@ -4475,23 +4693,22 @@ hns3_do_start(struct hns3_adapter *hns, bool reset_queue)
        if (ret)
                return ret;
 
-       /* Enable queues */
-       ret = hns3_start_queues(hns, reset_queue);
+       ret = hns3_init_queues(hns, reset_queue);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Failed to start queues: %d", ret);
+               PMD_INIT_LOG(ERR, "failed to init queues, ret = %d.", ret);
                return ret;
        }
 
-       /* Enable MAC */
        ret = hns3_cfg_mac_mode(hw, true);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Failed to enable MAC: %d", ret);
+               PMD_INIT_LOG(ERR, "failed to enable MAC, ret = %d", ret);
                goto err_config_mac_mode;
        }
        return 0;
 
 err_config_mac_mode:
-       hns3_stop_queues(hns, true);
+       hns3_dev_release_mbufs(hns);
+       hns3_reset_all_tqps(hns);
        return ret;
 }
 
@@ -4622,9 +4839,36 @@ hns3_dev_start(struct rte_eth_dev *dev)
                return ret;
        }
 
+       /*
+        * There are three register used to control the status of a TQP
+        * (contains a pair of Tx queue and Rx queue) in the new version network
+        * engine. One is used to control the enabling of Tx queue, the other is
+        * used to control the enabling of Rx queue, and the last is the master
+        * switch used to control the enabling of the tqp. The Tx register and
+        * TQP register must be enabled at the same time to enable a Tx queue.
+        * The same applies to the Rx queue. For the older network engine, this
+        * function only refresh the enabled flag, and it is used to update the
+        * status of queue in the dpdk framework.
+        */
+       ret = hns3_start_all_txqs(dev);
+       if (ret) {
+               hw->adapter_state = HNS3_NIC_CONFIGURED;
+               rte_spinlock_unlock(&hw->lock);
+               return ret;
+       }
+
+       ret = hns3_start_all_rxqs(dev);
+       if (ret) {
+               hns3_stop_all_txqs(dev);
+               hw->adapter_state = HNS3_NIC_CONFIGURED;
+               rte_spinlock_unlock(&hw->lock);
+               return ret;
+       }
+
        hw->adapter_state = HNS3_NIC_STARTED;
        rte_spinlock_unlock(&hw->lock);
 
+       hns3_rx_scattered_calc(dev);
        hns3_set_rxtx_function(dev);
        hns3_mp_req_start_rxtx(dev);
        rte_eal_alarm_set(HNS3_SERVICE_INTERVAL, hns3_service_handler, dev);
@@ -4633,11 +4877,12 @@ hns3_dev_start(struct rte_eth_dev *dev)
 
        /* Enable interrupt of all rx queues before enabling queues */
        hns3_dev_all_rx_queue_intr_enable(hw, true);
+
        /*
-        * When finished the initialization, enable queues to receive/transmit
-        * packets.
+        * After finished the initialization, enable tqps to receive/transmit
+        * packets and refresh all queue status.
         */
-       hns3_enable_all_queues(hw, true);
+       hns3_start_tqps(hw);
 
        hns3_info(hw, "hns3 dev start successful!");
        return 0;
@@ -4647,7 +4892,6 @@ static int
 hns3_do_stop(struct hns3_adapter *hns)
 {
        struct hns3_hw *hw = &hns->hw;
-       bool reset_queue;
        int ret;
 
        ret = hns3_cfg_mac_mode(hw, false);
@@ -4657,11 +4901,15 @@ hns3_do_stop(struct hns3_adapter *hns)
 
        if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) {
                hns3_configure_all_mac_addr(hns, true);
-               reset_queue = true;
-       } else
-               reset_queue = false;
+               ret = hns3_reset_all_tqps(hns);
+               if (ret) {
+                       hns3_err(hw, "failed to reset all queues ret = %d.",
+                                ret);
+                       return ret;
+               }
+       }
        hw->mac.default_addr_setted = false;
-       return hns3_stop_queues(hns, reset_queue);
+       return 0;
 }
 
 static void
@@ -4718,16 +4966,18 @@ hns3_dev_stop(struct rte_eth_dev *dev)
 
        rte_spinlock_lock(&hw->lock);
        if (rte_atomic16_read(&hw->reset.resetting) == 0) {
+               hns3_stop_tqps(hw);
                hns3_do_stop(hns);
                hns3_unmap_rx_interrupt(dev);
                hns3_dev_release_mbufs(hns);
                hw->adapter_state = HNS3_NIC_CONFIGURED;
        }
+       hns3_rx_scattered_reset(dev);
        rte_eal_alarm_cancel(hns3_service_handler, dev);
        rte_spinlock_unlock(&hw->lock);
 }
 
-static void
+static int
 hns3_dev_close(struct rte_eth_dev *eth_dev)
 {
        struct hns3_adapter *hns = eth_dev->data->dev_private;
@@ -4736,7 +4986,7 @@ hns3_dev_close(struct rte_eth_dev *eth_dev)
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
                rte_free(eth_dev->process_private);
                eth_dev->process_private = NULL;
-               return;
+               return 0;
        }
 
        if (hw->adapter_state == HNS3_NIC_STARTED)
@@ -4756,6 +5006,8 @@ hns3_dev_close(struct rte_eth_dev *eth_dev)
        eth_dev->process_private = NULL;
        hns3_mp_uninit_primary();
        hns3_warn(hw, "Close port %d finished", hw->data->port_id);
+
+       return 0;
 }
 
 static int
@@ -4954,7 +5206,7 @@ hns3_reinit_dev(struct hns3_adapter *hns)
                return ret;
        }
 
-       ret = hns3_reset_all_queues(hns);
+       ret = hns3_reset_all_tqps(hns);
        if (ret) {
                hns3_err(hw, "Failed to reset all queues: %d", ret);
                return ret;
@@ -5144,6 +5396,28 @@ hns3_get_reset_level(struct hns3_adapter *hns, uint64_t *levels)
        return reset_level;
 }
 
+static void
+hns3_record_imp_error(struct hns3_adapter *hns)
+{
+       struct hns3_hw *hw = &hns->hw;
+       uint32_t reg_val;
+
+       reg_val = hns3_read_dev(hw, HNS3_VECTOR0_OTER_EN_REG);
+       if (hns3_get_bit(reg_val, HNS3_VECTOR0_IMP_RD_POISON_B)) {
+               hns3_warn(hw, "Detected IMP RD poison!");
+               hns3_error_int_stats_add(hns, "IMP_RD_POISON_INT_STS");
+               hns3_set_bit(reg_val, HNS3_VECTOR0_IMP_RD_POISON_B, 0);
+               hns3_write_dev(hw, HNS3_VECTOR0_OTER_EN_REG, reg_val);
+       }
+
+       if (hns3_get_bit(reg_val, HNS3_VECTOR0_IMP_CMDQ_ERR_B)) {
+               hns3_warn(hw, "Detected IMP CMDQ error!");
+               hns3_error_int_stats_add(hns, "CMDQ_MEM_ECC_INT_STS");
+               hns3_set_bit(reg_val, HNS3_VECTOR0_IMP_CMDQ_ERR_B, 0);
+               hns3_write_dev(hw, HNS3_VECTOR0_OTER_EN_REG, reg_val);
+       }
+}
+
 static int
 hns3_prepare_reset(struct hns3_adapter *hns)
 {
@@ -5167,6 +5441,7 @@ hns3_prepare_reset(struct hns3_adapter *hns)
                hw->reset.stats.request_cnt++;
                break;
        case HNS3_IMP_RESET:
+               hns3_record_imp_error(hns);
                reg_val = hns3_read_dev(hw, HNS3_VECTOR0_OTER_EN_REG);
                hns3_write_dev(hw, HNS3_VECTOR0_OTER_EN_REG, reg_val |
                               BIT(HNS3_VECTOR0_IMP_RESET_INT_B));
@@ -5209,6 +5484,7 @@ hns3_stop_service(struct hns3_adapter *hns)
        rte_spinlock_lock(&hw->lock);
        if (hns->hw.adapter_state == HNS3_NIC_STARTED ||
            hw->adapter_state == HNS3_NIC_STOPPING) {
+               hns3_enable_all_queues(hw, false);
                hns3_do_stop(hns);
                hw->reset.mbuf_deferred_free = true;
        } else
@@ -5370,6 +5646,7 @@ hns3_reset_service(void *param)
 }
 
 static const struct eth_dev_ops hns3_eth_dev_ops = {
+       .dev_configure      = hns3_dev_configure,
        .dev_start          = hns3_dev_start,
        .dev_stop           = hns3_dev_stop,
        .dev_close          = hns3_dev_close,
@@ -5391,9 +5668,16 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {
        .tx_queue_setup         = hns3_tx_queue_setup,
        .rx_queue_release       = hns3_dev_rx_queue_release,
        .tx_queue_release       = hns3_dev_tx_queue_release,
+       .rx_queue_start         = hns3_dev_rx_queue_start,
+       .rx_queue_stop          = hns3_dev_rx_queue_stop,
+       .tx_queue_start         = hns3_dev_tx_queue_start,
+       .tx_queue_stop          = hns3_dev_tx_queue_stop,
        .rx_queue_intr_enable   = hns3_dev_rx_queue_intr_enable,
        .rx_queue_intr_disable  = hns3_dev_rx_queue_intr_disable,
-       .dev_configure          = hns3_dev_configure,
+       .rxq_info_get           = hns3_rxq_info_get,
+       .txq_info_get           = hns3_txq_info_get,
+       .rx_burst_mode_get      = hns3_rx_burst_mode_get,
+       .tx_burst_mode_get      = hns3_tx_burst_mode_get,
        .flow_ctrl_get          = hns3_flow_ctrl_get,
        .flow_ctrl_set          = hns3_flow_ctrl_set,
        .priority_flow_ctrl_set = hns3_priority_flow_ctrl_set,
@@ -5430,6 +5714,8 @@ static int
 hns3_dev_init(struct rte_eth_dev *eth_dev)
 {
        struct hns3_adapter *hns = eth_dev->data->dev_private;
+       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
+       struct rte_ether_addr *eth_addr;
        struct hns3_hw *hw = &hns->hw;
        int ret;
 
@@ -5449,12 +5735,25 @@ hns3_dev_init(struct rte_eth_dev *eth_dev)
        hns3_set_rxtx_function(eth_dev);
        eth_dev->dev_ops = &hns3_eth_dev_ops;
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
-               hns3_mp_init_secondary();
+               ret = hns3_mp_init_secondary();
+               if (ret) {
+                       PMD_INIT_LOG(ERR, "Failed to init for secondary "
+                                    "process, ret = %d", ret);
+                       goto err_mp_init_secondary;
+               }
+
                hw->secondary_cnt++;
                return 0;
        }
 
-       hns3_mp_init_primary();
+       ret = hns3_mp_init_primary();
+       if (ret) {
+               PMD_INIT_LOG(ERR,
+                            "Failed to init for primary process, ret = %d",
+                            ret);
+               goto err_mp_init_primary;
+       }
+
        hw->adapter_state = HNS3_NIC_UNINITIALIZED;
        hns->is_vf = false;
        hw->data = eth_dev->data;
@@ -5489,15 +5788,19 @@ hns3_dev_init(struct rte_eth_dev *eth_dev)
                goto err_rte_zmalloc;
        }
 
+       eth_addr = (struct rte_ether_addr *)hw->mac.mac_addr;
+       if (!rte_is_valid_assigned_ether_addr(eth_addr)) {
+               rte_eth_random_addr(hw->mac.mac_addr);
+               rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
+                               (struct rte_ether_addr *)hw->mac.mac_addr);
+               hns3_warn(hw, "default mac_addr from firmware is an invalid "
+                         "unicast address, using random MAC address %s",
+                         mac_str);
+       }
        rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.mac_addr,
                            &eth_dev->data->mac_addrs[0]);
 
        hw->adapter_state = HNS3_NIC_INITIALIZED;
-       /*
-        * Pass the information to the rte_eth_dev_close() that it should also
-        * release the private port resources.
-        */
-       eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
 
        if (rte_atomic16_read(&hns->hw.reset.schedule) == SCHEDULE_PENDING) {
                hns3_err(hw, "Reschedule reset service after dev_init");
@@ -5515,7 +5818,12 @@ err_rte_zmalloc:
 
 err_init_pf:
        rte_free(hw->reset.wait_data);
+
 err_init_reset:
+       hns3_mp_uninit_primary();
+
+err_mp_init_primary:
+err_mp_init_secondary:
        eth_dev->dev_ops = NULL;
        eth_dev->rx_pkt_burst = NULL;
        eth_dev->tx_pkt_burst = NULL;
@@ -5568,6 +5876,7 @@ static const struct rte_pci_id pci_id_hns3_map[] = {
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_25GE_RDMA) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_50GE_RDMA) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_RDMA_MACSEC) },
+       { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_RDMA) },
        { .vendor_id = 0, /* sentinel */ },
 };