ethdev: remove legacy FDIR filter type support
[dpdk.git] / drivers / net / i40e / i40e_fdir.c
index aa8e729..b61e605 100644 (file)
        (1ULL << RTE_ETH_FLOW_NONFRAG_IPV6_OTHER) | \
        (1ULL << RTE_ETH_FLOW_L2_PAYLOAD))
 
-static int i40e_fdir_filter_programming(struct i40e_pf *pf,
-                       enum i40e_filter_pctype pctype,
-                       const struct rte_eth_fdir_filter *filter,
-                       bool add);
 static int i40e_fdir_filter_convert(const struct i40e_fdir_filter_conf *input,
                         struct i40e_fdir_filter *filter);
 static struct i40e_fdir_filter *
@@ -731,263 +727,6 @@ i40e_fdir_configure(struct rte_eth_dev *dev)
        return ret;
 }
 
-static inline int
-i40e_fdir_fill_eth_ip_head(const struct rte_eth_fdir_input *fdir_input,
-                          unsigned char *raw_pkt,
-                          bool vlan)
-{
-       static uint8_t vlan_frame[] = {0x81, 0, 0, 0};
-       uint16_t *ether_type;
-       uint8_t len = 2 * sizeof(struct rte_ether_addr);
-       struct rte_ipv4_hdr *ip;
-       struct rte_ipv6_hdr *ip6;
-       static const uint8_t next_proto[] = {
-               [RTE_ETH_FLOW_FRAG_IPV4] = IPPROTO_IP,
-               [RTE_ETH_FLOW_NONFRAG_IPV4_TCP] = IPPROTO_TCP,
-               [RTE_ETH_FLOW_NONFRAG_IPV4_UDP] = IPPROTO_UDP,
-               [RTE_ETH_FLOW_NONFRAG_IPV4_SCTP] = IPPROTO_SCTP,
-               [RTE_ETH_FLOW_NONFRAG_IPV4_OTHER] = IPPROTO_IP,
-               [RTE_ETH_FLOW_FRAG_IPV6] = IPPROTO_NONE,
-               [RTE_ETH_FLOW_NONFRAG_IPV6_TCP] = IPPROTO_TCP,
-               [RTE_ETH_FLOW_NONFRAG_IPV6_UDP] = IPPROTO_UDP,
-               [RTE_ETH_FLOW_NONFRAG_IPV6_SCTP] = IPPROTO_SCTP,
-               [RTE_ETH_FLOW_NONFRAG_IPV6_OTHER] = IPPROTO_NONE,
-       };
-
-       raw_pkt += 2 * sizeof(struct rte_ether_addr);
-       if (vlan && fdir_input->flow_ext.vlan_tci) {
-               rte_memcpy(raw_pkt, vlan_frame, sizeof(vlan_frame));
-               rte_memcpy(raw_pkt + sizeof(uint16_t),
-                          &fdir_input->flow_ext.vlan_tci,
-                          sizeof(uint16_t));
-               raw_pkt += sizeof(vlan_frame);
-               len += sizeof(vlan_frame);
-       }
-       ether_type = (uint16_t *)raw_pkt;
-       raw_pkt += sizeof(uint16_t);
-       len += sizeof(uint16_t);
-
-       switch (fdir_input->flow_type) {
-       case RTE_ETH_FLOW_L2_PAYLOAD:
-               *ether_type = fdir_input->flow.l2_flow.ether_type;
-               break;
-       case RTE_ETH_FLOW_NONFRAG_IPV4_TCP:
-       case RTE_ETH_FLOW_NONFRAG_IPV4_UDP:
-       case RTE_ETH_FLOW_NONFRAG_IPV4_SCTP:
-       case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER:
-       case RTE_ETH_FLOW_FRAG_IPV4:
-               ip = (struct rte_ipv4_hdr *)raw_pkt;
-
-               *ether_type = rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4);
-               ip->version_ihl = I40E_FDIR_IP_DEFAULT_VERSION_IHL;
-               /* set len to by default */
-               ip->total_length = rte_cpu_to_be_16(I40E_FDIR_IP_DEFAULT_LEN);
-               ip->next_proto_id = fdir_input->flow.ip4_flow.proto ?
-                                       fdir_input->flow.ip4_flow.proto :
-                                       next_proto[fdir_input->flow_type];
-               ip->time_to_live = fdir_input->flow.ip4_flow.ttl ?
-                                       fdir_input->flow.ip4_flow.ttl :
-                                       I40E_FDIR_IP_DEFAULT_TTL;
-               ip->type_of_service = fdir_input->flow.ip4_flow.tos;
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               ip->src_addr = fdir_input->flow.ip4_flow.dst_ip;
-               ip->dst_addr = fdir_input->flow.ip4_flow.src_ip;
-               len += sizeof(struct rte_ipv4_hdr);
-               break;
-       case RTE_ETH_FLOW_NONFRAG_IPV6_TCP:
-       case RTE_ETH_FLOW_NONFRAG_IPV6_UDP:
-       case RTE_ETH_FLOW_NONFRAG_IPV6_SCTP:
-       case RTE_ETH_FLOW_NONFRAG_IPV6_OTHER:
-       case RTE_ETH_FLOW_FRAG_IPV6:
-               ip6 = (struct rte_ipv6_hdr *)raw_pkt;
-
-               *ether_type = rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV6);
-               ip6->vtc_flow =
-                       rte_cpu_to_be_32(I40E_FDIR_IPv6_DEFAULT_VTC_FLOW |
-                                        (fdir_input->flow.ipv6_flow.tc <<
-                                         I40E_FDIR_IPv6_TC_OFFSET));
-               ip6->payload_len =
-                       rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN);
-               ip6->proto = fdir_input->flow.ipv6_flow.proto ?
-                                       fdir_input->flow.ipv6_flow.proto :
-                                       next_proto[fdir_input->flow_type];
-               ip6->hop_limits = fdir_input->flow.ipv6_flow.hop_limits ?
-                                       fdir_input->flow.ipv6_flow.hop_limits :
-                                       I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS;
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               rte_memcpy(&(ip6->src_addr),
-                          &(fdir_input->flow.ipv6_flow.dst_ip),
-                          IPV6_ADDR_LEN);
-               rte_memcpy(&(ip6->dst_addr),
-                          &(fdir_input->flow.ipv6_flow.src_ip),
-                          IPV6_ADDR_LEN);
-               len += sizeof(struct rte_ipv6_hdr);
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "unknown flow type %u.",
-                           fdir_input->flow_type);
-               return -1;
-       }
-       return len;
-}
-
-
-/*
- * i40e_fdir_construct_pkt - construct packet based on fields in input
- * @pf: board private structure
- * @fdir_input: input set of the flow director entry
- * @raw_pkt: a packet to be constructed
- */
-static int
-i40e_fdir_construct_pkt(struct i40e_pf *pf,
-                            const struct rte_eth_fdir_input *fdir_input,
-                            unsigned char *raw_pkt)
-{
-       unsigned char *payload, *ptr;
-       struct rte_udp_hdr *udp;
-       struct rte_tcp_hdr *tcp;
-       struct rte_sctp_hdr *sctp;
-       uint8_t size, dst = 0;
-       uint8_t i, pit_idx, set_idx = I40E_FLXPLD_L4_IDX; /* use l4 by default*/
-       int len;
-
-       /* fill the ethernet and IP head */
-       len = i40e_fdir_fill_eth_ip_head(fdir_input, raw_pkt,
-                                        !!fdir_input->flow_ext.vlan_tci);
-       if (len < 0)
-               return -EINVAL;
-
-       /* fill the L4 head */
-       switch (fdir_input->flow_type) {
-       case RTE_ETH_FLOW_NONFRAG_IPV4_UDP:
-               udp = (struct rte_udp_hdr *)(raw_pkt + len);
-               payload = (unsigned char *)udp + sizeof(struct rte_udp_hdr);
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               udp->src_port = fdir_input->flow.udp4_flow.dst_port;
-               udp->dst_port = fdir_input->flow.udp4_flow.src_port;
-               udp->dgram_len = rte_cpu_to_be_16(I40E_FDIR_UDP_DEFAULT_LEN);
-               break;
-
-       case RTE_ETH_FLOW_NONFRAG_IPV4_TCP:
-               tcp = (struct rte_tcp_hdr *)(raw_pkt + len);
-               payload = (unsigned char *)tcp + sizeof(struct rte_tcp_hdr);
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               tcp->src_port = fdir_input->flow.tcp4_flow.dst_port;
-               tcp->dst_port = fdir_input->flow.tcp4_flow.src_port;
-               tcp->data_off = I40E_FDIR_TCP_DEFAULT_DATAOFF;
-               break;
-
-       case RTE_ETH_FLOW_NONFRAG_IPV4_SCTP:
-               sctp = (struct rte_sctp_hdr *)(raw_pkt + len);
-               payload = (unsigned char *)sctp + sizeof(struct rte_sctp_hdr);
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               sctp->src_port = fdir_input->flow.sctp4_flow.dst_port;
-               sctp->dst_port = fdir_input->flow.sctp4_flow.src_port;
-               sctp->tag = fdir_input->flow.sctp4_flow.verify_tag;
-               break;
-
-       case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER:
-       case RTE_ETH_FLOW_FRAG_IPV4:
-               payload = raw_pkt + len;
-               set_idx = I40E_FLXPLD_L3_IDX;
-               break;
-
-       case RTE_ETH_FLOW_NONFRAG_IPV6_UDP:
-               udp = (struct rte_udp_hdr *)(raw_pkt + len);
-               payload = (unsigned char *)udp + sizeof(struct rte_udp_hdr);
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               udp->src_port = fdir_input->flow.udp6_flow.dst_port;
-               udp->dst_port = fdir_input->flow.udp6_flow.src_port;
-               udp->dgram_len = rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN);
-               break;
-
-       case RTE_ETH_FLOW_NONFRAG_IPV6_TCP:
-               tcp = (struct rte_tcp_hdr *)(raw_pkt + len);
-               payload = (unsigned char *)tcp + sizeof(struct rte_tcp_hdr);
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               tcp->data_off = I40E_FDIR_TCP_DEFAULT_DATAOFF;
-               tcp->src_port = fdir_input->flow.udp6_flow.dst_port;
-               tcp->dst_port = fdir_input->flow.udp6_flow.src_port;
-               break;
-
-       case RTE_ETH_FLOW_NONFRAG_IPV6_SCTP:
-               sctp = (struct rte_sctp_hdr *)(raw_pkt + len);
-               payload = (unsigned char *)sctp + sizeof(struct rte_sctp_hdr);
-               /*
-                * The source and destination fields in the transmitted packet
-                * need to be presented in a reversed order with respect
-                * to the expected received packets.
-                */
-               sctp->src_port = fdir_input->flow.sctp6_flow.dst_port;
-               sctp->dst_port = fdir_input->flow.sctp6_flow.src_port;
-               sctp->tag = fdir_input->flow.sctp6_flow.verify_tag;
-               break;
-
-       case RTE_ETH_FLOW_NONFRAG_IPV6_OTHER:
-       case RTE_ETH_FLOW_FRAG_IPV6:
-               payload = raw_pkt + len;
-               set_idx = I40E_FLXPLD_L3_IDX;
-               break;
-       case RTE_ETH_FLOW_L2_PAYLOAD:
-               payload = raw_pkt + len;
-               /*
-                * ARP packet is a special case on which the payload
-                * starts after the whole ARP header
-                */
-               if (fdir_input->flow.l2_flow.ether_type ==
-                               rte_cpu_to_be_16(RTE_ETHER_TYPE_ARP))
-                       payload += sizeof(struct rte_arp_hdr);
-               set_idx = I40E_FLXPLD_L2_IDX;
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "unknown flow type %u.", fdir_input->flow_type);
-               return -EINVAL;
-       }
-
-       /* fill the flexbytes to payload */
-       for (i = 0; i < I40E_MAX_FLXPLD_FIED; i++) {
-               pit_idx = set_idx * I40E_MAX_FLXPLD_FIED + i;
-               size = pf->fdir.flex_set[pit_idx].size;
-               if (size == 0)
-                       continue;
-               dst = pf->fdir.flex_set[pit_idx].dst_offset * sizeof(uint16_t);
-               ptr = payload +
-                       pf->fdir.flex_set[pit_idx].src_offset * sizeof(uint16_t);
-               rte_memcpy(ptr,
-                                &fdir_input->flow_ext.flexbytes[dst],
-                                size * sizeof(uint16_t));
-       }
-
-       return 0;
-}
 
 static struct i40e_customized_pctype *
 i40e_flow_fdir_find_customized_pctype(struct i40e_pf *pf, uint8_t pctype)
@@ -1703,68 +1442,6 @@ i40e_fdir_entry_pool_put(struct i40e_fdir_info *fdir_info,
        rte_bitmap_set(fdir_info->fdir_flow_pool.bitmap, f->idx);
 }
 
-/*
- * i40e_add_del_fdir_filter - add or remove a flow director filter.
- * @pf: board private structure
- * @filter: fdir filter entry
- * @add: 0 - delete, 1 - add
- */
-int
-i40e_add_del_fdir_filter(struct rte_eth_dev *dev,
-                        const struct rte_eth_fdir_filter *filter,
-                        bool add)
-{
-       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       unsigned char *pkt = (unsigned char *)pf->fdir.prg_pkt[0];
-       enum i40e_filter_pctype pctype;
-       int ret = 0;
-
-       if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_PERFECT) {
-               PMD_DRV_LOG(ERR, "FDIR is not enabled, please"
-                       " check the mode in fdir_conf.");
-               return -ENOTSUP;
-       }
-
-       pctype = i40e_flowtype_to_pctype(pf->adapter, filter->input.flow_type);
-       if (pctype == I40E_FILTER_PCTYPE_INVALID) {
-               PMD_DRV_LOG(ERR, "invalid flow_type input.");
-               return -EINVAL;
-       }
-       if (filter->action.rx_queue >= pf->dev_data->nb_rx_queues) {
-               PMD_DRV_LOG(ERR, "Invalid queue ID");
-               return -EINVAL;
-       }
-       if (filter->input.flow_ext.is_vf &&
-               filter->input.flow_ext.dst_id >= pf->vf_num) {
-               PMD_DRV_LOG(ERR, "Invalid VF ID");
-               return -EINVAL;
-       }
-
-       memset(pkt, 0, I40E_FDIR_PKT_LEN);
-
-       ret = i40e_fdir_construct_pkt(pf, &filter->input, pkt);
-       if (ret < 0) {
-               PMD_DRV_LOG(ERR, "construct packet for fdir fails.");
-               return ret;
-       }
-
-       if (hw->mac.type == I40E_MAC_X722) {
-               /* get translated pctype value in fd pctype register */
-               pctype = (enum i40e_filter_pctype)i40e_read_rx_ctl(
-                       hw, I40E_GLQF_FD_PCTYPES((int)pctype));
-       }
-
-       ret = i40e_fdir_filter_programming(pf, pctype, filter, add);
-       if (ret < 0) {
-               PMD_DRV_LOG(ERR, "fdir programming fails for PCTYPE(%u).",
-                           pctype);
-               return ret;
-       }
-
-       return ret;
-}
-
 static inline unsigned char *
 i40e_find_available_buffer(struct rte_eth_dev *dev)
 {
@@ -1939,141 +1616,6 @@ error_op:
        return ret;
 }
 
-/*
- * i40e_fdir_filter_programming - Program a flow director filter rule.
- * Is done by Flow Director Programming Descriptor followed by packet
- * structure that contains the filter fields need to match.
- * @pf: board private structure
- * @pctype: pctype
- * @filter: fdir filter entry
- * @add: 0 - delete, 1 - add
- */
-static int
-i40e_fdir_filter_programming(struct i40e_pf *pf,
-                       enum i40e_filter_pctype pctype,
-                       const struct rte_eth_fdir_filter *filter,
-                       bool add)
-{
-       struct i40e_tx_queue *txq = pf->fdir.txq;
-       struct i40e_rx_queue *rxq = pf->fdir.rxq;
-       const struct rte_eth_fdir_action *fdir_action = &filter->action;
-       volatile struct i40e_tx_desc *txdp;
-       volatile struct i40e_filter_program_desc *fdirdp;
-       uint32_t td_cmd;
-       uint16_t vsi_id, i;
-       uint8_t dest;
-
-       PMD_DRV_LOG(INFO, "filling filter programming descriptor.");
-       fdirdp = (volatile struct i40e_filter_program_desc *)
-                       (&(txq->tx_ring[txq->tx_tail]));
-
-       fdirdp->qindex_flex_ptype_vsi =
-                       rte_cpu_to_le_32((fdir_action->rx_queue <<
-                                         I40E_TXD_FLTR_QW0_QINDEX_SHIFT) &
-                                         I40E_TXD_FLTR_QW0_QINDEX_MASK);
-
-       fdirdp->qindex_flex_ptype_vsi |=
-                       rte_cpu_to_le_32((fdir_action->flex_off <<
-                                         I40E_TXD_FLTR_QW0_FLEXOFF_SHIFT) &
-                                         I40E_TXD_FLTR_QW0_FLEXOFF_MASK);
-
-       fdirdp->qindex_flex_ptype_vsi |=
-                       rte_cpu_to_le_32((pctype <<
-                                         I40E_TXD_FLTR_QW0_PCTYPE_SHIFT) &
-                                         I40E_TXD_FLTR_QW0_PCTYPE_MASK);
-
-       if (filter->input.flow_ext.is_vf)
-               vsi_id = pf->vfs[filter->input.flow_ext.dst_id].vsi->vsi_id;
-       else
-               /* Use LAN VSI Id by default */
-               vsi_id = pf->main_vsi->vsi_id;
-       fdirdp->qindex_flex_ptype_vsi |=
-               rte_cpu_to_le_32(((uint32_t)vsi_id <<
-                                 I40E_TXD_FLTR_QW0_DEST_VSI_SHIFT) &
-                                 I40E_TXD_FLTR_QW0_DEST_VSI_MASK);
-
-       fdirdp->dtype_cmd_cntindex =
-                       rte_cpu_to_le_32(I40E_TX_DESC_DTYPE_FILTER_PROG);
-
-       if (add)
-               fdirdp->dtype_cmd_cntindex |= rte_cpu_to_le_32(
-                               I40E_FILTER_PROGRAM_DESC_PCMD_ADD_UPDATE <<
-                               I40E_TXD_FLTR_QW1_PCMD_SHIFT);
-       else
-               fdirdp->dtype_cmd_cntindex |= rte_cpu_to_le_32(
-                               I40E_FILTER_PROGRAM_DESC_PCMD_REMOVE <<
-                               I40E_TXD_FLTR_QW1_PCMD_SHIFT);
-
-       if (fdir_action->behavior == RTE_ETH_FDIR_REJECT)
-               dest = I40E_FILTER_PROGRAM_DESC_DEST_DROP_PACKET;
-       else if (fdir_action->behavior == RTE_ETH_FDIR_ACCEPT)
-               dest = I40E_FILTER_PROGRAM_DESC_DEST_DIRECT_PACKET_QINDEX;
-       else if (fdir_action->behavior == RTE_ETH_FDIR_PASSTHRU)
-               dest = I40E_FILTER_PROGRAM_DESC_DEST_DIRECT_PACKET_OTHER;
-       else {
-               PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"
-                           " unsupported fdir behavior.");
-               return -EINVAL;
-       }
-
-       fdirdp->dtype_cmd_cntindex |= rte_cpu_to_le_32((dest <<
-                               I40E_TXD_FLTR_QW1_DEST_SHIFT) &
-                               I40E_TXD_FLTR_QW1_DEST_MASK);
-
-       fdirdp->dtype_cmd_cntindex |=
-               rte_cpu_to_le_32((fdir_action->report_status<<
-                               I40E_TXD_FLTR_QW1_FD_STATUS_SHIFT) &
-                               I40E_TXD_FLTR_QW1_FD_STATUS_MASK);
-
-       fdirdp->dtype_cmd_cntindex |=
-                       rte_cpu_to_le_32(I40E_TXD_FLTR_QW1_CNT_ENA_MASK);
-       fdirdp->dtype_cmd_cntindex |=
-                       rte_cpu_to_le_32(
-                       ((uint32_t)pf->fdir.match_counter_index <<
-                       I40E_TXD_FLTR_QW1_CNTINDEX_SHIFT) &
-                       I40E_TXD_FLTR_QW1_CNTINDEX_MASK);
-
-       fdirdp->fd_id = rte_cpu_to_le_32(filter->soft_id);
-
-       PMD_DRV_LOG(INFO, "filling transmit descriptor.");
-       txdp = &(txq->tx_ring[txq->tx_tail + 1]);
-       txdp->buffer_addr = rte_cpu_to_le_64(pf->fdir.dma_addr[0]);
-       td_cmd = I40E_TX_DESC_CMD_EOP |
-                I40E_TX_DESC_CMD_RS  |
-                I40E_TX_DESC_CMD_DUMMY;
-
-       txdp->cmd_type_offset_bsz =
-               i40e_build_ctob(td_cmd, 0, I40E_FDIR_PKT_LEN, 0);
-
-       txq->tx_tail += 2; /* set 2 descriptors above, fdirdp and txdp */
-       if (txq->tx_tail >= txq->nb_tx_desc)
-               txq->tx_tail = 0;
-       /* Update the tx tail register */
-       rte_wmb();
-       I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail);
-       for (i = 0; i < I40E_FDIR_MAX_WAIT_US; i++) {
-               if ((txdp->cmd_type_offset_bsz &
-                               rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) ==
-                               rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE))
-                       break;
-               rte_delay_us(1);
-       }
-       if (i >= I40E_FDIR_MAX_WAIT_US) {
-               PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"
-                           " time out to get DD on tx queue.");
-               return -ETIMEDOUT;
-       }
-       /* totally delay 10 ms to check programming status*/
-       for (; i < I40E_FDIR_MAX_WAIT_US; i++) {
-               if (i40e_check_fdir_programming_status(rxq) >= 0)
-                       return 0;
-               rte_delay_us(1);
-       }
-       PMD_DRV_LOG(ERR,
-               "Failed to program FDIR filter: programming status reported.");
-       return -ETIMEDOUT;
-}
-
 /*
  * i40e_flow_fdir_filter_programming - Program a flow director filter rule.
  * Is done by Flow Director Programming Descriptor followed by packet
@@ -2401,87 +1943,6 @@ i40e_fdir_stats_get(struct rte_eth_dev *dev, struct rte_eth_fdir_stats *stat)
                            I40E_PFQF_FDSTAT_BEST_CNT_SHIFT);
 }
 
-static int
-i40e_fdir_filter_set(struct rte_eth_dev *dev,
-                    struct rte_eth_fdir_filter_info *info)
-{
-       struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       int ret = 0;
-
-       if (!info) {
-               PMD_DRV_LOG(ERR, "Invalid pointer");
-               return -EFAULT;
-       }
-
-       switch (info->info_type) {
-       case RTE_ETH_FDIR_FILTER_INPUT_SET_SELECT:
-               ret = i40e_fdir_filter_inset_select(pf,
-                               &(info->info.input_set_conf));
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "FD filter info type (%d) not supported",
-                           info->info_type);
-               return -EINVAL;
-       }
-
-       return ret;
-}
-
-/*
- * i40e_fdir_ctrl_func - deal with all operations on flow director.
- * @pf: board private structure
- * @filter_op:operation will be taken.
- * @arg: a pointer to specific structure corresponding to the filter_op
- */
-int
-i40e_fdir_ctrl_func(struct rte_eth_dev *dev,
-                      enum rte_filter_op filter_op,
-                      void *arg)
-{
-       struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       int ret = 0;
-
-       if ((pf->flags & I40E_FLAG_FDIR) == 0)
-               return -ENOTSUP;
-
-       if (filter_op == RTE_ETH_FILTER_NOP)
-               return 0;
-
-       if (arg == NULL && filter_op != RTE_ETH_FILTER_FLUSH)
-               return -EINVAL;
-
-       switch (filter_op) {
-       case RTE_ETH_FILTER_ADD:
-               ret = i40e_add_del_fdir_filter(dev,
-                       (struct rte_eth_fdir_filter *)arg,
-                       TRUE);
-               break;
-       case RTE_ETH_FILTER_DELETE:
-               ret = i40e_add_del_fdir_filter(dev,
-                       (struct rte_eth_fdir_filter *)arg,
-                       FALSE);
-               break;
-       case RTE_ETH_FILTER_FLUSH:
-               ret = i40e_fdir_flush(dev);
-               break;
-       case RTE_ETH_FILTER_INFO:
-               i40e_fdir_info_get(dev, (struct rte_eth_fdir_info *)arg);
-               break;
-       case RTE_ETH_FILTER_SET:
-               ret = i40e_fdir_filter_set(dev,
-                       (struct rte_eth_fdir_filter_info *)arg);
-               break;
-       case RTE_ETH_FILTER_STATS:
-               i40e_fdir_stats_get(dev, (struct rte_eth_fdir_stats *)arg);
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "unknown operation %u.", filter_op);
-               ret = -EINVAL;
-               break;
-       }
-       return ret;
-}
-
 /* Restore flow director filter */
 void
 i40e_fdir_filter_restore(struct i40e_pf *pf)