net/i40e: fix flow director config after flow validate
[dpdk.git] / drivers / net / i40e / i40e_flow.c
index 4e92097..2cc9ad9 100644 (file)
 #include <unistd.h>
 #include <stdarg.h>
 
+#include <rte_debug.h>
 #include <rte_ether.h>
-#include <rte_ethdev.h>
+#include <ethdev_driver.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
-#include <rte_eth_ctrl.h>
 #include <rte_tailq.h>
 #include <rte_flow_driver.h>
+#include <rte_bitmap.h>
 
 #include "i40e_logs.h"
 #include "base/i40e_type.h"
 #include "base/i40e_prototype.h"
 #include "i40e_ethdev.h"
+#include "i40e_hash.h"
 
 #define I40E_IPV6_TC_MASK      (0xFF << I40E_FDIR_IPv6_TC_OFFSET)
 #define I40E_IPV6_FRAG_HEADER  44
 #define I40E_TENANT_ARRAY_NUM  3
-#define I40E_TCI_MASK          0xFFFF
+#define I40E_VLAN_TCI_MASK     0xFFFF
+#define I40E_VLAN_PRI_MASK     0xE000
+#define I40E_VLAN_CFI_MASK     0x1000
+#define I40E_VLAN_VID_MASK     0x0FFF
 
 static int i40e_flow_validate(struct rte_eth_dev *dev,
                              const struct rte_flow_attr *attr,
@@ -43,6 +48,10 @@ static int i40e_flow_destroy(struct rte_eth_dev *dev,
                             struct rte_flow_error *error);
 static int i40e_flow_flush(struct rte_eth_dev *dev,
                           struct rte_flow_error *error);
+static int i40e_flow_query(struct rte_eth_dev *dev,
+                          struct rte_flow *flow,
+                          const struct rte_flow_action *actions,
+                          void *data, struct rte_flow_error *error);
 static int
 i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
                                  const struct rte_flow_item *pattern,
@@ -53,6 +62,7 @@ static int i40e_flow_parse_ethertype_action(struct rte_eth_dev *dev,
                                    struct rte_flow_error *error,
                                    struct rte_eth_ethertype_filter *filter);
 static int i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
+                                       const struct rte_flow_attr *attr,
                                        const struct rte_flow_item *pattern,
                                        struct rte_flow_error *error,
                                        struct i40e_fdir_filter_conf *filter);
@@ -122,15 +132,24 @@ i40e_flow_parse_qinq_pattern(struct rte_eth_dev *dev,
                              struct rte_flow_error *error,
                              struct i40e_tunnel_filter_conf *filter);
 
+static int i40e_flow_parse_l4_cloud_filter(struct rte_eth_dev *dev,
+                                          const struct rte_flow_attr *attr,
+                                          const struct rte_flow_item pattern[],
+                                          const struct rte_flow_action actions[],
+                                          struct rte_flow_error *error,
+                                          union i40e_filter_t *filter);
 const struct rte_flow_ops i40e_flow_ops = {
        .validate = i40e_flow_validate,
        .create = i40e_flow_create,
        .destroy = i40e_flow_destroy,
        .flush = i40e_flow_flush,
+       .query = i40e_flow_query,
 };
 
-union i40e_filter_t cons_filter;
-enum rte_filter_type cons_filter_type = RTE_ETH_FILTER_NONE;
+static union i40e_filter_t cons_filter;
+static enum rte_filter_type cons_filter_type = RTE_ETH_FILTER_NONE;
+/* internal pattern w/o VOID items */
+struct rte_flow_item g_items[32];
 
 /* Pattern matched ethertype filter */
 static enum rte_flow_item_type pattern_ethertype[] = {
@@ -1612,6 +1631,50 @@ static enum rte_flow_item_type pattern_qinq_1[] = {
        RTE_FLOW_ITEM_TYPE_END,
 };
 
+static enum rte_flow_item_type pattern_fdir_ipv4_l2tpv3oip[] = {
+       RTE_FLOW_ITEM_TYPE_ETH,
+       RTE_FLOW_ITEM_TYPE_IPV4,
+       RTE_FLOW_ITEM_TYPE_L2TPV3OIP,
+       RTE_FLOW_ITEM_TYPE_END,
+};
+
+static enum rte_flow_item_type pattern_fdir_ipv6_l2tpv3oip[] = {
+       RTE_FLOW_ITEM_TYPE_ETH,
+       RTE_FLOW_ITEM_TYPE_IPV6,
+       RTE_FLOW_ITEM_TYPE_L2TPV3OIP,
+       RTE_FLOW_ITEM_TYPE_END,
+};
+
+static enum rte_flow_item_type pattern_fdir_ipv4_esp[] = {
+       RTE_FLOW_ITEM_TYPE_ETH,
+       RTE_FLOW_ITEM_TYPE_IPV4,
+       RTE_FLOW_ITEM_TYPE_ESP,
+       RTE_FLOW_ITEM_TYPE_END,
+};
+
+static enum rte_flow_item_type pattern_fdir_ipv6_esp[] = {
+       RTE_FLOW_ITEM_TYPE_ETH,
+       RTE_FLOW_ITEM_TYPE_IPV6,
+       RTE_FLOW_ITEM_TYPE_ESP,
+       RTE_FLOW_ITEM_TYPE_END,
+};
+
+static enum rte_flow_item_type pattern_fdir_ipv4_udp_esp[] = {
+       RTE_FLOW_ITEM_TYPE_ETH,
+       RTE_FLOW_ITEM_TYPE_IPV4,
+       RTE_FLOW_ITEM_TYPE_UDP,
+       RTE_FLOW_ITEM_TYPE_ESP,
+       RTE_FLOW_ITEM_TYPE_END,
+};
+
+static enum rte_flow_item_type pattern_fdir_ipv6_udp_esp[] = {
+       RTE_FLOW_ITEM_TYPE_ETH,
+       RTE_FLOW_ITEM_TYPE_IPV6,
+       RTE_FLOW_ITEM_TYPE_UDP,
+       RTE_FLOW_ITEM_TYPE_ESP,
+       RTE_FLOW_ITEM_TYPE_END,
+};
+
 static struct i40e_valid_pattern i40e_supported_patterns[] = {
        /* Ethertype */
        { pattern_ethertype, i40e_flow_parse_ethertype_filter },
@@ -1625,6 +1688,8 @@ static struct i40e_valid_pattern i40e_supported_patterns[] = {
        { pattern_fdir_ipv4_gtpu, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ipv4_gtpu_ipv4, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ipv4_gtpu_ipv6, i40e_flow_parse_fdir_filter },
+       { pattern_fdir_ipv4_esp, i40e_flow_parse_fdir_filter },
+       { pattern_fdir_ipv4_udp_esp, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ipv6, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ipv6_udp, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ipv6_tcp, i40e_flow_parse_fdir_filter },
@@ -1633,6 +1698,8 @@ static struct i40e_valid_pattern i40e_supported_patterns[] = {
        { pattern_fdir_ipv6_gtpu, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ipv6_gtpu_ipv4, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ipv6_gtpu_ipv6, i40e_flow_parse_fdir_filter },
+       { pattern_fdir_ipv6_esp, i40e_flow_parse_fdir_filter },
+       { pattern_fdir_ipv6_udp_esp, i40e_flow_parse_fdir_filter },
        /* FDIR - support default flow type with flexible payload */
        { pattern_fdir_ethertype_raw_1, i40e_flow_parse_fdir_filter },
        { pattern_fdir_ethertype_raw_2, i40e_flow_parse_fdir_filter },
@@ -1792,6 +1859,16 @@ static struct i40e_valid_pattern i40e_supported_patterns[] = {
        { pattern_fdir_ipv6_gtpu, i40e_flow_parse_gtp_filter },
        /* QINQ */
        { pattern_qinq_1, i40e_flow_parse_qinq_filter },
+       /* L2TPv3 over IP */
+       { pattern_fdir_ipv4_l2tpv3oip, i40e_flow_parse_fdir_filter },
+       { pattern_fdir_ipv6_l2tpv3oip, i40e_flow_parse_fdir_filter },
+       /* L4 over port */
+       { pattern_fdir_ipv4_udp, i40e_flow_parse_l4_cloud_filter },
+       { pattern_fdir_ipv4_tcp, i40e_flow_parse_l4_cloud_filter },
+       { pattern_fdir_ipv4_sctp, i40e_flow_parse_l4_cloud_filter },
+       { pattern_fdir_ipv6_udp, i40e_flow_parse_l4_cloud_filter },
+       { pattern_fdir_ipv6_tcp, i40e_flow_parse_l4_cloud_filter },
+       { pattern_fdir_ipv6_sctp, i40e_flow_parse_l4_cloud_filter },
 };
 
 #define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
@@ -1937,7 +2014,8 @@ static uint16_t
 i40e_get_outer_vlan(struct rte_eth_dev *dev)
 {
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       int qinq = dev->data->dev_conf.rxmode.hw_vlan_extend;
+       int qinq = dev->data->dev_conf.rxmode.offloads &
+               DEV_RX_OFFLOAD_VLAN_EXTEND;
        uint64_t reg_r = 0;
        uint16_t reg_id;
        uint16_t tpid;
@@ -1972,9 +2050,6 @@ i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
        const struct rte_flow_item_eth *eth_spec;
        const struct rte_flow_item_eth *eth_mask;
        enum rte_flow_item_type item_type;
-       uint16_t outer_tpid;
-
-       outer_tpid = i40e_get_outer_vlan(dev);
 
        for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++) {
                if (item->last) {
@@ -1987,8 +2062,8 @@ i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
                item_type = item->type;
                switch (item_type) {
                case RTE_FLOW_ITEM_TYPE_ETH:
-                       eth_spec = (const struct rte_flow_item_eth *)item->spec;
-                       eth_mask = (const struct rte_flow_item_eth *)item->mask;
+                       eth_spec = item->spec;
+                       eth_mask = item->mask;
                        /* Get the MAC info. */
                        if (!eth_spec || !eth_mask) {
                                rte_flow_error_set(error, EINVAL,
@@ -2002,9 +2077,9 @@ i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
                         * Mask bits of destination MAC address must be full
                         * of 1 or full of 0.
                         */
-                       if (!is_zero_ether_addr(&eth_mask->src) ||
-                           (!is_zero_ether_addr(&eth_mask->dst) &&
-                            !is_broadcast_ether_addr(&eth_mask->dst))) {
+                       if (!rte_is_zero_ether_addr(&eth_mask->src) ||
+                           (!rte_is_zero_ether_addr(&eth_mask->dst) &&
+                            !rte_is_broadcast_ether_addr(&eth_mask->dst))) {
                                rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
                                                   item,
@@ -2023,7 +2098,7 @@ i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
                        /* If mask bits of destination MAC address
                         * are full of 1, set RTE_ETHTYPE_FLAGS_MAC.
                         */
-                       if (is_broadcast_ether_addr(&eth_mask->dst)) {
+                       if (rte_is_broadcast_ether_addr(&eth_mask->dst)) {
                                filter->mac_addr = eth_spec->dst;
                                filter->flags |= RTE_ETHTYPE_FLAGS_MAC;
                        } else {
@@ -2031,10 +2106,10 @@ i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
                        }
                        filter->ether_type = rte_be_to_cpu_16(eth_spec->type);
 
-                       if (filter->ether_type == ETHER_TYPE_IPv4 ||
-                           filter->ether_type == ETHER_TYPE_IPv6 ||
-                           filter->ether_type == ETHER_TYPE_LLDP ||
-                           filter->ether_type == outer_tpid) {
+                       if (filter->ether_type == RTE_ETHER_TYPE_IPV4 ||
+                           filter->ether_type == RTE_ETHER_TYPE_IPV6 ||
+                           filter->ether_type == RTE_ETHER_TYPE_LLDP ||
+                           filter->ether_type == i40e_get_outer_vlan(dev)) {
                                rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
                                                   item,
@@ -2073,7 +2148,7 @@ i40e_flow_parse_ethertype_action(struct rte_eth_dev *dev,
        }
 
        if (act->type == RTE_FLOW_ACTION_TYPE_QUEUE) {
-               act_q = (const struct rte_flow_action_queue *)act->conf;
+               act_q = act->conf;
                filter->queue = act_q->index;
                if (filter->queue >= pf->dev_data->nb_rx_queues) {
                        rte_flow_error_set(error, EINVAL,
@@ -2168,197 +2243,6 @@ i40e_flow_check_raw_item(const struct rte_flow_item *item,
        return 0;
 }
 
-static int
-i40e_flow_store_flex_pit(struct i40e_pf *pf,
-                        struct i40e_fdir_flex_pit *flex_pit,
-                        enum i40e_flxpld_layer_idx layer_idx,
-                        uint8_t raw_id)
-{
-       uint8_t field_idx;
-
-       field_idx = layer_idx * I40E_MAX_FLXPLD_FIED + raw_id;
-       /* Check if the configuration is conflicted */
-       if (pf->fdir.flex_pit_flag[layer_idx] &&
-           (pf->fdir.flex_set[field_idx].src_offset != flex_pit->src_offset ||
-            pf->fdir.flex_set[field_idx].size != flex_pit->size ||
-            pf->fdir.flex_set[field_idx].dst_offset != flex_pit->dst_offset))
-               return -1;
-
-       /* Check if the configuration exists. */
-       if (pf->fdir.flex_pit_flag[layer_idx] &&
-           (pf->fdir.flex_set[field_idx].src_offset == flex_pit->src_offset &&
-            pf->fdir.flex_set[field_idx].size == flex_pit->size &&
-            pf->fdir.flex_set[field_idx].dst_offset == flex_pit->dst_offset))
-               return 1;
-
-       pf->fdir.flex_set[field_idx].src_offset =
-               flex_pit->src_offset;
-       pf->fdir.flex_set[field_idx].size =
-               flex_pit->size;
-       pf->fdir.flex_set[field_idx].dst_offset =
-               flex_pit->dst_offset;
-
-       return 0;
-}
-
-static int
-i40e_flow_store_flex_mask(struct i40e_pf *pf,
-                         enum i40e_filter_pctype pctype,
-                         uint8_t *mask)
-{
-       struct i40e_fdir_flex_mask flex_mask;
-       uint16_t mask_tmp;
-       uint8_t i, nb_bitmask = 0;
-
-       memset(&flex_mask, 0, sizeof(struct i40e_fdir_flex_mask));
-       for (i = 0; i < I40E_FDIR_MAX_FLEX_LEN; i += sizeof(uint16_t)) {
-               mask_tmp = I40E_WORD(mask[i], mask[i + 1]);
-               if (mask_tmp) {
-                       flex_mask.word_mask |=
-                               I40E_FLEX_WORD_MASK(i / sizeof(uint16_t));
-                       if (mask_tmp != UINT16_MAX) {
-                               flex_mask.bitmask[nb_bitmask].mask = ~mask_tmp;
-                               flex_mask.bitmask[nb_bitmask].offset =
-                                       i / sizeof(uint16_t);
-                               nb_bitmask++;
-                               if (nb_bitmask > I40E_FDIR_BITMASK_NUM_WORD)
-                                       return -1;
-                       }
-               }
-       }
-       flex_mask.nb_bitmask = nb_bitmask;
-
-       if (pf->fdir.flex_mask_flag[pctype] &&
-           (memcmp(&flex_mask, &pf->fdir.flex_mask[pctype],
-                   sizeof(struct i40e_fdir_flex_mask))))
-               return -2;
-       else if (pf->fdir.flex_mask_flag[pctype] &&
-                !(memcmp(&flex_mask, &pf->fdir.flex_mask[pctype],
-                         sizeof(struct i40e_fdir_flex_mask))))
-               return 1;
-
-       memcpy(&pf->fdir.flex_mask[pctype], &flex_mask,
-              sizeof(struct i40e_fdir_flex_mask));
-       return 0;
-}
-
-static void
-i40e_flow_set_fdir_flex_pit(struct i40e_pf *pf,
-                           enum i40e_flxpld_layer_idx layer_idx,
-                           uint8_t raw_id)
-{
-       struct i40e_hw *hw = I40E_PF_TO_HW(pf);
-       uint32_t flx_pit;
-       uint8_t field_idx;
-       uint16_t min_next_off = 0;  /* in words */
-       uint8_t i;
-
-       /* Set flex pit */
-       for (i = 0; i < raw_id; i++) {
-               field_idx = layer_idx * I40E_MAX_FLXPLD_FIED + i;
-               flx_pit = MK_FLX_PIT(pf->fdir.flex_set[field_idx].src_offset,
-                                    pf->fdir.flex_set[field_idx].size,
-                                    pf->fdir.flex_set[field_idx].dst_offset);
-
-               I40E_WRITE_REG(hw, I40E_PRTQF_FLX_PIT(field_idx), flx_pit);
-               min_next_off = pf->fdir.flex_set[field_idx].src_offset +
-                       pf->fdir.flex_set[field_idx].size;
-       }
-
-       for (; i < I40E_MAX_FLXPLD_FIED; i++) {
-               /* set the non-used register obeying register's constrain */
-               field_idx = layer_idx * I40E_MAX_FLXPLD_FIED + i;
-               flx_pit = MK_FLX_PIT(min_next_off, NONUSE_FLX_PIT_FSIZE,
-                                    NONUSE_FLX_PIT_DEST_OFF);
-               I40E_WRITE_REG(hw, I40E_PRTQF_FLX_PIT(field_idx), flx_pit);
-               min_next_off++;
-       }
-
-       pf->fdir.flex_pit_flag[layer_idx] = 1;
-}
-
-static void
-i40e_flow_set_fdir_flex_msk(struct i40e_pf *pf,
-                           enum i40e_filter_pctype pctype)
-{
-       struct i40e_hw *hw = I40E_PF_TO_HW(pf);
-       struct i40e_fdir_flex_mask *flex_mask;
-       uint32_t flxinset, fd_mask;
-       uint8_t i;
-
-       /* Set flex mask */
-       flex_mask = &pf->fdir.flex_mask[pctype];
-       flxinset = (flex_mask->word_mask <<
-                   I40E_PRTQF_FD_FLXINSET_INSET_SHIFT) &
-               I40E_PRTQF_FD_FLXINSET_INSET_MASK;
-       i40e_write_rx_ctl(hw, I40E_PRTQF_FD_FLXINSET(pctype), flxinset);
-
-       for (i = 0; i < flex_mask->nb_bitmask; i++) {
-               fd_mask = (flex_mask->bitmask[i].mask <<
-                          I40E_PRTQF_FD_MSK_MASK_SHIFT) &
-                       I40E_PRTQF_FD_MSK_MASK_MASK;
-               fd_mask |= ((flex_mask->bitmask[i].offset +
-                            I40E_FLX_OFFSET_IN_FIELD_VECTOR) <<
-                           I40E_PRTQF_FD_MSK_OFFSET_SHIFT) &
-                       I40E_PRTQF_FD_MSK_OFFSET_MASK;
-               i40e_write_rx_ctl(hw, I40E_PRTQF_FD_MSK(pctype, i), fd_mask);
-       }
-
-       pf->fdir.flex_mask_flag[pctype] = 1;
-}
-
-static int
-i40e_flow_set_fdir_inset(struct i40e_pf *pf,
-                        enum i40e_filter_pctype pctype,
-                        uint64_t input_set)
-{
-       struct i40e_hw *hw = I40E_PF_TO_HW(pf);
-       uint64_t inset_reg = 0;
-       uint32_t mask_reg[I40E_INSET_MASK_NUM_REG] = {0};
-       int i, num;
-
-       /* Check if the input set is valid */
-       if (i40e_validate_input_set(pctype, RTE_ETH_FILTER_FDIR,
-                                   input_set) != 0) {
-               PMD_DRV_LOG(ERR, "Invalid input set");
-               return -EINVAL;
-       }
-
-       /* Check if the configuration is conflicted */
-       if (pf->fdir.inset_flag[pctype] &&
-           memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t)))
-               return -1;
-
-       if (pf->fdir.inset_flag[pctype] &&
-           !memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t)))
-               return 0;
-
-       num = i40e_generate_inset_mask_reg(input_set, mask_reg,
-                                          I40E_INSET_MASK_NUM_REG);
-       if (num < 0)
-               return -EINVAL;
-
-       inset_reg |= i40e_translate_input_set_reg(hw->mac.type, input_set);
-
-       i40e_check_write_reg(hw, I40E_PRTQF_FD_INSET(pctype, 0),
-                            (uint32_t)(inset_reg & UINT32_MAX));
-       i40e_check_write_reg(hw, I40E_PRTQF_FD_INSET(pctype, 1),
-                            (uint32_t)((inset_reg >>
-                                        I40E_32_BIT_WIDTH) & UINT32_MAX));
-
-       for (i = 0; i < num; i++)
-               i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype),
-                                    mask_reg[i]);
-
-       /*clear unused mask registers of the pctype */
-       for (i = num; i < I40E_INSET_MASK_NUM_REG; i++)
-               i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype), 0);
-       I40E_WRITE_FLUSH(hw);
-
-       pf->fdir.input_set[pctype] = input_set;
-       pf->fdir.inset_flag[pctype] = 1;
-       return 0;
-}
 
 static uint8_t
 i40e_flow_fdir_get_pctype_value(struct i40e_pf *pf,
@@ -2385,17 +2269,72 @@ i40e_flow_fdir_get_pctype_value(struct i40e_pf *pf,
                        cus_pctype = i40e_find_customized_pctype(pf,
                                                 I40E_CUSTOMIZED_GTPU_IPV6);
                break;
+       case RTE_FLOW_ITEM_TYPE_L2TPV3OIP:
+               if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4)
+                       cus_pctype = i40e_find_customized_pctype(pf,
+                                               I40E_CUSTOMIZED_IPV4_L2TPV3);
+               else if (filter->input.flow_ext.oip_type ==
+                        I40E_FDIR_IPTYPE_IPV6)
+                       cus_pctype = i40e_find_customized_pctype(pf,
+                                               I40E_CUSTOMIZED_IPV6_L2TPV3);
+               break;
+       case RTE_FLOW_ITEM_TYPE_ESP:
+               if (!filter->input.flow_ext.is_udp) {
+                       if (filter->input.flow_ext.oip_type ==
+                               I40E_FDIR_IPTYPE_IPV4)
+                               cus_pctype = i40e_find_customized_pctype(pf,
+                                               I40E_CUSTOMIZED_ESP_IPV4);
+                       else if (filter->input.flow_ext.oip_type ==
+                               I40E_FDIR_IPTYPE_IPV6)
+                               cus_pctype = i40e_find_customized_pctype(pf,
+                                               I40E_CUSTOMIZED_ESP_IPV6);
+               } else {
+                       if (filter->input.flow_ext.oip_type ==
+                               I40E_FDIR_IPTYPE_IPV4)
+                               cus_pctype = i40e_find_customized_pctype(pf,
+                                               I40E_CUSTOMIZED_ESP_IPV4_UDP);
+                       else if (filter->input.flow_ext.oip_type ==
+                                       I40E_FDIR_IPTYPE_IPV6)
+                               cus_pctype = i40e_find_customized_pctype(pf,
+                                               I40E_CUSTOMIZED_ESP_IPV6_UDP);
+                       filter->input.flow_ext.is_udp = false;
+               }
+               break;
        default:
                PMD_DRV_LOG(ERR, "Unsupported item type");
                break;
        }
 
-       if (cus_pctype)
+       if (cus_pctype && cus_pctype->valid)
                return cus_pctype->pctype;
 
        return I40E_FILTER_PCTYPE_INVALID;
 }
 
+static void
+i40e_flow_set_filter_spi(struct i40e_fdir_filter_conf *filter,
+       const struct rte_flow_item_esp *esp_spec)
+{
+       if (filter->input.flow_ext.oip_type ==
+               I40E_FDIR_IPTYPE_IPV4) {
+               if (filter->input.flow_ext.is_udp)
+                       filter->input.flow.esp_ipv4_udp_flow.spi =
+                               esp_spec->hdr.spi;
+               else
+                       filter->input.flow.esp_ipv4_flow.spi =
+                               esp_spec->hdr.spi;
+       }
+       if (filter->input.flow_ext.oip_type ==
+               I40E_FDIR_IPTYPE_IPV6) {
+               if (filter->input.flow_ext.is_udp)
+                       filter->input.flow.esp_ipv6_udp_flow.spi =
+                               esp_spec->hdr.spi;
+               else
+                       filter->input.flow.esp_ipv6_flow.spi =
+                               esp_spec->hdr.spi;
+       }
+}
+
 /* 1. Last in item should be NULL as range is not supported.
  * 2. Supported patterns: refer to array i40e_supported_patterns.
  * 3. Default supported flow type and input set: refer to array
@@ -2409,6 +2348,7 @@ i40e_flow_fdir_get_pctype_value(struct i40e_pf *pf,
  */
 static int
 i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
+                            const struct rte_flow_attr *attr,
                             const struct rte_flow_item *pattern,
                             struct rte_flow_error *error,
                             struct i40e_fdir_filter_conf *filter)
@@ -2417,19 +2357,21 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
        const struct rte_flow_item *item = pattern;
        const struct rte_flow_item_eth *eth_spec, *eth_mask;
        const struct rte_flow_item_vlan *vlan_spec, *vlan_mask;
-       const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_mask;
+       const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_last, *ipv4_mask;
        const struct rte_flow_item_ipv6 *ipv6_spec, *ipv6_mask;
        const struct rte_flow_item_tcp *tcp_spec, *tcp_mask;
        const struct rte_flow_item_udp *udp_spec, *udp_mask;
        const struct rte_flow_item_sctp *sctp_spec, *sctp_mask;
        const struct rte_flow_item_gtp *gtp_spec, *gtp_mask;
+       const struct rte_flow_item_esp *esp_spec, *esp_mask;
        const struct rte_flow_item_raw *raw_spec, *raw_mask;
        const struct rte_flow_item_vf *vf_spec;
+       const struct rte_flow_item_l2tpv3oip *l2tpv3oip_spec, *l2tpv3oip_mask;
 
        uint8_t pctype = 0;
        uint64_t input_set = I40E_INSET_NONE;
-       uint16_t frag_off;
        enum rte_flow_item_type item_type;
+       enum rte_flow_item_type next_type;
        enum rte_flow_item_type l3 = RTE_FLOW_ITEM_TYPE_END;
        enum rte_flow_item_type cus_proto = RTE_FLOW_ITEM_TYPE_END;
        uint32_t i, j;
@@ -2442,23 +2384,18 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
        uint16_t len_arr[I40E_MAX_FLXPLD_FIED];
        struct i40e_fdir_flex_pit flex_pit;
        uint8_t next_dst_off = 0;
-       uint8_t flex_mask[I40E_FDIR_MAX_FLEX_LEN];
        uint16_t flex_size;
-       bool cfg_flex_pit = true;
-       bool cfg_flex_msk = true;
-       uint16_t outer_tpid;
        uint16_t ether_type;
        uint32_t vtc_flow_cpu;
        bool outer_ip = true;
+       uint8_t field_idx;
        int ret;
 
        memset(off_arr, 0, sizeof(off_arr));
        memset(len_arr, 0, sizeof(len_arr));
-       memset(flex_mask, 0, I40E_FDIR_MAX_FLEX_LEN);
-       outer_tpid = i40e_get_outer_vlan(dev);
        filter->input.flow_ext.customized_pctype = false;
        for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++) {
-               if (item->last) {
+               if (item->last && item->type != RTE_FLOW_ITEM_TYPE_IPV4) {
                        rte_flow_error_set(error, EINVAL,
                                           RTE_FLOW_ERROR_TYPE_ITEM,
                                           item,
@@ -2468,37 +2405,71 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                item_type = item->type;
                switch (item_type) {
                case RTE_FLOW_ITEM_TYPE_ETH:
-                       eth_spec = (const struct rte_flow_item_eth *)item->spec;
-                       eth_mask = (const struct rte_flow_item_eth *)item->mask;
+                       eth_spec = item->spec;
+                       eth_mask = item->mask;
+                       next_type = (item + 1)->type;
+
+                       if (next_type == RTE_FLOW_ITEM_TYPE_END &&
+                                               (!eth_spec || !eth_mask)) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "NULL eth spec/mask.");
+                               return -rte_errno;
+                       }
 
                        if (eth_spec && eth_mask) {
-                               if (!is_zero_ether_addr(&eth_mask->src) ||
-                                   !is_zero_ether_addr(&eth_mask->dst)) {
+                               if (rte_is_broadcast_ether_addr(&eth_mask->dst) &&
+                                       rte_is_zero_ether_addr(&eth_mask->src)) {
+                                       filter->input.flow.l2_flow.dst =
+                                               eth_spec->dst;
+                                       input_set |= I40E_INSET_DMAC;
+                               } else if (rte_is_zero_ether_addr(&eth_mask->dst) &&
+                                       rte_is_broadcast_ether_addr(&eth_mask->src)) {
+                                       filter->input.flow.l2_flow.src =
+                                               eth_spec->src;
+                                       input_set |= I40E_INSET_SMAC;
+                               } else if (rte_is_broadcast_ether_addr(&eth_mask->dst) &&
+                                       rte_is_broadcast_ether_addr(&eth_mask->src)) {
+                                       filter->input.flow.l2_flow.dst =
+                                               eth_spec->dst;
+                                       filter->input.flow.l2_flow.src =
+                                               eth_spec->src;
+                                       input_set |= (I40E_INSET_DMAC | I40E_INSET_SMAC);
+                               } else if (!rte_is_zero_ether_addr(&eth_mask->src) ||
+                                          !rte_is_zero_ether_addr(&eth_mask->dst)) {
                                        rte_flow_error_set(error, EINVAL,
                                                      RTE_FLOW_ERROR_TYPE_ITEM,
                                                      item,
                                                      "Invalid MAC_addr mask.");
                                        return -rte_errno;
                                }
-
-                               if ((eth_mask->type & UINT16_MAX) ==
-                                   UINT16_MAX) {
-                                       input_set |= I40E_INSET_LAST_ETHER_TYPE;
-                                       filter->input.flow.l2_flow.ether_type =
-                                               eth_spec->type;
+                       }
+                       if (eth_spec && eth_mask &&
+                       next_type == RTE_FLOW_ITEM_TYPE_END) {
+                               if (eth_mask->type != RTE_BE16(0xffff)) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                     RTE_FLOW_ERROR_TYPE_ITEM,
+                                                     item,
+                                                     "Invalid type mask.");
+                                       return -rte_errno;
                                }
 
                                ether_type = rte_be_to_cpu_16(eth_spec->type);
-                               if (ether_type == ETHER_TYPE_IPv4 ||
-                                   ether_type == ETHER_TYPE_IPv6 ||
-                                   ether_type == ETHER_TYPE_ARP ||
-                                   ether_type == outer_tpid) {
+
+                               if (next_type == RTE_FLOW_ITEM_TYPE_VLAN ||
+                                   ether_type == RTE_ETHER_TYPE_IPV4 ||
+                                   ether_type == RTE_ETHER_TYPE_IPV6 ||
+                                   ether_type == i40e_get_outer_vlan(dev)) {
                                        rte_flow_error_set(error, EINVAL,
                                                     RTE_FLOW_ERROR_TYPE_ITEM,
                                                     item,
                                                     "Unsupported ether_type.");
                                        return -rte_errno;
                                }
+                               input_set |= I40E_INSET_LAST_ETHER_TYPE;
+                               filter->input.flow.l2_flow.ether_type =
+                                       eth_spec->type;
                        }
 
                        pctype = I40E_FILTER_PCTYPE_L2_PAYLOAD;
@@ -2506,17 +2477,53 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
 
                        break;
                case RTE_FLOW_ITEM_TYPE_VLAN:
-                       vlan_spec =
-                               (const struct rte_flow_item_vlan *)item->spec;
-                       vlan_mask =
-                               (const struct rte_flow_item_vlan *)item->mask;
+                       vlan_spec = item->spec;
+                       vlan_mask = item->mask;
+
+                       RTE_ASSERT(!(input_set & I40E_INSET_LAST_ETHER_TYPE));
                        if (vlan_spec && vlan_mask) {
-                               if (vlan_mask->tci ==
-                                   rte_cpu_to_be_16(I40E_TCI_MASK)) {
-                                       input_set |= I40E_INSET_VLAN_INNER;
-                                       filter->input.flow_ext.vlan_tci =
-                                               vlan_spec->tci;
+                               if (vlan_mask->tci !=
+                                   rte_cpu_to_be_16(I40E_VLAN_TCI_MASK) &&
+                                   vlan_mask->tci !=
+                                   rte_cpu_to_be_16(I40E_VLAN_PRI_MASK) &&
+                                   vlan_mask->tci !=
+                                   rte_cpu_to_be_16(I40E_VLAN_CFI_MASK) &&
+                                   vlan_mask->tci !=
+                                   rte_cpu_to_be_16(I40E_VLAN_VID_MASK)) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Unsupported TCI mask.");
+                               }
+                               input_set |= I40E_INSET_VLAN_INNER;
+                               filter->input.flow_ext.vlan_tci =
+                                       vlan_spec->tci;
+                       }
+                       if (vlan_spec && vlan_mask && vlan_mask->inner_type) {
+                               if (vlan_mask->inner_type != RTE_BE16(0xffff)) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                     RTE_FLOW_ERROR_TYPE_ITEM,
+                                                     item,
+                                                     "Invalid inner_type"
+                                                     " mask.");
+                                       return -rte_errno;
+                               }
+
+                               ether_type =
+                                       rte_be_to_cpu_16(vlan_spec->inner_type);
+
+                               if (ether_type == RTE_ETHER_TYPE_IPV4 ||
+                                   ether_type == RTE_ETHER_TYPE_IPV6 ||
+                                   ether_type == i40e_get_outer_vlan(dev)) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                    RTE_FLOW_ERROR_TYPE_ITEM,
+                                                    item,
+                                                    "Unsupported inner_type.");
+                                       return -rte_errno;
                                }
+                               input_set |= I40E_INSET_LAST_ETHER_TYPE;
+                               filter->input.flow.l2_flow.ether_type =
+                                       vlan_spec->inner_type;
                        }
 
                        pctype = I40E_FILTER_PCTYPE_L2_PAYLOAD;
@@ -2525,19 +2532,42 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                        break;
                case RTE_FLOW_ITEM_TYPE_IPV4:
                        l3 = RTE_FLOW_ITEM_TYPE_IPV4;
-                       ipv4_spec =
-                               (const struct rte_flow_item_ipv4 *)item->spec;
-                       ipv4_mask =
-                               (const struct rte_flow_item_ipv4 *)item->mask;
+                       ipv4_spec = item->spec;
+                       ipv4_mask = item->mask;
+                       ipv4_last = item->last;
                        pctype = I40E_FILTER_PCTYPE_NONF_IPV4_OTHER;
                        layer_idx = I40E_FLXPLD_L3_IDX;
 
+                       if (ipv4_last) {
+                               if (!ipv4_spec || !ipv4_mask || !outer_ip) {
+                                       rte_flow_error_set(error, EINVAL,
+                                               RTE_FLOW_ERROR_TYPE_ITEM,
+                                               item,
+                                               "Not support range");
+                                       return -rte_errno;
+                               }
+                               /* Only fragment_offset supports range */
+                               if (ipv4_last->hdr.version_ihl ||
+                                   ipv4_last->hdr.type_of_service ||
+                                   ipv4_last->hdr.total_length ||
+                                   ipv4_last->hdr.packet_id ||
+                                   ipv4_last->hdr.time_to_live ||
+                                   ipv4_last->hdr.next_proto_id ||
+                                   ipv4_last->hdr.hdr_checksum ||
+                                   ipv4_last->hdr.src_addr ||
+                                   ipv4_last->hdr.dst_addr) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Not support range");
+                                       return -rte_errno;
+                               }
+                       }
                        if (ipv4_spec && ipv4_mask && outer_ip) {
                                /* Check IPv4 mask and update input set */
                                if (ipv4_mask->hdr.version_ihl ||
                                    ipv4_mask->hdr.total_length ||
                                    ipv4_mask->hdr.packet_id ||
-                                   ipv4_mask->hdr.fragment_offset ||
                                    ipv4_mask->hdr.hdr_checksum) {
                                        rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
@@ -2558,27 +2588,92 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                        input_set |= I40E_INSET_IPV4_PROTO;
 
                                /* Check if it is fragment. */
-                               frag_off = ipv4_spec->hdr.fragment_offset;
-                               frag_off = rte_be_to_cpu_16(frag_off);
-                               if (frag_off & IPV4_HDR_OFFSET_MASK ||
-                                   frag_off & IPV4_HDR_MF_FLAG)
-                                       pctype = I40E_FILTER_PCTYPE_FRAG_IPV4;
-
-                               /* Get the filter info */
-                               filter->input.flow.ip4_flow.proto =
-                                       ipv4_spec->hdr.next_proto_id;
-                               filter->input.flow.ip4_flow.tos =
-                                       ipv4_spec->hdr.type_of_service;
-                               filter->input.flow.ip4_flow.ttl =
-                                       ipv4_spec->hdr.time_to_live;
-                               filter->input.flow.ip4_flow.src_ip =
-                                       ipv4_spec->hdr.src_addr;
-                               filter->input.flow.ip4_flow.dst_ip =
-                                       ipv4_spec->hdr.dst_addr;
+                               uint16_t frag_mask =
+                                       ipv4_mask->hdr.fragment_offset;
+                               uint16_t frag_spec =
+                                       ipv4_spec->hdr.fragment_offset;
+                               uint16_t frag_last = 0;
+                               if (ipv4_last)
+                                       frag_last =
+                                       ipv4_last->hdr.fragment_offset;
+                               if (frag_mask) {
+                                       frag_mask = rte_be_to_cpu_16(frag_mask);
+                                       frag_spec = rte_be_to_cpu_16(frag_spec);
+                                       frag_last = rte_be_to_cpu_16(frag_last);
+                                       /* frag_off mask has to be 0x3fff */
+                                       if (frag_mask !=
+                                           (RTE_IPV4_HDR_OFFSET_MASK |
+                                           RTE_IPV4_HDR_MF_FLAG)) {
+                                               rte_flow_error_set(error,
+                                                  EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid IPv4 fragment_offset mask");
+                                               return -rte_errno;
+                                       }
+                                       /*
+                                        * non-frag rule:
+                                        * mask=0x3fff,spec=0
+                                        * frag rule:
+                                        * mask=0x3fff,spec=0x8,last=0x2000
+                                        */
+                                       if (frag_spec ==
+                                           (1 << RTE_IPV4_HDR_FO_SHIFT) &&
+                                           frag_last == RTE_IPV4_HDR_MF_FLAG) {
+                                               pctype =
+                                                 I40E_FILTER_PCTYPE_FRAG_IPV4;
+                                       } else if (frag_spec || frag_last) {
+                                               rte_flow_error_set(error,
+                                                  EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid IPv4 fragment_offset rule");
+                                               return -rte_errno;
+                                       }
+                               } else if (frag_spec || frag_last) {
+                                       rte_flow_error_set(error,
+                                               EINVAL,
+                                               RTE_FLOW_ERROR_TYPE_ITEM,
+                                               item,
+                                               "Invalid fragment_offset");
+                                       return -rte_errno;
+                               }
+
+                               if (input_set & (I40E_INSET_DMAC | I40E_INSET_SMAC)) {
+                                       if (input_set & (I40E_INSET_IPV4_SRC |
+                                               I40E_INSET_IPV4_DST | I40E_INSET_IPV4_TOS |
+                                               I40E_INSET_IPV4_TTL | I40E_INSET_IPV4_PROTO)) {
+                                               rte_flow_error_set(error, EINVAL,
+                                                       RTE_FLOW_ERROR_TYPE_ITEM,
+                                                       item,
+                                                       "L2 and L3 input set are exclusive.");
+                                               return -rte_errno;
+                                       }
+                               } else {
+                                       /* Get the filter info */
+                                       filter->input.flow.ip4_flow.proto =
+                                               ipv4_spec->hdr.next_proto_id;
+                                       filter->input.flow.ip4_flow.tos =
+                                               ipv4_spec->hdr.type_of_service;
+                                       filter->input.flow.ip4_flow.ttl =
+                                               ipv4_spec->hdr.time_to_live;
+                                       filter->input.flow.ip4_flow.src_ip =
+                                               ipv4_spec->hdr.src_addr;
+                                       filter->input.flow.ip4_flow.dst_ip =
+                                               ipv4_spec->hdr.dst_addr;
+
+                                       filter->input.flow_ext.inner_ip = false;
+                                       filter->input.flow_ext.oip_type =
+                                               I40E_FDIR_IPTYPE_IPV4;
+                               }
                        } else if (!ipv4_spec && !ipv4_mask && !outer_ip) {
                                filter->input.flow_ext.inner_ip = true;
                                filter->input.flow_ext.iip_type =
                                        I40E_FDIR_IPTYPE_IPV4;
+                       } else if (!ipv4_spec && !ipv4_mask && outer_ip) {
+                               filter->input.flow_ext.inner_ip = false;
+                               filter->input.flow_ext.oip_type =
+                                       I40E_FDIR_IPTYPE_IPV4;
                        } else if ((ipv4_spec || ipv4_mask) && !outer_ip) {
                                rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
@@ -2593,10 +2688,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                        break;
                case RTE_FLOW_ITEM_TYPE_IPV6:
                        l3 = RTE_FLOW_ITEM_TYPE_IPV6;
-                       ipv6_spec =
-                               (const struct rte_flow_item_ipv6 *)item->spec;
-                       ipv6_mask =
-                               (const struct rte_flow_item_ipv6 *)item->mask;
+                       ipv6_spec = item->spec;
+                       ipv6_mask = item->mask;
                        pctype = I40E_FILTER_PCTYPE_NONF_IPV6_OTHER;
                        layer_idx = I40E_FLXPLD_L3_IDX;
 
@@ -2639,6 +2732,10 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                filter->input.flow.ipv6_flow.hop_limits =
                                        ipv6_spec->hdr.hop_limits;
 
+                               filter->input.flow_ext.inner_ip = false;
+                               filter->input.flow_ext.oip_type =
+                                       I40E_FDIR_IPTYPE_IPV6;
+
                                rte_memcpy(filter->input.flow.ipv6_flow.src_ip,
                                           ipv6_spec->hdr.src_addr, 16);
                                rte_memcpy(filter->input.flow.ipv6_flow.dst_ip,
@@ -2652,6 +2749,10 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                filter->input.flow_ext.inner_ip = true;
                                filter->input.flow_ext.iip_type =
                                        I40E_FDIR_IPTYPE_IPV6;
+                       } else if (!ipv6_spec && !ipv6_mask && outer_ip) {
+                               filter->input.flow_ext.inner_ip = false;
+                               filter->input.flow_ext.oip_type =
+                                       I40E_FDIR_IPTYPE_IPV6;
                        } else if ((ipv6_spec || ipv6_mask) && !outer_ip) {
                                rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
@@ -2664,8 +2765,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                outer_ip = false;
                        break;
                case RTE_FLOW_ITEM_TYPE_TCP:
-                       tcp_spec = (const struct rte_flow_item_tcp *)item->spec;
-                       tcp_mask = (const struct rte_flow_item_tcp *)item->mask;
+                       tcp_spec = item->spec;
+                       tcp_mask = item->mask;
 
                        if (l3 == RTE_FLOW_ITEM_TYPE_IPV4)
                                pctype =
@@ -2694,17 +2795,28 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                if (tcp_mask->hdr.dst_port == UINT16_MAX)
                                        input_set |= I40E_INSET_DST_PORT;
 
-                               /* Get filter info */
-                               if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
-                                       filter->input.flow.tcp4_flow.src_port =
-                                               tcp_spec->hdr.src_port;
-                                       filter->input.flow.tcp4_flow.dst_port =
-                                               tcp_spec->hdr.dst_port;
-                               } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
-                                       filter->input.flow.tcp6_flow.src_port =
-                                               tcp_spec->hdr.src_port;
-                                       filter->input.flow.tcp6_flow.dst_port =
-                                               tcp_spec->hdr.dst_port;
+                               if (input_set & (I40E_INSET_DMAC | I40E_INSET_SMAC)) {
+                                       if (input_set &
+                                               (I40E_INSET_SRC_PORT | I40E_INSET_DST_PORT)) {
+                                               rte_flow_error_set(error, EINVAL,
+                                                       RTE_FLOW_ERROR_TYPE_ITEM,
+                                                       item,
+                                                       "L2 and L4 input set are exclusive.");
+                                               return -rte_errno;
+                                       }
+                               } else {
+                                       /* Get filter info */
+                                       if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
+                                               filter->input.flow.tcp4_flow.src_port =
+                                                       tcp_spec->hdr.src_port;
+                                               filter->input.flow.tcp4_flow.dst_port =
+                                                       tcp_spec->hdr.dst_port;
+                                       } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
+                                               filter->input.flow.tcp6_flow.src_port =
+                                                       tcp_spec->hdr.src_port;
+                                               filter->input.flow.tcp6_flow.dst_port =
+                                                       tcp_spec->hdr.dst_port;
+                                       }
                                }
                        }
 
@@ -2712,8 +2824,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
 
                        break;
                case RTE_FLOW_ITEM_TYPE_UDP:
-                       udp_spec = (const struct rte_flow_item_udp *)item->spec;
-                       udp_mask = (const struct rte_flow_item_udp *)item->mask;
+                       udp_spec = item->spec;
+                       udp_mask = item->mask;
 
                        if (l3 == RTE_FLOW_ITEM_TYPE_IPV4)
                                pctype =
@@ -2738,20 +2850,31 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                if (udp_mask->hdr.dst_port == UINT16_MAX)
                                        input_set |= I40E_INSET_DST_PORT;
 
-                               /* Get filter info */
-                               if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
-                                       filter->input.flow.udp4_flow.src_port =
-                                               udp_spec->hdr.src_port;
-                                       filter->input.flow.udp4_flow.dst_port =
-                                               udp_spec->hdr.dst_port;
-                               } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
-                                       filter->input.flow.udp6_flow.src_port =
-                                               udp_spec->hdr.src_port;
-                                       filter->input.flow.udp6_flow.dst_port =
-                                               udp_spec->hdr.dst_port;
+                               if (input_set & (I40E_INSET_DMAC | I40E_INSET_SMAC)) {
+                                       if (input_set &
+                                               (I40E_INSET_SRC_PORT | I40E_INSET_DST_PORT)) {
+                                               rte_flow_error_set(error, EINVAL,
+                                                       RTE_FLOW_ERROR_TYPE_ITEM,
+                                                       item,
+                                                       "L2 and L4 input set are exclusive.");
+                                               return -rte_errno;
+                                       }
+                               } else {
+                                       /* Get filter info */
+                                       if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
+                                               filter->input.flow.udp4_flow.src_port =
+                                                       udp_spec->hdr.src_port;
+                                               filter->input.flow.udp4_flow.dst_port =
+                                                       udp_spec->hdr.dst_port;
+                                       } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
+                                               filter->input.flow.udp6_flow.src_port =
+                                                       udp_spec->hdr.src_port;
+                                               filter->input.flow.udp6_flow.dst_port =
+                                                       udp_spec->hdr.dst_port;
+                                       }
                                }
                        }
-
+                       filter->input.flow_ext.is_udp = true;
                        layer_idx = I40E_FLXPLD_L4_IDX;
 
                        break;
@@ -2765,8 +2888,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                return -rte_errno;
                        }
 
-                       gtp_spec = (const struct rte_flow_item_gtp *)item->spec;
-                       gtp_mask = (const struct rte_flow_item_gtp *)item->mask;
+                       gtp_spec = item->spec;
+                       gtp_mask = item->mask;
 
                        if (gtp_spec && gtp_mask) {
                                if (gtp_mask->v_pt_rsv_flags ||
@@ -2786,11 +2909,42 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                cus_proto = item_type;
                        }
                        break;
+               case RTE_FLOW_ITEM_TYPE_ESP:
+                       if (!pf->esp_support) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Unsupported ESP protocol");
+                               return -rte_errno;
+                       }
+
+                       esp_spec = item->spec;
+                       esp_mask = item->mask;
+
+                       if (!esp_spec || !esp_mask) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid ESP item");
+                               return -rte_errno;
+                       }
+
+                       if (esp_spec && esp_mask) {
+                               if (esp_mask->hdr.spi != UINT32_MAX) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid ESP mask");
+                                       return -rte_errno;
+                               }
+                               i40e_flow_set_filter_spi(filter, esp_spec);
+                               filter->input.flow_ext.customized_pctype = true;
+                               cus_proto = item_type;
+                       }
+                       break;
                case RTE_FLOW_ITEM_TYPE_SCTP:
-                       sctp_spec =
-                               (const struct rte_flow_item_sctp *)item->spec;
-                       sctp_mask =
-                               (const struct rte_flow_item_sctp *)item->mask;
+                       sctp_spec = item->spec;
+                       sctp_mask = item->mask;
 
                        if (l3 == RTE_FLOW_ITEM_TYPE_IPV4)
                                pctype =
@@ -2838,8 +2992,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
 
                        break;
                case RTE_FLOW_ITEM_TYPE_RAW:
-                       raw_spec = (const struct rte_flow_item_raw *)item->spec;
-                       raw_mask = (const struct rte_flow_item_raw *)item->mask;
+                       raw_spec = item->spec;
+                       raw_mask = item->mask;
 
                        if (!raw_spec || !raw_mask) {
                                rte_flow_error_set(error, EINVAL,
@@ -2849,6 +3003,14 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                return -rte_errno;
                        }
 
+                       if (pf->support_multi_driver) {
+                               rte_flow_error_set(error, ENOTSUP,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Unsupported flexible payload.");
+                               return -rte_errno;
+                       }
+
                        ret = i40e_flow_check_raw_item(item, raw_spec, error);
                        if (ret < 0)
                                return ret;
@@ -2858,6 +3020,7 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
 
                        flex_size = 0;
                        memset(&flex_pit, 0, sizeof(struct i40e_fdir_flex_pit));
+                       field_idx = layer_idx * I40E_MAX_FLXPLD_FIED + raw_id;
                        flex_pit.size =
                                raw_spec->length / sizeof(uint16_t);
                        flex_pit.dst_offset =
@@ -2884,30 +3047,35 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                return -rte_errno;
                        }
 
-                       /* Store flex pit to SW */
-                       ret = i40e_flow_store_flex_pit(pf, &flex_pit,
-                                                      layer_idx, raw_id);
-                       if (ret < 0) {
-                               rte_flow_error_set(error, EINVAL,
-                                  RTE_FLOW_ERROR_TYPE_ITEM,
-                                  item,
-                                  "Conflict with the first flexible rule.");
-                               return -rte_errno;
-                       } else if (ret > 0)
-                               cfg_flex_pit = false;
-
                        for (i = 0; i < raw_spec->length; i++) {
                                j = i + next_dst_off;
                                filter->input.flow_ext.flexbytes[j] =
                                        raw_spec->pattern[i];
-                               flex_mask[j] = raw_mask->pattern[i];
+                               filter->input.flow_ext.flex_mask[j] =
+                                       raw_mask->pattern[i];
                        }
 
                        next_dst_off += raw_spec->length;
                        raw_id++;
+
+                       memcpy(&filter->input.flow_ext.flex_pit[field_idx],
+                              &flex_pit, sizeof(struct i40e_fdir_flex_pit));
+                       filter->input.flow_ext.layer_idx = layer_idx;
+                       filter->input.flow_ext.raw_id = raw_id;
+                       filter->input.flow_ext.is_flex_flow = true;
                        break;
                case RTE_FLOW_ITEM_TYPE_VF:
-                       vf_spec = (const struct rte_flow_item_vf *)item->spec;
+                       vf_spec = item->spec;
+                       if (!attr->transfer) {
+                               rte_flow_error_set(error, ENOTSUP,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Matching VF traffic"
+                                                  " without affecting it"
+                                                  " (transfer attribute)"
+                                                  " is unsupported");
+                               return -rte_errno;
+                       }
                        filter->input.flow_ext.is_vf = 1;
                        filter->input.flow_ext.dst_id = vf_spec->id;
                        if (filter->input.flow_ext.is_vf &&
@@ -2919,6 +3087,36 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                                return -rte_errno;
                        }
                        break;
+               case RTE_FLOW_ITEM_TYPE_L2TPV3OIP:
+                       l2tpv3oip_spec = item->spec;
+                       l2tpv3oip_mask = item->mask;
+
+                       if (!l2tpv3oip_spec || !l2tpv3oip_mask)
+                               break;
+
+                       if (l2tpv3oip_mask->session_id != UINT32_MAX) {
+                               rte_flow_error_set(error, EINVAL,
+                                       RTE_FLOW_ERROR_TYPE_ITEM,
+                                       item,
+                                       "Invalid L2TPv3 mask");
+                               return -rte_errno;
+                       }
+
+                       if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
+                               filter->input.flow.ip4_l2tpv3oip_flow.session_id =
+                                       l2tpv3oip_spec->session_id;
+                               filter->input.flow_ext.oip_type =
+                                       I40E_FDIR_IPTYPE_IPV4;
+                       } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
+                               filter->input.flow.ip6_l2tpv3oip_flow.session_id =
+                                       l2tpv3oip_spec->session_id;
+                               filter->input.flow_ext.oip_type =
+                                       I40E_FDIR_IPTYPE_IPV6;
+                       }
+
+                       filter->input.flow_ext.customized_pctype = true;
+                       cus_proto = item_type;
+                       break;
                default:
                        break;
                }
@@ -2938,41 +3136,14 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
 
        /* If customized pctype is not used, set fdir configuration.*/
        if (!filter->input.flow_ext.customized_pctype) {
-               ret = i40e_flow_set_fdir_inset(pf, pctype, input_set);
-               if (ret == -1) {
-                       rte_flow_error_set(error, EINVAL,
-                                          RTE_FLOW_ERROR_TYPE_ITEM, item,
-                                          "Conflict with the first rule's input set.");
-                       return -rte_errno;
-               } else if (ret == -EINVAL) {
-                       rte_flow_error_set(error, EINVAL,
-                                          RTE_FLOW_ERROR_TYPE_ITEM, item,
-                                          "Invalid pattern mask.");
-                       return -rte_errno;
+               /* Check if the input set is valid */
+               if (i40e_validate_input_set(pctype, RTE_ETH_FILTER_FDIR,
+                                               input_set) != 0) {
+                       PMD_DRV_LOG(ERR, "Invalid input set");
+                       return -EINVAL;
                }
 
-               /* Store flex mask to SW */
-               ret = i40e_flow_store_flex_mask(pf, pctype, flex_mask);
-               if (ret == -1) {
-                       rte_flow_error_set(error, EINVAL,
-                                          RTE_FLOW_ERROR_TYPE_ITEM,
-                                          item,
-                                          "Exceed maximal number of bitmasks");
-                       return -rte_errno;
-               } else if (ret == -2) {
-                       rte_flow_error_set(error, EINVAL,
-                                          RTE_FLOW_ERROR_TYPE_ITEM,
-                                          item,
-                                          "Conflict with the first flexible rule");
-                       return -rte_errno;
-               } else if (ret > 0)
-                       cfg_flex_msk = false;
-
-               if (cfg_flex_pit)
-                       i40e_flow_set_fdir_flex_pit(pf, layer_idx, raw_id);
-
-               if (cfg_flex_msk)
-                       i40e_flow_set_fdir_flex_msk(pf, pctype);
+               filter->input.flow_ext.input_set = input_set;
        }
 
        filter->input.pctype = pctype;
@@ -2992,14 +3163,14 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
        struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        const struct rte_flow_action *act;
        const struct rte_flow_action_queue *act_q;
-       const struct rte_flow_action_mark *mark_spec;
+       const struct rte_flow_action_mark *mark_spec = NULL;
        uint32_t index = 0;
 
        /* Check if the first non-void action is QUEUE or DROP or PASSTHRU. */
        NEXT_ITEM_OF_ACTION(act, actions, index);
        switch (act->type) {
        case RTE_FLOW_ACTION_TYPE_QUEUE:
-               act_q = (const struct rte_flow_action_queue *)act->conf;
+               act_q = act->conf;
                filter->action.rx_queue = act_q->index;
                if ((!filter->input.flow_ext.is_vf &&
                     filter->action.rx_queue >= pf->dev_data->nb_rx_queues) ||
@@ -3018,6 +3189,12 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
        case RTE_FLOW_ACTION_TYPE_PASSTHRU:
                filter->action.behavior = I40E_FDIR_PASSTHRU;
                break;
+       case RTE_FLOW_ACTION_TYPE_MARK:
+               filter->action.behavior = I40E_FDIR_PASSTHRU;
+               mark_spec = act->conf;
+               filter->action.report_status = I40E_FDIR_REPORT_ID;
+               filter->soft_id = mark_spec->id;
+       break;
        default:
                rte_flow_error_set(error, EINVAL,
                                   RTE_FLOW_ERROR_TYPE_ACTION, act,
@@ -3030,13 +3207,36 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
        NEXT_ITEM_OF_ACTION(act, actions, index);
        switch (act->type) {
        case RTE_FLOW_ACTION_TYPE_MARK:
-               mark_spec = (const struct rte_flow_action_mark *)act->conf;
+               if (mark_spec) {
+                       /* Double MARK actions requested */
+                       rte_flow_error_set(error, EINVAL,
+                          RTE_FLOW_ERROR_TYPE_ACTION, act,
+                          "Invalid action.");
+                       return -rte_errno;
+               }
+               mark_spec = act->conf;
                filter->action.report_status = I40E_FDIR_REPORT_ID;
                filter->soft_id = mark_spec->id;
                break;
        case RTE_FLOW_ACTION_TYPE_FLAG:
+               if (mark_spec) {
+                       /* MARK + FLAG not supported */
+                       rte_flow_error_set(error, EINVAL,
+                                          RTE_FLOW_ERROR_TYPE_ACTION, act,
+                                          "Invalid action.");
+                       return -rte_errno;
+               }
                filter->action.report_status = I40E_FDIR_NO_REPORT_STATUS;
                break;
+       case RTE_FLOW_ACTION_TYPE_RSS:
+               if (filter->action.behavior != I40E_FDIR_PASSTHRU) {
+                       /* RSS filter won't be next if FDIR did not pass thru */
+                       rte_flow_error_set(error, EINVAL,
+                                          RTE_FLOW_ERROR_TYPE_ACTION, act,
+                                          "Invalid action.");
+                       return -rte_errno;
+               }
+               break;
        case RTE_FLOW_ACTION_TYPE_END:
                return 0;
        default:
@@ -3066,11 +3266,13 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
                            struct rte_flow_error *error,
                            union i40e_filter_t *filter)
 {
+       struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        struct i40e_fdir_filter_conf *fdir_filter =
                &filter->fdir_filter;
        int ret;
 
-       ret = i40e_flow_parse_fdir_pattern(dev, pattern, error, fdir_filter);
+       ret = i40e_flow_parse_fdir_pattern(dev, attr, pattern, error,
+                                          fdir_filter);
        if (ret)
                return ret;
 
@@ -3084,16 +3286,32 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
 
        cons_filter_type = RTE_ETH_FILTER_FDIR;
 
-       if (dev->data->dev_conf.fdir_conf.mode !=
-           RTE_FDIR_MODE_PERFECT) {
-               rte_flow_error_set(error, ENOTSUP,
-                                  RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
-                                  NULL,
-                                  "Check the mode in fdir_conf.");
-               return -rte_errno;
+       if (pf->fdir.fdir_vsi == NULL) {
+               /* Enable fdir when fdir flow is added at first time. */
+               ret = i40e_fdir_setup(pf);
+               if (ret != I40E_SUCCESS) {
+                       rte_flow_error_set(error, ENOTSUP,
+                                          RTE_FLOW_ERROR_TYPE_HANDLE,
+                                          NULL, "Failed to setup fdir.");
+                       return -rte_errno;
+               }
+               ret = i40e_fdir_configure(dev);
+               if (ret < 0) {
+                       rte_flow_error_set(error, ENOTSUP,
+                                          RTE_FLOW_ERROR_TYPE_HANDLE,
+                                          NULL, "Failed to configure fdir.");
+                       goto err;
+               }
        }
 
+       /* If create the first fdir rule, enable fdir check for rx queues */
+       if (TAILQ_EMPTY(&pf->fdir.fdir_list))
+               i40e_fdir_rx_proc_enable(dev, 1);
+
        return 0;
+err:
+       i40e_fdir_teardown(pf);
+       return -rte_errno;
 }
 
 /* Parse to get the action info of a tunnel filter
@@ -3121,7 +3339,7 @@ i40e_flow_parse_tunnel_action(struct rte_eth_dev *dev,
        }
 
        if (act->type == RTE_FLOW_ACTION_TYPE_VF) {
-               act_vf = (const struct rte_flow_action_vf *)act->conf;
+               act_vf = act->conf;
                filter->vf_id = act_vf->id;
                filter->is_to_vf = 1;
                if (filter->vf_id >= pf->vf_num) {
@@ -3136,7 +3354,7 @@ i40e_flow_parse_tunnel_action(struct rte_eth_dev *dev,
        index++;
        NEXT_ITEM_OF_ACTION(act, actions, index);
        if (act->type == RTE_FLOW_ACTION_TYPE_QUEUE) {
-               act_q = (const struct rte_flow_action_queue *)act->conf;
+               act_q = act->conf;
                filter->queue_id = act_q->index;
                if ((!filter->is_to_vf) &&
                    (filter->queue_id >= pf->dev_data->nb_rx_queues)) {
@@ -3165,6 +3383,223 @@ i40e_flow_parse_tunnel_action(struct rte_eth_dev *dev,
        return 0;
 }
 
+/* 1. Last in item should be NULL as range is not supported.
+ * 2. Supported filter types: Source port only and Destination port only.
+ * 3. Mask of fields which need to be matched should be
+ *    filled with 1.
+ * 4. Mask of fields which needn't to be matched should be
+ *    filled with 0.
+ */
+static int
+i40e_flow_parse_l4_pattern(const struct rte_flow_item *pattern,
+                          struct rte_flow_error *error,
+                          struct i40e_tunnel_filter_conf *filter)
+{
+       const struct rte_flow_item_sctp *sctp_spec, *sctp_mask;
+       const struct rte_flow_item_tcp *tcp_spec, *tcp_mask;
+       const struct rte_flow_item_udp *udp_spec, *udp_mask;
+       const struct rte_flow_item *item = pattern;
+       enum rte_flow_item_type item_type;
+
+       for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++) {
+               if (item->last) {
+                       rte_flow_error_set(error, EINVAL,
+                                          RTE_FLOW_ERROR_TYPE_ITEM,
+                                          item,
+                                          "Not support range");
+                       return -rte_errno;
+               }
+               item_type = item->type;
+               switch (item_type) {
+               case RTE_FLOW_ITEM_TYPE_ETH:
+                       if (item->spec || item->mask) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid ETH item");
+                               return -rte_errno;
+                       }
+
+                       break;
+               case RTE_FLOW_ITEM_TYPE_IPV4:
+                       filter->ip_type = I40E_TUNNEL_IPTYPE_IPV4;
+                       /* IPv4 is used to describe protocol,
+                        * spec and mask should be NULL.
+                        */
+                       if (item->spec || item->mask) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid IPv4 item");
+                               return -rte_errno;
+                       }
+
+                       break;
+               case RTE_FLOW_ITEM_TYPE_IPV6:
+                       filter->ip_type = I40E_TUNNEL_IPTYPE_IPV6;
+                       /* IPv6 is used to describe protocol,
+                        * spec and mask should be NULL.
+                        */
+                       if (item->spec || item->mask) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid IPv6 item");
+                               return -rte_errno;
+                       }
+
+                       break;
+               case RTE_FLOW_ITEM_TYPE_UDP:
+                       udp_spec = item->spec;
+                       udp_mask = item->mask;
+
+                       if (!udp_spec || !udp_mask) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid udp item");
+                               return -rte_errno;
+                       }
+
+                       if (udp_spec->hdr.src_port != 0 &&
+                           udp_spec->hdr.dst_port != 0) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid udp spec");
+                               return -rte_errno;
+                       }
+
+                       if (udp_spec->hdr.src_port != 0) {
+                               filter->l4_port_type =
+                                       I40E_L4_PORT_TYPE_SRC;
+                               filter->tenant_id =
+                               rte_be_to_cpu_32(udp_spec->hdr.src_port);
+                       }
+
+                       if (udp_spec->hdr.dst_port != 0) {
+                               filter->l4_port_type =
+                                       I40E_L4_PORT_TYPE_DST;
+                               filter->tenant_id =
+                               rte_be_to_cpu_32(udp_spec->hdr.dst_port);
+                       }
+
+                       filter->tunnel_type = I40E_CLOUD_TYPE_UDP;
+
+                       break;
+               case RTE_FLOW_ITEM_TYPE_TCP:
+                       tcp_spec = item->spec;
+                       tcp_mask = item->mask;
+
+                       if (!tcp_spec || !tcp_mask) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid tcp item");
+                               return -rte_errno;
+                       }
+
+                       if (tcp_spec->hdr.src_port != 0 &&
+                           tcp_spec->hdr.dst_port != 0) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid tcp spec");
+                               return -rte_errno;
+                       }
+
+                       if (tcp_spec->hdr.src_port != 0) {
+                               filter->l4_port_type =
+                                       I40E_L4_PORT_TYPE_SRC;
+                               filter->tenant_id =
+                               rte_be_to_cpu_32(tcp_spec->hdr.src_port);
+                       }
+
+                       if (tcp_spec->hdr.dst_port != 0) {
+                               filter->l4_port_type =
+                                       I40E_L4_PORT_TYPE_DST;
+                               filter->tenant_id =
+                               rte_be_to_cpu_32(tcp_spec->hdr.dst_port);
+                       }
+
+                       filter->tunnel_type = I40E_CLOUD_TYPE_TCP;
+
+                       break;
+               case RTE_FLOW_ITEM_TYPE_SCTP:
+                       sctp_spec = item->spec;
+                       sctp_mask = item->mask;
+
+                       if (!sctp_spec || !sctp_mask) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid sctp item");
+                               return -rte_errno;
+                       }
+
+                       if (sctp_spec->hdr.src_port != 0 &&
+                           sctp_spec->hdr.dst_port != 0) {
+                               rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid sctp spec");
+                               return -rte_errno;
+                       }
+
+                       if (sctp_spec->hdr.src_port != 0) {
+                               filter->l4_port_type =
+                                       I40E_L4_PORT_TYPE_SRC;
+                               filter->tenant_id =
+                                       rte_be_to_cpu_32(sctp_spec->hdr.src_port);
+                       }
+
+                       if (sctp_spec->hdr.dst_port != 0) {
+                               filter->l4_port_type =
+                                       I40E_L4_PORT_TYPE_DST;
+                               filter->tenant_id =
+                                       rte_be_to_cpu_32(sctp_spec->hdr.dst_port);
+                       }
+
+                       filter->tunnel_type = I40E_CLOUD_TYPE_SCTP;
+
+                       break;
+               default:
+                       break;
+               }
+       }
+
+       return 0;
+}
+
+static int
+i40e_flow_parse_l4_cloud_filter(struct rte_eth_dev *dev,
+                               const struct rte_flow_attr *attr,
+                               const struct rte_flow_item pattern[],
+                               const struct rte_flow_action actions[],
+                               struct rte_flow_error *error,
+                               union i40e_filter_t *filter)
+{
+       struct i40e_tunnel_filter_conf *tunnel_filter =
+               &filter->consistent_tunnel_filter;
+       int ret;
+
+       ret = i40e_flow_parse_l4_pattern(pattern, error, tunnel_filter);
+       if (ret)
+               return ret;
+
+       ret = i40e_flow_parse_tunnel_action(dev, actions, error, tunnel_filter);
+       if (ret)
+               return ret;
+
+       ret = i40e_flow_parse_attr(attr, error);
+       if (ret)
+               return ret;
+
+       cons_filter_type = RTE_ETH_FILTER_TUNNEL;
+
+       return ret;
+}
+
 static uint16_t i40e_supported_tunnel_filter_types[] = {
        ETH_TUNNEL_FILTER_IMAC | ETH_TUNNEL_FILTER_TENID |
        ETH_TUNNEL_FILTER_IVLAN,
@@ -3228,8 +3663,8 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev,
                item_type = item->type;
                switch (item_type) {
                case RTE_FLOW_ITEM_TYPE_ETH:
-                       eth_spec = (const struct rte_flow_item_eth *)item->spec;
-                       eth_mask = (const struct rte_flow_item_eth *)item->mask;
+                       eth_spec = item->spec;
+                       eth_mask = item->mask;
 
                        /* Check if ETH item is used for place holder.
                         * If yes, both spec and mask should be NULL.
@@ -3248,8 +3683,8 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev,
                                /* DST address of inner MAC shouldn't be masked.
                                 * SRC address of Inner MAC should be masked.
                                 */
-                               if (!is_broadcast_ether_addr(&eth_mask->dst) ||
-                                   !is_zero_ether_addr(&eth_mask->src) ||
+                               if (!rte_is_broadcast_ether_addr(&eth_mask->dst) ||
+                                   !rte_is_zero_ether_addr(&eth_mask->src) ||
                                    eth_mask->type) {
                                        rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
@@ -3261,22 +3696,21 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev,
                                if (!vxlan_flag) {
                                        rte_memcpy(&filter->outer_mac,
                                                   &eth_spec->dst,
-                                                  ETHER_ADDR_LEN);
+                                                  RTE_ETHER_ADDR_LEN);
                                        filter_type |= ETH_TUNNEL_FILTER_OMAC;
                                } else {
                                        rte_memcpy(&filter->inner_mac,
                                                   &eth_spec->dst,
-                                                  ETHER_ADDR_LEN);
+                                                  RTE_ETHER_ADDR_LEN);
                                        filter_type |= ETH_TUNNEL_FILTER_IMAC;
                                }
                        }
                        break;
                case RTE_FLOW_ITEM_TYPE_VLAN:
-                       vlan_spec =
-                               (const struct rte_flow_item_vlan *)item->spec;
-                       vlan_mask =
-                               (const struct rte_flow_item_vlan *)item->mask;
-                       if (!(vlan_spec && vlan_mask)) {
+                       vlan_spec = item->spec;
+                       vlan_mask = item->mask;
+                       if (!(vlan_spec && vlan_mask) ||
+                           vlan_mask->inner_type) {
                                rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
                                                   item,
@@ -3286,10 +3720,10 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev,
 
                        if (vlan_spec && vlan_mask) {
                                if (vlan_mask->tci ==
-                                   rte_cpu_to_be_16(I40E_TCI_MASK))
+                                   rte_cpu_to_be_16(I40E_VLAN_TCI_MASK))
                                        filter->inner_vlan =
                                              rte_be_to_cpu_16(vlan_spec->tci) &
-                                             I40E_TCI_MASK;
+                                             I40E_VLAN_TCI_MASK;
                                filter_type |= ETH_TUNNEL_FILTER_IVLAN;
                        }
                        break;
@@ -3332,10 +3766,8 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev,
                        }
                        break;
                case RTE_FLOW_ITEM_TYPE_VXLAN:
-                       vxlan_spec =
-                               (const struct rte_flow_item_vxlan *)item->spec;
-                       vxlan_mask =
-                               (const struct rte_flow_item_vxlan *)item->mask;
+                       vxlan_spec = item->spec;
+                       vxlan_mask = item->mask;
                        /* Check if VXLAN item is used to describe protocol.
                         * If yes, both spec and mask should be NULL.
                         * If no, both spec and mask shouldn't be NULL.
@@ -3461,8 +3893,8 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev,
                item_type = item->type;
                switch (item_type) {
                case RTE_FLOW_ITEM_TYPE_ETH:
-                       eth_spec = (const struct rte_flow_item_eth *)item->spec;
-                       eth_mask = (const struct rte_flow_item_eth *)item->mask;
+                       eth_spec = item->spec;
+                       eth_mask = item->mask;
 
                        /* Check if ETH item is used for place holder.
                         * If yes, both spec and mask should be NULL.
@@ -3481,8 +3913,8 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev,
                                /* DST address of inner MAC shouldn't be masked.
                                 * SRC address of Inner MAC should be masked.
                                 */
-                               if (!is_broadcast_ether_addr(&eth_mask->dst) ||
-                                   !is_zero_ether_addr(&eth_mask->src) ||
+                               if (!rte_is_broadcast_ether_addr(&eth_mask->dst) ||
+                                   !rte_is_zero_ether_addr(&eth_mask->src) ||
                                    eth_mask->type) {
                                        rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
@@ -3494,23 +3926,22 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev,
                                if (!nvgre_flag) {
                                        rte_memcpy(&filter->outer_mac,
                                                   &eth_spec->dst,
-                                                  ETHER_ADDR_LEN);
+                                                  RTE_ETHER_ADDR_LEN);
                                        filter_type |= ETH_TUNNEL_FILTER_OMAC;
                                } else {
                                        rte_memcpy(&filter->inner_mac,
                                                   &eth_spec->dst,
-                                                  ETHER_ADDR_LEN);
+                                                  RTE_ETHER_ADDR_LEN);
                                        filter_type |= ETH_TUNNEL_FILTER_IMAC;
                                }
                        }
 
                        break;
                case RTE_FLOW_ITEM_TYPE_VLAN:
-                       vlan_spec =
-                               (const struct rte_flow_item_vlan *)item->spec;
-                       vlan_mask =
-                               (const struct rte_flow_item_vlan *)item->mask;
-                       if (!(vlan_spec && vlan_mask)) {
+                       vlan_spec = item->spec;
+                       vlan_mask = item->mask;
+                       if (!(vlan_spec && vlan_mask) ||
+                           vlan_mask->inner_type) {
                                rte_flow_error_set(error, EINVAL,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
                                                   item,
@@ -3520,10 +3951,10 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev,
 
                        if (vlan_spec && vlan_mask) {
                                if (vlan_mask->tci ==
-                                   rte_cpu_to_be_16(I40E_TCI_MASK))
+                                   rte_cpu_to_be_16(I40E_VLAN_TCI_MASK))
                                        filter->inner_vlan =
                                              rte_be_to_cpu_16(vlan_spec->tci) &
-                                             I40E_TCI_MASK;
+                                             I40E_VLAN_TCI_MASK;
                                filter_type |= ETH_TUNNEL_FILTER_IVLAN;
                        }
                        break;
@@ -3554,10 +3985,8 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev,
                        }
                        break;
                case RTE_FLOW_ITEM_TYPE_NVGRE:
-                       nvgre_spec =
-                               (const struct rte_flow_item_nvgre *)item->spec;
-                       nvgre_mask =
-                               (const struct rte_flow_item_nvgre *)item->mask;
+                       nvgre_spec = item->spec;
+                       nvgre_mask = item->mask;
                        /* Check if NVGRE item is used to describe protocol.
                         * If yes, both spec and mask should be NULL.
                         * If no, both spec and mask shouldn't be NULL.
@@ -3582,6 +4011,41 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev,
                                                       "Invalid TNI mask");
                                        return -rte_errno;
                                }
+                               if (nvgre_mask->protocol &&
+                                       nvgre_mask->protocol != 0xFFFF) {
+                                       rte_flow_error_set(error, EINVAL,
+                                               RTE_FLOW_ERROR_TYPE_ITEM,
+                                               item,
+                                               "Invalid NVGRE item");
+                                       return -rte_errno;
+                               }
+                               if (nvgre_mask->c_k_s_rsvd0_ver &&
+                                       nvgre_mask->c_k_s_rsvd0_ver !=
+                                       rte_cpu_to_be_16(0xFFFF)) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid NVGRE item");
+                                       return -rte_errno;
+                               }
+                               if (nvgre_spec->c_k_s_rsvd0_ver !=
+                                       rte_cpu_to_be_16(0x2000) &&
+                                       nvgre_mask->c_k_s_rsvd0_ver) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid NVGRE item");
+                                       return -rte_errno;
+                               }
+                               if (nvgre_mask->protocol &&
+                                       nvgre_spec->protocol !=
+                                       rte_cpu_to_be_16(0x6558)) {
+                                       rte_flow_error_set(error, EINVAL,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  item,
+                                                  "Invalid NVGRE item");
+                                       return -rte_errno;
+                               }
                                rte_memcpy(((uint8_t *)&tenant_id_be + 1),
                                           nvgre_spec->tni, 3);
                                filter->tenant_id =
@@ -3733,10 +4197,8 @@ i40e_flow_parse_mpls_pattern(__rte_unused struct rte_eth_dev *dev,
                        }
                        break;
                case RTE_FLOW_ITEM_TYPE_MPLS:
-                       mpls_spec =
-                               (const struct rte_flow_item_mpls *)item->spec;
-                       mpls_mask =
-                               (const struct rte_flow_item_mpls *)item->mask;
+                       mpls_spec = item->spec;
+                       mpls_mask = item->mask;
 
                        if (!mpls_spec || !mpls_mask) {
                                rte_flow_error_set(error, EINVAL,
@@ -3872,10 +4334,8 @@ i40e_flow_parse_gtp_pattern(struct rte_eth_dev *dev,
                        break;
                case RTE_FLOW_ITEM_TYPE_GTPC:
                case RTE_FLOW_ITEM_TYPE_GTPU:
-                       gtp_spec =
-                               (const struct rte_flow_item_gtp *)item->spec;
-                       gtp_mask =
-                               (const struct rte_flow_item_gtp *)item->mask;
+                       gtp_spec = item->spec;
+                       gtp_mask = item->mask;
 
                        if (!gtp_spec || !gtp_mask) {
                                rte_flow_error_set(error, EINVAL,
@@ -3986,12 +4446,11 @@ i40e_flow_parse_qinq_pattern(__rte_unused struct rte_eth_dev *dev,
                        }
                        break;
                case RTE_FLOW_ITEM_TYPE_VLAN:
-                       vlan_spec =
-                               (const struct rte_flow_item_vlan *)item->spec;
-                       vlan_mask =
-                               (const struct rte_flow_item_vlan *)item->mask;
+                       vlan_spec = item->spec;
+                       vlan_mask = item->mask;
 
-                       if (!(vlan_spec && vlan_mask)) {
+                       if (!(vlan_spec && vlan_mask) ||
+                           vlan_mask->inner_type) {
                                rte_flow_error_set(error, EINVAL,
                                           RTE_FLOW_ERROR_TYPE_ITEM,
                                           item,
@@ -4016,14 +4475,9 @@ i40e_flow_parse_qinq_pattern(__rte_unused struct rte_eth_dev *dev,
        }
 
        /* Get filter specification */
-       if ((o_vlan_mask != NULL) && (o_vlan_mask->tci ==
-                       rte_cpu_to_be_16(I40E_TCI_MASK)) &&
-                       (i_vlan_mask != NULL) &&
-                       (i_vlan_mask->tci == rte_cpu_to_be_16(I40E_TCI_MASK))) {
-               filter->outer_vlan = rte_be_to_cpu_16(o_vlan_spec->tci)
-                       & I40E_TCI_MASK;
-               filter->inner_vlan = rte_be_to_cpu_16(i_vlan_spec->tci)
-                       & I40E_TCI_MASK;
+       if (o_vlan_mask != NULL &&  i_vlan_mask != NULL) {
+               filter->outer_vlan = rte_be_to_cpu_16(o_vlan_spec->tci);
+               filter->inner_vlan = rte_be_to_cpu_16(i_vlan_spec->tci);
        } else {
                        rte_flow_error_set(error, EINVAL,
                                           RTE_FLOW_ERROR_TYPE_ITEM,
@@ -4099,9 +4553,23 @@ i40e_flow_validate(struct rte_eth_dev *dev,
                                   NULL, "NULL attribute.");
                return -rte_errno;
        }
-
        memset(&cons_filter, 0, sizeof(cons_filter));
 
+       /* Get the non-void item of action */
+       while ((actions + i)->type == RTE_FLOW_ACTION_TYPE_VOID)
+               i++;
+
+       if ((actions + i)->type == RTE_FLOW_ACTION_TYPE_RSS) {
+               ret = i40e_flow_parse_attr(attr, error);
+               if (ret)
+                       return ret;
+
+               cons_filter_type = RTE_ETH_FILTER_HASH;
+               return i40e_hash_parse(dev, pattern, actions + i,
+                                      &cons_filter.rss_conf, error);
+       }
+
+       i = 0;
        /* Get the non-void item number of pattern */
        while ((pattern + i)->type != RTE_FLOW_ITEM_TYPE_END) {
                if ((pattern + i)->type != RTE_FLOW_ITEM_TYPE_VOID)
@@ -4110,12 +4578,18 @@ i40e_flow_validate(struct rte_eth_dev *dev,
        }
        item_num++;
 
-       items = rte_zmalloc("i40e_pattern",
-                           item_num * sizeof(struct rte_flow_item), 0);
-       if (!items) {
-               rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_ITEM_NUM,
-                                  NULL, "No memory for PMD internal items.");
-               return -ENOMEM;
+       if (item_num <= ARRAY_SIZE(g_items)) {
+               items = g_items;
+       } else {
+               items = rte_zmalloc("i40e_pattern",
+                                   item_num * sizeof(struct rte_flow_item), 0);
+               if (!items) {
+                       rte_flow_error_set(error, ENOMEM,
+                                       RTE_FLOW_ERROR_TYPE_ITEM_NUM,
+                                       NULL,
+                                       "No memory for PMD internal items.");
+                       return -ENOMEM;
+               }
        }
 
        i40e_pattern_skip_void_item(items, pattern);
@@ -4127,16 +4601,21 @@ i40e_flow_validate(struct rte_eth_dev *dev,
                        rte_flow_error_set(error, EINVAL,
                                           RTE_FLOW_ERROR_TYPE_ITEM,
                                           pattern, "Unsupported pattern");
-                       rte_free(items);
+
+                       if (items != g_items)
+                               rte_free(items);
                        return -rte_errno;
                }
+
                if (parse_filter)
                        ret = parse_filter(dev, attr, items, actions,
                                           error, &cons_filter);
+
                flag = true;
        } while ((ret < 0) && (i < RTE_DIM(i40e_supported_patterns)));
 
-       rte_free(items);
+       if (items != g_items)
+               rte_free(items);
 
        return ret;
 }
@@ -4149,21 +4628,33 @@ i40e_flow_create(struct rte_eth_dev *dev,
                 struct rte_flow_error *error)
 {
        struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       struct rte_flow *flow;
+       struct rte_flow *flow = NULL;
+       struct i40e_fdir_info *fdir_info = &pf->fdir;
        int ret;
 
-       flow = rte_zmalloc("i40e_flow", sizeof(struct rte_flow), 0);
-       if (!flow) {
-               rte_flow_error_set(error, ENOMEM,
-                                  RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
-                                  "Failed to allocate memory");
-               return flow;
-       }
-
        ret = i40e_flow_validate(dev, attr, pattern, actions, error);
        if (ret < 0)
                return NULL;
 
+       if (cons_filter_type == RTE_ETH_FILTER_FDIR) {
+               flow = i40e_fdir_entry_pool_get(fdir_info);
+               if (flow == NULL) {
+                       rte_flow_error_set(error, ENOBUFS,
+                          RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
+                          "Fdir space full");
+
+                       return flow;
+               }
+       } else {
+               flow = rte_zmalloc("i40e_flow", sizeof(struct rte_flow), 0);
+               if (!flow) {
+                       rte_flow_error_set(error, ENOMEM,
+                                          RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
+                                          "Failed to allocate memory");
+                       return flow;
+               }
+       }
+
        switch (cons_filter_type) {
        case RTE_ETH_FILTER_ETHERTYPE:
                ret = i40e_ethertype_filter_set(pf,
@@ -4175,7 +4666,7 @@ i40e_flow_create(struct rte_eth_dev *dev,
                break;
        case RTE_ETH_FILTER_FDIR:
                ret = i40e_flow_add_del_fdir_filter(dev,
-                                      &cons_filter.fdir_filter, 1);
+                              &cons_filter.fdir_filter, 1);
                if (ret)
                        goto free_flow;
                flow->rule = TAILQ_LAST(&pf->fdir.fdir_list,
@@ -4189,6 +4680,13 @@ i40e_flow_create(struct rte_eth_dev *dev,
                flow->rule = TAILQ_LAST(&pf->tunnel.tunnel_list,
                                        i40e_tunnel_filter_list);
                break;
+       case RTE_ETH_FILTER_HASH:
+               ret = i40e_hash_filter_create(pf, &cons_filter.rss_conf);
+               if (ret)
+                       goto free_flow;
+               flow->rule = TAILQ_LAST(&pf->rss_config_list,
+                                       i40e_rss_conf_list);
+               break;
        default:
                goto free_flow;
        }
@@ -4201,7 +4699,12 @@ free_flow:
        rte_flow_error_set(error, -ret,
                           RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
                           "Failed to create flow.");
-       rte_free(flow);
+
+       if (cons_filter_type != RTE_ETH_FILTER_FDIR)
+               rte_free(flow);
+       else
+               i40e_fdir_entry_pool_put(fdir_info, flow);
+
        return NULL;
 }
 
@@ -4212,6 +4715,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
 {
        struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        enum rte_filter_type filter_type = flow->filter_type;
+       struct i40e_fdir_info *fdir_info = &pf->fdir;
        int ret = 0;
 
        switch (filter_type) {
@@ -4225,7 +4729,16 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
                break;
        case RTE_ETH_FILTER_FDIR:
                ret = i40e_flow_add_del_fdir_filter(dev,
-                      &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
+                               &((struct i40e_fdir_filter *)flow->rule)->fdir,
+                               0);
+
+               /* If the last flow is destroyed, disable fdir. */
+               if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {
+                       i40e_fdir_rx_proc_enable(dev, 0);
+               }
+               break;
+       case RTE_ETH_FILTER_HASH:
+               ret = i40e_hash_filter_destroy(pf, flow->rule);
                break;
        default:
                PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
@@ -4236,7 +4749,11 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
 
        if (!ret) {
                TAILQ_REMOVE(&pf->flow_list, flow, node);
-               rte_free(flow);
+               if (filter_type == RTE_ETH_FILTER_FDIR)
+                       i40e_fdir_entry_pool_put(fdir_info, flow);
+               else
+                       rte_free(flow);
+
        } else
                rte_flow_error_set(error, -ret,
                                   RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
@@ -4287,17 +4804,17 @@ i40e_flow_destroy_tunnel_filter(struct i40e_pf *pf,
        struct i40e_hw *hw = I40E_PF_TO_HW(pf);
        struct i40e_vsi *vsi;
        struct i40e_pf_vf *vf;
-       struct i40e_aqc_add_rm_cloud_filt_elem_ext cld_filter;
+       struct i40e_aqc_cloud_filters_element_bb cld_filter;
        struct i40e_tunnel_rule *tunnel_rule = &pf->tunnel;
        struct i40e_tunnel_filter *node;
        bool big_buffer = 0;
        int ret = 0;
 
        memset(&cld_filter, 0, sizeof(cld_filter));
-       ether_addr_copy((struct ether_addr *)&filter->input.outer_mac,
-                       (struct ether_addr *)&cld_filter.element.outer_mac);
-       ether_addr_copy((struct ether_addr *)&filter->input.inner_mac,
-                       (struct ether_addr *)&cld_filter.element.inner_mac);
+       rte_ether_addr_copy((struct rte_ether_addr *)&filter->input.outer_mac,
+                       (struct rte_ether_addr *)&cld_filter.element.outer_mac);
+       rte_ether_addr_copy((struct rte_ether_addr *)&filter->input.inner_mac,
+                       (struct rte_ether_addr *)&cld_filter.element.inner_mac);
        cld_filter.element.inner_vlan = filter->input.inner_vlan;
        cld_filter.element.flags = filter->input.flags;
        cld_filter.element.tenant_id = filter->input.tenant_id;
@@ -4322,11 +4839,11 @@ i40e_flow_destroy_tunnel_filter(struct i40e_pf *pf,
                big_buffer = 1;
 
        if (big_buffer)
-               ret = i40e_aq_remove_cloud_filters_big_buffer(hw, vsi->seid,
-                                                             &cld_filter, 1);
+               ret = i40e_aq_rem_cloud_filters_bb(hw, vsi->seid,
+                                               &cld_filter, 1);
        else
-               ret = i40e_aq_remove_cloud_filters(hw, vsi->seid,
-                                                  &cld_filter.element, 1);
+               ret = i40e_aq_rem_cloud_filters(hw, vsi->seid,
+                                               &cld_filter.element, 1);
        if (ret < 0)
                return -ENOTSUP;
 
@@ -4369,6 +4886,11 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
                return -rte_errno;
        }
 
+       ret = i40e_hash_filter_flush(pf);
+       if (ret)
+               rte_flow_error_set(error, -ret,
+                                  RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
+                                  "Failed to flush RSS flows.");
        return ret;
 }
 
@@ -4378,9 +4900,11 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
        struct rte_eth_dev *dev = pf->adapter->eth_dev;
        struct i40e_fdir_info *fdir_info = &pf->fdir;
        struct i40e_fdir_filter *fdir_filter;
+       enum i40e_filter_pctype pctype;
        struct rte_flow *flow;
        void *temp;
        int ret;
+       uint32_t i = 0;
 
        ret = i40e_fdir_flush(dev);
        if (!ret) {
@@ -4396,9 +4920,35 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
                TAILQ_FOREACH_SAFE(flow, &pf->flow_list, node, temp) {
                        if (flow->filter_type == RTE_ETH_FILTER_FDIR) {
                                TAILQ_REMOVE(&pf->flow_list, flow, node);
-                               rte_free(flow);
                        }
                }
+
+               /* reset bitmap */
+               rte_bitmap_reset(fdir_info->fdir_flow_pool.bitmap);
+               for (i = 0; i < fdir_info->fdir_space_size; i++) {
+                       fdir_info->fdir_flow_pool.pool[i].idx = i;
+                       rte_bitmap_set(fdir_info->fdir_flow_pool.bitmap, i);
+               }
+
+               fdir_info->fdir_actual_cnt = 0;
+               fdir_info->fdir_guarantee_free_space =
+                       fdir_info->fdir_guarantee_total_space;
+               memset(fdir_info->fdir_filter_array,
+                       0,
+                       sizeof(struct i40e_fdir_filter) *
+                       I40E_MAX_FDIR_FILTER_NUM);
+
+               for (pctype = I40E_FILTER_PCTYPE_NONF_IPV4_UDP;
+                    pctype <= I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) {
+                       pf->fdir.inset_flag[pctype] = 0;
+                       pf->fdir.flex_mask_flag[pctype] = 0;
+               }
+
+               for (i = 0; i < I40E_MAX_FLXPLD_LAYER; i++)
+                       pf->fdir.flex_pit_flag[i] = 0;
+
+               /* Disable FDIR processing as all FDIR rules are now flushed */
+               i40e_fdir_rx_proc_enable(dev, 0);
        }
 
        return ret;
@@ -4459,3 +5009,47 @@ i40e_flow_flush_tunnel_filter(struct i40e_pf *pf)
 
        return ret;
 }
+
+static int
+i40e_flow_query(struct rte_eth_dev *dev __rte_unused,
+               struct rte_flow *flow,
+               const struct rte_flow_action *actions,
+               void *data, struct rte_flow_error *error)
+{
+       struct i40e_rss_filter *rss_rule = (struct i40e_rss_filter *)flow->rule;
+       enum rte_filter_type filter_type = flow->filter_type;
+       struct rte_flow_action_rss *rss_conf = data;
+
+       if (!rss_rule) {
+               rte_flow_error_set(error, EINVAL,
+                                  RTE_FLOW_ERROR_TYPE_HANDLE,
+                                  NULL, "Invalid rule");
+               return -rte_errno;
+       }
+
+       for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
+               switch (actions->type) {
+               case RTE_FLOW_ACTION_TYPE_VOID:
+                       break;
+               case RTE_FLOW_ACTION_TYPE_RSS:
+                       if (filter_type != RTE_ETH_FILTER_HASH) {
+                               rte_flow_error_set(error, ENOTSUP,
+                                                  RTE_FLOW_ERROR_TYPE_ACTION,
+                                                  actions,
+                                                  "action not supported");
+                               return -rte_errno;
+                       }
+                       rte_memcpy(rss_conf,
+                                  &rss_rule->rss_filter_info.conf,
+                                  sizeof(struct rte_flow_action_rss));
+                       break;
+               default:
+                       return rte_flow_error_set(error, ENOTSUP,
+                                                 RTE_FLOW_ERROR_TYPE_ACTION,
+                                                 actions,
+                                                 "action not supported");
+               }
+       }
+
+       return 0;
+}