net/ice: enable switch filter
[dpdk.git] / drivers / net / ice / ice_ethdev.c
index c230445..b50ec50 100644 (file)
@@ -58,9 +58,9 @@ static int ice_vlan_filter_set(struct rte_eth_dev *dev,
                               uint16_t vlan_id,
                               int on);
 static int ice_macaddr_set(struct rte_eth_dev *dev,
-                          struct ether_addr *mac_addr);
+                          struct rte_ether_addr *mac_addr);
 static int ice_macaddr_add(struct rte_eth_dev *dev,
-                          struct ether_addr *mac_addr,
+                          struct rte_ether_addr *mac_addr,
                           __rte_unused uint32_t index,
                           uint32_t pool);
 static void ice_macaddr_remove(struct rte_eth_dev *dev, uint32_t index);
@@ -153,13 +153,13 @@ static const struct ice_xstats_name_off ice_stats_strings[] = {
        {"rx_unicast_packets", offsetof(struct ice_eth_stats, rx_unicast)},
        {"rx_multicast_packets", offsetof(struct ice_eth_stats, rx_multicast)},
        {"rx_broadcast_packets", offsetof(struct ice_eth_stats, rx_broadcast)},
-       {"rx_dropped", offsetof(struct ice_eth_stats, rx_discards)},
+       {"rx_dropped_packets", offsetof(struct ice_eth_stats, rx_discards)},
        {"rx_unknown_protocol_packets", offsetof(struct ice_eth_stats,
                rx_unknown_protocol)},
        {"tx_unicast_packets", offsetof(struct ice_eth_stats, tx_unicast)},
        {"tx_multicast_packets", offsetof(struct ice_eth_stats, tx_multicast)},
        {"tx_broadcast_packets", offsetof(struct ice_eth_stats, tx_broadcast)},
-       {"tx_dropped", offsetof(struct ice_eth_stats, tx_discards)},
+       {"tx_dropped_packets", offsetof(struct ice_eth_stats, tx_discards)},
 };
 
 #define ICE_NB_ETH_XSTATS (sizeof(ice_stats_strings) / \
@@ -485,35 +485,38 @@ ice_init_mac_address(struct rte_eth_dev *dev)
 {
        struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-       if (!is_unicast_ether_addr
-               ((struct ether_addr *)hw->port_info[0].mac.lan_addr)) {
+       if (!rte_is_unicast_ether_addr
+               ((struct rte_ether_addr *)hw->port_info[0].mac.lan_addr)) {
                PMD_INIT_LOG(ERR, "Invalid MAC address");
                return -EINVAL;
        }
 
-       ether_addr_copy((struct ether_addr *)hw->port_info[0].mac.lan_addr,
-                       (struct ether_addr *)hw->port_info[0].mac.perm_addr);
+       rte_ether_addr_copy(
+               (struct rte_ether_addr *)hw->port_info[0].mac.lan_addr,
+               (struct rte_ether_addr *)hw->port_info[0].mac.perm_addr);
 
-       dev->data->mac_addrs = rte_zmalloc(NULL, sizeof(struct ether_addr), 0);
+       dev->data->mac_addrs =
+               rte_zmalloc(NULL, sizeof(struct rte_ether_addr), 0);
        if (!dev->data->mac_addrs) {
                PMD_INIT_LOG(ERR,
                             "Failed to allocate memory to store mac address");
                return -ENOMEM;
        }
        /* store it to dev data */
-       ether_addr_copy((struct ether_addr *)hw->port_info[0].mac.perm_addr,
-                       &dev->data->mac_addrs[0]);
+       rte_ether_addr_copy(
+               (struct rte_ether_addr *)hw->port_info[0].mac.perm_addr,
+               &dev->data->mac_addrs[0]);
        return 0;
 }
 
 /* Find out specific MAC filter */
 static struct ice_mac_filter *
-ice_find_mac_filter(struct ice_vsi *vsi, struct ether_addr *macaddr)
+ice_find_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *macaddr)
 {
        struct ice_mac_filter *f;
 
        TAILQ_FOREACH(f, &vsi->mac_list, next) {
-               if (is_same_ether_addr(macaddr, &f->mac_info.mac_addr))
+               if (rte_is_same_ether_addr(macaddr, &f->mac_info.mac_addr))
                        return f;
        }
 
@@ -521,7 +524,7 @@ ice_find_mac_filter(struct ice_vsi *vsi, struct ether_addr *macaddr)
 }
 
 static int
-ice_add_mac_filter(struct ice_vsi *vsi, struct ether_addr *mac_addr)
+ice_add_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)
 {
        struct ice_fltr_list_entry *m_list_itr = NULL;
        struct ice_mac_filter *f;
@@ -580,7 +583,7 @@ DONE:
 }
 
 static int
-ice_remove_mac_filter(struct ice_vsi *vsi, struct ether_addr *mac_addr)
+ice_remove_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)
 {
        struct ice_fltr_list_entry *m_list_itr = NULL;
        struct ice_mac_filter *f;
@@ -653,7 +656,7 @@ ice_add_vlan_filter(struct ice_vsi *vsi, uint16_t vlan_id)
        struct ice_hw *hw;
        int ret = 0;
 
-       if (!vsi || vlan_id > ETHER_MAX_VLAN_ID)
+       if (!vsi || vlan_id > RTE_ETHER_MAX_VLAN_ID)
                return -EINVAL;
 
        hw = ICE_VSI_TO_HW(vsi);
@@ -724,7 +727,7 @@ ice_remove_vlan_filter(struct ice_vsi *vsi, uint16_t vlan_id)
         * Vlan 0 is the generic filter for untagged packets
         * and can't be removed.
         */
-       if (!vsi || vlan_id == 0 || vlan_id > ETHER_MAX_VLAN_ID)
+       if (!vsi || vlan_id == 0 || vlan_id > RTE_ETHER_MAX_VLAN_ID)
                return -EINVAL;
 
        hw = ICE_VSI_TO_HW(vsi);
@@ -1133,9 +1136,9 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
        struct ice_vsi *vsi = NULL;
        struct ice_vsi_ctx vsi_ctx;
        int ret;
-       struct ether_addr broadcast = {
+       struct rte_ether_addr broadcast = {
                .addr_bytes = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff} };
-       struct ether_addr mac_addr;
+       struct rte_ether_addr mac_addr;
        uint16_t max_txqs[ICE_MAX_TRAFFIC_CLASS] = { 0 };
        uint8_t tc_bitmap = 0x1;
 
@@ -1154,6 +1157,12 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
        TAILQ_INIT(&vsi->mac_list);
        TAILQ_INIT(&vsi->vlan_list);
 
+       /* Be sync with ETH_RSS_RETA_SIZE_x maximum value definition */
+       pf->hash_lut_size = hw->func_caps.common_cap.rss_table_size >
+                       ETH_RSS_RETA_SIZE_512 ? ETH_RSS_RETA_SIZE_512 :
+                       hw->func_caps.common_cap.rss_table_size;
+       pf->flags |= ICE_FLAG_RSS_AQ_CAPABLE;
+
        memset(&vsi_ctx, 0, sizeof(vsi_ctx));
        /* base_queue in used in queue mapping of VSI add/update command.
         * Suppose vsi->base_queue is 0 now, don't consider SRIOV, VMDQ
@@ -1226,12 +1235,12 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
                   hw->port_info->mac.perm_addr,
                   ETH_ADDR_LEN);
 
-       rte_memcpy(&mac_addr, &pf->dev_addr, ETHER_ADDR_LEN);
+       rte_memcpy(&mac_addr, &pf->dev_addr, RTE_ETHER_ADDR_LEN);
        ret = ice_add_mac_filter(vsi, &mac_addr);
        if (ret != ICE_SUCCESS)
                PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter");
 
-       rte_memcpy(&mac_addr, &broadcast, ETHER_ADDR_LEN);
+       rte_memcpy(&mac_addr, &broadcast, RTE_ETHER_ADDR_LEN);
        ret = ice_add_mac_filter(vsi, &mac_addr);
        if (ret != ICE_SUCCESS)
                PMD_INIT_LOG(ERR, "Failed to add MAC filter");
@@ -1355,6 +1364,21 @@ fail_exit:
        return err;
 }
 
+static void
+ice_base_queue_get(struct ice_pf *pf)
+{
+       uint32_t reg;
+       struct ice_hw *hw = ICE_PF_TO_HW(pf);
+
+       reg = ICE_READ_REG(hw, PFLAN_RX_QALLOC);
+       if (reg & PFLAN_RX_QALLOC_VALID_M) {
+               pf->base_queue = reg & PFLAN_RX_QALLOC_FIRSTQ_M;
+       } else {
+               PMD_INIT_LOG(WARNING, "Failed to get Rx base queue"
+                                       " index");
+       }
+}
+
 static int
 ice_dev_init(struct rte_eth_dev *dev)
 {
@@ -1438,7 +1462,7 @@ ice_dev_init(struct rte_eth_dev *dev)
        /* Disable double vlan by default */
        ice_vsi_config_double_vlan(vsi, FALSE);
 
-       ret = ice_aq_stop_lldp(hw, TRUE, NULL);
+       ret = ice_aq_stop_lldp(hw, TRUE, FALSE, NULL);
        if (ret != ICE_SUCCESS)
                PMD_INIT_LOG(DEBUG, "lldp has already stopped\n");
 
@@ -1451,12 +1475,16 @@ ice_dev_init(struct rte_eth_dev *dev)
        /* enable uio intr after callback register */
        rte_intr_enable(intr_handle);
 
+       /* get base queue pairs index  in the device */
+       ice_base_queue_get(pf);
+
        return 0;
 
 err_pf_setup:
        ice_res_pool_destroy(&pf->msix_pool);
 err_msix_pool_init:
        rte_free(dev->data->mac_addrs);
+       dev->data->mac_addrs = NULL;
 err_init_mac:
        ice_sched_cleanup_all(hw);
        rte_free(hw->port_info);
@@ -1642,7 +1670,7 @@ static int ice_init_rss(struct ice_pf *pf)
        rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
        nb_q = dev->data->nb_rx_queues;
        vsi->rss_key_size = ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE;
-       vsi->rss_lut_size = hw->func_caps.common_cap.rss_table_size;
+       vsi->rss_lut_size = pf->hash_lut_size;
 
        if (is_safe_mode) {
                PMD_DRV_LOG(WARNING, "RSS is not supported in safe mode\n");
@@ -2016,7 +2044,7 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->max_mac_addrs = vsi->max_macaddrs;
        dev_info->max_vfs = pci_dev->max_vfs;
        dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
-       dev_info->min_mtu = ETHER_MIN_MTU;
+       dev_info->min_mtu = RTE_ETHER_MIN_MTU;
 
        dev_info->rx_offload_capa =
                DEV_RX_OFFLOAD_VLAN_STRIP |
@@ -2045,14 +2073,15 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
                        DEV_TX_OFFLOAD_UDP_CKSUM |
                        DEV_TX_OFFLOAD_TCP_CKSUM |
                        DEV_TX_OFFLOAD_SCTP_CKSUM |
-                       DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
+                       DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+                       DEV_TX_OFFLOAD_OUTER_UDP_CKSUM;
                dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
        }
 
        dev_info->rx_queue_offload_capa = 0;
        dev_info->tx_queue_offload_capa = 0;
 
-       dev_info->reta_size = hw->func_caps.common_cap.rss_table_size;
+       dev_info->reta_size = pf->hash_lut_size;
        dev_info->hash_key_size = (VSIQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t);
 
        dev_info->default_rxconf = (struct rte_eth_rxconf) {
@@ -2286,7 +2315,7 @@ ice_force_phys_link_state(struct ice_hw *hw, bool link_up)
        else
                cfg.caps &= ~ICE_AQ_PHY_ENA_LINK;
 
-       status = ice_aq_set_phy_cfg(hw, pi->lport, &cfg, NULL);
+       status = ice_aq_set_phy_cfg(hw, pi, &cfg, NULL);
 
 out:
        ice_free(hw, pcaps);
@@ -2317,7 +2346,7 @@ ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
        uint32_t frame_size = mtu + ICE_ETH_OVERHEAD;
 
        /* check if mtu is within the allowed range */
-       if (mtu < ETHER_MIN_MTU || frame_size > ICE_FRAME_SIZE_MAX)
+       if (mtu < RTE_ETHER_MIN_MTU || frame_size > ICE_FRAME_SIZE_MAX)
                return -EINVAL;
 
        /* mtu setting is forbidden if port is start */
@@ -2328,7 +2357,7 @@ ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
                return -EBUSY;
        }
 
-       if (frame_size > ETHER_MAX_LEN)
+       if (frame_size > RTE_ETHER_MAX_LEN)
                dev_data->dev_conf.rxmode.offloads |=
                        DEV_RX_OFFLOAD_JUMBO_FRAME;
        else
@@ -2341,7 +2370,7 @@ ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 }
 
 static int ice_macaddr_set(struct rte_eth_dev *dev,
-                          struct ether_addr *mac_addr)
+                          struct rte_ether_addr *mac_addr)
 {
        struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
@@ -2350,13 +2379,13 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
        uint8_t flags = 0;
        int ret;
 
-       if (!is_valid_assigned_ether_addr(mac_addr)) {
+       if (!rte_is_valid_assigned_ether_addr(mac_addr)) {
                PMD_DRV_LOG(ERR, "Tried to set invalid MAC address.");
                return -EINVAL;
        }
 
        TAILQ_FOREACH(f, &vsi->mac_list, next) {
-               if (is_same_ether_addr(&pf->dev_addr, &f->mac_info.mac_addr))
+               if (rte_is_same_ether_addr(&pf->dev_addr, &f->mac_info.mac_addr))
                        break;
        }
 
@@ -2388,7 +2417,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
 /* Add a MAC address, and update filters */
 static int
 ice_macaddr_add(struct rte_eth_dev *dev,
-               struct ether_addr *mac_addr,
+               struct rte_ether_addr *mac_addr,
                __rte_unused uint32_t index,
                __rte_unused uint32_t pool)
 {
@@ -2412,7 +2441,7 @@ ice_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        struct ice_vsi *vsi = pf->main_vsi;
        struct rte_eth_dev_data *data = dev->data;
-       struct ether_addr *macaddr;
+       struct rte_ether_addr *macaddr;
        int ret;
 
        macaddr = &data->mac_addrs[index];
@@ -2692,28 +2721,31 @@ ice_rss_reta_update(struct rte_eth_dev *dev,
                    uint16_t reta_size)
 {
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint16_t i, lut_size = hw->func_caps.common_cap.rss_table_size;
+       uint16_t i, lut_size = pf->hash_lut_size;
        uint16_t idx, shift;
        uint8_t *lut;
        int ret;
 
-       if (reta_size != lut_size ||
-           reta_size > ETH_RSS_RETA_SIZE_512) {
+       if (reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_128 &&
+           reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_512 &&
+           reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_2K) {
                PMD_DRV_LOG(ERR,
                            "The size of hash lookup table configured (%d)"
                            "doesn't match the number hardware can "
-                           "supported (%d)",
-                           reta_size, lut_size);
+                           "supported (128, 512, 2048)",
+                           reta_size);
                return -EINVAL;
        }
 
-       lut = rte_zmalloc(NULL, reta_size, 0);
+       /* It MUST use the current LUT size to get the RSS lookup table,
+        * otherwise if will fail with -100 error code.
+        */
+       lut = rte_zmalloc(NULL,  RTE_MAX(reta_size, lut_size), 0);
        if (!lut) {
                PMD_DRV_LOG(ERR, "No memory can be allocated");
                return -ENOMEM;
        }
-       ret = ice_get_rss_lut(pf->main_vsi, lut, reta_size);
+       ret = ice_get_rss_lut(pf->main_vsi, lut, lut_size);
        if (ret)
                goto out;
 
@@ -2724,6 +2756,12 @@ ice_rss_reta_update(struct rte_eth_dev *dev,
                        lut[i] = reta_conf[idx].reta[shift];
        }
        ret = ice_set_rss_lut(pf->main_vsi, lut, reta_size);
+       if (ret == 0 && lut_size != reta_size) {
+               PMD_DRV_LOG(INFO,
+                           "The size of hash lookup table is changed from (%d) to (%d)",
+                           lut_size, reta_size);
+               pf->hash_lut_size = reta_size;
+       }
 
 out:
        rte_free(lut);
@@ -2737,14 +2775,12 @@ ice_rss_reta_query(struct rte_eth_dev *dev,
                   uint16_t reta_size)
 {
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint16_t i, lut_size = hw->func_caps.common_cap.rss_table_size;
+       uint16_t i, lut_size = pf->hash_lut_size;
        uint16_t idx, shift;
        uint8_t *lut;
        int ret;
 
-       if (reta_size != lut_size ||
-           reta_size > ETH_RSS_RETA_SIZE_512) {
+       if (reta_size != lut_size) {
                PMD_DRV_LOG(ERR,
                            "The size of hash lookup table configured (%d)"
                            "doesn't match the number hardware can "
@@ -3185,7 +3221,7 @@ ice_update_vsi_stats(struct ice_vsi *vsi)
                           &nes->rx_broadcast);
        /* exclude CRC bytes */
        nes->rx_bytes -= (nes->rx_unicast + nes->rx_multicast +
-                         nes->rx_broadcast) * ETHER_CRC_LEN;
+                         nes->rx_broadcast) * RTE_ETHER_CRC_LEN;
 
        ice_stat_update_32(hw, GLV_RDPC(idx), vsi->offset_loaded,
                           &oes->rx_discards, &nes->rx_discards);
@@ -3258,10 +3294,11 @@ ice_read_stats_registers(struct ice_pf *pf, struct ice_hw *hw)
                           &ns->eth.rx_discards);
 
        /* Workaround: CRC size should not be included in byte statistics,
-        * so subtract ETHER_CRC_LEN from the byte counter for each rx packet.
+        * so subtract RTE_ETHER_CRC_LEN from the byte counter for each rx
+        * packet.
         */
        ns->eth.rx_bytes -= (ns->eth.rx_unicast + ns->eth.rx_multicast +
-                            ns->eth.rx_broadcast) * ETHER_CRC_LEN;
+                            ns->eth.rx_broadcast) * RTE_ETHER_CRC_LEN;
 
        /* GLPRT_REPC not supported */
        /* GLPRT_RMPC not supported */
@@ -3286,7 +3323,7 @@ ice_read_stats_registers(struct ice_pf *pf, struct ice_hw *hw)
                           pf->offset_loaded, &os->eth.tx_broadcast,
                           &ns->eth.tx_broadcast);
        ns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +
-                            ns->eth.tx_broadcast) * ETHER_CRC_LEN;
+                            ns->eth.tx_broadcast) * RTE_ETHER_CRC_LEN;
 
        /* GLPRT_TEPC not supported */