net/mlx5: block pop VLAN action on Tx
[dpdk.git] / drivers / net / mlx5 / mlx5_flow_dv.c
index e37ed93..9dc08ce 100644 (file)
@@ -27,6 +27,7 @@
 #include <rte_ip.h>
 #include <rte_gre.h>
 #include <rte_vxlan.h>
+#include <rte_gtp.h>
 
 #include "mlx5.h"
 #include "mlx5_defs.h"
@@ -365,7 +366,7 @@ flow_dv_convert_modify_action(struct rte_flow_item *item,
                uint32_t mask;
                uint32_t data;
 
-               if (i >= MLX5_MODIFY_NUM)
+               if (i >= MLX5_MAX_MODIFY_NUM)
                        return rte_flow_error_set(error, EINVAL,
                                 RTE_FLOW_ERROR_TYPE_ACTION, NULL,
                                 "too many items to modify");
@@ -406,11 +407,11 @@ flow_dv_convert_modify_action(struct rte_flow_item *item,
                ++i;
                ++field;
        } while (field->size);
-       resource->actions_num = i;
-       if (!resource->actions_num)
+       if (resource->actions_num == i)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
                                          "invalid modification flow item");
+       resource->actions_num = i;
        return 0;
 }
 
@@ -571,7 +572,7 @@ flow_dv_convert_action_modify_vlan_vid
        struct mlx5_modification_cmd *actions = &resource->actions[i];
        struct field_modify_info *field = modify_vlan_out_first_vid;
 
-       if (i >= MLX5_MODIFY_NUM)
+       if (i >= MLX5_MAX_MODIFY_NUM)
                return rte_flow_error_set(error, EINVAL,
                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
                         "too many items to modify");
@@ -904,7 +905,7 @@ flow_dv_convert_action_set_reg
        struct mlx5_modification_cmd *actions = resource->actions;
        uint32_t i = resource->actions_num;
 
-       if (i >= MLX5_MODIFY_NUM)
+       if (i >= MLX5_MAX_MODIFY_NUM)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
                                          "too many items to modify");
@@ -916,10 +917,6 @@ flow_dv_convert_action_set_reg
        actions[i].data1 = rte_cpu_to_be_32(conf->data);
        ++i;
        resource->actions_num = i;
-       if (!resource->actions_num)
-               return rte_flow_error_set(error, EINVAL,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
-                                         "invalid modification flow item");
        return 0;
 }
 
@@ -1090,6 +1087,14 @@ flow_dv_convert_action_mark(struct rte_eth_dev *dev,
        if (reg < 0)
                return reg;
        assert(reg > 0);
+       if (reg == REG_C_0) {
+               uint32_t msk_c0 = priv->sh->dv_regc0_mask;
+               uint32_t shl_c0 = rte_bsf32(msk_c0);
+
+               data = rte_cpu_to_be_32(rte_cpu_to_be_32(data) << shl_c0);
+               mask = rte_cpu_to_be_32(mask) & msk_c0;
+               mask = rte_cpu_to_be_32(mask << shl_c0);
+       }
        reg_c_x[0].id = reg_to_field[reg];
        return flow_dv_convert_modify_action(&item, reg_c_x, NULL, resource,
                                             MLX5_MODIFICATION_TYPE_SET, error);
@@ -1543,6 +1548,56 @@ flow_dv_validate_item_port_id(struct rte_eth_dev *dev,
        return 0;
 }
 
+/**
+ * Validate GTP item.
+ *
+ * @param[in] dev
+ *   Pointer to the rte_eth_dev structure.
+ * @param[in] item
+ *   Item specification.
+ * @param[in] item_flags
+ *   Bit-fields that holds the items detected until now.
+ * @param[out] error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+flow_dv_validate_item_gtp(struct rte_eth_dev *dev,
+                         const struct rte_flow_item *item,
+                         uint64_t item_flags,
+                         struct rte_flow_error *error)
+{
+       struct mlx5_priv *priv = dev->data->dev_private;
+       const struct rte_flow_item_gtp *mask = item->mask;
+       const struct rte_flow_item_gtp nic_mask = {
+               .msg_type = 0xff,
+               .teid = RTE_BE32(0xffffffff),
+       };
+
+       if (!priv->config.hca_attr.tunnel_stateless_gtp)
+               return rte_flow_error_set(error, ENOTSUP,
+                                         RTE_FLOW_ERROR_TYPE_ITEM, item,
+                                         "GTP support is not enabled");
+       if (item_flags & MLX5_FLOW_LAYER_TUNNEL)
+               return rte_flow_error_set(error, ENOTSUP,
+                                         RTE_FLOW_ERROR_TYPE_ITEM, item,
+                                         "multiple tunnel layers not"
+                                         " supported");
+       if (!(item_flags & MLX5_FLOW_LAYER_OUTER_L4_UDP))
+               return rte_flow_error_set(error, EINVAL,
+                                         RTE_FLOW_ERROR_TYPE_ITEM, item,
+                                         "no outer UDP layer found");
+       if (!mask)
+               mask = &rte_flow_item_gtp_mask;
+       return mlx5_flow_item_acceptable
+               (item, (const uint8_t *)mask,
+                (const uint8_t *)&nic_mask,
+                sizeof(struct rte_flow_item_gtp),
+                error);
+}
+
 /**
  * Validate the pop VLAN action.
  *
@@ -1579,6 +1634,12 @@ flow_dv_validate_action_pop_vlan(struct rte_eth_dev *dev,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL,
                                          "pop vlan action is not supported");
+       if (attr->egress)
+               return rte_flow_error_set(error, ENOTSUP,
+                                         RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
+                                         NULL,
+                                         "pop vlan action not supported for "
+                                         "egress");
        /*
         * Check for inconsistencies:
         *  fail strip_vlan in a flow that matches packets without VLAN tags.
@@ -1679,32 +1740,29 @@ flow_dev_get_vlan_info_from_items(const struct rte_flow_item *items,
  */
 static int
 flow_dv_validate_action_push_vlan(uint64_t action_flags,
-                                 uint64_t item_flags,
+                                 uint64_t item_flags __rte_unused,
                                  const struct rte_flow_action *action,
                                  const struct rte_flow_attr *attr,
                                  struct rte_flow_error *error)
 {
        const struct rte_flow_action_of_push_vlan *push_vlan = action->conf;
 
+       if (attr->ingress)
+               return rte_flow_error_set(error, ENOTSUP,
+                                         RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
+                                         NULL,
+                                         "push VLAN action not supported for "
+                                         "ingress");
        if (push_vlan->ethertype != RTE_BE16(RTE_ETHER_TYPE_VLAN) &&
            push_vlan->ethertype != RTE_BE16(RTE_ETHER_TYPE_QINQ))
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
                                          "invalid vlan ethertype");
-       if (action_flags &
-               (MLX5_FLOW_ACTION_OF_POP_VLAN | MLX5_FLOW_ACTION_OF_PUSH_VLAN))
+       if (action_flags & MLX5_FLOW_VLAN_ACTIONS)
                return rte_flow_error_set(error, ENOTSUP,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
                                          "no support for multiple VLAN "
                                          "actions");
-       if (!mlx5_flow_find_action
-                       (action + 1, RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID) &&
-           !(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN))
-               return rte_flow_error_set(error, ENOTSUP,
-                               RTE_FLOW_ERROR_TYPE_ACTION, action,
-                               "push VLAN needs to match on VLAN in order to "
-                               "get VLAN VID information because there is "
-                               "no followed set VLAN VID action");
        if (action_flags & MLX5_FLOW_ACTION_PORT_ID)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
@@ -1866,10 +1924,6 @@ flow_dv_validate_action_flag(struct rte_eth_dev *dev,
        if (ret < 0)
                return ret;
        assert(ret > 0);
-       if (action_flags & MLX5_FLOW_ACTION_DROP)
-               return rte_flow_error_set(error, EINVAL,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
-                                         "can't drop and flag in same flow");
        if (action_flags & MLX5_FLOW_ACTION_MARK)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
@@ -1939,10 +1993,6 @@ flow_dv_validate_action_mark(struct rte_eth_dev *dev,
                                          RTE_FLOW_ERROR_TYPE_ACTION_CONF,
                                          &mark->id,
                                          "mark id exceeds the limit");
-       if (action_flags & MLX5_FLOW_ACTION_DROP)
-               return rte_flow_error_set(error, EINVAL,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
-                                         "can't drop and mark in same flow");
        if (action_flags & MLX5_FLOW_ACTION_FLAG)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
@@ -2127,10 +2177,6 @@ flow_dv_validate_action_l2_encap(uint64_t action_flags,
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
                                          "configuration cannot be null");
-       if (action_flags & MLX5_FLOW_ACTION_DROP)
-               return rte_flow_error_set(error, EINVAL,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
-                                         "can't drop and encap in same flow");
        if (action_flags & (MLX5_FLOW_ENCAP_ACTIONS | MLX5_FLOW_DECAP_ACTIONS))
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
@@ -2163,10 +2209,6 @@ flow_dv_validate_action_l2_decap(uint64_t action_flags,
                                 const struct rte_flow_attr *attr,
                                 struct rte_flow_error *error)
 {
-       if (action_flags & MLX5_FLOW_ACTION_DROP)
-               return rte_flow_error_set(error, EINVAL,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
-                                         "can't drop and decap in same flow");
        if (action_flags & (MLX5_FLOW_ENCAP_ACTIONS | MLX5_FLOW_DECAP_ACTIONS))
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
@@ -2213,10 +2255,6 @@ flow_dv_validate_action_raw_encap(uint64_t action_flags,
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
                                          "configuration cannot be null");
-       if (action_flags & MLX5_FLOW_ACTION_DROP)
-               return rte_flow_error_set(error, EINVAL,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
-                                         "can't drop and encap in same flow");
        if (action_flags & MLX5_FLOW_ENCAP_ACTIONS)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
@@ -2260,10 +2298,6 @@ flow_dv_validate_action_raw_decap(uint64_t action_flags,
 {
        const struct rte_flow_action_raw_decap *decap   = action->conf;
 
-       if (action_flags & MLX5_FLOW_ACTION_DROP)
-               return rte_flow_error_set(error, EINVAL,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
-                                         "can't drop and decap in same flow");
        if (action_flags & MLX5_FLOW_ENCAP_ACTIONS)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
@@ -2326,7 +2360,6 @@ flow_dv_encap_decap_resource_register
                domain = sh->rx_domain;
        else
                domain = sh->tx_domain;
-
        /* Lookup a matching resource from cache. */
        LIST_FOREACH(cache_resource, &sh->encaps_decaps, next) {
                if (resource->reformat_type == cache_resource->reformat_type &&
@@ -3437,21 +3470,27 @@ flow_dv_validate_action_port_id(struct rte_eth_dev *dev,
  *
  * @param dev
  *   Pointer to rte_eth_dev structure.
+ * @param flags
+ *   Flags bits to check if root level.
  *
  * @return
  *   Max number of modify header actions device can support.
  */
 static unsigned int
-flow_dv_modify_hdr_action_max(struct rte_eth_dev *dev)
+flow_dv_modify_hdr_action_max(struct rte_eth_dev *dev, uint64_t flags)
 {
        /*
         * There's no way to directly query the max cap. Although it has to be
         * acquried by iterative trial, it is a safe assumption that more
         * actions are supported by FW if extensive metadata register is
-        * supported.
+        * supported. (Only in the root table)
         */
-       return mlx5_flow_ext_mreg_supported(dev) ? MLX5_MODIFY_NUM :
-                                                  MLX5_MODIFY_NUM_NO_MREG;
+       if (!(flags & MLX5DV_DR_ACTION_FLAGS_ROOT_LEVEL))
+               return MLX5_MAX_MODIFY_NUM;
+       else
+               return mlx5_flow_ext_mreg_supported(dev) ?
+                                       MLX5_ROOT_TBL_MODIFY_NUM :
+                                       MLX5_ROOT_TBL_MODIFY_NUM_NO_MREG;
 }
 
 /**
@@ -3610,8 +3649,12 @@ flow_dv_modify_hdr_resource_register
        struct mlx5_ibv_shared *sh = priv->sh;
        struct mlx5_flow_dv_modify_hdr_resource *cache_resource;
        struct mlx5dv_dr_domain *ns;
+       uint32_t actions_len;
 
-       if (resource->actions_num > flow_dv_modify_hdr_action_max(dev))
+       resource->flags =
+               dev_flow->group ? 0 : MLX5DV_DR_ACTION_FLAGS_ROOT_LEVEL;
+       if (resource->actions_num > flow_dv_modify_hdr_action_max(dev,
+                                   resource->flags))
                return rte_flow_error_set(error, EOVERFLOW,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
                                          "too many modify header items");
@@ -3621,17 +3664,15 @@ flow_dv_modify_hdr_resource_register
                ns = sh->tx_domain;
        else
                ns = sh->rx_domain;
-       resource->flags =
-               dev_flow->group ? 0 : MLX5DV_DR_ACTION_FLAGS_ROOT_LEVEL;
        /* Lookup a matching resource from cache. */
+       actions_len = resource->actions_num * sizeof(resource->actions[0]);
        LIST_FOREACH(cache_resource, &sh->modify_cmds, next) {
                if (resource->ft_type == cache_resource->ft_type &&
                    resource->actions_num == cache_resource->actions_num &&
                    resource->flags == cache_resource->flags &&
                    !memcmp((const void *)resource->actions,
                            (const void *)cache_resource->actions,
-                           (resource->actions_num *
-                                           sizeof(resource->actions[0])))) {
+                           actions_len)) {
                        DRV_LOG(DEBUG, "modify-header resource %p: refcnt %d++",
                                (void *)cache_resource,
                                rte_atomic32_read(&cache_resource->refcnt));
@@ -3641,18 +3682,18 @@ flow_dv_modify_hdr_resource_register
                }
        }
        /* Register new modify-header resource. */
-       cache_resource = rte_calloc(__func__, 1, sizeof(*cache_resource), 0);
+       cache_resource = rte_calloc(__func__, 1,
+                                   sizeof(*cache_resource) + actions_len, 0);
        if (!cache_resource)
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
                                          "cannot allocate resource memory");
        *cache_resource = *resource;
+       rte_memcpy(cache_resource->actions, resource->actions, actions_len);
        cache_resource->verbs_action =
                mlx5_glue->dv_create_flow_action_modify_header
-                                       (sh->ctx, cache_resource->ft_type,
-                                        ns, cache_resource->flags,
-                                        cache_resource->actions_num *
-                                        sizeof(cache_resource->actions[0]),
+                                       (sh->ctx, cache_resource->ft_type, ns,
+                                        cache_resource->flags, actions_len,
                                         (uint64_t *)cache_resource->actions);
        if (!cache_resource->verbs_action) {
                rte_free(cache_resource);
@@ -4621,6 +4662,13 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
                case MLX5_RTE_FLOW_ITEM_TYPE_TAG:
                case MLX5_RTE_FLOW_ITEM_TYPE_TX_QUEUE:
                        break;
+               case RTE_FLOW_ITEM_TYPE_GTP:
+                       ret = flow_dv_validate_item_gtp(dev, items, item_flags,
+                                                       error);
+                       if (ret < 0)
+                               return ret;
+                       last_item = MLX5_FLOW_LAYER_GTP;
+                       break;
                default:
                        return rte_flow_error_set(error, ENOTSUP,
                                                  RTE_FLOW_ERROR_TYPE_ITEM,
@@ -4991,13 +5039,18 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
                                                  "action not supported");
                }
        }
-       if ((action_flags & MLX5_FLOW_LAYER_TUNNEL) &&
-           (action_flags & MLX5_FLOW_VLAN_ACTIONS))
-               return rte_flow_error_set(error, ENOTSUP,
-                                         RTE_FLOW_ERROR_TYPE_ACTION,
-                                         actions,
-                                         "can't have vxlan and vlan"
-                                         " actions in the same rule");
+       /*
+        * Validate the drop action mutual exclusion with other actions.
+        * Drop action is mutually-exclusive with any other action, except for
+        * Count action.
+        */
+       if ((action_flags & MLX5_FLOW_ACTION_DROP) &&
+           (action_flags & ~(MLX5_FLOW_ACTION_DROP | MLX5_FLOW_ACTION_COUNT)))
+               return rte_flow_error_set(error, EINVAL,
+                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
+                                         "Drop action is mutually-exclusive "
+                                         "with any other action, except for "
+                                         "Count action");
        /* Eswitch has few restrictions on using items and actions */
        if (attr->transfer) {
                if (!mlx5_flow_ext_mreg_supported(dev) &&
@@ -5920,6 +5973,7 @@ flow_dv_match_meta_reg(void *matcher, void *key,
                MLX5_ADDR_OF(fte_match_param, matcher, misc_parameters_2);
        void *misc2_v =
                MLX5_ADDR_OF(fte_match_param, key, misc_parameters_2);
+       uint32_t temp;
 
        data &= mask;
        switch (reg_type) {
@@ -5932,8 +5986,18 @@ flow_dv_match_meta_reg(void *matcher, void *key,
                MLX5_SET(fte_match_set_misc2, misc2_v, metadata_reg_b, data);
                break;
        case REG_C_0:
-               MLX5_SET(fte_match_set_misc2, misc2_m, metadata_reg_c_0, mask);
-               MLX5_SET(fte_match_set_misc2, misc2_v, metadata_reg_c_0, data);
+               /*
+                * The metadata register C0 field might be divided into
+                * source vport index and META item value, we should set
+                * this field according to specified mask, not as whole one.
+                */
+               temp = MLX5_GET(fte_match_set_misc2, misc2_m, metadata_reg_c_0);
+               temp |= mask;
+               MLX5_SET(fte_match_set_misc2, misc2_m, metadata_reg_c_0, temp);
+               temp = MLX5_GET(fte_match_set_misc2, misc2_v, metadata_reg_c_0);
+               temp &= ~mask;
+               temp |= data;
+               MLX5_SET(fte_match_set_misc2, misc2_v, metadata_reg_c_0, temp);
                break;
        case REG_C_1:
                MLX5_SET(fte_match_set_misc2, misc2_m, metadata_reg_c_1, mask);
@@ -6003,6 +6067,15 @@ flow_dv_translate_item_mark(struct rte_eth_dev *dev,
                /* Get the metadata register index for the mark. */
                reg = mlx5_flow_get_reg_id(dev, MLX5_FLOW_MARK, 0, NULL);
                assert(reg > 0);
+               if (reg == REG_C_0) {
+                       struct mlx5_priv *priv = dev->data->dev_private;
+                       uint32_t msk_c0 = priv->sh->dv_regc0_mask;
+                       uint32_t shl_c0 = rte_bsf32(msk_c0);
+
+                       mask &= msk_c0;
+                       mask <<= shl_c0;
+                       value <<= shl_c0;
+               }
                flow_dv_match_meta_reg(matcher, key, reg, value, mask);
        }
 }
@@ -6053,8 +6126,12 @@ flow_dv_translate_item_meta(struct rte_eth_dev *dev,
                        struct mlx5_priv *priv = dev->data->dev_private;
                        uint32_t msk_c0 = priv->sh->dv_regc0_mask;
                        uint32_t shl_c0 = rte_bsf32(msk_c0);
+#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
+                       uint32_t shr_c0 = __builtin_clz(priv->sh->dv_meta_mask);
 
-                       msk_c0 = rte_cpu_to_be_32(msk_c0);
+                       value >>= shr_c0;
+                       mask >>= shr_c0;
+#endif
                        value <<= shl_c0;
                        mask <<= shl_c0;
                        assert(msk_c0);
@@ -6084,6 +6161,8 @@ flow_dv_translate_item_meta_vport(void *matcher, void *key,
 /**
  * Add tag item to matcher
  *
+ * @param[in] dev
+ *   The devich to configure through.
  * @param[in, out] matcher
  *   Flow matcher.
  * @param[in, out] key
@@ -6092,15 +6171,27 @@ flow_dv_translate_item_meta_vport(void *matcher, void *key,
  *   Flow pattern to translate.
  */
 static void
-flow_dv_translate_mlx5_item_tag(void *matcher, void *key,
+flow_dv_translate_mlx5_item_tag(struct rte_eth_dev *dev,
+                               void *matcher, void *key,
                                const struct rte_flow_item *item)
 {
        const struct mlx5_rte_flow_item_tag *tag_v = item->spec;
        const struct mlx5_rte_flow_item_tag *tag_m = item->mask;
+       uint32_t mask, value;
 
        assert(tag_v);
-       flow_dv_match_meta_reg(matcher, key, tag_v->id, tag_v->data,
-                              tag_m ? tag_m->data : UINT32_MAX);
+       value = tag_v->data;
+       mask = tag_m ? tag_m->data : UINT32_MAX;
+       if (tag_v->id == REG_C_0) {
+               struct mlx5_priv *priv = dev->data->dev_private;
+               uint32_t msk_c0 = priv->sh->dv_regc0_mask;
+               uint32_t shl_c0 = rte_bsf32(msk_c0);
+
+               mask &= msk_c0;
+               mask <<= shl_c0;
+               value <<= shl_c0;
+       }
+       flow_dv_match_meta_reg(matcher, key, tag_v->id, value, mask);
 }
 
 /**
@@ -6291,6 +6382,57 @@ flow_dv_translate_item_icmp(void *matcher, void *key,
                 icmp_v->hdr.icmp_code & icmp_m->hdr.icmp_code);
 }
 
+/**
+ * Add GTP item to matcher and to the value.
+ *
+ * @param[in, out] matcher
+ *   Flow matcher.
+ * @param[in, out] key
+ *   Flow matcher value.
+ * @param[in] item
+ *   Flow pattern to translate.
+ * @param[in] inner
+ *   Item is inner pattern.
+ */
+static void
+flow_dv_translate_item_gtp(void *matcher, void *key,
+                          const struct rte_flow_item *item, int inner)
+{
+       const struct rte_flow_item_gtp *gtp_m = item->mask;
+       const struct rte_flow_item_gtp *gtp_v = item->spec;
+       void *headers_m;
+       void *headers_v;
+       void *misc3_m = MLX5_ADDR_OF(fte_match_param, matcher,
+                                    misc_parameters_3);
+       void *misc3_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters_3);
+       uint16_t dport = RTE_GTPU_UDP_PORT;
+
+       if (inner) {
+               headers_m = MLX5_ADDR_OF(fte_match_param, matcher,
+                                        inner_headers);
+               headers_v = MLX5_ADDR_OF(fte_match_param, key, inner_headers);
+       } else {
+               headers_m = MLX5_ADDR_OF(fte_match_param, matcher,
+                                        outer_headers);
+               headers_v = MLX5_ADDR_OF(fte_match_param, key, outer_headers);
+       }
+       if (!MLX5_GET16(fte_match_set_lyr_2_4, headers_v, udp_dport)) {
+               MLX5_SET(fte_match_set_lyr_2_4, headers_m, udp_dport, 0xFFFF);
+               MLX5_SET(fte_match_set_lyr_2_4, headers_v, udp_dport, dport);
+       }
+       if (!gtp_v)
+               return;
+       if (!gtp_m)
+               gtp_m = &rte_flow_item_gtp_mask;
+       MLX5_SET(fte_match_set_misc3, misc3_m, gtpu_msg_type, gtp_m->msg_type);
+       MLX5_SET(fte_match_set_misc3, misc3_v, gtpu_msg_type,
+                gtp_v->msg_type & gtp_m->msg_type);
+       MLX5_SET(fte_match_set_misc3, misc3_m, gtpu_teid,
+                rte_be_to_cpu_32(gtp_m->teid));
+       MLX5_SET(fte_match_set_misc3, misc3_v, gtpu_teid,
+                rte_be_to_cpu_32(gtp_v->teid & gtp_m->teid));
+}
+
 static uint32_t matcher_zero[MLX5_ST_SZ_DW(fte_match_param)] = { 0 };
 
 #define HEADER_IS_ZERO(match_criteria, headers)                                     \
@@ -6865,10 +7007,13 @@ __flow_dv_translate(struct rte_eth_dev *dev,
        };
        int actions_n = 0;
        bool actions_end = false;
-       struct mlx5_flow_dv_modify_hdr_resource mhdr_res = {
-               .ft_type = attr->egress ? MLX5DV_FLOW_TABLE_TYPE_NIC_TX :
-                                         MLX5DV_FLOW_TABLE_TYPE_NIC_RX
-       };
+       union {
+               struct mlx5_flow_dv_modify_hdr_resource res;
+               uint8_t len[sizeof(struct mlx5_flow_dv_modify_hdr_resource) +
+                           sizeof(struct mlx5_modification_cmd) *
+                           (MLX5_MAX_MODIFY_NUM + 1)];
+       } mhdr_dummy;
+       struct mlx5_flow_dv_modify_hdr_resource *mhdr_res = &mhdr_dummy.res;
        union flow_dv_attr flow_attr = { .attr = 0 };
        uint32_t tag_be;
        union mlx5_flow_tbl_key tbl_key;
@@ -6880,15 +7025,19 @@ __flow_dv_translate(struct rte_eth_dev *dev,
        uint32_t table;
        int ret = 0;
 
+       mhdr_res->ft_type = attr->egress ? MLX5DV_FLOW_TABLE_TYPE_NIC_TX :
+                                          MLX5DV_FLOW_TABLE_TYPE_NIC_RX;
        ret = mlx5_flow_group_to_table(attr, dev_flow->external, attr->group,
                                       &table, error);
        if (ret)
                return ret;
        dev_flow->group = table;
        if (attr->transfer)
-               mhdr_res.ft_type = MLX5DV_FLOW_TABLE_TYPE_FDB;
+               mhdr_res->ft_type = MLX5DV_FLOW_TABLE_TYPE_FDB;
        if (priority == MLX5_FLOW_PRIO_RSVD)
                priority = dev_conf->flow_prio - 1;
+       /* number of actions must be set to 0 in case of dirty stack. */
+       mhdr_res->actions_num = 0;
        for (; !actions_end ; actions++) {
                const struct rte_flow_action_queue *queue;
                const struct rte_flow_action_rss *rss;
@@ -6926,7 +7075,7 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                                };
 
                                if (flow_dv_convert_action_mark(dev, &mark,
-                                                               &mhdr_res,
+                                                               mhdr_res,
                                                                error))
                                        return -rte_errno;
                                action_flags |= MLX5_FLOW_ACTION_MARK_EXT;
@@ -6948,7 +7097,7 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                                                actions->conf;
 
                                if (flow_dv_convert_action_mark(dev, mark,
-                                                               &mhdr_res,
+                                                               mhdr_res,
                                                                error))
                                        return -rte_errno;
                                action_flags |= MLX5_FLOW_ACTION_MARK_EXT;
@@ -6969,7 +7118,7 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                        break;
                case RTE_FLOW_ACTION_TYPE_SET_META:
                        if (flow_dv_convert_action_set_meta
-                               (dev, &mhdr_res, attr,
+                               (dev, mhdr_res, attr,
                                 (const struct rte_flow_action_set_meta *)
                                  actions->conf, error))
                                return -rte_errno;
@@ -6977,7 +7126,7 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                        break;
                case RTE_FLOW_ACTION_TYPE_SET_TAG:
                        if (flow_dv_convert_action_set_tag
-                               (dev, &mhdr_res,
+                               (dev, mhdr_res,
                                 (const struct rte_flow_action_set_tag *)
                                  actions->conf, error))
                                return -rte_errno;
@@ -7077,7 +7226,7 @@ cnt_err:
                        mlx5_update_vlan_vid_pcp(actions, &vlan);
                        /* If no VLAN push - this is a modify header action */
                        if (flow_dv_convert_action_modify_vlan_vid
-                                               (&mhdr_res, actions, error))
+                                               (mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= MLX5_FLOW_ACTION_OF_SET_VLAN_VID;
                        break;
@@ -7176,7 +7325,7 @@ cnt_err:
                case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
                case RTE_FLOW_ACTION_TYPE_SET_MAC_DST:
                        if (flow_dv_convert_action_modify_mac
-                                       (&mhdr_res, actions, error))
+                                       (mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= actions->type ==
                                        RTE_FLOW_ACTION_TYPE_SET_MAC_SRC ?
@@ -7186,7 +7335,7 @@ cnt_err:
                case RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC:
                case RTE_FLOW_ACTION_TYPE_SET_IPV4_DST:
                        if (flow_dv_convert_action_modify_ipv4
-                                       (&mhdr_res, actions, error))
+                                       (mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= actions->type ==
                                        RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC ?
@@ -7196,7 +7345,7 @@ cnt_err:
                case RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC:
                case RTE_FLOW_ACTION_TYPE_SET_IPV6_DST:
                        if (flow_dv_convert_action_modify_ipv6
-                                       (&mhdr_res, actions, error))
+                                       (mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= actions->type ==
                                        RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC ?
@@ -7206,7 +7355,7 @@ cnt_err:
                case RTE_FLOW_ACTION_TYPE_SET_TP_SRC:
                case RTE_FLOW_ACTION_TYPE_SET_TP_DST:
                        if (flow_dv_convert_action_modify_tp
-                                       (&mhdr_res, actions, items,
+                                       (mhdr_res, actions, items,
                                         &flow_attr, error))
                                return -rte_errno;
                        action_flags |= actions->type ==
@@ -7216,13 +7365,13 @@ cnt_err:
                        break;
                case RTE_FLOW_ACTION_TYPE_DEC_TTL:
                        if (flow_dv_convert_action_modify_dec_ttl
-                                       (&mhdr_res, items, &flow_attr, error))
+                                       (mhdr_res, items, &flow_attr, error))
                                return -rte_errno;
                        action_flags |= MLX5_FLOW_ACTION_DEC_TTL;
                        break;
                case RTE_FLOW_ACTION_TYPE_SET_TTL:
                        if (flow_dv_convert_action_modify_ttl
-                                       (&mhdr_res, actions, items,
+                                       (mhdr_res, actions, items,
                                         &flow_attr, error))
                                return -rte_errno;
                        action_flags |= MLX5_FLOW_ACTION_SET_TTL;
@@ -7230,7 +7379,7 @@ cnt_err:
                case RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ:
                case RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ:
                        if (flow_dv_convert_action_modify_tcp_seq
-                                       (&mhdr_res, actions, error))
+                                       (mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= actions->type ==
                                        RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ ?
@@ -7241,7 +7390,7 @@ cnt_err:
                case RTE_FLOW_ACTION_TYPE_INC_TCP_ACK:
                case RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK:
                        if (flow_dv_convert_action_modify_tcp_ack
-                                       (&mhdr_res, actions, error))
+                                       (mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= actions->type ==
                                        RTE_FLOW_ACTION_TYPE_INC_TCP_ACK ?
@@ -7250,13 +7399,13 @@ cnt_err:
                        break;
                case MLX5_RTE_FLOW_ACTION_TYPE_TAG:
                        if (flow_dv_convert_action_set_reg
-                                       (&mhdr_res, actions, error))
+                                       (mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= MLX5_FLOW_ACTION_SET_TAG;
                        break;
                case MLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG:
                        if (flow_dv_convert_action_copy_mreg
-                                       (dev, &mhdr_res, actions, error))
+                                       (dev, mhdr_res, actions, error))
                                return -rte_errno;
                        action_flags |= MLX5_FLOW_ACTION_SET_TAG;
                        break;
@@ -7280,23 +7429,23 @@ cnt_err:
                        action_flags |= MLX5_FLOW_ACTION_METER;
                        break;
                case RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP:
-                       if (flow_dv_convert_action_modify_ipv4_dscp(&mhdr_res,
+                       if (flow_dv_convert_action_modify_ipv4_dscp(mhdr_res,
                                                              actions, error))
                                return -rte_errno;
                        action_flags |= MLX5_FLOW_ACTION_SET_IPV4_DSCP;
                        break;
                case RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP:
-                       if (flow_dv_convert_action_modify_ipv6_dscp(&mhdr_res,
+                       if (flow_dv_convert_action_modify_ipv6_dscp(mhdr_res,
                                                              actions, error))
                                return -rte_errno;
                        action_flags |= MLX5_FLOW_ACTION_SET_IPV6_DSCP;
                        break;
                case RTE_FLOW_ACTION_TYPE_END:
                        actions_end = true;
-                       if (mhdr_res.actions_num) {
+                       if (mhdr_res->actions_num) {
                                /* create modify action if needed. */
                                if (flow_dv_modify_hdr_resource_register
-                                       (dev, &mhdr_res, dev_flow, error))
+                                       (dev, mhdr_res, dev_flow, error))
                                        return -rte_errno;
                                dev_flow->dv.actions[modify_action_position] =
                                        dev_flow->dv.modify_hdr->verbs_action;
@@ -7305,7 +7454,7 @@ cnt_err:
                default:
                        break;
                }
-               if (mhdr_res.actions_num &&
+               if (mhdr_res->actions_num &&
                    modify_action_position == UINT32_MAX)
                        modify_action_position = actions_n++;
        }
@@ -7459,7 +7608,7 @@ cnt_err:
                        last_item = MLX5_FLOW_ITEM_TAG;
                        break;
                case MLX5_RTE_FLOW_ITEM_TYPE_TAG:
-                       flow_dv_translate_mlx5_item_tag(match_mask,
+                       flow_dv_translate_mlx5_item_tag(dev, match_mask,
                                                        match_value, items);
                        last_item = MLX5_FLOW_ITEM_TAG;
                        break;
@@ -7469,6 +7618,11 @@ cnt_err:
                                                        items);
                        last_item = MLX5_FLOW_ITEM_TX_QUEUE;
                        break;
+               case RTE_FLOW_ITEM_TYPE_GTP:
+                       flow_dv_translate_item_gtp(match_mask, match_value,
+                                                  items, tunnel);
+                       last_item = MLX5_FLOW_LAYER_GTP;
+                       break;
                default:
                        break;
                }