net/mlx5: fix tunnel flow priority
[dpdk.git] / drivers / net / mlx5 / mlx5_flow_dv.c
index a9202d5..f0cc7ad 100644 (file)
@@ -8,16 +8,6 @@
 #include <string.h>
 #include <unistd.h>
 
-/* Verbs header. */
-/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */
-#ifdef PEDANTIC
-#pragma GCC diagnostic ignored "-Wpedantic"
-#endif
-#include <infiniband/verbs.h>
-#ifdef PEDANTIC
-#pragma GCC diagnostic error "-Wpedantic"
-#endif
-
 #include <rte_common.h>
 #include <rte_ether.h>
 #include <rte_ethdev_driver.h>
 #include <rte_gre.h>
 #include <rte_vxlan.h>
 #include <rte_gtp.h>
+#include <rte_eal_paging.h>
 
+#include <mlx5_glue.h>
 #include <mlx5_devx_cmds.h>
 #include <mlx5_prm.h>
+#include <mlx5_malloc.h>
 
 #include "mlx5_defs.h"
 #include "mlx5.h"
@@ -1839,7 +1832,17 @@ flow_dv_validate_action_pop_vlan(struct rte_eth_dev *dev,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
                                          "no support for multiple VLAN "
                                          "actions");
-       if (!(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN))
+       /* Pop VLAN with preceding Decap requires inner header with VLAN. */
+       if ((action_flags & MLX5_FLOW_ACTION_DECAP) &&
+           !(item_flags & MLX5_FLOW_LAYER_INNER_VLAN))
+               return rte_flow_error_set(error, ENOTSUP,
+                                         RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+                                         NULL,
+                                         "cannot pop vlan after decap without "
+                                         "match on inner vlan in the flow");
+       /* Pop VLAN without preceding Decap requires outer header with VLAN. */
+       if (!(action_flags & MLX5_FLOW_ACTION_DECAP) &&
+           !(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN))
                return rte_flow_error_set(error, ENOTSUP,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL,
@@ -1948,22 +1951,11 @@ flow_dv_validate_action_push_vlan(struct rte_eth_dev *dev,
        const struct rte_flow_action_of_push_vlan *push_vlan = action->conf;
        const struct mlx5_priv *priv = dev->data->dev_private;
 
-       if (!attr->transfer && attr->ingress)
-               return rte_flow_error_set(error, ENOTSUP,
-                                         RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
-                                         NULL,
-                                         "push VLAN action not supported for "
-                                         "ingress");
        if (push_vlan->ethertype != RTE_BE16(RTE_ETHER_TYPE_VLAN) &&
            push_vlan->ethertype != RTE_BE16(RTE_ETHER_TYPE_QINQ))
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
                                          "invalid vlan ethertype");
-       if (action_flags & MLX5_FLOW_VLAN_ACTIONS)
-               return rte_flow_error_set(error, ENOTSUP,
-                                         RTE_FLOW_ERROR_TYPE_ACTION, action,
-                                         "no support for multiple VLAN "
-                                         "actions");
        if (action_flags & MLX5_FLOW_ACTION_PORT_ID)
                return rte_flow_error_set(error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ACTION, action,
@@ -2428,6 +2420,11 @@ flow_dv_validate_action_decap(struct rte_eth_dev *dev,
 {
        const struct mlx5_priv *priv = dev->data->dev_private;
 
+       if (priv->config.hca_attr.scatter_fcs_w_decap_disable &&
+           !priv->config.decap_en)
+               return rte_flow_error_set(error, ENOTSUP,
+                                         RTE_FLOW_ERROR_TYPE_ACTION, NULL,
+                                         "decap is not enabled");
        if (action_flags & MLX5_FLOW_XCAP_ACTIONS)
                return rte_flow_error_set(error, ENOTSUP,
                                          RTE_FLOW_ERROR_TYPE_ACTION, NULL,
@@ -2615,7 +2612,7 @@ flow_dv_encap_decap_resource_register
                                        (sh->ctx, domain, cache_resource,
                                         &cache_resource->action);
        if (ret) {
-               rte_free(cache_resource);
+               mlx5_free(cache_resource);
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL, "cannot create action");
@@ -2772,7 +2769,7 @@ flow_dv_port_id_action_resource_register
                                (priv->sh->fdb_domain, resource->port_id,
                                 &cache_resource->action);
        if (ret) {
-               rte_free(cache_resource);
+               mlx5_free(cache_resource);
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL, "cannot create action");
@@ -2851,7 +2848,7 @@ flow_dv_push_vlan_action_resource_register
                                        (domain, resource->vlan_tag,
                                         &cache_resource->action);
        if (ret) {
-               rte_free(cache_resource);
+               mlx5_free(cache_resource);
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL, "cannot create action");
@@ -4024,8 +4021,9 @@ flow_dv_modify_hdr_resource_register
                }
        }
        /* Register new modify-header resource. */
-       cache_resource = rte_calloc(__func__, 1,
-                                   sizeof(*cache_resource) + actions_len, 0);
+       cache_resource = mlx5_malloc(MLX5_MEM_ZERO,
+                                   sizeof(*cache_resource) + actions_len, 0,
+                                   SOCKET_ID_ANY);
        if (!cache_resource)
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
@@ -4036,7 +4034,7 @@ flow_dv_modify_hdr_resource_register
                                        (sh->ctx, ns, cache_resource,
                                         actions_len, &cache_resource->action);
        if (ret) {
-               rte_free(cache_resource);
+               mlx5_free(cache_resource);
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL, "cannot create action");
@@ -4175,7 +4173,14 @@ flow_dv_create_counter_stat_mem_mng(struct rte_eth_dev *dev, int raws_n)
                        MLX5_COUNTERS_PER_POOL +
                        sizeof(struct mlx5_counter_stats_raw)) * raws_n +
                        sizeof(struct mlx5_counter_stats_mem_mng);
-       uint8_t *mem = rte_calloc(__func__, 1, size, sysconf(_SC_PAGESIZE));
+       size_t pgsize = rte_mem_page_size();
+       if (pgsize == (size_t)-1) {
+               DRV_LOG(ERR, "Failed to get mem page size");
+               rte_errno = ENOMEM;
+               return NULL;
+       }
+       uint8_t *mem = mlx5_malloc(MLX5_MEM_ZERO, size, pgsize,
+                                 SOCKET_ID_ANY);
        int i;
 
        if (!mem) {
@@ -4188,7 +4193,7 @@ flow_dv_create_counter_stat_mem_mng(struct rte_eth_dev *dev, int raws_n)
                                                 IBV_ACCESS_LOCAL_WRITE);
        if (!mem_mng->umem) {
                rte_errno = errno;
-               rte_free(mem);
+               mlx5_free(mem);
                return NULL;
        }
        mkey_attr.addr = (uintptr_t)mem;
@@ -4207,7 +4212,7 @@ flow_dv_create_counter_stat_mem_mng(struct rte_eth_dev *dev, int raws_n)
        if (!mem_mng->dm) {
                mlx5_glue->devx_umem_dereg(mem_mng->umem);
                rte_errno = errno;
-               rte_free(mem);
+               mlx5_free(mem);
                return NULL;
        }
        mem_mng->raws = (struct mlx5_counter_stats_raw *)(mem + size);
@@ -4244,7 +4249,7 @@ flow_dv_container_resize(struct rte_eth_dev *dev,
        void *old_pools = cont->pools;
        uint32_t resize = cont->n + MLX5_CNT_CONTAINER_RESIZE;
        uint32_t mem_size = sizeof(struct mlx5_flow_counter_pool *) * resize;
-       void *pools = rte_calloc(__func__, 1, mem_size, 0);
+       void *pools = mlx5_malloc(MLX5_MEM_ZERO, mem_size, 0, SOCKET_ID_ANY);
 
        if (!pools) {
                rte_errno = ENOMEM;
@@ -4263,7 +4268,7 @@ flow_dv_container_resize(struct rte_eth_dev *dev,
                mem_mng = flow_dv_create_counter_stat_mem_mng(dev,
                          MLX5_CNT_CONTAINER_RESIZE + MLX5_MAX_PENDING_QUERIES);
                if (!mem_mng) {
-                       rte_free(pools);
+                       mlx5_free(pools);
                        return -ENOMEM;
                }
                for (i = 0; i < MLX5_MAX_PENDING_QUERIES; ++i)
@@ -4278,7 +4283,7 @@ flow_dv_container_resize(struct rte_eth_dev *dev,
        cont->pools = pools;
        rte_spinlock_unlock(&cont->resize_sl);
        if (old_pools)
-               rte_free(old_pools);
+               mlx5_free(old_pools);
        return 0;
 }
 
@@ -4367,7 +4372,7 @@ flow_dv_pool_create(struct rte_eth_dev *dev, struct mlx5_devx_obj *dcs,
        size += MLX5_COUNTERS_PER_POOL * CNT_SIZE;
        size += (batch ? 0 : MLX5_COUNTERS_PER_POOL * CNTEXT_SIZE);
        size += (!age ? 0 : MLX5_COUNTERS_PER_POOL * AGE_SIZE);
-       pool = rte_calloc(__func__, 1, size, 0);
+       pool = mlx5_malloc(MLX5_MEM_ZERO, size, 0, SOCKET_ID_ANY);
        if (!pool) {
                rte_errno = ENOMEM;
                return NULL;
@@ -5675,21 +5680,38 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
                                                  actions,
                                                  "no fate action is found");
        }
-       /* Continue validation for Xcap actions.*/
-       if ((action_flags & MLX5_FLOW_XCAP_ACTIONS) && (queue_index == 0xFFFF ||
-           mlx5_rxq_get_type(dev, queue_index) != MLX5_RXQ_TYPE_HAIRPIN)) {
+       /* Continue validation for Xcap and VLAN actions.*/
+       if ((action_flags & (MLX5_FLOW_XCAP_ACTIONS |
+                            MLX5_FLOW_VLAN_ACTIONS)) &&
+           (queue_index == 0xFFFF ||
+            mlx5_rxq_get_type(dev, queue_index) != MLX5_RXQ_TYPE_HAIRPIN)) {
                if ((action_flags & MLX5_FLOW_XCAP_ACTIONS) ==
                    MLX5_FLOW_XCAP_ACTIONS)
                        return rte_flow_error_set(error, ENOTSUP,
                                                  RTE_FLOW_ERROR_TYPE_ACTION,
                                                  NULL, "encap and decap "
                                                  "combination aren't supported");
-               if (!attr->transfer && attr->ingress && (action_flags &
-                                                       MLX5_FLOW_ACTION_ENCAP))
-                       return rte_flow_error_set(error, ENOTSUP,
-                                                 RTE_FLOW_ERROR_TYPE_ACTION,
-                                                 NULL, "encap is not supported"
-                                                 " for ingress traffic");
+               if (!attr->transfer && attr->ingress) {
+                       if (action_flags & MLX5_FLOW_ACTION_ENCAP)
+                               return rte_flow_error_set
+                                               (error, ENOTSUP,
+                                                RTE_FLOW_ERROR_TYPE_ACTION,
+                                                NULL, "encap is not supported"
+                                                " for ingress traffic");
+                       else if (action_flags & MLX5_FLOW_ACTION_OF_PUSH_VLAN)
+                               return rte_flow_error_set
+                                               (error, ENOTSUP,
+                                                RTE_FLOW_ERROR_TYPE_ACTION,
+                                                NULL, "push VLAN action not "
+                                                "supported for ingress");
+                       else if ((action_flags & MLX5_FLOW_VLAN_ACTIONS) ==
+                                       MLX5_FLOW_VLAN_ACTIONS)
+                               return rte_flow_error_set
+                                               (error, ENOTSUP,
+                                                RTE_FLOW_ERROR_TYPE_ACTION,
+                                                NULL, "no support for "
+                                                "multiple VLAN actions");
+               }
        }
        /* Hairpin flow will add one more TAG action. */
        if (hairpin > 0)
@@ -7585,7 +7607,8 @@ flow_dv_matcher_register(struct rte_eth_dev *dev,
                }
        }
        /* Register new matcher. */
-       cache_matcher = rte_calloc(__func__, 1, sizeof(*cache_matcher), 0);
+       cache_matcher = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*cache_matcher), 0,
+                                   SOCKET_ID_ANY);
        if (!cache_matcher) {
                flow_dv_tbl_resource_release(dev, tbl);
                return rte_flow_error_set(error, ENOMEM,
@@ -7601,7 +7624,7 @@ flow_dv_matcher_register(struct rte_eth_dev *dev,
        ret = mlx5_flow_os_create_flow_matcher(sh->ctx, &dv_attr, tbl->obj,
                                               &cache_matcher->matcher_object);
        if (ret) {
-               rte_free(cache_matcher);
+               mlx5_free(cache_matcher);
 #ifdef HAVE_MLX5DV_DR
                flow_dv_tbl_resource_release(dev, tbl);
 #endif
@@ -7676,7 +7699,7 @@ flow_dv_tag_resource_register
        ret = mlx5_flow_os_create_flow_action_tag(tag_be24,
                                                  &cache_resource->action);
        if (ret) {
-               rte_free(cache_resource);
+               mlx5_free(cache_resource);
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL, "cannot create action");
@@ -7685,7 +7708,7 @@ flow_dv_tag_resource_register
        rte_atomic32_inc(&cache_resource->refcnt);
        if (mlx5_hlist_insert(sh->tag_table, &cache_resource->entry)) {
                mlx5_flow_os_destroy_flow_action(cache_resource->action);
-               rte_free(cache_resource);
+               mlx5_free(cache_resource);
                return rte_flow_error_set(error, EEXIST,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
                                          NULL, "cannot insert tag");
@@ -8581,8 +8604,7 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                case RTE_FLOW_ITEM_TYPE_GRE:
                        flow_dv_translate_item_gre(match_mask, match_value,
                                                   items, tunnel);
-                       matcher.priority = rss_desc->level >= 2 ?
-                                   MLX5_PRIORITY_MAP_L2 : MLX5_PRIORITY_MAP_L4;
+                       matcher.priority = MLX5_TUNNEL_PRIO_GET(rss_desc);
                        last_item = MLX5_FLOW_LAYER_GRE;
                        break;
                case RTE_FLOW_ITEM_TYPE_GRE_KEY:
@@ -8593,37 +8615,32 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                case RTE_FLOW_ITEM_TYPE_NVGRE:
                        flow_dv_translate_item_nvgre(match_mask, match_value,
                                                     items, tunnel);
-                       matcher.priority = rss_desc->level >= 2 ?
-                                   MLX5_PRIORITY_MAP_L2 : MLX5_PRIORITY_MAP_L4;
+                       matcher.priority = MLX5_TUNNEL_PRIO_GET(rss_desc);
                        last_item = MLX5_FLOW_LAYER_GRE;
                        break;
                case RTE_FLOW_ITEM_TYPE_VXLAN:
                        flow_dv_translate_item_vxlan(match_mask, match_value,
                                                     items, tunnel);
-                       matcher.priority = rss_desc->level >= 2 ?
-                                   MLX5_PRIORITY_MAP_L2 : MLX5_PRIORITY_MAP_L4;
+                       matcher.priority = MLX5_TUNNEL_PRIO_GET(rss_desc);
                        last_item = MLX5_FLOW_LAYER_VXLAN;
                        break;
                case RTE_FLOW_ITEM_TYPE_VXLAN_GPE:
                        flow_dv_translate_item_vxlan_gpe(match_mask,
                                                         match_value, items,
                                                         tunnel);
-                       matcher.priority = rss_desc->level >= 2 ?
-                                   MLX5_PRIORITY_MAP_L2 : MLX5_PRIORITY_MAP_L4;
+                       matcher.priority = MLX5_TUNNEL_PRIO_GET(rss_desc);
                        last_item = MLX5_FLOW_LAYER_VXLAN_GPE;
                        break;
                case RTE_FLOW_ITEM_TYPE_GENEVE:
                        flow_dv_translate_item_geneve(match_mask, match_value,
                                                      items, tunnel);
-                       matcher.priority = rss_desc->level >= 2 ?
-                                   MLX5_PRIORITY_MAP_L2 : MLX5_PRIORITY_MAP_L4;
+                       matcher.priority = MLX5_TUNNEL_PRIO_GET(rss_desc);
                        last_item = MLX5_FLOW_LAYER_GENEVE;
                        break;
                case RTE_FLOW_ITEM_TYPE_MPLS:
                        flow_dv_translate_item_mpls(match_mask, match_value,
                                                    items, last_item, tunnel);
-                       matcher.priority = rss_desc->level >= 2 ?
-                                   MLX5_PRIORITY_MAP_L2 : MLX5_PRIORITY_MAP_L4;
+                       matcher.priority = MLX5_TUNNEL_PRIO_GET(rss_desc);
                        last_item = MLX5_FLOW_LAYER_MPLS;
                        break;
                case RTE_FLOW_ITEM_TYPE_MARK:
@@ -8665,16 +8682,16 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                case RTE_FLOW_ITEM_TYPE_GTP:
                        flow_dv_translate_item_gtp(match_mask, match_value,
                                                   items, tunnel);
-                       matcher.priority = rss_desc->level >= 2 ?
-                                   MLX5_PRIORITY_MAP_L2 : MLX5_PRIORITY_MAP_L4;
+                       matcher.priority = MLX5_TUNNEL_PRIO_GET(rss_desc);
                        last_item = MLX5_FLOW_LAYER_GTP;
                        break;
                case RTE_FLOW_ITEM_TYPE_ECPRI:
                        if (!mlx5_flex_parser_ecpri_exist(dev)) {
+                               /* Create it only the first time to be used. */
                                ret = mlx5_flex_parser_ecpri_alloc(dev);
                                if (ret)
                                        return rte_flow_error_set
-                                               (error, ret,
+                                               (error, -ret,
                                                RTE_FLOW_ERROR_TYPE_ITEM,
                                                NULL,
                                                "cannot create eCPRI parser");
@@ -8907,7 +8924,7 @@ flow_dv_matcher_release(struct rte_eth_dev *dev,
                LIST_REMOVE(matcher, next);
                /* table ref-- in release interface. */
                flow_dv_tbl_resource_release(dev, matcher->tbl);
-               rte_free(matcher);
+               mlx5_free(matcher);
                DRV_LOG(DEBUG, "port %u matcher %p: removed",
                        dev->data->port_id, (void *)matcher);
                return 0;
@@ -9049,7 +9066,7 @@ flow_dv_modify_hdr_resource_release(struct mlx5_flow_handle *handle)
                claim_zero(mlx5_flow_os_destroy_flow_action
                                                (cache_resource->action));
                LIST_REMOVE(cache_resource, next);
-               rte_free(cache_resource);
+               mlx5_free(cache_resource);
                DRV_LOG(DEBUG, "modify-header resource %p: removed",
                        (void *)cache_resource);
                return 0;
@@ -9422,7 +9439,7 @@ flow_dv_destroy_mtr_tbl(struct rte_eth_dev *dev,
                flow_dv_tbl_resource_release(dev, mtd->transfer.sfx_tbl);
        if (mtd->drop_actn)
                claim_zero(mlx5_flow_os_destroy_flow_action(mtd->drop_actn));
-       rte_free(mtd);
+       mlx5_free(mtd);
        return 0;
 }
 
@@ -9555,7 +9572,7 @@ flow_dv_create_mtr_tbl(struct rte_eth_dev *dev,
                rte_errno = ENOTSUP;
                return NULL;
        }
-       mtb = rte_calloc(__func__, 1, sizeof(*mtb), 0);
+       mtb = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*mtb), 0, SOCKET_ID_ANY);
        if (!mtb) {
                DRV_LOG(ERR, "Failed to allocate memory for meter.");
                return NULL;