net/mlx5: use flow to enable all multi mode
[dpdk.git] / drivers / net / mlx5 / mlx5_rxmode.c
index bcf4231..0c75889 100644 (file)
 /* Verbs header. */
 /* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */
 #ifdef PEDANTIC
-#pragma GCC diagnostic ignored "-pedantic"
+#pragma GCC diagnostic ignored "-Wpedantic"
 #endif
 #include <infiniband/verbs.h>
 #ifdef PEDANTIC
-#pragma GCC diagnostic error "-pedantic"
+#pragma GCC diagnostic error "-Wpedantic"
 #endif
 
-/* DPDK headers don't like -pedantic. */
-#ifdef PEDANTIC
-#pragma GCC diagnostic ignored "-pedantic"
-#endif
 #include <rte_ethdev.h>
-#ifdef PEDANTIC
-#pragma GCC diagnostic error "-pedantic"
-#endif
 
 #include "mlx5.h"
 #include "mlx5_rxtx.h"
 
 /* Initialization data for special flows. */
 static const struct special_flow_init special_flow_init[] = {
-       [HASH_RXQ_FLOW_TYPE_PROMISC] = {
-               .dst_mac_val = "\x00\x00\x00\x00\x00\x00",
-               .dst_mac_mask = "\x00\x00\x00\x00\x00\x00",
-               .hash_types =
-                       1 << HASH_RXQ_TCPV4 |
-                       1 << HASH_RXQ_UDPV4 |
-                       1 << HASH_RXQ_IPV4 |
-#ifdef HAVE_FLOW_SPEC_IPV6
-                       1 << HASH_RXQ_TCPV6 |
-                       1 << HASH_RXQ_UDPV6 |
-                       1 << HASH_RXQ_IPV6 |
-#endif /* HAVE_FLOW_SPEC_IPV6 */
-                       1 << HASH_RXQ_ETH |
-                       0,
-       },
-       [HASH_RXQ_FLOW_TYPE_ALLMULTI] = {
-               .dst_mac_val = "\x01\x00\x00\x00\x00\x00",
-               .dst_mac_mask = "\x01\x00\x00\x00\x00\x00",
-               .hash_types =
-                       1 << HASH_RXQ_UDPV4 |
-                       1 << HASH_RXQ_IPV4 |
-#ifdef HAVE_FLOW_SPEC_IPV6
-                       1 << HASH_RXQ_UDPV6 |
-                       1 << HASH_RXQ_IPV6 |
-#endif /* HAVE_FLOW_SPEC_IPV6 */
-                       1 << HASH_RXQ_ETH |
-                       0,
-       },
        [HASH_RXQ_FLOW_TYPE_BROADCAST] = {
                .dst_mac_val = "\xff\xff\xff\xff\xff\xff",
                .dst_mac_mask = "\xff\xff\xff\xff\xff\xff",
                .hash_types =
                        1 << HASH_RXQ_UDPV4 |
                        1 << HASH_RXQ_IPV4 |
-#ifdef HAVE_FLOW_SPEC_IPV6
                        1 << HASH_RXQ_UDPV6 |
                        1 << HASH_RXQ_IPV6 |
-#endif /* HAVE_FLOW_SPEC_IPV6 */
                        1 << HASH_RXQ_ETH |
                        0,
+               .per_vlan = 1,
        },
-#ifdef HAVE_FLOW_SPEC_IPV6
        [HASH_RXQ_FLOW_TYPE_IPV6MULTI] = {
                .dst_mac_val = "\x33\x33\x00\x00\x00\x00",
                .dst_mac_mask = "\xff\xff\x00\x00\x00\x00",
@@ -110,38 +73,44 @@ static const struct special_flow_init special_flow_init[] = {
                        1 << HASH_RXQ_IPV6 |
                        1 << HASH_RXQ_ETH |
                        0,
+               .per_vlan = 1,
        },
-#endif /* HAVE_FLOW_SPEC_IPV6 */
 };
 
 /**
- * Enable a special flow in a hash RX queue.
+ * Enable a special flow in a hash RX queue for a given VLAN index.
  *
  * @param hash_rxq
  *   Pointer to hash RX queue structure.
  * @param flow_type
  *   Special flow type.
+ * @param vlan_index
+ *   VLAN index to use.
  *
  * @return
  *   0 on success, errno value on failure.
  */
 static int
-hash_rxq_special_flow_enable(struct hash_rxq *hash_rxq,
-                            enum hash_rxq_flow_type flow_type)
+hash_rxq_special_flow_enable_vlan(struct hash_rxq *hash_rxq,
+                                 enum hash_rxq_flow_type flow_type,
+                                 unsigned int vlan_index)
 {
        struct priv *priv = hash_rxq->priv;
-       struct ibv_exp_flow *flow;
+       struct ibv_flow *flow;
        FLOW_ATTR_SPEC_ETH(data, priv_flow_attr(priv, NULL, 0, hash_rxq->type));
-       struct ibv_exp_flow_attr *attr = &data->attr;
-       struct ibv_exp_flow_spec_eth *spec = &data->spec;
+       struct ibv_flow_attr *attr = &data->attr;
+       struct ibv_flow_spec_eth *spec = &data->spec;
        const uint8_t *mac;
        const uint8_t *mask;
+       unsigned int vlan_enabled = (priv->vlan_filter_n &&
+                                    special_flow_init[flow_type].per_vlan);
+       unsigned int vlan_id = priv->vlan_filter[vlan_index];
 
        /* Check if flow is relevant for this hash_rxq. */
        if (!(special_flow_init[flow_type].hash_types & (1 << hash_rxq->type)))
                return 0;
        /* Check if flow already exists. */
-       if (hash_rxq->special_flow[flow_type] != NULL)
+       if (hash_rxq->special_flow[flow_type][vlan_index] != NULL)
                return 0;
 
        /*
@@ -151,30 +120,36 @@ hash_rxq_special_flow_enable(struct hash_rxq *hash_rxq,
        assert(((uint8_t *)attr + sizeof(*attr)) == (uint8_t *)spec);
        priv_flow_attr(priv, attr, sizeof(data), hash_rxq->type);
        /* The first specification must be Ethernet. */
-       assert(spec->type == IBV_EXP_FLOW_SPEC_ETH);
+       assert(spec->type == IBV_FLOW_SPEC_ETH);
        assert(spec->size == sizeof(*spec));
 
        mac = special_flow_init[flow_type].dst_mac_val;
        mask = special_flow_init[flow_type].dst_mac_mask;
-       *spec = (struct ibv_exp_flow_spec_eth){
-               .type = IBV_EXP_FLOW_SPEC_ETH,
+       *spec = (struct ibv_flow_spec_eth){
+               .type = IBV_FLOW_SPEC_ETH,
                .size = sizeof(*spec),
                .val = {
                        .dst_mac = {
                                mac[0], mac[1], mac[2],
                                mac[3], mac[4], mac[5],
                        },
+                       .vlan_tag = (vlan_enabled ?
+                                    rte_cpu_to_be_16(vlan_id) :
+                                    0),
                },
                .mask = {
                        .dst_mac = {
                                mask[0], mask[1], mask[2],
                                mask[3], mask[4], mask[5],
                        },
+                       .vlan_tag = (vlan_enabled ?
+                                    rte_cpu_to_be_16(0xfff) :
+                                    0),
                },
        };
 
        errno = 0;
-       flow = ibv_exp_create_flow(hash_rxq->qp, attr);
+       flow = ibv_create_flow(hash_rxq->qp, attr);
        if (flow == NULL) {
                /* It's not clear whether errno is always set in this case. */
                ERROR("%p: flow configuration failed, errno=%d: %s",
@@ -184,9 +159,77 @@ hash_rxq_special_flow_enable(struct hash_rxq *hash_rxq,
                        return errno;
                return EINVAL;
        }
-       hash_rxq->special_flow[flow_type] = flow;
-       DEBUG("%p: enabling special flow %s (%d)",
-             (void *)hash_rxq, hash_rxq_flow_type_str(flow_type), flow_type);
+       hash_rxq->special_flow[flow_type][vlan_index] = flow;
+       DEBUG("%p: special flow %s (index %d) VLAN %u (index %u) enabled",
+             (void *)hash_rxq, hash_rxq_flow_type_str(flow_type), flow_type,
+             vlan_id, vlan_index);
+       return 0;
+}
+
+/**
+ * Disable a special flow in a hash RX queue for a given VLAN index.
+ *
+ * @param hash_rxq
+ *   Pointer to hash RX queue structure.
+ * @param flow_type
+ *   Special flow type.
+ * @param vlan_index
+ *   VLAN index to use.
+ */
+static void
+hash_rxq_special_flow_disable_vlan(struct hash_rxq *hash_rxq,
+                                  enum hash_rxq_flow_type flow_type,
+                                  unsigned int vlan_index)
+{
+       struct ibv_flow *flow =
+               hash_rxq->special_flow[flow_type][vlan_index];
+
+       if (flow == NULL)
+               return;
+       claim_zero(ibv_destroy_flow(flow));
+       hash_rxq->special_flow[flow_type][vlan_index] = NULL;
+       DEBUG("%p: special flow %s (index %d) VLAN %u (index %u) disabled",
+             (void *)hash_rxq, hash_rxq_flow_type_str(flow_type), flow_type,
+             hash_rxq->priv->vlan_filter[vlan_index], vlan_index);
+}
+
+/**
+ * Enable a special flow in a hash RX queue.
+ *
+ * @param hash_rxq
+ *   Pointer to hash RX queue structure.
+ * @param flow_type
+ *   Special flow type.
+ * @param vlan_index
+ *   VLAN index to use.
+ *
+ * @return
+ *   0 on success, errno value on failure.
+ */
+static int
+hash_rxq_special_flow_enable(struct hash_rxq *hash_rxq,
+                            enum hash_rxq_flow_type flow_type)
+{
+       struct priv *priv = hash_rxq->priv;
+       unsigned int i = 0;
+       int ret;
+
+       assert((unsigned int)flow_type < RTE_DIM(hash_rxq->special_flow));
+       assert(RTE_DIM(hash_rxq->special_flow[flow_type]) ==
+              RTE_DIM(priv->vlan_filter));
+       /* Add a special flow for each VLAN filter when relevant. */
+       do {
+               ret = hash_rxq_special_flow_enable_vlan(hash_rxq, flow_type, i);
+               if (ret) {
+                       /* Failure, rollback. */
+                       while (i != 0)
+                               hash_rxq_special_flow_disable_vlan(hash_rxq,
+                                                                  flow_type,
+                                                                  --i);
+                       return ret;
+               }
+       } while (special_flow_init[flow_type].per_vlan &&
+                ++i < priv->vlan_filter_n);
        return 0;
 }
 
@@ -202,14 +245,11 @@ static void
 hash_rxq_special_flow_disable(struct hash_rxq *hash_rxq,
                              enum hash_rxq_flow_type flow_type)
 {
-       if (hash_rxq->special_flow[flow_type] == NULL)
-               return;
-       DEBUG("%p: disabling special flow %s (%d)",
-             (void *)hash_rxq, hash_rxq_flow_type_str(flow_type), flow_type);
-       claim_zero(ibv_exp_destroy_flow(hash_rxq->special_flow[flow_type]));
-       hash_rxq->special_flow[flow_type] = NULL;
-       DEBUG("%p: special flow %s (%d) disabled",
-             (void *)hash_rxq, hash_rxq_flow_type_str(flow_type), flow_type);
+       unsigned int i;
+
+       assert((unsigned int)flow_type < RTE_DIM(hash_rxq->special_flow));
+       for (i = 0; (i != RTE_DIM(hash_rxq->special_flow[flow_type])); ++i)
+               hash_rxq_special_flow_disable_vlan(hash_rxq, flow_type, i);
 }
 
 /**
@@ -278,7 +318,11 @@ priv_special_flow_enable_all(struct priv *priv)
 {
        enum hash_rxq_flow_type flow_type;
 
-       for (flow_type = 0; flow_type != HASH_RXQ_FLOW_TYPE_MAC; ++flow_type) {
+       if (priv->isolated)
+               return 0;
+       for (flow_type = HASH_RXQ_FLOW_TYPE_BROADCAST;
+                       flow_type != HASH_RXQ_FLOW_TYPE_MAC;
+                       ++flow_type) {
                int ret;
 
                ret = priv_special_flow_enable(priv, flow_type);
@@ -303,7 +347,9 @@ priv_special_flow_disable_all(struct priv *priv)
 {
        enum hash_rxq_flow_type flow_type;
 
-       for (flow_type = 0; flow_type != HASH_RXQ_FLOW_TYPE_MAC; ++flow_type)
+       for (flow_type = HASH_RXQ_FLOW_TYPE_BROADCAST;
+                       flow_type != HASH_RXQ_FLOW_TYPE_MAC;
+                       ++flow_type)
                priv_special_flow_disable(priv, flow_type);
 }
 
@@ -316,16 +362,16 @@ priv_special_flow_disable_all(struct priv *priv)
 void
 mlx5_promiscuous_enable(struct rte_eth_dev *dev)
 {
-       struct priv *priv = dev->data->dev_private;
-       int ret;
+       struct rte_flow_item_eth eth = {
+               .dst.addr_bytes = "\x00\x00\x00\x00\x00\x00",
+               .src.addr_bytes = "\x00\x00\x00\x00\x00\x00",
+               .type = 0,
+       };
 
-       priv_lock(priv);
-       priv->promisc_req = 1;
-       ret = priv_rehash_flows(priv);
-       if (ret)
-               ERROR("error while enabling promiscuous mode: %s",
-                     strerror(ret));
-       priv_unlock(priv);
+       if (mlx5_is_secondary())
+               return;
+       dev->data->promiscuous = 1;
+       claim_zero(mlx5_ctrl_flow(dev, &eth, &eth, 1));
 }
 
 /**
@@ -337,16 +383,16 @@ mlx5_promiscuous_enable(struct rte_eth_dev *dev)
 void
 mlx5_promiscuous_disable(struct rte_eth_dev *dev)
 {
-       struct priv *priv = dev->data->dev_private;
-       int ret;
+       struct rte_flow_item_eth eth = {
+               .dst.addr_bytes = "\x00\x00\x00\x00\x00\x00",
+               .src.addr_bytes = "\x00\x00\x00\x00\x00\x00",
+               .type = 0,
+       };
 
-       priv_lock(priv);
-       priv->promisc_req = 0;
-       ret = priv_rehash_flows(priv);
-       if (ret)
-               ERROR("error while disabling promiscuous mode: %s",
-                     strerror(ret));
-       priv_unlock(priv);
+       if (mlx5_is_secondary())
+               return;
+       dev->data->promiscuous = 0;
+       claim_zero(mlx5_ctrl_flow(dev, &eth, &eth, 0));
 }
 
 /**
@@ -358,16 +404,17 @@ mlx5_promiscuous_disable(struct rte_eth_dev *dev)
 void
 mlx5_allmulticast_enable(struct rte_eth_dev *dev)
 {
-       struct priv *priv = dev->data->dev_private;
-       int ret;
+       struct rte_flow_item_eth eth = {
+               .dst.addr_bytes = "\x01\x00\x00\x00\x00\x00",
+               .src.addr_bytes = "\x01\x00\x00\x00\x00\x00",
+               .type = 0,
+       };
 
-       priv_lock(priv);
-       priv->allmulti_req = 1;
-       ret = priv_rehash_flows(priv);
-       if (ret)
-               ERROR("error while enabling allmulticast mode: %s",
-                     strerror(ret));
-       priv_unlock(priv);
+       if (mlx5_is_secondary())
+               return;
+       dev->data->all_multicast = 1;
+       if (dev->data->dev_started)
+               claim_zero(mlx5_ctrl_flow(dev, &eth, &eth, 1));
 }
 
 /**
@@ -379,14 +426,15 @@ mlx5_allmulticast_enable(struct rte_eth_dev *dev)
 void
 mlx5_allmulticast_disable(struct rte_eth_dev *dev)
 {
-       struct priv *priv = dev->data->dev_private;
-       int ret;
+       struct rte_flow_item_eth eth = {
+               .dst.addr_bytes = "\x01\x00\x00\x00\x00\x00",
+               .src.addr_bytes = "\x01\x00\x00\x00\x00\x00",
+               .type = 0,
+       };
 
-       priv_lock(priv);
-       priv->allmulti_req = 0;
-       ret = priv_rehash_flows(priv);
-       if (ret)
-               ERROR("error while disabling allmulticast mode: %s",
-                     strerror(ret));
-       priv_unlock(priv);
+       if (mlx5_is_secondary())
+               return;
+       dev->data->all_multicast = 0;
+       if (dev->data->dev_started)
+               claim_zero(mlx5_ctrl_flow(dev, &eth, &eth, 0));
 }