net/mlx5: remove useless empty lines
[dpdk.git] / drivers / net / mlx5 / mlx5_rxq.c
index 8e4fbbf..320a12b 100644 (file)
@@ -1,34 +1,6 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright 2015 6WIND S.A.
- *   Copyright 2015 Mellanox.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of 6WIND S.A. nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2015 6WIND S.A.
+ * Copyright 2015 Mellanox.
  */
 
 #include <stddef.h>
@@ -63,6 +35,7 @@
 #include "mlx5_utils.h"
 #include "mlx5_autoconf.h"
 #include "mlx5_defs.h"
+#include "mlx5_glue.h"
 
 /* Default RSS hash key also used for ConnectX-3. */
 uint8_t rss_hash_default_key[] = {
@@ -517,7 +490,6 @@ mlx5_arm_cq(struct mlx5_rxq_data *rxq, int sq_n_rxq)
        doorbell = (uint64_t)doorbell_hi << 32;
        doorbell |=  rxq->cqn;
        rxq->cq_db[MLX5_CQ_ARM_DB] = rte_cpu_to_be_32(doorbell_hi);
-       rte_wmb();
        rte_write64(rte_cpu_to_be_64(doorbell), cq_db_reg);
 }
 
@@ -601,13 +573,13 @@ mlx5_rx_intr_disable(struct rte_eth_dev *dev, uint16_t rx_queue_id)
                ret = EINVAL;
                goto exit;
        }
-       ret = ibv_get_cq_event(rxq_ibv->channel, &ev_cq, &ev_ctx);
+       ret = mlx5_glue->get_cq_event(rxq_ibv->channel, &ev_cq, &ev_ctx);
        if (ret || ev_cq != rxq_ibv->cq) {
                ret = EINVAL;
                goto exit;
        }
        rxq_data->cq_arm_sn++;
-       ibv_ack_cq_events(rxq_ibv->cq, 1);
+       mlx5_glue->ack_cq_events(rxq_ibv->cq, 1);
 exit:
        if (rxq_ibv)
                mlx5_priv_rxq_ibv_release(priv, rxq_ibv);
@@ -629,7 +601,7 @@ exit:
  * @return
  *   The Verbs object initialised if it can be created.
  */
-struct mlx5_rxq_ibv*
+struct mlx5_rxq_ibv *
 mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
 {
        struct mlx5_rxq_data *rxq_data = (*priv->rxqs)[idx];
@@ -655,6 +627,8 @@ mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
 
        assert(rxq_data);
        assert(!rxq_ctrl->ibv);
+       priv->verbs_alloc_ctx.type = MLX5_VERBS_ALLOC_TYPE_RX_QUEUE;
+       priv->verbs_alloc_ctx.obj = rxq_ctrl;
        tmpl = rte_calloc_socket(__func__, 1, sizeof(*tmpl), 0,
                                 rxq_ctrl->socket);
        if (!tmpl) {
@@ -673,7 +647,7 @@ mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
                }
        }
        if (rxq_ctrl->irq) {
-               tmpl->channel = ibv_create_comp_channel(priv->ctx);
+               tmpl->channel = mlx5_glue->create_comp_channel(priv->ctx);
                if (!tmpl->channel) {
                        ERROR("%p: Comp Channel creation failure",
                              (void *)rxq_ctrl);
@@ -701,8 +675,9 @@ mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
        } else if (config->cqe_comp && rxq_data->hw_timestamp) {
                DEBUG("Rx CQE compression is disabled for HW timestamp");
        }
-       tmpl->cq = ibv_cq_ex_to_cq(mlx5dv_create_cq(priv->ctx, &attr.cq.ibv,
-                                                   &attr.cq.mlx5));
+       tmpl->cq = mlx5_glue->cq_ex_to_cq
+               (mlx5_glue->dv_create_cq(priv->ctx, &attr.cq.ibv,
+                                        &attr.cq.mlx5));
        if (tmpl->cq == NULL) {
                ERROR("%p: CQ creation failure", (void *)rxq_ctrl);
                goto error;
@@ -738,7 +713,7 @@ mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
                attr.wq.comp_mask |= IBV_WQ_INIT_ATTR_FLAGS;
        }
 #endif
-       tmpl->wq = ibv_create_wq(priv->ctx, &attr.wq);
+       tmpl->wq = mlx5_glue->create_wq(priv->ctx, &attr.wq);
        if (tmpl->wq == NULL) {
                ERROR("%p: WQ creation failure", (void *)rxq_ctrl);
                goto error;
@@ -762,7 +737,7 @@ mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
                .attr_mask = IBV_WQ_ATTR_STATE,
                .wq_state = IBV_WQS_RDY,
        };
-       ret = ibv_modify_wq(tmpl->wq, &mod);
+       ret = mlx5_glue->modify_wq(tmpl->wq, &mod);
        if (ret) {
                ERROR("%p: WQ state to IBV_WQS_RDY failed",
                      (void *)rxq_ctrl);
@@ -772,7 +747,7 @@ mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
        obj.cq.out = &cq_info;
        obj.rwq.in = tmpl->wq;
        obj.rwq.out = &rwq;
-       ret = mlx5dv_init_obj(&obj, MLX5DV_OBJ_CQ | MLX5DV_OBJ_RWQ);
+       ret = mlx5_glue->dv_init_obj(&obj, MLX5DV_OBJ_CQ | MLX5DV_OBJ_RWQ);
        if (ret != 0)
                goto error;
        if (cq_info.cqe_size != RTE_CACHE_LINE_SIZE) {
@@ -818,16 +793,18 @@ mlx5_priv_rxq_ibv_new(struct priv *priv, uint16_t idx)
        DEBUG("%p: Verbs Rx queue %p: refcnt %d", (void *)priv,
              (void *)tmpl, rte_atomic32_read(&tmpl->refcnt));
        LIST_INSERT_HEAD(&priv->rxqsibv, tmpl, next);
+       priv->verbs_alloc_ctx.type = MLX5_VERBS_ALLOC_TYPE_NONE;
        return tmpl;
 error:
        if (tmpl->wq)
-               claim_zero(ibv_destroy_wq(tmpl->wq));
+               claim_zero(mlx5_glue->destroy_wq(tmpl->wq));
        if (tmpl->cq)
-               claim_zero(ibv_destroy_cq(tmpl->cq));
+               claim_zero(mlx5_glue->destroy_cq(tmpl->cq));
        if (tmpl->channel)
-               claim_zero(ibv_destroy_comp_channel(tmpl->channel));
+               claim_zero(mlx5_glue->destroy_comp_channel(tmpl->channel));
        if (tmpl->mr)
                priv_mr_release(priv, tmpl->mr);
+       priv->verbs_alloc_ctx.type = MLX5_VERBS_ALLOC_TYPE_NONE;
        return NULL;
 }
 
@@ -842,7 +819,7 @@ error:
  * @return
  *   The Verbs object if it exists.
  */
-struct mlx5_rxq_ibv*
+struct mlx5_rxq_ibv *
 mlx5_priv_rxq_ibv_get(struct priv *priv, uint16_t idx)
 {
        struct mlx5_rxq_data *rxq_data = (*priv->rxqs)[idx];
@@ -890,10 +867,11 @@ mlx5_priv_rxq_ibv_release(struct priv *priv, struct mlx5_rxq_ibv *rxq_ibv)
              (void *)rxq_ibv, rte_atomic32_read(&rxq_ibv->refcnt));
        if (rte_atomic32_dec_and_test(&rxq_ibv->refcnt)) {
                rxq_free_elts(rxq_ibv->rxq_ctrl);
-               claim_zero(ibv_destroy_wq(rxq_ibv->wq));
-               claim_zero(ibv_destroy_cq(rxq_ibv->cq));
+               claim_zero(mlx5_glue->destroy_wq(rxq_ibv->wq));
+               claim_zero(mlx5_glue->destroy_cq(rxq_ibv->cq));
                if (rxq_ibv->channel)
-                       claim_zero(ibv_destroy_comp_channel(rxq_ibv->channel));
+                       claim_zero(mlx5_glue->destroy_comp_channel
+                                  (rxq_ibv->channel));
                LIST_REMOVE(rxq_ibv, next);
                rte_free(rxq_ibv);
                return 0;
@@ -905,9 +883,10 @@ mlx5_priv_rxq_ibv_release(struct priv *priv, struct mlx5_rxq_ibv *rxq_ibv)
  * Verify the Verbs Rx queue list is empty
  *
  * @param priv
- *  Pointer to private structure.
+ *   Pointer to private structure.
  *
- * @return the number of object not released.
+ * @return
+ *   The number of object not released.
  */
 int
 mlx5_priv_rxq_ibv_verify(struct priv *priv)
@@ -932,9 +911,9 @@ mlx5_priv_rxq_ibv_verify(struct priv *priv)
  *   Verbs Rx queue object.
  */
 int
-mlx5_priv_rxq_ibv_releasable(struct priv *priv, struct mlx5_rxq_ibv *rxq_ibv)
+mlx5_priv_rxq_ibv_releasable(struct priv *priv __rte_unused,
+                            struct mlx5_rxq_ibv *rxq_ibv)
 {
-       (void)priv;
        assert(rxq_ibv);
        return (rte_atomic32_read(&rxq_ibv->refcnt) == 1);
 }
@@ -954,7 +933,7 @@ mlx5_priv_rxq_ibv_releasable(struct priv *priv, struct mlx5_rxq_ibv *rxq_ibv)
  * @return
  *   A DPDK queue object on success.
  */
-struct mlx5_rxq_ctrl*
+struct mlx5_rxq_ctrl *
 mlx5_priv_rxq_new(struct priv *priv, uint16_t idx, uint16_t desc,
                  unsigned int socket, const struct rte_eth_rxconf *conf,
                  struct rte_mempool *mp)
@@ -1028,7 +1007,7 @@ mlx5_priv_rxq_new(struct priv *priv, uint16_t idx, uint16_t desc,
        /* Toggle RX checksum offload if hardware supports it. */
        tmpl->rxq.csum = !!(conf->offloads & DEV_RX_OFFLOAD_CHECKSUM);
        tmpl->rxq.csum_l2tun = (!!(conf->offloads & DEV_RX_OFFLOAD_CHECKSUM) &&
-                               priv->config.hw_csum_l2tun);
+                               priv->config.tunnel_en);
        tmpl->rxq.hw_timestamp = !!(conf->offloads & DEV_RX_OFFLOAD_TIMESTAMP);
        /* Configure VLAN stripping. */
        tmpl->rxq.vlan_strip = !!(conf->offloads & DEV_RX_OFFLOAD_VLAN_STRIP);
@@ -1079,7 +1058,7 @@ error:
  * @return
  *   A pointer to the queue if it exists.
  */
-struct mlx5_rxq_ctrl*
+struct mlx5_rxq_ctrl *
 mlx5_priv_rxq_get(struct priv *priv, uint16_t idx)
 {
        struct mlx5_rxq_ctrl *rxq_ctrl = NULL;
@@ -1088,7 +1067,6 @@ mlx5_priv_rxq_get(struct priv *priv, uint16_t idx)
                rxq_ctrl = container_of((*priv->rxqs)[idx],
                                        struct mlx5_rxq_ctrl,
                                        rxq);
-
                mlx5_priv_rxq_ibv_get(priv, idx);
                rte_atomic32_inc(&rxq_ctrl->refcnt);
                DEBUG("%p: Rx queue %p: refcnt %d", (void *)priv,
@@ -1161,9 +1139,10 @@ mlx5_priv_rxq_releasable(struct priv *priv, uint16_t idx)
  * Verify the Rx Queue list is empty
  *
  * @param priv
- *  Pointer to private structure.
+ *   Pointer to private structure.
  *
- * @return the number of object not released.
+ * @return
+ *   The number of object not released.
  */
 int
 mlx5_priv_rxq_verify(struct priv *priv)
@@ -1192,14 +1171,14 @@ mlx5_priv_rxq_verify(struct priv *priv)
  * @return
  *   A new indirection table.
  */
-struct mlx5_ind_table_ibv*
+struct mlx5_ind_table_ibv *
 mlx5_priv_ind_table_ibv_new(struct priv *priv, uint16_t queues[],
                            uint16_t queues_n)
 {
        struct mlx5_ind_table_ibv *ind_tbl;
        const unsigned int wq_n = rte_is_power_of_2(queues_n) ?
                log2above(queues_n) :
-               log2above(priv->ind_table_max_size);
+               log2above(priv->config.ind_table_max_size);
        struct ibv_wq *wq[1 << wq_n];
        unsigned int i;
        unsigned int j;
@@ -1221,13 +1200,13 @@ mlx5_priv_ind_table_ibv_new(struct priv *priv, uint16_t queues[],
        /* Finalise indirection table. */
        for (j = 0; i != (unsigned int)(1 << wq_n); ++i, ++j)
                wq[i] = wq[j];
-       ind_tbl->ind_table = ibv_create_rwq_ind_table(
-               priv->ctx,
-               &(struct ibv_rwq_ind_table_init_attr){
+       ind_tbl->ind_table = mlx5_glue->create_rwq_ind_table
+               (priv->ctx,
+                &(struct ibv_rwq_ind_table_init_attr){
                        .log_ind_tbl_size = wq_n,
                        .ind_tbl = wq,
                        .comp_mask = 0,
-               });
+                });
        if (!ind_tbl->ind_table)
                goto error;
        rte_atomic32_inc(&ind_tbl->refcnt);
@@ -1254,7 +1233,7 @@ error:
  * @return
  *   An indirection table if found.
  */
-struct mlx5_ind_table_ibv*
+struct mlx5_ind_table_ibv *
 mlx5_priv_ind_table_ibv_get(struct priv *priv, uint16_t queues[],
                            uint16_t queues_n)
 {
@@ -1299,7 +1278,8 @@ mlx5_priv_ind_table_ibv_release(struct priv *priv,
        DEBUG("%p: Indirection table %p: refcnt %d", (void *)priv,
              (void *)ind_tbl, rte_atomic32_read(&ind_tbl->refcnt));
        if (rte_atomic32_dec_and_test(&ind_tbl->refcnt))
-               claim_zero(ibv_destroy_rwq_ind_table(ind_tbl->ind_table));
+               claim_zero(mlx5_glue->destroy_rwq_ind_table
+                          (ind_tbl->ind_table));
        for (i = 0; i != ind_tbl->queues_n; ++i)
                claim_nonzero(mlx5_priv_rxq_release(priv, ind_tbl->queues[i]));
        if (!rte_atomic32_read(&ind_tbl->refcnt)) {
@@ -1314,9 +1294,10 @@ mlx5_priv_ind_table_ibv_release(struct priv *priv,
  * Verify the Rx Queue list is empty
  *
  * @param priv
- *  Pointer to private structure.
+ *   Pointer to private structure.
  *
- * @return the number of object not released.
+ * @return
+ *   The number of object not released.
  */
 int
 mlx5_priv_ind_table_ibv_verify(struct priv *priv)
@@ -1352,7 +1333,7 @@ mlx5_priv_ind_table_ibv_verify(struct priv *priv)
  * @return
  *   An hash Rx queue on success.
  */
-struct mlx5_hrxq*
+struct mlx5_hrxq *
 mlx5_priv_hrxq_new(struct priv *priv, uint8_t *rss_key, uint8_t rss_key_len,
                   uint64_t hash_fields, uint16_t queues[], uint16_t queues_n)
 {
@@ -1366,9 +1347,9 @@ mlx5_priv_hrxq_new(struct priv *priv, uint8_t *rss_key, uint8_t rss_key_len,
                ind_tbl = mlx5_priv_ind_table_ibv_new(priv, queues, queues_n);
        if (!ind_tbl)
                return NULL;
-       qp = ibv_create_qp_ex(
-               priv->ctx,
-               &(struct ibv_qp_init_attr_ex){
+       qp = mlx5_glue->create_qp_ex
+               (priv->ctx,
+                &(struct ibv_qp_init_attr_ex){
                        .qp_type = IBV_QPT_RAW_PACKET,
                        .comp_mask =
                                IBV_QP_INIT_ATTR_PD |
@@ -1382,7 +1363,7 @@ mlx5_priv_hrxq_new(struct priv *priv, uint8_t *rss_key, uint8_t rss_key_len,
                        },
                        .rwq_ind_tbl = ind_tbl->ind_table,
                        .pd = priv->pd,
-               });
+                });
        if (!qp)
                goto error;
        hrxq = rte_calloc(__func__, 1, sizeof(*hrxq) + rss_key_len, 0);
@@ -1401,7 +1382,7 @@ mlx5_priv_hrxq_new(struct priv *priv, uint8_t *rss_key, uint8_t rss_key_len,
 error:
        mlx5_priv_ind_table_ibv_release(priv, ind_tbl);
        if (qp)
-               claim_zero(ibv_destroy_qp(qp));
+               claim_zero(mlx5_glue->destroy_qp(qp));
        return NULL;
 }
 
@@ -1421,7 +1402,7 @@ error:
  * @return
  *   An hash Rx queue on success.
  */
-struct mlx5_hrxq*
+struct mlx5_hrxq *
 mlx5_priv_hrxq_get(struct priv *priv, uint8_t *rss_key, uint8_t rss_key_len,
                   uint64_t hash_fields, uint16_t queues[], uint16_t queues_n)
 {
@@ -1469,7 +1450,7 @@ mlx5_priv_hrxq_release(struct priv *priv, struct mlx5_hrxq *hrxq)
        DEBUG("%p: Hash Rx queue %p: refcnt %d", (void *)priv,
              (void *)hrxq, rte_atomic32_read(&hrxq->refcnt));
        if (rte_atomic32_dec_and_test(&hrxq->refcnt)) {
-               claim_zero(ibv_destroy_qp(hrxq->qp));
+               claim_zero(mlx5_glue->destroy_qp(hrxq->qp));
                mlx5_priv_ind_table_ibv_release(priv, hrxq->ind_table);
                LIST_REMOVE(hrxq, next);
                rte_free(hrxq);
@@ -1483,9 +1464,10 @@ mlx5_priv_hrxq_release(struct priv *priv, struct mlx5_hrxq *hrxq)
  * Verify the Rx Queue list is empty
  *
  * @param priv
- *  Pointer to private structure.
+ *   Pointer to private structure.
  *
- * @return the number of object not released.
+ * @return
+ *   The number of object not released.
  */
 int
 mlx5_priv_hrxq_ibv_verify(struct priv *priv)