common/mlx5: introduce common library
[dpdk.git] / drivers / net / mlx5 / mlx5_stats.c
index 875dd10..0ed7170 100644 (file)
 #include <rte_common.h>
 #include <rte_malloc.h>
 
+#include "mlx5_defs.h"
 #include "mlx5.h"
 #include "mlx5_rxtx.h"
-#include "mlx5_defs.h"
-
-struct mlx5_counter_ctrl {
-       /* Name of the counter. */
-       char dpdk_name[RTE_ETH_XSTATS_NAME_SIZE];
-       /* Name of the counter on the device table. */
-       char ctr_name[RTE_ETH_XSTATS_NAME_SIZE];
-       uint32_t ib:1; /**< Nonzero for IB counters. */
-};
 
 static const struct mlx5_counter_ctrl mlx5_counters_init[] = {
        {
@@ -107,6 +99,14 @@ static const struct mlx5_counter_ctrl mlx5_counters_init[] = {
                .dpdk_name = "rx_packets_phy",
                .ctr_name = "rx_packets_phy",
        },
+       {
+               .dpdk_name = "tx_discards_phy",
+               .ctr_name = "tx_discards_phy",
+       },
+       {
+               .dpdk_name = "rx_discards_phy",
+               .ctr_name = "rx_discards_phy",
+       },
        {
                .dpdk_name = "tx_bytes_phy",
                .ctr_name = "tx_bytes_phy",
@@ -115,10 +115,49 @@ static const struct mlx5_counter_ctrl mlx5_counters_init[] = {
                .dpdk_name = "rx_bytes_phy",
                .ctr_name = "rx_bytes_phy",
        },
+       /* Representor only */
+       {
+               .dpdk_name = "rx_packets",
+               .ctr_name = "vport_rx_packets",
+       },
+       {
+               .dpdk_name = "rx_bytes",
+               .ctr_name = "vport_rx_bytes",
+       },
+       {
+               .dpdk_name = "tx_packets",
+               .ctr_name = "vport_tx_packets",
+       },
+       {
+               .dpdk_name = "tx_bytes",
+               .ctr_name = "vport_tx_bytes",
+       },
 };
 
 static const unsigned int xstats_n = RTE_DIM(mlx5_counters_init);
 
+static inline void
+mlx5_read_ib_stat(struct mlx5_priv *priv, const char *ctr_name, uint64_t *stat)
+{
+       FILE *file;
+       if (priv->sh) {
+               MKSTR(path, "%s/ports/%d/hw_counters/%s",
+                         priv->sh->ibdev_path,
+                         priv->ibv_port,
+                         ctr_name);
+
+               file = fopen(path, "rb");
+               if (file) {
+                       int n = fscanf(file, "%" SCNu64, stat);
+
+                       fclose(file);
+                       if (n == 1)
+                               return;
+               }
+       }
+       *stat = 0;
+}
+
 /**
  * Read device counters table.
  *
@@ -134,7 +173,7 @@ static const unsigned int xstats_n = RTE_DIM(mlx5_counters_init);
 static int
 mlx5_read_dev_counters(struct rte_eth_dev *dev, uint64_t *stats)
 {
-       struct priv *priv = dev->data->dev_private;
+       struct mlx5_priv *priv = dev->data->dev_private;
        struct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;
        unsigned int i;
        struct ifreq ifr;
@@ -153,21 +192,10 @@ mlx5_read_dev_counters(struct rte_eth_dev *dev, uint64_t *stats)
                        dev->data->port_id);
                return ret;
        }
-       for (i = 0; i != xstats_n; ++i) {
-               if (mlx5_counters_init[i].ib) {
-                       FILE *file;
-                       MKSTR(path, "%s/ports/1/hw_counters/%s",
-                             priv->ibdev_path,
-                             mlx5_counters_init[i].ctr_name);
-
-                       file = fopen(path, "rb");
-                       if (file) {
-                               int n = fscanf(file, "%" SCNu64, &stats[i]);
-
-                               fclose(file);
-                               if (n != 1)
-                                       stats[i] = 0;
-                       }
+       for (i = 0; i != xstats_ctrl->mlx5_stats_n; ++i) {
+               if (xstats_ctrl->info[i].ib) {
+                       mlx5_read_ib_stat(priv, xstats_ctrl->info[i].ctr_name,
+                                         &stats[i]);
                } else {
                        stats[i] = (uint64_t)
                                et_stats->data[xstats_ctrl->dev_table_idx[i]];
@@ -210,10 +238,11 @@ mlx5_ethtool_get_stats_n(struct rte_eth_dev *dev) {
  *   Pointer to Ethernet device.
  */
 void
-mlx5_xstats_init(struct rte_eth_dev *dev)
+mlx5_stats_init(struct rte_eth_dev *dev)
 {
-       struct priv *priv = dev->data->dev_private;
+       struct mlx5_priv *priv = dev->data->dev_private;
        struct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;
+       struct mlx5_stats_ctrl *stats_ctrl = &priv->stats_ctrl;
        unsigned int i;
        unsigned int j;
        struct ifreq ifr;
@@ -222,6 +251,8 @@ mlx5_xstats_init(struct rte_eth_dev *dev)
        unsigned int str_sz;
        int ret;
 
+       /* So that it won't aggregate for each init. */
+       xstats_ctrl->mlx5_stats_n = 0;
        ret = mlx5_ethtool_get_stats_n(dev);
        if (ret < 0) {
                DRV_LOG(WARNING, "port %u no extended statistics available",
@@ -229,7 +260,6 @@ mlx5_xstats_init(struct rte_eth_dev *dev)
                return;
        }
        dev_stats_n = ret;
-       xstats_ctrl->stats_n = dev_stats_n;
        /* Allocate memory to grab stat names and values. */
        str_sz = dev_stats_n * ETH_GSTRING_LEN;
        strings = (struct ethtool_gstrings *)
@@ -250,8 +280,6 @@ mlx5_xstats_init(struct rte_eth_dev *dev)
                        dev->data->port_id);
                goto free;
        }
-       for (j = 0; j != xstats_n; ++j)
-               xstats_ctrl->dev_table_idx[j] = dev_stats_n;
        for (i = 0; i != dev_stats_n; ++i) {
                const char *curr_string = (const char *)
                        &strings->data[i * ETH_GSTRING_LEN];
@@ -259,28 +287,30 @@ mlx5_xstats_init(struct rte_eth_dev *dev)
                for (j = 0; j != xstats_n; ++j) {
                        if (!strcmp(mlx5_counters_init[j].ctr_name,
                                    curr_string)) {
-                               xstats_ctrl->dev_table_idx[j] = i;
+                               unsigned int idx = xstats_ctrl->mlx5_stats_n++;
+
+                               xstats_ctrl->dev_table_idx[idx] = i;
+                               xstats_ctrl->info[idx] = mlx5_counters_init[j];
                                break;
                        }
                }
        }
-       for (j = 0; j != xstats_n; ++j) {
-               if (mlx5_counters_init[j].ib)
-                       continue;
-               if (xstats_ctrl->dev_table_idx[j] >= dev_stats_n) {
-                       DRV_LOG(WARNING,
-                               "port %u counter \"%s\" is not recognized",
-                               dev->data->port_id,
-                               mlx5_counters_init[j].dpdk_name);
-                       goto free;
+       /* Add IB counters. */
+       for (i = 0; i != xstats_n; ++i) {
+               if (mlx5_counters_init[i].ib) {
+                       unsigned int idx = xstats_ctrl->mlx5_stats_n++;
+
+                       xstats_ctrl->info[idx] = mlx5_counters_init[i];
                }
        }
+       assert(xstats_ctrl->mlx5_stats_n <= MLX5_MAX_XSTATS);
+       xstats_ctrl->stats_n = dev_stats_n;
        /* Copy to base at first time. */
-       assert(xstats_n <= MLX5_MAX_XSTATS);
        ret = mlx5_read_dev_counters(dev, xstats_ctrl->base);
        if (ret)
                DRV_LOG(ERR, "port %u cannot read device counters: %s",
                        dev->data->port_id, strerror(rte_errno));
+       mlx5_read_ib_stat(priv, "out_of_buffer", &stats_ctrl->imissed_base);
 free:
        rte_free(strings);
 }
@@ -303,12 +333,13 @@ int
 mlx5_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,
                unsigned int n)
 {
-       struct priv *priv = dev->data->dev_private;
+       struct mlx5_priv *priv = dev->data->dev_private;
        unsigned int i;
        uint64_t counters[n];
+       struct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;
+       uint16_t mlx5_stats_n = xstats_ctrl->mlx5_stats_n;
 
-       if (n >= xstats_n && stats) {
-               struct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;
+       if (n >= mlx5_stats_n && stats) {
                int stats_n;
                int ret;
 
@@ -316,16 +347,16 @@ mlx5_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,
                if (stats_n < 0)
                        return stats_n;
                if (xstats_ctrl->stats_n != stats_n)
-                       mlx5_xstats_init(dev);
+                       mlx5_stats_init(dev);
                ret = mlx5_read_dev_counters(dev, counters);
                if (ret)
                        return ret;
-               for (i = 0; i != xstats_n; ++i) {
+               for (i = 0; i != mlx5_stats_n; ++i) {
                        stats[i].id = i;
                        stats[i].value = (counters[i] - xstats_ctrl->base[i]);
                }
        }
-       return xstats_n;
+       return mlx5_stats_n;
 }
 
 /**
@@ -343,18 +374,19 @@ mlx5_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,
 int
 mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
-       struct priv *priv = dev->data->dev_private;
-       struct rte_eth_stats tmp = {0};
+       struct mlx5_priv *priv = dev->data->dev_private;
+       struct rte_eth_stats tmp;
        unsigned int i;
        unsigned int idx;
 
+       memset(&tmp, 0, sizeof(tmp));
        /* Add software counters. */
        for (i = 0; (i != priv->rxqs_n); ++i) {
                struct mlx5_rxq_data *rxq = (*priv->rxqs)[i];
 
                if (rxq == NULL)
                        continue;
-               idx = rxq->stats.idx;
+               idx = rxq->idx;
                if (idx < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
 #ifdef MLX5_PMD_SOFT_COUNTERS
                        tmp.q_ipackets[idx] += rxq->stats.ipackets;
@@ -375,13 +407,12 @@ mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
                if (txq == NULL)
                        continue;
-               idx = txq->stats.idx;
+               idx = txq->idx;
                if (idx < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
 #ifdef MLX5_PMD_SOFT_COUNTERS
                        tmp.q_opackets[idx] += txq->stats.opackets;
                        tmp.q_obytes[idx] += txq->stats.obytes;
 #endif
-                       tmp.q_errors[idx] += txq->stats.oerrors;
                }
 #ifdef MLX5_PMD_SOFT_COUNTERS
                tmp.opackets += txq->stats.opackets;
@@ -389,6 +420,8 @@ mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 #endif
                tmp.oerrors += txq->stats.oerrors;
        }
+       mlx5_read_ib_stat(priv, "out_of_buffer", &tmp.imissed);
+       tmp.imissed -= priv->stats_ctrl.imissed_base;
 #ifndef MLX5_PMD_SOFT_COUNTERS
        /* FIXME: retrieve and add hardware counters. */
 #endif
@@ -401,31 +434,35 @@ mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
  *
  * @param dev
  *   Pointer to Ethernet device structure.
+ *
+ * @return
+ *   always 0 on success and stats is reset
  */
-void
+int
 mlx5_stats_reset(struct rte_eth_dev *dev)
 {
-       struct priv *priv = dev->data->dev_private;
+       struct mlx5_priv *priv = dev->data->dev_private;
+       struct mlx5_stats_ctrl *stats_ctrl = &priv->stats_ctrl;
        unsigned int i;
-       unsigned int idx;
 
        for (i = 0; (i != priv->rxqs_n); ++i) {
                if ((*priv->rxqs)[i] == NULL)
                        continue;
-               idx = (*priv->rxqs)[i]->stats.idx;
-               (*priv->rxqs)[i]->stats =
-                       (struct mlx5_rxq_stats){ .idx = idx };
+               memset(&(*priv->rxqs)[i]->stats, 0,
+                      sizeof(struct mlx5_rxq_stats));
        }
        for (i = 0; (i != priv->txqs_n); ++i) {
                if ((*priv->txqs)[i] == NULL)
                        continue;
-               idx = (*priv->txqs)[i]->stats.idx;
-               (*priv->txqs)[i]->stats =
-                       (struct mlx5_txq_stats){ .idx = idx };
+               memset(&(*priv->txqs)[i]->stats, 0,
+                      sizeof(struct mlx5_txq_stats));
        }
+       mlx5_read_ib_stat(priv, "out_of_buffer", &stats_ctrl->imissed_base);
 #ifndef MLX5_PMD_SOFT_COUNTERS
        /* FIXME: reset hardware counters. */
 #endif
+
+       return 0;
 }
 
 /**
@@ -433,15 +470,19 @@ mlx5_stats_reset(struct rte_eth_dev *dev)
  *
  * @param dev
  *   Pointer to Ethernet device structure.
+ *
+ * @return
+ *   0 on success and stats is reset, negative errno value otherwise and
+ *   rte_errno is set.
  */
-void
+int
 mlx5_xstats_reset(struct rte_eth_dev *dev)
 {
-       struct priv *priv = dev->data->dev_private;
+       struct mlx5_priv *priv = dev->data->dev_private;
        struct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;
        int stats_n;
        unsigned int i;
-       unsigned int n = xstats_n;
+       unsigned int n = xstats_ctrl->mlx5_stats_n;
        uint64_t counters[n];
        int ret;
 
@@ -449,18 +490,20 @@ mlx5_xstats_reset(struct rte_eth_dev *dev)
        if (stats_n < 0) {
                DRV_LOG(ERR, "port %u cannot get stats: %s", dev->data->port_id,
                        strerror(-stats_n));
-               return;
+               return stats_n;
        }
        if (xstats_ctrl->stats_n != stats_n)
-               mlx5_xstats_init(dev);
+               mlx5_stats_init(dev);
        ret = mlx5_read_dev_counters(dev, counters);
        if (ret) {
                DRV_LOG(ERR, "port %u cannot read device counters: %s",
                        dev->data->port_id, strerror(rte_errno));
-               return;
+               return ret;
        }
        for (i = 0; i != n; ++i)
                xstats_ctrl->base[i] = counters[i];
+
+       return 0;
 }
 
 /**
@@ -481,14 +524,17 @@ mlx5_xstats_get_names(struct rte_eth_dev *dev __rte_unused,
                      struct rte_eth_xstat_name *xstats_names, unsigned int n)
 {
        unsigned int i;
+       struct mlx5_priv *priv = dev->data->dev_private;
+       struct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;
+       unsigned int mlx5_xstats_n = xstats_ctrl->mlx5_stats_n;
 
-       if (n >= xstats_n && xstats_names) {
-               for (i = 0; i != xstats_n; ++i) {
+       if (n >= mlx5_xstats_n && xstats_names) {
+               for (i = 0; i != mlx5_xstats_n; ++i) {
                        strncpy(xstats_names[i].name,
-                               mlx5_counters_init[i].dpdk_name,
+                               xstats_ctrl->info[i].dpdk_name,
                                RTE_ETH_XSTATS_NAME_SIZE);
                        xstats_names[i].name[RTE_ETH_XSTATS_NAME_SIZE - 1] = 0;
                }
        }
-       return xstats_n;
+       return mlx5_xstats_n;
 }