ethdev: add device flag to bypass auto-filled queue xstats
[dpdk.git] / drivers / net / pfe / pfe_ethdev.c
index 8af0037..3b07969 100644 (file)
@@ -1,7 +1,8 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright 2019 NXP
+ * Copyright 2018-2019 NXP
  */
 
+#include <sys/ioctl.h>
 #include <sys/epoll.h>
 #include <rte_kvargs.h>
 #include <rte_ethdev_vdev.h>
@@ -12,7 +13,7 @@
 #include "pfe_logs.h"
 #include "pfe_mod.h"
 
-#define PFE_MAX_MACS 1 /*we can support upto 4 MACs per IF*/
+#define PFE_MAX_MACS 1 /* we can support up to 4 MACs per IF */
 #define PFE_VDEV_GEM_ID_ARG    "intf"
 
 struct pfe_vdev_init_params {
@@ -39,8 +40,6 @@ unsigned int pfe_svr = SVR_LS1012A_REV1;
 static void *cbus_emac_base[3];
 static void *cbus_gpi_base[3];
 
-int pfe_logtype_pmd;
-
 /* pfe_gemac_init
  */
 static int
@@ -374,42 +373,43 @@ pfe_eth_close_cdev(struct pfe_eth_priv_s *priv)
        }
 }
 
-static void
+static int
 pfe_eth_stop(struct rte_eth_dev *dev/*, int wake*/)
 {
        struct pfe_eth_priv_s *priv = dev->data->dev_private;
 
+       dev->data->dev_started = 0;
+
        gemac_disable(priv->EMAC_baseaddr);
        gpi_disable(priv->GPI_baseaddr);
 
        dev->rx_pkt_burst = &pfe_dummy_recv_pkts;
        dev->tx_pkt_burst = &pfe_dummy_xmit_pkts;
-}
 
-static void
-pfe_eth_exit(struct rte_eth_dev *dev, struct pfe *pfe)
-{
-       PMD_INIT_FUNC_TRACE();
-
-       pfe_eth_stop(dev);
-       /* Close the device file for link status */
-       pfe_eth_close_cdev(dev->data->dev_private);
-
-       rte_free(dev->data->mac_addrs);
-       rte_eth_dev_release_port(dev);
-       pfe->nb_devs--;
+       return 0;
 }
 
-static void
+static int
 pfe_eth_close(struct rte_eth_dev *dev)
 {
+       int ret;
+       PMD_INIT_FUNC_TRACE();
+
        if (!dev)
-               return;
+               return -1;
 
        if (!g_pfe)
-               return;
+               return -1;
 
-       pfe_eth_exit(dev, g_pfe);
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
+       ret = pfe_eth_stop(dev);
+       /* Close the device file for link status */
+       pfe_eth_close_cdev(dev->data->dev_private);
+
+       munmap(g_pfe->cbus_baseaddr, g_pfe->cbus_size);
+       g_pfe->nb_devs--;
 
        if (g_pfe->nb_devs == 0) {
                pfe_hif_exit(g_pfe);
@@ -417,6 +417,8 @@ pfe_eth_close(struct rte_eth_dev *dev)
                rte_free(g_pfe);
                g_pfe = NULL;
        }
+
+       return ret;
 }
 
 static int
@@ -429,9 +431,6 @@ static int
 pfe_eth_info(struct rte_eth_dev *dev,
                struct rte_eth_dev_info *dev_info)
 {
-       struct pfe_eth_priv_s *internals = dev->data->dev_private;
-
-       dev_info->if_index = internals->id;
        dev_info->max_mac_addrs = PFE_MAX_MACS;
        dev_info->max_rx_queues = dev->data->nb_rx_queues;
        dev_info->max_tx_queues = dev->data->nb_tx_queues;
@@ -547,6 +546,90 @@ pfe_supported_ptypes_get(struct rte_eth_dev *dev)
        return NULL;
 }
 
+static inline int
+pfe_eth_atomic_read_link_status(struct rte_eth_dev *dev,
+                               struct rte_eth_link *link)
+{
+       struct rte_eth_link *dst = link;
+       struct rte_eth_link *src = &dev->data->dev_link;
+
+       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
+                               *(uint64_t *)src) == 0)
+               return -1;
+
+       return 0;
+}
+
+static inline int
+pfe_eth_atomic_write_link_status(struct rte_eth_dev *dev,
+                                struct rte_eth_link *link)
+{
+       struct rte_eth_link *dst = &dev->data->dev_link;
+       struct rte_eth_link *src = link;
+
+       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
+                               *(uint64_t *)src) == 0)
+               return -1;
+
+       return 0;
+}
+
+static int
+pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)
+{
+       int ret, ioctl_cmd = 0;
+       struct pfe_eth_priv_s *priv = dev->data->dev_private;
+       struct rte_eth_link link, old;
+       unsigned int lstatus = 1;
+
+       if (dev == NULL) {
+               PFE_PMD_ERR("Invalid device in link_update.\n");
+               return 0;
+       }
+
+       memset(&old, 0, sizeof(old));
+       memset(&link, 0, sizeof(struct rte_eth_link));
+
+       pfe_eth_atomic_read_link_status(dev, &old);
+
+       /* Read from PFE CDEV, status of link, if file was successfully
+        * opened.
+        */
+       if (priv->link_fd != PFE_CDEV_INVALID_FD) {
+               if (priv->id == 0)
+                       ioctl_cmd = PFE_CDEV_ETH0_STATE_GET;
+               if (priv->id == 1)
+                       ioctl_cmd = PFE_CDEV_ETH1_STATE_GET;
+
+               ret = ioctl(priv->link_fd, ioctl_cmd, &lstatus);
+               if (ret != 0) {
+                       PFE_PMD_ERR("Unable to fetch link status (ioctl)\n");
+                       /* use dummy link value */
+                       link.link_status = 1;
+               }
+               PFE_PMD_DEBUG("Fetched link state (%d) for dev %d.\n",
+                             lstatus, priv->id);
+       }
+
+       if (old.link_status == lstatus) {
+               /* no change in status */
+               PFE_PMD_DEBUG("No change in link status; Not updating.\n");
+               return -1;
+       }
+
+       link.link_status = lstatus;
+       link.link_speed = ETH_LINK_SPEED_1G;
+       link.link_duplex = ETH_LINK_FULL_DUPLEX;
+       link.link_autoneg = ETH_LINK_AUTONEG;
+
+       pfe_eth_atomic_write_link_status(dev, &link);
+
+       PFE_PMD_INFO("Port (%d) link is %s\n", dev->data->port_id,
+                    link.link_status ? "up" : "down");
+
+       return 0;
+}
+
 static int
 pfe_promiscuous_enable(struct rte_eth_dev *dev)
 {
@@ -586,6 +669,21 @@ pfe_allmulticast_enable(struct rte_eth_dev *dev)
        return 0;
 }
 
+static int
+pfe_link_down(struct rte_eth_dev *dev)
+{
+       return pfe_eth_stop(dev);
+}
+
+static int
+pfe_link_up(struct rte_eth_dev *dev)
+{
+       struct pfe_eth_priv_s *priv = dev->data->dev_private;
+
+       pfe_eth_start(priv);
+       return 0;
+}
+
 static int
 pfe_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
@@ -670,9 +768,12 @@ static const struct eth_dev_ops ops = {
        .tx_queue_setup = pfe_tx_queue_setup,
        .tx_queue_release  = pfe_tx_queue_release,
        .dev_supported_ptypes_get = pfe_supported_ptypes_get,
+       .link_update  = pfe_eth_link_update,
        .promiscuous_enable   = pfe_promiscuous_enable,
        .promiscuous_disable  = pfe_promiscuous_disable,
        .allmulticast_enable  = pfe_allmulticast_enable,
+       .dev_set_link_down    = pfe_link_down,
+       .dev_set_link_up      = pfe_link_up,
        .mtu_set              = pfe_mtu_set,
        .mac_addr_set         = pfe_dev_set_mac_addr,
        .stats_get            = pfe_stats_get,
@@ -746,12 +847,16 @@ pfe_eth_init(struct rte_vdev_device *vdev, struct pfe *pfe, int id)
 
        eth_dev->data->mtu = 1500;
        eth_dev->dev_ops = &ops;
-       pfe_eth_stop(eth_dev);
+       err = pfe_eth_stop(eth_dev);
+       if (err != 0)
+               goto err0;
        pfe_gemac_init(priv);
 
        eth_dev->data->nb_rx_queues = 1;
        eth_dev->data->nb_tx_queues = 1;
 
+       eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+
        /* For link status, open the PFE CDEV; Error from this function
         * is silently ignored; In case of error, the link status will not
         * be available.
@@ -886,7 +991,7 @@ pmd_pfe_probe(struct rte_vdev_device *vdev)
        if (rc < 0)
                return -EINVAL;
 
-       RTE_LOG(INFO, PMD, "Initializing pmd_pfe for %s Given gem-id %d\n",
+       PFE_PMD_LOG(INFO, "Initializing pmd_pfe for %s Given gem-id %d",
                name, init_params.gem_id);
 
        if (g_pfe) {
@@ -1014,7 +1119,7 @@ eth_init:
        else
                gem_id = init_params.gem_id;
 
-       RTE_LOG(INFO, PMD, "Init pmd_pfe for %s gem-id %d(given =%d)\n",
+       PFE_PMD_LOG(INFO, "Init pmd_pfe for %s gem-id %d(given =%d)",
                name, gem_id, init_params.gem_id);
 
        rc = pfe_eth_init(vdev, g_pfe, gem_id);
@@ -1044,6 +1149,7 @@ pmd_pfe_remove(struct rte_vdev_device *vdev)
 {
        const char *name;
        struct rte_eth_dev *eth_dev = NULL;
+       int ret = 0;
 
        name = rte_vdev_device_name(vdev);
        if (name == NULL)
@@ -1055,19 +1161,12 @@ pmd_pfe_remove(struct rte_vdev_device *vdev)
                return 0;
 
        eth_dev = rte_eth_dev_allocated(name);
-       if (eth_dev == NULL)
-               return -ENODEV;
-
-       pfe_eth_exit(eth_dev, g_pfe);
-       munmap(g_pfe->cbus_baseaddr, g_pfe->cbus_size);
-
-       if (g_pfe->nb_devs == 0) {
-               pfe_hif_exit(g_pfe);
-               pfe_hif_lib_exit(g_pfe);
-               rte_free(g_pfe);
-               g_pfe = NULL;
+       if (eth_dev) {
+               pfe_eth_close(eth_dev);
+               ret = rte_eth_dev_release_port(eth_dev);
        }
-       return 0;
+
+       return ret;
 }
 
 static
@@ -1078,10 +1177,4 @@ struct rte_vdev_driver pmd_pfe_drv = {
 
 RTE_PMD_REGISTER_VDEV(PFE_NAME_PMD, pmd_pfe_drv);
 RTE_PMD_REGISTER_PARAM_STRING(PFE_NAME_PMD, PFE_VDEV_GEM_ID_ARG "=<int> ");
-
-RTE_INIT(pfe_pmd_init_log)
-{
-       pfe_logtype_pmd = rte_log_register("pmd.net.pfe");
-       if (pfe_logtype_pmd >= 0)
-               rte_log_set_level(pfe_logtype_pmd, RTE_LOG_NOTICE);
-}
+RTE_LOG_REGISTER(pfe_logtype_pmd, pmd.net.pfe, NOTICE);