ethdev: add namespace
[dpdk.git] / drivers / net / ring / rte_eth_ring.c
index f0fafa0..db10f03 100644 (file)
@@ -4,7 +4,7 @@
 
 #include "rte_eth_ring.h"
 #include <rte_mbuf.h>
-#include <rte_ethdev_driver.h>
+#include <ethdev_driver.h>
 #include <rte_malloc.h>
 #include <rte_memcpy.h>
 #include <rte_string_fns.h>
@@ -16,6 +16,7 @@
 #define ETH_RING_ACTION_CREATE         "CREATE"
 #define ETH_RING_ACTION_ATTACH         "ATTACH"
 #define ETH_RING_INTERNAL_ARG          "internal"
+#define ETH_RING_INTERNAL_ARG_MAX_LEN  19 /* "0x..16chars..\0" */
 
 static const char *valid_arguments[] = {
        ETH_RING_NUMA_NODE_ACTION_ARG,
@@ -55,13 +56,13 @@ struct pmd_internals {
 };
 
 static struct rte_eth_link pmd_link = {
-       .link_speed = ETH_SPEED_NUM_10G,
-       .link_duplex = ETH_LINK_FULL_DUPLEX,
-       .link_status = ETH_LINK_DOWN,
-       .link_autoneg = ETH_LINK_FIXED,
+       .link_speed = RTE_ETH_SPEED_NUM_10G,
+       .link_duplex = RTE_ETH_LINK_FULL_DUPLEX,
+       .link_status = RTE_ETH_LINK_DOWN,
+       .link_autoneg = RTE_ETH_LINK_FIXED,
 };
 
-static int eth_ring_logtype;
+RTE_LOG_REGISTER_DEFAULT(eth_ring_logtype, NOTICE);
 
 #define PMD_LOG(level, fmt, args...) \
        rte_log(RTE_LOG_ ## level, eth_ring_logtype, \
@@ -101,27 +102,29 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) { return 0; }
 static int
 eth_dev_start(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = ETH_LINK_UP;
+       dev->data->dev_link.link_status = RTE_ETH_LINK_UP;
        return 0;
 }
 
-static void
+static int
 eth_dev_stop(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = ETH_LINK_DOWN;
+       dev->data->dev_started = 0;
+       dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN;
+       return 0;
 }
 
 static int
 eth_dev_set_link_down(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = ETH_LINK_DOWN;
+       dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN;
        return 0;
 }
 
 static int
 eth_dev_set_link_up(struct rte_eth_dev *dev)
 {
-       dev->data->dev_link.link_status = ETH_LINK_UP;
+       dev->data->dev_link.link_status = RTE_ETH_LINK_UP;
        return 0;
 }
 
@@ -160,6 +163,8 @@ eth_dev_info(struct rte_eth_dev *dev,
        dev_info->max_mac_addrs = 1;
        dev_info->max_rx_pktlen = (uint32_t)-1;
        dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;
+       dev_info->rx_offload_capa = RTE_ETH_RX_OFFLOAD_SCATTER;
+       dev_info->tx_offload_capa = RTE_ETH_TX_OFFLOAD_MULTI_SEGS;
        dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues;
        dev_info->min_rx_bufsize = 0;
 
@@ -220,13 +225,43 @@ eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused,
        return 0;
 }
 
-static void
-eth_queue_release(void *q __rte_unused) { ; }
 static int
 eth_link_update(struct rte_eth_dev *dev __rte_unused,
                int wait_to_complete __rte_unused) { return 0; }
 
+static int
+eth_dev_close(struct rte_eth_dev *dev)
+{
+       struct pmd_internals *internals = NULL;
+       struct ring_queue *r = NULL;
+       uint16_t i;
+       int ret;
+
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
+       ret = eth_dev_stop(dev);
+
+       internals = dev->data->dev_private;
+       if (internals->action == DEV_CREATE) {
+               /*
+                * it is only necessary to delete the rings in rx_queues because
+                * they are the same used in tx_queues
+                */
+               for (i = 0; i < dev->data->nb_rx_queues; i++) {
+                       r = dev->data->rx_queues[i];
+                       rte_ring_free(r->rng);
+               }
+       }
+
+       /* mac_addrs must not be freed alone because part of dev_private */
+       dev->data->mac_addrs = NULL;
+
+       return ret;
+}
+
 static const struct eth_dev_ops ops = {
+       .dev_close = eth_dev_close,
        .dev_start = eth_dev_start,
        .dev_stop = eth_dev_stop,
        .dev_set_link_up = eth_dev_set_link_up,
@@ -235,8 +270,6 @@ static const struct eth_dev_ops ops = {
        .dev_infos_get = eth_dev_info,
        .rx_queue_setup = eth_rx_queue_setup,
        .tx_queue_setup = eth_tx_queue_setup,
-       .rx_queue_release = eth_queue_release,
-       .tx_queue_release = eth_queue_release,
        .link_update = eth_link_update,
        .stats_get = eth_stats_get,
        .stats_reset = eth_stats_reset,
@@ -324,9 +357,9 @@ do_eth_dev_ring_create(const char *name,
        data->mac_addrs = &internals->address;
        data->promiscuous = 1;
        data->all_multicast = 1;
+       data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
 
        eth_dev->dev_ops = &ops;
-       data->kdrv = RTE_KDRV_NONE;
        data->numa_node = numa_node;
 
        /* finally assign rx and tx ops */
@@ -539,8 +572,21 @@ parse_internal_args(const char *key __rte_unused, const char *value,
 {
        struct ring_internal_args **internal_args = data;
        void *args;
+       int ret, n;
 
-       sscanf(value, "%p", &args);
+       /* make sure 'value' is valid pointer length */
+       if (strnlen(value, ETH_RING_INTERNAL_ARG_MAX_LEN) >=
+                       ETH_RING_INTERNAL_ARG_MAX_LEN) {
+               PMD_LOG(ERR, "Error parsing internal args, argument is too long");
+               return -1;
+       }
+
+       ret = sscanf(value, "%p%n", &args, &n);
+       if (ret == 0 || (size_t)n != strlen(value)) {
+               PMD_LOG(ERR, "Error parsing internal args");
+
+               return -1;
+       }
 
        *internal_args = args;
 
@@ -565,6 +611,23 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)
 
        PMD_LOG(INFO, "Initializing pmd_ring for %s", name);
 
+       if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
+               eth_dev = rte_eth_dev_attach_secondary(name);
+               if (!eth_dev) {
+                       PMD_LOG(ERR, "Failed to probe %s", name);
+                       return -1;
+               }
+               eth_dev->dev_ops = &ops;
+               eth_dev->device = &dev->device;
+
+               eth_dev->rx_pkt_burst = eth_ring_rx;
+               eth_dev->tx_pkt_burst = eth_ring_tx;
+
+               rte_eth_dev_probing_finish(eth_dev);
+
+               return 0;
+       }
+
        if (params == NULL || params[0] == '\0') {
                ret = eth_dev_ring_create(name, dev, rte_socket_id(), DEV_CREATE,
                                &eth_dev);
@@ -579,7 +642,7 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)
 
                if (!kvlist) {
                        PMD_LOG(INFO,
-                               "Ignoring unsupported parameters when creatingrings-backed ethernet device");
+                               "Ignoring unsupported parameters when creating rings-backed ethernet device");
                        ret = eth_dev_ring_create(name, dev, rte_socket_id(),
                                                  DEV_CREATE, &eth_dev);
                        if (ret == -1) {
@@ -659,9 +722,6 @@ rte_pmd_ring_remove(struct rte_vdev_device *dev)
 {
        const char *name = rte_vdev_device_name(dev);
        struct rte_eth_dev *eth_dev = NULL;
-       struct pmd_internals *internals = NULL;
-       struct ring_queue *r = NULL;
-       uint16_t i;
 
        PMD_LOG(INFO, "Un-Initializing pmd_ring for %s", name);
 
@@ -671,24 +731,9 @@ rte_pmd_ring_remove(struct rte_vdev_device *dev)
        /* find an ethdev entry */
        eth_dev = rte_eth_dev_allocated(name);
        if (eth_dev == NULL)
-               return -ENODEV;
+               return 0; /* port already released */
 
-       eth_dev_stop(eth_dev);
-
-       internals = eth_dev->data->dev_private;
-       if (internals->action == DEV_CREATE) {
-               /*
-                * it is only necessary to delete the rings in rx_queues because
-                * they are the same used in tx_queues
-                */
-               for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
-                       r = eth_dev->data->rx_queues[i];
-                       rte_ring_free(r->rng);
-               }
-       }
-
-       /* mac_addrs must not be freed alone because part of dev_private */
-       eth_dev->data->mac_addrs = NULL;
+       eth_dev_close(eth_dev);
        rte_eth_dev_release_port(eth_dev);
        return 0;
 }
@@ -702,10 +747,3 @@ RTE_PMD_REGISTER_VDEV(net_ring, pmd_ring_drv);
 RTE_PMD_REGISTER_ALIAS(net_ring, eth_ring);
 RTE_PMD_REGISTER_PARAM_STRING(net_ring,
        ETH_RING_NUMA_NODE_ACTION_ARG "=name:node:action(ATTACH|CREATE)");
-
-RTE_INIT(eth_ring_init_log)
-{
-       eth_ring_logtype = rte_log_register("pmd.net.ring");
-       if (eth_ring_logtype >= 0)
-               rte_log_set_level(eth_ring_logtype, RTE_LOG_NOTICE);
-}