net/sfc: fix MAC stats update for stopped device
[dpdk.git] / drivers / net / sfc / sfc_ethdev.c
index 1a58e0d..bbc2272 100644 (file)
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  *
- * Copyright(c) 2019-2020 Xilinx, Inc.
+ * Copyright(c) 2019-2021 Xilinx, Inc.
  * Copyright(c) 2016-2019 Solarflare Communications Inc.
  *
  * This software was jointly developed between OKTET Labs (under contract
@@ -8,8 +8,8 @@
  */
 
 #include <rte_dev.h>
-#include <rte_ethdev_driver.h>
-#include <rte_ethdev_pci.h>
+#include <ethdev_driver.h>
+#include <ethdev_pci.h>
 #include <rte_pci.h>
 #include <rte_bus_pci.h>
 #include <rte_errno.h>
@@ -46,14 +46,6 @@ sfc_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
        int ret;
        int rc;
 
-       /*
-        * Return value of the callback is likely supposed to be
-        * equal to or greater than 0, nevertheless, if an error
-        * occurs, it will be desirable to pass it to the caller
-        */
-       if ((fw_version == NULL) || (fw_size == 0))
-               return -EINVAL;
-
        rc = efx_nic_get_fw_version(sa->nic, &enfi);
        if (rc != 0)
                return -rc;
@@ -93,6 +85,7 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_rss *rss = &sas->rss;
+       struct sfc_mae *mae = &sa->mae;
        uint64_t txq_offloads_def = 0;
 
        sfc_log_init(sa, "entry");
@@ -102,6 +95,8 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 
        dev_info->max_rx_pktlen = EFX_MAC_PDU_MAX;
 
+       dev_info->max_vfs = sa->sriov.num_vfs;
+
        /* Autonegotiation may be disabled */
        dev_info->speed_capa = ETH_LINK_SPEED_FIXED;
        if (sa->port.phy_adv_cap_mask & (1u << EFX_PHY_CAP_1000FDX))
@@ -185,6 +180,12 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
                             RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
 
+       if (mae->status == SFC_MAE_STATUS_SUPPORTED) {
+               dev_info->switch_info.name = dev->device->driver->name;
+               dev_info->switch_info.domain_id = mae->switch_domain_id;
+               dev_info->switch_info.port_id = mae->switch_port_id;
+       }
+
        return 0;
 }
 
@@ -274,7 +275,7 @@ sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
        return ret;
 }
 
-static void
+static int
 sfc_dev_stop(struct rte_eth_dev *dev)
 {
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
@@ -286,6 +287,8 @@ sfc_dev_stop(struct rte_eth_dev *dev)
        sfc_adapter_unlock(sa);
 
        sfc_log_init(sa, "done");
+
+       return 0;
 }
 
 static int
@@ -319,12 +322,24 @@ sfc_dev_set_link_down(struct rte_eth_dev *dev)
 }
 
 static void
+sfc_eth_dev_secondary_clear_ops(struct rte_eth_dev *dev)
+{
+       free(dev->process_private);
+       rte_eth_dev_release_port(dev);
+}
+
+static int
 sfc_dev_close(struct rte_eth_dev *dev)
 {
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
 
        sfc_log_init(sa, "entry");
 
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               sfc_eth_dev_secondary_clear_ops(dev);
+               return 0;
+       }
+
        sfc_adapter_lock(sa);
        switch (sa->state) {
        case SFC_ADAPTER_STARTED:
@@ -343,7 +358,7 @@ sfc_dev_close(struct rte_eth_dev *dev)
        }
 
        /*
-        * Cleanup all resources in accordance with RTE_ETH_DEV_CLOSE_REMOVE.
+        * Cleanup all resources.
         * Rollback primary process sfc_eth_dev_init() below.
         */
 
@@ -362,8 +377,9 @@ sfc_dev_close(struct rte_eth_dev *dev)
        /* Required for logging, so cleanup last */
        sa->eth_dev = NULL;
 
-       dev->process_private = NULL;
        free(sa);
+
+       return 0;
 }
 
 static int
@@ -447,26 +463,31 @@ sfc_dev_allmulti_disable(struct rte_eth_dev *dev)
 }
 
 static int
-sfc_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
+sfc_rx_queue_setup(struct rte_eth_dev *dev, uint16_t ethdev_qid,
                   uint16_t nb_rx_desc, unsigned int socket_id,
                   const struct rte_eth_rxconf *rx_conf,
                   struct rte_mempool *mb_pool)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
+       sfc_ethdev_qid_t sfc_ethdev_qid = ethdev_qid;
+       struct sfc_rxq_info *rxq_info;
+       sfc_sw_index_t sw_index;
        int rc;
 
        sfc_log_init(sa, "RxQ=%u nb_rx_desc=%u socket_id=%u",
-                    rx_queue_id, nb_rx_desc, socket_id);
+                    ethdev_qid, nb_rx_desc, socket_id);
 
        sfc_adapter_lock(sa);
 
-       rc = sfc_rx_qinit(sa, rx_queue_id, nb_rx_desc, socket_id,
+       sw_index = sfc_rxq_sw_index_by_ethdev_rx_qid(sas, sfc_ethdev_qid);
+       rc = sfc_rx_qinit(sa, sw_index, nb_rx_desc, socket_id,
                          rx_conf, mb_pool);
        if (rc != 0)
                goto fail_rx_qinit;
 
-       dev->data->rx_queues[rx_queue_id] = sas->rxq_info[rx_queue_id].dp;
+       rxq_info = sfc_rxq_info_by_ethdev_qid(sas, sfc_ethdev_qid);
+       dev->data->rx_queues[ethdev_qid] = rxq_info->dp;
 
        sfc_adapter_unlock(sa);
 
@@ -484,7 +505,7 @@ sfc_rx_queue_release(void *queue)
        struct sfc_dp_rxq *dp_rxq = queue;
        struct sfc_rxq *rxq;
        struct sfc_adapter *sa;
-       unsigned int sw_index;
+       sfc_sw_index_t sw_index;
 
        if (dp_rxq == NULL)
                return;
@@ -503,24 +524,28 @@ sfc_rx_queue_release(void *queue)
 }
 
 static int
-sfc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
+sfc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t ethdev_qid,
                   uint16_t nb_tx_desc, unsigned int socket_id,
                   const struct rte_eth_txconf *tx_conf)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
+       struct sfc_txq_info *txq_info;
+       sfc_sw_index_t sw_index;
        int rc;
 
        sfc_log_init(sa, "TxQ = %u, nb_tx_desc = %u, socket_id = %u",
-                    tx_queue_id, nb_tx_desc, socket_id);
+                    ethdev_qid, nb_tx_desc, socket_id);
 
        sfc_adapter_lock(sa);
 
-       rc = sfc_tx_qinit(sa, tx_queue_id, nb_tx_desc, socket_id, tx_conf);
+       sw_index = sfc_txq_sw_index_by_ethdev_tx_qid(sas, ethdev_qid);
+       rc = sfc_tx_qinit(sa, sw_index, nb_tx_desc, socket_id, tx_conf);
        if (rc != 0)
                goto fail_tx_qinit;
 
-       dev->data->tx_queues[tx_queue_id] = sas->txq_info[tx_queue_id].dp;
+       txq_info = sfc_txq_info_by_ethdev_qid(sas, ethdev_qid);
+       dev->data->tx_queues[ethdev_qid] = txq_info->dp;
 
        sfc_adapter_unlock(sa);
        return 0;
@@ -536,7 +561,7 @@ sfc_tx_queue_release(void *queue)
 {
        struct sfc_dp_txq *dp_txq = queue;
        struct sfc_txq *txq;
-       unsigned int sw_index;
+       sfc_sw_index_t sw_index;
        struct sfc_adapter *sa;
 
        if (dp_txq == NULL)
@@ -588,9 +613,9 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        uint64_t *mac_stats;
        int ret;
 
-       rte_spinlock_lock(&port->mac_stats_lock);
+       sfc_adapter_lock(sa);
 
-       ret = sfc_port_update_mac_stats(sa);
+       ret = sfc_port_update_mac_stats(sa, B_FALSE);
        if (ret != 0)
                goto unlock;
 
@@ -616,10 +641,19 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
                        mac_stats[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES];
                stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS];
                stats->oerrors = mac_stats[EFX_MAC_VADAPTER_TX_BAD_PACKETS];
+
+               /* CRC is included in these stats, but shouldn't be */
+               stats->ibytes -= stats->ipackets * RTE_ETHER_CRC_LEN;
+               stats->obytes -= stats->opackets * RTE_ETHER_CRC_LEN;
        } else {
                stats->opackets = mac_stats[EFX_MAC_TX_PKTS];
                stats->ibytes = mac_stats[EFX_MAC_RX_OCTETS];
                stats->obytes = mac_stats[EFX_MAC_TX_OCTETS];
+
+               /* CRC is included in these stats, but shouldn't be */
+               stats->ibytes -= mac_stats[EFX_MAC_RX_PKTS] * RTE_ETHER_CRC_LEN;
+               stats->obytes -= mac_stats[EFX_MAC_TX_PKTS] * RTE_ETHER_CRC_LEN;
+
                /*
                 * Take into account stats which are whenever supported
                 * on EF10. If some stat is not supported by current
@@ -652,7 +686,7 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        }
 
 unlock:
-       rte_spinlock_unlock(&port->mac_stats_lock);
+       sfc_adapter_unlock(sa);
        SFC_ASSERT(ret >= 0);
        return -ret;
 }
@@ -664,12 +698,15 @@ sfc_stats_reset(struct rte_eth_dev *dev)
        struct sfc_port *port = &sa->port;
        int rc;
 
+       sfc_adapter_lock(sa);
+
        if (sa->state != SFC_ADAPTER_STARTED) {
                /*
                 * The operation cannot be done if port is not started; it
                 * will be scheduled to be done during the next port start
                 */
                port->mac_stats_reset_pending = B_TRUE;
+               sfc_adapter_unlock(sa);
                return 0;
        }
 
@@ -677,6 +714,8 @@ sfc_stats_reset(struct rte_eth_dev *dev)
        if (rc != 0)
                sfc_err(sa, "failed to reset statistics (rc = %d)", rc);
 
+       sfc_adapter_unlock(sa);
+
        SFC_ASSERT(rc >= 0);
        return -rc;
 }
@@ -692,9 +731,9 @@ sfc_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
        unsigned int i;
        int nstats = 0;
 
-       rte_spinlock_lock(&port->mac_stats_lock);
+       sfc_adapter_lock(sa);
 
-       rc = sfc_port_update_mac_stats(sa);
+       rc = sfc_port_update_mac_stats(sa, B_FALSE);
        if (rc != 0) {
                SFC_ASSERT(rc > 0);
                nstats = -rc;
@@ -714,7 +753,7 @@ sfc_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
        }
 
 unlock:
-       rte_spinlock_unlock(&port->mac_stats_lock);
+       sfc_adapter_unlock(sa);
 
        return nstats;
 }
@@ -749,19 +788,16 @@ sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        uint64_t *mac_stats;
-       unsigned int nb_supported = 0;
-       unsigned int nb_written = 0;
        unsigned int i;
        int ret;
        int rc;
 
-       if (unlikely(values == NULL) ||
-           unlikely((ids == NULL) && (n < port->mac_stats_nb_supported)))
-               return port->mac_stats_nb_supported;
+       if (unlikely(ids == NULL || values == NULL))
+               return -EINVAL;
 
-       rte_spinlock_lock(&port->mac_stats_lock);
+       sfc_adapter_lock(sa);
 
-       rc = sfc_port_update_mac_stats(sa);
+       rc = sfc_port_update_mac_stats(sa, B_FALSE);
        if (rc != 0) {
                SFC_ASSERT(rc > 0);
                ret = -rc;
@@ -770,20 +806,22 @@ sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
 
        mac_stats = port->mac_stats_buf;
 
-       for (i = 0; (i < EFX_MAC_NSTATS) && (nb_written < n); ++i) {
-               if (!EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i))
-                       continue;
-
-               if ((ids == NULL) || (ids[nb_written] == nb_supported))
-                       values[nb_written++] = mac_stats[i];
+       SFC_ASSERT(port->mac_stats_nb_supported <=
+                  RTE_DIM(port->mac_stats_by_id));
 
-               ++nb_supported;
+       for (i = 0; i < n; i++) {
+               if (ids[i] < port->mac_stats_nb_supported) {
+                       values[i] = mac_stats[port->mac_stats_by_id[ids[i]]];
+               } else {
+                       ret = i;
+                       goto unlock;
+               }
        }
 
-       ret = nb_written;
+       ret = n;
 
 unlock:
-       rte_spinlock_unlock(&port->mac_stats_lock);
+       sfc_adapter_unlock(sa);
 
        return ret;
 }
@@ -795,29 +833,39 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev,
 {
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
-       unsigned int nb_supported = 0;
-       unsigned int nb_written = 0;
+       unsigned int nb_supported;
        unsigned int i;
 
-       if (unlikely(xstats_names == NULL) ||
-           unlikely((ids == NULL) && (size < port->mac_stats_nb_supported)))
-               return port->mac_stats_nb_supported;
+       if (unlikely(xstats_names == NULL && ids != NULL) ||
+           unlikely(xstats_names != NULL && ids == NULL))
+               return -EINVAL;
 
-       for (i = 0; (i < EFX_MAC_NSTATS) && (nb_written < size); ++i) {
-               if (!EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i))
-                       continue;
+       sfc_adapter_lock(sa);
 
-               if ((ids == NULL) || (ids[nb_written] == nb_supported)) {
-                       char *name = xstats_names[nb_written++].name;
+       if (unlikely(xstats_names == NULL && ids == NULL)) {
+               nb_supported = port->mac_stats_nb_supported;
+               sfc_adapter_unlock(sa);
+               return nb_supported;
+       }
+
+       SFC_ASSERT(port->mac_stats_nb_supported <=
+                  RTE_DIM(port->mac_stats_by_id));
 
-                       strlcpy(name, efx_mac_stat_name(sa->nic, i),
+       for (i = 0; i < size; i++) {
+               if (ids[i] < port->mac_stats_nb_supported) {
+                       strlcpy(xstats_names[i].name,
+                               efx_mac_stat_name(sa->nic,
+                                                port->mac_stats_by_id[ids[i]]),
                                sizeof(xstats_names[0].name));
+               } else {
+                       sfc_adapter_unlock(sa);
+                       return i;
                }
-
-               ++nb_supported;
        }
 
-       return nb_written;
+       sfc_adapter_unlock(sa);
+
+       return size;
 }
 
 static int
@@ -934,7 +982,8 @@ sfc_check_scatter_on_all_rx_queues(struct sfc_adapter *sa, size_t pdu)
 
                if (!sfc_rx_check_scatter(pdu, sa->rxq_ctrl[i].buf_size,
                                          encp->enc_rx_prefix_size,
-                                         scatter_enabled, &error)) {
+                                         scatter_enabled,
+                                         encp->enc_rx_scatter_max, &error)) {
                        sfc_err(sa, "MTU check for RxQ %u failed: %s", i,
                                error);
                        return EINVAL;
@@ -992,7 +1041,7 @@ sfc_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
         * The driver does not use it, but other PMDs update jumbo frame
         * flag and max_rx_pkt_len when MTU is set.
         */
-       if (mtu > RTE_ETHER_MAX_LEN) {
+       if (mtu > RTE_ETHER_MTU) {
                struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
                rxmode->offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
        }
@@ -1156,15 +1205,14 @@ sfc_set_mc_addr_list(struct rte_eth_dev *dev,
  * use any process-local pointers from the adapter data.
  */
 static void
-sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,
+sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t ethdev_qid,
                      struct rte_eth_rxq_info *qinfo)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
+       sfc_ethdev_qid_t sfc_ethdev_qid = ethdev_qid;
        struct sfc_rxq_info *rxq_info;
 
-       SFC_ASSERT(rx_queue_id < sas->rxq_count);
-
-       rxq_info = &sas->rxq_info[rx_queue_id];
+       rxq_info = sfc_rxq_info_by_ethdev_qid(sas, sfc_ethdev_qid);
 
        qinfo->mp = rxq_info->refill_mb_pool;
        qinfo->conf.rx_free_thresh = rxq_info->refill_threshold;
@@ -1183,15 +1231,15 @@ sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,
  * use any process-local pointers from the adapter data.
  */
 static void
-sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,
+sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t ethdev_qid,
                      struct rte_eth_txq_info *qinfo)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_txq_info *txq_info;
 
-       SFC_ASSERT(tx_queue_id < sas->txq_count);
+       SFC_ASSERT(ethdev_qid < sas->ethdev_txq_count);
 
-       txq_info = &sas->txq_info[tx_queue_id];
+       txq_info = sfc_txq_info_by_ethdev_qid(sas, ethdev_qid);
 
        memset(qinfo, 0, sizeof(*qinfo));
 
@@ -1206,14 +1254,14 @@ sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,
  * use any process-local pointers from the adapter data.
  */
 static uint32_t
-sfc_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+sfc_rx_queue_count(struct rte_eth_dev *dev, uint16_t ethdev_qid)
 {
        const struct sfc_adapter_priv *sap = sfc_adapter_priv_by_eth_dev(dev);
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
+       sfc_ethdev_qid_t sfc_ethdev_qid = ethdev_qid;
        struct sfc_rxq_info *rxq_info;
 
-       SFC_ASSERT(rx_queue_id < sas->rxq_count);
-       rxq_info = &sas->rxq_info[rx_queue_id];
+       rxq_info = sfc_rxq_info_by_ethdev_qid(sas, sfc_ethdev_qid);
 
        if ((rxq_info->state & SFC_RXQ_STARTED) == 0)
                return 0;
@@ -1267,13 +1315,16 @@ sfc_tx_descriptor_status(void *queue, uint16_t offset)
 }
 
 static int
-sfc_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+sfc_rx_queue_start(struct rte_eth_dev *dev, uint16_t ethdev_qid)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
+       sfc_ethdev_qid_t sfc_ethdev_qid = ethdev_qid;
+       struct sfc_rxq_info *rxq_info;
+       sfc_sw_index_t sw_index;
        int rc;
 
-       sfc_log_init(sa, "RxQ=%u", rx_queue_id);
+       sfc_log_init(sa, "RxQ=%u", ethdev_qid);
 
        sfc_adapter_lock(sa);
 
@@ -1281,14 +1332,16 @@ sfc_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
        if (sa->state != SFC_ADAPTER_STARTED)
                goto fail_not_started;
 
-       if (sas->rxq_info[rx_queue_id].state != SFC_RXQ_INITIALIZED)
+       rxq_info = sfc_rxq_info_by_ethdev_qid(sas, sfc_ethdev_qid);
+       if (rxq_info->state != SFC_RXQ_INITIALIZED)
                goto fail_not_setup;
 
-       rc = sfc_rx_qstart(sa, rx_queue_id);
+       sw_index = sfc_rxq_sw_index_by_ethdev_rx_qid(sas, sfc_ethdev_qid);
+       rc = sfc_rx_qstart(sa, sw_index);
        if (rc != 0)
                goto fail_rx_qstart;
 
-       sas->rxq_info[rx_queue_id].deferred_started = B_TRUE;
+       rxq_info->deferred_started = B_TRUE;
 
        sfc_adapter_unlock(sa);
 
@@ -1303,17 +1356,23 @@ fail_not_started:
 }
 
 static int
-sfc_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+sfc_rx_queue_stop(struct rte_eth_dev *dev, uint16_t ethdev_qid)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
+       sfc_ethdev_qid_t sfc_ethdev_qid = ethdev_qid;
+       struct sfc_rxq_info *rxq_info;
+       sfc_sw_index_t sw_index;
 
-       sfc_log_init(sa, "RxQ=%u", rx_queue_id);
+       sfc_log_init(sa, "RxQ=%u", ethdev_qid);
 
        sfc_adapter_lock(sa);
-       sfc_rx_qstop(sa, rx_queue_id);
 
-       sas->rxq_info[rx_queue_id].deferred_started = B_FALSE;
+       sw_index = sfc_rxq_sw_index_by_ethdev_rx_qid(sas, sfc_ethdev_qid);
+       sfc_rx_qstop(sa, sw_index);
+
+       rxq_info = sfc_rxq_info_by_ethdev_qid(sas, sfc_ethdev_qid);
+       rxq_info->deferred_started = B_FALSE;
 
        sfc_adapter_unlock(sa);
 
@@ -1321,13 +1380,15 @@ sfc_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 }
 
 static int
-sfc_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
+sfc_tx_queue_start(struct rte_eth_dev *dev, uint16_t ethdev_qid)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
+       struct sfc_txq_info *txq_info;
+       sfc_sw_index_t sw_index;
        int rc;
 
-       sfc_log_init(sa, "TxQ = %u", tx_queue_id);
+       sfc_log_init(sa, "TxQ = %u", ethdev_qid);
 
        sfc_adapter_lock(sa);
 
@@ -1335,14 +1396,16 @@ sfc_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
        if (sa->state != SFC_ADAPTER_STARTED)
                goto fail_not_started;
 
-       if (sas->txq_info[tx_queue_id].state != SFC_TXQ_INITIALIZED)
+       txq_info = sfc_txq_info_by_ethdev_qid(sas, ethdev_qid);
+       if (txq_info->state != SFC_TXQ_INITIALIZED)
                goto fail_not_setup;
 
-       rc = sfc_tx_qstart(sa, tx_queue_id);
+       sw_index = sfc_txq_sw_index_by_ethdev_tx_qid(sas, ethdev_qid);
+       rc = sfc_tx_qstart(sa, sw_index);
        if (rc != 0)
                goto fail_tx_qstart;
 
-       sas->txq_info[tx_queue_id].deferred_started = B_TRUE;
+       txq_info->deferred_started = B_TRUE;
 
        sfc_adapter_unlock(sa);
        return 0;
@@ -1357,18 +1420,22 @@ fail_not_started:
 }
 
 static int
-sfc_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)
+sfc_tx_queue_stop(struct rte_eth_dev *dev, uint16_t ethdev_qid)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
+       struct sfc_txq_info *txq_info;
+       sfc_sw_index_t sw_index;
 
-       sfc_log_init(sa, "TxQ = %u", tx_queue_id);
+       sfc_log_init(sa, "TxQ = %u", ethdev_qid);
 
        sfc_adapter_lock(sa);
 
-       sfc_tx_qstop(sa, tx_queue_id);
+       sw_index = sfc_txq_sw_index_by_ethdev_tx_qid(sas, ethdev_qid);
+       sfc_tx_qstop(sa, sw_index);
 
-       sas->txq_info[tx_queue_id].deferred_started = B_FALSE;
+       txq_info = sfc_txq_info_by_ethdev_qid(sas, ethdev_qid);
+       txq_info->deferred_started = B_FALSE;
 
        sfc_adapter_unlock(sa);
        return 0;
@@ -1526,8 +1593,15 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
        struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_rss *rss = &sfc_sa2shared(sa)->rss;
        unsigned int efx_hash_types;
+       uint32_t contexts[] = {EFX_RSS_CONTEXT_DEFAULT, rss->dummy_rss_context};
+       unsigned int n_contexts;
+       unsigned int mode_i = 0;
+       unsigned int key_i = 0;
+       unsigned int i = 0;
        int rc = 0;
 
+       n_contexts = rss->dummy_rss_context == EFX_RSS_CONTEXT_DEFAULT ? 1 : 2;
+
        if (sfc_sa2shared(sa)->isolated)
                return -ENOTSUP;
 
@@ -1554,19 +1628,24 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
        if (rc != 0)
                goto fail_rx_hf_rte_to_efx;
 
-       rc = efx_rx_scale_mode_set(sa->nic, EFX_RSS_CONTEXT_DEFAULT,
-                                  rss->hash_alg, efx_hash_types, B_TRUE);
-       if (rc != 0)
-               goto fail_scale_mode_set;
+       for (mode_i = 0; mode_i < n_contexts; mode_i++) {
+               rc = efx_rx_scale_mode_set(sa->nic, contexts[mode_i],
+                                          rss->hash_alg, efx_hash_types,
+                                          B_TRUE);
+               if (rc != 0)
+                       goto fail_scale_mode_set;
+       }
 
        if (rss_conf->rss_key != NULL) {
                if (sa->state == SFC_ADAPTER_STARTED) {
-                       rc = efx_rx_scale_key_set(sa->nic,
-                                                 EFX_RSS_CONTEXT_DEFAULT,
-                                                 rss_conf->rss_key,
-                                                 sizeof(rss->key));
-                       if (rc != 0)
-                               goto fail_scale_key_set;
+                       for (key_i = 0; key_i < n_contexts; key_i++) {
+                               rc = efx_rx_scale_key_set(sa->nic,
+                                                         contexts[key_i],
+                                                         rss_conf->rss_key,
+                                                         sizeof(rss->key));
+                               if (rc != 0)
+                                       goto fail_scale_key_set;
+                       }
                }
 
                rte_memcpy(rss->key, rss_conf->rss_key, sizeof(rss->key));
@@ -1579,12 +1658,20 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
        return 0;
 
 fail_scale_key_set:
-       if (efx_rx_scale_mode_set(sa->nic, EFX_RSS_CONTEXT_DEFAULT,
-                                 EFX_RX_HASHALG_TOEPLITZ,
-                                 rss->hash_types, B_TRUE) != 0)
-               sfc_err(sa, "failed to restore RSS mode");
+       for (i = 0; i < key_i; i++) {
+               if (efx_rx_scale_key_set(sa->nic, contexts[i], rss->key,
+                                        sizeof(rss->key)) != 0)
+                       sfc_err(sa, "failed to restore RSS key");
+       }
 
 fail_scale_mode_set:
+       for (i = 0; i < mode_i; i++) {
+               if (efx_rx_scale_mode_set(sa->nic, contexts[i],
+                                         EFX_RX_HASHALG_TOEPLITZ,
+                                         rss->hash_types, B_TRUE) != 0)
+                       sfc_err(sa, "failed to restore RSS mode");
+       }
+
 fail_rx_hf_rte_to_efx:
        sfc_adapter_unlock(sa);
        return -rc;
@@ -1697,59 +1784,11 @@ bad_reta_entry:
 }
 
 static int
-sfc_dev_filter_ctrl(struct rte_eth_dev *dev, enum rte_filter_type filter_type,
-                   enum rte_filter_op filter_op,
-                   void *arg)
+sfc_dev_flow_ops_get(struct rte_eth_dev *dev __rte_unused,
+                    const struct rte_flow_ops **ops)
 {
-       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
-       int rc = ENOTSUP;
-
-       sfc_log_init(sa, "entry");
-
-       switch (filter_type) {
-       case RTE_ETH_FILTER_NONE:
-               sfc_err(sa, "Global filters configuration not supported");
-               break;
-       case RTE_ETH_FILTER_MACVLAN:
-               sfc_err(sa, "MACVLAN filters not supported");
-               break;
-       case RTE_ETH_FILTER_ETHERTYPE:
-               sfc_err(sa, "EtherType filters not supported");
-               break;
-       case RTE_ETH_FILTER_FLEXIBLE:
-               sfc_err(sa, "Flexible filters not supported");
-               break;
-       case RTE_ETH_FILTER_SYN:
-               sfc_err(sa, "SYN filters not supported");
-               break;
-       case RTE_ETH_FILTER_NTUPLE:
-               sfc_err(sa, "NTUPLE filters not supported");
-               break;
-       case RTE_ETH_FILTER_TUNNEL:
-               sfc_err(sa, "Tunnel filters not supported");
-               break;
-       case RTE_ETH_FILTER_FDIR:
-               sfc_err(sa, "Flow Director filters not supported");
-               break;
-       case RTE_ETH_FILTER_HASH:
-               sfc_err(sa, "Hash filters not supported");
-               break;
-       case RTE_ETH_FILTER_GENERIC:
-               if (filter_op != RTE_ETH_FILTER_GET) {
-                       rc = EINVAL;
-               } else {
-                       *(const void **)arg = &sfc_flow_ops;
-                       rc = 0;
-               }
-               break;
-       default:
-               sfc_err(sa, "Unknown filter type %u", filter_type);
-               break;
-       }
-
-       sfc_log_init(sa, "exit: %d", -rc);
-       SFC_ASSERT(rc >= 0);
-       return -rc;
+       *ops = &sfc_flow_ops;
+       return 0;
 }
 
 static int
@@ -1768,27 +1807,27 @@ sfc_pool_ops_supported(struct rte_eth_dev *dev, const char *pool)
 }
 
 static int
-sfc_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
+sfc_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t ethdev_qid)
 {
        const struct sfc_adapter_priv *sap = sfc_adapter_priv_by_eth_dev(dev);
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
+       sfc_ethdev_qid_t sfc_ethdev_qid = ethdev_qid;
        struct sfc_rxq_info *rxq_info;
 
-       SFC_ASSERT(queue_id < sas->rxq_count);
-       rxq_info = &sas->rxq_info[queue_id];
+       rxq_info = sfc_rxq_info_by_ethdev_qid(sas, sfc_ethdev_qid);
 
        return sap->dp_rx->intr_enable(rxq_info->dp);
 }
 
 static int
-sfc_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)
+sfc_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t ethdev_qid)
 {
        const struct sfc_adapter_priv *sap = sfc_adapter_priv_by_eth_dev(dev);
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
+       sfc_ethdev_qid_t sfc_ethdev_qid = ethdev_qid;
        struct sfc_rxq_info *rxq_info;
 
-       SFC_ASSERT(queue_id < sas->rxq_count);
-       rxq_info = &sas->rxq_info[queue_id];
+       rxq_info = sfc_rxq_info_by_ethdev_qid(sas, sfc_ethdev_qid);
 
        return sap->dp_rx->intr_disable(rxq_info->dp);
 }
@@ -1832,7 +1871,7 @@ static const struct eth_dev_ops sfc_eth_dev_ops = {
        .reta_query                     = sfc_dev_rss_reta_query,
        .rss_hash_update                = sfc_dev_rss_hash_update,
        .rss_hash_conf_get              = sfc_dev_rss_hash_conf_get,
-       .filter_ctrl                    = sfc_dev_filter_ctrl,
+       .flow_ops_get                   = sfc_dev_flow_ops_get,
        .set_mc_addr_list               = sfc_set_mc_addr_list,
        .rxq_info_get                   = sfc_rx_queue_info_get,
        .txq_info_get                   = sfc_tx_queue_info_get,
@@ -1883,6 +1922,11 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)
        case EFX_FAMILY_MEDFORD:
        case EFX_FAMILY_MEDFORD2:
                avail_caps |= SFC_DP_HW_FW_CAP_EF10;
+               avail_caps |= SFC_DP_HW_FW_CAP_RX_EFX;
+               avail_caps |= SFC_DP_HW_FW_CAP_TX_EFX;
+               break;
+       case EFX_FAMILY_RIVERHEAD:
+               avail_caps |= SFC_DP_HW_FW_CAP_EF100;
                break;
        default:
                break;
@@ -2099,27 +2143,18 @@ fail_alloc_priv:
        return rc;
 }
 
-static void
-sfc_eth_dev_secondary_clear_ops(struct rte_eth_dev *dev)
-{
-       free(dev->process_private);
-       dev->process_private = NULL;
-       dev->dev_ops = NULL;
-       dev->tx_pkt_prepare = NULL;
-       dev->tx_pkt_burst = NULL;
-       dev->rx_pkt_burst = NULL;
-}
-
 static void
 sfc_register_dp(void)
 {
        /* Register once */
        if (TAILQ_EMPTY(&sfc_dp_head)) {
                /* Prefer EF10 datapath */
+               sfc_dp_register(&sfc_dp_head, &sfc_ef100_rx.dp);
                sfc_dp_register(&sfc_dp_head, &sfc_ef10_essb_rx.dp);
                sfc_dp_register(&sfc_dp_head, &sfc_ef10_rx.dp);
                sfc_dp_register(&sfc_dp_head, &sfc_efx_rx.dp);
 
+               sfc_dp_register(&sfc_dp_head, &sfc_ef100_tx.dp);
                sfc_dp_register(&sfc_dp_head, &sfc_ef10_tx.dp);
                sfc_dp_register(&sfc_dp_head, &sfc_efx_tx.dp);
                sfc_dp_register(&sfc_dp_head, &sfc_ef10_simple_tx.dp);
@@ -2136,6 +2171,14 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
        int rc;
        const efx_nic_cfg_t *encp;
        const struct rte_ether_addr *from;
+       int ret;
+
+       if (sfc_efx_dev_class_get(pci_dev->device.devargs) !=
+                       SFC_EFX_DEV_CLASS_NET) {
+               SFC_GENERIC_LOG(DEBUG,
+                       "Incompatible device class: skip probing, should be probed by other sfc driver.");
+               return 1;
+       }
 
        sfc_register_dp();
 
@@ -2147,6 +2190,18 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
                return -sfc_eth_dev_secondary_init(dev, logtype_main);
 
        /* Required for logging */
+       ret = snprintf(sas->log_prefix, sizeof(sas->log_prefix),
+                       "PMD: sfc_efx " PCI_PRI_FMT " #%" PRIu16 ": ",
+                       pci_dev->addr.domain, pci_dev->addr.bus,
+                       pci_dev->addr.devid, pci_dev->addr.function,
+                       dev->data->port_id);
+       if (ret < 0 || ret >= (int)sizeof(sas->log_prefix)) {
+               SFC_GENERIC_LOG(ERR,
+                       "reserved log prefix is too short for " PCI_PRI_FMT,
+                       pci_dev->addr.domain, pci_dev->addr.bus,
+                       pci_dev->addr.devid, pci_dev->addr.function);
+               return -EINVAL;
+       }
        sas->pci_addr = pci_dev->addr;
        sas->port_id = dev->data->port_id;
 
@@ -2170,6 +2225,8 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
 
        /* Copy PCI device info to the dev->data */
        rte_eth_copy_pci_info(dev, pci_dev);
+       dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+       dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE;
 
        rc = sfc_kvargs_parse(sa);
        if (rc != 0)
@@ -2177,8 +2234,6 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
 
        sfc_log_init(sa, "entry");
 
-       dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
-
        dev->data->mac_addrs = rte_zmalloc("sfc", RTE_ETHER_ADDR_LEN, 0);
        if (dev->data->mac_addrs == NULL) {
                rc = ENOMEM;
@@ -2245,11 +2300,6 @@ fail_alloc_sa:
 static int
 sfc_eth_dev_uninit(struct rte_eth_dev *dev)
 {
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
-               sfc_eth_dev_secondary_clear_ops(dev);
-               return 0;
-       }
-
        sfc_dev_close(dev);
 
        return 0;
@@ -2264,6 +2314,7 @@ static const struct rte_pci_id pci_id_sfc_efx_map[] = {
        { RTE_PCI_DEVICE(EFX_PCI_VENID_SFC, EFX_PCI_DEVID_MEDFORD_VF) },
        { RTE_PCI_DEVICE(EFX_PCI_VENID_SFC, EFX_PCI_DEVID_MEDFORD2) },
        { RTE_PCI_DEVICE(EFX_PCI_VENID_SFC, EFX_PCI_DEVID_MEDFORD2_VF) },
+       { RTE_PCI_DEVICE(EFX_PCI_VENID_XILINX, EFX_PCI_DEVID_RIVERHEAD) },
        { .vendor_id = 0 /* sentinel */ }
 };