vhost: replace vDPA device ID in Vhost
[dpdk.git] / drivers / vdpa / mlx5 / mlx5_vdpa.c
index 94cac66..47db5fd 100644 (file)
@@ -2,6 +2,11 @@
  * Copyright 2019 Mellanox Technologies, Ltd
  */
 #include <unistd.h>
+#include <net/if.h>
+#include <sys/socket.h>
+#include <sys/ioctl.h>
+#include <fcntl.h>
+#include <netinet/in.h>
 
 #include <rte_malloc.h>
 #include <rte_log.h>
                            (1ULL << VIRTIO_NET_F_MQ) | \
                            (1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE) | \
                            (1ULL << VIRTIO_F_ORDER_PLATFORM) | \
-                           (1ULL << VHOST_F_LOG_ALL))
+                           (1ULL << VHOST_F_LOG_ALL) | \
+                           (1ULL << VIRTIO_NET_F_MTU))
 
 #define MLX5_VDPA_PROTOCOL_FEATURES \
                            ((1ULL << VHOST_USER_PROTOCOL_F_SLAVE_REQ) | \
                             (1ULL << VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD) | \
                             (1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER) | \
                             (1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD) | \
-                            (1ULL << VHOST_USER_PROTOCOL_F_MQ))
+                            (1ULL << VHOST_USER_PROTOCOL_F_MQ) | \
+                            (1ULL << VHOST_USER_PROTOCOL_F_NET_MTU))
+
+#define MLX5_VDPA_MAX_RETRIES 20
+#define MLX5_VDPA_USEC 1000
 
 TAILQ_HEAD(mlx5_vdpa_privs, mlx5_vdpa_priv) priv_list =
                                              TAILQ_HEAD_INITIALIZER(priv_list);
@@ -40,21 +50,21 @@ static pthread_mutex_t priv_list_lock = PTHREAD_MUTEX_INITIALIZER;
 int mlx5_vdpa_logtype;
 
 static struct mlx5_vdpa_priv *
-mlx5_vdpa_find_priv_resource_by_did(int did)
+mlx5_vdpa_find_priv_resource_by_vdev(struct rte_vdpa_device *vdev)
 {
        struct mlx5_vdpa_priv *priv;
        int found = 0;
 
        pthread_mutex_lock(&priv_list_lock);
        TAILQ_FOREACH(priv, &priv_list, next) {
-               if (did == priv->id) {
+               if (vdev == priv->vdev) {
                        found = 1;
                        break;
                }
        }
        pthread_mutex_unlock(&priv_list_lock);
        if (!found) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                rte_errno = EINVAL;
                return NULL;
        }
@@ -62,12 +72,13 @@ mlx5_vdpa_find_priv_resource_by_did(int did)
 }
 
 static int
-mlx5_vdpa_get_queue_num(int did, uint32_t *queue_num)
+mlx5_vdpa_get_queue_num(struct rte_vdpa_device *vdev, uint32_t *queue_num)
 {
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -1;
        }
        *queue_num = priv->caps.max_num_virtio_queues;
@@ -75,12 +86,13 @@ mlx5_vdpa_get_queue_num(int did, uint32_t *queue_num)
 }
 
 static int
-mlx5_vdpa_get_vdpa_features(int did, uint64_t *features)
+mlx5_vdpa_get_vdpa_features(struct rte_vdpa_device *vdev, uint64_t *features)
 {
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -1;
        }
        *features = MLX5_VDPA_DEFAULT_FEATURES;
@@ -100,12 +112,14 @@ mlx5_vdpa_get_vdpa_features(int did, uint64_t *features)
 }
 
 static int
-mlx5_vdpa_get_protocol_features(int did, uint64_t *features)
+mlx5_vdpa_get_protocol_features(struct rte_vdpa_device *vdev,
+               uint64_t *features)
 {
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -1;
        }
        *features = MLX5_VDPA_PROTOCOL_FEATURES;
@@ -115,11 +129,12 @@ mlx5_vdpa_get_protocol_features(int did, uint64_t *features)
 static int
 mlx5_vdpa_set_vring_state(int vid, int vring, int state)
 {
-       int did = rte_vhost_get_vdpa_device_id(vid);
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct rte_vdpa_device *vdev = rte_vhost_get_vdpa_device(vid);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -EINVAL;
        }
        if (vring >= (int)priv->caps.max_num_virtio_queues * 2) {
@@ -155,14 +170,15 @@ mlx5_vdpa_direct_db_prepare(struct mlx5_vdpa_priv *priv)
 static int
 mlx5_vdpa_features_set(int vid)
 {
-       int did = rte_vhost_get_vdpa_device_id(vid);
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct rte_vdpa_device *vdev = rte_vhost_get_vdpa_device(vid);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
        uint64_t log_base, log_size;
        uint64_t features;
        int ret;
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -EINVAL;
        }
        ret = rte_vhost_get_negotiated_features(vid, &features);
@@ -222,15 +238,65 @@ mlx5_vdpa_pd_create(struct mlx5_vdpa_priv *priv)
 #endif /* HAVE_IBV_FLOW_DV_SUPPORT */
 }
 
+static int
+mlx5_vdpa_mtu_set(struct mlx5_vdpa_priv *priv)
+{
+       struct ifreq request;
+       uint16_t vhost_mtu = 0;
+       uint16_t kern_mtu = 0;
+       int ret = rte_vhost_get_mtu(priv->vid, &vhost_mtu);
+       int sock;
+       int retries = MLX5_VDPA_MAX_RETRIES;
+
+       if (ret) {
+               DRV_LOG(DEBUG, "Cannot get vhost MTU - %d.", ret);
+               return ret;
+       }
+       if (!vhost_mtu) {
+               DRV_LOG(DEBUG, "Vhost MTU is 0.");
+               return ret;
+       }
+       ret = mlx5_get_ifname_sysfs(priv->ctx->device->ibdev_path,
+                                   request.ifr_name);
+       if (ret) {
+               DRV_LOG(DEBUG, "Cannot get kernel IF name - %d.", ret);
+               return ret;
+       }
+       sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP);
+       if (sock == -1) {
+               DRV_LOG(DEBUG, "Cannot open IF socket.");
+               return sock;
+       }
+       while (retries--) {
+               ret = ioctl(sock, SIOCGIFMTU, &request);
+               if (ret == -1)
+                       break;
+               kern_mtu = request.ifr_mtu;
+               DRV_LOG(DEBUG, "MTU: current %d requested %d.", (int)kern_mtu,
+                       (int)vhost_mtu);
+               if (kern_mtu == vhost_mtu)
+                       break;
+               request.ifr_mtu = vhost_mtu;
+               ret = ioctl(sock, SIOCSIFMTU, &request);
+               if (ret == -1)
+                       break;
+               request.ifr_mtu = 0;
+               usleep(MLX5_VDPA_USEC);
+       }
+       close(sock);
+       return kern_mtu == vhost_mtu ? 0 : -1;
+}
+
 static int
 mlx5_vdpa_dev_close(int vid)
 {
-       int did = rte_vhost_get_vdpa_device_id(vid);
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct rte_vdpa_device *vdev = rte_vhost_get_vdpa_device(vid);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
        int ret = 0;
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -1;
        }
        if (priv->configured)
@@ -253,11 +319,12 @@ mlx5_vdpa_dev_close(int vid)
 static int
 mlx5_vdpa_dev_config(int vid)
 {
-       int did = rte_vhost_get_vdpa_device_id(vid);
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct rte_vdpa_device *vdev = rte_vhost_get_vdpa_device(vid);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -EINVAL;
        }
        if (priv->configured && mlx5_vdpa_dev_close(vid)) {
@@ -265,6 +332,9 @@ mlx5_vdpa_dev_config(int vid)
                return -1;
        }
        priv->vid = vid;
+       if (mlx5_vdpa_mtu_set(priv))
+               DRV_LOG(WARNING, "MTU cannot be set on device %s.",
+                               vdev->device->name);
        if (mlx5_vdpa_pd_create(priv) || mlx5_vdpa_mem_register(priv) ||
            mlx5_vdpa_direct_db_prepare(priv) ||
            mlx5_vdpa_virtqs_prepare(priv) || mlx5_vdpa_steer_setup(priv) ||
@@ -280,11 +350,12 @@ mlx5_vdpa_dev_config(int vid)
 static int
 mlx5_vdpa_get_device_fd(int vid)
 {
-       int did = rte_vhost_get_vdpa_device_id(vid);
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct rte_vdpa_device *vdev = rte_vhost_get_vdpa_device(vid);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -EINVAL;
        }
        return priv->ctx->cmd_fd;
@@ -293,17 +364,18 @@ mlx5_vdpa_get_device_fd(int vid)
 static int
 mlx5_vdpa_get_notify_area(int vid, int qid, uint64_t *offset, uint64_t *size)
 {
-       int did = rte_vhost_get_vdpa_device_id(vid);
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct rte_vdpa_device *vdev = rte_vhost_get_vdpa_device(vid);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        RTE_SET_USED(qid);
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name);
                return -EINVAL;
        }
        if (!priv->var) {
-               DRV_LOG(ERR, "VAR was not created for device %d, is the device"
-                       " configured?.", did);
+               DRV_LOG(ERR, "VAR was not created for device %s, is the device"
+                       " configured?.", vdev->device->name);
                return -EINVAL;
        }
        *offset = priv->var->mmap_off;
@@ -312,8 +384,9 @@ mlx5_vdpa_get_notify_area(int vid, int qid, uint64_t *offset, uint64_t *size)
 }
 
 static int
-mlx5_vdpa_get_stats_names(int did, struct rte_vdpa_stat_name *stats_names,
-                         unsigned int size)
+mlx5_vdpa_get_stats_names(struct rte_vdpa_device *vdev,
+               struct rte_vdpa_stat_name *stats_names,
+               unsigned int size)
 {
        static const char *mlx5_vdpa_stats_names[MLX5_VDPA_STATS_MAX] = {
                "received_descriptors",
@@ -323,11 +396,12 @@ mlx5_vdpa_get_stats_names(int did, struct rte_vdpa_stat_name *stats_names,
                "invalid buffer",
                "completion errors",
        };
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
        unsigned int i;
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid device: %s.", vdev->device->name);
                return -ENODEV;
        }
        if (!stats_names)
@@ -340,51 +414,57 @@ mlx5_vdpa_get_stats_names(int did, struct rte_vdpa_stat_name *stats_names,
 }
 
 static int
-mlx5_vdpa_get_stats(int did, int qid, struct rte_vdpa_stat *stats,
-                   unsigned int n)
+mlx5_vdpa_get_stats(struct rte_vdpa_device *vdev, int qid,
+               struct rte_vdpa_stat *stats, unsigned int n)
 {
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid device: %s.", vdev->device->name);
                return -ENODEV;
        }
        if (!priv->configured) {
-               DRV_LOG(ERR, "Device %d was not configured.", did);
+               DRV_LOG(ERR, "Device %s was not configured.",
+                               vdev->device->name);
                return -ENODATA;
        }
        if (qid >= (int)priv->nr_virtqs) {
-               DRV_LOG(ERR, "Too big vring id: %d.", qid);
+               DRV_LOG(ERR, "Too big vring id: %d for device %s.", qid,
+                               vdev->device->name);
                return -E2BIG;
        }
        if (!priv->caps.queue_counters_valid) {
-               DRV_LOG(ERR, "Virtq statistics is not supported for device %d.",
-                       did);
+               DRV_LOG(ERR, "Virtq statistics is not supported for device %s.",
+                       vdev->device->name);
                return -ENOTSUP;
        }
        return mlx5_vdpa_virtq_stats_get(priv, qid, stats, n);
 }
 
 static int
-mlx5_vdpa_reset_stats(int did, int qid)
+mlx5_vdpa_reset_stats(struct rte_vdpa_device *vdev, int qid)
 {
-       struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);
+       struct mlx5_vdpa_priv *priv =
+               mlx5_vdpa_find_priv_resource_by_vdev(vdev);
 
        if (priv == NULL) {
-               DRV_LOG(ERR, "Invalid device id: %d.", did);
+               DRV_LOG(ERR, "Invalid device: %s.", vdev->device->name);
                return -ENODEV;
        }
        if (!priv->configured) {
-               DRV_LOG(ERR, "Device %d was not configured.", did);
+               DRV_LOG(ERR, "Device %s was not configured.",
+                               vdev->device->name);
                return -ENODATA;
        }
        if (qid >= (int)priv->nr_virtqs) {
-               DRV_LOG(ERR, "Too big vring id: %d.", qid);
+               DRV_LOG(ERR, "Too big vring id: %d for device %s.", qid,
+                               vdev->device->name);
                return -E2BIG;
        }
        if (!priv->caps.queue_counters_valid) {
-               DRV_LOG(ERR, "Virtq statistics is not supported for device %d.",
-                       did);
+               DRV_LOG(ERR, "Virtq statistics is not supported for device %s.",
+                       vdev->device->name);
                return -ENOTSUP;
        }
        return mlx5_vdpa_virtq_stats_reset(priv, qid);
@@ -513,8 +593,6 @@ close:
        return ret;
 }
 
-#define MLX5_VDPA_MAX_RETRIES 20
-#define MLX5_VDPA_USEC 1000
 static int
 mlx5_vdpa_roce_disable(struct rte_pci_addr *addr, struct ibv_device **ibv)
 {
@@ -622,15 +700,15 @@ mlx5_vdpa_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
        priv->caps = attr.vdpa;
        priv->log_max_rqt_size = attr.log_max_rqt_size;
        priv->ctx = ctx;
-       priv->dev_addr.pci_addr = pci_dev->addr;
-       priv->dev_addr.type = VDPA_ADDR_PCI;
+       priv->pci_dev = pci_dev;
        priv->var = mlx5_glue->dv_alloc_var(ctx, 0);
        if (!priv->var) {
                DRV_LOG(ERR, "Failed to allocate VAR %u.\n", errno);
                goto error;
        }
-       priv->id = rte_vdpa_register_device(&priv->dev_addr, &mlx5_vdpa_ops);
-       if (priv->id < 0) {
+       priv->vdev = rte_vdpa_register_device(&pci_dev->device,
+                       &mlx5_vdpa_ops);
+       if (priv->vdev == NULL) {
                DRV_LOG(ERR, "Failed to register vDPA device.");
                rte_errno = rte_errno ? rte_errno : EINVAL;
                goto error;
@@ -671,8 +749,7 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev)
 
        pthread_mutex_lock(&priv_list_lock);
        TAILQ_FOREACH(priv, &priv_list, next) {
-               if (memcmp(&priv->dev_addr.pci_addr, &pci_dev->addr,
-                          sizeof(pci_dev->addr)) == 0) {
+               if (!rte_pci_addr_cmp(&priv->pci_dev->addr, &pci_dev->addr)) {
                        found = 1;
                        break;
                }