examples: fix port id type
[dpdk.git] / examples / l2fwd-jobstats / main.c
index c193840..dfa3c8b 100644 (file)
@@ -38,7 +38,6 @@
 #include <ctype.h>
 #include <getopt.h>
 
-#include <rte_alarm.h>
 #include <rte_common.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
@@ -46,7 +45,6 @@
 #include <rte_memcpy.h>
 #include <rte_memzone.h>
 #include <rte_eal.h>
-#include <rte_per_lcore.h>
 #include <rte_launch.h>
 #include <rte_atomic.h>
 #include <rte_cycles.h>
@@ -59,7 +57,6 @@
 #include <rte_debug.h>
 #include <rte_ether.h>
 #include <rte_ethdev.h>
-#include <rte_ring.h>
 #include <rte_mempool.h>
 #include <rte_mbuf.h>
 #include <rte_spinlock.h>
@@ -68,6 +65,7 @@
 #include <rte_jobstats.h>
 #include <rte_timer.h>
 #include <rte_alarm.h>
+#include <rte_pause.h>
 
 #define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1
 
@@ -127,7 +125,7 @@ static const struct rte_eth_conf port_conf = {
                .hw_ip_checksum = 0, /**< IP checksum offload disabled */
                .hw_vlan_filter = 0, /**< VLAN filtering disabled */
                .jumbo_frame    = 0, /**< Jumbo Frame Support disabled */
-               .hw_strip_crc   = 0, /**< CRC stripped by hardware */
+               .hw_strip_crc   = 1, /**< CRC stripped by hardware */
        },
        .txmode = {
                .mq_mode = ETH_MQ_TX_NONE,
@@ -178,7 +176,7 @@ show_lcore_stats(unsigned lcore_id)
        uint64_t busy, busy_min, busy_max;
 
        /* Jobs statistics. */
-       const uint8_t port_cnt = qconf->n_rx_port;
+       const uint16_t port_cnt = qconf->n_rx_port;
        uint64_t jobs_exec_cnt[port_cnt], jobs_period[port_cnt];
        uint64_t jobs_exec[port_cnt], jobs_exec_min[port_cnt],
                                jobs_exec_max[port_cnt];
@@ -416,11 +414,11 @@ l2fwd_fwd_job(__rte_unused struct rte_timer *timer, void *arg)
        struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
        struct rte_mbuf *m;
 
-       const uint8_t port_idx = (uintptr_t) arg;
+       const uint16_t port_idx = (uintptr_t) arg;
        const unsigned lcore_id = rte_lcore_id();
        struct lcore_queue_conf *qconf = &lcore_queue_conf[lcore_id];
        struct rte_jobstats *job = &qconf->port_fwd_jobs[port_idx];
-       const uint8_t portid = qconf->rx_port_list[port_idx];
+       const uint16_t portid = qconf->rx_port_list[port_idx];
 
        uint8_t j;
        uint16_t total_nb_rx;
@@ -430,7 +428,7 @@ l2fwd_fwd_job(__rte_unused struct rte_timer *timer, void *arg)
        /* Call rx burst 2 times. This allow rte_jobstats logic to see if this
         * function must be called more frequently. */
 
-       total_nb_rx = rte_eth_rx_burst((uint8_t) portid, 0, pkts_burst,
+       total_nb_rx = rte_eth_rx_burst(portid, 0, pkts_burst,
                        MAX_PKT_BURST);
 
        for (j = 0; j < total_nb_rx; j++) {
@@ -440,7 +438,7 @@ l2fwd_fwd_job(__rte_unused struct rte_timer *timer, void *arg)
        }
 
        if (total_nb_rx == MAX_PKT_BURST) {
-               const uint16_t nb_rx = rte_eth_rx_burst((uint8_t) portid, 0, pkts_burst,
+               const uint16_t nb_rx = rte_eth_rx_burst(portid, 0, pkts_burst,
                                MAX_PKT_BURST);
 
                total_nb_rx += nb_rx;
@@ -466,7 +464,7 @@ l2fwd_flush_job(__rte_unused struct rte_timer *timer, __rte_unused void *arg)
        uint64_t now;
        unsigned lcore_id;
        struct lcore_queue_conf *qconf;
-       uint8_t portid;
+       uint16_t portid;
        unsigned i;
        uint32_t sent;
        struct rte_eth_dev_tx_buffer *buffer;
@@ -710,17 +708,18 @@ l2fwd_parse_args(int argc, char **argv)
                argv[optind-1] = prgname;
 
        ret = optind-1;
-       optind = 0; /* reset getopt lib */
+       optind = 1; /* reset getopt lib */
        return ret;
 }
 
 /* Check the link status of all ports in up to 9s, and print them finally */
 static void
-check_all_ports_link_status(uint8_t port_num, uint32_t port_mask)
+check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
 {
 #define CHECK_INTERVAL 100 /* 100ms */
 #define MAX_CHECK_TIME 90 /* 9s (90 * 100ms) in total */
-       uint8_t portid, count, all_ports_up, print_flag = 0;
+       uint16_t portid;
+       uint8_t count, all_ports_up, print_flag = 0;
        struct rte_eth_link link;
 
        printf("\nChecking link status");
@@ -735,14 +734,13 @@ check_all_ports_link_status(uint8_t port_num, uint32_t port_mask)
                        /* print link status if flag set */
                        if (print_flag == 1) {
                                if (link.link_status)
-                                       printf("Port %d Link Up - speed %u "
-                                               "Mbps - %s\n", (uint8_t)portid,
-                                               (unsigned)link.link_speed,
+                                       printf(
+                                       "Port%d Link Up. Speed %u Mbps - %s\n",
+                                               portid, link.link_speed,
                                (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
                                        ("full-duplex") : ("half-duplex\n"));
                                else
-                                       printf("Port %d Link Down\n",
-                                               (uint8_t)portid);
+                                       printf("Port %d Link Down\n", portid);
                                continue;
                        }
                        /* clear all_ports_up flag if any link down */
@@ -778,9 +776,9 @@ main(int argc, char **argv)
        unsigned nb_ports_in_mask = 0;
        int ret;
        char name[RTE_JOBSTATS_NAMESIZE];
-       uint8_t nb_ports;
-       uint8_t nb_ports_available;
-       uint8_t portid, last_port;
+       uint16_t nb_ports;
+       uint16_t nb_ports_available;
+       uint16_t portid, last_port;
        uint8_t i;
 
        /* init EAL */
@@ -863,7 +861,7 @@ main(int argc, char **argv)
 
                qconf->rx_port_list[qconf->n_rx_port] = portid;
                qconf->n_rx_port++;
-               printf("Lcore %u: RX port %u\n", rx_lcore_id, (unsigned) portid);
+               printf("Lcore %u: RX port %u\n", rx_lcore_id, portid);
        }
 
        nb_ports_available = nb_ports;
@@ -872,17 +870,24 @@ main(int argc, char **argv)
        for (portid = 0; portid < nb_ports; portid++) {
                /* skip ports that are not enabled */
                if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) {
-                       printf("Skipping disabled port %u\n", (unsigned) portid);
+                       printf("Skipping disabled port %u\n", portid);
                        nb_ports_available--;
                        continue;
                }
                /* init port */
-               printf("Initializing port %u... ", (unsigned) portid);
+               printf("Initializing port %u... ", portid);
                fflush(stdout);
                ret = rte_eth_dev_configure(portid, 1, 1, &port_conf);
                if (ret < 0)
                        rte_exit(EXIT_FAILURE, "Cannot configure device: err=%d, port=%u\n",
-                                 ret, (unsigned) portid);
+                                 ret, portid);
+
+               ret = rte_eth_dev_adjust_nb_rx_tx_desc(portid, &nb_rxd,
+                                                      &nb_txd);
+               if (ret < 0)
+                       rte_exit(EXIT_FAILURE,
+                                "Cannot adjust number of descriptors: err=%d, port=%u\n",
+                                ret, portid);
 
                rte_eth_macaddr_get(portid, &l2fwd_ports_eth_addr[portid]);
 
@@ -894,7 +899,7 @@ main(int argc, char **argv)
                                             l2fwd_pktmbuf_pool);
                if (ret < 0)
                        rte_exit(EXIT_FAILURE, "rte_eth_rx_queue_setup:err=%d, port=%u\n",
-                                 ret, (unsigned) portid);
+                                 ret, portid);
 
                /* init one TX queue on each port */
                fflush(stdout);
@@ -902,8 +907,9 @@ main(int argc, char **argv)
                                rte_eth_dev_socket_id(portid),
                                NULL);
                if (ret < 0)
-                       rte_exit(EXIT_FAILURE, "rte_eth_tx_queue_setup:err=%d, port=%u\n",
-                               ret, (unsigned) portid);
+                       rte_exit(EXIT_FAILURE,
+                       "rte_eth_tx_queue_setup:err=%d, port=%u\n",
+                               ret, portid);
 
                /* Initialize TX buffers */
                tx_buffer[portid] = rte_zmalloc_socket("tx_buffer",
@@ -911,7 +917,7 @@ main(int argc, char **argv)
                                rte_eth_dev_socket_id(portid));
                if (tx_buffer[portid] == NULL)
                        rte_exit(EXIT_FAILURE, "Cannot allocate buffer for tx on port %u\n",
-                                       (unsigned) portid);
+                                       portid);
 
                rte_eth_tx_buffer_init(tx_buffer[portid], MAX_PKT_BURST);
 
@@ -919,21 +925,22 @@ main(int argc, char **argv)
                                rte_eth_tx_buffer_count_callback,
                                &port_statistics[portid].dropped);
                if (ret < 0)
-                               rte_exit(EXIT_FAILURE, "Cannot set error callback for "
-                                               "tx buffer on port %u\n", (unsigned) portid);
+                       rte_exit(EXIT_FAILURE,
+                       "Cannot set error callback for tx buffer on port %u\n",
+                                portid);
 
                /* Start device */
                ret = rte_eth_dev_start(portid);
                if (ret < 0)
                        rte_exit(EXIT_FAILURE, "rte_eth_dev_start:err=%d, port=%u\n",
-                                 ret, (unsigned) portid);
+                                 ret, portid);
 
                printf("done:\n");
 
                rte_eth_promiscuous_enable(portid);
 
                printf("Port %u, MAC address: %02X:%02X:%02X:%02X:%02X:%02X\n\n",
-                               (unsigned) portid,
+                               portid,
                                l2fwd_ports_eth_addr[portid].addr_bytes[0],
                                l2fwd_ports_eth_addr[portid].addr_bytes[1],
                                l2fwd_ports_eth_addr[portid].addr_bytes[2],
@@ -987,7 +994,7 @@ main(int argc, char **argv)
                        struct rte_jobstats *job = &qconf->port_fwd_jobs[i];
 
                        portid = qconf->rx_port_list[i];
-                       printf("Setting forward jon for port %u\n", portid);
+                       printf("Setting forward job for port %u\n", portid);
 
                        snprintf(name, RTE_DIM(name), "port %u fwd", portid);
                        /* Setup forward job.