vhost: replace vDPA device ID in Vhost
[dpdk.git] / examples / vdpa / main.c
index d9a9112..6a719e3 100644 (file)
@@ -18,6 +18,7 @@
 #include <cmdline_parse.h>
 #include <cmdline_socket.h>
 #include <cmdline_parse_string.h>
+#include <cmdline_parse_num.h>
 #include <cmdline.h>
 
 #define MAX_PATH_LEN 128
@@ -29,6 +30,9 @@ struct vdpa_port {
        int did;
        int vid;
        uint64_t flags;
+       int stats_n;
+       struct rte_vdpa_stat_name *stats_names;
+       struct rte_vdpa_stat *stats;
 };
 
 static struct vdpa_port vports[MAX_VDPA_SAMPLE_PORTS];
@@ -145,6 +149,7 @@ start_vdpa(struct vdpa_port *vport)
 {
        int ret;
        char *socket_path = vport->ifname;
+       struct rte_vdpa_device *vdev;
        int did = vport->did;
 
        if (client_mode)
@@ -169,7 +174,13 @@ start_vdpa(struct vdpa_port *vport)
                        "register driver ops failed: %s\n",
                        socket_path);
 
-       ret = rte_vhost_driver_attach_vdpa_device(socket_path, did);
+       vdev = rte_vdpa_get_device(did);
+       if (!vdev)
+               rte_exit(EXIT_FAILURE,
+                       "vDPA device retrieval failed: %p\n",
+                       vdev);
+
+       ret = rte_vhost_driver_attach_vdpa_device(socket_path, vdev);
        if (ret != 0)
                rte_exit(EXIT_FAILURE,
                        "attach vdpa device failed: %s\n",
@@ -199,6 +210,10 @@ close_vdpa(struct vdpa_port *vport)
                RTE_LOG(ERR, VDPA,
                                "Fail to unregister vhost driver for %s.\n",
                                socket_path);
+       if (vport->stats_names) {
+               rte_free(vport->stats_names);
+               vport->stats_names = NULL;
+       }
 }
 
 static void
@@ -240,6 +255,7 @@ static void cmd_help_parsed(__rte_unused void *parsed_result,
                "    help                                      : Show interactive instructions.\n"
                "    list                                      : list all available vdpa devices.\n"
                "    create <socket file> <vdev addr>          : create a new vdpa port.\n"
+               "    stats <device ID> <virtio queue ID>       : show statistics of virtio queue, 0xffff for all.\n"
                "    quit                                      : exit vdpa sample app.\n"
        );
 }
@@ -271,30 +287,31 @@ static void cmd_list_vdpa_devices_parsed(
        uint32_t queue_num;
        uint64_t features;
        struct rte_vdpa_device *vdev;
-       struct rte_pci_addr addr;
+       struct rte_device *dev;
+       struct rte_dev_iterator dev_iter;
 
-       cmdline_printf(cl, "device id\tdevice address\tqueue num\tsupported features\n");
-       for (did = 0; did < dev_total; did++) {
+       cmdline_printf(cl, "device id\tdevice name\tqueue num\tsupported features\n");
+       RTE_DEV_FOREACH(dev, "class=vdpa", &dev_iter) {
+               did = rte_vdpa_find_device_id_by_name(dev->name);
+               if (did < 0)
+                       continue;
                vdev = rte_vdpa_get_device(did);
                if (!vdev)
                        continue;
-               if (vdev->ops->get_queue_num(did, &queue_num) < 0) {
+               if (vdev->ops->get_queue_num(vdev, &queue_num) < 0) {
                        RTE_LOG(ERR, VDPA,
                                "failed to get vdpa queue number "
                                "for device id %d.\n", did);
                        continue;
                }
-               if (vdev->ops->get_features(did, &features) < 0) {
+               if (vdev->ops->get_features(vdev, &features) < 0) {
                        RTE_LOG(ERR, VDPA,
                                "failed to get vdpa features "
                                "for device id %d.\n", did);
                        continue;
                }
-               addr = vdev->addr.pci_addr;
-               cmdline_printf(cl,
-                       "%d\t\t" PCI_PRI_FMT "\t%" PRIu32 "\t\t0x%" PRIx64 "\n",
-                       did, addr.domain, addr.bus, addr.devid,
-                       addr.function, queue_num, features);
+               cmdline_printf(cl, "%d\t\t%s\t\t%" PRIu32 "\t\t0x%" PRIx64 "\n",
+                       did, dev->name, queue_num, features);
        }
 }
 
@@ -324,17 +341,12 @@ static void cmd_create_vdpa_port_parsed(void *parsed_result,
 {
        int did;
        struct cmd_create_result *res = parsed_result;
-       struct rte_vdpa_dev_addr addr;
 
        rte_strscpy(vports[devcnt].ifname, res->socket_path, MAX_PATH_LEN);
-       if (rte_pci_addr_parse(res->bdf, &addr.pci_addr) != 0) {
-               cmdline_printf(cl, "Unable to parse the given bdf.\n");
-               return;
-       }
-       addr.type = VDPA_ADDR_PCI;
-       did = rte_vdpa_find_device_id(&addr);
+       did = rte_vdpa_find_device_id_by_name(res->bdf);
        if (did < 0) {
-               cmdline_printf(cl, "Unable to find vdpa device id.\n");
+               cmdline_printf(cl, "Unable to find vdpa device id for %s.\n",
+                               res->bdf);
                return;
        }
 
@@ -363,6 +375,115 @@ cmdline_parse_inst_t cmd_create_vdpa_port = {
        },
 };
 
+/* *** STATS *** */
+struct cmd_stats_result {
+       cmdline_fixed_string_t stats;
+       uint16_t did;
+       uint16_t qid;
+};
+
+static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
+                                   __rte_unused void *data)
+{
+       struct cmd_stats_result *res = parsed_result;
+       struct rte_vdpa_device *vdev = rte_vdpa_get_device(res->did);
+       struct vdpa_port *vport = NULL;
+       uint32_t first, last;
+       int i;
+
+       if (!vdev) {
+               RTE_LOG(ERR, VDPA, "Invalid device id %" PRIu16 ".\n",
+                       res->did);
+               return;
+       }
+       for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total); i++) {
+               if (vports[i].did == res->did) {
+                       vport = &vports[i];
+                       break;
+               }
+       }
+       if (!vport) {
+               RTE_LOG(ERR, VDPA, "Device id %" PRIu16 " was not created.\n",
+                       res->did);
+               return;
+       }
+       if (res->qid == 0xFFFF) {
+               first = 0;
+               last = rte_vhost_get_vring_num(vport->vid);
+               if (last == 0) {
+                       RTE_LOG(ERR, VDPA, "Failed to get num of actual virtqs"
+                               " for device id %d.\n", (int)res->did);
+                       return;
+               }
+               last--;
+       } else {
+               first = res->qid;
+               last = res->qid;
+       }
+       if (!vport->stats_names) {
+               vport->stats_n = rte_vdpa_get_stats_names(vport->did, NULL, 0);
+               if (vport->stats_n <= 0) {
+                       RTE_LOG(ERR, VDPA, "Failed to get names number of "
+                               "device %d stats.\n", (int)res->did);
+                       return;
+               }
+               vport->stats_names = rte_zmalloc(NULL,
+                       (sizeof(*vport->stats_names) + sizeof(*vport->stats)) *
+                                                       vport->stats_n, 0);
+               if (!vport->stats_names) {
+                       RTE_LOG(ERR, VDPA, "Failed to allocate memory for stat"
+                               " names of device %d.\n", (int)res->did);
+                       return;
+               }
+               i = rte_vdpa_get_stats_names(vport->did, vport->stats_names,
+                                               vport->stats_n);
+               if (vport->stats_n != i) {
+                       RTE_LOG(ERR, VDPA, "Failed to get names of device %d "
+                               "stats.\n", (int)res->did);
+                       return;
+               }
+               vport->stats = (struct rte_vdpa_stat *)
+                                       (vport->stats_names + vport->stats_n);
+       }
+       cmdline_printf(cl, "\nDevice %d:\n", (int)res->did);
+       for (; first <= last; first++) {
+               memset(vport->stats, 0, sizeof(*vport->stats) * vport->stats_n);
+               if (rte_vdpa_get_stats(vport->did, (int)first, vport->stats,
+                                       vport->stats_n) <= 0) {
+                       RTE_LOG(ERR, VDPA, "Failed to get vdpa queue statistics"
+                               " for device id %d qid %d.\n", (int)res->did,
+                               (int)first);
+                       return;
+               }
+               cmdline_printf(cl, "\tVirtq %" PRIu32 ":\n", first);
+               for (i = 0; i < vport->stats_n; ++i) {
+                       cmdline_printf(cl, "\t\t%-*s %-16" PRIu64 "\n",
+                               RTE_VDPA_STATS_NAME_SIZE,
+                               vport->stats_names[vport->stats[i].id].name,
+                               vport->stats[i].value);
+               }
+       }
+}
+
+cmdline_parse_token_string_t cmd_device_stats_ =
+       TOKEN_STRING_INITIALIZER(struct cmd_stats_result, stats, "stats");
+cmdline_parse_token_num_t cmd_device_id =
+       TOKEN_NUM_INITIALIZER(struct cmd_stats_result, did, UINT32);
+cmdline_parse_token_num_t cmd_queue_id =
+       TOKEN_NUM_INITIALIZER(struct cmd_stats_result, qid, UINT32);
+
+cmdline_parse_inst_t cmd_device_stats = {
+       .f = cmd_device_stats_parsed,
+       .data = NULL,
+       .help_str = "stats: show device statistics",
+       .tokens = {
+               (void *)&cmd_device_stats_,
+               (void *)&cmd_device_id,
+               (void *)&cmd_queue_id,
+               NULL,
+       },
+};
+
 /* *** QUIT *** */
 struct cmd_quit_result {
        cmdline_fixed_string_t quit;
@@ -392,6 +513,7 @@ cmdline_parse_ctx_t main_ctx[] = {
        (cmdline_parse_inst_t *)&cmd_help,
        (cmdline_parse_inst_t *)&cmd_list_vdpa_devices,
        (cmdline_parse_inst_t *)&cmd_create_vdpa_port,
+       (cmdline_parse_inst_t *)&cmd_device_stats,
        (cmdline_parse_inst_t *)&cmd_quit,
        NULL,
 };
@@ -400,9 +522,11 @@ int
 main(int argc, char *argv[])
 {
        char ch;
-       int i;
+       int did;
        int ret;
        struct cmdline *cl;
+       struct rte_device *dev;
+       struct rte_dev_iterator dev_iter;
 
        ret = rte_eal_init(argc, argv);
        if (ret < 0)
@@ -428,13 +552,18 @@ main(int argc, char *argv[])
                cmdline_interact(cl);
                cmdline_stdin_exit(cl);
        } else {
-               for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total);
-                               i++) {
-                       vports[i].did = i;
-                       snprintf(vports[i].ifname, MAX_PATH_LEN, "%s%d",
-                                       iface, i);
+               RTE_DEV_FOREACH(dev, "class=vdpa", &dev_iter) {
+                       did = rte_vdpa_find_device_id_by_name(dev->name);
+                       if (did < 0) {
+                               rte_panic("Failed to find device id for %s\n",
+                                               dev->name);
+                       }
+                       vports[devcnt].did = did;
+                       snprintf(vports[devcnt].ifname, MAX_PATH_LEN, "%s%d",
+                                       iface, devcnt);
 
-                       start_vdpa(&vports[i]);
+                       start_vdpa(&vports[devcnt]);
+                       devcnt++;
                }
 
                printf("enter \'q\' to quit\n");