/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2016, Olivier MATZ <zer0@droids-corp.org>
+ * Copyright 2016, Olivier MATZ <zer0@droids-corp.org>
*/
#include <stdio.h>
if (child == NULL)
return -ENOMEM;
- ec_parsed_add_child(state, child);
+ ec_parsed_link_child(state, child);
} else {
child = state;
}
free:
if (!is_root) {
- ec_parsed_del_child(state, child);
+ ec_parsed_unlink_child(state, child);
ec_parsed_free(child);
}
return ret;
dup_child = __ec_parsed_dup(child, ref, new_ref);
if (dup_child == NULL)
goto fail;
- ec_parsed_add_child(dup, dup_child);
+ ec_parsed_link_child(dup, dup_child);
}
return dup;
return NULL;
}
-struct ec_parsed *ec_parsed_dup(struct ec_parsed *parsed) //XXX const
+struct ec_parsed *ec_parsed_dup(const struct ec_parsed *parsed)
{
- struct ec_parsed *root, *dup_root, *dup = NULL;
+ const struct ec_parsed *root;
+ struct ec_parsed *dup_root, *dup = NULL;
root = ec_parsed_get_root(parsed);
dup_root = __ec_parsed_dup(root, parsed, &dup);
while (!TAILQ_EMPTY(&parsed->children)) {
child = TAILQ_FIRST(&parsed->children);
TAILQ_REMOVE(&parsed->children, child, next);
+ child->parent = NULL;
ec_parsed_free(child);
}
}
if (parsed == NULL)
return;
- // assert(parsed->parent == NULL); XXX
- // or
- // parsed = ec_parsed_get_root(parsed);
+ ec_assert_print(parsed->parent == NULL,
+ "parent not NULL in ec_parsed_free()");
ec_parsed_free_children(parsed);
ec_strvec_free(parsed->strvec);
__ec_parsed_dump(out, parsed, 0);
}
-void ec_parsed_add_child(struct ec_parsed *parsed,
+void ec_parsed_link_child(struct ec_parsed *parsed,
struct ec_parsed *child)
{
TAILQ_INSERT_TAIL(&parsed->children, child, next);
child->parent = parsed;
}
-// XXX we can remove the first arg ? parsed == child->parent ?
-void ec_parsed_del_child(struct ec_parsed *parsed, // XXX rename del in unlink?
+void ec_parsed_unlink_child(struct ec_parsed *parsed,
struct ec_parsed *child)
{
TAILQ_REMOVE(&parsed->children, child, next);
return parsed->node;
}
-void ec_parsed_del_last_child(struct ec_parsed *parsed) // rename in free
+void ec_parsed_del_last_child(struct ec_parsed *parsed)
{
struct ec_parsed *child;
child = ec_parsed_get_last_child(parsed);
- ec_parsed_del_child(parsed, child);
+ ec_parsed_unlink_child(parsed, child);
ec_parsed_free(child);
}
-struct ec_parsed *ec_parsed_get_root(struct ec_parsed *parsed)
+struct ec_parsed *__ec_parsed_get_root(struct ec_parsed *parsed)
{
if (parsed == NULL)
return NULL;
return parsed;
}
-struct ec_parsed *ec_parsed_get_parent(struct ec_parsed *parsed)
+struct ec_parsed *ec_parsed_get_parent(const struct ec_parsed *parsed)
{
if (parsed == NULL)
return NULL;