ethdev: forbid MTU set before device configure
[dpdk.git] / lib / ethdev / rte_ethdev.c
index c73d263..0d7dd68 100644 (file)
 static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
 struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
 
+/* public fast-path API */
+struct rte_eth_fp_ops rte_eth_fp_ops[RTE_MAX_ETHPORTS];
+
 /* spinlock for eth device callbacks */
 static rte_spinlock_t eth_dev_cb_lock = RTE_SPINLOCK_INITIALIZER;
 
-/* spinlock for add/remove rx callbacks */
+/* spinlock for add/remove Rx callbacks */
 static rte_spinlock_t eth_dev_rx_cb_lock = RTE_SPINLOCK_INITIALIZER;
 
-/* spinlock for add/remove tx callbacks */
+/* spinlock for add/remove Tx callbacks */
 static rte_spinlock_t eth_dev_tx_cb_lock = RTE_SPINLOCK_INITIALIZER;
 
 /* spinlock for shared data allocation */
@@ -118,7 +121,6 @@ static const struct {
        RTE_RX_OFFLOAD_BIT2STR(HEADER_SPLIT),
        RTE_RX_OFFLOAD_BIT2STR(VLAN_FILTER),
        RTE_RX_OFFLOAD_BIT2STR(VLAN_EXTEND),
-       RTE_RX_OFFLOAD_BIT2STR(JUMBO_FRAME),
        RTE_RX_OFFLOAD_BIT2STR(SCATTER),
        RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP),
        RTE_RX_OFFLOAD_BIT2STR(SECURITY),
@@ -165,6 +167,15 @@ static const struct {
 
 #undef RTE_TX_OFFLOAD_BIT2STR
 
+static const struct {
+       uint64_t offload;
+       const char *name;
+} rte_eth_dev_capa_names[] = {
+       {RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP, "RUNTIME_RX_QUEUE_SETUP"},
+       {RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP, "RUNTIME_TX_QUEUE_SETUP"},
+       {RTE_ETH_DEV_CAPA_RXQ_SHARE, "RXQ_SHARE"},
+};
+
 /**
  * The user application callback description.
  *
@@ -195,6 +206,17 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)
        char *cls_str = NULL;
        int str_size;
 
+       if (iter == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot initialize NULL iterator\n");
+               return -EINVAL;
+       }
+
+       if (devargs_str == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot initialize iterator from NULL device description string\n");
+               return -EINVAL;
+       }
+
        memset(iter, 0, sizeof(*iter));
        memset(&devargs, 0, sizeof(devargs));
 
@@ -203,7 +225,6 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)
         *   - 0000:08:00.0,representor=[1-3]
         *   - pci:0000:06:00.0,representor=[0,5]
         *   - class=eth,mac=00:11:22:33:44:55
-        * A new syntax is in development (not yet supported):
         *   - bus=X,paramX=x/class=Y,paramY=y/driver=Z,paramZ=z
         */
 
@@ -249,7 +270,9 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)
        }
 
        /* Convert bus args to new syntax for use with new API dev_iterate. */
-       if (strcmp(iter->bus->name, "vdev") == 0) {
+       if ((strcmp(iter->bus->name, "vdev") == 0) ||
+               (strcmp(iter->bus->name, "fslmc") == 0) ||
+               (strcmp(iter->bus->name, "dpaa_bus") == 0)) {
                bus_param_key = "name";
        } else if (strcmp(iter->bus->name, "pci") == 0) {
                bus_param_key = "addr";
@@ -289,6 +312,12 @@ error:
 uint16_t
 rte_eth_iterator_next(struct rte_dev_iterator *iter)
 {
+       if (iter == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get next device from NULL iterator\n");
+               return RTE_MAX_ETHPORTS;
+       }
+
        if (iter->cls == NULL) /* invalid ethdev iterator */
                return RTE_MAX_ETHPORTS;
 
@@ -318,6 +347,11 @@ rte_eth_iterator_next(struct rte_dev_iterator *iter)
 void
 rte_eth_iterator_cleanup(struct rte_dev_iterator *iter)
 {
+       if (iter == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot do clean up from NULL iterator\n");
+               return;
+       }
+
        if (iter->bus_str == NULL)
                return; /* nothing to free in pure class filter */
        free(RTE_CAST_FIELD(iter, bus_str, char *)); /* workaround const */
@@ -501,6 +535,7 @@ rte_eth_dev_allocate(const char *name)
        eth_dev = eth_dev_get(port_id);
        strlcpy(eth_dev->data->name, name, sizeof(eth_dev->data->name));
        eth_dev->data->port_id = port_id;
+       eth_dev->data->backer_port_id = RTE_MAX_ETHPORTS;
        eth_dev->data->mtu = RTE_ETHER_MTU;
        pthread_mutex_init(&eth_dev->data->flow_ops_mutex, NULL);
 
@@ -512,7 +547,7 @@ unlock:
 
 /*
  * Attach to a port already registered by the primary process, which
- * makes sure that the same device would have the same port id both
+ * makes sure that the same device would have the same port ID both
  * in the primary and secondary process.
  */
 struct rte_eth_dev *
@@ -555,6 +590,8 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)
                rte_eth_dev_callback_process(eth_dev,
                                RTE_ETH_EVENT_DESTROY, NULL);
 
+       eth_dev_fp_ops_reset(rte_eth_fp_ops + eth_dev->data->port_id);
+
        rte_spinlock_lock(&eth_dev_shared_data->ownership_lock);
 
        eth_dev->state = RTE_ETH_DEV_UNUSED;
@@ -565,7 +602,6 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)
        eth_dev->tx_pkt_burst = NULL;
        eth_dev->tx_pkt_prepare = NULL;
        eth_dev->rx_queue_count = NULL;
-       eth_dev->rx_descriptor_done = NULL;
        eth_dev->rx_descriptor_status = NULL;
        eth_dev->tx_descriptor_status = NULL;
        eth_dev->dev_ops = NULL;
@@ -618,6 +654,11 @@ rte_eth_find_next_owned_by(uint16_t port_id, const uint64_t owner_id)
 int
 rte_eth_dev_owner_new(uint64_t *owner_id)
 {
+       if (owner_id == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get new owner ID to NULL\n");
+               return -EINVAL;
+       }
+
        eth_dev_shared_data_prepare();
 
        rte_spinlock_lock(&eth_dev_shared_data->ownership_lock);
@@ -636,11 +677,18 @@ eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id,
        struct rte_eth_dev_owner *port_owner;
 
        if (port_id >= RTE_MAX_ETHPORTS || !eth_dev_is_allocated(ethdev)) {
-               RTE_ETHDEV_LOG(ERR, "Port id %"PRIu16" is not allocated\n",
+               RTE_ETHDEV_LOG(ERR, "Port ID %"PRIu16" is not allocated\n",
                        port_id);
                return -ENODEV;
        }
 
+       if (new_owner == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot set ethdev port %u owner from NULL owner\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        if (!eth_is_valid_owner_id(new_owner->id) &&
            !eth_is_valid_owner_id(old_owner_id)) {
                RTE_ETHDEV_LOG(ERR,
@@ -721,7 +769,7 @@ rte_eth_dev_owner_delete(const uint64_t owner_id)
                        owner_id);
        } else {
                RTE_ETHDEV_LOG(ERR,
-                              "Invalid owner id=%016"PRIx64"\n",
+                              "Invalid owner ID=%016"PRIx64"\n",
                               owner_id);
                ret = -EINVAL;
        }
@@ -734,23 +782,30 @@ rte_eth_dev_owner_delete(const uint64_t owner_id)
 int
 rte_eth_dev_owner_get(const uint16_t port_id, struct rte_eth_dev_owner *owner)
 {
-       int ret = 0;
-       struct rte_eth_dev *ethdev = &rte_eth_devices[port_id];
+       struct rte_eth_dev *ethdev;
 
-       eth_dev_shared_data_prepare();
+       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       ethdev = &rte_eth_devices[port_id];
 
-       rte_spinlock_lock(&eth_dev_shared_data->ownership_lock);
+       if (!eth_dev_is_allocated(ethdev)) {
+               RTE_ETHDEV_LOG(ERR, "Port ID %"PRIu16" is not allocated\n",
+                       port_id);
+               return -ENODEV;
+       }
 
-       if (port_id >= RTE_MAX_ETHPORTS || !eth_dev_is_allocated(ethdev)) {
-               RTE_ETHDEV_LOG(ERR, "Port id %"PRIu16" is not allocated\n",
+       if (owner == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u owner to NULL\n",
                        port_id);
-               ret = -ENODEV;
-       } else {
-               rte_memcpy(owner, &ethdev->data->owner, sizeof(*owner));
+               return -EINVAL;
        }
 
+       eth_dev_shared_data_prepare();
+
+       rte_spinlock_lock(&eth_dev_shared_data->ownership_lock);
+       rte_memcpy(owner, &ethdev->data->owner, sizeof(*owner));
        rte_spinlock_unlock(&eth_dev_shared_data->ownership_lock);
-       return ret;
+
+       return 0;
 }
 
 int
@@ -800,7 +855,8 @@ rte_eth_dev_get_name_by_port(uint16_t port_id, char *name)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        if (name == NULL) {
-               RTE_ETHDEV_LOG(ERR, "Null pointer is specified\n");
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u name to NULL\n",
+                       port_id);
                return -EINVAL;
        }
 
@@ -817,7 +873,13 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id)
        uint16_t pid;
 
        if (name == NULL) {
-               RTE_ETHDEV_LOG(ERR, "Null pointer is specified\n");
+               RTE_ETHDEV_LOG(ERR, "Cannot get port ID from NULL name");
+               return -EINVAL;
+       }
+
+       if (port_id == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get port ID to NULL for %s\n", name);
                return -EINVAL;
        }
 
@@ -840,48 +902,54 @@ eth_err(uint16_t port_id, int ret)
        return ret;
 }
 
+static void
+eth_dev_rxq_release(struct rte_eth_dev *dev, uint16_t qid)
+{
+       void **rxq = dev->data->rx_queues;
+
+       if (rxq[qid] == NULL)
+               return;
+
+       if (dev->dev_ops->rx_queue_release != NULL)
+               (*dev->dev_ops->rx_queue_release)(dev, qid);
+       rxq[qid] = NULL;
+}
+
+static void
+eth_dev_txq_release(struct rte_eth_dev *dev, uint16_t qid)
+{
+       void **txq = dev->data->tx_queues;
+
+       if (txq[qid] == NULL)
+               return;
+
+       if (dev->dev_ops->tx_queue_release != NULL)
+               (*dev->dev_ops->tx_queue_release)(dev, qid);
+       txq[qid] = NULL;
+}
+
 static int
 eth_dev_rx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
 {
        uint16_t old_nb_queues = dev->data->nb_rx_queues;
-       void **rxq;
        unsigned i;
 
        if (dev->data->rx_queues == NULL && nb_queues != 0) { /* first time configuration */
                dev->data->rx_queues = rte_zmalloc("ethdev->rx_queues",
-                               sizeof(dev->data->rx_queues[0]) * nb_queues,
+                               sizeof(dev->data->rx_queues[0]) *
+                               RTE_MAX_QUEUES_PER_PORT,
                                RTE_CACHE_LINE_SIZE);
                if (dev->data->rx_queues == NULL) {
                        dev->data->nb_rx_queues = 0;
                        return -(ENOMEM);
                }
        } else if (dev->data->rx_queues != NULL && nb_queues != 0) { /* re-configure */
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, -ENOTSUP);
-
-               rxq = dev->data->rx_queues;
-
                for (i = nb_queues; i < old_nb_queues; i++)
-                       (*dev->dev_ops->rx_queue_release)(rxq[i]);
-               rxq = rte_realloc(rxq, sizeof(rxq[0]) * nb_queues,
-                               RTE_CACHE_LINE_SIZE);
-               if (rxq == NULL)
-                       return -(ENOMEM);
-               if (nb_queues > old_nb_queues) {
-                       uint16_t new_qs = nb_queues - old_nb_queues;
-
-                       memset(rxq + old_nb_queues, 0,
-                               sizeof(rxq[0]) * new_qs);
-               }
-
-               dev->data->rx_queues = rxq;
+                       eth_dev_rxq_release(dev, i);
 
        } else if (dev->data->rx_queues != NULL && nb_queues == 0) {
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, -ENOTSUP);
-
-               rxq = dev->data->rx_queues;
-
                for (i = nb_queues; i < old_nb_queues; i++)
-                       (*dev->dev_ops->rx_queue_release)(rxq[i]);
+                       eth_dev_rxq_release(dev, i);
 
                rte_free(dev->data->rx_queues);
                dev->data->rx_queues = NULL;
@@ -945,8 +1013,8 @@ rte_eth_dev_rx_queue_start(uint16_t port_id, uint16_t rx_queue_id)
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        if (!dev->data->dev_started) {
                RTE_ETHDEV_LOG(ERR,
                        "Port %u must be started before start any queue\n",
@@ -974,9 +1042,7 @@ rte_eth_dev_rx_queue_start(uint16_t port_id, uint16_t rx_queue_id)
                return 0;
        }
 
-       return eth_err(port_id, dev->dev_ops->rx_queue_start(dev,
-                                                            rx_queue_id));
-
+       return eth_err(port_id, dev->dev_ops->rx_queue_start(dev, rx_queue_id));
 }
 
 int
@@ -986,7 +1052,6 @@ rte_eth_dev_rx_queue_stop(uint16_t port_id, uint16_t rx_queue_id)
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        ret = eth_dev_validate_rx_queue(dev, rx_queue_id);
@@ -1010,7 +1075,6 @@ rte_eth_dev_rx_queue_stop(uint16_t port_id, uint16_t rx_queue_id)
        }
 
        return eth_err(port_id, dev->dev_ops->rx_queue_stop(dev, rx_queue_id));
-
 }
 
 int
@@ -1020,8 +1084,8 @@ rte_eth_dev_tx_queue_start(uint16_t port_id, uint16_t tx_queue_id)
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        if (!dev->data->dev_started) {
                RTE_ETHDEV_LOG(ERR,
                        "Port %u must be started before start any queue\n",
@@ -1059,7 +1123,6 @@ rte_eth_dev_tx_queue_stop(uint16_t port_id, uint16_t tx_queue_id)
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        ret = eth_dev_validate_tx_queue(dev, tx_queue_id);
@@ -1083,51 +1146,30 @@ rte_eth_dev_tx_queue_stop(uint16_t port_id, uint16_t tx_queue_id)
        }
 
        return eth_err(port_id, dev->dev_ops->tx_queue_stop(dev, tx_queue_id));
-
 }
 
 static int
 eth_dev_tx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
 {
        uint16_t old_nb_queues = dev->data->nb_tx_queues;
-       void **txq;
        unsigned i;
 
        if (dev->data->tx_queues == NULL && nb_queues != 0) { /* first time configuration */
                dev->data->tx_queues = rte_zmalloc("ethdev->tx_queues",
-                                                  sizeof(dev->data->tx_queues[0]) * nb_queues,
-                                                  RTE_CACHE_LINE_SIZE);
+                               sizeof(dev->data->tx_queues[0]) *
+                               RTE_MAX_QUEUES_PER_PORT,
+                               RTE_CACHE_LINE_SIZE);
                if (dev->data->tx_queues == NULL) {
                        dev->data->nb_tx_queues = 0;
                        return -(ENOMEM);
                }
        } else if (dev->data->tx_queues != NULL && nb_queues != 0) { /* re-configure */
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release, -ENOTSUP);
-
-               txq = dev->data->tx_queues;
-
                for (i = nb_queues; i < old_nb_queues; i++)
-                       (*dev->dev_ops->tx_queue_release)(txq[i]);
-               txq = rte_realloc(txq, sizeof(txq[0]) * nb_queues,
-                                 RTE_CACHE_LINE_SIZE);
-               if (txq == NULL)
-                       return -ENOMEM;
-               if (nb_queues > old_nb_queues) {
-                       uint16_t new_qs = nb_queues - old_nb_queues;
-
-                       memset(txq + old_nb_queues, 0,
-                              sizeof(txq[0]) * new_qs);
-               }
-
-               dev->data->tx_queues = txq;
+                       eth_dev_txq_release(dev, i);
 
        } else if (dev->data->tx_queues != NULL && nb_queues == 0) {
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release, -ENOTSUP);
-
-               txq = dev->data->tx_queues;
-
                for (i = nb_queues; i < old_nb_queues; i++)
-                       (*dev->dev_ops->tx_queue_release)(txq[i]);
+                       eth_dev_txq_release(dev, i);
 
                rte_free(dev->data->tx_queues);
                dev->data->tx_queues = NULL;
@@ -1203,6 +1245,22 @@ rte_eth_dev_tx_offload_name(uint64_t offload)
        return name;
 }
 
+const char *
+rte_eth_dev_capability_name(uint64_t capability)
+{
+       const char *name = "UNKNOWN";
+       unsigned int i;
+
+       for (i = 0; i < RTE_DIM(rte_eth_dev_capa_names); ++i) {
+               if (capability == rte_eth_dev_capa_names[i].offload) {
+                       name = rte_eth_dev_capa_names[i].name;
+                       break;
+               }
+       }
+
+       return name;
+}
+
 static inline int
 eth_dev_check_lro_pkt_size(uint16_t port_id, uint32_t config_size,
                   uint32_t max_rx_pkt_len, uint32_t dev_info_size)
@@ -1232,14 +1290,14 @@ eth_dev_check_lro_pkt_size(uint16_t port_id, uint32_t config_size,
 
 /*
  * Validate offloads that are requested through rte_eth_dev_configure against
- * the offloads successfully set by the ethernet device.
+ * the offloads successfully set by the Ethernet device.
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
  * @param req_offloads
  *   The offloads that have been requested through `rte_eth_dev_configure`.
  * @param set_offloads
- *   The offloads successfully set by the ethernet device.
+ *   The offloads successfully set by the Ethernet device.
  * @param offload_type
  *   The offload type i.e. Rx/Tx string.
  * @param offload_name
@@ -1260,7 +1318,7 @@ eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads,
 
        while (offloads_diff != 0) {
                /* Check if any offload is requested but not enabled. */
-               offload = 1ULL << __builtin_ctzll(offloads_diff);
+               offload = RTE_BIT64(__builtin_ctzll(offloads_diff));
                if (offload & req_offloads) {
                        RTE_ETHDEV_LOG(ERR,
                                "Port %u failed to enable %s offload %s\n",
@@ -1281,6 +1339,60 @@ eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads,
        return ret;
 }
 
+static uint32_t
+eth_dev_get_overhead_len(uint32_t max_rx_pktlen, uint16_t max_mtu)
+{
+       uint32_t overhead_len;
+
+       if (max_mtu != UINT16_MAX && max_rx_pktlen > max_mtu)
+               overhead_len = max_rx_pktlen - max_mtu;
+       else
+               overhead_len = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
+
+       return overhead_len;
+}
+
+/* rte_eth_dev_info_get() should be called prior to this function */
+static int
+eth_dev_validate_mtu(uint16_t port_id, struct rte_eth_dev_info *dev_info,
+               uint16_t mtu)
+{
+       uint32_t overhead_len;
+       uint32_t frame_size;
+
+       if (mtu < dev_info->min_mtu) {
+               RTE_ETHDEV_LOG(ERR,
+                       "MTU (%u) < device min MTU (%u) for port_id %u\n",
+                       mtu, dev_info->min_mtu, port_id);
+               return -EINVAL;
+       }
+       if (mtu > dev_info->max_mtu) {
+               RTE_ETHDEV_LOG(ERR,
+                       "MTU (%u) > device max MTU (%u) for port_id %u\n",
+                       mtu, dev_info->max_mtu, port_id);
+               return -EINVAL;
+       }
+
+       overhead_len = eth_dev_get_overhead_len(dev_info->max_rx_pktlen,
+                       dev_info->max_mtu);
+       frame_size = mtu + overhead_len;
+       if (frame_size < RTE_ETHER_MIN_LEN) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Frame size (%u) < min frame size (%u) for port_id %u\n",
+                       frame_size, RTE_ETHER_MIN_LEN, port_id);
+               return -EINVAL;
+       }
+
+       if (frame_size > dev_info->max_rx_pktlen) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Frame size (%u) > device max frame size (%u) for port_id %u\n",
+                       frame_size, dev_info->max_rx_pktlen, port_id);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
 int
 rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                      const struct rte_eth_conf *dev_conf)
@@ -1288,15 +1400,20 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
        struct rte_eth_dev *dev;
        struct rte_eth_dev_info dev_info;
        struct rte_eth_conf orig_conf;
-       uint16_t overhead_len;
        int diag;
        int ret;
        uint16_t old_mtu;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
+       if (dev_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot configure ethdev port %u from NULL config\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP);
 
        if (dev->data->dev_started) {
@@ -1306,6 +1423,13 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                return -EBUSY;
        }
 
+       /*
+        * Ensure that "dev_configured" is always 0 each time prepare to do
+        * dev_configure() to avoid any non-anticipated behaviour.
+        * And set to 1 when dev_configure() is executed successfully.
+        */
+       dev->data->dev_configured = 0;
+
         /* Store original config, as rollback required on failure */
        memcpy(&orig_conf, &dev->data->dev_conf, sizeof(dev->data->dev_conf));
 
@@ -1324,13 +1448,6 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
        if (ret != 0)
                goto rollback;
 
-       /* Get the real Ethernet overhead length */
-       if (dev_info.max_mtu != UINT16_MAX &&
-           dev_info.max_rx_pktlen > dev_info.max_mtu)
-               overhead_len = dev_info.max_rx_pktlen - dev_info.max_mtu;
-       else
-               overhead_len = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
-
        /* If number of queues specified by application for both Rx and Tx is
         * zero, use driver preferred values. This cannot be done individually
         * as it is valid for either Tx or Rx (but not both) to be zero.
@@ -1348,7 +1465,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
 
        if (nb_rx_q > RTE_MAX_QUEUES_PER_PORT) {
                RTE_ETHDEV_LOG(ERR,
-                       "Number of RX queues requested (%u) is greater than max supported(%d)\n",
+                       "Number of Rx queues requested (%u) is greater than max supported(%d)\n",
                        nb_rx_q, RTE_MAX_QUEUES_PER_PORT);
                ret = -EINVAL;
                goto rollback;
@@ -1356,15 +1473,15 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
 
        if (nb_tx_q > RTE_MAX_QUEUES_PER_PORT) {
                RTE_ETHDEV_LOG(ERR,
-                       "Number of TX queues requested (%u) is greater than max supported(%d)\n",
+                       "Number of Tx queues requested (%u) is greater than max supported(%d)\n",
                        nb_tx_q, RTE_MAX_QUEUES_PER_PORT);
                ret = -EINVAL;
                goto rollback;
        }
 
        /*
-        * Check that the numbers of RX and TX queues are not greater
-        * than the maximum number of RX and TX queues supported by the
+        * Check that the numbers of Rx and Tx queues are not greater
+        * than the maximum number of Rx and Tx queues supported by the
         * configured device.
         */
        if (nb_rx_q > dev_info.max_rx_queues) {
@@ -1397,50 +1514,32 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                goto rollback;
        }
 
-       /*
-        * If jumbo frames are enabled, check that the maximum RX packet
-        * length is supported by the configured device.
-        */
-       if (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
-               if (dev_conf->rxmode.max_rx_pkt_len > dev_info.max_rx_pktlen) {
-                       RTE_ETHDEV_LOG(ERR,
-                               "Ethdev port_id=%u max_rx_pkt_len %u > max valid value %u\n",
-                               port_id, dev_conf->rxmode.max_rx_pkt_len,
-                               dev_info.max_rx_pktlen);
-                       ret = -EINVAL;
-                       goto rollback;
-               } else if (dev_conf->rxmode.max_rx_pkt_len < RTE_ETHER_MIN_LEN) {
-                       RTE_ETHDEV_LOG(ERR,
-                               "Ethdev port_id=%u max_rx_pkt_len %u < min valid value %u\n",
-                               port_id, dev_conf->rxmode.max_rx_pkt_len,
-                               (unsigned int)RTE_ETHER_MIN_LEN);
-                       ret = -EINVAL;
-                       goto rollback;
-               }
+       if (dev_conf->rxmode.mtu == 0)
+               dev->data->dev_conf.rxmode.mtu = RTE_ETHER_MTU;
 
-               /* Scale the MTU size to adapt max_rx_pkt_len */
-               dev->data->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len -
-                               overhead_len;
-       } else {
-               uint16_t pktlen = dev_conf->rxmode.max_rx_pkt_len;
-               if (pktlen < RTE_ETHER_MIN_MTU + overhead_len ||
-                   pktlen > RTE_ETHER_MTU + overhead_len)
-                       /* Use default value */
-                       dev->data->dev_conf.rxmode.max_rx_pkt_len =
-                                               RTE_ETHER_MTU + overhead_len;
-       }
+       ret = eth_dev_validate_mtu(port_id, &dev_info,
+                       dev->data->dev_conf.rxmode.mtu);
+       if (ret != 0)
+               goto rollback;
+
+       dev->data->mtu = dev->data->dev_conf.rxmode.mtu;
 
        /*
         * If LRO is enabled, check that the maximum aggregated packet
         * size is supported by the configured device.
         */
        if (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_TCP_LRO) {
+               uint32_t max_rx_pktlen;
+               uint32_t overhead_len;
+
+               overhead_len = eth_dev_get_overhead_len(dev_info.max_rx_pktlen,
+                               dev_info.max_mtu);
+               max_rx_pktlen = dev->data->dev_conf.rxmode.mtu + overhead_len;
                if (dev_conf->rxmode.max_lro_pkt_size == 0)
-                       dev->data->dev_conf.rxmode.max_lro_pkt_size =
-                               dev->data->dev_conf.rxmode.max_rx_pkt_len;
+                       dev->data->dev_conf.rxmode.max_lro_pkt_size = max_rx_pktlen;
                ret = eth_dev_check_lro_pkt_size(port_id,
                                dev->data->dev_conf.rxmode.max_lro_pkt_size,
-                               dev->data->dev_conf.rxmode.max_rx_pkt_len,
+                               max_rx_pktlen,
                                dev_info.max_lro_pkt_size);
                if (ret != 0)
                        goto rollback;
@@ -1497,7 +1596,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
        }
 
        /*
-        * Setup new number of RX/TX queues and reconfigure device.
+        * Setup new number of Rx/Tx queues and reconfigure device.
         */
        diag = eth_dev_rx_queue_config(dev, nb_rx_q);
        if (diag != 0) {
@@ -1555,6 +1654,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                goto reset_queues;
        }
 
+       dev->data->dev_configured = 1;
        rte_ethdev_trace_configure(port_id, nb_rx_q, nb_tx_q, dev_conf, 0);
        return 0;
 reset_queues:
@@ -1612,7 +1712,7 @@ eth_dev_mac_restore(struct rte_eth_dev *dev,
                        pool_mask = dev->data->mac_pool_sel[i];
 
                        do {
-                               if (pool_mask & 1ULL)
+                               if (pool_mask & UINT64_C(1))
                                        (*dev->dev_ops->mac_addr_add)(dev,
                                                addr, i, pool);
                                pool_mask >>= 1;
@@ -1697,11 +1797,17 @@ rte_eth_dev_start(uint16_t port_id)
        int ret, ret_stop;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_start, -ENOTSUP);
 
+       if (dev->data->dev_configured == 0) {
+               RTE_ETHDEV_LOG(INFO,
+                       "Device with port_id=%"PRIu16" is not configured.\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        if (dev->data->dev_started != 0) {
                RTE_ETHDEV_LOG(INFO,
                        "Device with port_id=%"PRIu16" already started\n",
@@ -1743,6 +1849,9 @@ rte_eth_dev_start(uint16_t port_id)
                (*dev->dev_ops->link_update)(dev, 0);
        }
 
+       /* expose selection of PMD fast-path functions */
+       eth_dev_fp_ops_setup(rte_eth_fp_ops + port_id, dev);
+
        rte_ethdev_trace_start(port_id);
        return 0;
 }
@@ -1765,6 +1874,9 @@ rte_eth_dev_stop(uint16_t port_id)
                return 0;
        }
 
+       /* point fast-path functions to dummy ones */
+       eth_dev_fp_ops_reset(rte_eth_fp_ops + port_id);
+
        dev->data->dev_started = 0;
        ret = (*dev->dev_ops->dev_stop)(dev);
        rte_ethdev_trace_stop(port_id, ret);
@@ -1778,7 +1890,6 @@ rte_eth_dev_set_link_up(uint16_t port_id)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_set_link_up, -ENOTSUP);
@@ -1791,7 +1902,6 @@ rte_eth_dev_set_link_down(uint16_t port_id)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_set_link_down, -ENOTSUP);
@@ -1808,6 +1918,12 @@ rte_eth_dev_close(uint16_t port_id)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
+       if (dev->data->dev_started) {
+               RTE_ETHDEV_LOG(ERR, "Cannot close started device (port %u)\n",
+                              port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_close, -ENOTSUP);
        *lasterr = (*dev->dev_ops->dev_close)(dev);
        if (*lasterr != 0)
@@ -1848,7 +1964,6 @@ rte_eth_dev_is_removed(uint16_t port_id)
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
-
        dev = &rte_eth_devices[port_id];
 
        if (dev->state == RTE_ETH_DEV_REMOVED)
@@ -1885,7 +2000,7 @@ rte_eth_rx_queue_check_split(const struct rte_eth_rxseg_split *rx_seg,
         * for each segment specified in extended configuration.
         */
        mp_first = rx_seg[0].mp;
-       offset_mask = (1u << seg_capa->offset_align_log2) - 1;
+       offset_mask = RTE_BIT32(seg_capa->offset_align_log2) - 1;
        for (seg_idx = 0; seg_idx < n_seg; seg_idx++) {
                struct rte_mempool *mpl = rx_seg[seg_idx].mp;
                uint32_t length = rx_seg[seg_idx].length;
@@ -1946,13 +2061,12 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
        struct rte_eth_dev *dev;
        struct rte_eth_dev_info dev_info;
        struct rte_eth_rxconf local_conf;
-       void **rxq;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        if (rx_queue_id >= dev->data->nb_rx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", rx_queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", rx_queue_id);
                return -EINVAL;
        }
 
@@ -2050,13 +2164,7 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
                        RTE_ETH_QUEUE_STATE_STOPPED))
                return -EBUSY;
 
-       rxq = dev->data->rx_queues;
-       if (rxq[rx_queue_id]) {
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release,
-                                       -ENOTSUP);
-               (*dev->dev_ops->rx_queue_release)(rxq[rx_queue_id]);
-               rxq[rx_queue_id] = NULL;
-       }
+       eth_dev_rxq_release(dev, rx_queue_id);
 
        if (rx_conf == NULL)
                rx_conf = &dev_info.default_rxconf;
@@ -2092,17 +2200,32 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
                return -EINVAL;
        }
 
+       if (local_conf.share_group > 0 &&
+           (dev_info.dev_capa & RTE_ETH_DEV_CAPA_RXQ_SHARE) == 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Ethdev port_id=%d rx_queue_id=%d, enabled share_group=%hu while device doesn't support Rx queue share\n",
+                       port_id, rx_queue_id, local_conf.share_group);
+               return -EINVAL;
+       }
+
        /*
         * If LRO is enabled, check that the maximum aggregated packet
         * size is supported by the configured device.
         */
+       /* Get the real Ethernet overhead length */
        if (local_conf.offloads & DEV_RX_OFFLOAD_TCP_LRO) {
+               uint32_t overhead_len;
+               uint32_t max_rx_pktlen;
+               int ret;
+
+               overhead_len = eth_dev_get_overhead_len(dev_info.max_rx_pktlen,
+                               dev_info.max_mtu);
+               max_rx_pktlen = dev->data->mtu + overhead_len;
                if (dev->data->dev_conf.rxmode.max_lro_pkt_size == 0)
-                       dev->data->dev_conf.rxmode.max_lro_pkt_size =
-                               dev->data->dev_conf.rxmode.max_rx_pkt_len;
-               int ret = eth_dev_check_lro_pkt_size(port_id,
+                       dev->data->dev_conf.rxmode.max_lro_pkt_size = max_rx_pktlen;
+               ret = eth_dev_check_lro_pkt_size(port_id,
                                dev->data->dev_conf.rxmode.max_lro_pkt_size,
-                               dev->data->dev_conf.rxmode.max_rx_pkt_len,
+                               max_rx_pktlen,
                                dev_info.max_lro_pkt_size);
                if (ret != 0)
                        return ret;
@@ -2129,17 +2252,24 @@ rte_eth_rx_hairpin_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
        int ret;
        struct rte_eth_dev *dev;
        struct rte_eth_hairpin_cap cap;
-       void **rxq;
        int i;
        int count;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        if (rx_queue_id >= dev->data->nb_rx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", rx_queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", rx_queue_id);
+               return -EINVAL;
+       }
+
+       if (conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot setup ethdev port %u Rx hairpin queue from NULL config\n",
+                       port_id);
                return -EINVAL;
        }
+
        ret = rte_eth_dev_hairpin_capability_get(port_id, &cap);
        if (ret != 0)
                return ret;
@@ -2178,13 +2308,7 @@ rte_eth_rx_hairpin_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
        }
        if (dev->data->dev_started)
                return -EBUSY;
-       rxq = dev->data->rx_queues;
-       if (rxq[rx_queue_id] != NULL) {
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release,
-                                       -ENOTSUP);
-               (*dev->dev_ops->rx_queue_release)(rxq[rx_queue_id]);
-               rxq[rx_queue_id] = NULL;
-       }
+       eth_dev_rxq_release(dev, rx_queue_id);
        ret = (*dev->dev_ops->rx_hairpin_queue_setup)(dev, rx_queue_id,
                                                      nb_rx_desc, conf);
        if (ret == 0)
@@ -2201,14 +2325,13 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
        struct rte_eth_dev *dev;
        struct rte_eth_dev_info dev_info;
        struct rte_eth_txconf local_conf;
-       void **txq;
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        if (tx_queue_id >= dev->data->nb_tx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", tx_queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Tx queue_id=%u\n", tx_queue_id);
                return -EINVAL;
        }
 
@@ -2246,13 +2369,7 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
                        RTE_ETH_QUEUE_STATE_STOPPED))
                return -EBUSY;
 
-       txq = dev->data->tx_queues;
-       if (txq[tx_queue_id]) {
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release,
-                                       -ENOTSUP);
-               (*dev->dev_ops->tx_queue_release)(txq[tx_queue_id]);
-               txq[tx_queue_id] = NULL;
-       }
+       eth_dev_txq_release(dev, tx_queue_id);
 
        if (tx_conf == NULL)
                tx_conf = &dev_info.default_txconf;
@@ -2300,17 +2417,25 @@ rte_eth_tx_hairpin_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
 {
        struct rte_eth_dev *dev;
        struct rte_eth_hairpin_cap cap;
-       void **txq;
        int i;
        int count;
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
        if (tx_queue_id >= dev->data->nb_tx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", tx_queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Tx queue_id=%u\n", tx_queue_id);
+               return -EINVAL;
+       }
+
+       if (conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot setup ethdev port %u Tx hairpin queue from NULL config\n",
+                       port_id);
                return -EINVAL;
        }
+
        ret = rte_eth_dev_hairpin_capability_get(port_id, &cap);
        if (ret != 0)
                return ret;
@@ -2349,13 +2474,7 @@ rte_eth_tx_hairpin_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
        }
        if (dev->data->dev_started)
                return -EBUSY;
-       txq = dev->data->tx_queues;
-       if (txq[tx_queue_id] != NULL) {
-               RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release,
-                                       -ENOTSUP);
-               (*dev->dev_ops->tx_queue_release)(txq[tx_queue_id]);
-               txq[tx_queue_id] = NULL;
-       }
+       eth_dev_txq_release(dev, tx_queue_id);
        ret = (*dev->dev_ops->tx_hairpin_queue_setup)
                (dev, tx_queue_id, nb_tx_desc, conf);
        if (ret == 0)
@@ -2372,6 +2491,7 @@ rte_eth_hairpin_bind(uint16_t tx_port, uint16_t rx_port)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(tx_port, -ENODEV);
        dev = &rte_eth_devices[tx_port];
+
        if (dev->data->dev_started == 0) {
                RTE_ETHDEV_LOG(ERR, "Tx port %d is not started\n", tx_port);
                return -EBUSY;
@@ -2395,6 +2515,7 @@ rte_eth_hairpin_unbind(uint16_t tx_port, uint16_t rx_port)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(tx_port, -ENODEV);
        dev = &rte_eth_devices[tx_port];
+
        if (dev->data->dev_started == 0) {
                RTE_ETHDEV_LOG(ERR, "Tx port %d is already stopped\n", tx_port);
                return -EBUSY;
@@ -2417,11 +2538,23 @@ rte_eth_hairpin_get_peer_ports(uint16_t port_id, uint16_t *peer_ports,
        struct rte_eth_dev *dev;
        int ret;
 
-       if (peer_ports == NULL || len == 0)
-               return -EINVAL;
-
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (peer_ports == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u hairpin peer ports to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
+       if (len == 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u hairpin peer ports to array with zero size\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->hairpin_get_peer_ports,
                                -ENOTSUP);
 
@@ -2455,6 +2588,12 @@ int
 rte_eth_tx_buffer_set_err_callback(struct rte_eth_dev_tx_buffer *buffer,
                buffer_tx_error_fn cbfn, void *userdata)
 {
+       if (buffer == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot set Tx buffer error callback to NULL buffer\n");
+               return -EINVAL;
+       }
+
        buffer->error_callback = cbfn;
        buffer->error_userdata = userdata;
        return 0;
@@ -2465,8 +2604,10 @@ rte_eth_tx_buffer_init(struct rte_eth_dev_tx_buffer *buffer, uint16_t size)
 {
        int ret = 0;
 
-       if (buffer == NULL)
+       if (buffer == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot initialize NULL buffer\n");
                return -EINVAL;
+       }
 
        buffer->size = size;
        if (buffer->error_callback == NULL) {
@@ -2480,11 +2621,12 @@ rte_eth_tx_buffer_init(struct rte_eth_dev_tx_buffer *buffer, uint16_t size)
 int
 rte_eth_tx_done_cleanup(uint16_t port_id, uint16_t queue_id, uint32_t free_cnt)
 {
-       struct rte_eth_dev *dev = &rte_eth_devices[port_id];
+       struct rte_eth_dev *dev;
        int ret;
 
-       /* Validate Input Data. Bail if not valid or not supported. */
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_done_cleanup, -ENOTSUP);
 
        /* Call driver to free pending mbufs. */
@@ -2541,8 +2683,8 @@ rte_eth_promiscuous_get(uint16_t port_id)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        return dev->data->promiscuous;
 }
 
@@ -2592,8 +2734,8 @@ rte_eth_allmulticast_get(uint16_t port_id)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        return dev->data->all_multicast;
 }
 
@@ -2605,8 +2747,13 @@ rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
-       if (dev->data->dev_conf.intr_conf.lsc &&
-           dev->data->dev_started)
+       if (eth_link == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u link to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
+       if (dev->data->dev_conf.intr_conf.lsc && dev->data->dev_started)
                rte_eth_linkstatus_get(dev, eth_link);
        else {
                RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->link_update, -ENOTSUP);
@@ -2625,8 +2772,13 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
-       if (dev->data->dev_conf.intr_conf.lsc &&
-           dev->data->dev_started)
+       if (eth_link == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u link to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
+       if (dev->data->dev_conf.intr_conf.lsc && dev->data->dev_started)
                rte_eth_linkstatus_get(dev, eth_link);
        else {
                RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->link_update, -ENOTSUP);
@@ -2663,6 +2815,22 @@ rte_eth_link_speed_to_str(uint32_t link_speed)
 int
 rte_eth_link_to_str(char *str, size_t len, const struct rte_eth_link *eth_link)
 {
+       if (str == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot convert link to NULL string\n");
+               return -EINVAL;
+       }
+
+       if (len == 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot convert link to string with zero size\n");
+               return -EINVAL;
+       }
+
+       if (eth_link == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot convert to string from NULL link\n");
+               return -EINVAL;
+       }
+
        if (eth_link->link_status == ETH_LINK_DOWN)
                return snprintf(str, len, "Link down");
        else
@@ -2680,8 +2848,14 @@ rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
+       if (stats == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u stats to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        memset(stats, 0, sizeof(*stats));
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->stats_get, -ENOTSUP);
@@ -2734,12 +2908,6 @@ eth_dev_get_xstats_count(uint16_t port_id)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
-       if (dev->dev_ops->xstats_get_names_by_id != NULL) {
-               count = (*dev->dev_ops->xstats_get_names_by_id)(dev, NULL,
-                               NULL, 0);
-               if (count < 0)
-                       return eth_err(port_id, count);
-       }
        if (dev->dev_ops->xstats_get_names != NULL) {
                count = (*dev->dev_ops->xstats_get_names)(dev, NULL, 0);
                if (count < 0)
@@ -2761,13 +2929,17 @@ rte_eth_xstats_get_id_by_name(uint16_t port_id, const char *xstat_name,
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
-       if (!id) {
-               RTE_ETHDEV_LOG(ERR, "Id pointer is NULL\n");
+       if (xstat_name == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u xstats ID from NULL xstat name\n",
+                       port_id);
                return -ENOMEM;
        }
 
-       if (!xstat_name) {
-               RTE_ETHDEV_LOG(ERR, "xstat_name pointer is NULL\n");
+       if (id == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u xstats ID to NULL\n",
+                       port_id);
                return -ENOMEM;
        }
 
@@ -2893,7 +3065,7 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,
 
                if (no_basic_stat_requested)
                        return (*dev->dev_ops->xstats_get_names_by_id)(dev,
-                                       xstats_names, ids_copy, size);
+                                       ids_copy, xstats_names, size);
        }
 
        /* Retrieve all stats */
@@ -3055,12 +3227,13 @@ rte_eth_xstats_get_by_id(uint16_t port_id, const uint64_t *ids,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
        ret = eth_dev_get_xstats_count(port_id);
        if (ret < 0)
                return ret;
        expected_entries = (uint16_t)ret;
        struct rte_eth_xstat xstats[expected_entries];
-       dev = &rte_eth_devices[port_id];
        basic_count = eth_dev_get_xstats_basic_count(dev);
 
        /* Return max number of stats if no ids given */
@@ -3144,7 +3317,6 @@ rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        nb_rxqs = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);
@@ -3210,11 +3382,8 @@ eth_dev_set_queue_stats_mapping(uint16_t port_id, uint16_t queue_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
-       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_stats_mapping_set, -ENOTSUP);
-
        if (is_rx && (queue_id >= dev->data->nb_rx_queues))
                return -EINVAL;
 
@@ -3224,11 +3393,10 @@ eth_dev_set_queue_stats_mapping(uint16_t port_id, uint16_t queue_id,
        if (stat_idx >= RTE_ETHDEV_QUEUE_STAT_CNTRS)
                return -EINVAL;
 
-       return (*dev->dev_ops->queue_stats_mapping_set)
-                       (dev, queue_id, stat_idx, is_rx);
+       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_stats_mapping_set, -ENOTSUP);
+       return (*dev->dev_ops->queue_stats_mapping_set) (dev, queue_id, stat_idx, is_rx);
 }
 
-
 int
 rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id, uint16_t tx_queue_id,
                uint8_t stat_idx)
@@ -3238,7 +3406,6 @@ rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id, uint16_t tx_queue_id,
                                                stat_idx, STAT_QMAP_TX));
 }
 
-
 int
 rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id, uint16_t rx_queue_id,
                uint8_t stat_idx)
@@ -3256,6 +3423,13 @@ rte_eth_dev_fw_version_get(uint16_t port_id, char *fw_version, size_t fw_size)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
+       if (fw_version == NULL && fw_size > 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u FW version to NULL when string size is non zero\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fw_version_get, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->fw_version_get)(dev,
                                                        fw_version, fw_size));
@@ -3274,6 +3448,15 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info)
        };
        int diag;
 
+       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (dev_info == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u info to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        /*
         * Init dev_info before port_id check since caller does not have
         * return status and does not know if get is successful or not.
@@ -3281,13 +3464,11 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info)
        memset(dev_info, 0, sizeof(struct rte_eth_dev_info));
        dev_info->switch_info.domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;
 
-       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-       dev = &rte_eth_devices[port_id];
-
        dev_info->rx_desc_lim = lim;
        dev_info->tx_desc_lim = lim;
        dev_info->device = dev->device;
-       dev_info->min_mtu = RTE_ETHER_MIN_MTU;
+       dev_info->min_mtu = RTE_ETHER_MIN_LEN - RTE_ETHER_HDR_LEN -
+               RTE_ETHER_CRC_LEN;
        dev_info->max_mtu = UINT16_MAX;
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
@@ -3313,6 +3494,26 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info)
        return 0;
 }
 
+int
+rte_eth_dev_conf_get(uint16_t port_id, struct rte_eth_conf *dev_conf)
+{
+       struct rte_eth_dev *dev;
+
+       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (dev_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u configuration to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
+       memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf));
+
+       return 0;
+}
+
 int
 rte_eth_dev_get_supported_ptypes(uint16_t port_id, uint32_t ptype_mask,
                                 uint32_t *ptypes, int num)
@@ -3323,6 +3524,14 @@ rte_eth_dev_get_supported_ptypes(uint16_t port_id, uint32_t ptype_mask,
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (ptypes == NULL && num > 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u supported packet types to NULL when array size is non zero\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_supported_ptypes_get, 0);
        all_ptypes = (*dev->dev_ops->dev_supported_ptypes_get)(dev);
 
@@ -3361,8 +3570,12 @@ rte_eth_dev_set_ptypes(uint16_t port_id, uint32_t ptype_mask,
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
-       if (num > 0 && set_ptypes == NULL)
+       if (num > 0 && set_ptypes == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u set packet types to NULL when array size is non zero\n",
+                       port_id);
                return -EINVAL;
+       }
 
        if (*dev->dev_ops->dev_supported_ptypes_get == NULL ||
                        *dev->dev_ops->dev_ptypes_set == NULL) {
@@ -3425,6 +3638,31 @@ ptype_unknown:
        return ret;
 }
 
+int
+rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma,
+       unsigned int num)
+{
+       int32_t ret;
+       struct rte_eth_dev *dev;
+       struct rte_eth_dev_info dev_info;
+
+       if (ma == NULL) {
+               RTE_ETHDEV_LOG(ERR, "%s: invalid parameters\n", __func__);
+               return -EINVAL;
+       }
+
+       /* will check for us that port_id is a valid one */
+       ret = rte_eth_dev_info_get(port_id, &dev_info);
+       if (ret != 0)
+               return ret;
+
+       dev = &rte_eth_devices[port_id];
+       num = RTE_MIN(dev_info.max_mac_addrs, num);
+       memcpy(ma, dev->data->mac_addrs, num * sizeof(ma[0]));
+
+       return num;
+}
+
 int
 rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr)
 {
@@ -3432,6 +3670,14 @@ rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (mac_addr == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u MAC address to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        rte_ether_addr_copy(&dev->data->mac_addrs[0], mac_addr);
 
        return 0;
@@ -3443,8 +3689,14 @@ rte_eth_dev_get_mtu(uint16_t port_id, uint16_t *mtu)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
+       if (mtu == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u MTU to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        *mtu = dev->data->mtu;
        return 0;
 }
@@ -3471,12 +3723,20 @@ rte_eth_dev_set_mtu(uint16_t port_id, uint16_t mtu)
                if (ret != 0)
                        return ret;
 
-               if (mtu < dev_info.min_mtu || mtu > dev_info.max_mtu)
-                       return -EINVAL;
+               ret = eth_dev_validate_mtu(port_id, &dev_info, mtu);
+               if (ret != 0)
+                       return ret;
+       }
+
+       if (dev->data->dev_configured == 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Port %u must be configured before MTU set\n",
+                       port_id);
+               return -EINVAL;
        }
 
        ret = (*dev->dev_ops->mtu_set)(dev, mtu);
-       if (!ret)
+       if (ret == 0)
                dev->data->mtu = mtu;
 
        return eth_err(port_id, ret);
@@ -3490,9 +3750,10 @@ rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
        if (!(dev->data->dev_conf.rxmode.offloads &
              DEV_RX_OFFLOAD_VLAN_FILTER)) {
-               RTE_ETHDEV_LOG(ERR, "Port %u: vlan-filtering disabled\n",
+               RTE_ETHDEV_LOG(ERR, "Port %u: VLAN-filtering disabled\n",
                        port_id);
                return -ENOSYS;
        }
@@ -3515,9 +3776,9 @@ rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on)
                vbit = vlan_id % 64;
 
                if (on)
-                       vfc->ids[vidx] |= UINT64_C(1) << vbit;
+                       vfc->ids[vidx] |= RTE_BIT64(vbit);
                else
-                       vfc->ids[vidx] &= ~(UINT64_C(1) << vbit);
+                       vfc->ids[vidx] &= ~RTE_BIT64(vbit);
        }
 
        return eth_err(port_id, ret);
@@ -3531,6 +3792,7 @@ rte_eth_dev_set_vlan_strip_on_queue(uint16_t port_id, uint16_t rx_queue_id,
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
        if (rx_queue_id >= dev->data->nb_rx_queues) {
                RTE_ETHDEV_LOG(ERR, "Invalid rx_queue_id=%u\n", rx_queue_id);
                return -EINVAL;
@@ -3551,8 +3813,8 @@ rte_eth_dev_set_vlan_ether_type(uint16_t port_id,
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
-       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_tpid_set, -ENOTSUP);
 
+       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_tpid_set, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->vlan_tpid_set)(dev, vlan_type,
                                                               tpid));
 }
@@ -3681,8 +3943,8 @@ rte_eth_dev_set_vlan_pvid(uint16_t port_id, uint16_t pvid, int on)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
-       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_pvid_set, -ENOTSUP);
 
+       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_pvid_set, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->vlan_pvid_set)(dev, pvid, on));
 }
 
@@ -3693,6 +3955,14 @@ rte_eth_dev_flow_ctrl_get(uint16_t port_id, struct rte_eth_fc_conf *fc_conf)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (fc_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u flow control config to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->flow_ctrl_get, -ENOTSUP);
        memset(fc_conf, 0, sizeof(*fc_conf));
        return eth_err(port_id, (*dev->dev_ops->flow_ctrl_get)(dev, fc_conf));
@@ -3704,12 +3974,20 @@ rte_eth_dev_flow_ctrl_set(uint16_t port_id, struct rte_eth_fc_conf *fc_conf)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (fc_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot set ethdev port %u flow control from NULL config\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        if ((fc_conf->send_xon != 0) && (fc_conf->send_xon != 1)) {
                RTE_ETHDEV_LOG(ERR, "Invalid send_xon, only 0/1 allowed\n");
                return -EINVAL;
        }
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->flow_ctrl_set, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->flow_ctrl_set)(dev, fc_conf));
 }
@@ -3721,12 +3999,20 @@ rte_eth_dev_priority_flow_ctrl_set(uint16_t port_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (pfc_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot set ethdev port %u priority flow control from NULL config\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        if (pfc_conf->priority > (ETH_DCB_NUM_USER_PRIORITIES - 1)) {
                RTE_ETHDEV_LOG(ERR, "Invalid priority, only 0-7 allowed\n");
                return -EINVAL;
        }
 
-       dev = &rte_eth_devices[port_id];
        /* High water, low water validation are device specific */
        if  (*dev->dev_ops->priority_flow_ctrl_set)
                return eth_err(port_id, (*dev->dev_ops->priority_flow_ctrl_set)
@@ -3740,9 +4026,6 @@ eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf,
 {
        uint16_t i, num;
 
-       if (!reta_conf)
-               return -EINVAL;
-
        num = (reta_size + RTE_RETA_GROUP_SIZE - 1) / RTE_RETA_GROUP_SIZE;
        for (i = 0; i < num; i++) {
                if (reta_conf[i].mask)
@@ -3759,9 +4042,6 @@ eth_check_reta_entry(struct rte_eth_rss_reta_entry64 *reta_conf,
 {
        uint16_t i, idx, shift;
 
-       if (!reta_conf)
-               return -EINVAL;
-
        if (max_rxq == 0) {
                RTE_ETHDEV_LOG(ERR, "No receive queue is available\n");
                return -EINVAL;
@@ -3770,7 +4050,7 @@ eth_check_reta_entry(struct rte_eth_rss_reta_entry64 *reta_conf,
        for (i = 0; i < reta_size; i++) {
                idx = i / RTE_RETA_GROUP_SIZE;
                shift = i % RTE_RETA_GROUP_SIZE;
-               if ((reta_conf[idx].mask & (1ULL << shift)) &&
+               if ((reta_conf[idx].mask & RTE_BIT64(shift)) &&
                        (reta_conf[idx].reta[shift] >= max_rxq)) {
                        RTE_ETHDEV_LOG(ERR,
                                "reta_conf[%u]->reta[%u]: %u exceeds the maximum rxq index: %u\n",
@@ -3792,13 +4072,27 @@ rte_eth_dev_rss_reta_update(uint16_t port_id,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (reta_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot update ethdev port %u RSS RETA to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
+       if (reta_size == 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot update ethdev port %u RSS RETA with zero size\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        /* Check mask bits */
        ret = eth_check_reta_mask(reta_conf, reta_size);
        if (ret < 0)
                return ret;
 
-       dev = &rte_eth_devices[port_id];
-
        /* Check entry value */
        ret = eth_check_reta_entry(reta_conf, reta_size,
                                dev->data->nb_rx_queues);
@@ -3819,13 +4113,20 @@ rte_eth_dev_rss_reta_query(uint16_t port_id,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (reta_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot query ethdev port %u RSS RETA from NULL config\n",
+                       port_id);
+               return -EINVAL;
+       }
 
        /* Check mask bits */
        ret = eth_check_reta_mask(reta_conf, reta_size);
        if (ret < 0)
                return ret;
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->reta_query, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->reta_query)(dev, reta_conf,
                                                            reta_size));
@@ -3840,14 +4141,20 @@ rte_eth_dev_rss_hash_update(uint16_t port_id,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (rss_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot update ethdev port %u RSS hash from NULL config\n",
+                       port_id);
+               return -EINVAL;
+       }
 
        ret = rte_eth_dev_info_get(port_id, &dev_info);
        if (ret != 0)
                return ret;
 
        rss_conf->rss_hf = rte_eth_rss_hf_refine(rss_conf->rss_hf);
-
-       dev = &rte_eth_devices[port_id];
        if ((dev_info.flow_type_rss_offloads | rss_conf->rss_hf) !=
            dev_info.flow_type_rss_offloads) {
                RTE_ETHDEV_LOG(ERR,
@@ -3869,6 +4176,14 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id,
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (rss_conf == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u RSS hash config to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rss_hash_conf_get, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->rss_hash_conf_get)(dev,
                                                                   rss_conf));
@@ -3881,8 +4196,12 @@ rte_eth_dev_udp_tunnel_port_add(uint16_t port_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
        if (udp_tunnel == NULL) {
-               RTE_ETHDEV_LOG(ERR, "Invalid udp_tunnel parameter\n");
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot add ethdev port %u UDP tunnel port from NULL UDP tunnel\n",
+                       port_id);
                return -EINVAL;
        }
 
@@ -3891,7 +4210,6 @@ rte_eth_dev_udp_tunnel_port_add(uint16_t port_id,
                return -EINVAL;
        }
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->udp_tunnel_port_add, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->udp_tunnel_port_add)(dev,
                                                                udp_tunnel));
@@ -3907,7 +4225,9 @@ rte_eth_dev_udp_tunnel_port_delete(uint16_t port_id,
        dev = &rte_eth_devices[port_id];
 
        if (udp_tunnel == NULL) {
-               RTE_ETHDEV_LOG(ERR, "Invalid udp_tunnel parameter\n");
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot delete ethdev port %u UDP tunnel port from NULL UDP tunnel\n",
+                       port_id);
                return -EINVAL;
        }
 
@@ -3928,6 +4248,7 @@ rte_eth_led_on(uint16_t port_id)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_led_on, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->dev_led_on)(dev));
 }
@@ -3939,6 +4260,7 @@ rte_eth_led_off(uint16_t port_id)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_led_off, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->dev_led_off)(dev));
 }
@@ -3951,11 +4273,16 @@ rte_eth_fec_get_capability(uint16_t port_id,
        struct rte_eth_dev *dev;
        int ret;
 
-       if (speed_fec_capa == NULL && num > 0)
-               return -EINVAL;
-
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (speed_fec_capa == NULL && num > 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u FEC capability to NULL when array size is non zero\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get_capability, -ENOTSUP);
        ret = (*dev->dev_ops->fec_get_capability)(dev, speed_fec_capa, num);
 
@@ -3967,11 +4294,16 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
 {
        struct rte_eth_dev *dev;
 
-       if (fec_capa == NULL)
-               return -EINVAL;
-
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (fec_capa == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u current FEC mode to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_capa));
 }
@@ -3983,6 +4315,7 @@ rte_eth_fec_set(uint16_t port_id, uint32_t fec_capa)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_set, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, fec_capa));
 }
@@ -4024,6 +4357,14 @@ rte_eth_dev_mac_addr_add(uint16_t port_id, struct rte_ether_addr *addr,
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (addr == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot add ethdev port %u MAC address from NULL address\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_add, -ENOTSUP);
 
        if (rte_is_zero_ether_addr(addr)) {
@@ -4032,7 +4373,7 @@ rte_eth_dev_mac_addr_add(uint16_t port_id, struct rte_ether_addr *addr,
                return -EINVAL;
        }
        if (pool >= ETH_64_POOLS) {
-               RTE_ETHDEV_LOG(ERR, "Pool id must be 0-%d\n", ETH_64_POOLS - 1);
+               RTE_ETHDEV_LOG(ERR, "Pool ID must be 0-%d\n", ETH_64_POOLS - 1);
                return -EINVAL;
        }
 
@@ -4048,7 +4389,7 @@ rte_eth_dev_mac_addr_add(uint16_t port_id, struct rte_ether_addr *addr,
                pool_mask = dev->data->mac_pool_sel[index];
 
                /* Check if both MAC address and pool is already there, and do nothing */
-               if (pool_mask & (1ULL << pool))
+               if (pool_mask & RTE_BIT64(pool))
                        return 0;
        }
 
@@ -4060,7 +4401,7 @@ rte_eth_dev_mac_addr_add(uint16_t port_id, struct rte_ether_addr *addr,
                rte_ether_addr_copy(addr, &dev->data->mac_addrs[index]);
 
                /* Update pool bitmap in NIC data structure */
-               dev->data->mac_pool_sel[index] |= (1ULL << pool);
+               dev->data->mac_pool_sel[index] |= RTE_BIT64(pool);
        }
 
        return eth_err(port_id, ret);
@@ -4074,6 +4415,14 @@ rte_eth_dev_mac_addr_remove(uint16_t port_id, struct rte_ether_addr *addr)
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
+
+       if (addr == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot remove ethdev port %u MAC address from NULL address\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_remove, -ENOTSUP);
 
        index = eth_dev_get_mac_addr_index(port_id, addr);
@@ -4104,11 +4453,18 @@ rte_eth_dev_default_mac_addr_set(uint16_t port_id, struct rte_ether_addr *addr)
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (addr == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot set ethdev port %u default MAC address from NULL address\n",
+                       port_id);
+               return -EINVAL;
+       }
 
        if (!rte_is_valid_assigned_ether_addr(addr))
                return -EINVAL;
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_set, -ENOTSUP);
 
        ret = (*dev->dev_ops->mac_addr_set)(dev, addr);
@@ -4159,8 +4515,15 @@ rte_eth_dev_uc_hash_table_set(uint16_t port_id, struct rte_ether_addr *addr,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
+       if (addr == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot set ethdev port %u unicast hash table from NULL address\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        if (rte_is_zero_ether_addr(addr)) {
                RTE_ETHDEV_LOG(ERR, "Port %u: Cannot add NULL MAC address\n",
                        port_id);
@@ -4209,7 +4572,6 @@ rte_eth_dev_uc_all_hash_table_set(uint16_t port_id, uint8_t on)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->uc_all_hash_table_set, -ENOTSUP);
@@ -4226,17 +4588,17 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
 
        ret = rte_eth_dev_info_get(port_id, &dev_info);
        if (ret != 0)
                return ret;
 
-       dev = &rte_eth_devices[port_id];
        link = dev->data->dev_link;
 
        if (queue_idx > dev_info.max_tx_queues) {
                RTE_ETHDEV_LOG(ERR,
-                       "Set queue rate limit:port %u: invalid queue id=%u\n",
+                       "Set queue rate limit:port %u: invalid queue ID=%u\n",
                        port_id, queue_idx);
                return -EINVAL;
        }
@@ -4253,59 +4615,12 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx,
                                                        queue_idx, tx_rate));
 }
 
-int
-rte_eth_mirror_rule_set(uint16_t port_id,
-                       struct rte_eth_mirror_conf *mirror_conf,
-                       uint8_t rule_id, uint8_t on)
+RTE_INIT(eth_dev_init_fp_ops)
 {
-       struct rte_eth_dev *dev;
-
-       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-       if (mirror_conf->rule_type == 0) {
-               RTE_ETHDEV_LOG(ERR, "Mirror rule type can not be 0\n");
-               return -EINVAL;
-       }
-
-       if (mirror_conf->dst_pool >= ETH_64_POOLS) {
-               RTE_ETHDEV_LOG(ERR, "Invalid dst pool, pool id must be 0-%d\n",
-                       ETH_64_POOLS - 1);
-               return -EINVAL;
-       }
-
-       if ((mirror_conf->rule_type & (ETH_MIRROR_VIRTUAL_POOL_UP |
-            ETH_MIRROR_VIRTUAL_POOL_DOWN)) &&
-           (mirror_conf->pool_mask == 0)) {
-               RTE_ETHDEV_LOG(ERR,
-                       "Invalid mirror pool, pool mask can not be 0\n");
-               return -EINVAL;
-       }
-
-       if ((mirror_conf->rule_type & ETH_MIRROR_VLAN) &&
-           mirror_conf->vlan.vlan_mask == 0) {
-               RTE_ETHDEV_LOG(ERR,
-                       "Invalid vlan mask, vlan mask can not be 0\n");
-               return -EINVAL;
-       }
-
-       dev = &rte_eth_devices[port_id];
-       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mirror_rule_set, -ENOTSUP);
-
-       return eth_err(port_id, (*dev->dev_ops->mirror_rule_set)(dev,
-                                               mirror_conf, rule_id, on));
-}
-
-int
-rte_eth_mirror_rule_reset(uint16_t port_id, uint8_t rule_id)
-{
-       struct rte_eth_dev *dev;
-
-       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       uint32_t i;
 
-       dev = &rte_eth_devices[port_id];
-       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mirror_rule_reset, -ENOTSUP);
-
-       return eth_err(port_id, (*dev->dev_ops->mirror_rule_reset)(dev,
-                                                                  rule_id));
+       for (i = 0; i != RTE_DIM(rte_eth_fp_ops); i++)
+               eth_dev_fp_ops_reset(rte_eth_fp_ops + i);
 }
 
 RTE_INIT(eth_dev_init_cb_lists)
@@ -4326,8 +4641,12 @@ rte_eth_dev_callback_register(uint16_t port_id,
        uint16_t next_port;
        uint16_t last_port;
 
-       if (!cb_fn)
+       if (cb_fn == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot register ethdev port %u callback from NULL\n",
+                       port_id);
                return -EINVAL;
+       }
 
        if (!rte_eth_dev_is_valid_port(port_id) && port_id != RTE_ETH_ALL) {
                RTE_ETHDEV_LOG(ERR, "Invalid port_id=%d\n", port_id);
@@ -4389,8 +4708,12 @@ rte_eth_dev_callback_unregister(uint16_t port_id,
        uint16_t next_port;
        uint16_t last_port;
 
-       if (!cb_fn)
+       if (cb_fn == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot unregister ethdev port %u callback from NULL\n",
+                       port_id);
                return -EINVAL;
+       }
 
        if (!rte_eth_dev_is_valid_port(port_id) && port_id != RTE_ETH_ALL) {
                RTE_ETHDEV_LOG(ERR, "Invalid port_id=%d\n", port_id);
@@ -4468,6 +4791,14 @@ rte_eth_dev_probing_finish(struct rte_eth_dev *dev)
        if (dev == NULL)
                return;
 
+       /*
+        * for secondary process, at that point we expect device
+        * to be already 'usable', so shared data and all function pointers
+        * for fast-path devops have to be setup properly inside rte_eth_dev.
+        */
+       if (rte_eal_process_type() == RTE_PROC_SECONDARY)
+               eth_dev_fp_ops_setup(rte_eth_fp_ops + dev->data->port_id, dev);
+
        rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_NEW, NULL);
 
        dev->state = RTE_ETH_DEV_ATTACHED;
@@ -4483,17 +4814,16 @@ rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, int op, void *data)
        int rc;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        if (!dev->intr_handle) {
-               RTE_ETHDEV_LOG(ERR, "RX Intr handle unset\n");
+               RTE_ETHDEV_LOG(ERR, "Rx Intr handle unset\n");
                return -ENOTSUP;
        }
 
        intr_handle = dev->intr_handle;
        if (!intr_handle->intr_vec) {
-               RTE_ETHDEV_LOG(ERR, "RX Intr vector unset\n");
+               RTE_ETHDEV_LOG(ERR, "Rx Intr vector unset\n");
                return -EPERM;
        }
 
@@ -4502,7 +4832,7 @@ rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, int op, void *data)
                rc = rte_intr_rx_ctl(intr_handle, epfd, op, vec, data);
                if (rc && rc != -EEXIST) {
                        RTE_ETHDEV_LOG(ERR,
-                               "p %u q %u rx ctl error op %d epfd %d vec %u\n",
+                               "p %u q %u Rx ctl error op %d epfd %d vec %u\n",
                                port_id, qid, op, epfd, vec);
                }
        }
@@ -4520,22 +4850,21 @@ rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id)
        int fd;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -1);
-
        dev = &rte_eth_devices[port_id];
 
        if (queue_id >= dev->data->nb_rx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", queue_id);
                return -1;
        }
 
        if (!dev->intr_handle) {
-               RTE_ETHDEV_LOG(ERR, "RX Intr handle unset\n");
+               RTE_ETHDEV_LOG(ERR, "Rx Intr handle unset\n");
                return -1;
        }
 
        intr_handle = dev->intr_handle;
        if (!intr_handle->intr_vec) {
-               RTE_ETHDEV_LOG(ERR, "RX Intr vector unset\n");
+               RTE_ETHDEV_LOG(ERR, "Rx Intr vector unset\n");
                return -1;
        }
 
@@ -4707,21 +5036,21 @@ rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
        int rc;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        if (queue_id >= dev->data->nb_rx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", queue_id);
                return -EINVAL;
        }
 
        if (!dev->intr_handle) {
-               RTE_ETHDEV_LOG(ERR, "RX Intr handle unset\n");
+               RTE_ETHDEV_LOG(ERR, "Rx Intr handle unset\n");
                return -ENOTSUP;
        }
 
        intr_handle = dev->intr_handle;
        if (!intr_handle->intr_vec) {
-               RTE_ETHDEV_LOG(ERR, "RX Intr vector unset\n");
+               RTE_ETHDEV_LOG(ERR, "Rx Intr vector unset\n");
                return -EPERM;
        }
 
@@ -4729,7 +5058,7 @@ rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
        rc = rte_intr_rx_ctl(intr_handle, epfd, op, vec, data);
        if (rc && rc != -EEXIST) {
                RTE_ETHDEV_LOG(ERR,
-                       "p %u q %u rx ctl error op %d epfd %d vec %u\n",
+                       "p %u q %u Rx ctl error op %d epfd %d vec %u\n",
                        port_id, queue_id, op, epfd, vec);
                return rc;
        }
@@ -4745,7 +5074,6 @@ rte_eth_dev_rx_intr_enable(uint16_t port_id,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        ret = eth_dev_validate_rx_queue(dev, queue_id);
@@ -4753,8 +5081,7 @@ rte_eth_dev_rx_intr_enable(uint16_t port_id,
                return ret;
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP);
-       return eth_err(port_id, (*dev->dev_ops->rx_queue_intr_enable)(dev,
-                                                               queue_id));
+       return eth_err(port_id, (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id));
 }
 
 int
@@ -4765,7 +5092,6 @@ rte_eth_dev_rx_intr_disable(uint16_t port_id,
        int ret;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
        ret = eth_dev_validate_rx_queue(dev, queue_id);
@@ -4773,8 +5099,7 @@ rte_eth_dev_rx_intr_disable(uint16_t port_id,
                return ret;
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP);
-       return eth_err(port_id, (*dev->dev_ops->rx_queue_intr_disable)(dev,
-                                                               queue_id));
+       return eth_err(port_id, (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id));
 }
 
 
@@ -5008,13 +5333,16 @@ rte_eth_rx_queue_info_get(uint16_t port_id, uint16_t queue_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
 
-       if (qinfo == NULL)
+       if (queue_id >= dev->data->nb_rx_queues) {
+               RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", queue_id);
                return -EINVAL;
+       }
 
-       dev = &rte_eth_devices[port_id];
-       if (queue_id >= dev->data->nb_rx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", queue_id);
+       if (qinfo == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u Rx queue %u info to NULL\n",
+                       port_id, queue_id);
                return -EINVAL;
        }
 
@@ -5038,6 +5366,8 @@ rte_eth_rx_queue_info_get(uint16_t port_id, uint16_t queue_id,
 
        memset(qinfo, 0, sizeof(*qinfo));
        dev->dev_ops->rxq_info_get(dev, queue_id, qinfo);
+       qinfo->queue_state = dev->data->rx_queue_state[queue_id];
+
        return 0;
 }
 
@@ -5048,13 +5378,16 @@ rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
 
-       if (qinfo == NULL)
+       if (queue_id >= dev->data->nb_tx_queues) {
+               RTE_ETHDEV_LOG(ERR, "Invalid Tx queue_id=%u\n", queue_id);
                return -EINVAL;
+       }
 
-       dev = &rte_eth_devices[port_id];
-       if (queue_id >= dev->data->nb_tx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", queue_id);
+       if (qinfo == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u Tx queue %u info to NULL\n",
+                       port_id, queue_id);
                return -EINVAL;
        }
 
@@ -5078,6 +5411,7 @@ rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
 
        memset(qinfo, 0, sizeof(*qinfo));
        dev->dev_ops->txq_info_get(dev, queue_id, qinfo);
+       qinfo->queue_state = dev->data->tx_queue_state[queue_id];
 
        return 0;
 }
@@ -5089,14 +5423,17 @@ rte_eth_rx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
-       if (mode == NULL)
-               return -EINVAL;
-
        dev = &rte_eth_devices[port_id];
 
        if (queue_id >= dev->data->nb_rx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", queue_id);
+               return -EINVAL;
+       }
+
+       if (mode == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u Rx queue %u burst mode to NULL\n",
+                       port_id, queue_id);
                return -EINVAL;
        }
 
@@ -5113,14 +5450,17 @@ rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
-       if (mode == NULL)
-               return -EINVAL;
-
        dev = &rte_eth_devices[port_id];
 
        if (queue_id >= dev->data->nb_tx_queues) {
-               RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", queue_id);
+               RTE_ETHDEV_LOG(ERR, "Invalid Tx queue_id=%u\n", queue_id);
+               return -EINVAL;
+       }
+
+       if (mode == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u Tx queue %u burst mode to NULL\n",
+                       port_id, queue_id);
                return -EINVAL;
        }
 
@@ -5137,25 +5477,23 @@ rte_eth_get_monitor_addr(uint16_t port_id, uint16_t queue_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
 
-       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_monitor_addr, -ENOTSUP);
-
        if (queue_id >= dev->data->nb_rx_queues) {
                RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", queue_id);
                return -EINVAL;
        }
 
        if (pmc == NULL) {
-               RTE_ETHDEV_LOG(ERR, "Invalid power monitor condition=%p\n",
-                               pmc);
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u Rx queue %u power monitor condition to NULL\n",
+                       port_id, queue_id);
                return -EINVAL;
        }
 
+       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_monitor_addr, -ENOTSUP);
        return eth_err(port_id,
-               dev->dev_ops->get_monitor_addr(dev->data->rx_queues[queue_id],
-                       pmc));
+               dev->dev_ops->get_monitor_addr(dev->data->rx_queues[queue_id], pmc));
 }
 
 int
@@ -5166,8 +5504,8 @@ rte_eth_dev_set_mc_addr_list(uint16_t port_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_mc_addr_list, -ENOTSUP);
        return eth_err(port_id, dev->dev_ops->set_mc_addr_list(dev,
                                                mc_addr_set, nb_mc_addr));
@@ -5206,6 +5544,13 @@ rte_eth_timesync_read_rx_timestamp(uint16_t port_id, struct timespec *timestamp,
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
+       if (timestamp == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot read ethdev port %u Rx timestamp to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_read_rx_timestamp, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->timesync_read_rx_timestamp)
                                (dev, timestamp, flags));
@@ -5220,6 +5565,13 @@ rte_eth_timesync_read_tx_timestamp(uint16_t port_id,
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
+       if (timestamp == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot read ethdev port %u Tx timestamp to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_read_tx_timestamp, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->timesync_read_tx_timestamp)
                                (dev, timestamp));
@@ -5234,8 +5586,7 @@ rte_eth_timesync_adjust_time(uint16_t port_id, int64_t delta)
        dev = &rte_eth_devices[port_id];
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_adjust_time, -ENOTSUP);
-       return eth_err(port_id, (*dev->dev_ops->timesync_adjust_time)(dev,
-                                                                     delta));
+       return eth_err(port_id, (*dev->dev_ops->timesync_adjust_time)(dev, delta));
 }
 
 int
@@ -5246,6 +5597,13 @@ rte_eth_timesync_read_time(uint16_t port_id, struct timespec *timestamp)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
+       if (timestamp == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot read ethdev port %u timesync time to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_read_time, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->timesync_read_time)(dev,
                                                                timestamp));
@@ -5259,6 +5617,13 @@ rte_eth_timesync_write_time(uint16_t port_id, const struct timespec *timestamp)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
+       if (timestamp == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot write ethdev port %u timesync from NULL time\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_write_time, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->timesync_write_time)(dev,
                                                                timestamp));
@@ -5272,6 +5637,12 @@ rte_eth_read_clock(uint16_t port_id, uint64_t *clock)
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
+       if (clock == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Cannot read ethdev port %u clock to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->read_clock, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->read_clock)(dev, clock));
 }
@@ -5282,10 +5653,15 @@ rte_eth_dev_get_reg_info(uint16_t port_id, struct rte_dev_reg_info *info)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-       if (info == NULL)
+       dev = &rte_eth_devices[port_id];
+
+       if (info == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u register info to NULL\n",
+                       port_id);
                return -EINVAL;
+       }
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_reg, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->get_reg)(dev, info));
 }
@@ -5296,8 +5672,8 @@ rte_eth_dev_get_eeprom_length(uint16_t port_id)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_eeprom_length, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->get_eeprom_length)(dev));
 }
@@ -5308,10 +5684,15 @@ rte_eth_dev_get_eeprom(uint16_t port_id, struct rte_dev_eeprom_info *info)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-       if (info == NULL)
+       dev = &rte_eth_devices[port_id];
+
+       if (info == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u EEPROM info to NULL\n",
+                       port_id);
                return -EINVAL;
+       }
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_eeprom, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->get_eeprom)(dev, info));
 }
@@ -5322,10 +5703,15 @@ rte_eth_dev_set_eeprom(uint16_t port_id, struct rte_dev_eeprom_info *info)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-       if (info == NULL)
+       dev = &rte_eth_devices[port_id];
+
+       if (info == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot set ethdev port %u EEPROM from NULL info\n",
+                       port_id);
                return -EINVAL;
+       }
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_eeprom, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->set_eeprom)(dev, info));
 }
@@ -5337,10 +5723,15 @@ rte_eth_dev_get_module_info(uint16_t port_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-       if (modinfo == NULL)
+       dev = &rte_eth_devices[port_id];
+
+       if (modinfo == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u EEPROM module info to NULL\n",
+                       port_id);
                return -EINVAL;
+       }
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_module_info, -ENOTSUP);
        return (*dev->dev_ops->get_module_info)(dev, modinfo);
 }
@@ -5352,10 +5743,29 @@ rte_eth_dev_get_module_eeprom(uint16_t port_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-       if (info == NULL || info->data == NULL || info->length == 0)
+       dev = &rte_eth_devices[port_id];
+
+       if (info == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u module EEPROM info to NULL\n",
+                       port_id);
                return -EINVAL;
+       }
+
+       if (info->data == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u module EEPROM data to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
+       if (info->length == 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u module EEPROM to data with zero size\n",
+                       port_id);
+               return -EINVAL;
+       }
 
-       dev = &rte_eth_devices[port_id];
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_module_eeprom, -ENOTSUP);
        return (*dev->dev_ops->get_module_eeprom)(dev, info);
 }
@@ -5367,8 +5777,15 @@ rte_eth_dev_get_dcb_info(uint16_t port_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
+       if (dcb_info == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u DCB info to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        memset(dcb_info, 0, sizeof(struct rte_eth_dcb_info));
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_dcb_info, -ENOTSUP);
@@ -5418,8 +5835,15 @@ rte_eth_dev_hairpin_capability_get(uint16_t port_id,
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
        dev = &rte_eth_devices[port_id];
+
+       if (cap == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot get ethdev port %u hairpin capability to NULL\n",
+                       port_id);
+               return -EINVAL;
+       }
+
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->hairpin_cap_get, -ENOTSUP);
        memset(cap, 0, sizeof(*cap));
        return eth_err(port_id, (*dev->dev_ops->hairpin_cap_get)(dev, cap));
@@ -5428,8 +5852,7 @@ rte_eth_dev_hairpin_capability_get(uint16_t port_id,
 int
 rte_eth_dev_is_rx_hairpin_queue(struct rte_eth_dev *dev, uint16_t queue_id)
 {
-       if (dev->data->rx_queue_state[queue_id] ==
-           RTE_ETH_QUEUE_STATE_HAIRPIN)
+       if (dev->data->rx_queue_state[queue_id] == RTE_ETH_QUEUE_STATE_HAIRPIN)
                return 1;
        return 0;
 }
@@ -5437,8 +5860,7 @@ rte_eth_dev_is_rx_hairpin_queue(struct rte_eth_dev *dev, uint16_t queue_id)
 int
 rte_eth_dev_is_tx_hairpin_queue(struct rte_eth_dev *dev, uint16_t queue_id)
 {
-       if (dev->data->tx_queue_state[queue_id] ==
-           RTE_ETH_QUEUE_STATE_HAIRPIN)
+       if (dev->data->tx_queue_state[queue_id] == RTE_ETH_QUEUE_STATE_HAIRPIN)
                return 1;
        return 0;
 }
@@ -5449,11 +5871,14 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const char *pool)
        struct rte_eth_dev *dev;
 
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
 
-       if (pool == NULL)
+       if (pool == NULL) {
+               RTE_ETHDEV_LOG(ERR,
+                       "Cannot test ethdev port %u mempool operation from NULL pool\n",
+                       port_id);
                return -EINVAL;
-
-       dev = &rte_eth_devices[port_id];
+       }
 
        if (*dev->dev_ops->pool_ops_supported == NULL)
                return 1; /* all pools are supported */
@@ -5616,12 +6041,13 @@ parse_cleanup:
 }
 
 int
-rte_eth_representor_id_get(const struct rte_eth_dev *ethdev,
+rte_eth_representor_id_get(uint16_t port_id,
                           enum rte_eth_representor_type type,
                           int controller, int pf, int representor_port,
                           uint16_t *repr_id)
 {
-       int ret, n, i, count;
+       int ret, n, count;
+       uint32_t i;
        struct rte_eth_representor_info *info = NULL;
        size_t size;
 
@@ -5631,7 +6057,7 @@ rte_eth_representor_id_get(const struct rte_eth_dev *ethdev,
                return -EINVAL;
 
        /* Get PMD representor range info. */
-       ret = rte_eth_representor_info_get(ethdev->data->port_id, NULL);
+       ret = rte_eth_representor_info_get(port_id, NULL);
        if (ret == -ENOTSUP && type == RTE_ETH_REPRESENTOR_VF &&
            controller == -1 && pf == -1) {
                /* Direct mapping for legacy VF representor. */
@@ -5645,7 +6071,8 @@ rte_eth_representor_id_get(const struct rte_eth_dev *ethdev,
        info = calloc(1, size);
        if (info == NULL)
                return -ENOMEM;
-       ret = rte_eth_representor_info_get(ethdev->data->port_id, info);
+       info->nb_ranges_alloc = n;
+       ret = rte_eth_representor_info_get(port_id, info);
        if (ret < 0)
                goto out;
 
@@ -5657,14 +6084,14 @@ rte_eth_representor_id_get(const struct rte_eth_dev *ethdev,
 
        /* Locate representor ID. */
        ret = -ENOENT;
-       for (i = 0; i < n; ++i) {
+       for (i = 0; i < info->nb_ranges; ++i) {
                if (info->ranges[i].type != type)
                        continue;
                if (info->ranges[i].controller != controller)
                        continue;
                if (info->ranges[i].id_end < info->ranges[i].id_base) {
                        RTE_LOG(WARNING, EAL, "Port %hu invalid representor ID Range %u - %u, entry %d\n",
-                               ethdev->data->port_id, info->ranges[i].id_base,
+                               port_id, info->ranges[i].id_base,
                                info->ranges[i].id_end, i);
                        continue;
 
@@ -5860,6 +6287,96 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused,
        return 0;
 }
 
+static int
+eth_dev_handle_port_info(const char *cmd __rte_unused,
+               const char *params,
+               struct rte_tel_data *d)
+{
+       struct rte_tel_data *rxq_state, *txq_state;
+       char mac_addr[RTE_ETHER_ADDR_LEN];
+       struct rte_eth_dev *eth_dev;
+       char *end_param;
+       int port_id, i;
+
+       if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+               return -1;
+
+       port_id = strtoul(params, &end_param, 0);
+       if (*end_param != '\0')
+               RTE_ETHDEV_LOG(NOTICE,
+                       "Extra parameters passed to ethdev telemetry command, ignoring");
+
+       if (!rte_eth_dev_is_valid_port(port_id))
+               return -EINVAL;
+
+       eth_dev = &rte_eth_devices[port_id];
+       if (!eth_dev)
+               return -EINVAL;
+
+       rxq_state = rte_tel_data_alloc();
+       if (!rxq_state)
+               return -ENOMEM;
+
+       txq_state = rte_tel_data_alloc();
+       if (!txq_state)
+               return -ENOMEM;
+
+       rte_tel_data_start_dict(d);
+       rte_tel_data_add_dict_string(d, "name", eth_dev->data->name);
+       rte_tel_data_add_dict_int(d, "state", eth_dev->state);
+       rte_tel_data_add_dict_int(d, "nb_rx_queues",
+                       eth_dev->data->nb_rx_queues);
+       rte_tel_data_add_dict_int(d, "nb_tx_queues",
+                       eth_dev->data->nb_tx_queues);
+       rte_tel_data_add_dict_int(d, "port_id", eth_dev->data->port_id);
+       rte_tel_data_add_dict_int(d, "mtu", eth_dev->data->mtu);
+       rte_tel_data_add_dict_int(d, "rx_mbuf_size_min",
+                       eth_dev->data->min_rx_buf_size);
+       rte_tel_data_add_dict_int(d, "rx_mbuf_alloc_fail",
+                       eth_dev->data->rx_mbuf_alloc_failed);
+       snprintf(mac_addr, RTE_ETHER_ADDR_LEN, "%02x:%02x:%02x:%02x:%02x:%02x",
+                        eth_dev->data->mac_addrs->addr_bytes[0],
+                        eth_dev->data->mac_addrs->addr_bytes[1],
+                        eth_dev->data->mac_addrs->addr_bytes[2],
+                        eth_dev->data->mac_addrs->addr_bytes[3],
+                        eth_dev->data->mac_addrs->addr_bytes[4],
+                        eth_dev->data->mac_addrs->addr_bytes[5]);
+       rte_tel_data_add_dict_string(d, "mac_addr", mac_addr);
+       rte_tel_data_add_dict_int(d, "promiscuous",
+                       eth_dev->data->promiscuous);
+       rte_tel_data_add_dict_int(d, "scattered_rx",
+                       eth_dev->data->scattered_rx);
+       rte_tel_data_add_dict_int(d, "all_multicast",
+                       eth_dev->data->all_multicast);
+       rte_tel_data_add_dict_int(d, "dev_started", eth_dev->data->dev_started);
+       rte_tel_data_add_dict_int(d, "lro", eth_dev->data->lro);
+       rte_tel_data_add_dict_int(d, "dev_configured",
+                       eth_dev->data->dev_configured);
+
+       rte_tel_data_start_array(rxq_state, RTE_TEL_INT_VAL);
+       for (i = 0; i < eth_dev->data->nb_rx_queues; i++)
+               rte_tel_data_add_array_int(rxq_state,
+                               eth_dev->data->rx_queue_state[i]);
+
+       rte_tel_data_start_array(txq_state, RTE_TEL_INT_VAL);
+       for (i = 0; i < eth_dev->data->nb_tx_queues; i++)
+               rte_tel_data_add_array_int(txq_state,
+                               eth_dev->data->tx_queue_state[i]);
+
+       rte_tel_data_add_dict_container(d, "rxq_state", rxq_state, 0);
+       rte_tel_data_add_dict_container(d, "txq_state", txq_state, 0);
+       rte_tel_data_add_dict_int(d, "numa_node", eth_dev->data->numa_node);
+       rte_tel_data_add_dict_int(d, "dev_flags", eth_dev->data->dev_flags);
+       rte_tel_data_add_dict_int(d, "rx_offloads",
+                       eth_dev->data->dev_conf.rxmode.offloads);
+       rte_tel_data_add_dict_int(d, "tx_offloads",
+                       eth_dev->data->dev_conf.txmode.offloads);
+       rte_tel_data_add_dict_int(d, "ethdev_rss_hf",
+                       eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf);
+
+       return 0;
+}
+
 int
 rte_eth_hairpin_queue_peer_update(uint16_t peer_port, uint16_t peer_queue,
                                  struct rte_hairpin_peer_info *cur_info,
@@ -5925,11 +6442,35 @@ rte_eth_representor_info_get(uint16_t port_id,
        dev = &rte_eth_devices[port_id];
 
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->representor_info_get, -ENOTSUP);
-       return eth_err(port_id, (*dev->dev_ops->representor_info_get)(dev,
-                                                                     info));
+       return eth_err(port_id, (*dev->dev_ops->representor_info_get)(dev, info));
+}
+
+int
+rte_eth_rx_metadata_negotiate(uint16_t port_id, uint64_t *features)
+{
+       struct rte_eth_dev *dev;
+
+       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       if (dev->data->dev_configured != 0) {
+               RTE_ETHDEV_LOG(ERR,
+                       "The port (ID=%"PRIu16") is already configured\n",
+                       port_id);
+               return -EBUSY;
+       }
+
+       if (features == NULL) {
+               RTE_ETHDEV_LOG(ERR, "Invalid features (NULL)\n");
+               return -EINVAL;
+       }
+
+       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_metadata_negotiate, -ENOTSUP);
+       return eth_err(port_id,
+                      (*dev->dev_ops->rx_metadata_negotiate)(dev, features));
 }
 
-RTE_LOG_REGISTER(rte_eth_dev_logtype, lib.ethdev, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);
 
 RTE_INIT(ethdev_init_telemetry)
 {
@@ -5942,4 +6483,6 @@ RTE_INIT(ethdev_init_telemetry)
        rte_telemetry_register_cmd("/ethdev/link_status",
                        eth_dev_handle_port_link_status,
                        "Returns the link status for a port. Parameters: int port_id");
+       rte_telemetry_register_cmd("/ethdev/info", eth_dev_handle_port_info,
+                       "Returns the device info for a port. Parameters: int port_id");
 }