lib: remove extra parenthesis after return

[dpdk.git] / lib / librte_cmdline / cmdline_parse_portlist.c

diff --git a/lib/librte_cmdline/cmdline_parse_portlist.c b/lib/librte_cmdline/cmdline_parse_portlist.c
index 7eac05c..f11bdf0 100644 (file)
--- a/lib/librte_cmdline/cmdline_parse_portlist.c
+++ b/lib/librte_cmdline/cmdline_parse_portlist.c
@@ -78,7 +78,7 @@ struct cmdline_token_ops cmdline_token_portlist_ops = {
 };
 
 static void
-parse_set_list(cmdline_portlist_t * pl, int low, int high)
+parse_set_list(cmdline_portlist_t *pl, size_t low, size_t high)
 {
        do {
                pl->map |= (1 << low++);
@@ -86,7 +86,7 @@ parse_set_list(cmdline_portlist_t * pl, int low, int high)
 }
 
 static int
-parse_ports(cmdline_portlist_t * pl, const char * str)
+parse_ports(cmdline_portlist_t *pl, const char *str)
 {
        size_t ps, pe;
        const char *first, *last;
@@ -102,7 +102,7 @@ parse_ports(cmdline_portlist_t * pl, const char * str)
                ps = strtoul(first, &end, 10);
                if (errno != 0 || end == first ||
                    (end[0] != '-' && end[0] != 0 && end != last))
-                       return (-1);
+                       return -1;
 
                /* Support for N-M portlist format */
                if (end[0] == '-') {
@@ -111,30 +111,33 @@ parse_ports(cmdline_portlist_t * pl, const char * str)
                        pe = strtoul(first, &end, 10);
                        if (errno != 0 || end == first ||
                            (end[0] != 0 && end != last))
-                               return (-1);
+                               return -1;
                } else {
                        pe = ps;
                }
 
                if (ps > pe || pe >= sizeof (pl->map) * 8)
-                       return (-1);
+                       return -1;
 
                parse_set_list(pl, ps, pe);
        }
 
-       return (0);
+       return 0;
 }
 
 int
 cmdline_parse_portlist(__attribute__((unused)) cmdline_parse_token_hdr_t *tk,
-               const char *buf, void *res)
+       const char *buf, void *res, unsigned ressize)
 {
        unsigned int token_len = 0;
        char portlist_str[PORTLIST_TOKEN_SIZE+1];
        cmdline_portlist_t *pl;
 
        if (!buf || ! *buf)
-               return (-1);
+               return -1;
+
+       if (res && ressize < sizeof(cmdline_portlist_t))
+               return -1;
 
        pl = res;
 
@@ -143,7 +146,7 @@ cmdline_parse_portlist(__attribute__((unused)) cmdline_parse_token_hdr_t *tk,
                token_len++;
 
        if (token_len >= PORTLIST_TOKEN_SIZE)
-               return (-1);
+               return -1;
 
        snprintf(portlist_str, token_len+1, "%s", buf);
 
@@ -152,7 +155,7 @@ cmdline_parse_portlist(__attribute__((unused)) cmdline_parse_token_hdr_t *tk,
                if (strcmp("all", portlist_str) == 0)
                        pl->map = UINT32_MAX;
                else if (parse_ports(pl, portlist_str) != 0)
-                       return (-1);
+                       return -1;
        }
 
        return token_len;