mem: provide thread-unsafe memseg list walk variant
[dpdk.git] / lib / librte_eal / common / eal_common_memory.c
index 1f15ff7..659cc08 100644 (file)
@@ -34,7 +34,7 @@
 
 #define MEMSEG_LIST_FMT "memseg-%" PRIu64 "k-%i-%i"
 
-static uint64_t baseaddr_offset;
+static void *next_baseaddr;
 static uint64_t system_page_sz;
 
 void *
@@ -56,9 +56,12 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
        allow_shrink = (flags & EAL_VIRTUAL_AREA_ALLOW_SHRINK) > 0;
        unmap = (flags & EAL_VIRTUAL_AREA_UNMAP) > 0;
 
-       if (requested_addr == NULL && internal_config.base_virtaddr != 0) {
-               requested_addr = (void *) (internal_config.base_virtaddr +
-                               (size_t)baseaddr_offset);
+       if (next_baseaddr == NULL && internal_config.base_virtaddr != 0 &&
+                       rte_eal_process_type() == RTE_PROC_PRIMARY)
+               next_baseaddr = (void *) internal_config.base_virtaddr;
+
+       if (requested_addr == NULL && next_baseaddr != NULL) {
+               requested_addr = next_baseaddr;
                requested_addr = RTE_PTR_ALIGN(requested_addr, page_sz);
                addr_is_hint = true;
        }
@@ -70,13 +73,18 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
         * system page size is the same as requested page size.
         */
        no_align = (requested_addr != NULL &&
-               ((uintptr_t)requested_addr & (page_sz - 1)) == 0) ||
+               ((uintptr_t)requested_addr & (page_sz - 1))) ||
                page_sz == system_page_sz;
 
        do {
                map_sz = no_align ? *size : *size + page_sz;
+               if (map_sz > SIZE_MAX) {
+                       RTE_LOG(ERR, EAL, "Map size too big\n");
+                       rte_errno = E2BIG;
+                       return NULL;
+               }
 
-               mapped_addr = mmap(requested_addr, map_sz, PROT_READ,
+               mapped_addr = mmap(requested_addr, (size_t)map_sz, PROT_READ,
                                mmap_flags, -1, 0);
                if (mapped_addr == MAP_FAILED && allow_shrink)
                        *size -= page_sz;
@@ -111,358 +119,41 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
                RTE_LOG(WARNING, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n",
                        requested_addr, aligned_addr);
                RTE_LOG(WARNING, EAL, "   This may cause issues with mapping memory into secondary processes\n");
+       } else if (next_baseaddr != NULL) {
+               next_baseaddr = RTE_PTR_ADD(aligned_addr, *size);
        }
 
-       if (unmap)
-               munmap(mapped_addr, map_sz);
-
        RTE_LOG(DEBUG, EAL, "Virtual area found at %p (size = 0x%zx)\n",
                aligned_addr, *size);
 
-       baseaddr_offset += *size;
-
-       return aligned_addr;
-}
-
-static uint64_t
-get_mem_amount(uint64_t page_sz, uint64_t max_mem)
-{
-       uint64_t area_sz, max_pages;
-
-       /* limit to RTE_MAX_MEMSEG_PER_LIST pages or RTE_MAX_MEM_MB_PER_LIST */
-       max_pages = RTE_MAX_MEMSEG_PER_LIST;
-       max_mem = RTE_MIN((uint64_t)RTE_MAX_MEM_MB_PER_LIST << 20, max_mem);
-
-       area_sz = RTE_MIN(page_sz * max_pages, max_mem);
-
-       /* make sure the list isn't smaller than the page size */
-       area_sz = RTE_MAX(area_sz, page_sz);
-
-       return RTE_ALIGN(area_sz, page_sz);
-}
-
-static int
-alloc_memseg_list(struct rte_memseg_list *msl, uint64_t page_sz,
-               uint64_t max_mem, int socket_id, int type_msl_idx)
-{
-       char name[RTE_FBARRAY_NAME_LEN];
-       uint64_t mem_amount;
-       int max_segs;
-
-       mem_amount = get_mem_amount(page_sz, max_mem);
-       max_segs = mem_amount / page_sz;
-
-       snprintf(name, sizeof(name), MEMSEG_LIST_FMT, page_sz >> 10, socket_id,
-                type_msl_idx);
-       if (rte_fbarray_init(&msl->memseg_arr, name, max_segs,
-                       sizeof(struct rte_memseg))) {
-               RTE_LOG(ERR, EAL, "Cannot allocate memseg list: %s\n",
-                       rte_strerror(rte_errno));
-               return -1;
-       }
-
-       msl->page_sz = page_sz;
-       msl->socket_id = socket_id;
-       msl->base_va = NULL;
-
-       RTE_LOG(DEBUG, EAL, "Memseg list allocated: 0x%zxkB at socket %i\n",
-                       (size_t)page_sz >> 10, socket_id);
-
-       return 0;
-}
-
-static int
-alloc_va_space(struct rte_memseg_list *msl)
-{
-       uint64_t page_sz;
-       size_t mem_sz;
-       void *addr;
-       int flags = 0;
-
-#ifdef RTE_ARCH_PPC_64
-       flags |= MAP_HUGETLB;
-#endif
-
-       page_sz = msl->page_sz;
-       mem_sz = page_sz * msl->memseg_arr.len;
-
-       addr = eal_get_virtual_area(msl->base_va, &mem_sz, page_sz, 0, flags);
-       if (addr == NULL) {
-               if (rte_errno == EADDRNOTAVAIL)
-                       RTE_LOG(ERR, EAL, "Could not mmap %llu bytes at [%p] - please use '--base-virtaddr' option\n",
-                               (unsigned long long)mem_sz, msl->base_va);
-               else
-                       RTE_LOG(ERR, EAL, "Cannot reserve memory\n");
-               return -1;
-       }
-       msl->base_va = addr;
-
-       return 0;
-}
-
-static int __rte_unused
-memseg_primary_init_32(void)
-{
-       struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
-       int active_sockets, hpi_idx, msl_idx = 0;
-       unsigned int socket_id, i;
-       struct rte_memseg_list *msl;
-       uint64_t extra_mem_per_socket, total_extra_mem, total_requested_mem;
-       uint64_t max_mem;
-
-       /* no-huge does not need this at all */
-       if (internal_config.no_hugetlbfs)
-               return 0;
-
-       /* this is a giant hack, but desperate times call for desperate
-        * measures. in legacy 32-bit mode, we cannot preallocate VA space,
-        * because having upwards of 2 gigabytes of VA space already mapped will
-        * interfere with our ability to map and sort hugepages.
-        *
-        * therefore, in legacy 32-bit mode, we will be initializing memseg
-        * lists much later - in eal_memory.c, right after we unmap all the
-        * unneeded pages. this will not affect secondary processes, as those
-        * should be able to mmap the space without (too many) problems.
-        */
-       if (internal_config.legacy_mem)
-               return 0;
-
-       /* 32-bit mode is a very special case. we cannot know in advance where
-        * the user will want to allocate their memory, so we have to do some
-        * heuristics.
-        */
-       active_sockets = 0;
-       total_requested_mem = 0;
-       if (internal_config.force_sockets)
-               for (i = 0; i < rte_socket_count(); i++) {
-                       uint64_t mem;
-
-                       socket_id = rte_socket_id_by_idx(i);
-                       mem = internal_config.socket_mem[socket_id];
-
-                       if (mem == 0)
-                               continue;
-
-                       active_sockets++;
-                       total_requested_mem += mem;
-               }
-       else
-               total_requested_mem = internal_config.memory;
-
-       max_mem = (uint64_t) RTE_MAX_MEM_MB_PER_TYPE << 20;
-       if (total_requested_mem > max_mem) {
-               RTE_LOG(ERR, EAL, "Invalid parameters: 32-bit process can at most use %uM of memory\n",
-                               (unsigned int)(max_mem >> 20));
-               return -1;
-       }
-       total_extra_mem = max_mem - total_requested_mem;
-       extra_mem_per_socket = active_sockets == 0 ? total_extra_mem :
-                       total_extra_mem / active_sockets;
-
-       /* the allocation logic is a little bit convoluted, but here's how it
-        * works, in a nutshell:
-        *  - if user hasn't specified on which sockets to allocate memory via
-        *    --socket-mem, we allocate all of our memory on master core socket.
-        *  - if user has specified sockets to allocate memory on, there may be
-        *    some "unused" memory left (e.g. if user has specified --socket-mem
-        *    such that not all memory adds up to 2 gigabytes), so add it to all
-        *    sockets that are in use equally.
-        *
-        * page sizes are sorted by size in descending order, so we can safely
-        * assume that we dispense with bigger page sizes first.
-        */
-
-       /* create memseg lists */
-       for (i = 0; i < rte_socket_count(); i++) {
-               int hp_sizes = (int) internal_config.num_hugepage_sizes;
-               uint64_t max_socket_mem, cur_socket_mem;
-               unsigned int master_lcore_socket;
-               struct rte_config *cfg = rte_eal_get_configuration();
-               bool skip;
-
-               socket_id = rte_socket_id_by_idx(i);
-
-#ifndef RTE_EAL_NUMA_AWARE_HUGEPAGES
-               if (socket_id > 0)
-                       break;
-#endif
-
-               /* if we didn't specifically request memory on this socket */
-               skip = active_sockets != 0 &&
-                               internal_config.socket_mem[socket_id] == 0;
-               /* ...or if we didn't specifically request memory on *any*
-                * socket, and this is not master lcore
+       if (unmap) {
+               munmap(mapped_addr, map_sz);
+       } else if (!no_align) {
+               void *map_end, *aligned_end;
+               size_t before_len, after_len;
+
+               /* when we reserve space with alignment, we add alignment to
+                * mapping size. On 32-bit, if 1GB alignment was requested, this
+                * would waste 1GB of address space, which is a luxury we cannot
+                * afford. so, if alignment was performed, check if any unneeded
+                * address space can be unmapped back.
                 */
-               master_lcore_socket = rte_lcore_to_socket_id(cfg->master_lcore);
-               skip |= active_sockets == 0 && socket_id != master_lcore_socket;
-
-               if (skip) {
-                       RTE_LOG(DEBUG, EAL, "Will not preallocate memory on socket %u\n",
-                                       socket_id);
-                       continue;
-               }
-
-               /* max amount of memory on this socket */
-               max_socket_mem = (active_sockets != 0 ?
-                                       internal_config.socket_mem[socket_id] :
-                                       internal_config.memory) +
-                                       extra_mem_per_socket;
-               cur_socket_mem = 0;
-
-               for (hpi_idx = 0; hpi_idx < hp_sizes; hpi_idx++) {
-                       uint64_t max_pagesz_mem, cur_pagesz_mem = 0;
-                       uint64_t hugepage_sz;
-                       struct hugepage_info *hpi;
-                       int type_msl_idx, max_segs, total_segs = 0;
-
-                       hpi = &internal_config.hugepage_info[hpi_idx];
-                       hugepage_sz = hpi->hugepage_sz;
-
-                       max_segs = RTE_MAX_MEMSEG_PER_TYPE;
-                       max_pagesz_mem = max_socket_mem - cur_socket_mem;
-
-                       /* make it multiple of page size */
-                       max_pagesz_mem = RTE_ALIGN_FLOOR(max_pagesz_mem,
-                                       hugepage_sz);
-
-                       RTE_LOG(DEBUG, EAL, "Attempting to preallocate "
-                                       "%" PRIu64 "M on socket %i\n",
-                                       max_pagesz_mem >> 20, socket_id);
-
-                       type_msl_idx = 0;
-                       while (cur_pagesz_mem < max_pagesz_mem &&
-                                       total_segs < max_segs) {
-                               if (msl_idx >= RTE_MAX_MEMSEG_LISTS) {
-                                       RTE_LOG(ERR, EAL,
-                                               "No more space in memseg lists, please increase %s\n",
-                                               RTE_STR(CONFIG_RTE_MAX_MEMSEG_LISTS));
-                                       return -1;
-                               }
-
-                               msl = &mcfg->memsegs[msl_idx++];
-
-                               if (alloc_memseg_list(msl, hugepage_sz,
-                                               max_pagesz_mem, socket_id,
-                                               type_msl_idx))
-                                       return -1;
-
-                               total_segs += msl->memseg_arr.len;
-                               cur_pagesz_mem = total_segs * hugepage_sz;
-                               type_msl_idx++;
-
-                               if (alloc_va_space(msl)) {
-                                       RTE_LOG(ERR, EAL, "Cannot allocate VA space for memseg list\n");
-                                       return -1;
-                               }
-                       }
-                       cur_socket_mem += cur_pagesz_mem;
-               }
-       }
-
-       return 0;
-}
-
-static int __rte_unused
-memseg_primary_init(void)
-{
-       struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
-       int i, socket_id, hpi_idx, msl_idx = 0;
-       struct rte_memseg_list *msl;
-       uint64_t max_mem, total_mem;
-
-       /* no-huge does not need this at all */
-       if (internal_config.no_hugetlbfs)
-               return 0;
-
-       max_mem = (uint64_t)RTE_MAX_MEM_MB << 20;
-       total_mem = 0;
-
-       /* create memseg lists */
-       for (hpi_idx = 0; hpi_idx < (int) internal_config.num_hugepage_sizes;
-                       hpi_idx++) {
-               struct hugepage_info *hpi;
-               uint64_t hugepage_sz;
-
-               hpi = &internal_config.hugepage_info[hpi_idx];
-               hugepage_sz = hpi->hugepage_sz;
-
-               for (i = 0; i < (int) rte_socket_count(); i++) {
-                       uint64_t max_type_mem, total_type_mem = 0;
-                       int type_msl_idx, max_segs, total_segs = 0;
-
-                       socket_id = rte_socket_id_by_idx(i);
-
-#ifndef RTE_EAL_NUMA_AWARE_HUGEPAGES
-                       if (socket_id > 0)
-                               break;
-#endif
-
-                       max_type_mem = RTE_MIN(max_mem - total_mem,
-                               (uint64_t)RTE_MAX_MEM_MB_PER_TYPE << 20);
-                       max_segs = RTE_MAX_MEMSEG_PER_TYPE;
-
-                       type_msl_idx = 0;
-                       while (total_type_mem < max_type_mem &&
-                                       total_segs < max_segs) {
-                               uint64_t cur_max_mem;
-                               if (msl_idx >= RTE_MAX_MEMSEG_LISTS) {
-                                       RTE_LOG(ERR, EAL,
-                                               "No more space in memseg lists, please increase %s\n",
-                                               RTE_STR(CONFIG_RTE_MAX_MEMSEG_LISTS));
-                                       return -1;
-                               }
-
-                               msl = &mcfg->memsegs[msl_idx++];
-
-                               cur_max_mem = max_type_mem - total_type_mem;
-                               if (alloc_memseg_list(msl, hugepage_sz,
-                                               cur_max_mem, socket_id,
-                                               type_msl_idx))
-                                       return -1;
-
-                               total_segs += msl->memseg_arr.len;
-                               total_type_mem = total_segs * hugepage_sz;
-                               type_msl_idx++;
-
-                               if (alloc_va_space(msl)) {
-                                       RTE_LOG(ERR, EAL, "Cannot allocate VA space for memseg list\n");
-                                       return -1;
-                               }
-                       }
-                       total_mem += total_type_mem;
-               }
-       }
-       return 0;
-}
-
-static int
-memseg_secondary_init(void)
-{
-       struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
-       int msl_idx = 0;
-       struct rte_memseg_list *msl;
-
-       for (msl_idx = 0; msl_idx < RTE_MAX_MEMSEG_LISTS; msl_idx++) {
 
-               msl = &mcfg->memsegs[msl_idx];
+               map_end = RTE_PTR_ADD(mapped_addr, (size_t)map_sz);
+               aligned_end = RTE_PTR_ADD(aligned_addr, *size);
 
-               /* skip empty memseg lists */
-               if (msl->memseg_arr.len == 0)
-                       continue;
+               /* unmap space before aligned mmap address */
+               before_len = RTE_PTR_DIFF(aligned_addr, mapped_addr);
+               if (before_len > 0)
+                       munmap(mapped_addr, before_len);
 
-               if (rte_fbarray_attach(&msl->memseg_arr)) {
-                       RTE_LOG(ERR, EAL, "Cannot attach to primary process memseg lists\n");
-                       return -1;
-               }
-
-               /* preallocate VA space */
-               if (alloc_va_space(msl)) {
-                       RTE_LOG(ERR, EAL, "Cannot preallocate VA space for hugepage memory\n");
-                       return -1;
-               }
+               /* unmap space after aligned end mmap address */
+               after_len = RTE_PTR_DIFF(map_end, aligned_end);
+               if (after_len > 0)
+                       munmap(aligned_end, after_len);
        }
 
-       return 0;
+       return aligned_addr;
 }
 
 static struct rte_memseg *
@@ -472,6 +163,9 @@ virt2memseg(const void *addr, const struct rte_memseg_list *msl)
        void *start, *end;
        int ms_idx;
 
+       if (msl == NULL)
+               return NULL;
+
        /* a memseg list was specified, check if it's the right one */
        start = msl->base_va;
        end = RTE_PTR_ADD(start, (size_t)msl->page_sz * msl->memseg_arr.len);
@@ -629,7 +323,8 @@ dump_memseg(const struct rte_memseg_list *msl, const struct rte_memseg *ms,
  * is in eal_common_memalloc.c, like all other memalloc internals.
  */
 int __rte_experimental
-rte_mem_event_callback_register(const char *name, rte_mem_event_callback_t clb)
+rte_mem_event_callback_register(const char *name, rte_mem_event_callback_t clb,
+               void *arg)
 {
        /* FreeBSD boots with legacy mem enabled by default */
        if (internal_config.legacy_mem) {
@@ -637,11 +332,11 @@ rte_mem_event_callback_register(const char *name, rte_mem_event_callback_t clb)
                rte_errno = ENOTSUP;
                return -1;
        }
-       return eal_memalloc_mem_event_callback_register(name, clb);
+       return eal_memalloc_mem_event_callback_register(name, clb, arg);
 }
 
 int __rte_experimental
-rte_mem_event_callback_unregister(const char *name)
+rte_mem_event_callback_unregister(const char *name, void *arg)
 {
        /* FreeBSD boots with legacy mem enabled by default */
        if (internal_config.legacy_mem) {
@@ -649,7 +344,33 @@ rte_mem_event_callback_unregister(const char *name)
                rte_errno = ENOTSUP;
                return -1;
        }
-       return eal_memalloc_mem_event_callback_unregister(name);
+       return eal_memalloc_mem_event_callback_unregister(name, arg);
+}
+
+int __rte_experimental
+rte_mem_alloc_validator_register(const char *name,
+               rte_mem_alloc_validator_t clb, int socket_id, size_t limit)
+{
+       /* FreeBSD boots with legacy mem enabled by default */
+       if (internal_config.legacy_mem) {
+               RTE_LOG(DEBUG, EAL, "Registering mem alloc validators not supported\n");
+               rte_errno = ENOTSUP;
+               return -1;
+       }
+       return eal_memalloc_mem_alloc_validator_register(name, clb, socket_id,
+                       limit);
+}
+
+int __rte_experimental
+rte_mem_alloc_validator_unregister(const char *name, int socket_id)
+{
+       /* FreeBSD boots with legacy mem enabled by default */
+       if (internal_config.legacy_mem) {
+               RTE_LOG(DEBUG, EAL, "Registering mem alloc validators not supported\n");
+               rte_errno = ENOTSUP;
+               return -1;
+       }
+       return eal_memalloc_mem_alloc_validator_unregister(name, socket_id);
 }
 
 /* Dump the physical memory layout on console */
@@ -697,14 +418,11 @@ rte_mem_lock_page(const void *virt)
 }
 
 int __rte_experimental
-rte_memseg_contig_walk(rte_memseg_contig_walk_t func, void *arg)
+rte_memseg_contig_walk_thread_unsafe(rte_memseg_contig_walk_t func, void *arg)
 {
        struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
        int i, ms_idx, ret = 0;
 
-       /* do not allow allocations/frees/init while we iterate */
-       rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
-
        for (i = 0; i < RTE_MAX_MEMSEG_LISTS; i++) {
                struct rte_memseg_list *msl = &mcfg->memsegs[i];
                const struct rte_memseg *ms;
@@ -729,30 +447,34 @@ rte_memseg_contig_walk(rte_memseg_contig_walk_t func, void *arg)
                        len = n_segs * msl->page_sz;
 
                        ret = func(msl, ms, len, arg);
-                       if (ret < 0) {
-                               ret = -1;
-                               goto out;
-                       } else if (ret > 0) {
-                               ret = 1;
-                               goto out;
-                       }
+                       if (ret)
+                               return ret;
                        ms_idx = rte_fbarray_find_next_used(arr,
                                        ms_idx + n_segs);
                }
        }
-out:
-       rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
-       return ret;
+       return 0;
 }
 
 int __rte_experimental
-rte_memseg_walk(rte_memseg_walk_t func, void *arg)
+rte_memseg_contig_walk(rte_memseg_contig_walk_t func, void *arg)
 {
        struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
-       int i, ms_idx, ret = 0;
+       int ret = 0;
 
        /* do not allow allocations/frees/init while we iterate */
        rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
+       ret = rte_memseg_contig_walk_thread_unsafe(func, arg);
+       rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
+
+       return ret;
+}
+
+int __rte_experimental
+rte_memseg_walk_thread_unsafe(rte_memseg_walk_t func, void *arg)
+{
+       struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
+       int i, ms_idx, ret = 0;
 
        for (i = 0; i < RTE_MAX_MEMSEG_LISTS; i++) {
                struct rte_memseg_list *msl = &mcfg->memsegs[i];
@@ -768,29 +490,33 @@ rte_memseg_walk(rte_memseg_walk_t func, void *arg)
                while (ms_idx >= 0) {
                        ms = rte_fbarray_get(arr, ms_idx);
                        ret = func(msl, ms, arg);
-                       if (ret < 0) {
-                               ret = -1;
-                               goto out;
-                       } else if (ret > 0) {
-                               ret = 1;
-                               goto out;
-                       }
+                       if (ret)
+                               return ret;
                        ms_idx = rte_fbarray_find_next_used(arr, ms_idx + 1);
                }
        }
-out:
-       rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
-       return ret;
+       return 0;
 }
 
 int __rte_experimental
-rte_memseg_list_walk(rte_memseg_list_walk_t func, void *arg)
+rte_memseg_walk(rte_memseg_walk_t func, void *arg)
 {
        struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
-       int i, ret = 0;
+       int ret = 0;
 
        /* do not allow allocations/frees/init while we iterate */
        rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
+       ret = rte_memseg_walk_thread_unsafe(func, arg);
+       rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
+
+       return ret;
+}
+
+int __rte_experimental
+rte_memseg_list_walk_thread_unsafe(rte_memseg_list_walk_t func, void *arg)
+{
+       struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
+       int i, ret = 0;
 
        for (i = 0; i < RTE_MAX_MEMSEG_LISTS; i++) {
                struct rte_memseg_list *msl = &mcfg->memsegs[i];
@@ -799,17 +525,23 @@ rte_memseg_list_walk(rte_memseg_list_walk_t func, void *arg)
                        continue;
 
                ret = func(msl, arg);
-               if (ret < 0) {
-                       ret = -1;
-                       goto out;
-               }
-               if (ret > 0) {
-                       ret = 1;
-                       goto out;
-               }
+               if (ret)
+                       return ret;
        }
-out:
+       return 0;
+}
+
+int __rte_experimental
+rte_memseg_list_walk(rte_memseg_list_walk_t func, void *arg)
+{
+       struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
+       int ret = 0;
+
+       /* do not allow allocations/frees/init while we iterate */
+       rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
+       ret = rte_memseg_list_walk_thread_unsafe(func, arg);
        rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
+
        return ret;
 }
 
@@ -827,15 +559,10 @@ rte_eal_memory_init(void)
        /* lock mem hotplug here, to prevent races while we init */
        rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
 
-       retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
-#ifndef RTE_ARCH_64
-                       memseg_primary_init_32() :
-#else
-                       memseg_primary_init() :
-#endif
-                       memseg_secondary_init();
+       if (rte_eal_memseg_init() < 0)
+               goto fail;
 
-       if (retval < 0)
+       if (eal_memalloc_init() < 0)
                goto fail;
 
        retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?