eal/bsd: rename bsdapp to freebsd
[dpdk.git] / lib / librte_eal / linuxapp / eal / eal_hugepage_info.c
index fb4b667..0eab1cf 100644 (file)
@@ -6,6 +6,7 @@
 #include <sys/types.h>
 #include <sys/file.h>
 #include <dirent.h>
+#include <fcntl.h>
 #include <stdint.h>
 #include <stdlib.h>
 #include <stdio.h>
@@ -18,6 +19,8 @@
 #include <sys/queue.h>
 #include <sys/stat.h>
 
+#include <linux/mman.h> /* for hugetlb-related flags */
+
 #include <rte_memory.h>
 #include <rte_eal.h>
 #include <rte_launch.h>
@@ -169,8 +172,8 @@ get_default_hp_size(void)
        return size;
 }
 
-static const char *
-get_hugepage_dir(uint64_t hugepage_sz)
+static int
+get_hugepage_dir(uint64_t hugepage_sz, char *hugedir, int len)
 {
        enum proc_mount_fieldnames {
                DEVICE = 0,
@@ -188,7 +191,7 @@ get_hugepage_dir(uint64_t hugepage_sz)
        const char split_tok = ' ';
        char *splitstr[_FIELDNAME_MAX];
        char buf[BUFSIZ];
-       char *retval = NULL;
+       int retval = -1;
 
        FILE *fd = fopen(proc_mounts, "r");
        if (fd == NULL)
@@ -215,7 +218,8 @@ get_hugepage_dir(uint64_t hugepage_sz)
                        /* if no explicit page size, the default page size is compared */
                        if (pagesz_str == NULL){
                                if (hugepage_sz == default_size){
-                                       retval = strdup(splitstr[MOUNTPT]);
+                                       strlcpy(hugedir, splitstr[MOUNTPT], len);
+                                       retval = 0;
                                        break;
                                }
                        }
@@ -223,7 +227,8 @@ get_hugepage_dir(uint64_t hugepage_sz)
                        else {
                                uint64_t pagesz = rte_str_to_size(&pagesz_str[pagesize_opt_len]);
                                if (pagesz == hugepage_sz) {
-                                       retval = strdup(splitstr[MOUNTPT]);
+                                       strlcpy(hugedir, splitstr[MOUNTPT], len);
+                                       retval = 0;
                                        break;
                                }
                        }
@@ -234,18 +239,6 @@ get_hugepage_dir(uint64_t hugepage_sz)
        return retval;
 }
 
-/*
- * uses fstat to report the size of a file on disk
- */
-static off_t
-get_file_size(int fd)
-{
-       struct stat st;
-       if (fstat(fd, &st) < 0)
-               return 0;
-       return st.st_size;
-}
-
 /*
  * Clear the hugepage directory of whatever hugepage files
  * there are. Checks if the file is locked (i.e.
@@ -276,8 +269,6 @@ clear_hugedir(const char * hugedir)
        }
 
        while(dirent != NULL){
-               struct flock lck = {0};
-
                /* skip files that don't match the hugepage pattern */
                if (fnmatch(filter, dirent->d_name, 0) > 0) {
                        dirent = readdir(dir);
@@ -294,19 +285,11 @@ clear_hugedir(const char * hugedir)
                }
 
                /* non-blocking lock */
-               lck.l_type = F_RDLCK;
-               lck.l_whence = SEEK_SET;
-               lck.l_start = 0;
-               lck.l_len = get_file_size(fd);
-
-               lck_result = fcntl(fd, F_SETLK, &lck);
+               lck_result = flock(fd, LOCK_EX | LOCK_NB);
 
-               /* if lock succeeds, unlock and remove the file */
-               if (lck_result != -1) {
-                       lck.l_type = F_UNLCK;
-                       fcntl(fd, F_SETLK, &lck);
+               /* if lock succeeds, remove the file */
+               if (lck_result != -1)
                        unlinkat(dir_fd, dirent->d_name, 0);
-               }
                close (fd);
                dirent = readdir(dir);
        }
@@ -333,11 +316,49 @@ compare_hpi(const void *a, const void *b)
        return hpi_b->hugepage_sz - hpi_a->hugepage_sz;
 }
 
+static void
+calc_num_pages(struct hugepage_info *hpi, struct dirent *dirent)
+{
+       uint64_t total_pages = 0;
+       unsigned int i;
+
+       /*
+        * first, try to put all hugepages into relevant sockets, but
+        * if first attempts fails, fall back to collecting all pages
+        * in one socket and sorting them later
+        */
+       total_pages = 0;
+       /* we also don't want to do this for legacy init */
+       if (!internal_config.legacy_mem)
+               for (i = 0; i < rte_socket_count(); i++) {
+                       int socket = rte_socket_id_by_idx(i);
+                       unsigned int num_pages =
+                                       get_num_hugepages_on_node(
+                                               dirent->d_name, socket);
+                       hpi->num_pages[socket] = num_pages;
+                       total_pages += num_pages;
+               }
+       /*
+        * we failed to sort memory from the get go, so fall
+        * back to old way
+        */
+       if (total_pages == 0) {
+               hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
+
+#ifndef RTE_ARCH_64
+               /* for 32-bit systems, limit number of hugepages to
+                * 1GB per page size */
+               hpi->num_pages[0] = RTE_MIN(hpi->num_pages[0],
+                               RTE_PGSIZE_1G / hpi->hugepage_sz);
+#endif
+       }
+}
+
 static int
 hugepage_info_init(void)
 {      const char dirent_start_text[] = "hugepages-";
        const size_t dirent_start_len = sizeof(dirent_start_text) - 1;
-       unsigned int i, total_pages, num_sizes = 0;
+       unsigned int i, num_sizes = 0;
        DIR *dir;
        struct dirent *dirent;
 
@@ -351,7 +372,6 @@ hugepage_info_init(void)
 
        for (dirent = readdir(dir); dirent != NULL; dirent = readdir(dir)) {
                struct hugepage_info *hpi;
-               const char *hugedir;
 
                if (strncmp(dirent->d_name, dirent_start_text,
                            dirent_start_len) != 0)
@@ -363,10 +383,10 @@ hugepage_info_init(void)
                hpi = &internal_config.hugepage_info[num_sizes];
                hpi->hugepage_sz =
                        rte_str_to_size(&dirent->d_name[dirent_start_len]);
-               hugedir = get_hugepage_dir(hpi->hugepage_sz);
 
                /* first, check if we have a mountpoint */
-               if (hugedir == NULL) {
+               if (get_hugepage_dir(hpi->hugepage_sz,
+                       hpi->hugedir, sizeof(hpi->hugedir)) < 0) {
                        uint32_t num_pages;
 
                        num_pages = get_num_hugepages(dirent->d_name);
@@ -376,9 +396,24 @@ hugepage_info_init(void)
                                        "%" PRIu64 " reserved, but no mounted "
                                        "hugetlbfs found for that size\n",
                                        num_pages, hpi->hugepage_sz);
+                       /* if we have kernel support for reserving hugepages
+                        * through mmap, and we're in in-memory mode, treat this
+                        * page size as valid. we cannot be in legacy mode at
+                        * this point because we've checked this earlier in the
+                        * init process.
+                        */
+#ifdef MAP_HUGE_SHIFT
+                       if (internal_config.in_memory) {
+                               RTE_LOG(DEBUG, EAL, "In-memory mode enabled, "
+                                       "hugepages of size %" PRIu64 " bytes "
+                                       "will be allocated anonymously\n",
+                                       hpi->hugepage_sz);
+                               calc_num_pages(hpi, dirent);
+                               num_sizes++;
+                       }
+#endif
                        continue;
                }
-               snprintf(hpi->hugedir, sizeof(hpi->hugedir), "%s", hugedir);
 
                /* try to obtain a writelock */
                hpi->lock_descriptor = open(hpi->hugedir, O_RDONLY);
@@ -393,35 +428,7 @@ hugepage_info_init(void)
                if (clear_hugedir(hpi->hugedir) == -1)
                        break;
 
-               /*
-                * first, try to put all hugepages into relevant sockets, but
-                * if first attempts fails, fall back to collecting all pages
-                * in one socket and sorting them later
-                */
-               total_pages = 0;
-               /* we also don't want to do this for legacy init */
-               if (!internal_config.legacy_mem)
-                       for (i = 0; i < rte_socket_count(); i++) {
-                               int socket = rte_socket_id_by_idx(i);
-                               unsigned int num_pages =
-                                               get_num_hugepages_on_node(
-                                                       dirent->d_name, socket);
-                               hpi->num_pages[socket] = num_pages;
-                               total_pages += num_pages;
-                       }
-               /*
-                * we failed to sort memory from the get go, so fall
-                * back to old way
-                */
-               if (total_pages == 0)
-                       hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
-
-#ifndef RTE_ARCH_64
-               /* for 32-bit systems, limit number of hugepages to
-                * 1GB per page size */
-               hpi->num_pages[0] = RTE_MIN(hpi->num_pages[0],
-                                           RTE_PGSIZE_1G / hpi->hugepage_sz);
-#endif
+               calc_num_pages(hpi, dirent);
 
                num_sizes++;
        }
@@ -445,8 +452,7 @@ hugepage_info_init(void)
 
                for (j = 0; j < RTE_MAX_NUMA_NODES; j++)
                        num_pages += hpi->num_pages[j];
-               if (strnlen(hpi->hugedir, sizeof(hpi->hugedir)) != 0 &&
-                               num_pages > 0)
+               if (num_pages > 0)
                        return 0;
        }
 
@@ -468,6 +474,10 @@ eal_hugepage_info_init(void)
        if (hugepage_info_init() < 0)
                return -1;
 
+       /* for no shared files mode, we're done */
+       if (internal_config.no_shconf)
+               return 0;
+
        hpi = &internal_config.hugepage_info[0];
 
        tmp_hpi = create_shared_memory(eal_hugepage_info_path(),