ethdev: support dynamic logging
[dpdk.git] / lib / librte_ether / rte_ethdev.c
index 0590f0c..2f458cd 100644 (file)
 #include <rte_errno.h>
 #include <rte_spinlock.h>
 #include <rte_string_fns.h>
-#include <rte_compat.h>
 
 #include "rte_ether.h"
 #include "rte_ethdev.h"
 #include "rte_ethdev_driver.h"
 #include "ethdev_profile.h"
 
+static int ethdev_logtype;
+
+#define ethdev_log(level, fmt, ...) \
+       rte_log(RTE_LOG_ ## level, ethdev_logtype, fmt "\n", ## __VA_ARGS__)
+
 static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
 struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
 static uint8_t eth_dev_last_created_port;
@@ -277,13 +281,14 @@ rte_eth_dev_allocate(const char *name)
 
        port_id = rte_eth_dev_find_free_port();
        if (port_id == RTE_MAX_ETHPORTS) {
-               RTE_LOG(ERR, EAL, "Reached maximum number of Ethernet ports\n");
+               ethdev_log(ERR, "Reached maximum number of Ethernet ports");
                goto unlock;
        }
 
        if (rte_eth_dev_allocated(name) != NULL) {
-               RTE_LOG(ERR, EAL, "Ethernet Device with name %s already allocated!\n",
-                               name);
+               ethdev_log(ERR,
+                       "Ethernet Device with name %s already allocated!",
+                       name);
                goto unlock;
        }
 
@@ -521,7 +526,7 @@ rte_eth_dev_socket_id(uint16_t port_id)
 }
 
 void *
-rte_eth_dev_get_sec_ctx(uint8_t port_id)
+rte_eth_dev_get_sec_ctx(uint16_t port_id)
 {
        RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, NULL);
        return rte_eth_devices[port_id].security_ctx;
@@ -572,8 +577,7 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id)
 
        for (pid = 0; pid < RTE_MAX_ETHPORTS; pid++) {
                if (rte_eth_devices[pid].state != RTE_ETH_DEV_UNUSED &&
-                   !strncmp(name, rte_eth_dev_shared_data->data[pid].name,
-                            strlen(name))) {
+                   !strcmp(name, rte_eth_dev_shared_data->data[pid].name)) {
                        *port_id = pid;
                        return 0;
                }
@@ -616,7 +620,7 @@ rte_eth_dev_attach(const char *devargs, uint16_t *port_id)
 
        /* no point looking at the port count if no port exists */
        if (!rte_eth_dev_count()) {
-               RTE_LOG(ERR, EAL, "No port found for device (%s)\n", name);
+               ethdev_log(ERR, "No port found for device (%s)", name);
                ret = -1;
                goto err;
        }
@@ -654,8 +658,8 @@ rte_eth_dev_detach(uint16_t port_id, char *name)
 
        dev_flags = rte_eth_devices[port_id].data->dev_flags;
        if (dev_flags & RTE_ETH_DEV_BONDED_SLAVE) {
-               RTE_LOG(ERR, EAL, "Port %" PRIu16 " is bonded, cannot detach\n",
-                       port_id);
+               ethdev_log(ERR,
+                       "Port %" PRIu16 " is bonded, cannot detach", port_id);
                ret = -ENOTSUP;
                goto err;
        }
@@ -1765,20 +1769,6 @@ rte_eth_allmulticast_get(uint16_t port_id)
        return dev->data->all_multicast;
 }
 
-static inline int
-rte_eth_dev_atomic_read_link_status(struct rte_eth_dev *dev,
-                               struct rte_eth_link *link)
-{
-       struct rte_eth_link *dst = link;
-       struct rte_eth_link *src = &(dev->data->dev_link);
-
-       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
-                                       *(uint64_t *)src) == 0)
-               return -1;
-
-       return 0;
-}
-
 void
 rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)
 {
@@ -1787,8 +1777,8 @@ rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)
        RTE_ETH_VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
-       if (dev->data->dev_conf.intr_conf.lsc != 0)
-               rte_eth_dev_atomic_read_link_status(dev, eth_link);
+       if (dev->data->dev_conf.intr_conf.lsc)
+               rte_eth_linkstatus_get(dev, eth_link);
        else {
                RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);
                (*dev->dev_ops->link_update)(dev, 1);
@@ -1804,8 +1794,8 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)
        RTE_ETH_VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
-       if (dev->data->dev_conf.intr_conf.lsc != 0)
-               rte_eth_dev_atomic_read_link_status(dev, eth_link);
+       if (dev->data->dev_conf.intr_conf.lsc)
+               rte_eth_linkstatus_get(dev, eth_link);
        else {
                RTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);
                (*dev->dev_ops->link_update)(dev, 0);
@@ -3216,7 +3206,7 @@ rte_eth_dev_callback_register(uint16_t port_id,
                return -EINVAL;
 
        if (!rte_eth_dev_is_valid_port(port_id) && port_id != RTE_ETH_ALL) {
-               RTE_LOG(ERR, EAL, "Invalid port_id=%d\n", port_id);
+               ethdev_log(ERR, "Invalid port_id=%d", port_id);
                return -EINVAL;
        }
 
@@ -3279,7 +3269,7 @@ rte_eth_dev_callback_unregister(uint16_t port_id,
                return -EINVAL;
 
        if (!rte_eth_dev_is_valid_port(port_id) && port_id != RTE_ETH_ALL) {
-               RTE_LOG(ERR, EAL, "Invalid port_id=%d\n", port_id);
+               ethdev_log(ERR, "Invalid port_id=%d", port_id);
                return -EINVAL;
        }
 
@@ -3490,153 +3480,8 @@ rte_eth_dev_filter_supported(uint16_t port_id,
 }
 
 int
-rte_eth_dev_filter_ctrl_v22(uint16_t port_id,
-                           enum rte_filter_type filter_type,
-                           enum rte_filter_op filter_op, void *arg);
-
-int
-rte_eth_dev_filter_ctrl_v22(uint16_t port_id,
-                           enum rte_filter_type filter_type,
-                           enum rte_filter_op filter_op, void *arg)
-{
-       struct rte_eth_fdir_info_v22 {
-               enum rte_fdir_mode mode;
-               struct rte_eth_fdir_masks mask;
-               struct rte_eth_fdir_flex_conf flex_conf;
-               uint32_t guarant_spc;
-               uint32_t best_spc;
-               uint32_t flow_types_mask[1];
-               uint32_t max_flexpayload;
-               uint32_t flex_payload_unit;
-               uint32_t max_flex_payload_segment_num;
-               uint16_t flex_payload_limit;
-               uint32_t flex_bitmask_unit;
-               uint32_t max_flex_bitmask_num;
-       };
-
-       struct rte_eth_hash_global_conf_v22 {
-               enum rte_eth_hash_function hash_func;
-               uint32_t sym_hash_enable_mask[1];
-               uint32_t valid_bit_mask[1];
-       };
-
-       struct rte_eth_hash_filter_info_v22 {
-               enum rte_eth_hash_filter_info_type info_type;
-               union {
-                       uint8_t enable;
-                       struct rte_eth_hash_global_conf_v22 global_conf;
-                       struct rte_eth_input_set_conf input_set_conf;
-               } info;
-       };
-
-       struct rte_eth_dev *dev;
-
-       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-
-       dev = &rte_eth_devices[port_id];
-       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->filter_ctrl, -ENOTSUP);
-       if (filter_op == RTE_ETH_FILTER_INFO) {
-               int retval;
-               struct rte_eth_fdir_info_v22 *fdir_info_v22;
-               struct rte_eth_fdir_info fdir_info;
-
-               fdir_info_v22 = (struct rte_eth_fdir_info_v22 *)arg;
-
-               retval = (*dev->dev_ops->filter_ctrl)(dev, filter_type,
-                         filter_op, (void *)&fdir_info);
-               fdir_info_v22->mode = fdir_info.mode;
-               fdir_info_v22->mask = fdir_info.mask;
-               fdir_info_v22->flex_conf = fdir_info.flex_conf;
-               fdir_info_v22->guarant_spc = fdir_info.guarant_spc;
-               fdir_info_v22->best_spc = fdir_info.best_spc;
-               fdir_info_v22->flow_types_mask[0] =
-                       (uint32_t)fdir_info.flow_types_mask[0];
-               fdir_info_v22->max_flexpayload = fdir_info.max_flexpayload;
-               fdir_info_v22->flex_payload_unit = fdir_info.flex_payload_unit;
-               fdir_info_v22->max_flex_payload_segment_num =
-                       fdir_info.max_flex_payload_segment_num;
-               fdir_info_v22->flex_payload_limit =
-                       fdir_info.flex_payload_limit;
-               fdir_info_v22->flex_bitmask_unit = fdir_info.flex_bitmask_unit;
-               fdir_info_v22->max_flex_bitmask_num =
-                       fdir_info.max_flex_bitmask_num;
-               return retval;
-       } else if (filter_op == RTE_ETH_FILTER_GET) {
-               int retval;
-               struct rte_eth_hash_filter_info f_info;
-               struct rte_eth_hash_filter_info_v22 *f_info_v22 =
-                       (struct rte_eth_hash_filter_info_v22 *)arg;
-
-               f_info.info_type = f_info_v22->info_type;
-               retval = (*dev->dev_ops->filter_ctrl)(dev, filter_type,
-                         filter_op, (void *)&f_info);
-
-               switch (f_info_v22->info_type) {
-               case RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT:
-                       f_info_v22->info.enable = f_info.info.enable;
-                       break;
-               case RTE_ETH_HASH_FILTER_GLOBAL_CONFIG:
-                       f_info_v22->info.global_conf.hash_func =
-                               f_info.info.global_conf.hash_func;
-                       f_info_v22->info.global_conf.sym_hash_enable_mask[0] =
-                               (uint32_t)
-                               f_info.info.global_conf.sym_hash_enable_mask[0];
-                       f_info_v22->info.global_conf.valid_bit_mask[0] =
-                               (uint32_t)
-                               f_info.info.global_conf.valid_bit_mask[0];
-                       break;
-               case RTE_ETH_HASH_FILTER_INPUT_SET_SELECT:
-                       f_info_v22->info.input_set_conf =
-                               f_info.info.input_set_conf;
-                       break;
-               default:
-                       break;
-               }
-               return retval;
-       } else if (filter_op == RTE_ETH_FILTER_SET) {
-               struct rte_eth_hash_filter_info f_info;
-               struct rte_eth_hash_filter_info_v22 *f_v22 =
-                       (struct rte_eth_hash_filter_info_v22 *)arg;
-
-               f_info.info_type = f_v22->info_type;
-               switch (f_v22->info_type) {
-               case RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT:
-                       f_info.info.enable = f_v22->info.enable;
-                       break;
-               case RTE_ETH_HASH_FILTER_GLOBAL_CONFIG:
-                       f_info.info.global_conf.hash_func =
-                               f_v22->info.global_conf.hash_func;
-                       f_info.info.global_conf.sym_hash_enable_mask[0] =
-                               (uint32_t)
-                               f_v22->info.global_conf.sym_hash_enable_mask[0];
-                       f_info.info.global_conf.valid_bit_mask[0] =
-                               (uint32_t)
-                               f_v22->info.global_conf.valid_bit_mask[0];
-                       break;
-               case RTE_ETH_HASH_FILTER_INPUT_SET_SELECT:
-                       f_info.info.input_set_conf =
-                               f_v22->info.input_set_conf;
-                       break;
-               default:
-                       break;
-               }
-               return (*dev->dev_ops->filter_ctrl)(dev, filter_type, filter_op,
-                                                   (void *)&f_info);
-       } else
-               return (*dev->dev_ops->filter_ctrl)(dev, filter_type, filter_op,
-                                                   arg);
-}
-VERSION_SYMBOL(rte_eth_dev_filter_ctrl, _v22, 2.2);
-
-int
-rte_eth_dev_filter_ctrl_v1802(uint16_t port_id,
-                             enum rte_filter_type filter_type,
-                             enum rte_filter_op filter_op, void *arg);
-
-int
-rte_eth_dev_filter_ctrl_v1802(uint16_t port_id,
-                             enum rte_filter_type filter_type,
-                             enum rte_filter_op filter_op, void *arg)
+rte_eth_dev_filter_ctrl(uint16_t port_id, enum rte_filter_type filter_type,
+                       enum rte_filter_op filter_op, void *arg)
 {
        struct rte_eth_dev *dev;
 
@@ -3647,11 +3492,6 @@ rte_eth_dev_filter_ctrl_v1802(uint16_t port_id,
        return eth_err(port_id, (*dev->dev_ops->filter_ctrl)(dev, filter_type,
                                                             filter_op, arg));
 }
-BIND_DEFAULT_SYMBOL(rte_eth_dev_filter_ctrl, _v1802, 18.02);
-MAP_STATIC_SYMBOL(int rte_eth_dev_filter_ctrl(uint16_t port_id,
-                 enum rte_filter_type filter_type,
-                 enum rte_filter_op filter_op, void *arg),
-                 rte_eth_dev_filter_ctrl_v1802);
 
 void *
 rte_eth_add_rx_callback(uint16_t port_id, uint16_t queue_id,
@@ -4168,3 +4008,12 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const char *pool)
 
        return (*dev->dev_ops->pool_ops_supported)(dev, pool);
 }
+
+RTE_INIT(ethdev_init_log);
+static void
+ethdev_init_log(void)
+{
+       ethdev_logtype = rte_log_register("lib.ethdev");
+       if (ethdev_logtype >= 0)
+               rte_log_set_level(ethdev_logtype, RTE_LOG_INFO);
+}