ethdev: add API to retrieve queue information
[dpdk.git] / lib / librte_ether / rte_ethdev.c
index b69a753..39f65bf 100644 (file)
@@ -1,7 +1,7 @@
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
  *   All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
@@ -52,7 +52,6 @@
 #include <rte_memcpy.h>
 #include <rte_memzone.h>
 #include <rte_launch.h>
-#include <rte_tailq.h>
 #include <rte_eal.h>
 #include <rte_per_lcore.h>
 #include <rte_lcore.h>
                PMD_DEBUG_TRACE("Cannot run in secondary processes\n"); \
                return (retval); \
        } \
-} while(0)
+} while (0)
+
 #define PROC_PRIMARY_OR_RET() do { \
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) { \
                PMD_DEBUG_TRACE("Cannot run in secondary processes\n"); \
                return; \
        } \
-} while(0)
+} while (0)
 
-/* Macros to check for invlaid function pointers in dev_ops structure */
+/* Macros to check for invalid function pointers in dev_ops structure */
 #define FUNC_PTR_OR_ERR_RET(func, retval) do { \
        if ((func) == NULL) { \
                PMD_DEBUG_TRACE("Function not supported\n"); \
                return (retval); \
        } \
-} while(0)
+} while (0)
+
 #define FUNC_PTR_OR_RET(func) do { \
        if ((func) == NULL) { \
                PMD_DEBUG_TRACE("Function not supported\n"); \
                return; \
        } \
-} while(0)
+} while (0)
+
+/* Macros to check for valid port */
+#define VALID_PORTID_OR_ERR_RET(port_id, retval) do {          \
+       if (!rte_eth_dev_is_valid_port(port_id)) {              \
+               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); \
+               return retval;                                  \
+       }                                                       \
+} while (0)
+
+#define VALID_PORTID_OR_RET(port_id) do {                      \
+       if (!rte_eth_dev_is_valid_port(port_id)) {              \
+               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); \
+               return;                                         \
+       }                                                       \
+} while (0)
 
 static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
 struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
-static struct rte_eth_dev_data *rte_eth_dev_data = NULL;
-static uint8_t nb_ports = 0;
+static struct rte_eth_dev_data *rte_eth_dev_data;
+static uint8_t nb_ports;
 
 /* spinlock for eth device callbacks */
 static rte_spinlock_t rte_eth_dev_cb_lock = RTE_SPINLOCK_INITIALIZER;
@@ -120,34 +136,25 @@ struct rte_eth_xstats_name_off {
        unsigned offset;
 };
 
-static struct rte_eth_xstats_name_off rte_stats_strings[] = {
-        {"rx_packets", offsetof(struct rte_eth_stats, ipackets)},
-        {"tx_packets", offsetof(struct rte_eth_stats, opackets)},
-        {"rx_bytes", offsetof(struct rte_eth_stats, ibytes)},
-        {"tx_bytes", offsetof(struct rte_eth_stats, obytes)},
-        {"tx_errors", offsetof(struct rte_eth_stats, oerrors)},
-        {"rx_missed_errors", offsetof(struct rte_eth_stats, imissed)},
-        {"rx_crc_errors", offsetof(struct rte_eth_stats, ibadcrc)},
-        {"rx_bad_length_errors", offsetof(struct rte_eth_stats, ibadlen)},
-        {"rx_errors", offsetof(struct rte_eth_stats, ierrors)},
-        {"alloc_rx_buff_failed", offsetof(struct rte_eth_stats, rx_nombuf)},
-        {"fdir_match", offsetof(struct rte_eth_stats, fdirmatch)},
-        {"fdir_miss", offsetof(struct rte_eth_stats, fdirmiss)},
-        {"tx_flow_control_xon", offsetof(struct rte_eth_stats, tx_pause_xon)},
-        {"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)},
-        {"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)},
-        {"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)},
+static const struct rte_eth_xstats_name_off rte_stats_strings[] = {
+       {"rx_packets", offsetof(struct rte_eth_stats, ipackets)},
+       {"tx_packets", offsetof(struct rte_eth_stats, opackets)},
+       {"rx_bytes", offsetof(struct rte_eth_stats, ibytes)},
+       {"tx_bytes", offsetof(struct rte_eth_stats, obytes)},
+       {"tx_errors", offsetof(struct rte_eth_stats, oerrors)},
+       {"rx_errors", offsetof(struct rte_eth_stats, ierrors)},
+       {"alloc_rx_buff_failed", offsetof(struct rte_eth_stats, rx_nombuf)},
 };
 #define RTE_NB_STATS (sizeof(rte_stats_strings) / sizeof(rte_stats_strings[0]))
 
-static struct rte_eth_xstats_name_off rte_rxq_stats_strings[] = {
+static const struct rte_eth_xstats_name_off rte_rxq_stats_strings[] = {
        {"rx_packets", offsetof(struct rte_eth_stats, q_ipackets)},
        {"rx_bytes", offsetof(struct rte_eth_stats, q_ibytes)},
 };
 #define RTE_NB_RXQ_STATS (sizeof(rte_rxq_stats_strings) /      \
                sizeof(rte_rxq_stats_strings[0]))
 
-static struct rte_eth_xstats_name_off rte_txq_stats_strings[] = {
+static const struct rte_eth_xstats_name_off rte_txq_stats_strings[] = {
        {"tx_packets", offsetof(struct rte_eth_stats, q_opackets)},
        {"tx_bytes", offsetof(struct rte_eth_stats, q_obytes)},
        {"tx_errors", offsetof(struct rte_eth_stats, q_errors)},
@@ -175,13 +182,18 @@ enum {
        STAT_QMAP_RX
 };
 
-static inline void
+enum {
+       DEV_DETACHED = 0,
+       DEV_ATTACHED
+};
+
+static void
 rte_eth_dev_data_alloc(void)
 {
        const unsigned flags = 0;
        const struct rte_memzone *mz;
 
-       if (rte_eal_process_type() == RTE_PROC_PRIMARY){
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
                mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA,
                                RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data),
                                rte_socket_id(), flags);
@@ -196,24 +208,39 @@ rte_eth_dev_data_alloc(void)
                                RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data));
 }
 
-static struct rte_eth_dev *
+struct rte_eth_dev *
 rte_eth_dev_allocated(const char *name)
 {
        unsigned i;
 
-       for (i = 0; i < nb_ports; i++) {
-               if (strcmp(rte_eth_devices[i].data->name, name) == 0)
+       for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+               if ((rte_eth_devices[i].attached == DEV_ATTACHED) &&
+                   strcmp(rte_eth_devices[i].data->name, name) == 0)
                        return &rte_eth_devices[i];
        }
        return NULL;
 }
 
+static uint8_t
+rte_eth_dev_find_free_port(void)
+{
+       unsigned i;
+
+       for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+               if (rte_eth_devices[i].attached == DEV_DETACHED)
+                       return i;
+       }
+       return RTE_MAX_ETHPORTS;
+}
+
 struct rte_eth_dev *
-rte_eth_dev_allocate(const char *name)
+rte_eth_dev_allocate(const char *name, enum rte_eth_dev_type type)
 {
+       uint8_t port_id;
        struct rte_eth_dev *eth_dev;
 
-       if (nb_ports == RTE_MAX_ETHPORTS) {
+       port_id = rte_eth_dev_find_free_port();
+       if (port_id == RTE_MAX_ETHPORTS) {
                PMD_DEBUG_TRACE("Reached maximum number of Ethernet ports\n");
                return NULL;
        }
@@ -222,17 +249,49 @@ rte_eth_dev_allocate(const char *name)
                rte_eth_dev_data_alloc();
 
        if (rte_eth_dev_allocated(name) != NULL) {
-               PMD_DEBUG_TRACE("Ethernet Device with name %s already allocated!\n", name);
+               PMD_DEBUG_TRACE("Ethernet Device with name %s already allocated!\n",
+                               name);
                return NULL;
        }
 
-       eth_dev = &rte_eth_devices[nb_ports];
-       eth_dev->data = &rte_eth_dev_data[nb_ports];
+       eth_dev = &rte_eth_devices[port_id];
+       eth_dev->data = &rte_eth_dev_data[port_id];
        snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name);
-       eth_dev->data->port_id = nb_ports++;
+       eth_dev->data->port_id = port_id;
+       eth_dev->attached = DEV_ATTACHED;
+       eth_dev->dev_type = type;
+       nb_ports++;
        return eth_dev;
 }
 
+static int
+rte_eth_dev_create_unique_device_name(char *name, size_t size,
+               struct rte_pci_device *pci_dev)
+{
+       int ret;
+
+       if ((name == NULL) || (pci_dev == NULL))
+               return -EINVAL;
+
+       ret = snprintf(name, size, "%d:%d.%d",
+                       pci_dev->addr.bus, pci_dev->addr.devid,
+                       pci_dev->addr.function);
+       if (ret < 0)
+               return ret;
+       return 0;
+}
+
+int
+rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)
+{
+       if (eth_dev == NULL)
+               return -EINVAL;
+
+       eth_dev->attached = DEV_DETACHED;
+       nb_ports--;
+       return 0;
+}
+
 static int
 rte_eth_dev_init(struct rte_pci_driver *pci_drv,
                 struct rte_pci_device *pci_dev)
@@ -246,14 +305,14 @@ rte_eth_dev_init(struct rte_pci_driver *pci_drv,
        eth_drv = (struct eth_driver *)pci_drv;
 
        /* Create unique Ethernet device name using PCI address */
-       snprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, "%d:%d.%d",
-                       pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function);
+       rte_eth_dev_create_unique_device_name(ethdev_name,
+                       sizeof(ethdev_name), pci_dev);
 
-       eth_dev = rte_eth_dev_allocate(ethdev_name);
+       eth_dev = rte_eth_dev_allocate(ethdev_name, RTE_ETH_DEV_PCI);
        if (eth_dev == NULL)
                return -ENOMEM;
 
-       if (rte_eal_process_type() == RTE_PROC_PRIMARY){
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
                eth_dev->data->dev_private = rte_zmalloc("ethdev private structure",
                                  eth_drv->dev_private_size,
                                  RTE_CACHE_LINE_SIZE);
@@ -273,20 +332,61 @@ rte_eth_dev_init(struct rte_pci_driver *pci_drv,
        eth_dev->data->mtu = ETHER_MTU;
 
        /* Invoke PMD device initialization function */
-       diag = (*eth_drv->eth_dev_init)(eth_drv, eth_dev);
+       diag = (*eth_drv->eth_dev_init)(eth_dev);
        if (diag == 0)
-               return (0);
+               return 0;
 
-       PMD_DEBUG_TRACE("driver %s: eth_dev_init(vendor_id=0x%u device_id=0x%x)"
-                       " failed\n", pci_drv->name,
+       PMD_DEBUG_TRACE("driver %s: eth_dev_init(vendor_id=0x%u device_id=0x%x) failed\n",
+                       pci_drv->name,
                        (unsigned) pci_dev->id.vendor_id,
                        (unsigned) pci_dev->id.device_id);
        if (rte_eal_process_type() == RTE_PROC_PRIMARY)
                rte_free(eth_dev->data->dev_private);
-       nb_ports--;
+       rte_eth_dev_release_port(eth_dev);
        return diag;
 }
 
+static int
+rte_eth_dev_uninit(struct rte_pci_device *pci_dev)
+{
+       const struct eth_driver *eth_drv;
+       struct rte_eth_dev *eth_dev;
+       char ethdev_name[RTE_ETH_NAME_MAX_LEN];
+       int ret;
+
+       if (pci_dev == NULL)
+               return -EINVAL;
+
+       /* Create unique Ethernet device name using PCI address */
+       rte_eth_dev_create_unique_device_name(ethdev_name,
+                       sizeof(ethdev_name), pci_dev);
+
+       eth_dev = rte_eth_dev_allocated(ethdev_name);
+       if (eth_dev == NULL)
+               return -ENODEV;
+
+       eth_drv = (const struct eth_driver *)pci_dev->driver;
+
+       /* Invoke PMD device uninit function */
+       if (*eth_drv->eth_dev_uninit) {
+               ret = (*eth_drv->eth_dev_uninit)(eth_dev);
+               if (ret)
+                       return ret;
+       }
+
+       /* free ether device */
+       rte_eth_dev_release_port(eth_dev);
+
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+               rte_free(eth_dev->data->dev_private);
+
+       eth_dev->pci_dev = NULL;
+       eth_dev->driver = NULL;
+       eth_dev->data = NULL;
+
+       return 0;
+}
+
 /**
  * Register an Ethernet [Poll Mode] driver.
  *
@@ -305,13 +405,24 @@ void
 rte_eth_driver_register(struct eth_driver *eth_drv)
 {
        eth_drv->pci_drv.devinit = rte_eth_dev_init;
+       eth_drv->pci_drv.devuninit = rte_eth_dev_uninit;
        rte_eal_pci_register(&eth_drv->pci_drv);
 }
 
+int
+rte_eth_dev_is_valid_port(uint8_t port_id)
+{
+       if (port_id >= RTE_MAX_ETHPORTS ||
+           rte_eth_devices[port_id].attached != DEV_ATTACHED)
+               return 0;
+       else
+               return 1;
+}
+
 int
 rte_eth_dev_socket_id(uint8_t port_id)
 {
-       if (port_id >= nb_ports)
+       if (!rte_eth_dev_is_valid_port(port_id))
                return -1;
        return rte_eth_devices[port_id].pci_dev->numa_node;
 }
@@ -319,7 +430,282 @@ rte_eth_dev_socket_id(uint8_t port_id)
 uint8_t
 rte_eth_dev_count(void)
 {
-       return (nb_ports);
+       return nb_ports;
+}
+
+static enum rte_eth_dev_type
+rte_eth_dev_get_device_type(uint8_t port_id)
+{
+       if (!rte_eth_dev_is_valid_port(port_id))
+               return RTE_ETH_DEV_UNKNOWN;
+       return rte_eth_devices[port_id].dev_type;
+}
+
+static int
+rte_eth_dev_save(struct rte_eth_dev *devs, size_t size)
+{
+       if ((devs == NULL) ||
+           (size != sizeof(struct rte_eth_dev) * RTE_MAX_ETHPORTS))
+               return -EINVAL;
+
+       /* save current rte_eth_devices */
+       memcpy(devs, rte_eth_devices, size);
+       return 0;
+}
+
+static int
+rte_eth_dev_get_changed_port(struct rte_eth_dev *devs, uint8_t *port_id)
+{
+       if ((devs == NULL) || (port_id == NULL))
+               return -EINVAL;
+
+       /* check which port was attached or detached */
+       for (*port_id = 0; *port_id < RTE_MAX_ETHPORTS; (*port_id)++, devs++) {
+               if (rte_eth_devices[*port_id].attached ^ devs->attached)
+                       return 0;
+       }
+       return -ENODEV;
+}
+
+static int
+rte_eth_dev_get_addr_by_port(uint8_t port_id, struct rte_pci_addr *addr)
+{
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
+       if (addr == NULL) {
+               PMD_DEBUG_TRACE("Null pointer is specified\n");
+               return -EINVAL;
+       }
+
+       *addr = rte_eth_devices[port_id].pci_dev->addr;
+       return 0;
+}
+
+static int
+rte_eth_dev_get_name_by_port(uint8_t port_id, char *name)
+{
+       char *tmp;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
+       if (name == NULL) {
+               PMD_DEBUG_TRACE("Null pointer is specified\n");
+               return -EINVAL;
+       }
+
+       /* shouldn't check 'rte_eth_devices[i].data',
+        * because it might be overwritten by VDEV PMD */
+       tmp = rte_eth_dev_data[port_id].name;
+       strcpy(name, tmp);
+       return 0;
+}
+
+static int
+rte_eth_dev_is_detachable(uint8_t port_id)
+{
+       uint32_t drv_flags;
+
+       if (!rte_eth_dev_is_valid_port(port_id)) {
+               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
+               return -EINVAL;
+       }
+
+       if (rte_eth_devices[port_id].dev_type == RTE_ETH_DEV_PCI) {
+               switch (rte_eth_devices[port_id].pci_dev->kdrv) {
+               case RTE_KDRV_IGB_UIO:
+               case RTE_KDRV_UIO_GENERIC:
+               case RTE_KDRV_NIC_UIO:
+                       break;
+               case RTE_KDRV_VFIO:
+               default:
+                       return -ENOTSUP;
+               }
+       }
+
+       drv_flags = rte_eth_devices[port_id].driver->pci_drv.drv_flags;
+       return !(drv_flags & RTE_PCI_DRV_DETACHABLE);
+}
+
+/* attach the new physical device, then store port_id of the device */
+static int
+rte_eth_dev_attach_pdev(struct rte_pci_addr *addr, uint8_t *port_id)
+{
+       uint8_t new_port_id;
+       struct rte_eth_dev devs[RTE_MAX_ETHPORTS];
+
+       if ((addr == NULL) || (port_id == NULL))
+               goto err;
+
+       /* save current port status */
+       if (rte_eth_dev_save(devs, sizeof(devs)))
+               goto err;
+       /* re-construct pci_device_list */
+       if (rte_eal_pci_scan())
+               goto err;
+       /* invoke probe func of the driver can handle the new device.
+        * TODO:
+        * rte_eal_pci_probe_one() should return port_id.
+        * And rte_eth_dev_save() and rte_eth_dev_get_changed_port()
+        * should be removed. */
+       if (rte_eal_pci_probe_one(addr))
+               goto err;
+       /* get port_id enabled by above procedures */
+       if (rte_eth_dev_get_changed_port(devs, &new_port_id))
+               goto err;
+
+       *port_id = new_port_id;
+       return 0;
+err:
+       RTE_LOG(ERR, EAL, "Driver, cannot attach the device\n");
+       return -1;
+}
+
+/* detach the new physical device, then store pci_addr of the device */
+static int
+rte_eth_dev_detach_pdev(uint8_t port_id, struct rte_pci_addr *addr)
+{
+       struct rte_pci_addr freed_addr;
+       struct rte_pci_addr vp;
+
+       if (addr == NULL)
+               goto err;
+
+       /* check whether the driver supports detach feature, or not */
+       if (rte_eth_dev_is_detachable(port_id))
+               goto err;
+
+       /* get pci address by port id */
+       if (rte_eth_dev_get_addr_by_port(port_id, &freed_addr))
+               goto err;
+
+       /* Zeroed pci addr means the port comes from virtual device */
+       vp.domain = vp.bus = vp.devid = vp.function = 0;
+       if (rte_eal_compare_pci_addr(&vp, &freed_addr) == 0)
+               goto err;
+
+       /* invoke devuninit func of the pci driver,
+        * also remove the device from pci_device_list */
+       if (rte_eal_pci_detach(&freed_addr))
+               goto err;
+
+       *addr = freed_addr;
+       return 0;
+err:
+       RTE_LOG(ERR, EAL, "Driver, cannot detach the device\n");
+       return -1;
+}
+
+/* attach the new virtual device, then store port_id of the device */
+static int
+rte_eth_dev_attach_vdev(const char *vdevargs, uint8_t *port_id)
+{
+       char *name = NULL, *args = NULL;
+       uint8_t new_port_id;
+       struct rte_eth_dev devs[RTE_MAX_ETHPORTS];
+       int ret = -1;
+
+       if ((vdevargs == NULL) || (port_id == NULL))
+               goto end;
+
+       /* parse vdevargs, then retrieve device name and args */
+       if (rte_eal_parse_devargs_str(vdevargs, &name, &args))
+               goto end;
+
+       /* save current port status */
+       if (rte_eth_dev_save(devs, sizeof(devs)))
+               goto end;
+       /* walk around dev_driver_list to find the driver of the device,
+        * then invoke probe function o the driver.
+        * TODO:
+        * rte_eal_vdev_init() should return port_id,
+        * And rte_eth_dev_save() and rte_eth_dev_get_changed_port()
+        * should be removed. */
+       if (rte_eal_vdev_init(name, args))
+               goto end;
+       /* get port_id enabled by above procedures */
+       if (rte_eth_dev_get_changed_port(devs, &new_port_id))
+               goto end;
+       ret = 0;
+       *port_id = new_port_id;
+end:
+       if (name)
+               free(name);
+       if (args)
+               free(args);
+
+       if (ret < 0)
+               RTE_LOG(ERR, EAL, "Driver, cannot attach the device\n");
+       return ret;
+}
+
+/* detach the new virtual device, then store the name of the device */
+static int
+rte_eth_dev_detach_vdev(uint8_t port_id, char *vdevname)
+{
+       char name[RTE_ETH_NAME_MAX_LEN];
+
+       if (vdevname == NULL)
+               goto err;
+
+       /* check whether the driver supports detach feature, or not */
+       if (rte_eth_dev_is_detachable(port_id))
+               goto err;
+
+       /* get device name by port id */
+       if (rte_eth_dev_get_name_by_port(port_id, name))
+               goto err;
+       /* walk around dev_driver_list to find the driver of the device,
+        * then invoke uninit function of the driver */
+       if (rte_eal_vdev_uninit(name))
+               goto err;
+
+       strncpy(vdevname, name, sizeof(name));
+       return 0;
+err:
+       RTE_LOG(ERR, EAL, "Driver, cannot detach the device\n");
+       return -1;
+}
+
+/* attach the new device, then store port_id of the device */
+int
+rte_eth_dev_attach(const char *devargs, uint8_t *port_id)
+{
+       struct rte_pci_addr addr;
+
+       if ((devargs == NULL) || (port_id == NULL))
+               return -EINVAL;
+
+       if (eal_parse_pci_DomBDF(devargs, &addr) == 0)
+               return rte_eth_dev_attach_pdev(&addr, port_id);
+       else
+               return rte_eth_dev_attach_vdev(devargs, port_id);
+}
+
+/* detach the device, then store the name of the device */
+int
+rte_eth_dev_detach(uint8_t port_id, char *name)
+{
+       struct rte_pci_addr addr;
+       int ret;
+
+       if (name == NULL)
+               return -EINVAL;
+
+       if (rte_eth_dev_get_device_type(port_id) == RTE_ETH_DEV_PCI) {
+               ret = rte_eth_dev_get_addr_by_port(port_id, &addr);
+               if (ret < 0)
+                       return ret;
+
+               ret = rte_eth_dev_detach_pdev(port_id, &addr);
+               if (ret == 0)
+                       snprintf(name, RTE_ETH_NAME_MAX_LEN,
+                               "%04x:%02x:%02x.%d",
+                               addr.domain, addr.bus,
+                               addr.devid, addr.function);
+
+               return ret;
+       } else
+               return rte_eth_dev_detach_vdev(port_id, name);
 }
 
 static int
@@ -348,16 +734,18 @@ rte_eth_dev_rx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
                                RTE_CACHE_LINE_SIZE);
                if (rxq == NULL)
                        return -(ENOMEM);
+               if (nb_queues > old_nb_queues) {
+                       uint16_t new_qs = nb_queues - old_nb_queues;
 
-               if (nb_queues > old_nb_queues)
                        memset(rxq + old_nb_queues, 0,
-                               sizeof(rxq[0]) * (nb_queues - old_nb_queues));
+                               sizeof(rxq[0]) * new_qs);
+               }
 
                dev->data->rx_queues = rxq;
 
        }
        dev->data->nb_rx_queues = nb_queues;
-       return (0);
+       return 0;
 }
 
 int
@@ -369,10 +757,7 @@ rte_eth_dev_rx_queue_start(uint8_t port_id, uint16_t rx_queue_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -EINVAL;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        if (rx_queue_id >= dev->data->nb_rx_queues) {
@@ -395,10 +780,7 @@ rte_eth_dev_rx_queue_stop(uint8_t port_id, uint16_t rx_queue_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -EINVAL;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        if (rx_queue_id >= dev->data->nb_rx_queues) {
@@ -421,10 +803,7 @@ rte_eth_dev_tx_queue_start(uint8_t port_id, uint16_t tx_queue_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -EINVAL;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        if (tx_queue_id >= dev->data->nb_tx_queues) {
@@ -447,10 +826,7 @@ rte_eth_dev_tx_queue_stop(uint8_t port_id, uint16_t tx_queue_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -EINVAL;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        if (tx_queue_id >= dev->data->nb_tx_queues) {
@@ -473,8 +849,8 @@ rte_eth_dev_tx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
 
        if (dev->data->tx_queues == NULL) { /* first time configuration */
                dev->data->tx_queues = rte_zmalloc("ethdev->tx_queues",
-                               sizeof(dev->data->tx_queues[0]) * nb_queues,
-                               RTE_CACHE_LINE_SIZE);
+                                                  sizeof(dev->data->tx_queues[0]) * nb_queues,
+                                                  RTE_CACHE_LINE_SIZE);
                if (dev->data->tx_queues == NULL) {
                        dev->data->nb_tx_queues = 0;
                        return -(ENOMEM);
@@ -487,207 +863,20 @@ rte_eth_dev_tx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
                for (i = nb_queues; i < old_nb_queues; i++)
                        (*dev->dev_ops->tx_queue_release)(txq[i]);
                txq = rte_realloc(txq, sizeof(txq[0]) * nb_queues,
-                               RTE_CACHE_LINE_SIZE);
+                                 RTE_CACHE_LINE_SIZE);
                if (txq == NULL)
-                       return -(ENOMEM);
+                       return -ENOMEM;
+               if (nb_queues > old_nb_queues) {
+                       uint16_t new_qs = nb_queues - old_nb_queues;
 
-               if (nb_queues > old_nb_queues)
                        memset(txq + old_nb_queues, 0,
-                               sizeof(txq[0]) * (nb_queues - old_nb_queues));
+                              sizeof(txq[0]) * new_qs);
+               }
 
                dev->data->tx_queues = txq;
 
        }
        dev->data->nb_tx_queues = nb_queues;
-       return (0);
-}
-
-static int
-rte_eth_dev_check_vf_rss_rxq_num(uint8_t port_id, uint16_t nb_rx_q)
-{
-       struct rte_eth_dev *dev = &rte_eth_devices[port_id];
-       switch (nb_rx_q) {
-       case 1:
-       case 2:
-               RTE_ETH_DEV_SRIOV(dev).active =
-                       ETH_64_POOLS;
-               break;
-       case 4:
-               RTE_ETH_DEV_SRIOV(dev).active =
-                       ETH_32_POOLS;
-               break;
-       default:
-               return -EINVAL;
-       }
-
-       RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
-       RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =
-               dev->pci_dev->max_vfs * nb_rx_q;
-
-       return 0;
-}
-
-static int
-rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
-                     const struct rte_eth_conf *dev_conf)
-{
-       struct rte_eth_dev *dev = &rte_eth_devices[port_id];
-
-       if (RTE_ETH_DEV_SRIOV(dev).active != 0) {
-               /* check multi-queue mode */
-               if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
-                   (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB_RSS) ||
-                   (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB)) {
-                       /* SRIOV only works in VMDq enable mode */
-                       PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
-                                       " SRIOV active, "
-                                       "wrong VMDQ mq_mode rx %u tx %u\n",
-                                       port_id,
-                                       dev_conf->rxmode.mq_mode,
-                                       dev_conf->txmode.mq_mode);
-                       return (-EINVAL);
-               }
-
-               switch (dev_conf->rxmode.mq_mode) {
-               case ETH_MQ_RX_VMDQ_DCB:
-               case ETH_MQ_RX_VMDQ_DCB_RSS:
-                       /* DCB/RSS VMDQ in SRIOV mode, not implement yet */
-                       PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
-                                       " SRIOV active, "
-                                       "unsupported VMDQ mq_mode rx %u\n",
-                                       port_id, dev_conf->rxmode.mq_mode);
-                       return (-EINVAL);
-               case ETH_MQ_RX_RSS:
-                       PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
-                                       " SRIOV active, "
-                                       "Rx mq mode is changed from:"
-                                       "mq_mode %u into VMDQ mq_mode %u\n",
-                                       port_id,
-                                       dev_conf->rxmode.mq_mode,
-                                       dev->data->dev_conf.rxmode.mq_mode);
-               case ETH_MQ_RX_VMDQ_RSS:
-                       dev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_VMDQ_RSS;
-                       if (nb_rx_q <= RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool)
-                               if (rte_eth_dev_check_vf_rss_rxq_num(port_id, nb_rx_q) != 0) {
-                                       PMD_DEBUG_TRACE("ethdev port_id=%d"
-                                               " SRIOV active, invalid queue"
-                                               " number for VMDQ RSS, allowed"
-                                               " value are 1, 2 or 4\n",
-                                               port_id);
-                                       return -EINVAL;
-                               }
-                       break;
-               default: /* ETH_MQ_RX_VMDQ_ONLY or ETH_MQ_RX_NONE */
-                       /* if nothing mq mode configure, use default scheme */
-                       dev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_VMDQ_ONLY;
-                       if (RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool > 1)
-                               RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 1;
-                       break;
-               }
-
-               switch (dev_conf->txmode.mq_mode) {
-               case ETH_MQ_TX_VMDQ_DCB:
-                       /* DCB VMDQ in SRIOV mode, not implement yet */
-                       PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
-                                       " SRIOV active, "
-                                       "unsupported VMDQ mq_mode tx %u\n",
-                                       port_id, dev_conf->txmode.mq_mode);
-                       return (-EINVAL);
-               default: /* ETH_MQ_TX_VMDQ_ONLY or ETH_MQ_TX_NONE */
-                       /* if nothing mq mode configure, use default scheme */
-                       dev->data->dev_conf.txmode.mq_mode = ETH_MQ_TX_VMDQ_ONLY;
-                       break;
-               }
-
-               /* check valid queue number */
-               if ((nb_rx_q > RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) ||
-                   (nb_tx_q > RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool)) {
-                       PMD_DEBUG_TRACE("ethdev port_id=%d SRIOV active, "
-                                   "queue number must less equal to %d\n",
-                                       port_id, RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool);
-                       return (-EINVAL);
-               }
-       } else {
-               /* For vmdb+dcb mode check our configuration before we go further */
-               if (dev_conf->rxmode.mq_mode == ETH_MQ_RX_VMDQ_DCB) {
-                       const struct rte_eth_vmdq_dcb_conf *conf;
-
-                       if (nb_rx_q != ETH_VMDQ_DCB_NUM_QUEUES) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d VMDQ+DCB, nb_rx_q "
-                                               "!= %d\n",
-                                               port_id, ETH_VMDQ_DCB_NUM_QUEUES);
-                               return (-EINVAL);
-                       }
-                       conf = &(dev_conf->rx_adv_conf.vmdq_dcb_conf);
-                       if (! (conf->nb_queue_pools == ETH_16_POOLS ||
-                              conf->nb_queue_pools == ETH_32_POOLS)) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d VMDQ+DCB selected, "
-                                               "nb_queue_pools must be %d or %d\n",
-                                               port_id, ETH_16_POOLS, ETH_32_POOLS);
-                               return (-EINVAL);
-                       }
-               }
-               if (dev_conf->txmode.mq_mode == ETH_MQ_TX_VMDQ_DCB) {
-                       const struct rte_eth_vmdq_dcb_tx_conf *conf;
-
-                       if (nb_tx_q != ETH_VMDQ_DCB_NUM_QUEUES) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d VMDQ+DCB, nb_tx_q "
-                                               "!= %d\n",
-                                               port_id, ETH_VMDQ_DCB_NUM_QUEUES);
-                               return (-EINVAL);
-                       }
-                       conf = &(dev_conf->tx_adv_conf.vmdq_dcb_tx_conf);
-                       if (! (conf->nb_queue_pools == ETH_16_POOLS ||
-                              conf->nb_queue_pools == ETH_32_POOLS)) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d VMDQ+DCB selected, "
-                                               "nb_queue_pools != %d or nb_queue_pools "
-                                               "!= %d\n",
-                                               port_id, ETH_16_POOLS, ETH_32_POOLS);
-                               return (-EINVAL);
-                       }
-               }
-
-               /* For DCB mode check our configuration before we go further */
-               if (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) {
-                       const struct rte_eth_dcb_rx_conf *conf;
-
-                       if (nb_rx_q != ETH_DCB_NUM_QUEUES) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d DCB, nb_rx_q "
-                                               "!= %d\n",
-                                               port_id, ETH_DCB_NUM_QUEUES);
-                               return (-EINVAL);
-                       }
-                       conf = &(dev_conf->rx_adv_conf.dcb_rx_conf);
-                       if (! (conf->nb_tcs == ETH_4_TCS ||
-                              conf->nb_tcs == ETH_8_TCS)) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d DCB selected, "
-                                               "nb_tcs != %d or nb_tcs "
-                                               "!= %d\n",
-                                               port_id, ETH_4_TCS, ETH_8_TCS);
-                               return (-EINVAL);
-                       }
-               }
-
-               if (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB) {
-                       const struct rte_eth_dcb_tx_conf *conf;
-
-                       if (nb_tx_q != ETH_DCB_NUM_QUEUES) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d DCB, nb_tx_q "
-                                               "!= %d\n",
-                                               port_id, ETH_DCB_NUM_QUEUES);
-                               return (-EINVAL);
-                       }
-                       conf = &(dev_conf->tx_adv_conf.dcb_tx_conf);
-                       if (! (conf->nb_tcs == ETH_4_TCS ||
-                              conf->nb_tcs == ETH_8_TCS)) {
-                               PMD_DEBUG_TRACE("ethdev port_id=%d DCB selected, "
-                                               "nb_tcs != %d or nb_tcs "
-                                               "!= %d\n",
-                                               port_id, ETH_4_TCS, ETH_8_TCS);
-                               return (-EINVAL);
-                       }
-               }
-       }
        return 0;
 }
 
@@ -703,10 +892,22 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports || port_id >= RTE_MAX_ETHPORTS) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-EINVAL);
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
+       if (nb_rx_q > RTE_MAX_QUEUES_PER_PORT) {
+               PMD_DEBUG_TRACE(
+                       "Number of RX queues requested (%u) is greater than max supported(%d)\n",
+                       nb_rx_q, RTE_MAX_QUEUES_PER_PORT);
+               return -EINVAL;
        }
+
+       if (nb_tx_q > RTE_MAX_QUEUES_PER_PORT) {
+               PMD_DEBUG_TRACE(
+                       "Number of TX queues requested (%u) is greater than max supported(%d)\n",
+                       nb_tx_q, RTE_MAX_QUEUES_PER_PORT);
+               return -EINVAL;
+       }
+
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
@@ -715,7 +916,7 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
        if (dev->data->dev_started) {
                PMD_DEBUG_TRACE(
                    "port %d must be stopped to allow configuration\n", port_id);
-               return (-EBUSY);
+               return -EBUSY;
        }
 
        /*
@@ -727,21 +928,21 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
        if (nb_rx_q > dev_info.max_rx_queues) {
                PMD_DEBUG_TRACE("ethdev port_id=%d nb_rx_queues=%d > %d\n",
                                port_id, nb_rx_q, dev_info.max_rx_queues);
-               return (-EINVAL);
+               return -EINVAL;
        }
        if (nb_rx_q == 0) {
                PMD_DEBUG_TRACE("ethdev port_id=%d nb_rx_q == 0\n", port_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        if (nb_tx_q > dev_info.max_tx_queues) {
                PMD_DEBUG_TRACE("ethdev port_id=%d nb_tx_queues=%d > %d\n",
                                port_id, nb_tx_q, dev_info.max_tx_queues);
-               return (-EINVAL);
+               return -EINVAL;
        }
        if (nb_tx_q == 0) {
                PMD_DEBUG_TRACE("ethdev port_id=%d nb_tx_q == 0\n", port_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        /* Copy the dev_conf parameter into the dev structure */
@@ -757,7 +958,7 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                if (!(pci_drv->drv_flags & RTE_PCI_DRV_INTR_LSC)) {
                        PMD_DEBUG_TRACE("driver %s does not support lsc\n",
                                        pci_drv->name);
-                       return (-EINVAL);
+                       return -EINVAL;
                }
        }
 
@@ -773,15 +974,14 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                                port_id,
                                (unsigned)dev_conf->rxmode.max_rx_pkt_len,
                                (unsigned)dev_info.max_rx_pktlen);
-                       return (-EINVAL);
-               }
-               else if (dev_conf->rxmode.max_rx_pkt_len < ETHER_MIN_LEN) {
+                       return -EINVAL;
+               } else if (dev_conf->rxmode.max_rx_pkt_len < ETHER_MIN_LEN) {
                        PMD_DEBUG_TRACE("ethdev port_id=%d max_rx_pkt_len %u"
                                " < min valid value %u\n",
                                port_id,
                                (unsigned)dev_conf->rxmode.max_rx_pkt_len,
                                (unsigned)ETHER_MIN_LEN);
-                       return (-EINVAL);
+                       return -EINVAL;
                }
        } else {
                if (dev_conf->rxmode.max_rx_pkt_len < ETHER_MIN_LEN ||
@@ -791,14 +991,6 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                                                        ETHER_MAX_LEN;
        }
 
-       /* multipe queue mode checking */
-       diag = rte_eth_dev_check_mq_mode(port_id, nb_rx_q, nb_tx_q, dev_conf);
-       if (diag != 0) {
-               PMD_DEBUG_TRACE("port%d rte_eth_dev_check_mq_mode = %d\n",
-                               port_id, diag);
-               return diag;
-       }
-
        /*
         * Setup new number of RX/TX queues and reconfigure device.
         */
@@ -871,7 +1063,7 @@ rte_eth_dev_config_restore(uint8_t port_id)
        else if (rte_eth_promiscuous_get(port_id) == 0)
                rte_eth_promiscuous_disable(port_id);
 
-       /* replay allmulticast configuration */
+       /* replay all multicast configuration */
        if (rte_eth_allmulticast_get(port_id) == 1)
                rte_eth_allmulticast_enable(port_id);
        else if (rte_eth_allmulticast_get(port_id) == 0)
@@ -888,10 +1080,8 @@ rte_eth_dev_start(uint8_t port_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%" PRIu8 "\n", port_id);
-               return (-EINVAL);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_start, -ENOTSUP);
@@ -900,7 +1090,7 @@ rte_eth_dev_start(uint8_t port_id)
                PMD_DEBUG_TRACE("Device with port_id=%" PRIu8
                        " already started\n",
                        port_id);
-               return (0);
+               return 0;
        }
 
        diag = (*dev->dev_ops->dev_start)(dev);
@@ -927,10 +1117,7 @@ rte_eth_dev_stop(uint8_t port_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_RET();
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%" PRIu8 "\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_RET(*dev->dev_ops->dev_stop);
@@ -955,10 +1142,8 @@ rte_eth_dev_set_link_up(uint8_t port_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -EINVAL;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_set_link_up, -ENOTSUP);
@@ -974,10 +1159,8 @@ rte_eth_dev_set_link_down(uint8_t port_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -EINVAL;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_set_link_down, -ENOTSUP);
@@ -993,16 +1176,17 @@ rte_eth_dev_close(uint8_t port_id)
         * in a multi-process setup*/
        PROC_PRIMARY_OR_RET();
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
-
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_RET(*dev->dev_ops->dev_close);
        dev->data->dev_started = 0;
        (*dev->dev_ops->dev_close)(dev);
+
+       rte_free(dev->data->rx_queues);
+       dev->data->rx_queues = NULL;
+       rte_free(dev->data->tx_queues);
+       dev->data->tx_queues = NULL;
 }
 
 int
@@ -1014,21 +1198,18 @@ rte_eth_rx_queue_setup(uint8_t port_id, uint16_t rx_queue_id,
        int ret;
        uint32_t mbp_buf_size;
        struct rte_eth_dev *dev;
-       struct rte_pktmbuf_pool_private *mbp_priv;
        struct rte_eth_dev_info dev_info;
 
        /* This function is only safe when called from the primary process
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-EINVAL);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
        dev = &rte_eth_devices[port_id];
        if (rx_queue_id >= dev->data->nb_rx_queues) {
                PMD_DEBUG_TRACE("Invalid RX queue_id=%d\n", rx_queue_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        if (dev->data->dev_started) {
@@ -1050,10 +1231,9 @@ rte_eth_rx_queue_setup(uint8_t port_id, uint16_t rx_queue_id,
                PMD_DEBUG_TRACE("%s private_data_size %d < %d\n",
                                mp->name, (int) mp->private_data_size,
                                (int) sizeof(struct rte_pktmbuf_pool_private));
-               return (-ENOSPC);
+               return -ENOSPC;
        }
-       mbp_priv = rte_mempool_get_priv(mp);
-       mbp_buf_size = mbp_priv->mbuf_data_room_size;
+       mbp_buf_size = rte_pktmbuf_data_room_size(mp);
 
        if ((mbp_buf_size - RTE_PKTMBUF_HEADROOM) < dev_info.min_rx_bufsize) {
                PMD_DEBUG_TRACE("%s mbuf_data_room_size %d < %d "
@@ -1065,7 +1245,20 @@ rte_eth_rx_queue_setup(uint8_t port_id, uint16_t rx_queue_id,
                                      dev_info.min_rx_bufsize),
                                (int)RTE_PKTMBUF_HEADROOM,
                                (int)dev_info.min_rx_bufsize);
-               return (-EINVAL);
+               return -EINVAL;
+       }
+
+       if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||
+                       nb_rx_desc < dev_info.rx_desc_lim.nb_min ||
+                       nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) {
+
+               PMD_DEBUG_TRACE("Invalid value for nb_rx_desc(=%hu), "
+                       "should be: <= %hu, = %hu, and a product of %hu\n",
+                       nb_rx_desc,
+                       dev_info.rx_desc_lim.nb_max,
+                       dev_info.rx_desc_lim.nb_min,
+                       dev_info.rx_desc_lim.nb_align);
+               return -EINVAL;
        }
 
        if (rx_conf == NULL)
@@ -1094,14 +1287,12 @@ rte_eth_tx_queue_setup(uint8_t port_id, uint16_t tx_queue_id,
         * in a multi-process setup*/
        PROC_PRIMARY_OR_ERR_RET(-E_RTE_SECONDARY);
 
-       if (port_id >= RTE_MAX_ETHPORTS || port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-EINVAL);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
        dev = &rte_eth_devices[port_id];
        if (tx_queue_id >= dev->data->nb_tx_queues) {
                PMD_DEBUG_TRACE("Invalid TX queue_id=%d\n", tx_queue_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        if (dev->data->dev_started) {
@@ -1127,10 +1318,7 @@ rte_eth_promiscuous_enable(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_RET(*dev->dev_ops->promiscuous_enable);
@@ -1143,10 +1331,7 @@ rte_eth_promiscuous_disable(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_RET(*dev->dev_ops->promiscuous_disable);
@@ -1159,10 +1344,7 @@ rte_eth_promiscuous_get(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -1;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        return dev->data->promiscuous;
@@ -1173,10 +1355,7 @@ rte_eth_allmulticast_enable(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_RET(*dev->dev_ops->allmulticast_enable);
@@ -1189,10 +1368,7 @@ rte_eth_allmulticast_disable(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_RET(*dev->dev_ops->allmulticast_disable);
@@ -1205,10 +1381,7 @@ rte_eth_allmulticast_get(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -1;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        return dev->data->all_multicast;
@@ -1233,10 +1406,7 @@ rte_eth_link_get(uint8_t port_id, struct rte_eth_link *eth_link)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        if (dev->data->dev_conf.intr_conf.lsc != 0)
@@ -1253,10 +1423,7 @@ rte_eth_link_get_nowait(uint8_t port_id, struct rte_eth_link *eth_link)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        if (dev->data->dev_conf.intr_conf.lsc != 0)
@@ -1273,10 +1440,8 @@ rte_eth_stats_get(uint8_t port_id, struct rte_eth_stats *stats)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
+
        dev = &rte_eth_devices[port_id];
        memset(stats, 0, sizeof(*stats));
 
@@ -1291,10 +1456,7 @@ rte_eth_stats_reset(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_RET(*dev->dev_ops->stats_reset);
@@ -1308,37 +1470,43 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,
 {
        struct rte_eth_stats eth_stats;
        struct rte_eth_dev *dev;
-       unsigned count, i, q;
-       uint64_t val;
-       char *stats_ptr;
+       unsigned count = 0, i, q;
+       signed xcount = 0;
+       uint64_t val, *stats_ptr;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -1;
-       }
-       dev = &rte_eth_devices[port_id];
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
-       /* implemented by the driver */
-       if (dev->dev_ops->xstats_get != NULL)
-               return (*dev->dev_ops->xstats_get)(dev, xstats, n);
+       dev = &rte_eth_devices[port_id];
 
-       /* else, return generic statistics */
+       /* Return generic statistics */
        count = RTE_NB_STATS;
        count += dev->data->nb_rx_queues * RTE_NB_RXQ_STATS;
        count += dev->data->nb_tx_queues * RTE_NB_TXQ_STATS;
-       if (n < count)
-               return count;
 
-       /* now fill the xstats structure */
+       /* implemented by the driver */
+       if (dev->dev_ops->xstats_get != NULL) {
+               /* Retrieve the xstats from the driver at the end of the
+                * xstats struct.
+                */
+               xcount = (*dev->dev_ops->xstats_get)(dev, &xstats[count],
+                        (n > count) ? n - count : 0);
+
+               if (xcount < 0)
+                       return xcount;
+       }
 
+       if (n < count + xcount)
+               return count + xcount;
+
+       /* now fill the xstats structure */
        count = 0;
-       memset(&eth_stats, 0, sizeof(eth_stats));
        rte_eth_stats_get(port_id, &eth_stats);
 
        /* global stats */
        for (i = 0; i < RTE_NB_STATS; i++) {
-               stats_ptr = (char *)&eth_stats + rte_stats_strings[i].offset;
-               val = *(uint64_t *)stats_ptr;
+               stats_ptr = RTE_PTR_ADD(&eth_stats,
+                                       rte_stats_strings[i].offset);
+               val = *stats_ptr;
                snprintf(xstats[count].name, sizeof(xstats[count].name),
                        "%s", rte_stats_strings[i].name);
                xstats[count++].value = val;
@@ -1347,10 +1515,10 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,
        /* per-rxq stats */
        for (q = 0; q < dev->data->nb_rx_queues; q++) {
                for (i = 0; i < RTE_NB_RXQ_STATS; i++) {
-                       stats_ptr = (char *)&eth_stats;
-                       stats_ptr += rte_rxq_stats_strings[i].offset;
-                       stats_ptr += q * sizeof(uint64_t);
-                       val = *(uint64_t *)stats_ptr;
+                       stats_ptr = RTE_PTR_ADD(&eth_stats,
+                                       rte_rxq_stats_strings[i].offset +
+                                       q * sizeof(uint64_t));
+                       val = *stats_ptr;
                        snprintf(xstats[count].name, sizeof(xstats[count].name),
                                "rx_queue_%u_%s", q,
                                rte_rxq_stats_strings[i].name);
@@ -1361,10 +1529,10 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,
        /* per-txq stats */
        for (q = 0; q < dev->data->nb_tx_queues; q++) {
                for (i = 0; i < RTE_NB_TXQ_STATS; i++) {
-                       stats_ptr = (char *)&eth_stats;
-                       stats_ptr += rte_txq_stats_strings[i].offset;
-                       stats_ptr += q * sizeof(uint64_t);
-                       val = *(uint64_t *)stats_ptr;
+                       stats_ptr = RTE_PTR_ADD(&eth_stats,
+                                       rte_txq_stats_strings[i].offset +
+                                       q * sizeof(uint64_t));
+                       val = *stats_ptr;
                        snprintf(xstats[count].name, sizeof(xstats[count].name),
                                "tx_queue_%u_%s", q,
                                rte_txq_stats_strings[i].name);
@@ -1372,7 +1540,7 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,
                }
        }
 
-       return count;
+       return count + xcount;
 }
 
 /* reset ethdev extended statistics */
@@ -1381,10 +1549,7 @@ rte_eth_xstats_reset(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        /* implemented by the driver */
@@ -1403,10 +1568,8 @@ set_queue_stats_mapping(uint8_t port_id, uint16_t queue_id, uint8_t stat_idx,
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -ENODEV;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_stats_mapping_set, -ENOTSUP);
@@ -1437,14 +1600,18 @@ void
 rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info)
 {
        struct rte_eth_dev *dev;
+       const struct rte_eth_desc_lim lim = {
+               .nb_max = UINT16_MAX,
+               .nb_min = 0,
+               .nb_align = 1,
+       };
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
 
        memset(dev_info, 0, sizeof(struct rte_eth_dev_info));
+       dev_info->rx_desc_lim = lim;
+       dev_info->tx_desc_lim = lim;
 
        FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get);
        (*dev->dev_ops->dev_infos_get)(dev, dev_info);
@@ -1458,10 +1625,7 @@ rte_eth_macaddr_get(uint8_t port_id, struct ether_addr *mac_addr)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return;
-       }
+       VALID_PORTID_OR_RET(port_id);
        dev = &rte_eth_devices[port_id];
        ether_addr_copy(&dev->data->mac_addrs[0], mac_addr);
 }
@@ -1472,10 +1636,7 @@ rte_eth_dev_get_mtu(uint8_t port_id, uint16_t *mtu)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        *mtu = dev->data->mtu;
@@ -1488,11 +1649,7 @@ rte_eth_dev_set_mtu(uint8_t port_id, uint16_t mtu)
        int ret;
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mtu_set, -ENOTSUP);
 
@@ -1508,24 +1665,21 @@ rte_eth_dev_vlan_filter(uint8_t port_id, uint16_t vlan_id, int on)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
-       if (! (dev->data->dev_conf.rxmode.hw_vlan_filter)) {
+       if (!(dev->data->dev_conf.rxmode.hw_vlan_filter)) {
                PMD_DEBUG_TRACE("port %d: vlan-filtering disabled\n", port_id);
-               return (-ENOSYS);
+               return -ENOSYS;
        }
 
        if (vlan_id > 4095) {
                PMD_DEBUG_TRACE("(port_id=%d) invalid vlan_id=%u > 4095\n",
                                port_id, (unsigned) vlan_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_filter_set, -ENOTSUP);
-       (*dev->dev_ops->vlan_filter_set)(dev, vlan_id, on);
-       return (0);
+
+       return (*dev->dev_ops->vlan_filter_set)(dev, vlan_id, on);
 }
 
 int
@@ -1533,21 +1687,17 @@ rte_eth_dev_set_vlan_strip_on_queue(uint8_t port_id, uint16_t rx_queue_id, int o
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        if (rx_queue_id >= dev->data->nb_rx_queues) {
                PMD_DEBUG_TRACE("Invalid rx_queue_id=%d\n", port_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_strip_queue_set, -ENOTSUP);
        (*dev->dev_ops->vlan_strip_queue_set)(dev, rx_queue_id, on);
 
-       return (0);
+       return 0;
 }
 
 int
@@ -1555,16 +1705,12 @@ rte_eth_dev_set_vlan_ether_type(uint8_t port_id, uint16_t tpid)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_tpid_set, -ENOTSUP);
        (*dev->dev_ops->vlan_tpid_set)(dev, tpid);
 
-       return (0);
+       return 0;
 }
 
 int
@@ -1575,37 +1721,33 @@ rte_eth_dev_set_vlan_offload(uint8_t port_id, int offload_mask)
        int mask = 0;
        int cur, org = 0;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
        /*check which option changed by application*/
        cur = !!(offload_mask & ETH_VLAN_STRIP_OFFLOAD);
        org = !!(dev->data->dev_conf.rxmode.hw_vlan_strip);
-       if (cur != org){
+       if (cur != org) {
                dev->data->dev_conf.rxmode.hw_vlan_strip = (uint8_t)cur;
                mask |= ETH_VLAN_STRIP_MASK;
        }
 
        cur = !!(offload_mask & ETH_VLAN_FILTER_OFFLOAD);
        org = !!(dev->data->dev_conf.rxmode.hw_vlan_filter);
-       if (cur != org){
+       if (cur != org) {
                dev->data->dev_conf.rxmode.hw_vlan_filter = (uint8_t)cur;
                mask |= ETH_VLAN_FILTER_MASK;
        }
 
        cur = !!(offload_mask & ETH_VLAN_EXTEND_OFFLOAD);
        org = !!(dev->data->dev_conf.rxmode.hw_vlan_extend);
-       if (cur != org){
+       if (cur != org) {
                dev->data->dev_conf.rxmode.hw_vlan_extend = (uint8_t)cur;
                mask |= ETH_VLAN_EXTEND_MASK;
        }
 
        /*no change*/
-       if(mask == 0)
+       if (mask == 0)
                return ret;
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_offload_set, -ENOTSUP);
@@ -1620,21 +1762,17 @@ rte_eth_dev_get_vlan_offload(uint8_t port_id)
        struct rte_eth_dev *dev;
        int ret = 0;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
        if (dev->data->dev_conf.rxmode.hw_vlan_strip)
-               ret |= ETH_VLAN_STRIP_OFFLOAD ;
+               ret |= ETH_VLAN_STRIP_OFFLOAD;
 
        if (dev->data->dev_conf.rxmode.hw_vlan_filter)
-               ret |= ETH_VLAN_FILTER_OFFLOAD ;
+               ret |= ETH_VLAN_FILTER_OFFLOAD;
 
        if (dev->data->dev_conf.rxmode.hw_vlan_extend)
-               ret |= ETH_VLAN_EXTEND_OFFLOAD ;
+               ret |= ETH_VLAN_EXTEND_OFFLOAD;
 
        return ret;
 }
@@ -1644,10 +1782,7 @@ rte_eth_dev_set_vlan_pvid(uint8_t port_id, uint16_t pvid, int on)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_pvid_set, -ENOTSUP);
        (*dev->dev_ops->vlan_pvid_set)(dev, pvid, on);
@@ -1656,418 +1791,142 @@ rte_eth_dev_set_vlan_pvid(uint8_t port_id, uint16_t pvid, int on)
 }
 
 int
-rte_eth_dev_fdir_add_signature_filter(uint8_t port_id,
-                                     struct rte_fdir_filter *fdir_filter,
-                                     uint8_t queue)
+rte_eth_dev_flow_ctrl_get(uint8_t port_id, struct rte_eth_fc_conf *fc_conf)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
-
-       if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_SIGNATURE) {
-               PMD_DEBUG_TRACE("port %d: invalid FDIR mode=%u\n",
-                               port_id, dev->data->dev_conf.fdir_conf.mode);
-               return (-ENOSYS);
-       }
-
-       if ((fdir_filter->l4type == RTE_FDIR_L4TYPE_SCTP
-            || fdir_filter->l4type == RTE_FDIR_L4TYPE_NONE)
-           && (fdir_filter->port_src || fdir_filter->port_dst)) {
-               PMD_DEBUG_TRACE(" Port are meaningless for SCTP and " \
-                               "None l4type, source & destinations ports " \
-                               "should be null!\n");
-               return (-EINVAL);
-       }
-
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_add_signature_filter, -ENOTSUP);
-       return (*dev->dev_ops->fdir_add_signature_filter)(dev, fdir_filter,
-                                                               queue);
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->flow_ctrl_get, -ENOTSUP);
+       memset(fc_conf, 0, sizeof(*fc_conf));
+       return (*dev->dev_ops->flow_ctrl_get)(dev, fc_conf);
 }
 
 int
-rte_eth_dev_fdir_update_signature_filter(uint8_t port_id,
-                                        struct rte_fdir_filter *fdir_filter,
-                                        uint8_t queue)
+rte_eth_dev_flow_ctrl_set(uint8_t port_id, struct rte_eth_fc_conf *fc_conf)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       if ((fc_conf->send_xon != 0) && (fc_conf->send_xon != 1)) {
+               PMD_DEBUG_TRACE("Invalid send_xon, only 0/1 allowed\n");
+               return -EINVAL;
        }
 
        dev = &rte_eth_devices[port_id];
-
-       if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_SIGNATURE) {
-               PMD_DEBUG_TRACE("port %d: invalid FDIR mode=%u\n",
-                               port_id, dev->data->dev_conf.fdir_conf.mode);
-               return (-ENOSYS);
-       }
-
-       if ((fdir_filter->l4type == RTE_FDIR_L4TYPE_SCTP
-            || fdir_filter->l4type == RTE_FDIR_L4TYPE_NONE)
-           && (fdir_filter->port_src || fdir_filter->port_dst)) {
-               PMD_DEBUG_TRACE(" Port are meaningless for SCTP and " \
-                               "None l4type, source & destinations ports " \
-                               "should be null!\n");
-               return (-EINVAL);
-       }
-
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_update_signature_filter, -ENOTSUP);
-       return (*dev->dev_ops->fdir_update_signature_filter)(dev, fdir_filter,
-                                                               queue);
-
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->flow_ctrl_set, -ENOTSUP);
+       return (*dev->dev_ops->flow_ctrl_set)(dev, fc_conf);
 }
 
 int
-rte_eth_dev_fdir_remove_signature_filter(uint8_t port_id,
-                                        struct rte_fdir_filter *fdir_filter)
+rte_eth_dev_priority_flow_ctrl_set(uint8_t port_id, struct rte_eth_pfc_conf *pfc_conf)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       if (pfc_conf->priority > (ETH_DCB_NUM_USER_PRIORITIES - 1)) {
+               PMD_DEBUG_TRACE("Invalid priority, only 0-7 allowed\n");
+               return -EINVAL;
        }
 
        dev = &rte_eth_devices[port_id];
-
-       if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_SIGNATURE) {
-               PMD_DEBUG_TRACE("port %d: invalid FDIR mode=%u\n",
-                               port_id, dev->data->dev_conf.fdir_conf.mode);
-               return (-ENOSYS);
-       }
-
-       if ((fdir_filter->l4type == RTE_FDIR_L4TYPE_SCTP
-            || fdir_filter->l4type == RTE_FDIR_L4TYPE_NONE)
-           && (fdir_filter->port_src || fdir_filter->port_dst)) {
-               PMD_DEBUG_TRACE(" Port are meaningless for SCTP and " \
-                               "None l4type source & destinations ports " \
-                               "should be null!\n");
-               return (-EINVAL);
-       }
-
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_remove_signature_filter, -ENOTSUP);
-       return (*dev->dev_ops->fdir_remove_signature_filter)(dev, fdir_filter);
+       /* High water, low water validation are device specific */
+       if  (*dev->dev_ops->priority_flow_ctrl_set)
+               return (*dev->dev_ops->priority_flow_ctrl_set)(dev, pfc_conf);
+       return -ENOTSUP;
 }
 
-int
-rte_eth_dev_fdir_get_infos(uint8_t port_id, struct rte_eth_fdir *fdir)
+static int
+rte_eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf,
+                       uint16_t reta_size)
 {
-       struct rte_eth_dev *dev;
+       uint16_t i, num;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       if (!reta_conf)
+               return -EINVAL;
 
-       dev = &rte_eth_devices[port_id];
-       if (! (dev->data->dev_conf.fdir_conf.mode)) {
-               PMD_DEBUG_TRACE("port %d: pkt-filter disabled\n", port_id);
-               return (-ENOSYS);
+       if (reta_size != RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) {
+               PMD_DEBUG_TRACE("Invalid reta size, should be %u aligned\n",
+                                                       RTE_RETA_GROUP_SIZE);
+               return -EINVAL;
        }
 
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_infos_get, -ENOTSUP);
+       num = reta_size / RTE_RETA_GROUP_SIZE;
+       for (i = 0; i < num; i++) {
+               if (reta_conf[i].mask)
+                       return 0;
+       }
 
-       (*dev->dev_ops->fdir_infos_get)(dev, fdir);
-       return (0);
+       return -EINVAL;
 }
 
-int
-rte_eth_dev_fdir_add_perfect_filter(uint8_t port_id,
-                                   struct rte_fdir_filter *fdir_filter,
-                                   uint16_t soft_id, uint8_t queue,
-                                   uint8_t drop)
+static int
+rte_eth_check_reta_entry(struct rte_eth_rss_reta_entry64 *reta_conf,
+                        uint16_t reta_size,
+                        uint8_t max_rxq)
 {
-       struct rte_eth_dev *dev;
-
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       uint16_t i, idx, shift;
 
-       dev = &rte_eth_devices[port_id];
+       if (!reta_conf)
+               return -EINVAL;
 
-       if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_PERFECT) {
-               PMD_DEBUG_TRACE("port %d: invalid FDIR mode=%u\n",
-                               port_id, dev->data->dev_conf.fdir_conf.mode);
-               return (-ENOSYS);
+       if (max_rxq == 0) {
+               PMD_DEBUG_TRACE("No receive queue is available\n");
+               return -EINVAL;
        }
 
-       if ((fdir_filter->l4type == RTE_FDIR_L4TYPE_SCTP
-            || fdir_filter->l4type == RTE_FDIR_L4TYPE_NONE)
-           && (fdir_filter->port_src || fdir_filter->port_dst)) {
-               PMD_DEBUG_TRACE(" Port are meaningless for SCTP and " \
-                               "None l4type, source & destinations ports " \
-                               "should be null!\n");
-               return (-EINVAL);
+       for (i = 0; i < reta_size; i++) {
+               idx = i / RTE_RETA_GROUP_SIZE;
+               shift = i % RTE_RETA_GROUP_SIZE;
+               if ((reta_conf[idx].mask & (1ULL << shift)) &&
+                       (reta_conf[idx].reta[shift] >= max_rxq)) {
+                       PMD_DEBUG_TRACE("reta_conf[%u]->reta[%u]: %u exceeds "
+                               "the maximum rxq index: %u\n", idx, shift,
+                               reta_conf[idx].reta[shift], max_rxq);
+                       return -EINVAL;
+               }
        }
 
-       /* For now IPv6 is not supported with perfect filter */
-       if (fdir_filter->iptype == RTE_FDIR_IPTYPE_IPV6)
-               return (-ENOTSUP);
-
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_add_perfect_filter, -ENOTSUP);
-       return (*dev->dev_ops->fdir_add_perfect_filter)(dev, fdir_filter,
-                                                               soft_id, queue,
-                                                               drop);
+       return 0;
 }
 
 int
-rte_eth_dev_fdir_update_perfect_filter(uint8_t port_id,
-                                      struct rte_fdir_filter *fdir_filter,
-                                      uint16_t soft_id, uint8_t queue,
-                                      uint8_t drop)
+rte_eth_dev_rss_reta_update(uint8_t port_id,
+                           struct rte_eth_rss_reta_entry64 *reta_conf,
+                           uint16_t reta_size)
 {
        struct rte_eth_dev *dev;
+       int ret;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       /* Check mask bits */
+       ret = rte_eth_check_reta_mask(reta_conf, reta_size);
+       if (ret < 0)
+               return ret;
 
        dev = &rte_eth_devices[port_id];
 
-       if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_PERFECT) {
-               PMD_DEBUG_TRACE("port %d: invalid FDIR mode=%u\n",
-                               port_id, dev->data->dev_conf.fdir_conf.mode);
-               return (-ENOSYS);
-       }
-
-       if ((fdir_filter->l4type == RTE_FDIR_L4TYPE_SCTP
-            || fdir_filter->l4type == RTE_FDIR_L4TYPE_NONE)
-           && (fdir_filter->port_src || fdir_filter->port_dst)) {
-               PMD_DEBUG_TRACE(" Port are meaningless for SCTP and " \
-                               "None l4type, source & destinations ports " \
-                               "should be null!\n");
-               return (-EINVAL);
-       }
-
-       /* For now IPv6 is not supported with perfect filter */
-       if (fdir_filter->iptype == RTE_FDIR_IPTYPE_IPV6)
-               return (-ENOTSUP);
+       /* Check entry value */
+       ret = rte_eth_check_reta_entry(reta_conf, reta_size,
+                               dev->data->nb_rx_queues);
+       if (ret < 0)
+               return ret;
 
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_update_perfect_filter, -ENOTSUP);
-       return (*dev->dev_ops->fdir_update_perfect_filter)(dev, fdir_filter,
-                                                       soft_id, queue, drop);
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->reta_update, -ENOTSUP);
+       return (*dev->dev_ops->reta_update)(dev, reta_conf, reta_size);
 }
 
 int
-rte_eth_dev_fdir_remove_perfect_filter(uint8_t port_id,
-                                      struct rte_fdir_filter *fdir_filter,
-                                      uint16_t soft_id)
+rte_eth_dev_rss_reta_query(uint8_t port_id,
+                          struct rte_eth_rss_reta_entry64 *reta_conf,
+                          uint16_t reta_size)
 {
        struct rte_eth_dev *dev;
+       int ret;
 
        if (port_id >= nb_ports) {
                PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       dev = &rte_eth_devices[port_id];
-
-       if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_PERFECT) {
-               PMD_DEBUG_TRACE("port %d: invalid FDIR mode=%u\n",
-                               port_id, dev->data->dev_conf.fdir_conf.mode);
-               return (-ENOSYS);
-       }
-
-       if ((fdir_filter->l4type == RTE_FDIR_L4TYPE_SCTP
-            || fdir_filter->l4type == RTE_FDIR_L4TYPE_NONE)
-           && (fdir_filter->port_src || fdir_filter->port_dst)) {
-               PMD_DEBUG_TRACE(" Port are meaningless for SCTP and " \
-                               "None l4type, source & destinations ports " \
-                               "should be null!\n");
-               return (-EINVAL);
-       }
-
-       /* For now IPv6 is not supported with perfect filter */
-       if (fdir_filter->iptype == RTE_FDIR_IPTYPE_IPV6)
-               return (-ENOTSUP);
-
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_remove_perfect_filter, -ENOTSUP);
-       return (*dev->dev_ops->fdir_remove_perfect_filter)(dev, fdir_filter,
-                                                               soft_id);
-}
-
-int
-rte_eth_dev_fdir_set_masks(uint8_t port_id, struct rte_fdir_masks *fdir_mask)
-{
-       struct rte_eth_dev *dev;
-
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       dev = &rte_eth_devices[port_id];
-       if (! (dev->data->dev_conf.fdir_conf.mode)) {
-               PMD_DEBUG_TRACE("port %d: pkt-filter disabled\n", port_id);
-               return (-ENOSYS);
-       }
-
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fdir_set_masks, -ENOTSUP);
-       return (*dev->dev_ops->fdir_set_masks)(dev, fdir_mask);
-}
-
-int
-rte_eth_dev_flow_ctrl_get(uint8_t port_id, struct rte_eth_fc_conf *fc_conf)
-{
-       struct rte_eth_dev *dev;
-
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       dev = &rte_eth_devices[port_id];
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->flow_ctrl_get, -ENOTSUP);
-       memset(fc_conf, 0, sizeof(*fc_conf));
-       return (*dev->dev_ops->flow_ctrl_get)(dev, fc_conf);
-}
-
-int
-rte_eth_dev_flow_ctrl_set(uint8_t port_id, struct rte_eth_fc_conf *fc_conf)
-{
-       struct rte_eth_dev *dev;
-
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       if ((fc_conf->send_xon != 0) && (fc_conf->send_xon != 1)) {
-               PMD_DEBUG_TRACE("Invalid send_xon, only 0/1 allowed\n");
-               return (-EINVAL);
-       }
-
-       dev = &rte_eth_devices[port_id];
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->flow_ctrl_set, -ENOTSUP);
-       return (*dev->dev_ops->flow_ctrl_set)(dev, fc_conf);
-}
-
-int
-rte_eth_dev_priority_flow_ctrl_set(uint8_t port_id, struct rte_eth_pfc_conf *pfc_conf)
-{
-       struct rte_eth_dev *dev;
-
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       if (pfc_conf->priority > (ETH_DCB_NUM_USER_PRIORITIES - 1)) {
-               PMD_DEBUG_TRACE("Invalid priority, only 0-7 allowed\n");
-               return (-EINVAL);
-       }
-
-       dev = &rte_eth_devices[port_id];
-       /* High water, low water validation are device specific */
-       if  (*dev->dev_ops->priority_flow_ctrl_set)
-               return (*dev->dev_ops->priority_flow_ctrl_set)(dev, pfc_conf);
-       return (-ENOTSUP);
-}
-
-static inline int
-rte_eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf,
-                       uint16_t reta_size)
-{
-       uint16_t i, num;
-
-       if (!reta_conf)
-               return -EINVAL;
-
-       if (reta_size != RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) {
-               PMD_DEBUG_TRACE("Invalid reta size, should be %u aligned\n",
-                                                       RTE_RETA_GROUP_SIZE);
-               return -EINVAL;
-       }
-
-       num = reta_size / RTE_RETA_GROUP_SIZE;
-       for (i = 0; i < num; i++) {
-               if (reta_conf[i].mask)
-                       return 0;
-       }
-
-       return -EINVAL;
-}
-
-static inline int
-rte_eth_check_reta_entry(struct rte_eth_rss_reta_entry64 *reta_conf,
-                        uint16_t reta_size,
-                        uint8_t max_rxq)
-{
-       uint16_t i, idx, shift;
-
-       if (!reta_conf)
-               return -EINVAL;
-
-       if (max_rxq == 0) {
-               PMD_DEBUG_TRACE("No receive queue is available\n");
-               return -EINVAL;
-       }
-
-       for (i = 0; i < reta_size; i++) {
-               idx = i / RTE_RETA_GROUP_SIZE;
-               shift = i % RTE_RETA_GROUP_SIZE;
-               if ((reta_conf[idx].mask & (1ULL << shift)) &&
-                       (reta_conf[idx].reta[shift] >= max_rxq)) {
-                       PMD_DEBUG_TRACE("reta_conf[%u]->reta[%u]: %u exceeds "
-                               "the maximum rxq index: %u\n", idx, shift,
-                               reta_conf[idx].reta[shift], max_rxq);
-                       return -EINVAL;
-               }
-       }
-
-       return 0;
-}
-
-int
-rte_eth_dev_rss_reta_update(uint8_t port_id,
-                           struct rte_eth_rss_reta_entry64 *reta_conf,
-                           uint16_t reta_size)
-{
-       struct rte_eth_dev *dev;
-       int ret;
-
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -ENODEV;
-       }
-
-       /* Check mask bits */
-       ret = rte_eth_check_reta_mask(reta_conf, reta_size);
-       if (ret < 0)
-               return ret;
-
-       dev = &rte_eth_devices[port_id];
-
-       /* Check entry value */
-       ret = rte_eth_check_reta_entry(reta_conf, reta_size,
-                               dev->data->nb_rx_queues);
-       if (ret < 0)
-               return ret;
-
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->reta_update, -ENOTSUP);
-       return (*dev->dev_ops->reta_update)(dev, reta_conf, reta_size);
-}
-
-int
-rte_eth_dev_rss_reta_query(uint8_t port_id,
-                          struct rte_eth_rss_reta_entry64 *reta_conf,
-                          uint16_t reta_size)
-{
-       struct rte_eth_dev *dev;
-       int ret;
-
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -ENODEV;
+               return -ENODEV;
        }
 
        /* Check mask bits */
@@ -2086,16 +1945,13 @@ rte_eth_dev_rss_hash_update(uint8_t port_id, struct rte_eth_rss_conf *rss_conf)
        struct rte_eth_dev *dev;
        uint16_t rss_hash_protos;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        rss_hash_protos = rss_conf->rss_hf;
        if ((rss_hash_protos != 0) &&
            ((rss_hash_protos & ETH_RSS_PROTO_MASK) == 0)) {
                PMD_DEBUG_TRACE("Invalid rss_hash_protos=0x%x\n",
                                rss_hash_protos);
-               return (-EINVAL);
+               return -EINVAL;
        }
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rss_hash_update, -ENOTSUP);
@@ -2108,10 +1964,7 @@ rte_eth_dev_rss_hash_conf_get(uint8_t port_id,
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rss_hash_conf_get, -ENOTSUP);
        return (*dev->dev_ops->rss_hash_conf_get)(dev, rss_conf);
@@ -2123,11 +1976,7 @@ rte_eth_dev_udp_tunnel_add(uint8_t port_id,
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -ENODEV;
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        if (udp_tunnel == NULL) {
                PMD_DEBUG_TRACE("Invalid udp_tunnel parameter\n");
                return -EINVAL;
@@ -2149,14 +1998,11 @@ rte_eth_dev_udp_tunnel_delete(uint8_t port_id,
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -ENODEV;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
 
        if (udp_tunnel == NULL) {
-               PMD_DEBUG_TRACE("Invalid udp_tunnel parametr\n");
+               PMD_DEBUG_TRACE("Invalid udp_tunnel parameter\n");
                return -EINVAL;
        }
 
@@ -2174,14 +2020,10 @@ rte_eth_led_on(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_led_on, -ENOTSUP);
-       return ((*dev->dev_ops->dev_led_on)(dev));
+       return (*dev->dev_ops->dev_led_on)(dev);
 }
 
 int
@@ -2189,22 +2031,18 @@ rte_eth_led_off(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_led_off, -ENOTSUP);
-       return ((*dev->dev_ops->dev_led_off)(dev));
+       return (*dev->dev_ops->dev_led_off)(dev);
 }
 
 /*
  * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find
  * an empty spot.
  */
-static inline int
-get_mac_addr_index(uint8_t port_id, struct ether_addr *addr)
+static int
+get_mac_addr_index(uint8_t port_id, const struct ether_addr *addr)
 {
        struct rte_eth_dev_info dev_info;
        struct rte_eth_dev *dev = &rte_eth_devices[port_id];
@@ -2219,7 +2057,7 @@ get_mac_addr_index(uint8_t port_id, struct ether_addr *addr)
        return -1;
 }
 
-static struct ether_addr null_mac_addr = {{0, 0, 0, 0, 0, 0}};
+static const struct ether_addr null_mac_addr;
 
 int
 rte_eth_dev_mac_addr_add(uint8_t port_id, struct ether_addr *addr,
@@ -2229,21 +2067,18 @@ rte_eth_dev_mac_addr_add(uint8_t port_id, struct ether_addr *addr,
        int index;
        uint64_t pool_mask;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_add, -ENOTSUP);
 
        if (is_zero_ether_addr(addr)) {
                PMD_DEBUG_TRACE("port %d: Cannot add NULL MAC address\n",
                        port_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
        if (pool >= ETH_64_POOLS) {
-               PMD_DEBUG_TRACE("pool id must be 0-%d\n",ETH_64_POOLS - 1);
-               return (-EINVAL);
+               PMD_DEBUG_TRACE("pool id must be 0-%d\n", ETH_64_POOLS - 1);
+               return -EINVAL;
        }
 
        index = get_mac_addr_index(port_id, addr);
@@ -2252,12 +2087,12 @@ rte_eth_dev_mac_addr_add(uint8_t port_id, struct ether_addr *addr,
                if (index < 0) {
                        PMD_DEBUG_TRACE("port %d: MAC address array full\n",
                                port_id);
-                       return (-ENOSPC);
+                       return -ENOSPC;
                }
        } else {
                pool_mask = dev->data->mac_pool_sel[index];
 
-               /* Check if both MAC address and pool is alread there, and do nothing */
+               /* Check if both MAC address and pool is already there, and do nothing */
                if (pool_mask & (1ULL << pool))
                        return 0;
        }
@@ -2280,17 +2115,14 @@ rte_eth_dev_mac_addr_remove(uint8_t port_id, struct ether_addr *addr)
        struct rte_eth_dev *dev;
        int index;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_remove, -ENOTSUP);
 
        index = get_mac_addr_index(port_id, addr);
        if (index == 0) {
                PMD_DEBUG_TRACE("port %d: Cannot remove default MAC address\n", port_id);
-               return (-EADDRINUSE);
+               return -EADDRINUSE;
        } else if (index < 0)
                return 0;  /* Do nothing if address wasn't found */
 
@@ -2306,6 +2138,27 @@ rte_eth_dev_mac_addr_remove(uint8_t port_id, struct ether_addr *addr)
        return 0;
 }
 
+int
+rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct ether_addr *addr)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       if (!is_valid_assigned_ether_addr(addr))
+               return -EINVAL;
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_set, -ENOTSUP);
+
+       /* Update default address in NIC data structure */
+       ether_addr_copy(addr, &dev->data->mac_addrs[0]);
+
+       (*dev->dev_ops->mac_addr_set)(dev, addr);
+
+       return 0;
+}
+
 int
 rte_eth_dev_set_vf_rxmode(uint8_t port_id,  uint16_t vf,
                                uint16_t rx_mode, uint8_t on)
@@ -2314,25 +2167,20 @@ rte_eth_dev_set_vf_rxmode(uint8_t port_id,  uint16_t vf,
        struct rte_eth_dev *dev;
        struct rte_eth_dev_info dev_info;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("set VF RX mode:Invalid port_id=%d\n",
-                               port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        rte_eth_dev_info_get(port_id, &dev_info);
 
        num_vfs = dev_info.max_vfs;
-       if (vf > num_vfs)
-       {
+       if (vf > num_vfs) {
                PMD_DEBUG_TRACE("set VF RX mode:invalid VF id %d\n", vf);
-               return (-EINVAL);
+               return -EINVAL;
        }
-       if (rx_mode == 0)
-       {
+
+       if (rx_mode == 0) {
                PMD_DEBUG_TRACE("set VF RX mode:mode mask ca not be zero\n");
-               return (-EINVAL);
+               return -EINVAL;
        }
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_vf_rx_mode, -ENOTSUP);
        return (*dev->dev_ops->set_vf_rx_mode)(dev, vf, rx_mode, on);
@@ -2342,8 +2190,8 @@ rte_eth_dev_set_vf_rxmode(uint8_t port_id,  uint16_t vf,
  * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find
  * an empty spot.
  */
-static inline int
-get_hash_mac_addr_index(uint8_t port_id, struct ether_addr *addr)
+static int
+get_hash_mac_addr_index(uint8_t port_id, const struct ether_addr *addr)
 {
        struct rte_eth_dev_info dev_info;
        struct rte_eth_dev *dev = &rte_eth_devices[port_id];
@@ -2369,17 +2217,13 @@ rte_eth_dev_uc_hash_table_set(uint8_t port_id, struct ether_addr *addr,
        int ret;
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("unicast hash setting:Invalid port_id=%d\n",
-                       port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        if (is_zero_ether_addr(addr)) {
                PMD_DEBUG_TRACE("port %d: Cannot add NULL MAC address\n",
                        port_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        index = get_hash_mac_addr_index(port_id, addr);
@@ -2389,16 +2233,16 @@ rte_eth_dev_uc_hash_table_set(uint8_t port_id, struct ether_addr *addr,
 
        if (index < 0) {
                if (!on) {
-                       PMD_DEBUG_TRACE("port %d: the MAC address was not"
+                       PMD_DEBUG_TRACE("port %d: the MAC address was not "
                                "set in UTA\n", port_id);
-                       return (-EINVAL);
+                       return -EINVAL;
                }
 
                index = get_hash_mac_addr_index(port_id, &null_mac_addr);
                if (index < 0) {
                        PMD_DEBUG_TRACE("port %d: MAC address array full\n",
                                        port_id);
-                       return (-ENOSPC);
+                       return -ENOSPC;
                }
        }
 
@@ -2422,11 +2266,7 @@ rte_eth_dev_uc_all_hash_table_set(uint8_t port_id, uint8_t on)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("unicast hash setting:Invalid port_id=%d\n",
-                       port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
 
@@ -2435,85 +2275,73 @@ rte_eth_dev_uc_all_hash_table_set(uint8_t port_id, uint8_t on)
 }
 
 int
-rte_eth_dev_set_vf_rx(uint8_t port_id,uint16_t vf, uint8_t on)
+rte_eth_dev_set_vf_rx(uint8_t port_id, uint16_t vf, uint8_t on)
 {
        uint16_t num_vfs;
        struct rte_eth_dev *dev;
        struct rte_eth_dev_info dev_info;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        rte_eth_dev_info_get(port_id, &dev_info);
 
        num_vfs = dev_info.max_vfs;
-       if (vf > num_vfs)
-       {
+       if (vf > num_vfs) {
                PMD_DEBUG_TRACE("port %d: invalid vf id\n", port_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_vf_rx, -ENOTSUP);
-       return (*dev->dev_ops->set_vf_rx)(dev, vf,on);
+       return (*dev->dev_ops->set_vf_rx)(dev, vf, on);
 }
 
 int
-rte_eth_dev_set_vf_tx(uint8_t port_id,uint16_t vf, uint8_t on)
+rte_eth_dev_set_vf_tx(uint8_t port_id, uint16_t vf, uint8_t on)
 {
        uint16_t num_vfs;
        struct rte_eth_dev *dev;
        struct rte_eth_dev_info dev_info;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("set pool tx:Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        rte_eth_dev_info_get(port_id, &dev_info);
 
        num_vfs = dev_info.max_vfs;
-       if (vf > num_vfs)
-       {
+       if (vf > num_vfs) {
                PMD_DEBUG_TRACE("set pool tx:invalid pool id=%d\n", vf);
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_vf_tx, -ENOTSUP);
-       return (*dev->dev_ops->set_vf_tx)(dev, vf,on);
+       return (*dev->dev_ops->set_vf_tx)(dev, vf, on);
 }
 
 int
 rte_eth_dev_set_vf_vlan_filter(uint8_t port_id, uint16_t vlan_id,
-                                uint64_t vf_mask,uint8_t vlan_on)
+                              uint64_t vf_mask, uint8_t vlan_on)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("VF VLAN filter:invalid port id=%d\n",
-                               port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
        dev = &rte_eth_devices[port_id];
 
-       if(vlan_id > ETHER_MAX_VLAN_ID)
-       {
+       if (vlan_id > ETHER_MAX_VLAN_ID) {
                PMD_DEBUG_TRACE("VF VLAN filter:invalid VLAN id=%d\n",
                        vlan_id);
-               return (-EINVAL);
+               return -EINVAL;
        }
-       if (vf_mask == 0)
-       {
+
+       if (vf_mask == 0) {
                PMD_DEBUG_TRACE("VF VLAN filter:pool_mask can not be 0\n");
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_vf_vlan_filter, -ENOTSUP);
        return (*dev->dev_ops->set_vf_vlan_filter)(dev, vlan_id,
-                                               vf_mask,vlan_on);
+                                                  vf_mask, vlan_on);
 }
 
 int rte_eth_set_queue_rate_limit(uint8_t port_id, uint16_t queue_idx,
@@ -2523,11 +2351,7 @@ int rte_eth_set_queue_rate_limit(uint8_t port_id, uint16_t queue_idx,
        struct rte_eth_dev_info dev_info;
        struct rte_eth_link link;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("set queue rate limit:invalid port id=%d\n",
-                               port_id);
-               return -ENODEV;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        rte_eth_dev_info_get(port_id, &dev_info);
@@ -2560,11 +2384,7 @@ int rte_eth_set_vf_rate_limit(uint8_t port_id, uint16_t vf, uint16_t tx_rate,
        if (q_msk == 0)
                return 0;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("set VF rate limit:invalid port id=%d\n",
-                               port_id);
-               return -ENODEV;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        rte_eth_dev_info_get(port_id, &dev_info);
@@ -2589,39 +2409,34 @@ int rte_eth_set_vf_rate_limit(uint8_t port_id, uint16_t vf, uint16_t tx_rate,
 
 int
 rte_eth_mirror_rule_set(uint8_t port_id,
-                       struct rte_eth_vmdq_mirror_conf *mirror_conf,
+                       struct rte_eth_mirror_conf *mirror_conf,
                        uint8_t rule_id, uint8_t on)
 {
        struct rte_eth_dev *dev = &rte_eth_devices[port_id];
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       if (mirror_conf->rule_type_mask == 0) {
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       if (mirror_conf->rule_type == 0) {
                PMD_DEBUG_TRACE("mirror rule type can not be 0.\n");
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        if (mirror_conf->dst_pool >= ETH_64_POOLS) {
-               PMD_DEBUG_TRACE("Invalid dst pool, pool id must"
-                       "be 0-%d\n",ETH_64_POOLS - 1);
-               return (-EINVAL);
+               PMD_DEBUG_TRACE("Invalid dst pool, pool id must be 0-%d\n",
+                               ETH_64_POOLS - 1);
+               return -EINVAL;
        }
 
-       if ((mirror_conf->rule_type_mask & ETH_VMDQ_POOL_MIRROR) &&
-               (mirror_conf->pool_mask == 0)) {
-               PMD_DEBUG_TRACE("Invalid mirror pool, pool mask can not"
-                               "be 0.\n");
-               return (-EINVAL);
+       if ((mirror_conf->rule_type & (ETH_MIRROR_VIRTUAL_POOL_UP |
+            ETH_MIRROR_VIRTUAL_POOL_DOWN)) &&
+           (mirror_conf->pool_mask == 0)) {
+               PMD_DEBUG_TRACE("Invalid mirror pool, pool mask can not be 0.\n");
+               return -EINVAL;
        }
 
-       if(rule_id >= ETH_VMDQ_NUM_MIRROR_RULE)
-       {
-               PMD_DEBUG_TRACE("Invalid rule_id, rule_id must be 0-%d\n",
-                       ETH_VMDQ_NUM_MIRROR_RULE - 1);
-               return (-EINVAL);
+       if ((mirror_conf->rule_type & ETH_MIRROR_VLAN) &&
+           mirror_conf->vlan.vlan_mask == 0) {
+               PMD_DEBUG_TRACE("Invalid vlan mask, vlan mask can not be 0.\n");
+               return -EINVAL;
        }
 
        dev = &rte_eth_devices[port_id];
@@ -2635,17 +2450,7 @@ rte_eth_mirror_rule_reset(uint8_t port_id, uint8_t rule_id)
 {
        struct rte_eth_dev *dev = &rte_eth_devices[port_id];
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       if(rule_id >= ETH_VMDQ_NUM_MIRROR_RULE)
-       {
-               PMD_DEBUG_TRACE("Invalid rule_id, rule_id must be 0-%d\n",
-                       ETH_VMDQ_NUM_MIRROR_RULE-1);
-               return (-EINVAL);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mirror_rule_reset, -ENOTSUP);
@@ -2660,10 +2465,8 @@ rte_eth_rx_burst(uint8_t port_id, uint16_t queue_id,
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return 0;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, 0);
+
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->rx_pkt_burst, 0);
        if (queue_id >= dev->data->nb_rx_queues) {
@@ -2680,10 +2483,8 @@ rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id,
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return 0;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, 0);
+
        dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->tx_pkt_burst, 0);
@@ -2700,10 +2501,8 @@ rte_eth_rx_queue_count(uint8_t port_id, uint16_t queue_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return 0;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, 0);
+
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_count, 0);
        return (*dev->dev_ops->rx_queue_count)(dev, queue_id);
@@ -2714,14 +2513,12 @@ rte_eth_rx_descriptor_done(uint8_t port_id, uint16_t queue_id, uint16_t offset)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_descriptor_done, -ENOTSUP);
-       return (*dev->dev_ops->rx_descriptor_done)( \
-               dev->data->rx_queues[queue_id], offset);
+       return (*dev->dev_ops->rx_descriptor_done)(dev->data->rx_queues[queue_id],
+                                                  offset);
 }
 #endif
 
@@ -2734,11 +2531,9 @@ rte_eth_dev_callback_register(uint8_t port_id,
        struct rte_eth_dev_callback *user_cb;
 
        if (!cb_fn)
-               return (-EINVAL);
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-EINVAL);
-       }
+               return -EINVAL;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        rte_spinlock_lock(&rte_eth_dev_cb_lock);
@@ -2752,8 +2547,10 @@ rte_eth_dev_callback_register(uint8_t port_id,
        }
 
        /* create a new callback. */
-       if (user_cb == NULL && (user_cb = rte_zmalloc("INTR_USER_CALLBACK",
-                       sizeof(struct rte_eth_dev_callback), 0)) != NULL) {
+       if (user_cb == NULL)
+               user_cb = rte_zmalloc("INTR_USER_CALLBACK",
+                                     sizeof(struct rte_eth_dev_callback), 0);
+       if (user_cb != NULL) {
                user_cb->cb_fn = cb_fn;
                user_cb->cb_arg = cb_arg;
                user_cb->event = event;
@@ -2761,7 +2558,7 @@ rte_eth_dev_callback_register(uint8_t port_id,
        }
 
        rte_spinlock_unlock(&rte_eth_dev_cb_lock);
-       return ((user_cb == NULL) ? -ENOMEM : 0);
+       return (user_cb == NULL) ? -ENOMEM : 0;
 }
 
 int
@@ -2774,11 +2571,9 @@ rte_eth_dev_callback_unregister(uint8_t port_id,
        struct rte_eth_dev_callback *cb, *next;
 
        if (!cb_fn)
-               return (-EINVAL);
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-EINVAL);
-       }
+               return -EINVAL;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
 
        dev = &rte_eth_devices[port_id];
        rte_spinlock_lock(&rte_eth_dev_cb_lock);
@@ -2806,7 +2601,7 @@ rte_eth_dev_callback_unregister(uint8_t port_id,
        }
 
        rte_spinlock_unlock(&rte_eth_dev_cb_lock);
-       return (ret);
+       return ret;
 }
 
 void
@@ -2830,21 +2625,121 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
        }
        rte_spinlock_unlock(&rte_eth_dev_cb_lock);
 }
-#ifdef RTE_NIC_BYPASS
-int rte_eth_dev_bypass_init(uint8_t port_id)
+
+int
+rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data)
 {
+       uint32_t vec;
        struct rte_eth_dev *dev;
+       struct rte_intr_handle *intr_handle;
+       uint16_t qid;
+       int rc;
 
-       if (port_id >= nb_ports) {
+       if (!rte_eth_dev_is_valid_port(port_id)) {
+               PMD_DEBUG_TRACE("Invalid port_id=%u\n", port_id);
+               return -ENODEV;
+       }
+
+       dev = &rte_eth_devices[port_id];
+       intr_handle = &dev->pci_dev->intr_handle;
+       if (!intr_handle->intr_vec) {
+               PMD_DEBUG_TRACE("RX Intr vector unset\n");
+               return -EPERM;
+       }
+
+       for (qid = 0; qid < dev->data->nb_rx_queues; qid++) {
+               vec = intr_handle->intr_vec[qid];
+               rc = rte_intr_rx_ctl(intr_handle, epfd, op, vec, data);
+               if (rc && rc != -EEXIST) {
+                       PMD_DEBUG_TRACE("p %u q %u rx ctl error"
+                                       " op %d epfd %d vec %u\n",
+                                       port_id, qid, op, epfd, vec);
+               }
+       }
+
+       return 0;
+}
+
+int
+rte_eth_dev_rx_intr_ctl_q(uint8_t port_id, uint16_t queue_id,
+                         int epfd, int op, void *data)
+{
+       uint32_t vec;
+       struct rte_eth_dev *dev;
+       struct rte_intr_handle *intr_handle;
+       int rc;
+
+       if (!rte_eth_dev_is_valid_port(port_id)) {
+               PMD_DEBUG_TRACE("Invalid port_id=%u\n", port_id);
+               return -ENODEV;
+       }
+
+       dev = &rte_eth_devices[port_id];
+       if (queue_id >= dev->data->nb_rx_queues) {
+               PMD_DEBUG_TRACE("Invalid RX queue_id=%u\n", queue_id);
+               return -EINVAL;
+       }
+
+       intr_handle = &dev->pci_dev->intr_handle;
+       if (!intr_handle->intr_vec) {
+               PMD_DEBUG_TRACE("RX Intr vector unset\n");
+               return -EPERM;
+       }
+
+       vec = intr_handle->intr_vec[queue_id];
+       rc = rte_intr_rx_ctl(intr_handle, epfd, op, vec, data);
+       if (rc && rc != -EEXIST) {
+               PMD_DEBUG_TRACE("p %u q %u rx ctl error"
+                               " op %d epfd %d vec %u\n",
+                               port_id, queue_id, op, epfd, vec);
+               return rc;
+       }
+
+       return 0;
+}
+
+int
+rte_eth_dev_rx_intr_enable(uint8_t port_id,
+                          uint16_t queue_id)
+{
+       struct rte_eth_dev *dev;
+
+       if (!rte_eth_dev_is_valid_port(port_id)) {
                PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
+               return -ENODEV;
        }
 
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP);
+       return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id);
+}
+
+int
+rte_eth_dev_rx_intr_disable(uint8_t port_id,
+                           uint16_t queue_id)
+{
+       struct rte_eth_dev *dev;
+
+       if (!rte_eth_dev_is_valid_port(port_id)) {
+               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
+               return -ENODEV;
        }
 
+       dev = &rte_eth_devices[port_id];
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP);
+       return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id);
+}
+
+#ifdef RTE_NIC_BYPASS
+int rte_eth_dev_bypass_init(uint8_t port_id)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_init, -ENOTSUP);
        (*dev->dev_ops->bypass_init)(dev);
        return 0;
@@ -2855,15 +2750,9 @@ rte_eth_dev_bypass_state_show(uint8_t port_id, uint32_t *state)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_state_show, -ENOTSUP);
        (*dev->dev_ops->bypass_state_show)(dev, state);
        return 0;
@@ -2874,16 +2763,9 @@ rte_eth_dev_bypass_state_set(uint8_t port_id, uint32_t *new_state)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
+       dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_state_set, -ENOTSUP);
        (*dev->dev_ops->bypass_state_set)(dev, new_state);
        return 0;
@@ -2894,16 +2776,9 @@ rte_eth_dev_bypass_event_show(uint8_t port_id, uint32_t event, uint32_t *state)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
-
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
+       dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_state_show, -ENOTSUP);
        (*dev->dev_ops->bypass_event_show)(dev, event, state);
        return 0;
@@ -2914,15 +2789,9 @@ rte_eth_dev_bypass_event_store(uint8_t port_id, uint32_t event, uint32_t state)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_event_set, -ENOTSUP);
        (*dev->dev_ops->bypass_event_set)(dev, event, state);
@@ -2934,15 +2803,9 @@ rte_eth_dev_wd_timeout_store(uint8_t port_id, uint32_t timeout)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_wd_timeout_set, -ENOTSUP);
        (*dev->dev_ops->bypass_wd_timeout_set)(dev, timeout);
@@ -2954,15 +2817,9 @@ rte_eth_dev_bypass_ver_show(uint8_t port_id, uint32_t *ver)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_ver_show, -ENOTSUP);
        (*dev->dev_ops->bypass_ver_show)(dev, ver);
@@ -2974,15 +2831,9 @@ rte_eth_dev_bypass_wd_timeout_show(uint8_t port_id, uint32_t *wd_timeout)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_wd_timeout_show, -ENOTSUP);
        (*dev->dev_ops->bypass_wd_timeout_show)(dev, wd_timeout);
@@ -2994,15 +2845,9 @@ rte_eth_dev_bypass_wd_reset(uint8_t port_id)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return (-ENODEV);
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
-       if ((dev= &rte_eth_devices[port_id]) == NULL) {
-               PMD_DEBUG_TRACE("Invalid port device\n");
-               return (-ENODEV);
-       }
+       dev = &rte_eth_devices[port_id];
 
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->bypass_wd_reset, -ENOTSUP);
        (*dev->dev_ops->bypass_wd_reset)(dev);
@@ -3015,10 +2860,7 @@ rte_eth_dev_filter_supported(uint8_t port_id, enum rte_filter_type filter_type)
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
-               PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
-               return -ENODEV;
-       }
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 
        dev = &rte_eth_devices[port_id];
        FUNC_PTR_OR_ERR_RET(*dev->dev_ops->filter_ctrl, -ENOTSUP);
@@ -3032,12 +2874,358 @@ rte_eth_dev_filter_ctrl(uint8_t port_id, enum rte_filter_type filter_type,
 {
        struct rte_eth_dev *dev;
 
-       if (port_id >= nb_ports) {
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->filter_ctrl, -ENOTSUP);
+       return (*dev->dev_ops->filter_ctrl)(dev, filter_type, filter_op, arg);
+}
+
+void *
+rte_eth_add_rx_callback(uint8_t port_id, uint16_t queue_id,
+               rte_rx_callback_fn fn, void *user_param)
+{
+#ifndef RTE_ETHDEV_RXTX_CALLBACKS
+       rte_errno = ENOTSUP;
+       return NULL;
+#endif
+       /* check input parameters */
+       if (!rte_eth_dev_is_valid_port(port_id) || fn == NULL ||
+                   queue_id >= rte_eth_devices[port_id].data->nb_rx_queues) {
+               rte_errno = EINVAL;
+               return NULL;
+       }
+
+       struct rte_eth_rxtx_callback *cb = rte_zmalloc(NULL, sizeof(*cb), 0);
+
+       if (cb == NULL) {
+               rte_errno = ENOMEM;
+               return NULL;
+       }
+
+       cb->fn.rx = fn;
+       cb->param = user_param;
+
+       /* Add the callbacks in fifo order. */
+       struct rte_eth_rxtx_callback *tail =
+               rte_eth_devices[port_id].post_rx_burst_cbs[queue_id];
+
+       if (!tail) {
+               rte_eth_devices[port_id].post_rx_burst_cbs[queue_id] = cb;
+
+       } else {
+               while (tail->next)
+                       tail = tail->next;
+               tail->next = cb;
+       }
+
+       return cb;
+}
+
+void *
+rte_eth_add_tx_callback(uint8_t port_id, uint16_t queue_id,
+               rte_tx_callback_fn fn, void *user_param)
+{
+#ifndef RTE_ETHDEV_RXTX_CALLBACKS
+       rte_errno = ENOTSUP;
+       return NULL;
+#endif
+       /* check input parameters */
+       if (!rte_eth_dev_is_valid_port(port_id) || fn == NULL ||
+                   queue_id >= rte_eth_devices[port_id].data->nb_tx_queues) {
+               rte_errno = EINVAL;
+               return NULL;
+       }
+
+       struct rte_eth_rxtx_callback *cb = rte_zmalloc(NULL, sizeof(*cb), 0);
+
+       if (cb == NULL) {
+               rte_errno = ENOMEM;
+               return NULL;
+       }
+
+       cb->fn.tx = fn;
+       cb->param = user_param;
+
+       /* Add the callbacks in fifo order. */
+       struct rte_eth_rxtx_callback *tail =
+               rte_eth_devices[port_id].pre_tx_burst_cbs[queue_id];
+
+       if (!tail) {
+               rte_eth_devices[port_id].pre_tx_burst_cbs[queue_id] = cb;
+
+       } else {
+               while (tail->next)
+                       tail = tail->next;
+               tail->next = cb;
+       }
+
+       return cb;
+}
+
+int
+rte_eth_remove_rx_callback(uint8_t port_id, uint16_t queue_id,
+               struct rte_eth_rxtx_callback *user_cb)
+{
+#ifndef RTE_ETHDEV_RXTX_CALLBACKS
+       return -ENOTSUP;
+#endif
+       /* Check input parameters. */
+       if (!rte_eth_dev_is_valid_port(port_id) || user_cb == NULL ||
+                   queue_id >= rte_eth_devices[port_id].data->nb_rx_queues) {
+               return -EINVAL;
+       }
+
+       struct rte_eth_dev *dev = &rte_eth_devices[port_id];
+       struct rte_eth_rxtx_callback *cb = dev->post_rx_burst_cbs[queue_id];
+       struct rte_eth_rxtx_callback *prev_cb;
+
+       /* Reset head pointer and remove user cb if first in the list. */
+       if (cb == user_cb) {
+               dev->post_rx_burst_cbs[queue_id] = user_cb->next;
+               return 0;
+       }
+
+       /* Remove the user cb from the callback list. */
+       do {
+               prev_cb = cb;
+               cb = cb->next;
+
+               if (cb == user_cb) {
+                       prev_cb->next = user_cb->next;
+                       return 0;
+               }
+
+       } while (cb != NULL);
+
+       /* Callback wasn't found. */
+       return -EINVAL;
+}
+
+int
+rte_eth_remove_tx_callback(uint8_t port_id, uint16_t queue_id,
+               struct rte_eth_rxtx_callback *user_cb)
+{
+#ifndef RTE_ETHDEV_RXTX_CALLBACKS
+       return -ENOTSUP;
+#endif
+       /* Check input parameters. */
+       if (!rte_eth_dev_is_valid_port(port_id) || user_cb == NULL ||
+                   queue_id >= rte_eth_devices[port_id].data->nb_tx_queues) {
+               return -EINVAL;
+       }
+
+       struct rte_eth_dev *dev = &rte_eth_devices[port_id];
+       struct rte_eth_rxtx_callback *cb = dev->pre_tx_burst_cbs[queue_id];
+       struct rte_eth_rxtx_callback *prev_cb;
+
+       /* Reset head pointer and remove user cb if first in the list. */
+       if (cb == user_cb) {
+               dev->pre_tx_burst_cbs[queue_id] = user_cb->next;
+               return 0;
+       }
+
+       /* Remove the user cb from the callback list. */
+       do {
+               prev_cb = cb;
+               cb = cb->next;
+
+               if (cb == user_cb) {
+                       prev_cb->next = user_cb->next;
+                       return 0;
+               }
+
+       } while (cb != NULL);
+
+       /* Callback wasn't found. */
+       return -EINVAL;
+}
+
+int
+rte_eth_rx_queue_info_get(uint8_t port_id, uint16_t queue_id,
+       struct rte_eth_rxq_info *qinfo)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       if (qinfo == NULL)
+               return -EINVAL;
+
+       dev = &rte_eth_devices[port_id];
+       if (queue_id >= dev->data->nb_rx_queues) {
+               PMD_DEBUG_TRACE("Invalid RX queue_id=%d\n", queue_id);
+               return -EINVAL;
+       }
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rxq_info_get, -ENOTSUP);
+
+       memset(qinfo, 0, sizeof(*qinfo));
+       dev->dev_ops->rxq_info_get(dev, queue_id, qinfo);
+       return 0;
+}
+
+int
+rte_eth_tx_queue_info_get(uint8_t port_id, uint16_t queue_id,
+       struct rte_eth_txq_info *qinfo)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       if (qinfo == NULL)
+               return -EINVAL;
+
+       dev = &rte_eth_devices[port_id];
+       if (queue_id >= dev->data->nb_tx_queues) {
+               PMD_DEBUG_TRACE("Invalid TX queue_id=%d\n", queue_id);
+               return -EINVAL;
+       }
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->txq_info_get, -ENOTSUP);
+
+       memset(qinfo, 0, sizeof(*qinfo));
+       dev->dev_ops->txq_info_get(dev, queue_id, qinfo);
+       return 0;
+}
+
+int
+rte_eth_dev_set_mc_addr_list(uint8_t port_id,
+                            struct ether_addr *mc_addr_set,
+                            uint32_t nb_mc_addr)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_mc_addr_list, -ENOTSUP);
+       return dev->dev_ops->set_mc_addr_list(dev, mc_addr_set, nb_mc_addr);
+}
+
+int
+rte_eth_timesync_enable(uint8_t port_id)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_enable, -ENOTSUP);
+       return (*dev->dev_ops->timesync_enable)(dev);
+}
+
+int
+rte_eth_timesync_disable(uint8_t port_id)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_disable, -ENOTSUP);
+       return (*dev->dev_ops->timesync_disable)(dev);
+}
+
+int
+rte_eth_timesync_read_rx_timestamp(uint8_t port_id, struct timespec *timestamp,
+                                  uint32_t flags)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_read_rx_timestamp, -ENOTSUP);
+       return (*dev->dev_ops->timesync_read_rx_timestamp)(dev, timestamp, flags);
+}
+
+int
+rte_eth_timesync_read_tx_timestamp(uint8_t port_id, struct timespec *timestamp)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+       dev = &rte_eth_devices[port_id];
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->timesync_read_tx_timestamp, -ENOTSUP);
+       return (*dev->dev_ops->timesync_read_tx_timestamp)(dev, timestamp);
+}
+
+int
+rte_eth_dev_get_reg_length(uint8_t port_id)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_reg_length, -ENOTSUP);
+       return (*dev->dev_ops->get_reg_length)(dev);
+}
+
+int
+rte_eth_dev_get_reg_info(uint8_t port_id, struct rte_dev_reg_info *info)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_reg, -ENOTSUP);
+       return (*dev->dev_ops->get_reg)(dev, info);
+}
+
+int
+rte_eth_dev_get_eeprom_length(uint8_t port_id)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_eeprom_length, -ENOTSUP);
+       return (*dev->dev_ops->get_eeprom_length)(dev);
+}
+
+int
+rte_eth_dev_get_eeprom(uint8_t port_id, struct rte_dev_eeprom_info *info)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_eeprom, -ENOTSUP);
+       return (*dev->dev_ops->get_eeprom)(dev, info);
+}
+
+int
+rte_eth_dev_set_eeprom(uint8_t port_id, struct rte_dev_eeprom_info *info)
+{
+       struct rte_eth_dev *dev;
+
+       VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+       dev = &rte_eth_devices[port_id];
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->set_eeprom, -ENOTSUP);
+       return (*dev->dev_ops->set_eeprom)(dev, info);
+}
+
+int
+rte_eth_dev_get_dcb_info(uint8_t port_id,
+                            struct rte_eth_dcb_info *dcb_info)
+{
+       struct rte_eth_dev *dev;
+
+       if (!rte_eth_dev_is_valid_port(port_id)) {
                PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
                return -ENODEV;
        }
 
        dev = &rte_eth_devices[port_id];
-       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->filter_ctrl, -ENOTSUP);
-       return (*dev->dev_ops->filter_ctrl)(dev, filter_type, filter_op, arg);
+       memset(dcb_info, 0, sizeof(struct rte_eth_dcb_info));
+
+       FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_dcb_info, -ENOTSUP);
+       return (*dev->dev_ops->get_dcb_info)(dev, dcb_info);
 }